Re: [lng-odp] [PATCH 2/2] configure: remove dead code
> On 07 Apr 2016, at 16:27, EXT Maxim Uvarov wrote: > > On 04/07/16 16:22, Elo, Matias (Nokia - FI/Espoo) wrote: >>> -Original Message- >>> From: EXT Maxim Uvarov [mailto:maxim.uva...@linaro.org] >>> Sent: Thursday, April 07, 2016 3:46 PM >>> To: lng-odp@lists.linaro.org >>> Cc: Elo, Matias (Nokia - FI/Espoo) >>> Subject: Re: [lng-odp] [PATCH 2/2] configure: remove dead code >>> >>> Matias, if you tested that can you please send Teted-by: ? >>> >>> Maxim. >> Hi Maxim, >> >> I tested the fixed patch suggested by Anders, not the original patch sent by >> Brian. Anders' fixed patch below. >> >> -Matias > I updated and sent v2. Can you please check because I can not reproduce it > here. > Maxim. > I already left the office for today but I'll test it first thing tomorrow morning. -Matias > >> >> diff --git a/configure.ac b/configure.ac >> index d0d3ca6..6361f14 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -172,20 +172,6 @@ AC_ARG_ENABLE([debug], >> ODP_CFLAGS="$ODP_CFLAGS -DODP_DEBUG=$ODP_DEBUG" >> >> ## >> -# Save and set temporary compilation flags >> -## >> -OLD_LDFLAGS=$LDFLAGS >> -OLD_CPPFLAGS=$CPPFLAGS >> -LDFLAGS="$AM_LDFLAGS $LDFLAGS" >> -CPPFLAGS="$AM_CPPFLAGS $CPPFLAGS" >> - >> -## >> -# Restore old saved variables >> -## >> -LDFLAGS=$OLD_LDFLAGS >> -CPPFLAGS=$OLD_CPPFLAGS >> - >> -## >> # Default warning setup >> ## >> ODP_CFLAGS="$ODP_CFLAGS -W -Wall -Werror -Wstrict-prototypes >> -Wmissing-prototypes" >> diff --git a/test/m4/validation.m4 b/test/m4/validation.m4 >> index b137118..d32f675 100644 >> --- a/test/m4/validation.m4 >> +++ b/test/m4/validation.m4 >> @@ -31,6 +31,14 @@ AC_HELP_STRING([--with-cunit-path=DIR path to >> CUnit libs and headers], >> cunit_support=yes],[]) >> >> ## >> +# Save and set temporary compilation flags >> +## >> +OLD_LDFLAGS=$LDFLAGS >> +OLD_CPPFLAGS=$CPPFLAGS >> +LDFLAGS="$AM_LDFLAGS $LDFLAGS" >> +CPPFLAGS="$AM_CPPFLAGS $CPPFLAGS" >> + >> +## >> # Check for CUnit availability >> ## >> if test x$cunit_support = xyes >> @@ -42,3 +50,9 @@ then >> else >> cunit_support=no >> fi >> + >> +## >> +# Restore old saved variables >> +## >> +LDFLAGS=$OLD_LDFLAGS >> +CPPFLAGS=$OLD_CPPFLAGS > ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
Re: [lng-odp] [PATCH 2/2] configure: remove dead code
On 04/07/16 16:22, Elo, Matias (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Maxim Uvarov [mailto:maxim.uva...@linaro.org] Sent: Thursday, April 07, 2016 3:46 PM To: lng-odp@lists.linaro.org Cc: Elo, Matias (Nokia - FI/Espoo) Subject: Re: [lng-odp] [PATCH 2/2] configure: remove dead code Matias, if you tested that can you please send Teted-by: ? Maxim. Hi Maxim, I tested the fixed patch suggested by Anders, not the original patch sent by Brian. Anders' fixed patch below. -Matias I updated and sent v2. Can you please check because I can not reproduce it here. Maxim. diff --git a/configure.ac b/configure.ac index d0d3ca6..6361f14 100644 --- a/configure.ac +++ b/configure.ac @@ -172,20 +172,6 @@ AC_ARG_ENABLE([debug], ODP_CFLAGS="$ODP_CFLAGS -DODP_DEBUG=$ODP_DEBUG" ## -# Save and set temporary compilation flags -## -OLD_LDFLAGS=$LDFLAGS -OLD_CPPFLAGS=$CPPFLAGS -LDFLAGS="$AM_LDFLAGS $LDFLAGS" -CPPFLAGS="$AM_CPPFLAGS $CPPFLAGS" - -## -# Restore old saved variables -## -LDFLAGS=$OLD_LDFLAGS -CPPFLAGS=$OLD_CPPFLAGS - -## # Default warning setup ## ODP_CFLAGS="$ODP_CFLAGS -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes" diff --git a/test/m4/validation.m4 b/test/m4/validation.m4 index b137118..d32f675 100644 --- a/test/m4/validation.m4 +++ b/test/m4/validation.m4 @@ -31,6 +31,14 @@ AC_HELP_STRING([--with-cunit-path=DIR path to CUnit libs and headers], cunit_support=yes],[]) ## +# Save and set temporary compilation flags +## +OLD_LDFLAGS=$LDFLAGS +OLD_CPPFLAGS=$CPPFLAGS +LDFLAGS="$AM_LDFLAGS $LDFLAGS" +CPPFLAGS="$AM_CPPFLAGS $CPPFLAGS" + +## # Check for CUnit availability ## if test x$cunit_support = xyes @@ -42,3 +50,9 @@ then else cunit_support=no fi + +## +# Restore old saved variables +## +LDFLAGS=$OLD_LDFLAGS +CPPFLAGS=$OLD_CPPFLAGS ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
Re: [lng-odp] [PATCH 2/2] configure: remove dead code
> -Original Message- > From: EXT Maxim Uvarov [mailto:maxim.uva...@linaro.org] > Sent: Thursday, April 07, 2016 3:46 PM > To: lng-odp@lists.linaro.org > Cc: Elo, Matias (Nokia - FI/Espoo) > Subject: Re: [lng-odp] [PATCH 2/2] configure: remove dead code > > Matias, if you tested that can you please send Teted-by: ? > > Maxim. Hi Maxim, I tested the fixed patch suggested by Anders, not the original patch sent by Brian. Anders' fixed patch below. -Matias diff --git a/configure.ac b/configure.ac index d0d3ca6..6361f14 100644 --- a/configure.ac +++ b/configure.ac @@ -172,20 +172,6 @@ AC_ARG_ENABLE([debug], ODP_CFLAGS="$ODP_CFLAGS -DODP_DEBUG=$ODP_DEBUG" ## -# Save and set temporary compilation flags -## -OLD_LDFLAGS=$LDFLAGS -OLD_CPPFLAGS=$CPPFLAGS -LDFLAGS="$AM_LDFLAGS $LDFLAGS" -CPPFLAGS="$AM_CPPFLAGS $CPPFLAGS" - -## -# Restore old saved variables -## -LDFLAGS=$OLD_LDFLAGS -CPPFLAGS=$OLD_CPPFLAGS - -## # Default warning setup ## ODP_CFLAGS="$ODP_CFLAGS -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes" diff --git a/test/m4/validation.m4 b/test/m4/validation.m4 index b137118..d32f675 100644 --- a/test/m4/validation.m4 +++ b/test/m4/validation.m4 @@ -31,6 +31,14 @@ AC_HELP_STRING([--with-cunit-path=DIR path to CUnit libs and headers], cunit_support=yes],[]) ## +# Save and set temporary compilation flags +## +OLD_LDFLAGS=$LDFLAGS +OLD_CPPFLAGS=$CPPFLAGS +LDFLAGS="$AM_LDFLAGS $LDFLAGS" +CPPFLAGS="$AM_CPPFLAGS $CPPFLAGS" + +## # Check for CUnit availability ## if test x$cunit_support = xyes @@ -42,3 +50,9 @@ then else cunit_support=no fi + +## +# Restore old saved variables +## +LDFLAGS=$OLD_LDFLAGS +CPPFLAGS=$OLD_CPPFLAGS ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
Re: [lng-odp] [PATCH 2/2] configure: remove dead code
Matias, if you tested that can you please send Teted-by: ? Maxim. On 03/25/16 22:25, Brian Brooks wrote: Remove dead code which potentially acted as a workaround for making AC_CHECK_LIB to work with --with-cunit-path. Signed-off-by: Brian Brooks --- configure.ac | 14 -- 1 file changed, 14 deletions(-) diff --git a/configure.ac b/configure.ac index 4d86817..6c712b9 100644 --- a/configure.ac +++ b/configure.ac @@ -172,20 +172,6 @@ AC_ARG_ENABLE([debug], ODP_CFLAGS="$ODP_CFLAGS -DODP_DEBUG=$ODP_DEBUG" ## -# Save and set temporary compilation flags -## -OLD_LDFLAGS=$LDFLAGS -OLD_CPPFLAGS=$CPPFLAGS -LDFLAGS="$AM_LDFLAGS $LDFLAGS" -CPPFLAGS="$AM_CPPFLAGS $CPPFLAGS" - -## -# Restore old saved variables -## -LDFLAGS=$OLD_LDFLAGS -CPPFLAGS=$OLD_CPPFLAGS - -## # Default warning setup ## ODP_CFLAGS="$ODP_CFLAGS -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes" ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
Re: [lng-odp] [PATCH 2/2] configure: remove dead code
On 25 March 2016 at 20:25, Brian Brooks wrote: > Remove dead code which potentially acted as a workaround for making > AC_CHECK_LIB to work with --with-cunit-path. Workaround you may say that. I would put it, one way to do checks for libs and headers that is in the path or not. > > Signed-off-by: Brian Brooks > --- > configure.ac | 14 -- > 1 file changed, 14 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 4d86817..6c712b9 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -172,20 +172,6 @@ AC_ARG_ENABLE([debug], > ODP_CFLAGS="$ODP_CFLAGS -DODP_DEBUG=$ODP_DEBUG" > > ## > -# Save and set temporary compilation flags > -## > -OLD_LDFLAGS=$LDFLAGS > -OLD_CPPFLAGS=$CPPFLAGS > -LDFLAGS="$AM_LDFLAGS $LDFLAGS" > -CPPFLAGS="$AM_CPPFLAGS $CPPFLAGS" > - > -## > -# Restore old saved variables > -## > -LDFLAGS=$OLD_LDFLAGS > -CPPFLAGS=$OLD_CPPFLAGS > - > -## The code isn't dead just not moved to the correct location. =/ The patch should look like this, see below. Cheers, Anders diff --git a/configure.ac b/configure.ac index d0d3ca6..6361f14 100644 --- a/configure.ac +++ b/configure.ac @@ -172,20 +172,6 @@ AC_ARG_ENABLE([debug], ODP_CFLAGS="$ODP_CFLAGS -DODP_DEBUG=$ODP_DEBUG" ## -# Save and set temporary compilation flags -## -OLD_LDFLAGS=$LDFLAGS -OLD_CPPFLAGS=$CPPFLAGS -LDFLAGS="$AM_LDFLAGS $LDFLAGS" -CPPFLAGS="$AM_CPPFLAGS $CPPFLAGS" - -## -# Restore old saved variables -## -LDFLAGS=$OLD_LDFLAGS -CPPFLAGS=$OLD_CPPFLAGS - -## # Default warning setup ## ODP_CFLAGS="$ODP_CFLAGS -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes" diff --git a/test/m4/validation.m4 b/test/m4/validation.m4 index b137118..d32f675 100644 --- a/test/m4/validation.m4 +++ b/test/m4/validation.m4 @@ -31,6 +31,14 @@ AC_HELP_STRING([--with-cunit-path=DIR path to CUnit libs and headers], cunit_support=yes],[]) ## +# Save and set temporary compilation flags +## +OLD_LDFLAGS=$LDFLAGS +OLD_CPPFLAGS=$CPPFLAGS +LDFLAGS="$AM_LDFLAGS $LDFLAGS" +CPPFLAGS="$AM_CPPFLAGS $CPPFLAGS" + +## # Check for CUnit availability ## if test x$cunit_support = xyes @@ -42,3 +50,9 @@ then else cunit_support=no fi + +## +# Restore old saved variables +## +LDFLAGS=$OLD_LDFLAGS +CPPFLAGS=$OLD_CPPFLAGS ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
