Re: [lng-odp] [PATCH v1] Various pktio fixes

2018-01-17 Thread Github ODP bot
muvarov replied on github web page:

platform/linux-generic/pktio/socket_mmap.c
line 46
@@ -202,6 +202,12 @@ static inline unsigned pkt_mmap_v2_rx(pktio_entry_t 
*pktio_entry,
pkt_buf = (uint8_t *)ppd.raw + ppd.v2->tp_h.tp_mac;
pkt_len = ppd.v2->tp_h.tp_snaplen;
 
+   if (odp_unlikely(pkt_len > pkt_sock->mtu)) {


Comment:
same here.

> muvarov wrote
> maybe to just set error bit and deliver this packet to application?


https://github.com/Linaro/odp/pull/397#discussion_r162014680
updated_at 2018-01-17 10:49:19


Re: [lng-odp] [PATCH v1] Various pktio fixes

2018-01-17 Thread Github ODP bot
muvarov replied on github web page:

platform/linux-generic/pktio/socket.c
line 14
@@ -643,6 +643,10 @@ static int sock_mmsg_recv(pktio_entry_t *pktio_entry, int 
index ODP_UNUSED,
uint16_t pkt_len = msgvec[i].msg_len;
int ret;
 
+   if (odp_unlikely(msgvec[i].msg_hdr.msg_flags & MSG_TRUNC)) {
+   odp_packet_free(pkt);


Comment:
maybe to just set error bit and deliver this packet to application?

https://github.com/Linaro/odp/pull/397#discussion_r162011711
updated_at 2018-01-17 10:36:49