Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-21 Thread Maxim Uvarov 

Merged to master and api-next then.

It looks like at least some clean up patches should be suitable for 
monarch also.


Maxim.

On 07/15/16 06:46, Christophe Milard wrote:

Cannot see them here when doing normal builds. you must be more
accurate on what you do. Moreover, these warnings seems to relate to
helper tests, which this serie doesn't touch.
confused.

/C

On 15 July 2016 at 05:21, Christophe Milard
 wrote:

Hi Maxim,
Warning when doing what?

On 14 July 2016 at 22:31, Maxim Uvarov  wrote:

I see that warnings:

helper/test/Makefile.am:27: warning: variable 'dist_chksum_SOURCES' is
defined but no program or
helper/test/Makefile.am:27: library has 'chksum' as canonical name (possible
typo)
helper/test/Makefile.am:28: warning: variable 'dist_odpthreads_SOURCES' is
defined but no program or
helper/test/Makefile.am:28: library has 'odpthreads' as canonical name
(possible typo)
helper/test/Makefile.am:33: warning: variable 'dist_parse_SOURCES' is
defined but no program or
helper/test/Makefile.am:33: library has 'parse' as canonical name (possible
typo)
helper/test/Makefile.am:32: warning: variable 'dist_process_SOURCES' is
defined but no program or
helper/test/Makefile.am:32: library has 'process' as canonical name
(possible typo)
helper/test/Makefile.am:35: warning: variable 'dist_table_SOURCES' is
defined but no program or
helper/test/Makefile.am:35: library has 'table' as canonical name (possible
typo)
helper/test/Makefile.am:30: warning: variable 'dist_thread_SOURCES' is
defined but no program or
helper/test/Makefile.am:30: library has 'thread' as canonical name (possible
typo)
helper/test/Makefile.am:29: warning: variable 'odpthreads_LDADD' is defined
but no program or
helper/test/Makefile.am:29: library has 'odpthreads' as canonical name
(possible typo)
helper/test/Makefile.am:34: warning: variable 'process_LDADD' is defined but
no program or
helper/test/Makefile.am:34: library has 'process' as canonical name
(possible typo)
helper/test/Makefile.am:31: warning: variable 'thread_LDADD' is defined but
no program or
helper/test/Makefile.am:31: library has 'thread' as canonical name (possible
typo)


Maxim.



On 07/14/16 14:58, Mike Holmes wrote:

For this series:

Reviewd-by: Mike Holmes 

On 14 July 2016 at 01:18, Yi He  wrote:


For this series:

Reviewed-and-tested-by: Yi He 

Best Regards, Yi

On 14 July 2016 at 03:52, Bill Fischofer 
wrote:


For this series:

Reviewed-by: Bill Fischofer 

On Wed, Jul 13, 2016 at 2:50 PM, Christophe Milard <
christophe.mil...@linaro.org> wrote:


since V2:
   -typo fix in implementers guide (Bill)

since V1:
   -new cosmetic fixes in patch 1 (Christophe)
   -fixed patch 2's l2_fwd_run.sh patch (Yi)
   -fixed implementers guide (Bill, Mike)
   -comment regarding patch4 in this cover-letter (Bill).
   -"all-platforms" directory now named "common_plat"

This patch series introduces a test directory restructuration needed
to make room for future new interface tests:

*Patch 1 is just fixing a bunch of cosmetic things to calm down
   check-odp which runs checkpatch on whole moved files. These fixes are
things
   that were not caught before or that were deliberately left as is.
   Still, check-odp cathes a few things: I thing there are meant to be
so
   (volatile usage, camelcase for cunit, and a couple of line > 80 char
   obviously left on purpose (strings)...)

*patch 2 moves down test/validation/* to
test/common_plat/validation/api/*
   hence making room for future new interface validation (and clearly
defining
   the plaform agnostic side).

*Patch 3 moves most of odp/test/platform// to
   odp/test//validation/api/*  hence making room
   for other test groups in platform dependant things (e.g. lauching
   perf test with specific platform parameters...) or making room for
other
   interface tests.

*Patch 4 updates the implementers guide with this new structure

   The structure under odp/test/ becomes:
   +-- m4
   +-- pktio_ipc//specific stuff
   +-- ring //specific stuff
   +-- validation   //the platform specific side of the validation
tests
   +-- api  //Interface name
   +-- pktio//platform specific things for these tests
   +-- shmem

   This could later evolved into:
   +-- m4
   +-- specific //things we cannot agree on :-). Soon empty I
hope!
   +-- pktio_ipc
   +-- ring
   +-- validation   //the platform specific side of the validation
tests
   +-- api  //platform specific things for the validation of
the api
   +-- pktio
   +-- shmem
   +--drv   //platform specific for validation of drv
interface
   +-- pci
   +-- dma



Christophe Milard (4):
validation: diverse cosmetic fixes for checkpatch
validation: moving api validation tests to prepare

Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-15 Thread Maxim Uvarov 

On 07/15/16 11:13, Anders Roxell wrote:

On 2016-07-15 05:46, Christophe Milard wrote:

Cannot see them here when doing normal builds. you must be more
accurate on what you do. Moreover, these warnings seems to relate to
helper tests, which this serie doesn't touch.
confused.

Don't be confused... Maxim commented on the wrong patch. =)

Cheers,
Anders


yes, sorry.  That was for Anders patches. These patches are in the queue 
and will be merged soon.


Maxim.



/C

On 15 July 2016 at 05:21, Christophe Milard
 wrote:

Hi Maxim,
Warning when doing what?

On 14 July 2016 at 22:31, Maxim Uvarov  wrote:

I see that warnings:

helper/test/Makefile.am:27: warning: variable 'dist_chksum_SOURCES' is
defined but no program or
helper/test/Makefile.am:27: library has 'chksum' as canonical name (possible
typo)
helper/test/Makefile.am:28: warning: variable 'dist_odpthreads_SOURCES' is
defined but no program or
helper/test/Makefile.am:28: library has 'odpthreads' as canonical name
(possible typo)
helper/test/Makefile.am:33: warning: variable 'dist_parse_SOURCES' is
defined but no program or
helper/test/Makefile.am:33: library has 'parse' as canonical name (possible
typo)
helper/test/Makefile.am:32: warning: variable 'dist_process_SOURCES' is
defined but no program or
helper/test/Makefile.am:32: library has 'process' as canonical name
(possible typo)
helper/test/Makefile.am:35: warning: variable 'dist_table_SOURCES' is
defined but no program or
helper/test/Makefile.am:35: library has 'table' as canonical name (possible
typo)
helper/test/Makefile.am:30: warning: variable 'dist_thread_SOURCES' is
defined but no program or
helper/test/Makefile.am:30: library has 'thread' as canonical name (possible
typo)
helper/test/Makefile.am:29: warning: variable 'odpthreads_LDADD' is defined
but no program or
helper/test/Makefile.am:29: library has 'odpthreads' as canonical name
(possible typo)
helper/test/Makefile.am:34: warning: variable 'process_LDADD' is defined but
no program or
helper/test/Makefile.am:34: library has 'process' as canonical name
(possible typo)
helper/test/Makefile.am:31: warning: variable 'thread_LDADD' is defined but
no program or
helper/test/Makefile.am:31: library has 'thread' as canonical name (possible
typo)


Maxim.



On 07/14/16 14:58, Mike Holmes wrote:

For this series:

Reviewd-by: Mike Holmes 

On 14 July 2016 at 01:18, Yi He  wrote:


For this series:

Reviewed-and-tested-by: Yi He 

Best Regards, Yi

On 14 July 2016 at 03:52, Bill Fischofer 
wrote:


For this series:

Reviewed-by: Bill Fischofer 

On Wed, Jul 13, 2016 at 2:50 PM, Christophe Milard <
christophe.mil...@linaro.org> wrote:


since V2:
   -typo fix in implementers guide (Bill)

since V1:
   -new cosmetic fixes in patch 1 (Christophe)
   -fixed patch 2's l2_fwd_run.sh patch (Yi)
   -fixed implementers guide (Bill, Mike)
   -comment regarding patch4 in this cover-letter (Bill).
   -"all-platforms" directory now named "common_plat"

This patch series introduces a test directory restructuration needed
to make room for future new interface tests:

*Patch 1 is just fixing a bunch of cosmetic things to calm down
   check-odp which runs checkpatch on whole moved files. These fixes are
things
   that were not caught before or that were deliberately left as is.
   Still, check-odp cathes a few things: I thing there are meant to be
so
   (volatile usage, camelcase for cunit, and a couple of line > 80 char
   obviously left on purpose (strings)...)

*patch 2 moves down test/validation/* to
test/common_plat/validation/api/*
   hence making room for future new interface validation (and clearly
defining
   the plaform agnostic side).

*Patch 3 moves most of odp/test/platform// to
   odp/test//validation/api/*  hence making room
   for other test groups in platform dependant things (e.g. lauching
   perf test with specific platform parameters...) or making room for
other
   interface tests.

*Patch 4 updates the implementers guide with this new structure

   The structure under odp/test/ becomes:
   +-- m4
   +-- pktio_ipc//specific stuff
   +-- ring //specific stuff
   +-- validation   //the platform specific side of the validation
tests
   +-- api  //Interface name
   +-- pktio//platform specific things for these tests
   +-- shmem

   This could later evolved into:
   +-- m4
   +-- specific //things we cannot agree on :-). Soon empty I
hope!
   +-- pktio_ipc
   +-- ring
   +-- validation   //the platform specific side of the validation
tests
   +-- api  //platform specific things for the validation of
the api
   +-- pktio
   +-- shmem
   +--drv   //platform specific for validation of drv
interface
   +-- pci
   +-- dma



Christophe Milard (4):

Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-15 Thread Anders Roxell 
On 2016-07-15 05:46, Christophe Milard wrote:
> Cannot see them here when doing normal builds. you must be more
> accurate on what you do. Moreover, these warnings seems to relate to
> helper tests, which this serie doesn't touch.
> confused.

Don't be confused... Maxim commented on the wrong patch. =)

Cheers,
Anders

> 
> /C
> 
> On 15 July 2016 at 05:21, Christophe Milard
>  wrote:
> > Hi Maxim,
> > Warning when doing what?
> >
> > On 14 July 2016 at 22:31, Maxim Uvarov  wrote:
> >> I see that warnings:
> >>
> >> helper/test/Makefile.am:27: warning: variable 'dist_chksum_SOURCES' is
> >> defined but no program or
> >> helper/test/Makefile.am:27: library has 'chksum' as canonical name 
> >> (possible
> >> typo)
> >> helper/test/Makefile.am:28: warning: variable 'dist_odpthreads_SOURCES' is
> >> defined but no program or
> >> helper/test/Makefile.am:28: library has 'odpthreads' as canonical name
> >> (possible typo)
> >> helper/test/Makefile.am:33: warning: variable 'dist_parse_SOURCES' is
> >> defined but no program or
> >> helper/test/Makefile.am:33: library has 'parse' as canonical name (possible
> >> typo)
> >> helper/test/Makefile.am:32: warning: variable 'dist_process_SOURCES' is
> >> defined but no program or
> >> helper/test/Makefile.am:32: library has 'process' as canonical name
> >> (possible typo)
> >> helper/test/Makefile.am:35: warning: variable 'dist_table_SOURCES' is
> >> defined but no program or
> >> helper/test/Makefile.am:35: library has 'table' as canonical name (possible
> >> typo)
> >> helper/test/Makefile.am:30: warning: variable 'dist_thread_SOURCES' is
> >> defined but no program or
> >> helper/test/Makefile.am:30: library has 'thread' as canonical name 
> >> (possible
> >> typo)
> >> helper/test/Makefile.am:29: warning: variable 'odpthreads_LDADD' is defined
> >> but no program or
> >> helper/test/Makefile.am:29: library has 'odpthreads' as canonical name
> >> (possible typo)
> >> helper/test/Makefile.am:34: warning: variable 'process_LDADD' is defined 
> >> but
> >> no program or
> >> helper/test/Makefile.am:34: library has 'process' as canonical name
> >> (possible typo)
> >> helper/test/Makefile.am:31: warning: variable 'thread_LDADD' is defined but
> >> no program or
> >> helper/test/Makefile.am:31: library has 'thread' as canonical name 
> >> (possible
> >> typo)
> >>
> >>
> >> Maxim.
> >>
> >>
> >>
> >> On 07/14/16 14:58, Mike Holmes wrote:
> >>>
> >>> For this series:
> >>>
> >>> Reviewd-by: Mike Holmes 
> >>>
> >>> On 14 July 2016 at 01:18, Yi He  wrote:
> >>>
>  For this series:
> 
>  Reviewed-and-tested-by: Yi He 
> 
>  Best Regards, Yi
> 
>  On 14 July 2016 at 03:52, Bill Fischofer 
>  wrote:
> 
> > For this series:
> >
> > Reviewed-by: Bill Fischofer 
> >
> > On Wed, Jul 13, 2016 at 2:50 PM, Christophe Milard <
> > christophe.mil...@linaro.org> wrote:
> >
> >> since V2:
> >>   -typo fix in implementers guide (Bill)
> >>
> >> since V1:
> >>   -new cosmetic fixes in patch 1 (Christophe)
> >>   -fixed patch 2's l2_fwd_run.sh patch (Yi)
> >>   -fixed implementers guide (Bill, Mike)
> >>   -comment regarding patch4 in this cover-letter (Bill).
> >>   -"all-platforms" directory now named "common_plat"
> >>
> >> This patch series introduces a test directory restructuration needed
> >> to make room for future new interface tests:
> >>
> >> *Patch 1 is just fixing a bunch of cosmetic things to calm down
> >>   check-odp which runs checkpatch on whole moved files. These fixes are
> >> things
> >>   that were not caught before or that were deliberately left as is.
> >>   Still, check-odp cathes a few things: I thing there are meant to be
> >> so
> >>   (volatile usage, camelcase for cunit, and a couple of line > 80 char
> >>   obviously left on purpose (strings)...)
> >>
> >> *patch 2 moves down test/validation/* to
> >> test/common_plat/validation/api/*
> >>   hence making room for future new interface validation (and clearly
> >> defining
> >>   the plaform agnostic side).
> >>
> >> *Patch 3 moves most of odp/test/platform// to
> >>   odp/test//validation/api/*  hence making room
> >>   for other test groups in platform dependant things (e.g. lauching
> >>   perf test with specific platform parameters...) or making room for
> >> other
> >>   interface tests.
> >>
> >> *Patch 4 updates the implementers guide with this new structure
> >>
> >>   The structure under odp/test/ becomes:
> >>   +-- m4
> >>   +-- pktio_ipc//specific stuff
> >>   +-- ring //specific stuff
> >>   +-- validation   //the platform specific side of the validation
> >> tests
> >>

Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-14 Thread Christophe Milard 
Cannot see them here when doing normal builds. you must be more
accurate on what you do. Moreover, these warnings seems to relate to
helper tests, which this serie doesn't touch.
confused.

/C

On 15 July 2016 at 05:21, Christophe Milard
 wrote:
> Hi Maxim,
> Warning when doing what?
>
> On 14 July 2016 at 22:31, Maxim Uvarov  wrote:
>> I see that warnings:
>>
>> helper/test/Makefile.am:27: warning: variable 'dist_chksum_SOURCES' is
>> defined but no program or
>> helper/test/Makefile.am:27: library has 'chksum' as canonical name (possible
>> typo)
>> helper/test/Makefile.am:28: warning: variable 'dist_odpthreads_SOURCES' is
>> defined but no program or
>> helper/test/Makefile.am:28: library has 'odpthreads' as canonical name
>> (possible typo)
>> helper/test/Makefile.am:33: warning: variable 'dist_parse_SOURCES' is
>> defined but no program or
>> helper/test/Makefile.am:33: library has 'parse' as canonical name (possible
>> typo)
>> helper/test/Makefile.am:32: warning: variable 'dist_process_SOURCES' is
>> defined but no program or
>> helper/test/Makefile.am:32: library has 'process' as canonical name
>> (possible typo)
>> helper/test/Makefile.am:35: warning: variable 'dist_table_SOURCES' is
>> defined but no program or
>> helper/test/Makefile.am:35: library has 'table' as canonical name (possible
>> typo)
>> helper/test/Makefile.am:30: warning: variable 'dist_thread_SOURCES' is
>> defined but no program or
>> helper/test/Makefile.am:30: library has 'thread' as canonical name (possible
>> typo)
>> helper/test/Makefile.am:29: warning: variable 'odpthreads_LDADD' is defined
>> but no program or
>> helper/test/Makefile.am:29: library has 'odpthreads' as canonical name
>> (possible typo)
>> helper/test/Makefile.am:34: warning: variable 'process_LDADD' is defined but
>> no program or
>> helper/test/Makefile.am:34: library has 'process' as canonical name
>> (possible typo)
>> helper/test/Makefile.am:31: warning: variable 'thread_LDADD' is defined but
>> no program or
>> helper/test/Makefile.am:31: library has 'thread' as canonical name (possible
>> typo)
>>
>>
>> Maxim.
>>
>>
>>
>> On 07/14/16 14:58, Mike Holmes wrote:
>>>
>>> For this series:
>>>
>>> Reviewd-by: Mike Holmes 
>>>
>>> On 14 July 2016 at 01:18, Yi He  wrote:
>>>
 For this series:

 Reviewed-and-tested-by: Yi He 

 Best Regards, Yi

 On 14 July 2016 at 03:52, Bill Fischofer 
 wrote:

> For this series:
>
> Reviewed-by: Bill Fischofer 
>
> On Wed, Jul 13, 2016 at 2:50 PM, Christophe Milard <
> christophe.mil...@linaro.org> wrote:
>
>> since V2:
>>   -typo fix in implementers guide (Bill)
>>
>> since V1:
>>   -new cosmetic fixes in patch 1 (Christophe)
>>   -fixed patch 2's l2_fwd_run.sh patch (Yi)
>>   -fixed implementers guide (Bill, Mike)
>>   -comment regarding patch4 in this cover-letter (Bill).
>>   -"all-platforms" directory now named "common_plat"
>>
>> This patch series introduces a test directory restructuration needed
>> to make room for future new interface tests:
>>
>> *Patch 1 is just fixing a bunch of cosmetic things to calm down
>>   check-odp which runs checkpatch on whole moved files. These fixes are
>> things
>>   that were not caught before or that were deliberately left as is.
>>   Still, check-odp cathes a few things: I thing there are meant to be
>> so
>>   (volatile usage, camelcase for cunit, and a couple of line > 80 char
>>   obviously left on purpose (strings)...)
>>
>> *patch 2 moves down test/validation/* to
>> test/common_plat/validation/api/*
>>   hence making room for future new interface validation (and clearly
>> defining
>>   the plaform agnostic side).
>>
>> *Patch 3 moves most of odp/test/platform// to
>>   odp/test//validation/api/*  hence making room
>>   for other test groups in platform dependant things (e.g. lauching
>>   perf test with specific platform parameters...) or making room for
>> other
>>   interface tests.
>>
>> *Patch 4 updates the implementers guide with this new structure
>>
>>   The structure under odp/test/ becomes:
>>   +-- m4
>>   +-- pktio_ipc//specific stuff
>>   +-- ring //specific stuff
>>   +-- validation   //the platform specific side of the validation
>> tests
>>   +-- api  //Interface name
>>   +-- pktio//platform specific things for these tests
>>   +-- shmem
>>
>>   This could later evolved into:
>>   +-- m4
>>   +-- specific //things we cannot agree on :-). Soon empty I
>> hope!
>>   +-- pktio_ipc
>>   +-- ring
>>   +-- validation   //the platform specific side

Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-14 Thread Christophe Milard 
Hi Maxim,
Warning when doing what?

On 14 July 2016 at 22:31, Maxim Uvarov  wrote:
> I see that warnings:
>
> helper/test/Makefile.am:27: warning: variable 'dist_chksum_SOURCES' is
> defined but no program or
> helper/test/Makefile.am:27: library has 'chksum' as canonical name (possible
> typo)
> helper/test/Makefile.am:28: warning: variable 'dist_odpthreads_SOURCES' is
> defined but no program or
> helper/test/Makefile.am:28: library has 'odpthreads' as canonical name
> (possible typo)
> helper/test/Makefile.am:33: warning: variable 'dist_parse_SOURCES' is
> defined but no program or
> helper/test/Makefile.am:33: library has 'parse' as canonical name (possible
> typo)
> helper/test/Makefile.am:32: warning: variable 'dist_process_SOURCES' is
> defined but no program or
> helper/test/Makefile.am:32: library has 'process' as canonical name
> (possible typo)
> helper/test/Makefile.am:35: warning: variable 'dist_table_SOURCES' is
> defined but no program or
> helper/test/Makefile.am:35: library has 'table' as canonical name (possible
> typo)
> helper/test/Makefile.am:30: warning: variable 'dist_thread_SOURCES' is
> defined but no program or
> helper/test/Makefile.am:30: library has 'thread' as canonical name (possible
> typo)
> helper/test/Makefile.am:29: warning: variable 'odpthreads_LDADD' is defined
> but no program or
> helper/test/Makefile.am:29: library has 'odpthreads' as canonical name
> (possible typo)
> helper/test/Makefile.am:34: warning: variable 'process_LDADD' is defined but
> no program or
> helper/test/Makefile.am:34: library has 'process' as canonical name
> (possible typo)
> helper/test/Makefile.am:31: warning: variable 'thread_LDADD' is defined but
> no program or
> helper/test/Makefile.am:31: library has 'thread' as canonical name (possible
> typo)
>
>
> Maxim.
>
>
>
> On 07/14/16 14:58, Mike Holmes wrote:
>>
>> For this series:
>>
>> Reviewd-by: Mike Holmes 
>>
>> On 14 July 2016 at 01:18, Yi He  wrote:
>>
>>> For this series:
>>>
>>> Reviewed-and-tested-by: Yi He 
>>>
>>> Best Regards, Yi
>>>
>>> On 14 July 2016 at 03:52, Bill Fischofer 
>>> wrote:
>>>
 For this series:

 Reviewed-by: Bill Fischofer 

 On Wed, Jul 13, 2016 at 2:50 PM, Christophe Milard <
 christophe.mil...@linaro.org> wrote:

> since V2:
>   -typo fix in implementers guide (Bill)
>
> since V1:
>   -new cosmetic fixes in patch 1 (Christophe)
>   -fixed patch 2's l2_fwd_run.sh patch (Yi)
>   -fixed implementers guide (Bill, Mike)
>   -comment regarding patch4 in this cover-letter (Bill).
>   -"all-platforms" directory now named "common_plat"
>
> This patch series introduces a test directory restructuration needed
> to make room for future new interface tests:
>
> *Patch 1 is just fixing a bunch of cosmetic things to calm down
>   check-odp which runs checkpatch on whole moved files. These fixes are
> things
>   that were not caught before or that were deliberately left as is.
>   Still, check-odp cathes a few things: I thing there are meant to be
> so
>   (volatile usage, camelcase for cunit, and a couple of line > 80 char
>   obviously left on purpose (strings)...)
>
> *patch 2 moves down test/validation/* to
> test/common_plat/validation/api/*
>   hence making room for future new interface validation (and clearly
> defining
>   the plaform agnostic side).
>
> *Patch 3 moves most of odp/test/platform// to
>   odp/test//validation/api/*  hence making room
>   for other test groups in platform dependant things (e.g. lauching
>   perf test with specific platform parameters...) or making room for
> other
>   interface tests.
>
> *Patch 4 updates the implementers guide with this new structure
>
>   The structure under odp/test/ becomes:
>   +-- m4
>   +-- pktio_ipc//specific stuff
>   +-- ring //specific stuff
>   +-- validation   //the platform specific side of the validation
> tests
>   +-- api  //Interface name
>   +-- pktio//platform specific things for these tests
>   +-- shmem
>
>   This could later evolved into:
>   +-- m4
>   +-- specific //things we cannot agree on :-). Soon empty I
> hope!
>   +-- pktio_ipc
>   +-- ring
>   +-- validation   //the platform specific side of the validation
> tests
>   +-- api  //platform specific things for the validation of
> the api
>   +-- pktio
>   +-- shmem
>   +--drv   //platform specific for validation of drv
> interface
>   +-- pci
>   +-- dma
>
>
>
> Christophe Milard (4):
>validation: diverse cosmetic fixes for

Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-14 Thread Maxim Uvarov 

I see that warnings:

helper/test/Makefile.am:27: warning: variable 'dist_chksum_SOURCES' is 
defined but no program or
helper/test/Makefile.am:27: library has 'chksum' as canonical name 
(possible typo)
helper/test/Makefile.am:28: warning: variable 'dist_odpthreads_SOURCES' 
is defined but no program or
helper/test/Makefile.am:28: library has 'odpthreads' as canonical name 
(possible typo)
helper/test/Makefile.am:33: warning: variable 'dist_parse_SOURCES' is 
defined but no program or
helper/test/Makefile.am:33: library has 'parse' as canonical name 
(possible typo)
helper/test/Makefile.am:32: warning: variable 'dist_process_SOURCES' is 
defined but no program or
helper/test/Makefile.am:32: library has 'process' as canonical name 
(possible typo)
helper/test/Makefile.am:35: warning: variable 'dist_table_SOURCES' is 
defined but no program or
helper/test/Makefile.am:35: library has 'table' as canonical name 
(possible typo)
helper/test/Makefile.am:30: warning: variable 'dist_thread_SOURCES' is 
defined but no program or
helper/test/Makefile.am:30: library has 'thread' as canonical name 
(possible typo)
helper/test/Makefile.am:29: warning: variable 'odpthreads_LDADD' is 
defined but no program or
helper/test/Makefile.am:29: library has 'odpthreads' as canonical name 
(possible typo)
helper/test/Makefile.am:34: warning: variable 'process_LDADD' is defined 
but no program or
helper/test/Makefile.am:34: library has 'process' as canonical name 
(possible typo)
helper/test/Makefile.am:31: warning: variable 'thread_LDADD' is defined 
but no program or
helper/test/Makefile.am:31: library has 'thread' as canonical name 
(possible typo)



Maxim.


On 07/14/16 14:58, Mike Holmes wrote:

For this series:

Reviewd-by: Mike Holmes 

On 14 July 2016 at 01:18, Yi He  wrote:


For this series:

Reviewed-and-tested-by: Yi He 

Best Regards, Yi

On 14 July 2016 at 03:52, Bill Fischofer 
wrote:


For this series:

Reviewed-by: Bill Fischofer 

On Wed, Jul 13, 2016 at 2:50 PM, Christophe Milard <
christophe.mil...@linaro.org> wrote:


since V2:
  -typo fix in implementers guide (Bill)

since V1:
  -new cosmetic fixes in patch 1 (Christophe)
  -fixed patch 2's l2_fwd_run.sh patch (Yi)
  -fixed implementers guide (Bill, Mike)
  -comment regarding patch4 in this cover-letter (Bill).
  -"all-platforms" directory now named "common_plat"

This patch series introduces a test directory restructuration needed
to make room for future new interface tests:

*Patch 1 is just fixing a bunch of cosmetic things to calm down
  check-odp which runs checkpatch on whole moved files. These fixes are
things
  that were not caught before or that were deliberately left as is.
  Still, check-odp cathes a few things: I thing there are meant to be so
  (volatile usage, camelcase for cunit, and a couple of line > 80 char
  obviously left on purpose (strings)...)

*patch 2 moves down test/validation/* to
test/common_plat/validation/api/*
  hence making room for future new interface validation (and clearly
defining
  the plaform agnostic side).

*Patch 3 moves most of odp/test/platform// to
  odp/test//validation/api/*  hence making room
  for other test groups in platform dependant things (e.g. lauching
  perf test with specific platform parameters...) or making room for other
  interface tests.

*Patch 4 updates the implementers guide with this new structure

  The structure under odp/test/ becomes:
  +-- m4
  +-- pktio_ipc//specific stuff
  +-- ring //specific stuff
  +-- validation   //the platform specific side of the validation
tests
  +-- api  //Interface name
  +-- pktio//platform specific things for these tests
  +-- shmem

  This could later evolved into:
  +-- m4
  +-- specific //things we cannot agree on :-). Soon empty I hope!
  +-- pktio_ipc
  +-- ring
  +-- validation   //the platform specific side of the validation
tests
  +-- api  //platform specific things for the validation of
the api
  +-- pktio
  +-- shmem
  +--drv   //platform specific for validation of drv interface
  +-- pci
  +-- dma



Christophe Milard (4):
   validation: diverse cosmetic fixes for checkpatch
   validation: moving api validation tests to prepare for new interfaces
   test: restructuring platform-specific tests to allow other interface
   doc: implementers guide update with the new structure

  configure.ac   |   2 +-
  doc/implementers-guide/implementers-guide.adoc | 137
-
  test/Makefile.am   |   6 +-
  test/common_plat/Makefile.am   |   7 ++
  .../{validation => common_plat}/common/Makefile.am |   0
  .../common/mask_common.c   |   0
  .../common/mask_common.h

Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-14 Thread Mike Holmes 
For this series:

Reviewd-by: Mike Holmes 

On 14 July 2016 at 01:18, Yi He  wrote:

> For this series:
>
> Reviewed-and-tested-by: Yi He 
>
> Best Regards, Yi
>
> On 14 July 2016 at 03:52, Bill Fischofer 
> wrote:
>
>> For this series:
>>
>> Reviewed-by: Bill Fischofer 
>>
>> On Wed, Jul 13, 2016 at 2:50 PM, Christophe Milard <
>> christophe.mil...@linaro.org> wrote:
>>
>>> since V2:
>>>  -typo fix in implementers guide (Bill)
>>>
>>> since V1:
>>>  -new cosmetic fixes in patch 1 (Christophe)
>>>  -fixed patch 2's l2_fwd_run.sh patch (Yi)
>>>  -fixed implementers guide (Bill, Mike)
>>>  -comment regarding patch4 in this cover-letter (Bill).
>>>  -"all-platforms" directory now named "common_plat"
>>>
>>> This patch series introduces a test directory restructuration needed
>>> to make room for future new interface tests:
>>>
>>> *Patch 1 is just fixing a bunch of cosmetic things to calm down
>>>  check-odp which runs checkpatch on whole moved files. These fixes are
>>> things
>>>  that were not caught before or that were deliberately left as is.
>>>  Still, check-odp cathes a few things: I thing there are meant to be so
>>>  (volatile usage, camelcase for cunit, and a couple of line > 80 char
>>>  obviously left on purpose (strings)...)
>>>
>>> *patch 2 moves down test/validation/* to
>>> test/common_plat/validation/api/*
>>>  hence making room for future new interface validation (and clearly
>>> defining
>>>  the plaform agnostic side).
>>>
>>> *Patch 3 moves most of odp/test/platform// to
>>>  odp/test//validation/api/*  hence making room
>>>  for other test groups in platform dependant things (e.g. lauching
>>>  perf test with specific platform parameters...) or making room for other
>>>  interface tests.
>>>
>>> *Patch 4 updates the implementers guide with this new structure
>>>
>>>  The structure under odp/test/ becomes:
>>>  +-- m4
>>>  +-- pktio_ipc//specific stuff
>>>  +-- ring //specific stuff
>>>  +-- validation   //the platform specific side of the validation
>>> tests
>>>  +-- api  //Interface name
>>>  +-- pktio//platform specific things for these tests
>>>  +-- shmem
>>>
>>>  This could later evolved into:
>>>  +-- m4
>>>  +-- specific //things we cannot agree on :-). Soon empty I hope!
>>>  +-- pktio_ipc
>>>  +-- ring
>>>  +-- validation   //the platform specific side of the validation
>>> tests
>>>  +-- api  //platform specific things for the validation of
>>> the api
>>>  +-- pktio
>>>  +-- shmem
>>>  +--drv   //platform specific for validation of drv interface
>>>  +-- pci
>>>  +-- dma
>>>
>>>
>>>
>>> Christophe Milard (4):
>>>   validation: diverse cosmetic fixes for checkpatch
>>>   validation: moving api validation tests to prepare for new interfaces
>>>   test: restructuring platform-specific tests to allow other interface
>>>   doc: implementers guide update with the new structure
>>>
>>>  configure.ac   |   2 +-
>>>  doc/implementers-guide/implementers-guide.adoc | 137
>>> -
>>>  test/Makefile.am   |   6 +-
>>>  test/common_plat/Makefile.am   |   7 ++
>>>  .../{validation => common_plat}/common/Makefile.am |   0
>>>  .../common/mask_common.c   |   0
>>>  .../common/mask_common.h   |   0
>>>  .../common/odp_cunit_common.c  |   0
>>>  .../common/odp_cunit_common.h  |   0
>>>  test/common_plat/m4/configure.m4   |  33 +
>>>  test/{ => common_plat}/m4/miscellaneous.m4 |   0
>>>  test/{ => common_plat}/m4/performance.m4   |   0
>>>  test/{ => common_plat}/m4/validation.m4|   0
>>>  test/{ => common_plat}/miscellaneous/.gitignore|   0
>>>  test/{ => common_plat}/miscellaneous/Makefile.am   |   0
>>>  .../miscellaneous/odp_api_from_cpp.cpp |   0
>>>  test/{ => common_plat}/performance/.gitignore  |   0
>>>  test/{ => common_plat}/performance/Makefile.am |   0
>>>  test/{ => common_plat}/performance/odp_crypto.c|   6 +-
>>>  test/{ => common_plat}/performance/odp_l2fwd.c |   1 -
>>>  .../{ => common_plat}/performance/odp_l2fwd_run.sh |  11 +-
>>>  .../{ => common_plat}/performance/odp_pktio_perf.c |  34 ++---
>>>  .../{ => common_plat}/performance/odp_scheduling.c |  19 ++-
>>>  .../performance/odp_scheduling_run.sh  |   0
>>>  test/common_plat/validation/Makefile.am|   3 +
>>>  .../validation/api}/.gitignore |   0
>>>  .../validation/api}/Makefile.am|   2 +-
>>>  .../validation/api}/Makefile.inc   |   4 +-
>>>  .../validation/api}/README |   0
>>>

Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-13 Thread Yi He 
For this series:

Reviewed-and-tested-by: Yi He 

Best Regards, Yi

On 14 July 2016 at 03:52, Bill Fischofer  wrote:

> For this series:
>
> Reviewed-by: Bill Fischofer 
>
> On Wed, Jul 13, 2016 at 2:50 PM, Christophe Milard <
> christophe.mil...@linaro.org> wrote:
>
>> since V2:
>>  -typo fix in implementers guide (Bill)
>>
>> since V1:
>>  -new cosmetic fixes in patch 1 (Christophe)
>>  -fixed patch 2's l2_fwd_run.sh patch (Yi)
>>  -fixed implementers guide (Bill, Mike)
>>  -comment regarding patch4 in this cover-letter (Bill).
>>  -"all-platforms" directory now named "common_plat"
>>
>> This patch series introduces a test directory restructuration needed
>> to make room for future new interface tests:
>>
>> *Patch 1 is just fixing a bunch of cosmetic things to calm down
>>  check-odp which runs checkpatch on whole moved files. These fixes are
>> things
>>  that were not caught before or that were deliberately left as is.
>>  Still, check-odp cathes a few things: I thing there are meant to be so
>>  (volatile usage, camelcase for cunit, and a couple of line > 80 char
>>  obviously left on purpose (strings)...)
>>
>> *patch 2 moves down test/validation/* to test/common_plat/validation/api/*
>>  hence making room for future new interface validation (and clearly
>> defining
>>  the plaform agnostic side).
>>
>> *Patch 3 moves most of odp/test/platform// to
>>  odp/test//validation/api/*  hence making room
>>  for other test groups in platform dependant things (e.g. lauching
>>  perf test with specific platform parameters...) or making room for other
>>  interface tests.
>>
>> *Patch 4 updates the implementers guide with this new structure
>>
>>  The structure under odp/test/ becomes:
>>  +-- m4
>>  +-- pktio_ipc//specific stuff
>>  +-- ring //specific stuff
>>  +-- validation   //the platform specific side of the validation tests
>>  +-- api  //Interface name
>>  +-- pktio//platform specific things for these tests
>>  +-- shmem
>>
>>  This could later evolved into:
>>  +-- m4
>>  +-- specific //things we cannot agree on :-). Soon empty I hope!
>>  +-- pktio_ipc
>>  +-- ring
>>  +-- validation   //the platform specific side of the validation tests
>>  +-- api  //platform specific things for the validation of
>> the api
>>  +-- pktio
>>  +-- shmem
>>  +--drv   //platform specific for validation of drv interface
>>  +-- pci
>>  +-- dma
>>
>>
>>
>> Christophe Milard (4):
>>   validation: diverse cosmetic fixes for checkpatch
>>   validation: moving api validation tests to prepare for new interfaces
>>   test: restructuring platform-specific tests to allow other interface
>>   doc: implementers guide update with the new structure
>>
>>  configure.ac   |   2 +-
>>  doc/implementers-guide/implementers-guide.adoc | 137
>> -
>>  test/Makefile.am   |   6 +-
>>  test/common_plat/Makefile.am   |   7 ++
>>  .../{validation => common_plat}/common/Makefile.am |   0
>>  .../common/mask_common.c   |   0
>>  .../common/mask_common.h   |   0
>>  .../common/odp_cunit_common.c  |   0
>>  .../common/odp_cunit_common.h  |   0
>>  test/common_plat/m4/configure.m4   |  33 +
>>  test/{ => common_plat}/m4/miscellaneous.m4 |   0
>>  test/{ => common_plat}/m4/performance.m4   |   0
>>  test/{ => common_plat}/m4/validation.m4|   0
>>  test/{ => common_plat}/miscellaneous/.gitignore|   0
>>  test/{ => common_plat}/miscellaneous/Makefile.am   |   0
>>  .../miscellaneous/odp_api_from_cpp.cpp |   0
>>  test/{ => common_plat}/performance/.gitignore  |   0
>>  test/{ => common_plat}/performance/Makefile.am |   0
>>  test/{ => common_plat}/performance/odp_crypto.c|   6 +-
>>  test/{ => common_plat}/performance/odp_l2fwd.c |   1 -
>>  .../{ => common_plat}/performance/odp_l2fwd_run.sh |  11 +-
>>  .../{ => common_plat}/performance/odp_pktio_perf.c |  34 ++---
>>  .../{ => common_plat}/performance/odp_scheduling.c |  19 ++-
>>  .../performance/odp_scheduling_run.sh  |   0
>>  test/common_plat/validation/Makefile.am|   3 +
>>  .../validation/api}/.gitignore |   0
>>  .../validation/api}/Makefile.am|   2 +-
>>  .../validation/api}/Makefile.inc   |   4 +-
>>  .../validation/api}/README |   0
>>  .../validation/api}/atomic/.gitignore  |   0
>>  .../validation/api}/atomic/Makefile.am |   0
>>  .../validation/api}/atomic/atomic.c|   0
>>  .../validation/api}/atomic/atomic.h|   0
>>

Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-13 Thread Bill Fischofer 
For this series:

Reviewed-by: Bill Fischofer 

On Wed, Jul 13, 2016 at 2:50 PM, Christophe Milard <
christophe.mil...@linaro.org> wrote:

> since V2:
>  -typo fix in implementers guide (Bill)
>
> since V1:
>  -new cosmetic fixes in patch 1 (Christophe)
>  -fixed patch 2's l2_fwd_run.sh patch (Yi)
>  -fixed implementers guide (Bill, Mike)
>  -comment regarding patch4 in this cover-letter (Bill).
>  -"all-platforms" directory now named "common_plat"
>
> This patch series introduces a test directory restructuration needed
> to make room for future new interface tests:
>
> *Patch 1 is just fixing a bunch of cosmetic things to calm down
>  check-odp which runs checkpatch on whole moved files. These fixes are
> things
>  that were not caught before or that were deliberately left as is.
>  Still, check-odp cathes a few things: I thing there are meant to be so
>  (volatile usage, camelcase for cunit, and a couple of line > 80 char
>  obviously left on purpose (strings)...)
>
> *patch 2 moves down test/validation/* to test/common_plat/validation/api/*
>  hence making room for future new interface validation (and clearly
> defining
>  the plaform agnostic side).
>
> *Patch 3 moves most of odp/test/platform// to
>  odp/test//validation/api/*  hence making room
>  for other test groups in platform dependant things (e.g. lauching
>  perf test with specific platform parameters...) or making room for other
>  interface tests.
>
> *Patch 4 updates the implementers guide with this new structure
>
>  The structure under odp/test/ becomes:
>  +-- m4
>  +-- pktio_ipc//specific stuff
>  +-- ring //specific stuff
>  +-- validation   //the platform specific side of the validation tests
>  +-- api  //Interface name
>  +-- pktio//platform specific things for these tests
>  +-- shmem
>
>  This could later evolved into:
>  +-- m4
>  +-- specific //things we cannot agree on :-). Soon empty I hope!
>  +-- pktio_ipc
>  +-- ring
>  +-- validation   //the platform specific side of the validation tests
>  +-- api  //platform specific things for the validation of the
> api
>  +-- pktio
>  +-- shmem
>  +--drv   //platform specific for validation of drv interface
>  +-- pci
>  +-- dma
>
>
>
> Christophe Milard (4):
>   validation: diverse cosmetic fixes for checkpatch
>   validation: moving api validation tests to prepare for new interfaces
>   test: restructuring platform-specific tests to allow other interface
>   doc: implementers guide update with the new structure
>
>  configure.ac   |   2 +-
>  doc/implementers-guide/implementers-guide.adoc | 137
> -
>  test/Makefile.am   |   6 +-
>  test/common_plat/Makefile.am   |   7 ++
>  .../{validation => common_plat}/common/Makefile.am |   0
>  .../common/mask_common.c   |   0
>  .../common/mask_common.h   |   0
>  .../common/odp_cunit_common.c  |   0
>  .../common/odp_cunit_common.h  |   0
>  test/common_plat/m4/configure.m4   |  33 +
>  test/{ => common_plat}/m4/miscellaneous.m4 |   0
>  test/{ => common_plat}/m4/performance.m4   |   0
>  test/{ => common_plat}/m4/validation.m4|   0
>  test/{ => common_plat}/miscellaneous/.gitignore|   0
>  test/{ => common_plat}/miscellaneous/Makefile.am   |   0
>  .../miscellaneous/odp_api_from_cpp.cpp |   0
>  test/{ => common_plat}/performance/.gitignore  |   0
>  test/{ => common_plat}/performance/Makefile.am |   0
>  test/{ => common_plat}/performance/odp_crypto.c|   6 +-
>  test/{ => common_plat}/performance/odp_l2fwd.c |   1 -
>  .../{ => common_plat}/performance/odp_l2fwd_run.sh |  11 +-
>  .../{ => common_plat}/performance/odp_pktio_perf.c |  34 ++---
>  .../{ => common_plat}/performance/odp_scheduling.c |  19 ++-
>  .../performance/odp_scheduling_run.sh  |   0
>  test/common_plat/validation/Makefile.am|   3 +
>  .../validation/api}/.gitignore |   0
>  .../validation/api}/Makefile.am|   2 +-
>  .../validation/api}/Makefile.inc   |   4 +-
>  .../validation/api}/README |   0
>  .../validation/api}/atomic/.gitignore  |   0
>  .../validation/api}/atomic/Makefile.am |   0
>  .../validation/api}/atomic/atomic.c|   0
>  .../validation/api}/atomic/atomic.h|   0
>  .../validation/api}/atomic/atomic_main.c   |   0
>  .../validation/api}/barrier/.gitignore |   0
>  .../validation/api}/barrier/Makefile.am|   0
>  .../validation/api}/barrier/barrier.c  |   0
>  .../validation/api}/barrier/barrier.h  |   0
>