Re: [lng-odp] pktio: enable_loop

[Bala Manoharan]

Regards,
Bala


On 25 January 2017 at 13:07, Nicolas Morey-Chaisemartin
 wrote:
>
> Le 01/24/2017 à 06:11 PM, Bala Manoharan a écrit :
>> On 24 January 2017 at 22:25, Nicolas Morey-Chaisemartin
>>  wrote:
>>> Just a quick question about the API.
>>>
>>> Bala introduced a patch to check/enable loopback mode on interface.
>>> But the patch adds an "enable_loop" in odp_pktio_config_t and a 
>>> "loop_supported" in odp_pktio_capability_t.
>>>
>>> As there is a odp_pktio_config_t in odp_pktio_capability_t which the API 
>>> describes as:
>>> /** Supported pktio configuration options */
>>>
>>> Why is there a need for the loop_supported field?
>> Yes. The "loop_supported" boolean could be removed from
>> odp_pktio_capability_t struct since there is a redundancy.
>> I will send a patch to remove the same.
>>
>> Regards,
>> Bala
>>>
>>> Nicolas
>>>
>
> OK.
> As this is in Monarch, I guess the expected behaviour there is to have both 
> loop_supported and enable_loop set to the same value when checking 
> capabilities?

Yes. "loop_enable" boolean in odp_pktio_config_t struct should be set
to true to configure a pktio interface in loopback mode while calling
odp_pktio_config() API.

Regards,
Bala
>
> Nicolas

Re: [lng-odp] pktio: enable_loop

[Nicolas Morey-Chaisemartin]

Le 01/24/2017 à 06:11 PM, Bala Manoharan a écrit :
> On 24 January 2017 at 22:25, Nicolas Morey-Chaisemartin
>  wrote:
>> Just a quick question about the API.
>>
>> Bala introduced a patch to check/enable loopback mode on interface.
>> But the patch adds an "enable_loop" in odp_pktio_config_t and a 
>> "loop_supported" in odp_pktio_capability_t.
>>
>> As there is a odp_pktio_config_t in odp_pktio_capability_t which the API 
>> describes as:
>> /** Supported pktio configuration options */
>>
>> Why is there a need for the loop_supported field?
> Yes. The "loop_supported" boolean could be removed from
> odp_pktio_capability_t struct since there is a redundancy.
> I will send a patch to remove the same.
>
> Regards,
> Bala
>>
>> Nicolas
>>

OK.
As this is in Monarch, I guess the expected behaviour there is to have both 
loop_supported and enable_loop set to the same value when checking capabilities?

Nicolas

Re: [lng-odp] pktio: enable_loop

[Bala Manoharan]

On 24 January 2017 at 22:25, Nicolas Morey-Chaisemartin
 wrote:
> Just a quick question about the API.
>
> Bala introduced a patch to check/enable loopback mode on interface.
> But the patch adds an "enable_loop" in odp_pktio_config_t and a 
> "loop_supported" in odp_pktio_capability_t.
>
> As there is a odp_pktio_config_t in odp_pktio_capability_t which the API 
> describes as:
> /** Supported pktio configuration options */
>
> Why is there a need for the loop_supported field?

Yes. The "loop_supported" boolean could be removed from
odp_pktio_capability_t struct since there is a redundancy.
I will send a patch to remove the same.

Regards,
Bala
>
>
> Nicolas
>