Re: Has anyone written a Win32 OutputDebugString appender?
I sent it off but nothing happened, as far as I can see. I don't know how long it takes for these things to get added. I get the impression that it is rather too much for the team to handle :) DP --On 03 August 2004 18:36 +0200 "Thomas Ernst (DiTEC)" <[EMAIL PROTECTED]> wrote: Any news about the Win32 OutputDebugString appender? Michaël CATANZARITI schrieb: Hello Danny, you can send your contribution to log4cxx-dev@logging.apache.org (it's a mailing list) Michael Danny Pike wrote: Michael, I have the code now and it appears to work OK. Can you tell me how to=20 contribute it? I have joined the developer's list (but am continuing the=20 conversation here to preserve the thread) but the web site only talks about = posting discussions and checking modules out. Apologies if it is "common" knowledge but I am a newbie at SourceForge (not = at C++/CVS!) and I can't see anything that explains how you would expect me = to contribute. Do I just email the files to someone? Thanks, DP --On 28 June 2004 22:30 +0200 Micha=EBl CATANZARITI <[EMAIL PROTECTED]> = wrote: Hello Danny, Your contribution is welcome ! Regards, Danny Pike wrote: I have inherited a project from a colleague who was using log4cpp. I wish to port it to log4cxx but there appears to be no appender support for the Windows kernel OutputDebugString() method. I understand that the OutputDebugString appender that was used in log4cpp was contributed by our company and that, if necessary, we can contribute it to the log4cxx project, too. However, before I go down that path, I thought I would ask if anyone has been there before me? DP -- Micha=EBl CATANZARITI log4cxx project manager log4cxx user mailing list: [EMAIL PROTECTED] log4cxx developer mailing list: mailto:[EMAIL PROTECTED]
Re: Has anyone written a Win32 OutputDebugString appender?
On Aug 10, 2004, at 6:11 AM, Danny Pike wrote: I sent it off but nothing happened, as far as I can see. I don't know how long it takes for these things to get added. I get the impression that it is rather too much for the team to handle :) DP I've added a bug for this feature request: http://nagoya.apache.org/jira/browse/LOGCXX-6 I had a couple of issues with the submitted patch, however the idea and general approach appear solid. First, there is not an equivalent appender in log4j, however log4net's equivalent is called OutputDebugStringAppender. To try to keep compatibility between the configuration files, that name should also be used in log4cxx. Michaël may have a better feel for significance of this, but the submitted patch had a personal copyright that was not the same name as the submitter. I'm pretty sure that we want to keep all copyrights in the code assigned to the Apache Software Foundation, but I'm unsure the submission is sufficient basis to rework the copyright assignment. There was a comment that said that all LF's were replaced by CR-LF's, however the code appeared only to change the final one. I did not see an equivalent in the log4net implementation. Could someone elaborate the on scenarios (log requests and debuggers) that motivated the replacement? With the proposed implementation, I assume that if a configuration file with a OutputDebugStringAppender would fail to load on a non-Windows platform. I'm not sure if that is a desirable behavior. An alternative would be for OutputDebugStringAppender to do nothing on platforms that do not support an equivalent functionality. Probably easier for Michaël or I to do a clean implementation since it is fairly trival, basically render the logging event to a string and call OutputDebugString.
Re: Has anyone written a Win32 OutputDebugString appender?
OK, I'm sure all of that is fine. Les wrote one for log4cplus and I changed the file when we moved over to log4cxx. He asked me to submit it for him because he's so busy at the moment. The amount of "clever" code in there is almost zero, so I don't care what is done or how it is altered, I just the need the facility in order to be able to use log4cxx at all! OutputDebugString is a key feature for us. :) DP --On 10 August 2004 10:55 -0500 Curt Arnold <[EMAIL PROTECTED]> wrote: On Aug 10, 2004, at 6:11 AM, Danny Pike wrote: I sent it off but nothing happened, as far as I can see. I don't know how long it takes for these things to get added. I get the impression that it is rather too much for the team to handle :) DP I've added a bug for this feature request: http://nagoya.apache.org/jira/browse/LOGCXX-6 I had a couple of issues with the submitted patch, however the idea and general approach appear solid. First, there is not an equivalent appender in log4j, however log4net's equivalent is called OutputDebugStringAppender. To try to keep compatibility between the configuration files, that name should also be used in log4cxx. Michaël may have a better feel for significance of this, but the submitted patch had a personal copyright that was not the same name as the submitter. I'm pretty sure that we want to keep all copyrights in the code assigned to the Apache Software Foundation, but I'm unsure the submission is sufficient basis to rework the copyright assignment. There was a comment that said that all LF's were replaced by CR-LF's, however the code appeared only to change the final one. I did not see an equivalent in the log4net implementation. Could someone elaborate the on scenarios (log requests and debuggers) that motivated the replacement? With the proposed implementation, I assume that if a configuration file with a OutputDebugStringAppender would fail to load on a non-Windows platform. I'm not sure if that is a desirable behavior. An alternative would be for OutputDebugStringAppender to do nothing on platforms that do not support an equivalent functionality. Probably easier for Michaël or I to do a clean implementation since it is fairly trival, basically render the logging event to a string and call OutputDebugString.
