DO NOT REPLY [Bug 52094] New: Add InputStream API to OptionConverter.selectAndConfigure and Configurator
https://issues.apache.org/bugzilla/show_bug.cgi?id=52094 Bug #: 52094 Summary: Add InputStream API to OptionConverter.selectAndConfigure and Configurator Product: Log4j Version: 1.2 Platform: PC Status: NEW Severity: normal Priority: P2 Component: Configurator AssignedTo: log4j-dev@logging.apache.org ReportedBy: ggreg...@seagullsw.com Classification: Unclassified Add the ability to Configure from an InputStream, not just a URL. The goal is to be able to configure from an Apache Commons VFS FileObject. The only way to get the contents of a FileObject is to say getContents().getInputStream() We currently use this API: org.apache.log4j.helpers.OptionConverter.selectAndConfigure(URL, String, LoggerRepository) Which in turn calls the interface: org.apache.log4j.spi.Configurator.doConfigure(URL, LoggerRepository) There is no InputStream version of the API. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Created] (LOG4J2-55) Configure from an InputStream
Configure from an InputStream - Key: LOG4J2-55 URL: https://issues.apache.org/jira/browse/LOG4J2-55 Project: Log4j 2 Issue Type: Improvement Components: Configurators Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_29, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_29\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory This issue is the version 2 side of https://issues.apache.org/bugzilla/show_bug.cgi?id=52094 Add the ability to Configure from an InputStream, not just a URL. The goal is to be able to configure from an Apache Commons VFS FileObject. The only way to get the contents of a FileObject is to say getContents().getInputStream() -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
DO NOT REPLY [Bug 52095] New: Inconsistent Javadoc comment in addAppender(Appender) in org.apache.log4j.AsyncAppender
https://issues.apache.org/bugzilla/show_bug.cgi?id=52095
Bug #: 52095
Summary: Inconsistent Javadoc comment in addAppender(Appender)
in org.apache.log4j.AsyncAppender
Product: Log4j
Version: 1.2
Platform: PC
Status: NEW
Severity: normal
Priority: P2
Component: Appender
AssignedTo: log4j-dev@logging.apache.org
ReportedBy: st...@illinois.edu
Classification: Unclassified
The Javadoc comment below states that the parameter appender may not be null:
/**
* Add appender.
*
* @param newAppender appender to add, may not be null.
*/
public void addAppender(final Appender newAppender) {
synchronized (appenders) {
appenders.addAppender(newAppender);
}
}
However, the called method
org.apache.log4j.helpers.AppenderAttachableImpl#addAppender(Appender) has an
explicit check for null and will ignore it, returning normally without any
exception being thrown. Also, the Javadoc for the called method does not
mention null.
Suggested Fixes:
1. Make the Javadoc in org.apache.log4j.AsyncAppender#addAppender(Appender)
consistent with the Javadoc in
org.apache.log4j.helpers.AppenderAttachableImpl#addAppender(Appender) (note
that the second in should be it in both):
/**
* Attach an appender. If the appender is already in the list in [sic] won't
be added.
*
* @param newAppender appender to add
*/
public void addAppender(final Appender newAppender) {
or
2. Simply remove , may not be null from the Javadoc in
org.apache.log4j.AsyncAppender#addAppender(Appender).
or
3. Change , may not be null to , null will be ignored.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
DO NOT REPLY [Bug 52095] Inconsistent Javadoc comment in addAppender(Appender) in org.apache.log4j.AsyncAppender
https://issues.apache.org/bugzilla/show_bug.cgi?id=52095 Shin Hwei Tan st...@illinois.edu changed: What|Removed |Added OS/Version||All -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
