[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15441354#comment-15441354 ] Mikael Ståldal commented on LOG4J2-1181: OK, merged to master now. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1, 2.6.2 >Reporter: Mikael Ståldal >Assignee: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15441327#comment-15441327 ] Remko Popma commented on LOG4J2-1181: - By the way, I don't think there is any reason not to merge this branch into master; these are new modules so there's no impact on existing functionality, and the next release will not be a bugfix release. We can review further and polish on master. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1, 2.6.2 >Reporter: Mikael Ståldal >Assignee: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15441158#comment-15441158 ] Mikael Ståldal commented on LOG4J2-1181: Thanks for reviewing. The TODOs are due to that there is no way to do the flow trace logging in {{ExtendedLogger}} without ifEnabled check (as you can do with regular logging using the {{logMessage}} method). I am not sure if we should try to do something about it, or just ignore it. I fixed the documentation, does it look better? > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1, 2.6.2 >Reporter: Mikael Ståldal >Assignee: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15441054#comment-15441054 ] Remko Popma commented on LOG4J2-1181: - The LoggerMacro classes for both Scala versions have a TODO (should not do ifEnabled check). Documentation looks ok, except that the example code is indented too much in the resulting HTML. There was some talk of marking these modules as beta. I am not sure how that would work. Perhaps edit the {{pom.xml}} of these modules to add {{-beta}} to the version? This is currently not done yet. Otherwise I am fine with merging this into master. (I would not want to make a beta release for 2.7 as a whole, by the way.) > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353024#comment-15353024 ] Matt Sicker commented on LOG4J2-1181: - Hopefully we can do 2.6.2 really soon, then we can start adding in our features for 2.7. I think we can get 2.7 done within a couple months as we don't have any epics to implement this time. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352589#comment-15352589 ] Mikael Ståldal commented on LOG4J2-1181: I am not comfortable with making a final release, but I would like to do a public beta quite soon. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352587#comment-15352587 ] Mikael Ståldal commented on LOG4J2-1181: When do we think 2.7 will happen? > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351215#comment-15351215 ] Ralph Goers commented on LOG4J2-1181: - I wouldn't do it as part of 2.6.2, but it would make sense to have it in 2.7. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351099#comment-15351099 ] Matt Sicker commented on LOG4J2-1181: - That depends on how comfortable you are with releasing it. You're on the PMC now don't forget ;) > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350870#comment-15350870 ] Mikael Ståldal commented on LOG4J2-1181: Would it be possible to release a beta of this Scala API as part of the next release? [~ralphgoers]? > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350716#comment-15350716 ] Mikael Ståldal commented on LOG4J2-1181: The string is parsed at compile time, and transformed into string construction with a {{StringBuilder}}. Probably not unlike string concatenation in Java. However, I think it will not be garbage free, since a new {{StringBuilder}} is created each time. But I don't think it is worthwhile to strive for garbage freeness in Scala since Scala is currently not very good at that in general. If you really need garbage freeness, you would probably not use Scala in the first place. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350693#comment-15350693 ] Mikael Ståldal commented on LOG4J2-1181: This is not my idea originally, I got it from here: https://github.com/typesafehub/scala-logging > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350689#comment-15350689 ] Remko Popma commented on LOG4J2-1181: - Copying the string interpolation example here to make discussion easier: (Note: it may be good to expand the documentation to show the interface of the {{user}} object's type.) {code} logger.debug(s"Logging in user ${user.getName} with birthday ${user.calcBirthday}") {code} >From a usability point of view, I like this even better than the Log4j >parameterized message syntax: in the Scala example it is not possible to >mistakenly have more parameter placeholders than values, they are always in >sync. It would be interesting to see some performance numbers, but I imagine >that the Scala language does String interpolation efficiently. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350672#comment-15350672 ] Remko Popma commented on LOG4J2-1181: - Not sure if it will help, but it is a fairly safe assumption that {{isEnabled}} is very, very cheap. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350664#comment-15350664 ] Mikael Ståldal commented on LOG4J2-1181: Implementing flow tracing properly is a bit tricky since a lot of the logic is in {{AbstractLogger}} which I have no access to. Currently I just call through to the methods in the wrapped {{Logger}}, but then the location info will be wrong, and I cannot make macros without having double {{isEnabled}} check. It would be nice if we could expose the flow tracing in {{AbstractLogger}}, or maybe break it out from there and put it in a new class. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350662#comment-15350662 ] Mikael Ståldal commented on LOG4J2-1181: I am looking at how to do flow tracing in the Scala API. Does this look good? (Quick Scala intro: types goes after variables/methods/parameters, {{Unit}} is like void in Java, {{AnyRef}} is like Object in Java, the {{*}} is varargs) {code} def traceEntry(): EntryMessage def traceEntry(params: Any*): EntryMessage def traceEntry(message: Message): EntryMessage def traceExit(): Unit def traceExit[R](result: R): R def traceExit(entryMessage: EntryMessage): Unit def traceExit[R](entryMessage: EntryMessage, result: R): R def traceExit[R](message: Message, result: R): R {code} > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350655#comment-15350655 ] Mikael Ståldal commented on LOG4J2-1181: Implementing support for parametrized messages is tricky in Scala since Scala cannot properly handle the var-args overloads in {{Logger}} and {{MessageFactory}}. Given that you can use string interpolations, how important is it to be able to use Log4j parameters? https://github.com/apache/logging-log4j2/blob/LOG4J-1181/src/site/xdoc/manual/scala-api.xml > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329055#comment-15329055 ] Mikael Ståldal commented on LOG4J2-1181: OK, then I'll do it like that. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328617#comment-15328617 ] Remko Popma commented on LOG4J2-1181: - No I don't think so. We considered that when the CharSequence API was proposed in LOG4J2-1326, but for the vararg methods the first element is usually a string literal in user code. This is for the single-param method. Knowing what we knew then, and aiming to preserve BC, I don't see how we could have done things differently. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328616#comment-15328616 ] Remko Popma commented on LOG4J2-1181: - No I don't think so. We considered that when the CharSequence API was proposed in LOG4J2-1326, but for the vararg methods the first element is usually a string literal in user code. This is for the single-param method. Knowing what we knew then, and aiming to preserve BC, I don't see how we could have done things differently. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328471#comment-15328471 ] Gary Gregory commented on LOG4J2-1181: -- Did we blow it when we unrolled all of the Logger APIs using {{String}} instead of using {{CharSequence}}? > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328462#comment-15328462 ] Remko Popma commented on LOG4J2-1181: - For the Scala API it would make sense to have only CharSequence (in addition to Message and Object). I envy you that backwards compatibility is not an issue. :-) I can't see any issue with all CharSequences, including regular Strings, going through MessageFactory2.newMessage(CharSequence). > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328217#comment-15328217 ] Matt Sicker commented on LOG4J2-1181: - I think it would make most sense to use the least amount of methods necessary. Otherwise you kind of get overwhelmed by IDE autocomplete or even the javadocs/scaladocs. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328081#comment-15328081 ] Mikael Ståldal commented on LOG4J2-1181: I am trying to keep this updated with new stuff in 2.6. Now, the Java Logger interface have four overloads: {{Message}}, {{String}}, {{CharSequence}} and {{Object}}. The {{CharSequence}} overload was added in 2.6, and it was necessary to keep the {{String}} overload to maintain binary compatibility. Is there any other reason for having both {{String}} and {{CharSequence}}, or would it make sense to have only {{CharSequence}} (in addition to {{Message}} and {{Object}}) in the Scala API? Backwards compatibility is not an issue since this is not public yet. That would mean that all CharSequences, including regular Strings, would go through {{MessageFactory2.newMessage(CharSequence)}}. Would there be any drawbacks with that? [~rem...@yahoo.com], what do you think? > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1, 2.5, 2.6, 2.6.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15064435#comment-15064435 ] Gary Gregory commented on LOG4J2-1181: -- I think we are talking about cutting a beta soon. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15064367#comment-15064367 ] Michael Allman commented on LOG4J2-1181: Hi Guys, I'm really interested in this work. Can you advise on where we are in the process of integrating this into master and a release? Cheers, Michael > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011287#comment-15011287 ] Mikael Ståldal commented on LOG4J2-1181: So, what do you think about it now? > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996791#comment-14996791 ] Mikael Ståldal commented on LOG4J2-1181: I have added some documentation now. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14995813#comment-14995813 ] Gary Gregory commented on LOG4J2-1181: -- And by "we", I mean Mikael ;-) > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14995811#comment-14995811 ] Gary Gregory commented on LOG4J2-1181: -- Where are we on this? > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987796#comment-14987796 ] Gary Gregory commented on LOG4J2-1181: -- Yes, examples are key IMO, IOW we need to update the manual. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986960#comment-14986960 ] Mikael Ståldal commented on LOG4J2-1181: It is called {{Logging}} since it is used in another way. I guess we need some example how to use it: {code} class MyClass extends Logging { def doStuff(): Unit = { logger.info("doing stuff") } } {code} or {code} class MyClass extends OtherClass with Logging { def doStuff(): Unit = { logger.info("doing stuff") } } {code} > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986952#comment-14986952 ] Mikael Ståldal commented on LOG4J2-1181: Yes, we have a {{Logger}} class in both. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986944#comment-14986944 ] Mikael Ståldal commented on LOG4J2-1181: I know, I made a mistake when creating this branch. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986943#comment-14986943 ] Mikael Ståldal commented on LOG4J2-1181: I know about the branch naming, I made a mistake when creating this branch. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985692#comment-14985692 ] Gary Gregory commented on LOG4J2-1181: -- Hi, {quote} Logging is a wrapper for LogManager. There is no test for it since it is very trivial. {quote} Isn't that confusing? Why is it not also called {{LogManager}}? You you explain or point to a write up on if/when/how to wrap Java libs? > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985680#comment-14985680 ] Gary Gregory commented on LOG4J2-1181: -- The Scala package is {[org.apache.logging.log4j.scala}} while the Java package is {{org.apache.logging.log4j}}. That is to avoid class name clashes, right? > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985670#comment-14985670 ] Gary Gregory commented on LOG4J2-1181: -- Minor housekeeping detail: You'll notice that the other branches are called {{LOG4J2-xxx}} instead of {{LOG4J-xxx}}. Gary > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985325#comment-14985325 ] Gary Gregory commented on LOG4J2-1181: -- ... then, if we need a {{log4j-core-scala_version}}, and so on, the names will make sense. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985305#comment-14985305 ] Mikael Ståldal commented on LOG4J2-1181: Seems reasonable to rename to log4j-api-scala_*version*. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985297#comment-14985297 ] Mikael Ståldal commented on LOG4J2-1181: {{Logging}} is a wrapper for {{LogManager}}. There is no test for it since it is very trivial. I don't think we need wrappers for {{MarkerManager}} and other stuff, you can just use them directly from Scala. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985289#comment-14985289 ] Mikael Ståldal commented on LOG4J2-1181: I have never used Eclipse with Scala, I use IntelliJ IDEA. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984861#comment-14984861 ] Gary Gregory commented on LOG4J2-1181: -- Mikael, Thank you for getting this started. I was able to run the tests OK for the 2.11 projects in Eclipse set up with m2e. For the 2.10 project I get: {noformat} Description ResourcePathLocationType More than one scala library found in the build path (C:/eclipse/4.5/plugins/org.scala-lang.scala-library_2.11.7.v20150622-112736-1fbce4612c.jar, C:/Users/ggregory/.m2/repository/org/scala-lang/scala-library/2.10.6/scala-library-2.10.6.jar).At least one has an incompatible version. Please update the project build path so it contains only one compatible scala library.log4j-scala_2.10 Unknown Scala Classpath Problem scalatest_2.10-2.2.5.jar of log4j-scala_2.10 build path is cross-compiled with an incompatible version of Scala (2.10.0). In case this report is mistaken, this check can be disabled in the compiler preference page. log4j-scala_2.10 Unknown Scala Version Problem {noformat} How can we get this to work in Eclipse? Both projects test fine from the Maven command line, so that's good. I'm not sure I understand the goal here though. I only see a {{LoggerTest}} class. Don't we want to provide wrappers for at least {{LogManager}}, {{Logger}}, {{MarkerManager}}, basically all of the "main" {{log4j-api}} classes. I'm starting to think that the modules should be called {{log4j-api-scala_2.10}} and {{log4j-api-scala_2.11}} to reflect that we are dealing with the Scala version of {{log4j-api}}. I'm not a Scala guru yet, so I'll appreciate any insights here ;-) > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14982494#comment-14982494 ] Mikael Ståldal commented on LOG4J2-1181: I think it looks good now. What do you think? > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
[jira] [Commented] (LOG4J2-1181) Scala wrapper for Log4j 2 API
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14978777#comment-14978777 ] Mikael Ståldal commented on LOG4J2-1181: Work in progress in Git branch LOG4J-1181. > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-1181 > URL: https://issues.apache.org/jira/browse/LOG4J2-1181 > Project: Log4j 2 > Issue Type: New Feature > Components: API >Affects Versions: 2.4.1 >Reporter: Mikael Ståldal > > Scala wrapper for Log4j 2 API which makes use of Scala features like macros > and string interpolation. > Inspired from [Typesafe's Scala > Logging|https://github.com/typesafehub/scala-logging] but should use Log4j 2 > directly and expose its features. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org