[jira] [Updated] (LOG4J2-621) Pattern To Drop First X Package Parts

2016-04-21 Thread Kamal Mettananda (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kamal Mettananda updated LOG4J2-621:

Attachment: LOG4J2-621_01.patch

Hi all

I analysed the code and the change is required around the 
org.apache.logging.log4j.core.pattern.NameAbbreviator.

So I implemented test cases for the existing feature where the parts are 
retained from the end of the names, Then implemented test cases for the new 
feature where the parts are dropped from the front of the names.

To provide this feature, I have implemented a new class named 
org.apache.logging.log4j.core.pattern.NameAbbreviator.DropFirstElementsAbbreviator
 which will analyse the name and drop from the start of the name using "." 
separator.

All the test cases are passing 100%. 

I have attached that feature as a patch ([^LOG4J2-621_01.patch]) including test 
cases. 

Could you please review that and provide your thoughts?

Thanks

> Pattern To Drop First X Package Parts
> -
>
> Key: LOG4J2-621
> URL: https://issues.apache.org/jira/browse/LOG4J2-621
> Project: Log4j 2
>  Issue Type: Wish
>  Components: Layouts
>Affects Versions: 2.0-rc1
>Reporter: Lee Theobald
>Priority: Trivial
> Attachments: LOG4J2-621_01.patch
>
>
> Currently you can have a pattern that will print out the last X parts of you 
> package.  So if my package was {{uk.co.ltheobald.foo.bar}}, then using 
> {{%logger\{2\}}} will print {{foo.bar}}.  But when I have a number of 
> different package levels, this becomes less useful (in my opinion).
> What I'd find more useful is the inverse where I can ditch the first X parts. 
>  Something like {{%logger\{-3\}}} for example.  That way I'd end up with:
> {{uk.co.ltheobald.Main logging}} as {{Main}}
> {{uk.co.ltheobald.foo.MyClass}} logging as {{foo.MyClass}}
> {{uk.co.ltheobald.foo.bar.MyOtherClass}} logging as {{foo.bar.MyOtherClass}}
> Removing from the start of the logger name allows me to consistently trim off 
> package names that I know are always the same.  I'll see if I can produce a 
> code example for this if I get time but I wanted to log it in the meanwhile.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Updated] (LOG4J2-621) Pattern To Drop First X Package Parts

2014-04-29 Thread Lee Theobald (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lee Theobald updated LOG4J2-621:


Description: 
Currently you can have a pattern that will print out the last X parts of you 
package.  So if my package was {{uk.co.ltheobald.foo.bar}}, then using 
`%logger{2}` will print {{foo.bar}}.  But when I have a number of different 
package levels, this becomes less useful (in my opinion).

What I'd find more useful is the inverse where I can ditch the first X parts.  
Something like `%logger{-3}` for example.  That way I'd end up with:

{{uk.co.ltheobald.Main logging}} as {{Main}}
{{uk.co.ltheobald.foo.MyClass}} logging as {{foo.MyClass}}
{{uk.co.ltheobald.foo.bar.MyOtherClass}} logging as {{foo.bar.MyOtherClass}}

Removing from the start of the logger name allows me to consistently trim off 
package names that I know are always the same.  I'll see if I can produce a 
code example for this if I get time but I wanted to log it in the meanwhile.

  was:
Currently you can have a pattern that will print out the last X parts of you 
package.  So if my package was {{uk.co.ltheobald.foo.bar}}, then using 
{{%logger{2} }} will print {{foo.bar}}.  But when I have a number of different 
package levels, this becomes less useful (in my opinion).

What I'd find more useful is the inverse where I can ditch the first X parts.  
Something like {{%logger{-3}}} for example.  That way I'd end up with:

{{uk.co.ltheobald.Main logging}} as {{Main}}
{{uk.co.ltheobald.foo.MyClass}} logging as {{foo.MyClass}}
{{uk.co.ltheobald.foo.bar.MyOtherClass}} logging as {{foo.bar.MyOtherClass}}

Removing from the start of the logger name allows me to consistently trim off 
package names that I know are always the same.  I'll see if I can produce a 
code example for this if I get time but I wanted to log it in the meanwhile.


> Pattern To Drop First X Package Parts
> -
>
> Key: LOG4J2-621
> URL: https://issues.apache.org/jira/browse/LOG4J2-621
> Project: Log4j 2
>  Issue Type: Wish
>  Components: Layouts
>Affects Versions: 2.0-rc1
>Reporter: Lee Theobald
>Priority: Trivial
>
> Currently you can have a pattern that will print out the last X parts of you 
> package.  So if my package was {{uk.co.ltheobald.foo.bar}}, then using 
> `%logger{2}` will print {{foo.bar}}.  But when I have a number of different 
> package levels, this becomes less useful (in my opinion).
> What I'd find more useful is the inverse where I can ditch the first X parts. 
>  Something like `%logger{-3}` for example.  That way I'd end up with:
> {{uk.co.ltheobald.Main logging}} as {{Main}}
> {{uk.co.ltheobald.foo.MyClass}} logging as {{foo.MyClass}}
> {{uk.co.ltheobald.foo.bar.MyOtherClass}} logging as {{foo.bar.MyOtherClass}}
> Removing from the start of the logger name allows me to consistently trim off 
> package names that I know are always the same.  I'll see if I can produce a 
> code example for this if I get time but I wanted to log it in the meanwhile.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Updated] (LOG4J2-621) Pattern To Drop First X Package Parts

2014-04-29 Thread Lee Theobald (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lee Theobald updated LOG4J2-621:


Description: 
Currently you can have a pattern that will print out the last X parts of you 
package.  So if my package was {{uk.co.ltheobald.foo.bar}}, then using 
{{%logger\{2\}}} will print {{foo.bar}}.  But when I have a number of different 
package levels, this becomes less useful (in my opinion).

What I'd find more useful is the inverse where I can ditch the first X parts.  
Something like {{%logger\{-3\}}} for example.  That way I'd end up with:

{{uk.co.ltheobald.Main logging}} as {{Main}}
{{uk.co.ltheobald.foo.MyClass}} logging as {{foo.MyClass}}
{{uk.co.ltheobald.foo.bar.MyOtherClass}} logging as {{foo.bar.MyOtherClass}}

Removing from the start of the logger name allows me to consistently trim off 
package names that I know are always the same.  I'll see if I can produce a 
code example for this if I get time but I wanted to log it in the meanwhile.

  was:
Currently you can have a pattern that will print out the last X parts of you 
package.  So if my package was {{uk.co.ltheobald.foo.bar}}, then using 
`%logger{2}` will print {{foo.bar}}.  But when I have a number of different 
package levels, this becomes less useful (in my opinion).

What I'd find more useful is the inverse where I can ditch the first X parts.  
Something like `%logger{-3}` for example.  That way I'd end up with:

{{uk.co.ltheobald.Main logging}} as {{Main}}
{{uk.co.ltheobald.foo.MyClass}} logging as {{foo.MyClass}}
{{uk.co.ltheobald.foo.bar.MyOtherClass}} logging as {{foo.bar.MyOtherClass}}

Removing from the start of the logger name allows me to consistently trim off 
package names that I know are always the same.  I'll see if I can produce a 
code example for this if I get time but I wanted to log it in the meanwhile.


> Pattern To Drop First X Package Parts
> -
>
> Key: LOG4J2-621
> URL: https://issues.apache.org/jira/browse/LOG4J2-621
> Project: Log4j 2
>  Issue Type: Wish
>  Components: Layouts
>Affects Versions: 2.0-rc1
>Reporter: Lee Theobald
>Priority: Trivial
>
> Currently you can have a pattern that will print out the last X parts of you 
> package.  So if my package was {{uk.co.ltheobald.foo.bar}}, then using 
> {{%logger\{2\}}} will print {{foo.bar}}.  But when I have a number of 
> different package levels, this becomes less useful (in my opinion).
> What I'd find more useful is the inverse where I can ditch the first X parts. 
>  Something like {{%logger\{-3\}}} for example.  That way I'd end up with:
> {{uk.co.ltheobald.Main logging}} as {{Main}}
> {{uk.co.ltheobald.foo.MyClass}} logging as {{foo.MyClass}}
> {{uk.co.ltheobald.foo.bar.MyOtherClass}} logging as {{foo.bar.MyOtherClass}}
> Removing from the start of the logger name allows me to consistently trim off 
> package names that I know are always the same.  I'll see if I can produce a 
> code example for this if I get time but I wanted to log it in the meanwhile.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Updated] (LOG4J2-621) Pattern To Drop First X Package Parts

2014-04-29 Thread Lee Theobald (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lee Theobald updated LOG4J2-621:


Description: 
Currently you can have a pattern that will print out the last X parts of you 
package.  So if my package was {{uk.co.ltheobald.foo.bar}}, then using 
{{%logger{2}}} will print {{foo.bar}}.  But when I have a number of different 
package levels, this becomes less useful (in my opinion).

What I'd find more useful is the inverse where I can ditch the first X parts.  
Something like {{%logger{-3}}} for example.  That way I'd end up with:

{{uk.co.ltheobald.Main logging}} as {{Main}}
{{uk.co.ltheobald.foo.MyClass}} logging as {{foo.MyClass}}
{{uk.co.ltheobald.foo.bar.MyOtherClass}} logging as {{foo.bar.MyOtherClass}}

Removing from the start of the logger name allows me to consistently trim off 
package names that I know are always the same.  I'll see if I can produce a 
code example for this if I get time but I wanted to log it in the meanwhile.

  was:
Currently you can have a pattern that will print out the last X parts of you 
package.  So if my package was `uk.co.ltheobald.foo.bar`, then using 
`%logger{2}` will print `foo.bar`.  But when I have a number of different 
package levels, this becomes less useful (in my opinion).

What I'd find more useful is the inverse where I can ditch the first X parts.  
Something like `%logger{-3}` for example.  That way I'd end up with:

`uk.co.ltheobald.Main logging` as `Main`
`uk.co.ltheobald.foo.MyClass` logging as `foo.MyClass`
`uk.co.ltheobald.foo.bar.MyOtherClass` logging as `foo.bar.MyOtherClass`

Removing from the start of the logger name allows me to consistently trim off 
package names that I know are always the same.

I'll see if I can produce a code example for this if I get time but I wanted to 
log it in the meanwhile.


> Pattern To Drop First X Package Parts
> -
>
> Key: LOG4J2-621
> URL: https://issues.apache.org/jira/browse/LOG4J2-621
> Project: Log4j 2
>  Issue Type: Wish
>  Components: Layouts
>Affects Versions: 2.0-rc1
>Reporter: Lee Theobald
>Priority: Trivial
>
> Currently you can have a pattern that will print out the last X parts of you 
> package.  So if my package was {{uk.co.ltheobald.foo.bar}}, then using 
> {{%logger{2}}} will print {{foo.bar}}.  But when I have a number of different 
> package levels, this becomes less useful (in my opinion).
> What I'd find more useful is the inverse where I can ditch the first X parts. 
>  Something like {{%logger{-3}}} for example.  That way I'd end up with:
> {{uk.co.ltheobald.Main logging}} as {{Main}}
> {{uk.co.ltheobald.foo.MyClass}} logging as {{foo.MyClass}}
> {{uk.co.ltheobald.foo.bar.MyOtherClass}} logging as {{foo.bar.MyOtherClass}}
> Removing from the start of the logger name allows me to consistently trim off 
> package names that I know are always the same.  I'll see if I can produce a 
> code example for this if I get time but I wanted to log it in the meanwhile.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Updated] (LOG4J2-621) Pattern To Drop First X Package Parts

2014-04-29 Thread Lee Theobald (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lee Theobald updated LOG4J2-621:


Description: 
Currently you can have a pattern that will print out the last X parts of you 
package.  So if my package was {{uk.co.ltheobald.foo.bar}}, then using 
{{%logger{2} }} will print {{foo.bar}}.  But when I have a number of different 
package levels, this becomes less useful (in my opinion).

What I'd find more useful is the inverse where I can ditch the first X parts.  
Something like {{%logger{-3}}} for example.  That way I'd end up with:

{{uk.co.ltheobald.Main logging}} as {{Main}}
{{uk.co.ltheobald.foo.MyClass}} logging as {{foo.MyClass}}
{{uk.co.ltheobald.foo.bar.MyOtherClass}} logging as {{foo.bar.MyOtherClass}}

Removing from the start of the logger name allows me to consistently trim off 
package names that I know are always the same.  I'll see if I can produce a 
code example for this if I get time but I wanted to log it in the meanwhile.

  was:
Currently you can have a pattern that will print out the last X parts of you 
package.  So if my package was {{uk.co.ltheobald.foo.bar}}, then using 
{{%logger{2}}} will print {{foo.bar}}.  But when I have a number of different 
package levels, this becomes less useful (in my opinion).

What I'd find more useful is the inverse where I can ditch the first X parts.  
Something like {{%logger{-3}}} for example.  That way I'd end up with:

{{uk.co.ltheobald.Main logging}} as {{Main}}
{{uk.co.ltheobald.foo.MyClass}} logging as {{foo.MyClass}}
{{uk.co.ltheobald.foo.bar.MyOtherClass}} logging as {{foo.bar.MyOtherClass}}

Removing from the start of the logger name allows me to consistently trim off 
package names that I know are always the same.  I'll see if I can produce a 
code example for this if I get time but I wanted to log it in the meanwhile.


> Pattern To Drop First X Package Parts
> -
>
> Key: LOG4J2-621
> URL: https://issues.apache.org/jira/browse/LOG4J2-621
> Project: Log4j 2
>  Issue Type: Wish
>  Components: Layouts
>Affects Versions: 2.0-rc1
>Reporter: Lee Theobald
>Priority: Trivial
>
> Currently you can have a pattern that will print out the last X parts of you 
> package.  So if my package was {{uk.co.ltheobald.foo.bar}}, then using 
> {{%logger{2} }} will print {{foo.bar}}.  But when I have a number of 
> different package levels, this becomes less useful (in my opinion).
> What I'd find more useful is the inverse where I can ditch the first X parts. 
>  Something like {{%logger{-3}}} for example.  That way I'd end up with:
> {{uk.co.ltheobald.Main logging}} as {{Main}}
> {{uk.co.ltheobald.foo.MyClass}} logging as {{foo.MyClass}}
> {{uk.co.ltheobald.foo.bar.MyOtherClass}} logging as {{foo.bar.MyOtherClass}}
> Removing from the start of the logger name allows me to consistently trim off 
> package names that I know are always the same.  I'll see if I can produce a 
> code example for this if I get time but I wanted to log it in the meanwhile.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org