DO NOT REPLY [Bug 44765] SyslogAppender should not attempt to remove inital tabs from stack trace lines
https://issues.apache.org/bugzilla/show_bug.cgi?id=44765
Curt Arnold [EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution||INVALID
--- Comment #3 from Curt Arnold [EMAIL PROTECTED] 2008-08-12 14:42:43 PST ---
Tab characters are prohibited in the MESSAGE section of the packet (see
http://www.ietf.org/rfc/rfc3164.txt?number=3164) along with all other
non-printable characters.
The code fragment that is suggested to be changed does not appear in the
current SVN HEAD (and as far back as the fix for bug 40502) as I can tell. The
current code is:
String[] s = event.getThrowableStrRep();
if (s != null) {
for(int i = 0; i s.length; i++) {
if (s[i].startsWith(\t)) {
sqw.write(hdr+TAB+s[i].substring(1));
} else {
sqw.write(hdr+s[i]);
}
}
}
This should replace any leading tab in the stack trace with the value of
SyslogAppender.TAB (which is initialized at four spaces).
The current code does not address cases where non-printable characters appear
in other positions, but it does appear to do the best possible when the stack
trace starts with a single tab character (which is a common in mainstream
JVM's). As far as I can tell, the behavior described in the bug report should
not occur with the current SVN head, and I'm going to mark the bug as INVALID.
If I've misunderstood, please reopen after testing with the SVN HEAD and
providing a patch against the current SVN HEAD.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44765] SyslogAppender should not attempt to remove inital tabs from stack trace lines
https://issues.apache.org/bugzilla/show_bug.cgi?id=44765 Thorbjørn Ravn Andersen [EMAIL PROTECTED] changed: What|Removed |Added Blocks||45527 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44765] SyslogAppender should not attempt to remove inital tabs from stack trace lines
https://issues.apache.org/bugzilla/show_bug.cgi?id=44765 Thorbjørn Ravn Andersen [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #1 from Thorbjørn Ravn Andersen [EMAIL PROTECTED] 2008-07-03 12:59:07 PST --- Is there any reason why this behaviour should NOT be changed to include all characters logged? Does the first character have special meaning in syslog messages? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44765] SyslogAppender should not attempt to remove inital tabs from stack trace lines
https://issues.apache.org/bugzilla/show_bug.cgi?id=44765 Morten Hattesen [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #2 from Morten Hattesen [EMAIL PROTECTED] 2008-07-03 13:38:51 PST --- (In reply to comment #1) Is there any reason why this behaviour should NOT be changed to include all characters logged? Does the first character have special meaning in syslog messages? No, the first character has no special meaning. But since stack-traces are indented using a leading TAB character, it is generally a good idea to expand this to a number (4) of spaces to ensure consistent rendering of the stack-trace. But the TAB character should definitely NOT be truncated as part of the Syslog appender, as is the case today. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
