RE: [jira] [Commented] (LOG4NET-437) LogicalThreadContext data does not flow properly using Async and Await

2015-03-30 Thread Alexander Houben
You probably mean LOG4NET-455.

 -Original Message-
 From: Stefan Bodewig (JIRA) [mailto:j...@apache.org]
 Sent: Montag, 30. März 2015 08:03
 To: log4net-dev@logging.apache.org
 Subject: [jira] [Commented] (LOG4NET-437) LogicalThreadContext data
 does not flow properly using Async and Await
 
 
 [ https://issues.apache.org/jira/browse/LOG4NET-
 437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
 tabpanelfocusedCommentId=14386242#comment-14386242 ]
 
 Stefan Bodewig commented on LOG4NET-437:
 
 
 Sorry, when I opened LOG4NET-456 I completely forgot about this one.
 Could you please verify the fix applied for LOG4NET-456 works for your
 application as well?
 
  LogicalThreadContext data does not flow properly using Async and
 Await
  -
 -
 
  Key: LOG4NET-437
  URL: https://issues.apache.org/jira/browse/LOG4NET-
 437
  Project: Log4net
   Issue Type: Bug
   Components: Core
 Affects Versions: 1.2.9, 1.2.10, 1.2.11, 1.2.12, 1.2.13
  Environment: Windows 7, .NET 4.5
 Reporter: Mike Barry
  Attachments: LogicalThreadContext.diff, Program.cs,
 ThreadContextStacks.diff
 
 
  LogicalThreadContext doesn't work properly when using Async and
 Await. The current NDC call stack gets corrupted because the logical
 data context is not immutable. (See:
 http://blog.stephencleary.com/2013/04/implicit-async-context-
 asynclocal.html for the gory details). I've attached a Program.cs that
 demonstrates the issue. You will see with an unpatched log4net the
 thread context is corrupted compared to the proper implementation in
 MyStack and the console logger. An entry like:
  LOG4NET Main 1 A 2 A: /MoreWork
  LOG4NET Main 1 A 2 A: /MoreWork
  is invalid and should not be possible in a properly working thread
 context.
  I've attached a VERY naive patch that corrects the issue.
 
 
 
 --
 This message was sent by Atlassian JIRA
 (v6.3.4#6332)


smime.p7s
Description: S/MIME cryptographic signature


Build failed in Jenkins: log4net-trunk-tests #45

2015-03-30 Thread Apache Jenkins Server
See https://builds.apache.org/job/log4net-trunk-tests/45/changes

Changes:

[bodewig] prefer locally loaded type over one loaded from GAC

[bodewig] used wrong symbol

--
[...truncated 695 lines...]
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetConnection.cs(46,32):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetConnection.State'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetConnection.cs(54,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetConnection.ConnectionString'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetConnection.cs(75,41):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetConnection.MostRecentInstance'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetConnection.cs(94,20):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetConnection.ConnectionTimeout'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetConnection.cs(99,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetConnection.Database'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(27,18):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(38,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.ParameterName'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(44,21):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.Precision'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(50,21):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.Scale'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(56,20):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.Size'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(62,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.DbType'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(68,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.Value'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(78,35):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.Direction'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(84,21):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.IsNullable'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(89,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.SourceColumn'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(95,31):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.SourceVersion'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameterCollection.cs(28,18):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameterCollection'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameterCollection.cs(34,33):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameterCollection.OnInsertComplete(int, 

[jira] [Commented] (LOG4NET-437) LogicalThreadContext data does not flow properly using Async and Await

2015-03-30 Thread Stefan Bodewig (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4NET-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386242#comment-14386242
 ] 

Stefan Bodewig commented on LOG4NET-437:


Sorry, when I opened LOG4NET-456 I completely forgot about this one.  Could you 
please verify the fix applied for LOG4NET-456 works for your application as 
well?

 LogicalThreadContext data does not flow properly using Async and Await
 --

 Key: LOG4NET-437
 URL: https://issues.apache.org/jira/browse/LOG4NET-437
 Project: Log4net
  Issue Type: Bug
  Components: Core
Affects Versions: 1.2.9, 1.2.10, 1.2.11, 1.2.12, 1.2.13
 Environment: Windows 7, .NET 4.5
Reporter: Mike Barry
 Attachments: LogicalThreadContext.diff, Program.cs, 
 ThreadContextStacks.diff


 LogicalThreadContext doesn't work properly when using Async and Await. The 
 current NDC call stack gets corrupted because the logical data context is not 
 immutable. (See: 
 http://blog.stephencleary.com/2013/04/implicit-async-context-asynclocal.html 
 for the gory details). I've attached a Program.cs that demonstrates the 
 issue. You will see with an unpatched log4net the thread context is corrupted 
 compared to the proper implementation in MyStack and the console logger. An 
 entry like:
 LOG4NET Main 1 A 2 A: /MoreWork
 LOG4NET Main 1 A 2 A: /MoreWork
 is invalid and should not be possible in a properly working thread context.
 I've attached a VERY naive patch that corrects the issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LOG4NET-344) Make AdoNetAppender not to stuck application process

2015-03-30 Thread Stefan Bodewig (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4NET-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386458#comment-14386458
 ] 

Stefan Bodewig commented on LOG4NET-344:


For some reason we've all forgotten there already is an AsyncAppender inside 
log4net's examples.  Furthermore there is an implementation using TPL in 
LOG4NET-407.

The existing example code seems to be similar to Ron's suggestion (it doesn't 
perform any bulk processing, but I'd rather see async and buffering/forwarding 
as two separate issues anyway.  Right now I'm leaning towards adding 
AsyncAppender to log4net's core using either the existing example code or Tom's 
implementation for .NET  4.0 and the TPL version for .NET = 4.0.

Tests would be good :-)

 Make AdoNetAppender not to stuck application process
 

 Key: LOG4NET-344
 URL: https://issues.apache.org/jira/browse/LOG4NET-344
 Project: Log4net
  Issue Type: Improvement
  Components: Appenders
Affects Versions: 1.2.10
 Environment: Windows series
Reporter: Tom Tang
  Labels: patch
 Fix For: 3.5

 Attachments: AdoNetAppender.cs, AsyncForwardingAppender.cs

   Original Estimate: 24h
  Remaining Estimate: 24h

 The original AdoNetAppender could stuck application during log insertion.
 Because it use the sync method call to do database insert, once the DB is 
 unavailable or table was locked.
 I change the implementation that has an inner queue inside to store the 
 messages, and the other independent thread will be going to cunsuming the 
 queue messages and do DB insertion.
 This implementation will not have any impact on application performance and 
 much stable.
 Trade off: Once the queue max buffer was full, the later coming log message 
 would be ignored and gone forever. But log4net is not designed for guarantee 
 delivery in purpose, right? So it's not big deal at all. :)  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LOG4NET-442) ReconnectOnError

2015-03-30 Thread Stefan Bodewig (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4NET-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386494#comment-14386494
 ] 

Stefan Bodewig commented on LOG4NET-442:


should we close this as Won't fix (Not a Problem is not appropriate IMHO) 
and add an entry to the FAQ?


 ReconnectOnError 
 -

 Key: LOG4NET-442
 URL: https://issues.apache.org/jira/browse/LOG4NET-442
 Project: Log4net
  Issue Type: Bug
  Components: Builds
Affects Versions: 1.2.13
 Environment: Microsoft .NET 4.5
Reporter: Alessio Sanguineti
 Attachments: log4net.txt


 Hello, in our .NET application using Log4Net to log on a Sql Server 2014 
 database, we set the parameter ReconnectOnError to true in the ADO.Net 
 Appender configuration. 
 Even if the property seems to be read correctly (as visible on the log), 
 whenever the server is not reachable for a while the appender does not 
 reconnect anymore thus not logging anything else.
 We get the log file attached of a test where we turned off SQL Server for 
 about 1 minute before restarting it.
 Thank you.
 Regards



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (LOG4NET-437) LogicalThreadContext data does not flow properly using Async and Await

2015-03-30 Thread Stefan Bodewig (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4NET-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386242#comment-14386242
 ] 

Stefan Bodewig edited comment on LOG4NET-437 at 3/30/15 8:37 AM:
-

Sorry, when I opened LOG4NET-455 I completely forgot about this one.  Could you 
please verify the fix applied for LOG4NET-455 works for your application as 
well?


was (Author: bodewig):
Sorry, when I opened LOG4NET-456 I completely forgot about this one.  Could you 
please verify the fix applied for LOG4NET-456 works for your application as 
well?

 LogicalThreadContext data does not flow properly using Async and Await
 --

 Key: LOG4NET-437
 URL: https://issues.apache.org/jira/browse/LOG4NET-437
 Project: Log4net
  Issue Type: Bug
  Components: Core
Affects Versions: 1.2.9, 1.2.10, 1.2.11, 1.2.12, 1.2.13
 Environment: Windows 7, .NET 4.5
Reporter: Mike Barry
 Attachments: LogicalThreadContext.diff, Program.cs, 
 ThreadContextStacks.diff


 LogicalThreadContext doesn't work properly when using Async and Await. The 
 current NDC call stack gets corrupted because the logical data context is not 
 immutable. (See: 
 http://blog.stephencleary.com/2013/04/implicit-async-context-asynclocal.html 
 for the gory details). I've attached a Program.cs that demonstrates the 
 issue. You will see with an unpatched log4net the thread context is corrupted 
 compared to the proper implementation in MyStack and the console logger. An 
 entry like:
 LOG4NET Main 1 A 2 A: /MoreWork
 LOG4NET Main 1 A 2 A: /MoreWork
 is invalid and should not be possible in a properly working thread context.
 I've attached a VERY naive patch that corrects the issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [jira] [Commented] (LOG4NET-437) LogicalThreadContext data does not flow properly using Async and Await

2015-03-30 Thread Stefan Bodewig
On 2015-03-30, Alexander Houben wrote:

 You probably mean LOG4NET-455.

Yes, thanks!

Stefan


signature.asc
Description: PGP signature


[jira] [Commented] (LOG4NET-412) Millisecond always return 0 in wince

2015-03-30 Thread Stefan Bodewig (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4NET-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386439#comment-14386439
 ] 

Stefan Bodewig commented on LOG4NET-412:


I've found the code you use in 
http://blog.opennetcf.com/ctacke/archives/ms-Resolution%20DateTime.pdf - 
unfortunately the license of that code is totally unclear to me.

 Millisecond always return 0 in wince 
 -

 Key: LOG4NET-412
 URL: https://issues.apache.org/jira/browse/LOG4NET-412
 Project: Log4net
  Issue Type: Bug
  Components: Appenders
Affects Versions: 1.3.0
 Environment: NETCF
Reporter: Son Tran
Priority: Trivial
  Labels: DateTime,

 As I check the DateTime.Ticks is used in function 
 AbsoluteTimeDateFormatter.FormatDate always return 0
 work around by using Enviroment.TichCount.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (LOG4NET-443) Logger.CallAppenders

2015-03-30 Thread Stefan Bodewig (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4NET-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Bodewig resolved LOG4NET-443.

   Resolution: Fixed
Fix Version/s: 1.3.0

implemented the try/finally workaround mentioned in Andrii Chabykins post with 
svn revision 1670018

 Logger.CallAppenders
 

 Key: LOG4NET-443
 URL: https://issues.apache.org/jira/browse/LOG4NET-443
 Project: Log4net
  Issue Type: Bug
Affects Versions: 1.2.13
 Environment: Windows service implemented with .NET 4.5  using Log4Net 
 1.2.13 on Windows 2008 R2
Reporter: Calin Pavel
Priority: Critical
 Fix For: 1.3.0

 Attachments: log4net.xml


 I do have an .NET application (Windows Service) that collects data from a lot 
 of sources (DBs, log files, machines event logs, ...) and uses Log4Net to log 
 details of the actions / execution.  As expected, I'm using a high number of 
 threads to collect data, threads that are writing logs in some files 
 (RollingFileAppenderer).
 Lately it happens that the entire application is BLOCKED because all threads 
 were trying to acquire a read lock, like in the stack trace:
 1ac3d998 774715fa [HelperMethodFrame: 1ac3d998] 
 System.Threading.Thread.SleepInternal(Int32)
 1ac3da90 07fef747b5e9 System.Threading.Thread.Sleep(Int32)
 1ac3dac0 07fef5fb9631 
 System.Threading.ReaderWriterLockSlim.EnterMyLockSpin()
 1ac3db90 07fef5cd297e 
 System.Threading.ReaderWriterLockSlim.TryEnterReadLockCore(TimeoutTracker)
 1ac3dbf0 07fef5cd28fa 
 System.Threading.ReaderWriterLockSlim.TryEnterReadLock(TimeoutTracker)
 1ac3dc40 07fe98fb4efd 
 log4net.Repository.Hierarchy.Logger.CallAppenders(log4net.Core.LoggingEvent)
 1ac3dcc0 07fe98fb4907 
 log4net.Repository.Hierarchy.Logger.Log(System.Type, log4net.Core.Level, 
 System.Object, System.Exception)
 1ac3dd30 07fe98fb47f9 log4net.Core.LogImpl.Info(System.Object)  
 It's important to mention that my threads have a timeout, and if they do not 
 finish the job in the given interval they are ABORTED.
 Searching for a solution, I found a possible explanation of application 
 hanging here: 
 http://chabster.blogspot.ro/2013/07/a-story-of-orphaned-readerwriterlockslim.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Build failed in Jenkins: log4net-trunk-tests #46

2015-03-30 Thread Apache Jenkins Server
See https://builds.apache.org/job/log4net-trunk-tests/46/changes

Changes:

[bodewig] LOG4NET-443 prevent orphaned locks with ReaderWriterLockSlim in the 
face of aborted threads

--
[...truncated 694 lines...]
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetConnection.cs(46,32):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetConnection.State'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetConnection.cs(54,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetConnection.ConnectionString'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetConnection.cs(75,41):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetConnection.MostRecentInstance'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetConnection.cs(94,20):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetConnection.ConnectionTimeout'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetConnection.cs(99,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetConnection.Database'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(27,18):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(38,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.ParameterName'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(44,21):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.Precision'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(50,21):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.Scale'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(56,20):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.Size'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(62,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.DbType'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(68,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.Value'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(78,35):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.Direction'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(84,21):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.IsNullable'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(89,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.SourceColumn'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(95,31):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.SourceVersion'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameterCollection.cs(28,18):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameterCollection'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameterCollection.cs(34,33):
 warning CS1591: Missing XML comment for publicly visible type or member 

[jira] [Commented] (LOG4NET-438) SmtpAppender not working

2015-03-30 Thread Stefan Bodewig (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4NET-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386511#comment-14386511
 ] 

Stefan Bodewig commented on LOG4NET-438:


You put the appender into lossy mode but don't specify an Evaluator - with 
this setting messages will never get sent.  
http://logging.apache.org/log4net/release/sdk/log4net.Appender.BufferingAppenderSkeleton.Lossy.html

 SmtpAppender not working
 

 Key: LOG4NET-438
 URL: https://issues.apache.org/jira/browse/LOG4NET-438
 Project: Log4net
  Issue Type: Bug
  Components: Appenders
Affects Versions: 1.2.13
 Environment: Windows 7, Visual Studio 2013, ASP.Net 4.5.2
Reporter: Jeff Armbruster
Priority: Blocker
  Labels: newbie

 SendBuffer and SendEmail are never called.
 I've tried many different configurations.
 Here's my setup.
 My config:
 appender name=SmtpAppender type=log4net.Appender.SmtpAppender
   to value= /
   from value=j...@apexenergetics.com /
   subject value=test logging message /
   smtpHost value=smtp.gmail.com /
   password value=***  /
   userName value=** /
   authentication value=Basic /
   locationInfo value=false /
   port value=587 /
   enableSsl value=true /
   bufferSize value=5 /
   lossy value=true /
   layout type=log4net.Layout.PatternLayout
 conversionPattern value=%newline%date [%thread] %-5level %logger 
 [%property{NDC}] - %message%newline%newline%newline /
   /layout
 /appender
 root
   level value=ALL /
   appender-ref ref=SmtpAppender /
 /root



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Build failed in Jenkins: log4net-trunk-tests #49

2015-03-30 Thread Apache Jenkins Server
See https://builds.apache.org/job/log4net-trunk-tests/49/changes

Changes:

[bodewig] On Mono 3.2 the stack trace becomes long enough that code uses a 
CDATA section

--
[...truncated 694 lines...]
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetConnection.cs(46,32):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetConnection.State'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetConnection.cs(54,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetConnection.ConnectionString'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetConnection.cs(75,41):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetConnection.MostRecentInstance'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetConnection.cs(94,20):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetConnection.ConnectionTimeout'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetConnection.cs(99,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetConnection.Database'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(27,18):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(38,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.ParameterName'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(44,21):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.Precision'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(50,21):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.Scale'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(56,20):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.Size'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(62,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.DbType'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(68,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.Value'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(78,35):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.Direction'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(84,21):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.IsNullable'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(89,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.SourceColumn'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(95,31):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.SourceVersion'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameterCollection.cs(28,18):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameterCollection'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameterCollection.cs(34,33):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameterCollection.OnInsertComplete(int, 

[jira] [Resolved] (LOG4NET-438) SmtpAppender not working

2015-03-30 Thread Stefan Bodewig (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4NET-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Bodewig resolved LOG4NET-438.

Resolution: Not a Problem

 SmtpAppender not working
 

 Key: LOG4NET-438
 URL: https://issues.apache.org/jira/browse/LOG4NET-438
 Project: Log4net
  Issue Type: Bug
  Components: Appenders
Affects Versions: 1.2.13
 Environment: Windows 7, Visual Studio 2013, ASP.Net 4.5.2
Reporter: Jeff Armbruster
Priority: Blocker
  Labels: newbie

 SendBuffer and SendEmail are never called.
 I've tried many different configurations.
 Here's my setup.
 My config:
 appender name=SmtpAppender type=log4net.Appender.SmtpAppender
   to value= /
   from value=j...@apexenergetics.com /
   subject value=test logging message /
   smtpHost value=smtp.gmail.com /
   password value=***  /
   userName value=** /
   authentication value=Basic /
   locationInfo value=false /
   port value=587 /
   enableSsl value=true /
   bufferSize value=5 /
   lossy value=true /
   layout type=log4net.Layout.PatternLayout
 conversionPattern value=%newline%date [%thread] %-5level %logger 
 [%property{NDC}] - %message%newline%newline%newline /
   /layout
 /appender
 root
   level value=ALL /
   appender-ref ref=SmtpAppender /
 /root



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Build failed in Jenkins: log4net-trunk-tests #47

2015-03-30 Thread Apache Jenkins Server
See https://builds.apache.org/job/log4net-trunk-tests/47/changes

Changes:

[bodewig] remove obsolete comments

--
[...truncated 694 lines...]
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetConnection.cs(46,32):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetConnection.State'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetConnection.cs(54,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetConnection.ConnectionString'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetConnection.cs(75,41):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetConnection.MostRecentInstance'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetConnection.cs(94,20):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetConnection.ConnectionTimeout'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetConnection.cs(99,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetConnection.Database'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(27,18):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(38,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.ParameterName'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(44,21):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.Precision'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(50,21):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.Scale'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(56,20):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.Size'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(62,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.DbType'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(68,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.Value'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(78,35):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.Direction'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(84,21):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.IsNullable'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(89,23):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.SourceColumn'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameter.cs(95,31):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameter.SourceVersion'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameterCollection.cs(28,18):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameterCollection'
  [csc] 
https://builds.apache.org/job/log4net-trunk-tests/ws/src\log4net.Tests\Appender\AdoNet\Log4NetParameterCollection.cs(34,33):
 warning CS1591: Missing XML comment for publicly visible type or member 
'log4net.Tests.Appender.AdoNet.Log4NetParameterCollection.OnInsertComplete(int, 
object)'
  [csc] 

[jira] [Resolved] (LOG4NET-441) FAQ should have QA about initialization

2015-03-30 Thread Stefan Bodewig (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4NET-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Bodewig resolved LOG4NET-441.

Resolution: Fixed

added the suggested FAQ with svn revision 1670051 will update the site soon.

 FAQ should have QA about initialization
 

 Key: LOG4NET-441
 URL: https://issues.apache.org/jira/browse/LOG4NET-441
 Project: Log4net
  Issue Type: Bug
  Components: Documentation
Affects Versions: 1.2.13
Reporter: jrv
Priority: Minor
  Labels: documentation
   Original Estimate: 4h
  Remaining Estimate: 4h

 I set up a sample application to try out log4net but nothing happened. I had 
 linked the assembly, called the methods and set up the config, but I neither 
 called one of the configurators nor included one of the configurator 
 attributes. While in retrospect it's stupid on my part, it also seems to be a 
 common cry for help (search log4net not working). The FAQ QA (under 
 troubleshooting) could be something like:
 Q: Why isn't log4net working at all?
 A: You may have overlooked initialization code for log4net in your 
 application. log4net can be initialized explicitly by calling one of the 
 configurators (e.g. BasicConfigurator, DOMConfigurator or XmlConfigurator in 
 the log4net.Config namespace, or implicitly by including one of the 
 configurator attributes (e.g. [XmlConfiguratorAttribute], 
 [DOMConfiguratorAttribute]) in the assembly where log4net is first used. See 
  and  for more information.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Jenkins build is back to normal : log4net-trunk-tests #50

2015-03-30 Thread Apache Jenkins Server
See https://builds.apache.org/job/log4net-trunk-tests/50/changes



[jira] [Commented] (LOG4NET-437) LogicalThreadContext data does not flow properly using Async and Await

2015-03-30 Thread Mike Barry (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4NET-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14387371#comment-14387371
 ] 

Mike Barry commented on LOG4NET-437:


Build fails in code from github. The files do not exist: 
https://github.com/jabbera/log4net/tree/trunk/src/log4net/Config

1CSC : error CS2001: Source file 'Config\AliasDomainAttribute.cs' could not be 
found
1CSC : error CS2001: Source file 'Config\DomainAttribute.cs' could not be found
1CSC : error CS2001: Source file 'Config\DOMConfigurator.cs' could not be found
1CSC : error CS2001: Source file 'Config\DOMConfiguratorAttribute.cs' could 
not be found

 LogicalThreadContext data does not flow properly using Async and Await
 --

 Key: LOG4NET-437
 URL: https://issues.apache.org/jira/browse/LOG4NET-437
 Project: Log4net
  Issue Type: Bug
  Components: Core
Affects Versions: 1.2.9, 1.2.10, 1.2.11, 1.2.12, 1.2.13
 Environment: Windows 7, .NET 4.5
Reporter: Mike Barry
 Attachments: LogicalThreadContext.diff, Program.cs, 
 ThreadContextStacks.diff


 LogicalThreadContext doesn't work properly when using Async and Await. The 
 current NDC call stack gets corrupted because the logical data context is not 
 immutable. (See: 
 http://blog.stephencleary.com/2013/04/implicit-async-context-asynclocal.html 
 for the gory details). I've attached a Program.cs that demonstrates the 
 issue. You will see with an unpatched log4net the thread context is corrupted 
 compared to the proper implementation in MyStack and the console logger. An 
 entry like:
 LOG4NET Main 1 A 2 A: /MoreWork
 LOG4NET Main 1 A 2 A: /MoreWork
 is invalid and should not be possible in a properly working thread context.
 I've attached a VERY naive patch that corrects the issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LOG4NET-437) LogicalThreadContext data does not flow properly using Async and Await

2015-03-30 Thread Stefan Bodewig (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4NET-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14387959#comment-14387959
 ] 

Stefan Bodewig commented on LOG4NET-437:


Oops, my fault.  I deleted the classes but didn't update the VS files (I'm 
using NAnt to build log4net).  Fixed now.

 LogicalThreadContext data does not flow properly using Async and Await
 --

 Key: LOG4NET-437
 URL: https://issues.apache.org/jira/browse/LOG4NET-437
 Project: Log4net
  Issue Type: Bug
  Components: Core
Affects Versions: 1.2.9, 1.2.10, 1.2.11, 1.2.12, 1.2.13
 Environment: Windows 7, .NET 4.5
Reporter: Mike Barry
 Attachments: LogicalThreadContext.diff, Program.cs, 
 ThreadContextStacks.diff


 LogicalThreadContext doesn't work properly when using Async and Await. The 
 current NDC call stack gets corrupted because the logical data context is not 
 immutable. (See: 
 http://blog.stephencleary.com/2013/04/implicit-async-context-asynclocal.html 
 for the gory details). I've attached a Program.cs that demonstrates the 
 issue. You will see with an unpatched log4net the thread context is corrupted 
 compared to the proper implementation in MyStack and the console logger. An 
 entry like:
 LOG4NET Main 1 A 2 A: /MoreWork
 LOG4NET Main 1 A 2 A: /MoreWork
 is invalid and should not be possible in a properly working thread context.
 I've attached a VERY naive patch that corrects the issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (LOG4NET-71) Reorganise source repository to support multiple src projects

2015-03-30 Thread Stefan Bodewig (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4NET-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Bodewig resolved LOG4NET-71.
---
Resolution: Fixed

the reshuffling has been completed many months ago, right now the last open 
issue before being able to cut a release is API docs.

 Reorganise source repository to support multiple src projects
 -

 Key: LOG4NET-71
 URL: https://issues.apache.org/jira/browse/LOG4NET-71
 Project: Log4net
  Issue Type: Task
Reporter: Nicko Cadell
Assignee: Stefan Bodewig
 Fix For: 1.3.0


 The log4net source code repository needs to be updated to allow multiple 
 projects under the src folder. Currently the source for the log4net assembly 
 is directly in the src folder.
 A better structure would be:
 src/
 log4net/
 log4net.Tests/
 log4net.Experimental/
 xdocs/
 We may want to move the examples in to the src folder, or we may want to 
 leave then outside.
 The major impact of this change is to the NAnt build scripts that we use to 
 build the log4net assembly, the examples and the tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)