RE: First JIRA triage run complete - RFA issues
Finally getting started on RFA. I ran NUnit's GUI and had 13 of the RFA tests to fail. I did a little investigation which indicated that the failure was in the test driver environment not in the test or the code. I picked up Visual NUnit for VS 2010. Once I installed it and ran the tests under it, none of the RFA tests failed. The plugin indicates that 5 are them are not implemented and indeed they are not. For instance the TestExclusiveLockFails in RollaingFileAppenderTest.cs fails under NUnit with a bad substring index on line 1473. The problem is that the sh.Message is empty, presumably because there was no error. Yet, when run under the plugin, it errors as expected. I have just discovered the problem. When the test is running under NUnit, the current directory is log4Net\tests\bin\debug, yet the logger creates its log file in log4Net directory. Therefore, the two files are different and there is no error. This means the tests are going to need revamping to work under NUnit GUI. (Could this be a similar problem to what you have with NAnt?). It appears that there is no way to change the current directory in NUnit GUI, so the tests would need modifications to have a consistent current directory while running. Comments/Suggestions? I am new to the whole NUnit thing, so maybe there is an obvious solution I do not know about. FYI. Only 2 of the total 129 tests failed under the Visual NUnit plugin. TestGetEntryType in EventLogAppenderTest (looks like an expected SecurityException under Windows 7) and TestFullFix in RemotingAppednerTest. -- Roy Chastain
First JIRA triage run complete
Hi all, as you have seen in the storm of JIRA emails I went through all JIRA issues and assigned them to some fix version. Some of them looked invalid but I only closed the most obvious ones. After I now have read all of them, on piece of code is sticking out as a major pain point: RollingFileAppender. A double digit number of issues are raised against it. I have assigned two or three of them to 1.2.11 but we can also push the whole thing back if it seems as if the code needs some re-thought to get it right. If anybody is looking for an isolated piece of code that needs to be fixed without any need to understand the whole code base, RollingFileAppender it is. If anybody wants to play with it, please raise your hand so we don't duplicate effort. The next things I intend to focus on is fixing the currently failing unit tests on Windows 7, generating the site (and fixing some related doc issues while I'm at it) and the whole build system so we can actually create a distribution. Stefan
RE: First JIRA triage run complete
I will take on RFA. I have had my issues with it and even added a different rolling method for my local use. This brings us back to how do I get the current code with any additions to start working from. -- Roy Chastain -Original Message- From: Stefan Bodewig [mailto:bode...@apache.org] Sent: Tuesday, September 06, 2011 08:28 To: log4net-dev@logging.apache.org Subject: First JIRA triage run complete Hi all, as you have seen in the storm of JIRA emails I went through all JIRA issues and assigned them to some fix version. Some of them looked invalid but I only closed the most obvious ones. After I now have read all of them, on piece of code is sticking out as a major pain point: RollingFileAppender. A double digit number of issues are raised against it. I have assigned two or three of them to 1.2.11 but we can also push the whole thing back if it seems as if the code needs some re-thought to get it right. If anybody is looking for an isolated piece of code that needs to be fixed without any need to understand the whole code base, RollingFileAppender it is. If anybody wants to play with it, please raise your hand so we don't duplicate effort. The next things I intend to focus on is fixing the currently failing unit tests on Windows 7, generating the site (and fixing some related doc issues while I'm at it) and the whole build system so we can actually create a distribution. Stefan
