Re: cvs commit: logging-log4net/src/Util PatternString.cs
On Wed, 11 May 2005, Nicko Cadell [EMAIL PROTECTED] wrote: I use cygwin cvs which is configured to work in UNIX mode on my WinXP box. This is not really by design, its just the way it is right now. I don't want to make an issue of this, but I'm curious. Why are you using the UNIX mode instead of DOS? Is there some other tool that works better that way? Is it just for historic reasons? Stefan
Re: cvs commit: logging-log4net/src/Util PatternString.cs
On Thu, 12 May 2005, Nicko Cadell [EMAIL PROTECTED] wrote: I haven't played around with subversion too much and I don't know how it deals with the LF / CRLF issue, I guess we will find out ;) Unlike CVS, Subversion treats all files as binary files - and doesn't do any keyword expansion either - unless you tell it to. You have to set properties on the individual files to make it translate line-feeds or make any other changes. For people working on Unix it is a bit annoying if you have cariage returns in the files and as soon as you have a committer working on Unix you may end up with files that have mixed line-ends since the code she/he added would have line-feeds only. Where it becomes a real problem is when you have Unix shell scripts in the module since the shell will see the cariage return in the she-bang line and fail with something like file not found /bin/sh^M where ^M is a \r and easy to overlook. Stefan
cvs commit: logging-log4net/src/Util PatternString.cs
nicko 2005/05/11 06:21:05
Modified:src/Layout PatternLayout.cs
src/Util PatternString.cs
Log:
Fixed preallocated hashtable size for static patterns
Revision ChangesPath
1.21 +1 -1 logging-log4net/src/Layout/PatternLayout.cs
Index: PatternLayout.cs
===
RCS file: /home/cvs/logging-log4net/src/Layout/PatternLayout.cs,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -r1.20 -r1.21
--- PatternLayout.cs 31 Jan 2005 02:32:10 - 1.20
+++ PatternLayout.cs 11 May 2005 13:21:05 - 1.21
@@ -766,7 +766,7 @@
/// /remarks
static PatternLayout()
{
- s_globalRulesRegistry = new Hashtable(35);
+ s_globalRulesRegistry = new Hashtable(45);
s_globalRulesRegistry.Add(literal,
typeof(log4net.Util.PatternStringConverters.LiteralPatternConverter));
s_globalRulesRegistry.Add(newline,
typeof(log4net.Util.PatternStringConverters.NewLinePatternConverter));
1.13 +2 -2 logging-log4net/src/Util/PatternString.cs
Index: PatternString.cs
===
RCS file: /home/cvs/logging-log4net/src/Util/PatternString.cs,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- PatternString.cs 31 Jan 2005 22:56:49 - 1.12
+++ PatternString.cs 11 May 2005 13:21:05 - 1.13
@@ -39,7 +39,7 @@
/// This class functions similarly to the see
cref=log4net.Layout.PatternLayout/
/// in that it accepts a pattern and renders it to a string. Unlike the
/// see cref=log4net.Layout.PatternLayout/ however the
cPatternString/c
- /// does does not render properties of a specific see
cref=LoggingEvent/ but
+ /// does not render the properties of a specific see
cref=LoggingEvent/ but
/// of the process in general.
/// /para
/// para
@@ -281,7 +281,7 @@
/// /summary
static PatternString()
{
- s_globalRulesRegistry = new Hashtable(10);
+ s_globalRulesRegistry = new Hashtable(15);
s_globalRulesRegistry.Add(appdomain,
typeof(AppDomainPatternConverter));
s_globalRulesRegistry.Add(date,
typeof(DatePatternConverter));
cvs commit: logging-log4net/src/Util PatternString.cs
nicko 2004/05/30 03:48:26
Modified:src/Util/PatternStringConverters DatePatternConverter.cs
NewLinePatternConverter.cs
src/Util PatternString.cs
Log:
Updated doc comments
Revision ChangesPath
1.4 +16 -0
logging-log4net/src/Util/PatternStringConverters/DatePatternConverter.cs
Index: DatePatternConverter.cs
===
RCS file:
/home/cvs/logging-log4net/src/Util/PatternStringConverters/DatePatternConverter.cs,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- DatePatternConverter.cs 23 Feb 2004 03:18:05 - 1.3
+++ DatePatternConverter.cs 30 May 2004 10:48:26 - 1.4
@@ -36,6 +36,22 @@
#region Implementation of IOptionHandler
+ /// summary
+ /// Initialize the converter options
+ /// /summary
+ /// remarks
+ /// para
+ /// This is part of the see cref=IOptionHandler/ delayed
object
+ /// activation scheme. The see cref=ActivateOptions/ method
must
+ /// be called on this object after the configuration properties
have
+ /// been set. Until see cref=ActivateOptions/ is called this
+ /// object is in an undefined state and must not be used.
+ /// /para
+ /// para
+ /// If any of the configuration properties are modified then
+ /// see cref=ActivateOptions/ must be called again.
+ /// /para
+ /// /remarks
public void ActivateOptions()
{
string dateFormatStr = Option;
1.3 +16 -0
logging-log4net/src/Util/PatternStringConverters/NewLinePatternConverter.cs
Index: NewLinePatternConverter.cs
===
RCS file:
/home/cvs/logging-log4net/src/Util/PatternStringConverters/NewLinePatternConverter.cs,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- NewLinePatternConverter.cs16 Feb 2004 02:10:55 - 1.2
+++ NewLinePatternConverter.cs30 May 2004 10:48:26 - 1.3
@@ -33,6 +33,22 @@
{
#region Implementation of IOptionHandler
+ /// summary
+ /// Initialize the converter options
+ /// /summary
+ /// remarks
+ /// para
+ /// This is part of the see cref=IOptionHandler/ delayed
object
+ /// activation scheme. The see cref=ActivateOptions/ method
must
+ /// be called on this object after the configuration properties
have
+ /// been set. Until see cref=ActivateOptions/ is called this
+ /// object is in an undefined state and must not be used.
+ /// /para
+ /// para
+ /// If any of the configuration properties are modified then
+ /// see cref=ActivateOptions/ must be called again.
+ /// /para
+ /// /remarks
public void ActivateOptions()
{
if (string.Compare(Option, DOS, true,
System.Globalization.CultureInfo.InvariantCulture) == 0)
1.4 +14 -1 logging-log4net/src/Util/PatternString.cs
Index: PatternString.cs
===
RCS file: /home/cvs/logging-log4net/src/Util/PatternString.cs,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- PatternString.cs 23 Feb 2004 03:18:04 - 1.3
+++ PatternString.cs 30 May 2004 10:48:26 - 1.4
@@ -147,8 +147,21 @@
#region Implementation of IOptionHandler
/// summary
- /// Does not do anything as options become effective
immediately.
+ /// Initialize component options
/// /summary
+ /// remarks
+ /// para
+ /// This is part of the see cref=IOptionHandler/ delayed
object
+ /// activation scheme. The see cref=ActivateOptions/ method
must
+ /// be called on this object after the configuration properties
have
+ /// been set. Until see cref=ActivateOptions/ is called this
+ /// object is in an undefined state and must not be used.
+ /// /para
+ /// para
+ /// If any of the configuration properties are modified then
+ /// see cref=ActivateOptions/ must be called again.
+ /// /para
+ /// /remarks
virtual public void ActivateOptions()
{
// nothing to do.
