Re: [lttng-dev] [PATCH lttng-modules] Fix formatting in strutils_star_glob_match_char_cb explanation

[Philippe Proulx]

On Fri, Mar 17, 2017 at 5:06 PM, Francis Deslauriers
 wrote:
>
> Replace tabs for spaces in example scenario

Yes, thank you, it looks like my editor replaced all 8 spaces with
tabs in this comment.

Phil

>
> Signed-off-by: Francis Deslauriers 

Signed-off-by: Philippe Proulx 

> ---
>  lttng-string-utils.c | 108 
> +--
>  1 file changed, 54 insertions(+), 54 deletions(-)
>
> diff --git a/lttng-string-utils.c b/lttng-string-utils.c
> index 94de1cf..7485380 100644
> --- a/lttng-string-utils.c
> +++ b/lttng-string-utils.c
> @@ -145,139 +145,139 @@ retry:
>  * Example:
>  *
>  * candidate: hi ev every onyx one
> -*  ^
> +*^
>  * pattern:   hi*every*one
> -*  ^
> +*^
>  *
>  * candidate: hi ev every onyx one
> -*   ^
> +* ^
>  * pattern:   hi*every*one
> -*   ^
> +* ^
>  *
>  * candidate: hi ev every onyx one
> -*^
> +*  ^
>  * pattern:   hi*every*one
> -*^
> +*  ^
>  *
>  * candidate: hi ev every onyx one
> -*^
> +*  ^
>  * pattern:   hi*every*one
> -* ^ MISMATCH
> +*   ^ MISMATCH
>  *
>  * candidate: hi ev every onyx one
> -* ^
> +*   ^
>  * pattern:   hi*every*one
> -* ^
> +*   ^
>  *
>  * candidate: hi ev every onyx one
> -* ^^
> +*   ^^
>  * pattern:   hi*every*one
> -* ^^
> +*   ^^
>  *
>  * candidate: hi ev every onyx one
> -* ^ ^
> +*   ^ ^
>  * pattern:   hi*every*one
> -* ^ ^ MISMATCH
> +*   ^ ^ MISMATCH
>  *
>  * candidate: hi ev every onyx one
> -*  ^
> +*^
>  * pattern:   hi*every*one
> -* ^ MISMATCH
> +*   ^ MISMATCH
>  *
>  * candidate: hi ev every onyx one
> -*   ^
> +* ^
>  * pattern:   hi*every*one
> -* ^ MISMATCH
> +*   ^ MISMATCH
>  *
>  * candidate: hi ev every onyx one
> -*^
> +*  ^
>  * pattern:   hi*every*one
> -* ^
> +*   ^
>  *
>  * candidate: hi ev every onyx one
> -*^^
> +*  ^^
>  * pattern:   hi*every*one
> -* ^^
> +*   ^^
>  *
>  * candidate: hi ev every onyx one
> -*^ ^
> +*  ^ ^
>  * pattern:   hi*every*one
> -* ^ ^
> +*   ^ ^
>  *
>  * candidate: hi ev every onyx one
> -*^  ^
> +*  ^  ^
>  * pattern:   hi*every*one
> -* ^  ^
> +*   ^  ^
>  *
>  * candidate: hi ev every onyx one
> -*^   ^
> +*  ^   ^
>  * pattern:   hi*every*one
> -* ^   ^
> +*   ^   ^
>  *
>  * candidate: hi ev every onyx one
> -* ^
> +*   ^
>  * pattern:   hi*every*one
> -*  ^
> +*^
>  *
>  * candidate: hi ev every onyx one
> -* ^
> +*   ^
>  * pattern:   hi*every*one
> -*   ^ MISMATCH
> +* ^ MISMATCH
>  *
>  * candidate: hi ev every onyx one
> -*  ^
> +*^
>  * pattern:   hi*every*one
> -*   ^
> +* ^
>  *
>  * candidate: hi ev every onyx one
> -*  ^^
> +   

Re: [lttng-dev] [PATCH lttng-modules] Fix formatting in strutils_star_glob_match_char_cb explanation

[Mathieu Desnoyers]

merged, thanks!

Mathieu

- On Mar 17, 2017, at 5:06 PM, Francis Deslauriers 
francis.deslauri...@efficios.com wrote:

> Replace tabs for spaces in example scenario
> 
> Signed-off-by: Francis Deslauriers 
> ---
> lttng-string-utils.c | 108 +--
> 1 file changed, 54 insertions(+), 54 deletions(-)
> 
> diff --git a/lttng-string-utils.c b/lttng-string-utils.c
> index 94de1cf..7485380 100644
> --- a/lttng-string-utils.c
> +++ b/lttng-string-utils.c
> @@ -145,139 +145,139 @@ retry:
>* Example:
>*
>* candidate: hi ev every onyx one
> -  *  ^
> +  *^
>* pattern:   hi*every*one
> -  *  ^
> +  *^
>*
>* candidate: hi ev every onyx one
> -  *   ^
> +  * ^
>* pattern:   hi*every*one
> -  *   ^
> +  * ^
>*
>* candidate: hi ev every onyx one
> -  *^
> +  *  ^
>* pattern:   hi*every*one
> -  *^
> +  *  ^
>*
>* candidate: hi ev every onyx one
> -  *^
> +  *  ^
>* pattern:   hi*every*one
> -  * ^ MISMATCH
> +  *   ^ MISMATCH
>*
>* candidate: hi ev every onyx one
> -  * ^
> +  *   ^
>* pattern:   hi*every*one
> -  * ^
> +  *   ^
>*
>* candidate: hi ev every onyx one
> -  * ^^
> +  *   ^^
>* pattern:   hi*every*one
> -  * ^^
> +  *   ^^
>*
>* candidate: hi ev every onyx one
> -  * ^ ^
> +  *   ^ ^
>* pattern:   hi*every*one
> -  * ^ ^ MISMATCH
> +  *   ^ ^ MISMATCH
>*
>* candidate: hi ev every onyx one
> -  *  ^
> +  *^
>* pattern:   hi*every*one
> -  * ^ MISMATCH
> +  *   ^ MISMATCH
>*
>* candidate: hi ev every onyx one
> -  *   ^
> +  * ^
>* pattern:   hi*every*one
> -  * ^ MISMATCH
> +  *   ^ MISMATCH
>*
>* candidate: hi ev every onyx one
> -  *^
> +  *  ^
>* pattern:   hi*every*one
> -  * ^
> +  *   ^
>*
>* candidate: hi ev every onyx one
> -  *^^
> +  *  ^^
>* pattern:   hi*every*one
> -  * ^^
> +  *   ^^
>*
>* candidate: hi ev every onyx one
> -  *^ ^
> +  *  ^ ^
>* pattern:   hi*every*one
> -  * ^ ^
> +  *   ^ ^
>*
>* candidate: hi ev every onyx one
> -  *^  ^
> +  *  ^  ^
>* pattern:   hi*every*one
> -  * ^  ^
> +  *   ^  ^
>*
>* candidate: hi ev every onyx one
> -  *^   ^
> +  *  ^   ^
>* pattern:   hi*every*one
> -  * ^   ^
> +  *   ^   ^
>*
>* candidate: hi ev every onyx one
> -  * ^
> +  *   ^
>* pattern:   hi*every*one
> -  *  ^
> +  *^
>*
>* candidate: hi ev every onyx one
> -  * ^
> +  *   ^
>* pattern:   hi*every*one
> -  *   ^ MISMATCH
> +  * ^ MISMATCH
>*
>* candidate: hi ev every onyx one
> -  *  ^
> +  *^
>* pattern:   hi*every*one
> -  *   ^
> +  * ^
>*
>* candidate: hi ev every onyx one
> -  *  ^^
> +  *^^
>* pattern:   hi*every*one
> -  *   ^^
> +  * ^^
>*
>* candidate: hi ev every onyx one
> -  *  ^ ^
> +  *^ ^
>* pattern:   hi*every*one
> -  *   ^ ^ MISMATCH
> +  

Re: [lttng-dev] [PATCH lttng-ust] Fix formatting in strutils_star_glob_match explanation

[Mathieu Desnoyers]

Changed the title and changelog:

"Cleanup: formatting in strutils_star_glob_match explanation

Replace tabs for spaces in example scenario."

Can you prepare a similar patch for lttng-modules ?

Thanks,

Mathieu


- On Mar 17, 2017, at 4:55 PM, Francis Deslauriers 
francis.deslauri...@efficios.com wrote:

> Replace tabs for spaces in example scenario
> 
> Signed-off-by: Francis Deslauriers 
> ---
> liblttng-ust/string-utils.c | 108 ++--
> 1 file changed, 54 insertions(+), 54 deletions(-)
> 
> diff --git a/liblttng-ust/string-utils.c b/liblttng-ust/string-utils.c
> index d597da3..cc61038 100644
> --- a/liblttng-ust/string-utils.c
> +++ b/liblttng-ust/string-utils.c
> @@ -124,139 +124,139 @@ retry:
>* Example:
>*
>* candidate: hi ev every onyx one
> -  *  ^
> +  *^
>* pattern:   hi*every*one
> -  *  ^
> +  *^
>*
>* candidate: hi ev every onyx one
> -  *   ^
> +  * ^
>* pattern:   hi*every*one
> -  *   ^
> +  * ^
>*
>* candidate: hi ev every onyx one
> -  *^
> +  *  ^
>* pattern:   hi*every*one
> -  *^
> +  *  ^
>*
>* candidate: hi ev every onyx one
> -  *^
> +  *  ^
>* pattern:   hi*every*one
> -  * ^ MISMATCH
> +  *   ^ MISMATCH
>*
>* candidate: hi ev every onyx one
> -  * ^
> +  *   ^
>* pattern:   hi*every*one
> -  * ^
> +  *   ^
>*
>* candidate: hi ev every onyx one
> -  * ^^
> +  *   ^^
>* pattern:   hi*every*one
> -  * ^^
> +  *   ^^
>*
>* candidate: hi ev every onyx one
> -  * ^ ^
> +  *   ^ ^
>* pattern:   hi*every*one
> -  * ^ ^ MISMATCH
> +  *   ^ ^ MISMATCH
>*
>* candidate: hi ev every onyx one
> -  *  ^
> +  *^
>* pattern:   hi*every*one
> -  * ^ MISMATCH
> +  *   ^ MISMATCH
>*
>* candidate: hi ev every onyx one
> -  *   ^
> +  * ^
>* pattern:   hi*every*one
> -  * ^ MISMATCH
> +  *   ^ MISMATCH
>*
>* candidate: hi ev every onyx one
> -  *^
> +  *  ^
>* pattern:   hi*every*one
> -  * ^
> +  *   ^
>*
>* candidate: hi ev every onyx one
> -  *^^
> +  *  ^^
>* pattern:   hi*every*one
> -  * ^^
> +  *   ^^
>*
>* candidate: hi ev every onyx one
> -  *^ ^
> +  *  ^ ^
>* pattern:   hi*every*one
> -  * ^ ^
> +  *   ^ ^
>*
>* candidate: hi ev every onyx one
> -  *^  ^
> +  *  ^  ^
>* pattern:   hi*every*one
> -  * ^  ^
> +  *   ^  ^
>*
>* candidate: hi ev every onyx one
> -  *^   ^
> +  *  ^   ^
>* pattern:   hi*every*one
> -  * ^   ^
> +  *   ^   ^
>*
>* candidate: hi ev every onyx one
> -  * ^
> +  *   ^
>* pattern:   hi*every*one
> -  *  ^
> +  *^
>*
>* candidate: hi ev every onyx one
> -  * ^
> +  *   ^
>* pattern:   hi*every*one
> -  *   ^ MISMATCH
> +  * ^ MISMATCH
>*
>* candidate: hi ev every onyx one
> -  *  ^
> +  *^
>* pattern:   hi*every*one
> -  *   ^
> +  * ^
>*
>* candidate: hi ev every onyx one
> -  *  ^^
> +  *^^
>* pattern:   hi*every*one
> -  *   ^^
> +  * ^^
>*
>  

[lttng-dev] [PATCH lttng-modules] Fix formatting in strutils_star_glob_match_char_cb explanation

[Francis Deslauriers]

Replace tabs for spaces in example scenario

Signed-off-by: Francis Deslauriers 
---
 lttng-string-utils.c | 108 +--
 1 file changed, 54 insertions(+), 54 deletions(-)

diff --git a/lttng-string-utils.c b/lttng-string-utils.c
index 94de1cf..7485380 100644
--- a/lttng-string-utils.c
+++ b/lttng-string-utils.c
@@ -145,139 +145,139 @@ retry:
 * Example:
 *
 * candidate: hi ev every onyx one
-*  ^
+*^
 * pattern:   hi*every*one
-*  ^
+*^
 *
 * candidate: hi ev every onyx one
-*   ^
+* ^
 * pattern:   hi*every*one
-*   ^
+* ^
 *
 * candidate: hi ev every onyx one
-*^
+*  ^
 * pattern:   hi*every*one
-*^
+*  ^
 *
 * candidate: hi ev every onyx one
-*^
+*  ^
 * pattern:   hi*every*one
-* ^ MISMATCH
+*   ^ MISMATCH
 *
 * candidate: hi ev every onyx one
-* ^
+*   ^
 * pattern:   hi*every*one
-* ^
+*   ^
 *
 * candidate: hi ev every onyx one
-* ^^
+*   ^^
 * pattern:   hi*every*one
-* ^^
+*   ^^
 *
 * candidate: hi ev every onyx one
-* ^ ^
+*   ^ ^
 * pattern:   hi*every*one
-* ^ ^ MISMATCH
+*   ^ ^ MISMATCH
 *
 * candidate: hi ev every onyx one
-*  ^
+*^
 * pattern:   hi*every*one
-* ^ MISMATCH
+*   ^ MISMATCH
 *
 * candidate: hi ev every onyx one
-*   ^
+* ^
 * pattern:   hi*every*one
-* ^ MISMATCH
+*   ^ MISMATCH
 *
 * candidate: hi ev every onyx one
-*^
+*  ^
 * pattern:   hi*every*one
-* ^
+*   ^
 *
 * candidate: hi ev every onyx one
-*^^
+*  ^^
 * pattern:   hi*every*one
-* ^^
+*   ^^
 *
 * candidate: hi ev every onyx one
-*^ ^
+*  ^ ^
 * pattern:   hi*every*one
-* ^ ^
+*   ^ ^
 *
 * candidate: hi ev every onyx one
-*^  ^
+*  ^  ^
 * pattern:   hi*every*one
-* ^  ^
+*   ^  ^
 *
 * candidate: hi ev every onyx one
-*^   ^
+*  ^   ^
 * pattern:   hi*every*one
-* ^   ^
+*   ^   ^
 *
 * candidate: hi ev every onyx one
-* ^
+*   ^
 * pattern:   hi*every*one
-*  ^
+*^
 *
 * candidate: hi ev every onyx one
-* ^
+*   ^
 * pattern:   hi*every*one
-*   ^ MISMATCH
+* ^ MISMATCH
 *
 * candidate: hi ev every onyx one
-*  ^
+*^
 * pattern:   hi*every*one
-*   ^
+* ^
 *
 * candidate: hi ev every onyx one
-*  ^^
+*^^
 * pattern:   hi*every*one
-*   ^^
+* ^^
 *
 * candidate: hi ev every onyx one
-*  ^ ^
+*^ ^
 * pattern:   hi*every*one
-*   ^ ^ MISMATCH
+* ^ ^ MISMATCH
 *
 * candidate: hi ev every onyx one
-*   ^
+

[lttng-dev] [PATCH lttng-ust] Fix formatting in strutils_star_glob_match explanation

[Francis Deslauriers]

Replace tabs for spaces in example scenario

Signed-off-by: Francis Deslauriers 
---
 liblttng-ust/string-utils.c | 108 ++--
 1 file changed, 54 insertions(+), 54 deletions(-)

diff --git a/liblttng-ust/string-utils.c b/liblttng-ust/string-utils.c
index d597da3..cc61038 100644
--- a/liblttng-ust/string-utils.c
+++ b/liblttng-ust/string-utils.c
@@ -124,139 +124,139 @@ retry:
 * Example:
 *
 * candidate: hi ev every onyx one
-*  ^
+*^
 * pattern:   hi*every*one
-*  ^
+*^
 *
 * candidate: hi ev every onyx one
-*   ^
+* ^
 * pattern:   hi*every*one
-*   ^
+* ^
 *
 * candidate: hi ev every onyx one
-*^
+*  ^
 * pattern:   hi*every*one
-*^
+*  ^
 *
 * candidate: hi ev every onyx one
-*^
+*  ^
 * pattern:   hi*every*one
-* ^ MISMATCH
+*   ^ MISMATCH
 *
 * candidate: hi ev every onyx one
-* ^
+*   ^
 * pattern:   hi*every*one
-* ^
+*   ^
 *
 * candidate: hi ev every onyx one
-* ^^
+*   ^^
 * pattern:   hi*every*one
-* ^^
+*   ^^
 *
 * candidate: hi ev every onyx one
-* ^ ^
+*   ^ ^
 * pattern:   hi*every*one
-* ^ ^ MISMATCH
+*   ^ ^ MISMATCH
 *
 * candidate: hi ev every onyx one
-*  ^
+*^
 * pattern:   hi*every*one
-* ^ MISMATCH
+*   ^ MISMATCH
 *
 * candidate: hi ev every onyx one
-*   ^
+* ^
 * pattern:   hi*every*one
-* ^ MISMATCH
+*   ^ MISMATCH
 *
 * candidate: hi ev every onyx one
-*^
+*  ^
 * pattern:   hi*every*one
-* ^
+*   ^
 *
 * candidate: hi ev every onyx one
-*^^
+*  ^^
 * pattern:   hi*every*one
-* ^^
+*   ^^
 *
 * candidate: hi ev every onyx one
-*^ ^
+*  ^ ^
 * pattern:   hi*every*one
-* ^ ^
+*   ^ ^
 *
 * candidate: hi ev every onyx one
-*^  ^
+*  ^  ^
 * pattern:   hi*every*one
-* ^  ^
+*   ^  ^
 *
 * candidate: hi ev every onyx one
-*^   ^
+*  ^   ^
 * pattern:   hi*every*one
-* ^   ^
+*   ^   ^
 *
 * candidate: hi ev every onyx one
-* ^
+*   ^
 * pattern:   hi*every*one
-*  ^
+*^
 *
 * candidate: hi ev every onyx one
-* ^
+*   ^
 * pattern:   hi*every*one
-*   ^ MISMATCH
+* ^ MISMATCH
 *
 * candidate: hi ev every onyx one
-*  ^
+*^
 * pattern:   hi*every*one
-*   ^
+* ^
 *
 * candidate: hi ev every onyx one
-*  ^^
+*^^
 * pattern:   hi*every*one
-*   ^^
+* ^^
 *
 * candidate: hi ev every onyx one
-*  ^ ^
+*^ ^
 * pattern:   hi*every*one
-*   ^ ^ MISMATCH
+* ^ ^ MISMATCH
 *
 * candidate: hi ev every onyx one
-*   

[lttng-dev] [PATCH babeltrace] Fix: text output missing separator when printing the domain

[Julien Desfossez]

With the "-f all" option, we expect to see
::, but instead we see
:.

Judging from the pattern of the other printed fields, the check for
"dom_print" variable seems to be missing when printing the domain.

Signed-off-by: Julien Desfossez 
---
 formats/ctf-text/ctf-text.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/formats/ctf-text/ctf-text.c b/formats/ctf-text/ctf-text.c
index f615161..69450cf 100644
--- a/formats/ctf-text/ctf-text.c
+++ b/formats/ctf-text/ctf-text.c
@@ -350,6 +350,8 @@ int ctf_text_write_event(struct bt_stream_pos *ppos, struct 
ctf_stream_definitio
set_field_names_print(pos, ITEM_HEADER);
if (pos->print_names) {
fprintf(pos->fp, "trace:domain = ");
+   } else if (dom_print) {
+   fprintf(pos->fp, ":");
}
fprintf(pos->fp, "%s", stream_class->trace->env.domain);
if (pos->print_names)
-- 
2.7.4

___
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev