[Lucene.Net] [jira] [Created] (LUCENENET-443) SpellChecker finaliser calls close regardless of if closed already
SpellChecker finaliser calls close regardless of if closed already
--
Key: LUCENENET-443
URL: https://issues.apache.org/jira/browse/LUCENENET-443
Project: Lucene.Net
Issue Type: Improvement
Components: Lucene.Net Contrib
Affects Versions: Lucene.Net 2.9.2
Reporter: Stuart Robinson
The SpellChecker Class currently has no publicly visible way of accessing the
closed field. It also calls close in the finaliser killing the process it is in
upon GC as this can throw an exceptin. I propose two changes:
Change the already existing method "IsClosed()" to public:
public bool IsClosed()
{
return closed;
}
and add a check on this in the finaliser:
~SpellChecker()
{
if (!IsClosed())
this.Close();
}
Ideally this class should implement IDisposable but I think this would be a
bigger job than this two line change.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] [Commented] (LUCENENET-443) SpellChecker finaliser calls close regardless of if closed already
[
https://issues.apache.org/jira/browse/LUCENENET-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105348#comment-13105348
]
michael herndon commented on LUCENENET-443:
---
I should have some over the weekend to fix it, though it would go into trunk
and the next release.
> SpellChecker finaliser calls close regardless of if closed already
> --
>
> Key: LUCENENET-443
> URL: https://issues.apache.org/jira/browse/LUCENENET-443
> Project: Lucene.Net
> Issue Type: Improvement
> Components: Lucene.Net Contrib
>Affects Versions: Lucene.Net 2.9.2
>Reporter: Stuart Robinson
> Labels: lucene, spellcheck, spellchecker
>
> The SpellChecker Class currently has no publicly visible way of accessing the
> closed field. It also calls close in the finaliser killing the process it is
> in upon GC as this can throw an exceptin. I propose two changes:
> Change the already existing method "IsClosed()" to public:
> public bool IsClosed()
> {
> return closed;
> }
> and add a check on this in the finaliser:
> ~SpellChecker()
> {
> if (!IsClosed())
> this.Close();
> }
> Ideally this class should implement IDisposable but I think this would be a
> bigger job than this two line change.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] [Created] (LUCENENET-444) Snowball stemmers (Portuguese, Hungarian, Romanian, Turkish)
Snowball stemmers (Portuguese, Hungarian, Romanian, Turkish) Key: LUCENENET-444 URL: https://issues.apache.org/jira/browse/LUCENENET-444 Project: Lucene.Net Issue Type: New Feature Reporter: Digy Priority: Trivial Fix For: Lucene.Net 2.9.4, Lucene.Net 3.x Some missing stemmers + a modified portuguese stemmer. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] [Updated] (LUCENENET-444) Snowball stemmers (Portuguese, Hungarian, Romanian, Turkish)
[ https://issues.apache.org/jira/browse/LUCENENET-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Digy updated LUCENENET-444: --- Fix Version/s: (was: Lucene.Net 3.x) Lucene.Net 2.9.4g > Snowball stemmers (Portuguese, Hungarian, Romanian, Turkish) > > > Key: LUCENENET-444 > URL: https://issues.apache.org/jira/browse/LUCENENET-444 > Project: Lucene.Net > Issue Type: New Feature >Reporter: Digy >Priority: Trivial > Fix For: Lucene.Net 2.9.4, Lucene.Net 2.9.4g > > > Some missing stemmers + a modified portuguese stemmer. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] [Updated] (LUCENENET-444) Snowball stemmers (Portuguese, Hungarian, Romanian, Turkish)
[ https://issues.apache.org/jira/browse/LUCENENET-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Digy updated LUCENENET-444: --- Attachment: PortugueseStemmer.cs TurkishStemmer.cs RomanianStemmer.cs HungarianStemmer.cs > Snowball stemmers (Portuguese, Hungarian, Romanian, Turkish) > > > Key: LUCENENET-444 > URL: https://issues.apache.org/jira/browse/LUCENENET-444 > Project: Lucene.Net > Issue Type: New Feature >Reporter: Digy >Priority: Trivial > Fix For: Lucene.Net 2.9.4, Lucene.Net 2.9.4g > > Attachments: HungarianStemmer.cs, PortugueseStemmer.cs, > RomanianStemmer.cs, TurkishStemmer.cs > > > Some missing stemmers + a modified portuguese stemmer. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] [Resolved] (LUCENENET-444) Snowball stemmers (Portuguese, Hungarian, Romanian, Turkish)
[ https://issues.apache.org/jira/browse/LUCENENET-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Digy resolved LUCENENET-444. Resolution: Fixed > Snowball stemmers (Portuguese, Hungarian, Romanian, Turkish) > > > Key: LUCENENET-444 > URL: https://issues.apache.org/jira/browse/LUCENENET-444 > Project: Lucene.Net > Issue Type: New Feature >Reporter: Digy >Priority: Trivial > Fix For: Lucene.Net 2.9.4, Lucene.Net 2.9.4g > > Attachments: HungarianStemmer.cs, PortugueseStemmer.cs, > RomanianStemmer.cs, TurkishStemmer.cs > > > Some missing stemmers + a modified portuguese stemmer. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] [Commented] (LUCENENET-444) Snowball stemmers (Portuguese, Hungarian, Romanian, Turkish)
[ https://issues.apache.org/jira/browse/LUCENENET-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105418#comment-13105418 ] Digy commented on LUCENENET-444: committed to trunk & 2.9.4g branch. > Snowball stemmers (Portuguese, Hungarian, Romanian, Turkish) > > > Key: LUCENENET-444 > URL: https://issues.apache.org/jira/browse/LUCENENET-444 > Project: Lucene.Net > Issue Type: New Feature >Reporter: Digy >Priority: Trivial > Fix For: Lucene.Net 2.9.4, Lucene.Net 2.9.4g > > Attachments: HungarianStemmer.cs, PortugueseStemmer.cs, > RomanianStemmer.cs, TurkishStemmer.cs > > > Some missing stemmers + a modified portuguese stemmer. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
