[jira] [Commented] (LUCENENET-446) Make Lucene.Net CLS Compliant
[ https://issues.apache.org/jira/browse/LUCENENET-446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13419915#comment-13419915 ] Prescott Nasser commented on LUCENENET-446: --- I changed most of these to internalXXX with the latest commit. There were some that could be changed to auto-properties, but some that couldn't that applied a default value. We still have some CLS issues around volitile and sbyte, but we aren't going to solve those soon I think. Make Lucene.Net CLS Compliant - Key: LUCENENET-446 URL: https://issues.apache.org/jira/browse/LUCENENET-446 Project: Lucene.Net Issue Type: Task Components: Lucene.Net Core Affects Versions: Lucene.Net 2.9.4 Reporter: Prescott Nasser Assignee: Prescott Nasser Fix For: Lucene.Net 3.0.3, Lucene.Net 3.6 Attachments: Lucene2.9.4-CLS-partial-fix Make Lucene.Net CLS Compliant -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
RE: [Lucene.Net] [jira] [Commented] (LUCENENET-446) Make Lucene.Net CLS Compliant
I'd say push it through. This needs to happen so something's will have to break - there isn't a way around it. Lets just make sure to really document what we are changing Sent from my Windows Phone From: Christopher Currens (Commented) (JIRA) Sent: 1/21/2012 12:33 AM To: lucene-net-dev@lucene.apache.org Subject: [Lucene.Net] [jira] [Commented] (LUCENENET-446) Make Lucene.Net CLS Compliant [ https://issues.apache.org/jira/browse/LUCENENET-446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13190349#comment-13190349 ] Christopher Currens commented on LUCENENET-446: --- I've decided to start work on this issue again. I'm not going to go about and change all of the signed vs unsigned types for so many reasons. I'm going to focus on just making naming CLS compliant, really just so it can be used in case-insensitive languages, like VB. The problem is that may of the variables are public (they are not public in java, and shouldn't be in .NET), so I really have no way of knowing if they are being used in external code. We have Obsolete attributes on SOME of them, but not all. Should we push through this and just make the changes or wait for another release and mark them obsoleted in the meantime? Make Lucene.Net CLS Compliant - Key: LUCENENET-446 URL: https://issues.apache.org/jira/browse/LUCENENET-446 Project: Lucene.Net Issue Type: Task Components: Lucene.Net Core Affects Versions: Lucene.Net 2.9.4 Reporter: Prescott Nasser Attachments: Lucene2.9.4-CLS-partial-fix Make Lucene.Net CLS Compliant -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [Lucene.Net] [jira] [Commented] (LUCENENET-446) Make Lucene.Net CLS Compliant
I go back and forth on this one. On one hand, people using VB.NET can't use lucene.net because of this blocking issue. On the other, it's possible people have production code (think even Stackoverflow) possibly using these fields, and changing them without obsoleting them first could cause a huge headache for them, though I realize they will have to do it at some point anyway. In most cases, it's a discrepancy between fields and properties. I would hope most people chose to use the property instead of the field. In other cases, it's a public field (that should be been private or protected internal) that has the same name as a method. So I would like more opinions here if possible, though I would rather just push it through. Unfortunately, people have gotten busy with holidays and/or work (understandable), so activity seems to be dwindling. On Sat, Jan 21, 2012 at 12:49 AM, Prescott Nasser geobmx...@hotmail.comwrote: I'd say push it through. This needs to happen so something's will have to break - there isn't a way around it. Lets just make sure to really document what we are changing Sent from my Windows Phone From: Christopher Currens (Commented) (JIRA) Sent: 1/21/2012 12:33 AM To: lucene-net-dev@lucene.apache.org Subject: [Lucene.Net] [jira] [Commented] (LUCENENET-446) Make Lucene.Net CLS Compliant [ https://issues.apache.org/jira/browse/LUCENENET-446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13190349#comment-13190349] Christopher Currens commented on LUCENENET-446: --- I've decided to start work on this issue again. I'm not going to go about and change all of the signed vs unsigned types for so many reasons. I'm going to focus on just making naming CLS compliant, really just so it can be used in case-insensitive languages, like VB. The problem is that may of the variables are public (they are not public in java, and shouldn't be in .NET), so I really have no way of knowing if they are being used in external code. We have Obsolete attributes on SOME of them, but not all. Should we push through this and just make the changes or wait for another release and mark them obsoleted in the meantime? Make Lucene.Net CLS Compliant - Key: LUCENENET-446 URL: https://issues.apache.org/jira/browse/LUCENENET-446 Project: Lucene.Net Issue Type: Task Components: Lucene.Net Core Affects Versions: Lucene.Net 2.9.4 Reporter: Prescott Nasser Attachments: Lucene2.9.4-CLS-partial-fix Make Lucene.Net CLS Compliant -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[Lucene.Net] [jira] [Commented] (LUCENENET-446) Make Lucene.Net CLS Compliant
[ https://issues.apache.org/jira/browse/LUCENENET-446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13118932#comment-13118932 ] Prescott Nasser commented on LUCENENET-446: --- Additionally, all shifting is broken (this causes an infinite loop in parts of the code - specifically the parts that write to file store (affectively making this patch useless in it's current form). The problem is that uint is not CLS compliant, and updating it to CLS Complaint (Int64) breaks shifting. Normally a -1 as a uint, would be 4Billion etc, however as an Int64, it is still -1. This means that we would have to adjust nearly all of the code relating to shifting, which is above my knowledge at the moment. Even making these changes would in my head reset our current status of having a relatively battle tested 2.9.4 release ready to go. Further, the fact that we can't fix a few of the mentioned items above (scoreDocs vs ScoreDocs, etc) we cannot make 2.9.4 CLS compliant without breaking the public api. With these issues, I think we should abandon the idea of making 2.9.4 CLS Compliant. Make Lucene.Net CLS Compliant - Key: LUCENENET-446 URL: https://issues.apache.org/jira/browse/LUCENENET-446 Project: Lucene.Net Issue Type: Task Components: Lucene.Net Core Affects Versions: Lucene.Net 2.9.4 Reporter: Prescott Nasser Attachments: Lucene2.9.4-CLS-partial-fix Make Lucene.Net CLS Compliant -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
