RE: [Lucene.Net] JIRA issues for Java Lucene changes

2011-02-23 Thread Digy 
Instead of looking at issues, use TortoiseSVN's compare revision utility.
Some issues seem to be complex but patches are really simple. See the fix
for 2 of 103 files below 

 

DIGY

 

 

Index: Constants.cs

===

--- Constants.cs  (revision 1049646)

+++ Constants.cs  (working copy)

@@ -70,7 +70,7 @@

 return s.ToString();

 }

-   public static readonly System.String LUCENE_MAIN_VERSION =
Ident("2.9.2");

+   public static readonly System.String LUCENE_MAIN_VERSION =
Ident("2.9.4");

   

public static System.String LUCENE_VERSION;

   static Constants()

Index: PriorityQueue.cs

===

--- PriorityQueue.cs(revision 1049646)

+++ PriorityQueue.cs(working copy)

@@ -92,7 +92,26 @@

 // We allocate 1 extra to avoid if statement in top()

   heapSize = 2;

 else

-   heapSize = maxSize + 1;

+{

+if (maxSize == Int32.MaxValue)

+{

+// Don't wrap heapSize to -1, in this case, which

+// causes a confusing NegativeArraySizeException.

+// Note that very likely this will simply then hit

+// an OOME, but at least that's more indicative to

+// caller that this values is too big.  We don't +1

+// in this case, but it's very unlikely in practice

+// one will actually insert this many objects into

+// the PQ:

+heapSize = Int32.MaxValue;

+}

+else

+{

+// NOTE: we add +1 because all access to heap is

+// 1-based not 0-based.  heap[0] is unused.

+heapSize = maxSize + 1;

+}

+}

 heap = new System.Object[heapSize];

 this.maxSize = maxSize;

 

 

 

 

-Original Message-
From: Lombard, Scott [mailto:slomb...@kingindustries.com] 
Sent: Thursday, February 24, 2011 12:14 AM
To: lucene-net-dev@lucene.apache.org
Subject: RE: [Lucene.Net] JIRA issues for Java Lucene changes

 

You're probably right DIGY.  I will take a look at issues and create JIRA
issues where the complexity deems it appropriate.  I will comment or patch
otherwise.

 

Scott

 

> -Original Message-

> From: Digy [mailto:digyd...@gmail.com]

> Sent: Wednesday, February 23, 2011 5:02 PM

> To: lucene-net-dev@lucene.apache.org

> Subject: RE: [Lucene.Net] JIRA issues for Java Lucene changes

> 

> In the time needed to create 10s of issues, half of the fixes could be

> done

> :)

> DIGY

> 

> -Original Message-

> From: Lombard, Scott [mailto:slomb...@kingindustries.com]

> Sent: Wednesday, February 23, 2011 11:36 PM

> To: lucene-net-dev@lucene.apache.org

> Subject: [Lucene.Net] JIRA issues for Java Lucene changes

> 

> Troy,

> 

> I will start adding separate JIRA issues tonight.  In the past do all the

> Java Lucene issues translate into .Net issues?

> 

> Scott

> 

> 

> 

> On Wed, Feb 23, 2011at 2:20 PM ,Troy Howard [mailto:thowar...@gmail.com]

> wrote:

> >

> > Scott,

> >

> > I would say the first task would be to collect all the Java changes up

> > and create separate JIRA issues for each one.

> >

> > Thanks,

> > Troy

> >

> >

> > On Wed, Feb 23, 2011 at 9:16 AM, Lombard, Scott

> >  wrote:

> > > I am on vacation next week.  So I won't be very helpful the next

> couple

> > of days.  I will be able take on some things for the 2.9.4 release.  Are

> > we going to break down the Java Lucene changes to individual items that

> > need to be ported or is it going to be handled as one big task?

> > >

> > > Scott

> > >

> > >

> > > -Original Message-

> > > From: Troy Howard [mailto:thowar...@gmail.com]

> > > Sent: Wednesday, February 23, 2011 3:32 AM

> > > To: lucene-net-dev@lucene.apache.org

> > > Subject: [Lucene.Net] Lucene.Net Tasks due by 2/28

> > >

> > > All,

> > >

> > > I've recently been updating JIRA a lot and that's causing a lot of

> > > noise on the dev list. Also, because of that noise, I fear that some

> > > of the more important details of those changes might be passing by

> > > unnoticed.

> > >

> > > Mostly, I'm trying to get the project cleaned up by the end of the

> > &

RE: [Lucene.Net] JIRA issues for Java Lucene changes

2011-02-23 Thread Digy 
We can take,for ex, a namespace like Lucene.Net.Util(+test cases) and create
a single patch for all of the related issues.
(This approach needs to work on svn history, not on issues)

DIGY


-Original Message-
From: Lombard, Scott [mailto:slomb...@kingindustries.com] 
Sent: Thursday, February 24, 2011 12:14 AM
To: lucene-net-dev@lucene.apache.org
Subject: RE: [Lucene.Net] JIRA issues for Java Lucene changes

You're probably right DIGY.  I will take a look at issues and create JIRA
issues where the complexity deems it appropriate.  I will comment or patch
otherwise.

Scott

> -Original Message-
> From: Digy [mailto:digyd...@gmail.com]
> Sent: Wednesday, February 23, 2011 5:02 PM
> To: lucene-net-dev@lucene.apache.org
> Subject: RE: [Lucene.Net] JIRA issues for Java Lucene changes
>
> In the time needed to create 10s of issues, half of the fixes could be
> done
> :)
> DIGY
>
> -Original Message-
> From: Lombard, Scott [mailto:slomb...@kingindustries.com]
> Sent: Wednesday, February 23, 2011 11:36 PM
> To: lucene-net-dev@lucene.apache.org
> Subject: [Lucene.Net] JIRA issues for Java Lucene changes
>
> Troy,
>
> I will start adding separate JIRA issues tonight.  In the past do all the
> Java Lucene issues translate into .Net issues?
>
> Scott
>
>
>
> On Wed, Feb 23, 2011at 2:20 PM ,Troy Howard [mailto:thowar...@gmail.com]
> wrote:
> >
> > Scott,
> >
> > I would say the first task would be to collect all the Java changes up
> > and create separate JIRA issues for each one.
> >
> > Thanks,
> > Troy
> >
> >
> > On Wed, Feb 23, 2011 at 9:16 AM, Lombard, Scott
> >  wrote:
> > > I am on vacation next week.  So I won't be very helpful the next
> couple
> > of days.  I will be able take on some things for the 2.9.4 release.  Are
> > we going to break down the Java Lucene changes to individual items that
> > need to be ported or is it going to be handled as one big task?
> > >
> > > Scott
> > >
> > >
> > > -Original Message-
> > > From: Troy Howard [mailto:thowar...@gmail.com]
> > > Sent: Wednesday, February 23, 2011 3:32 AM
> > > To: lucene-net-dev@lucene.apache.org
> > > Subject: [Lucene.Net] Lucene.Net Tasks due by 2/28
> > >
> > > All,
> > >
> > > I've recently been updating JIRA a lot and that's causing a lot of
> > > noise on the dev list. Also, because of that noise, I fear that some
> > > of the more important details of those changes might be passing by
> > > unnoticed.
> > >
> > > Mostly, I'm trying to get the project cleaned up by the end of the
> > > month. The goal is that March will represent a month of building out
> > > our new infrastructure and creating our first new release as a team
> > > (2.9.4). To that end, I'd like to resolve some of the outstanding
> > > questions about tooling so we can get started building out solutions
> > > with those tools. Also, I'd like to see our new status and efforts
> > > announced publicly, but I'm hesitant to draw much attention to the
> > > project until the website is updated.
> > >
> > > Additionally, I'd like to take a moment to apologize a bit for moving
> > > at such a rapid pace. I realize this is not sustainable and could
> > > cause some people to feel alienated if they don't have the time or
> > > energy right this second to match that pace. I also feel a bit
> > > self-conscious and am concerned that I'm being a little to much 'me',
> > > and perhaps not enough 'we'.
> > >
> > > I have been taking a lot of liberty regarding the project direction,
> > > bypassing some opportunities for community discussion and voting, in
> > > the interests of pushing the project forward and catching up a bit of
> > > lost time. Once we get past this initial push, I hope that we can slow
> > > down a bit, and maintain a healthy forward-moving pace with plenty of
> > > time allotted for discussion, group decision making and voting. The
> > > Apache Way is the way this project will succeed and thrive, and that
> > > requires all of us.
> > >
> > >
> > > So, that said, the outstanding tasks, which we can hopefully complete
> > > by next Monday are:
> > >
> > > Troy Howard:
> > > LUCENENET-381 - Official release of Lucene.Net 2.9.2
> > >
> > > Sergey Mirvoda:
> > > LUCENENET-398 - LUCENENET-391 Prepare the code for ingestion
> > &g

RE: [Lucene.Net] JIRA issues for Java Lucene changes

2011-02-23 Thread Lombard, Scott 
You're probably right DIGY.  I will take a look at issues and create JIRA 
issues where the complexity deems it appropriate.  I will comment or patch 
otherwise.

Scott

> -Original Message-
> From: Digy [mailto:digyd...@gmail.com]
> Sent: Wednesday, February 23, 2011 5:02 PM
> To: lucene-net-dev@lucene.apache.org
> Subject: RE: [Lucene.Net] JIRA issues for Java Lucene changes
>
> In the time needed to create 10s of issues, half of the fixes could be
> done
> :)
> DIGY
>
> -Original Message-
> From: Lombard, Scott [mailto:slomb...@kingindustries.com]
> Sent: Wednesday, February 23, 2011 11:36 PM
> To: lucene-net-dev@lucene.apache.org
> Subject: [Lucene.Net] JIRA issues for Java Lucene changes
>
> Troy,
>
> I will start adding separate JIRA issues tonight.  In the past do all the
> Java Lucene issues translate into .Net issues?
>
> Scott
>
>
>
> On Wed, Feb 23, 2011at 2:20 PM ,Troy Howard [mailto:thowar...@gmail.com]
> wrote:
> >
> > Scott,
> >
> > I would say the first task would be to collect all the Java changes up
> > and create separate JIRA issues for each one.
> >
> > Thanks,
> > Troy
> >
> >
> > On Wed, Feb 23, 2011 at 9:16 AM, Lombard, Scott
> >  wrote:
> > > I am on vacation next week.  So I won't be very helpful the next
> couple
> > of days.  I will be able take on some things for the 2.9.4 release.  Are
> > we going to break down the Java Lucene changes to individual items that
> > need to be ported or is it going to be handled as one big task?
> > >
> > > Scott
> > >
> > >
> > > -Original Message-
> > > From: Troy Howard [mailto:thowar...@gmail.com]
> > > Sent: Wednesday, February 23, 2011 3:32 AM
> > > To: lucene-net-dev@lucene.apache.org
> > > Subject: [Lucene.Net] Lucene.Net Tasks due by 2/28
> > >
> > > All,
> > >
> > > I've recently been updating JIRA a lot and that's causing a lot of
> > > noise on the dev list. Also, because of that noise, I fear that some
> > > of the more important details of those changes might be passing by
> > > unnoticed.
> > >
> > > Mostly, I'm trying to get the project cleaned up by the end of the
> > > month. The goal is that March will represent a month of building out
> > > our new infrastructure and creating our first new release as a team
> > > (2.9.4). To that end, I'd like to resolve some of the outstanding
> > > questions about tooling so we can get started building out solutions
> > > with those tools. Also, I'd like to see our new status and efforts
> > > announced publicly, but I'm hesitant to draw much attention to the
> > > project until the website is updated.
> > >
> > > Additionally, I'd like to take a moment to apologize a bit for moving
> > > at such a rapid pace. I realize this is not sustainable and could
> > > cause some people to feel alienated if they don't have the time or
> > > energy right this second to match that pace. I also feel a bit
> > > self-conscious and am concerned that I'm being a little to much 'me',
> > > and perhaps not enough 'we'.
> > >
> > > I have been taking a lot of liberty regarding the project direction,
> > > bypassing some opportunities for community discussion and voting, in
> > > the interests of pushing the project forward and catching up a bit of
> > > lost time. Once we get past this initial push, I hope that we can slow
> > > down a bit, and maintain a healthy forward-moving pace with plenty of
> > > time allotted for discussion, group decision making and voting. The
> > > Apache Way is the way this project will succeed and thrive, and that
> > > requires all of us.
> > >
> > >
> > > So, that said, the outstanding tasks, which we can hopefully complete
> > > by next Monday are:
> > >
> > > Troy Howard:
> > > LUCENENET-381 - Official release of Lucene.Net 2.9.2
> > >
> > > Sergey Mirvoda:
> > > LUCENENET-398 - LUCENENET-391 Prepare the code for ingestion
> > >
> > > Michael Herndon:
> > > LUCENENET-400 - Evaluate tooling for continuous integration server
> > >
> > > Prescott Nasser:
> > > LUCENENET-379 - Clean up Lucene.Net website
> > > LUCENENET-379 / LUCENENET-403 - Improve site layout and design
> > > LUCENENET-379 / LUCENENET-402 - Update website to reflect current
> > > status and informati

RE: [Lucene.Net] JIRA issues for Java Lucene changes

2011-02-23 Thread Digy 
In the time needed to create 10s of issues, half of the fixes could be done
:)
DIGY

-Original Message-
From: Lombard, Scott [mailto:slomb...@kingindustries.com] 
Sent: Wednesday, February 23, 2011 11:36 PM
To: lucene-net-dev@lucene.apache.org
Subject: [Lucene.Net] JIRA issues for Java Lucene changes

Troy,

I will start adding separate JIRA issues tonight.  In the past do all the
Java Lucene issues translate into .Net issues?

Scott



On Wed, Feb 23, 2011at 2:20 PM ,Troy Howard [mailto:thowar...@gmail.com]
wrote:
>
> Scott,
>
> I would say the first task would be to collect all the Java changes up
> and create separate JIRA issues for each one.
>
> Thanks,
> Troy
>
>
> On Wed, Feb 23, 2011 at 9:16 AM, Lombard, Scott
>  wrote:
> > I am on vacation next week.  So I won't be very helpful the next couple
> of days.  I will be able take on some things for the 2.9.4 release.  Are
> we going to break down the Java Lucene changes to individual items that
> need to be ported or is it going to be handled as one big task?
> >
> > Scott
> >
> >
> > -Original Message-
> > From: Troy Howard [mailto:thowar...@gmail.com]
> > Sent: Wednesday, February 23, 2011 3:32 AM
> > To: lucene-net-dev@lucene.apache.org
> > Subject: [Lucene.Net] Lucene.Net Tasks due by 2/28
> >
> > All,
> >
> > I've recently been updating JIRA a lot and that's causing a lot of
> > noise on the dev list. Also, because of that noise, I fear that some
> > of the more important details of those changes might be passing by
> > unnoticed.
> >
> > Mostly, I'm trying to get the project cleaned up by the end of the
> > month. The goal is that March will represent a month of building out
> > our new infrastructure and creating our first new release as a team
> > (2.9.4). To that end, I'd like to resolve some of the outstanding
> > questions about tooling so we can get started building out solutions
> > with those tools. Also, I'd like to see our new status and efforts
> > announced publicly, but I'm hesitant to draw much attention to the
> > project until the website is updated.
> >
> > Additionally, I'd like to take a moment to apologize a bit for moving
> > at such a rapid pace. I realize this is not sustainable and could
> > cause some people to feel alienated if they don't have the time or
> > energy right this second to match that pace. I also feel a bit
> > self-conscious and am concerned that I'm being a little to much 'me',
> > and perhaps not enough 'we'.
> >
> > I have been taking a lot of liberty regarding the project direction,
> > bypassing some opportunities for community discussion and voting, in
> > the interests of pushing the project forward and catching up a bit of
> > lost time. Once we get past this initial push, I hope that we can slow
> > down a bit, and maintain a healthy forward-moving pace with plenty of
> > time allotted for discussion, group decision making and voting. The
> > Apache Way is the way this project will succeed and thrive, and that
> > requires all of us.
> >
> >
> > So, that said, the outstanding tasks, which we can hopefully complete
> > by next Monday are:
> >
> > Troy Howard:
> > LUCENENET-381 - Official release of Lucene.Net 2.9.2
> >
> > Sergey Mirvoda:
> > LUCENENET-398 - LUCENENET-391 Prepare the code for ingestion
> >
> > Michael Herndon:
> > LUCENENET-400 - Evaluate tooling for continuous integration server
> >
> > Prescott Nasser:
> > LUCENENET-379 - Clean up Lucene.Net website
> > LUCENENET-379 / LUCENENET-403 - Improve site layout and design
> > LUCENENET-379 / LUCENENET-402 - Update website to reflect current
> > status and information
> > LUCENENET-379 / LUCENENET-401 - Update website to be Apache CMS based
> >
> > Alex Thompson:
> > LUCENENET-380 - Evaluate Sharpen as a port tool
> >
> > Does anyone feel less than confident about being able to complete
> > those tasks on that schedule? Need any help? Want to change
> > assignments?
> >
> > Anyone in the community want to get involved as a contributor on any
> > of these tasks (or any of the open tasks in JIRA that are not listed
> > here)? Sergey could probably use some help on Luke.Net. Prescott has a
> > lot of work cut out for him on the website. Perhaps we should get the
> > ball rolling on 2.9.4 task assignments for everyone else?
> >
> > Thanks,
> > Troy
> >
> >
> > This message (and any associated files) is intended only for the
> > use of the individual or entity to which it is addressed and may
> > contain information that is confidential, subject to copyright or
> > constitutes a trade secret. If you are not the intended recipient
> > you are hereby notified that any dissemination, copying or
> > distribution of this message, or files associated with this message,
> > is strictly prohibited. If you have received this message in error,
> > please notify us immediately by replying to the message and deleting
> > it from your computer.  Thank you, King Industries, Inc.
> >


This message (and any associated files) is intended only

RE: [Lucene.Net] JIRA issues for Java Lucene changes

2011-02-23 Thread Digy 
2.3.1->2.3.2 or 2.9.1 -> 2.9.2 transitions were done with just a single
patch, for ex.
DIGY

-Original Message-
From: Lombard, Scott [mailto:slomb...@kingindustries.com] 
Sent: Wednesday, February 23, 2011 11:36 PM
To: lucene-net-dev@lucene.apache.org
Subject: [Lucene.Net] JIRA issues for Java Lucene changes

Troy,

I will start adding separate JIRA issues tonight.  In the past do all the
Java Lucene issues translate into .Net issues?

Scott



On Wed, Feb 23, 2011at 2:20 PM ,Troy Howard [mailto:thowar...@gmail.com]
wrote:
>
> Scott,
>
> I would say the first task would be to collect all the Java changes up
> and create separate JIRA issues for each one.
>
> Thanks,
> Troy
>
>
> On Wed, Feb 23, 2011 at 9:16 AM, Lombard, Scott
>  wrote:
> > I am on vacation next week.  So I won't be very helpful the next couple
> of days.  I will be able take on some things for the 2.9.4 release.  Are
> we going to break down the Java Lucene changes to individual items that
> need to be ported or is it going to be handled as one big task?
> >
> > Scott
> >
> >
> > -Original Message-
> > From: Troy Howard [mailto:thowar...@gmail.com]
> > Sent: Wednesday, February 23, 2011 3:32 AM
> > To: lucene-net-dev@lucene.apache.org
> > Subject: [Lucene.Net] Lucene.Net Tasks due by 2/28
> >
> > All,
> >
> > I've recently been updating JIRA a lot and that's causing a lot of
> > noise on the dev list. Also, because of that noise, I fear that some
> > of the more important details of those changes might be passing by
> > unnoticed.
> >
> > Mostly, I'm trying to get the project cleaned up by the end of the
> > month. The goal is that March will represent a month of building out
> > our new infrastructure and creating our first new release as a team
> > (2.9.4). To that end, I'd like to resolve some of the outstanding
> > questions about tooling so we can get started building out solutions
> > with those tools. Also, I'd like to see our new status and efforts
> > announced publicly, but I'm hesitant to draw much attention to the
> > project until the website is updated.
> >
> > Additionally, I'd like to take a moment to apologize a bit for moving
> > at such a rapid pace. I realize this is not sustainable and could
> > cause some people to feel alienated if they don't have the time or
> > energy right this second to match that pace. I also feel a bit
> > self-conscious and am concerned that I'm being a little to much 'me',
> > and perhaps not enough 'we'.
> >
> > I have been taking a lot of liberty regarding the project direction,
> > bypassing some opportunities for community discussion and voting, in
> > the interests of pushing the project forward and catching up a bit of
> > lost time. Once we get past this initial push, I hope that we can slow
> > down a bit, and maintain a healthy forward-moving pace with plenty of
> > time allotted for discussion, group decision making and voting. The
> > Apache Way is the way this project will succeed and thrive, and that
> > requires all of us.
> >
> >
> > So, that said, the outstanding tasks, which we can hopefully complete
> > by next Monday are:
> >
> > Troy Howard:
> > LUCENENET-381 - Official release of Lucene.Net 2.9.2
> >
> > Sergey Mirvoda:
> > LUCENENET-398 - LUCENENET-391 Prepare the code for ingestion
> >
> > Michael Herndon:
> > LUCENENET-400 - Evaluate tooling for continuous integration server
> >
> > Prescott Nasser:
> > LUCENENET-379 - Clean up Lucene.Net website
> > LUCENENET-379 / LUCENENET-403 - Improve site layout and design
> > LUCENENET-379 / LUCENENET-402 - Update website to reflect current
> > status and information
> > LUCENENET-379 / LUCENENET-401 - Update website to be Apache CMS based
> >
> > Alex Thompson:
> > LUCENENET-380 - Evaluate Sharpen as a port tool
> >
> > Does anyone feel less than confident about being able to complete
> > those tasks on that schedule? Need any help? Want to change
> > assignments?
> >
> > Anyone in the community want to get involved as a contributor on any
> > of these tasks (or any of the open tasks in JIRA that are not listed
> > here)? Sergey could probably use some help on Luke.Net. Prescott has a
> > lot of work cut out for him on the website. Perhaps we should get the
> > ball rolling on 2.9.4 task assignments for everyone else?
> >
> > Thanks,
> > Troy
> >
> >
> > This message (and any associated files) is intended only for the
> > use of the individual or entity to which it is addressed and may
> > contain information that is confidential, subject to copyright or
> > constitutes a trade secret. If you are not the intended recipient
> > you are hereby notified that any dissemination, copying or
> > distribution of this message, or files associated with this message,
> > is strictly prohibited. If you have received this message in error,
> > please notify us immediately by replying to the message and deleting
> > it from your computer.  Thank you, King Industries, Inc.
> >


This message (and any associated files) is inten