Re: [lwip-users] DHCP Unit tests fail
On Mon, Jun 30, 2014 at 4:24 PM, Fabian Koch fabian.k...@de.abb.com wrote: Hey all, I started using the unit tests with the unix port from lwip-contrib: [..] Can anyone tell me if my setup is wrong OR The unix-port has problems OR the unit tests for DHCP are not working at the moment? I have the same problem here (and I wrote the tests). I think the problem was introduced in this patch: http://git.savannah.gnu.org/cgit/lwip.git/commit/test/unit/dhcp/test_dhcp.c?id=e1225cec5f4817248b77c773aef1feecff6e6888 /Erik ___ lwip-users mailing list lwip-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/lwip-users
[lwip-users] DHCP Unit tests fail
Hey all, I started using the unit tests with the unix port from lwip-contrib: * git cloned lwIP and lwIP-contrib * installed check (Ubuntu 12.04) $ cd lwIP-contrib/ports/unix/check $ make check Running suite(s): UDP TCP TCP_OOS MEM PBUF ETHARP DHCP 97%: Checks: 38, Failures: 1, Errors: 0 ../../../../lwip/test/unit/dhcp/test_dhcp.c:776:F:DHCP:test_dhcp_relayed:0: txpacket = 5 make: *** [check] Error 1 so I took a look at the dhcp tests at line 776 and without any knowledge of those tests, I found it odd that the check is for txpacket == 6 when a few lines above, the last check was for txpacket == 4 (unless the expectation here really is sending two packets. So if I change line 776 to expect txpacket==5 it yields: $ make check Running suite(s): UDP TCP TCP_OOS MEM PBUF ETHARP DHCP 97%: Checks: 38, Failures: 1, Errors: 0 ../../../../lwip/test/unit/dhcp/test_dhcp.c:206:F:DHCP:test_dhcp_relayed_0: data at pos 0, len 6 in packet 6 did not match make: *** [check] Error 1 Can anyone tell me if my setup is wrong OR The unix-port has problems OR the unit tests for DHCP are not working at the moment? Kind regards, Fabian ___ lwip-users mailing list lwip-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/lwip-users
Re: [lwip-users] DHCP Unit tests fail
Hi Fabian, Try posting this to the developers list, I see the same on my system with the latest version of check. However, I remember running the suite on the stable 1.4.1 when I hadn't patched it, with an older version of check, which I can't now with the latest one (and my patches...) I'm using CentOS 5.9 with check 0.9.13. Prior tests where with check 0.9.3, however, I see lots of errors against that release, so the one used by the developers on the stable branch might lie between them. In the meantime, try checking that dhcp stuff in the stable branch code (get the zip) Regards ___ lwip-users mailing list lwip-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/lwip-users
Re: [lwip-users] DHCP Unit tests fail
Got it to run now. The checks in the stable branch do not test DHCP, so I guess that in the git head is brand new or fresh. ___ lwip-users mailing list lwip-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/lwip-users