[lxc-devel] [lxc/lxc] 0b8e87: attach: don't return early when calculating namesp...

2021-04-12 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 0b8e876fbda6d7198b483ac7a96169e78f97e519
  https://github.com/lxc/lxc/commit/0b8e876fbda6d7198b483ac7a96169e78f97e519
  Author: Christian Brauner 
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: don't return early when calculating namespaces via pidfd

Signed-off-by: Christian Brauner 


  Commit: 09a83db55bf54f6afbde166f7edbe6bc68b90b67
  https://github.com/lxc/lxc/commit/09a83db55bf54f6afbde166f7edbe6bc68b90b67
  Author: Christian Brauner 
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
M src/lxc/rexec.c

  Log Message:
  ---
  Revert "rexec: mark all fds as close-on-exec if possible"

This reverts commit 531d36ad009325b74a105d9d6956e320f37b2937.

Callers might want to explicilty inhert file descriptors so we can't
close them behind their back when we exec.

Signed-off-by: Christian Brauner 


  Commit: aeff7df6e44d76a14e57646e9a63dee9c5aefbce
  https://github.com/lxc/lxc/commit/aeff7df6e44d76a14e57646e9a63dee9c5aefbce
  Author: Stéphane Graber 
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/rexec.c

  Log Message:
  ---
  Merge pull request #3779 from brauner/2021-04-12/attach_fixes

attach: fixes


Compare: https://github.com/lxc/lxc/compare/d32dcd01e730...aeff7df6e44d
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 83cb73: conf: simplify idmaptool_on_path_and_privileged()

2021-04-12 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 83cb7362189f122ce8820021d65c6fe182952950
  https://github.com/lxc/lxc/commit/83cb7362189f122ce8820021d65c6fe182952950
  Author: Christian Brauner 
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: simplify idmaptool_on_path_and_privileged()

Signed-off-by: Christian Brauner 


  Commit: a864a2e10537310c0455f843f4bfaff8dd90d222
  https://github.com/lxc/lxc/commit/a864a2e10537310c0455f843f4bfaff8dd90d222
  Author: Christian Brauner 
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: don't report success when idmaptools lack all privilege

Fixes: #3777
Signed-off-by: Christian Brauner 


  Commit: d32dcd01e730bdca53f607e861c8c646bbd4bb0d
  https://github.com/lxc/lxc/commit/d32dcd01e730bdca53f607e861c8c646bbd4bb0d
  Author: Stéphane Graber 
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  Merge pull request #3778 from brauner/2021-04-12/fixes

conf: idmaptool fixes


Compare: https://github.com/lxc/lxc/compare/965502a09cbc...d32dcd01e730
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] Upcoming migration of linuxcontainers.org mailing-lists

2021-04-07 Thread Stéphane Graber
Hello,

As part of moving some of our services to newer infrastructure,
consolidating things where they make sense and in general reducing the
amount of time I need to spend maintaining things, the
linuxcontainers.org mailing-lists will soon be migrated over to Google
Groups.

linuxcontainers.org has been a Google Workspace domain for a couple of
years now and all e-mails in and out of our mailing-lists were already
routed through Google's SMTP infrastructure with mailman used at the
mailing-list engine on our end.

As I'm re-deploying all linuxcontainers.org services on new hardware
and upgrading to more recent Linux distributions, I was left with the
following options:
 - Keep lists.linuxcontainers.org running on an older distro to keep mailman2
 - Bite the bullet and go through a full migration to mailman3 (which
for just 3 mailing-lists looks very difficult)
 - Move to an alternative solution

As we're already using Google for all e-mail delivery and the existing
Google Workspace plan I'm using includes the full version of Google
Groups, that seems the easiest approach, completely eliminating any
need for maintenance.

I've already migrated a couple of lists I used to host over to it and
have been able to successfully do it while retaining the entirety of
the mailing-list archive.
I intend to do the same for the linuxcontainers.org lists, effectively
stopping e-mail delivery to the lists, transfer the existing archive
over to Google Groups and then move all members over.

For existing members, this should be pretty seamless with the main
difference being for new subscribers where
https://lists.linuxcontainers.org will now send people to Google
Groups for membership management and for access to the archive. To
avoid breaking all links on Google, I'll keep a static version of the
old mailing-list archive online at their current URL so that any link
to them will keep working in the future.


I expect the transition to happen over the next week or so. I'll be
replying to this e-mail once it's all done.

Thanks!

Stéphane
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 6773e1: confile: make lxc_get_config() and lxc_get_config_...

2021-04-07 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 6773e108515b6f595e0e43b806c52f834ec88467
  https://github.com/lxc/lxc/commit/6773e108515b6f595e0e43b806c52f834ec88467
  Author: Christian Brauner 
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
M src/lxc/commands.c
M src/lxc/confile.c
M src/lxc/lxccontainer.c

  Log Message:
  ---
  confile: make lxc_get_config() and lxc_get_config_net() always return non-NULL

Introduce the concept of an unsupported config item.

Signed-off-by: Christian Brauner 


  Commit: 965502a09cbc0e0cb5da2db0ad5f247a58924f79
  https://github.com/lxc/lxc/commit/965502a09cbc0e0cb5da2db0ad5f247a58924f79
  Author: Stéphane Graber 
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
M src/lxc/commands.c
M src/lxc/confile.c
M src/lxc/lxccontainer.c

  Log Message:
  ---
  Merge pull request #3775 from brauner/2021-04-07/fixes

confile: make lxc_get_config() and lxc_get_config_net() always return…


Compare: https://github.com/lxc/lxc/compare/33c0a5466e0d...965502a09cbc
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 0a3b86: macro: ensure ret_errno() always returns negative

2021-04-07 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 0a3b86f90ceac8de887095fc7904851d67fac413
  https://github.com/lxc/lxc/commit/0a3b86f90ceac8de887095fc7904851d67fac413
  Author: Christian Brauner 
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
M src/lxc/macro.h

  Log Message:
  ---
  macro: ensure ret_errno() always returns negative

Signed-off-by: Christian Brauner 


  Commit: c3cef319e34c5041833387136b89881634fe982c
  https://github.com/lxc/lxc/commit/c3cef319e34c5041833387136b89881634fe982c
  Author: Christian Brauner 
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
M src/lxc/log.h

  Log Message:
  ---
  log: add error_ret()

Signed-off-by: Christian Brauner 


  Commit: ae393e1328b5c107d1ffc735cfdd25690a2702ff
  https://github.com/lxc/lxc/commit/ae393e1328b5c107d1ffc735cfdd25690a2702ff
  Author: Christian Brauner 
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: enforce maximum subkey length

Signed-off-by: Christian Brauner 


  Commit: f0c6219acbc68553921fc599f1939cdbd1999e0b
  https://github.com/lxc/lxc/commit/f0c6219acbc68553921fc599f1939cdbd1999e0b
  Author: Stéphane Graber 
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/log.h
M src/lxc/macro.h

  Log Message:
  ---
  Merge pull request #3773 from brauner/2021-04-06/fixes_2

confile & log: fixes


Compare: https://github.com/lxc/lxc/compare/9d984c3fb5b4...f0c6219acbc6
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 655d10: templates/*.in: fixed PATH handling with spaces

2021-04-06 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 655d10ed7f4eff465cf2be1f0a3664f86df7b83c
  https://github.com/lxc/lxc/commit/655d10ed7f4eff465cf2be1f0a3664f86df7b83c
  Author: Christian Ratzenhofer 
  Date:   2021-04-06 (Tue, 06 Apr 2021)

  Changed paths:
M templates/lxc-busybox.in
M templates/lxc-download.in
M templates/lxc-local.in
M templates/lxc-oci.in

  Log Message:
  ---
  templates/*.in: fixed PATH handling with spaces

if $PATH already contains a path with a space the append of the
default directories in all template scripts fails with an error
like the following:

/usr/share/lxc/templates/lxc-download: 69: export: (x86)/NVIDIA: bad
variable name

Signed-off-by: Christian Ratzenhofer 


  Commit: ace51ce88d919428889819332233075937050fc7
  https://github.com/lxc/lxc/commit/ace51ce88d919428889819332233075937050fc7
  Author: Stéphane Graber 
  Date:   2021-04-06 (Tue, 06 Apr 2021)

  Changed paths:
M templates/lxc-busybox.in
M templates/lxc-download.in
M templates/lxc-local.in
M templates/lxc-oci.in

  Log Message:
  ---
  Merge pull request #3772 from merlin1991/master

templates/*.in: fixed PATH handling with spaces


Compare: https://github.com/lxc/lxc/compare/093bfcc83cb5...ace51ce88d91
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 1f0a3b: conf: fix setups where /dev is outside of LXC's co...

2021-04-06 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 1f0a3b6e48bf84a1405affeb52b8cdb4b19fcfce
  https://github.com/lxc/lxc/commit/1f0a3b6e48bf84a1405affeb52b8cdb4b19fcfce
  Author: Christian Brauner 
  Date:   2021-04-06 (Tue, 06 Apr 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: fix setups where /dev is outside of LXC's control

Fixes: #3770
Suggested-by: Ruben Jenster 
Signed-off-by: Christian Brauner 


  Commit: e2c8dbd8bc78784c831a19ac25500960f0601c6e
  https://github.com/lxc/lxc/commit/e2c8dbd8bc78784c831a19ac25500960f0601c6e
  Author: Christian Brauner 
  Date:   2021-04-06 (Tue, 06 Apr 2021)

  Changed paths:
M src/lxc/log.h

  Log Message:
  ---
  log: ensure we always return negative errno

Signed-off-by: Christian Brauner 


  Commit: 093bfcc83cb5cdacf2f67f69fda404527b9149b8
  https://github.com/lxc/lxc/commit/093bfcc83cb5cdacf2f67f69fda404527b9149b8
  Author: Stéphane Graber 
  Date:   2021-04-06 (Tue, 06 Apr 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/log.h

  Log Message:
  ---
  Merge pull request #3771 from brauner/2021-04-06/fixes

conf: fix setups where /dev is outside of LXC's control


Compare: https://github.com/lxc/lxc/compare/d75ddd9b1b5b...093bfcc83cb5
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] d6df2b: confile: complain when LXC is built without selinu...

2021-04-02 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: d6df2b8fdf11bbe01a1caf3130c6fed34a9850f1
  https://github.com/lxc/lxc/commit/d6df2b8fdf11bbe01a1caf3130c6fed34a9850f1
  Author: Christian Brauner 
  Date:   2021-04-02 (Fri, 02 Apr 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: complain when LXC is built without selinux support

Link: https://github.com/lxc/lxc/issues/3765
Signed-off-by: Christian Brauner 


  Commit: 8f899a4a127b40f9af13c8fdf116e7c9d4bfde56
  https://github.com/lxc/lxc/commit/8f899a4a127b40f9af13c8fdf116e7c9d4bfde56
  Author: Christian Brauner 
  Date:   2021-04-02 (Fri, 02 Apr 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: complain when LXC is built without AppArmor support

Signed-off-by: Christian Brauner 


  Commit: d75ddd9b1b5b083fc4562347cd44668f060286a3
  https://github.com/lxc/lxc/commit/d75ddd9b1b5b083fc4562347cd44668f060286a3
  Author: Stéphane Graber 
  Date:   2021-04-02 (Fri, 02 Apr 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  Merge pull request #3766 from brauner/2021-04-02/fixes_2

lsm: fixes


Compare: https://github.com/lxc/lxc/compare/6fde9fb187a6...d75ddd9b1b5b
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 057d2c: confile: fix lxc.namespace.share.[identifier]

2021-04-02 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 057d2caecbb11c7127a17d4eda33ba2e250a752a
  https://github.com/lxc/lxc/commit/057d2caecbb11c7127a17d4eda33ba2e250a752a
  Author: Christian Brauner 
  Date:   2021-04-02 (Fri, 02 Apr 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: fix lxc.namespace.share.[identifier]

Link: https://github.com/lxc/lxc/pull/3763/files#r606089660
Signed-off-by: Christian Brauner 


  Commit: 6fde9fb187a63f67e8790ad897f43e77c25edb27
  https://github.com/lxc/lxc/commit/6fde9fb187a63f67e8790ad897f43e77c25edb27
  Author: Stéphane Graber 
  Date:   2021-04-02 (Fri, 02 Apr 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  Merge pull request #3764 from brauner/2021-04-02/fixes

confile: fix lxc.namespace.share.[identifier]


Compare: https://github.com/lxc/lxc/compare/8aa602556a42...6fde9fb187a6
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 4c7de7: lxc_user_nic: cleanup append_alloted()

2021-04-01 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 4c7de7c5ee74d6c92cadc1e75e3f4e355baec9ba
  https://github.com/lxc/lxc/commit/4c7de7c5ee74d6c92cadc1e75e3f4e355baec9ba
  Author: Christian Brauner 
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
M src/lxc/cmd/lxc_user_nic.c

  Log Message:
  ---
  lxc_user_nic: cleanup append_alloted()

Signed-off-by: Christian Brauner 


  Commit: 68dd0ea545c9e6e9ce1c772ca7a88b663da59ddf
  https://github.com/lxc/lxc/commit/68dd0ea545c9e6e9ce1c772ca7a88b663da59ddf
  Author: Christian Brauner 
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
M src/lxc/cmd/lxc_user_nic.c

  Log Message:
  ---
  lxc_user_nic: cleanup get_alloted()

Signed-off-by: Christian Brauner 


  Commit: 5fba37a1341457363d1b172bfb3453322a1854b0
  https://github.com/lxc/lxc/commit/5fba37a1341457363d1b172bfb3453322a1854b0
  Author: Christian Brauner 
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
M src/lxc/string_utils.c
M src/lxc/string_utils.h
M src/lxc/tools/lxc_copy.c

  Log Message:
  ---
  string_utils: move to lxc-copy() sources

It's the only place where it is still used.

Signed-off-by: Christian Brauner 


  Commit: 90e69d7178610809e0531a77182dc12869455f9e
  https://github.com/lxc/lxc/commit/90e69d7178610809e0531a77182dc12869455f9e
  Author: Christian Brauner 
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
M src/lxc/string_utils.c

  Log Message:
  ---
  string_utils: ensure that errno is set on return

Signed-off-by: Christian Brauner 


  Commit: 59f5a10311c25503ad072657e8a615be0004
  https://github.com/lxc/lxc/commit/59f5a10311c25503ad072657e8a615be0004
  Author: Christian Brauner 
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
M src/lxc/string_utils.c
M src/lxc/string_utils.h

  Log Message:
  ---
  string_utils: use restrict for lxc_safe_int64_residual()

Signed-off-by: Christian Brauner 


  Commit: 7707b0e06e35fa25dee42f9295d1707389b1676c
  https://github.com/lxc/lxc/commit/7707b0e06e35fa25dee42f9295d1707389b1676c
  Author: Christian Brauner 
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/confile.h

  Log Message:
  ---
  confile: simplify get_network_config_ops()

Signed-off-by: Christian Brauner 


  Commit: 8aa602556a425eee359847aaf01015ea146fd164
  https://github.com/lxc/lxc/commit/8aa602556a425eee359847aaf01015ea146fd164
  Author: Stéphane Graber 
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
M src/lxc/cmd/lxc_user_nic.c
M src/lxc/confile.c
M src/lxc/confile.h
M src/lxc/string_utils.c
M src/lxc/string_utils.h
M src/lxc/tools/lxc_copy.c

  Log Message:
  ---
  Merge pull request #3762 from brauner/2021-03-31/fixes

fixes: Makefile, lxc-user-nic, simplify get_network_config_ops()


Compare: https://github.com/lxc/lxc/compare/b405dec645ae...8aa602556a42
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 365136: confile: cap to last bit in set_config_net_ipv4_ad...

2021-03-31 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 365136359f8bf991ed172b498909000ec18b32de
  https://github.com/lxc/lxc/commit/365136359f8bf991ed172b498909000ec18b32de
  Author: Christian Brauner 
  Date:   2021-03-31 (Wed, 31 Mar 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/macro.h

  Log Message:
  ---
  confile: cap to last bit in set_config_net_ipv4_address()

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32708
Signed-off-by: Christian Brauner 


  Commit: 6dcd23e2bd3642af93cc333d09dc7d8a59c75681
  https://github.com/lxc/lxc/commit/6dcd23e2bd3642af93cc333d09dc7d8a59c75681
  Author: Stéphane Graber 
  Date:   2021-03-31 (Wed, 31 Mar 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/macro.h

  Log Message:
  ---
  Merge pull request #3758 from brauner/2021-03-31/fixes

confile: cap to last bit in set_config_net_ipv4_address()


Compare: https://github.com/lxc/lxc/compare/ea35e2ccda17...6dcd23e2bd36
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 28e54b: string_utils: switch to path_simplify()

2021-03-30 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 28e54be15fbb9c56edd3a0733377d7668739fc93
  https://github.com/lxc/lxc/commit/28e54be15fbb9c56edd3a0733377d7668739fc93
  Author: Christian Brauner 
  Date:   2021-03-30 (Tue, 30 Mar 2021)

  Changed paths:
M src/lxc/confile_utils.c
M src/lxc/criu.c
M src/lxc/storage/overlay.c
M src/lxc/string_utils.c
M src/lxc/string_utils.h
M src/tests/lxc-test-utils.c

  Log Message:
  ---
  string_utils: switch to path_simplify()

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32689
Signed-off-by: Christian Brauner 


  Commit: 21e9bead1200c986e32a1275d074b4ee94568329
  https://github.com/lxc/lxc/commit/21e9bead1200c986e32a1275d074b4ee94568329
  Author: Stéphane Graber 
  Date:   2021-03-30 (Tue, 30 Mar 2021)

  Changed paths:
M src/lxc/confile_utils.c
M src/lxc/criu.c
M src/lxc/storage/overlay.c
M src/lxc/string_utils.c
M src/lxc/string_utils.h
M src/tests/lxc-test-utils.c

  Log Message:
  ---
  Merge pull request #3756 from brauner/2021-03-30/fixes_3

string_utils: switch to path_simplify()


Compare: https://github.com/lxc/lxc/compare/ec6de2c3e71d...21e9bead1200
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 0abcc2: confile: don't jump into the global table twice

2021-03-30 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 0abcc213e2291d718cb93484f87add9c4b640f9d
  https://github.com/lxc/lxc/commit/0abcc213e2291d718cb93484f87add9c4b640f9d
  Author: Christian Brauner 
  Date:   2021-03-30 (Tue, 30 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: don't jump into the global table twice

instead move networking keys into a subtable. This avoids even just the
remote danger of recursion and also speeds up config parsing.

Signed-off-by: Christian Brauner 


  Commit: ec6de2c3e71d98fbaf31b1db697652ec42e0fe4a
  https://github.com/lxc/lxc/commit/ec6de2c3e71d98fbaf31b1db697652ec42e0fe4a
  Author: Stéphane Graber 
  Date:   2021-03-30 (Tue, 30 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  Merge pull request #3754 from brauner/2021-03-30/fixes_2

confile: don't jump into the global table twice


Compare: https://github.com/lxc/lxc/compare/dce56ec2284f...ec6de2c3e71d
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 5f4042: autotools: remove --enable-{asan, ubsan} in favor o...

2021-03-29 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 5f404236273bb293d81788d2d26a33a57a78
  https://github.com/lxc/lxc/commit/5f404236273bb293d81788d2d26a33a57a78
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M configure.ac
M src/lxc/Makefile.am

  Log Message:
  ---
  autotools: remove --enable-{asan,ubsan} in favor of --enable-sanitizers

Signed-off-by: Christian Brauner 


  Commit: 73c852f7d68d3d38004f9006e5d04f96b21a60bd
  https://github.com/lxc/lxc/commit/73c852f7d68d3d38004f9006e5d04f96b21a60bd
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M README.md

  Log Message:
  ---
  README: remove Travis and add Github actions badge

Signed-off-by: Christian Brauner 


  Commit: dce56ec2284fc8e7f014b3b01a4f1631c4ca18ac
  https://github.com/lxc/lxc/commit/dce56ec2284fc8e7f014b3b01a4f1631c4ca18ac
  Author: Stéphane Graber 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M README.md
M configure.ac
M src/lxc/Makefile.am

  Log Message:
  ---
  Merge pull request #3750 from brauner/2021-03-29/fixes_2

autotools: remove --enable-{asan,ubsan} in favor of --enable-sanitizers


Compare: https://github.com/lxc/lxc/compare/fb33b35c8830...dce56ec2284f
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 448439: compiler: fix thread_local detection

2021-03-29 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 448439729d091f428101288fb04d7e90d2e61ef8
  https://github.com/lxc/lxc/commit/448439729d091f428101288fb04d7e90d2e61ef8
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M configure.ac
M src/lxc/compiler.h
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/initutils.c

  Log Message:
  ---
  compiler: fix thread_local detection

Signed-off-by: Christian Brauner 


  Commit: d96134fa74e1de7f8272c305cad51922b68ae1ec
  https://github.com/lxc/lxc/commit/d96134fa74e1de7f8272c305cad51922b68ae1ec
  Author: Stéphane Graber 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M configure.ac
M src/lxc/compiler.h
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/initutils.c

  Log Message:
  ---
  Merge pull request #3749 from brauner/2021-03-29/fixes

compiler: fix thread_local detection


Compare: https://github.com/lxc/lxc/compare/86624ee4a5b2...d96134fa74e1
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] e0f420: confile: safely clean previous value in set_config...

2021-03-29 Thread Stéphane Graber
to bsearch is never NULL

Signed-off-by: Christian Brauner 


  Commit: be43adcda9795c46aa80d0fdf80b78bbae879f81
  https://github.com/lxc/lxc/commit/be43adcda9795c46aa80d0fdf80b78bbae879f81
  Author: Stéphane Graber 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M configure.ac
M src/lxc/compiler.h
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/confile.c
M src/lxc/confile.h
M src/lxc/confile_utils.c
M src/lxc/confile_utils.h
M src/lxc/initutils.c
M src/lxc/lxccontainer.c
M src/tests/parse_config_file.c

  Log Message:
  ---
  Merge pull request #3748 from brauner/2021-03-29/fixes

fixes & config key validation


Compare: https://github.com/lxc/lxc/compare/cc19bc540674...be43adcda979
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 79d2f5: confile: add missing prefix validation

2021-03-28 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 79d2f54fd5f26c69c6e0c3e5e813c9752ae0cc4c
  https://github.com/lxc/lxc/commit/79d2f54fd5f26c69c6e0c3e5e813c9752ae0cc4c
  Author: Christian Brauner 
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: add missing prefix validation

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32488
Signed-off-by: Christian Brauner 


  Commit: 405b28a4de42c15a060ecb95b63fcee08b98885b
  https://github.com/lxc/lxc/commit/405b28a4de42c15a060ecb95b63fcee08b98885b
  Author: Christian Brauner 
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: don't leak memory in case multiple shmounts are set

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32503
Signed-off-by: Christian Brauner 


  Commit: 4c5479d21e4d8d0bd1ca6abc04f6800a92fd34e5
  https://github.com/lxc/lxc/commit/4c5479d21e4d8d0bd1ca6abc04f6800a92fd34e5
  Author: Christian Brauner 
  Date:   2021-03-28 (Sun, 28 Mar 2021)

  Changed paths:
M src/lxc/compiler.h
M src/lxc/confile.c
M src/lxc/string_utils.c
M src/lxc/string_utils.h
M src/tests/lxc-test-utils.c

  Log Message:
  ---
  string_utils: handle overflow correct in parse_byte_size_string()

This takes the overflow handling code from the kernel.

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32549
Signed-off-by: Christian Brauner 


  Commit: db62570f0f89cb33e6ea3f37f19ba8c028dafe2d
  https://github.com/lxc/lxc/commit/db62570f0f89cb33e6ea3f37f19ba8c028dafe2d
  Author: Stéphane Graber 
  Date:   2021-03-28 (Sun, 28 Mar 2021)

  Changed paths:
M src/lxc/compiler.h
M src/lxc/confile.c
M src/lxc/string_utils.c
M src/lxc/string_utils.h
M src/tests/lxc-test-utils.c

  Log Message:
  ---
  Merge pull request #3743 from brauner/2021-03-27/fixes_3

oss-fuzz: fixes


Compare: https://github.com/lxc/lxc/compare/d734e61169f5...db62570f0f89
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 9a096e: confile_utils: free list during lxc_remove_nic_by_...

2021-03-27 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 9a096e987e8a38735d305dcf02582a25a983d3d0
  https://github.com/lxc/lxc/commit/9a096e987e8a38735d305dcf02582a25a983d3d0
  Author: Christian Brauner 
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  confile_utils: free list during lxc_remove_nic_by_idx()

Reported-by: Evgeny Vereshchagin 
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32484
Signed-off-by: Christian Brauner 


  Commit: d734e61169f5d69a833a8b3ba37b921cbe33d606
  https://github.com/lxc/lxc/commit/d734e61169f5d69a833a8b3ba37b921cbe33d606
  Author: Stéphane Graber 
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  Merge pull request #3741 from brauner/2021-03-27/fixes_2

confile_utils: free list during lxc_remove_nic_by_idx()


Compare: https://github.com/lxc/lxc/compare/cc98c4702132...d734e61169f5
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] c45833: string_utils: always memset buf in lxc_safe_int64_...

2021-03-27 Thread Stéphane Graber
)
#9 0x432c50 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char 
const*, unsigned long)) (/home/vagrant/lxc/out/fuzz-lxc-config-read+0x432c50)
#10 0x423136 in main (/home/vagrant/lxc/out/fuzz-lxc-config-read+0x423136)
#11 0x7f2cbb992081 in __libc_start_main (/lib64/libc.so.6+0x27081)

SUMMARY: AddressSanitizer: 2 byte(s) leaked in 1 allocation(s).
```

Signed-off-by: Evgeny Vereshchagin 


  Commit: 1504790389f07348e722aa760cf06ef3234fc265
  https://github.com/lxc/lxc/commit/1504790389f07348e722aa760cf06ef3234fc265
  Author: Christian Brauner 
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: prevent recursion when parsing networks

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32558
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32484
Signed-off-by: Christian Brauner 


  Commit: b2606302dead642b1f4a352c6804cd7ab5a6c20e
  https://github.com/lxc/lxc/commit/b2606302dead642b1f4a352c6804cd7ab5a6c20e
  Author: Evgeny Vereshchagin 
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
M .github/workflows/cifuzz.yml

  Log Message:
  ---
  ci: turn on ASan on CIFuzz

Signed-off-by: Evgeny Vereshchagin 


  Commit: cc98c47021322328347d6dbffccebbea4f396e86
  https://github.com/lxc/lxc/commit/cc98c47021322328347d6dbffccebbea4f396e86
  Author: Stéphane Graber 
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
M .github/workflows/cifuzz.yml
M src/lxc/conf.c
M src/lxc/confile.c
M src/lxc/confile_utils.c
M src/lxc/string_utils.c

  Log Message:
  ---
  Merge pull request #3739 from brauner/2021-03-27/fixes

oss-fuzz: fixes


Compare: https://github.com/lxc/lxc/compare/6a374b65e718...cc98c4702132
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 0b73eb: confile_utils: improve network parser

2021-03-26 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 0b73eb0590e9c140a8d4595572ca9f85f2faddf8
  https://github.com/lxc/lxc/commit/0b73eb0590e9c140a8d4595572ca9f85f2faddf8
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/confile_utils.c

  Log Message:
  ---
  confile_utils: improve network parser

Signed-off-by: Christian Brauner 


  Commit: b2480b29508bd4068e985e1cb9fbb63a67d2531d
  https://github.com/lxc/lxc/commit/b2480b29508bd4068e985e1cb9fbb63a67d2531d
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/string_utils.c

  Log Message:
  ---
  string_utils: fix parse_byte_size_string()

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32475
Signed-off-by: Christian Brauner 


  Commit: 06fdc710a8c9962563e6cf9fc264427fd77097b6
  https://github.com/lxc/lxc/commit/06fdc710a8c9962563e6cf9fc264427fd77097b6
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/log.c

  Log Message:
  ---
  log: avoid regressions for relative log paths

We need to allow relative log paths.

Signed-off-by: Christian Brauner 


  Commit: 8c70a4080b9625f476bf2b538d4aefbfbb96c03d
  https://github.com/lxc/lxc/commit/8c70a4080b9625f476bf2b538d4aefbfbb96c03d
  Author: Stéphane Graber 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/confile_utils.c
M src/lxc/log.c
M src/lxc/string_utils.c

  Log Message:
  ---
  Merge pull request #3736 from brauner/2021-03-26/fixes_3

oss-fuzz: fixes


Compare: https://github.com/lxc/lxc/compare/6583a6509089...8c70a4080b96
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] c04f42: confile: don't leak memory when overwriting lxc.ro...

2021-03-26 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: c04f422182501585e2e92a238dc416ce21ff077d
  https://github.com/lxc/lxc/commit/c04f422182501585e2e92a238dc416ce21ff077d
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: don't leak memory when overwriting lxc.rootfs.options

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32473
Signed-off-by: Christian Brauner 


  Commit: b8e539f44814cd1760c7dc21c027d7e6c51b72fd
  https://github.com/lxc/lxc/commit/b8e539f44814cd1760c7dc21c027d7e6c51b72fd
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  confile_utils: fix real-time signal parsing

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32521
Signed-off-by: Christian Brauner 


  Commit: 786467cbdd2e170839a2f58da8f1b634388361b7
  https://github.com/lxc/lxc/commit/786467cbdd2e170839a2f58da8f1b634388361b7
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: prevent UAF in lxc_clear_limits()

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32532
Signed-off-by: Christian Brauner 


  Commit: 627c766cba4073be3280defbcc3b7ac90d19518f
  https://github.com/lxc/lxc/commit/627c766cba4073be3280defbcc3b7ac90d19518f
  Author: Stéphane Graber 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/confile.c
M src/lxc/confile_utils.c

  Log Message:
  ---
  Merge pull request #3735 from brauner/2021-03-26/fixes_2

oss-fuzz: fixes


Compare: https://github.com/lxc/lxc/compare/e50319aaaf6d...627c766cba40
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] d60ba5: confile: be stricter in config helpers

2021-03-26 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: d60ba56821985618bfe90a84b6c6c80ba1019402
  https://github.com/lxc/lxc/commit/d60ba56821985618bfe90a84b6c6c80ba1019402
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: be stricter in config helpers

We never call these helper without an initialized config afaict but
since we're now exposing these two functions to oss-fuzz directly in a
way we never do to users so let's be stricter about it.

Inspired-by: #3733
Signed-off-by: Christian Brauner 


  Commit: 6a3b579505dc70d6495ac9909d5cf69a0758ab61
  https://github.com/lxc/lxc/commit/6a3b579505dc70d6495ac9909d5cf69a0758ab61
  Author: Stéphane Graber 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  Merge pull request #3734 from brauner/2021-03-26/fixes_2

confile: be stricter in config helpers


Compare: https://github.com/lxc/lxc/compare/0912bf6b77c5...6a3b579505dc
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] a30a4e: log: dont create log file for fuzz builds

2021-03-26 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: a30a4efae5207ec3aa9aab872db8b0bb805d391e
  https://github.com/lxc/lxc/commit/a30a4efae5207ec3aa9aab872db8b0bb805d391e
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/log.c

  Log Message:
  ---
  log: dont create log file for fuzz builds

Fixes: #3730
Fixes: https://github.com/google/oss-fuzz/issues/5509
Signed-off-by: Christian Brauner 


  Commit: e459cf683160a2ab9b253d03e64e6de22576978b
  https://github.com/lxc/lxc/commit/e459cf683160a2ab9b253d03e64e6de22576978b
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/log.c

  Log Message:
  ---
  log: don't create directories for fuzz builds

Fixes: #3730
Fixes: https://github.com/google/oss-fuzz/issues/5509
Suggested-by: Evgeny Vereshchagin 
Signed-off-by: Christian Brauner 


  Commit: 2f6d309983feeb6942ca170961cf0663cbacbbd2
  https://github.com/lxc/lxc/commit/2f6d309983feeb6942ca170961cf0663cbacbbd2
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/log.c
M src/tests/parse_config_file.c

  Log Message:
  ---
  log: handle empty log name

Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32491
Signed-off-by: Christian Brauner 


  Commit: 0912bf6b77c5dd8c62c454e84d7c4c1dc861cdbc
  https://github.com/lxc/lxc/commit/0912bf6b77c5dd8c62c454e84d7c4c1dc861cdbc
  Author: Stéphane Graber 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/log.c
M src/tests/parse_config_file.c

  Log Message:
  ---
  Merge pull request #3732 from brauner/2021-03-26/fixes

log: dont create log file for fuzz builds


Compare: https://github.com/lxc/lxc/compare/27df2528171f...0912bf6b77c5
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] b5fdc1: confile: fix set_config_sysctl()

2021-03-25 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: b5fdc164e310c8c4d6d92200bd4433e8fac61c69
  https://github.com/lxc/lxc/commit/b5fdc164e310c8c4d6d92200bd4433e8fac61c69
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: fix set_config_sysctl()

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32487
Signed-off-by: Christian Brauner 


  Commit: 4a2c9b40233fd1725701feb7d9fa8326a7aeedf0
  https://github.com/lxc/lxc/commit/4a2c9b40233fd1725701feb7d9fa8326a7aeedf0
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: reinitialize sysctl list after clearing it

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32474
Signed-off-by: Christian Brauner 


  Commit: c461b9c7edbdd0d632425715a757a68d9e9df856
  https://github.com/lxc/lxc/commit/c461b9c7edbdd0d632425715a757a68d9e9df856
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  confile_utils: delete netdev from list

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32478
Signed-off-by: Christian Brauner 


  Commit: 89d34eb2eda5c2e6bf9ffa8382bba41d0257828e
  https://github.com/lxc/lxc/commit/89d34eb2eda5c2e6bf9ffa8382bba41d0257828e
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/lxc/list.h

  Log Message:
  ---
  list: add lxc_list_new() helper

Signed-off-by: Christian Brauner 


  Commit: 642751ccd07d923c1645575d900a4cfabf8d4cb6
  https://github.com/lxc/lxc/commit/642751ccd07d923c1645575d900a4cfabf8d4cb6
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: use lxc_list_new() everywhere

Signed-off-by: Christian Brauner 


  Commit: b8e43ef0bd5959a550356871de27fa3835719e87
  https://github.com/lxc/lxc/commit/b8e43ef0bd5959a550356871de27fa3835719e87
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: use lxc_list_new() everywhere

Signed-off-by: Christian Brauner 


  Commit: 27df2528171f36d88f4761abbfcfc4bb4d31a55f
  https://github.com/lxc/lxc/commit/27df2528171f36d88f4761abbfcfc4bb4d31a55f
  Author: Stéphane Graber 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/confile.c
M src/lxc/confile_utils.c
M src/lxc/list.h

  Log Message:
  ---
  Merge pull request #3729 from brauner/2021-03-25/fixes_3

oss-fuzz: fixes


Compare: https://github.com/lxc/lxc/compare/65c5bc571b94...27df2528171f
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 5b1030: confile_utils: don't free netdev twice

2021-03-25 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 5b1030e26ca9b925ea4f9f79c4939958474806db
  https://github.com/lxc/lxc/commit/5b1030e26ca9b925ea4f9f79c4939958474806db
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  confile_utils: don't free netdev twice

lxc_free_netdev() will already free the list element.

Fixes: https://github.com/google/oss-fuzz/pull/5498
Signed-off-by: Christian Brauner 


  Commit: 3c9c460953e8af3b76bae1b6d1819093c92b5ccf
  https://github.com/lxc/lxc/commit/3c9c460953e8af3b76bae1b6d1819093c92b5ccf
  Author: Stéphane Graber 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  Merge pull request #3724 from brauner/2021-03-25/fixes

confile_utils: don't free netdev twice


Compare: https://github.com/lxc/lxc/compare/38b4b216bb9d...3c9c460953e8
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 10bf1a: strchrnul: fix copy-paste braino

2021-03-23 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 10bf1adb4315d8fbc38656fbb734e27bac20f668
  https://github.com/lxc/lxc/commit/10bf1adb4315d8fbc38656fbb734e27bac20f668
  Author: Christian Brauner 
  Date:   2021-03-23 (Tue, 23 Mar 2021)

  Changed paths:
M src/include/strchrnul.c

  Log Message:
  ---
  strchrnul: fix copy-paste braino

Signed-off-by: Christian Brauner 


  Commit: 38b4b216bb9dc07b284d8a60862b3c6413a1ad57
  https://github.com/lxc/lxc/commit/38b4b216bb9dc07b284d8a60862b3c6413a1ad57
  Author: Stéphane Graber 
  Date:   2021-03-23 (Tue, 23 Mar 2021)

  Changed paths:
M src/include/strchrnul.c

  Log Message:
  ---
  Merge pull request #3720 from brauner/2021-03-23/fixes

strchrnul: fix copy-paste braino


Compare: https://github.com/lxc/lxc/compare/678d600f50c5...38b4b216bb9d
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 09c3ee: strchrnul: ignore increased required alignment war...

2021-03-22 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 09c3ee139024a1eda45c326b503a6fc33bf2737e
  https://github.com/lxc/lxc/commit/09c3ee139024a1eda45c326b503a6fc33bf2737e
  Author: Christian Brauner 
  Date:   2021-03-22 (Mon, 22 Mar 2021)

  Changed paths:
M src/include/strchrnul.c

  Log Message:
  ---
  strchrnul: ignore increased required alignment warning

Fixes: 
https://jenkins.linuxcontainers.org/view/LXC/job/lxc-build-android/7949/console
Signed-off-by: Christian Brauner 


  Commit: 678d600f50c570f78975d678d05f5e1f5996b34a
  https://github.com/lxc/lxc/commit/678d600f50c570f78975d678d05f5e1f5996b34a
  Author: Stéphane Graber 
  Date:   2021-03-22 (Mon, 22 Mar 2021)

  Changed paths:
M src/include/strchrnul.c

  Log Message:
  ---
  Merge pull request #3719 from brauner/2021-03-22/fixes

strchrnul: ignore increased required alignment warning


Compare: https://github.com/lxc/lxc/compare/1d358fe9c0c7...678d600f50c5
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 7e4ea7: configure: fix strchrnul conditiona compilation

2021-03-21 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 7e4ea7bffdf2afa7c6f8d0aa9a8c5c227ed557b4
  https://github.com/lxc/lxc/commit/7e4ea7bffdf2afa7c6f8d0aa9a8c5c227ed557b4
  Author: Christian Brauner 
  Date:   2021-03-21 (Sun, 21 Mar 2021)

  Changed paths:
M configure.ac
M src/lxc/Makefile.am

  Log Message:
  ---
  configure: fix strchrnul conditiona compilation

Signed-off-by: Christian Brauner 


  Commit: 1d358fe9c0c701bfd221f25d2a0fb502f08ff114
  https://github.com/lxc/lxc/commit/1d358fe9c0c701bfd221f25d2a0fb502f08ff114
  Author: Stéphane Graber 
  Date:   2021-03-21 (Sun, 21 Mar 2021)

  Changed paths:
M configure.ac
M src/lxc/Makefile.am

  Log Message:
  ---
  Merge pull request #3718 from brauner/2021-03-21/fixes_2

configure: fix strchrnul conditiona compilation


Compare: https://github.com/lxc/lxc/compare/3e7605b397a0...1d358fe9c0c7
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 5582dd: include: fix typo

2021-03-21 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 5582dd63c3f1ea942f14e8095eb1c923a12438ce
  https://github.com/lxc/lxc/commit/5582dd63c3f1ea942f14e8095eb1c923a12438ce
  Author: Christian Brauner 
  Date:   2021-03-21 (Sun, 21 Mar 2021)

  Changed paths:
R src/include/stchrnul.c
R src/include/stchrnul.h
A src/include/strchrnul.c
A src/include/strchrnul.h

  Log Message:
  ---
  include: fix typo

Signed-off-by: Christian Brauner 


  Commit: 3e7605b397a02533f262df6e2877c16b4065fe72
  https://github.com/lxc/lxc/commit/3e7605b397a02533f262df6e2877c16b4065fe72
  Author: Stéphane Graber 
  Date:   2021-03-21 (Sun, 21 Mar 2021)

  Changed paths:
R src/include/stchrnul.c
R src/include/stchrnul.h
A src/include/strchrnul.c
A src/include/strchrnul.h

  Log Message:
  ---
  Merge pull request #3717 from brauner/2021-03-21/fixes

include: fix typo


Compare: https://github.com/lxc/lxc/compare/f62beebe22d6...3e7605b397a0
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 88cf32: string_utils: provide a version of strchrnul() in ...

2021-03-20 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 88cf3229fe5dec0df3c560eb714c7365ba987f4d
  https://github.com/lxc/lxc/commit/88cf3229fe5dec0df3c560eb714c7365ba987f4d
  Author: Christian Brauner 
  Date:   2021-03-20 (Sat, 20 Mar 2021)

  Changed paths:
M configure.ac
A src/include/stchrnul.c
A src/include/stchrnul.h
M src/lxc/string_utils.h

  Log Message:
  ---
  string_utils: provide a version of strchrnul() in case it's not available

This should only happen on Android.

Signed-off-by: Christian Brauner 


  Commit: f62beebe22d638ae001211fc9407925d41e5ccc2
  https://github.com/lxc/lxc/commit/f62beebe22d638ae001211fc9407925d41e5ccc2
  Author: Stéphane Graber 
  Date:   2021-03-20 (Sat, 20 Mar 2021)

  Changed paths:
M configure.ac
A src/include/stchrnul.c
A src/include/stchrnul.h
M src/lxc/string_utils.h

  Log Message:
  ---
  Merge pull request #3716 from brauner/2021-03-19/fixes

string_utils: provide a version of strchrnul() in case it's not avail…


Compare: https://github.com/lxc/lxc/compare/1718e6d6018d...f62beebe22d6
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] b75c1e: rexec: don't close stderr

2021-03-18 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: b75c1e611d984a2fe48236cd779b9edb1dfbecdd
  https://github.com/lxc/lxc/commit/b75c1e611d984a2fe48236cd779b9edb1dfbecdd
  Author: Christian Brauner 
  Date:   2021-03-18 (Thu, 18 Mar 2021)

  Changed paths:
M src/lxc/rexec.c

  Log Message:
  ---
  rexec: don't close stderr

Otherwise we'll fail to attach to containers later on.

Fixes: 
https://discuss.linuxcontainers.org/t/error-failed-to-retrieve-pid-of-executing-child-process
Signed-off-by: Christian Brauner 


  Commit: 1718e6d6018d5d6072a01d92a11d5aafc314f98f
  https://github.com/lxc/lxc/commit/1718e6d6018d5d6072a01d92a11d5aafc314f98f
  Author: Stéphane Graber 
  Date:   2021-03-18 (Thu, 18 Mar 2021)

  Changed paths:
M src/lxc/rexec.c

  Log Message:
  ---
  Merge pull request #3715 from brauner/2021-03-18/fixes

rexec: don't close stderr


Compare: https://github.com/lxc/lxc/compare/45580870b05c...1718e6d6018d
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] b6153e: cgroups: ignore unused controllers

2021-03-17 Thread Stéphane Graber
  Branch: refs/heads/stable-4.0
  Home:   https://github.com/lxc/lxc
  Commit: b6153ed81899d807be2de932e364320f899d174a
  https://github.com/lxc/lxc/commit/b6153ed81899d807be2de932e364320f899d174a
  Author: Christian Brauner 
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: ignore unused controllers

Someone might have created a name= controller after the
container has started and so the container doesn't make use of this
controller.

Link: https://github.com/lxc/lxd/issues/8577
Signed-off-by: Christian Brauner 


  Commit: dcf690189a5771e931c5b974658e2287a3fca18b
  https://github.com/lxc/lxc/commit/dcf690189a5771e931c5b974658e2287a3fca18b
  Author: Christian Brauner 
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
M configure.ac
M src/lxc/macro.h

  Log Message:
  ---
  macro: define __aligned_u64 to handle kernels without such support

Signed-off-by: Christian Brauner 


  Commit: 652e39c6c5c5944010f958d9e5abaf0cae188705
  https://github.com/lxc/lxc/commit/652e39c6c5c5944010f958d9e5abaf0cae188705
  Author: Stéphane Graber 
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
A .github/workflows/build.yml
A .github/workflows/coverity.yml
A .github/workflows/static-analysis.yml
R .travis.yml
M src/tests/Makefile.am
R src/tests/travis.sh

  Log Message:
  ---
  Switch to Github actions

Travis-CI has been a disaster lately with us running out of credits or
their system thinking we're out of credit anyway...

So with Jenkins now covering arm64, let's move the rest of the CI to
Github Actions instead.

Signed-off-by: Stéphane Graber 


  Commit: 3bcb8895a40b2f0bf7dc72ced6d285f77f28b8d5
  https://github.com/lxc/lxc/commit/3bcb8895a40b2f0bf7dc72ced6d285f77f28b8d5
  Author: Stéphane Graber 
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
M .github/workflows/coverity.yml

  Log Message:
  ---
  github: Fix invalid syntax for coverity

Signed-off-by: Stéphane Graber 


Compare: https://github.com/lxc/lxc/compare/cca16c4ff90e...3bcb8895a40b
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] b1abf1: macro: define __aligned_u64 to handle kernels with...

2021-03-17 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: b1abf15db2b5fb5126ae1f9221e6e3de3b4e0768
  https://github.com/lxc/lxc/commit/b1abf15db2b5fb5126ae1f9221e6e3de3b4e0768
  Author: Christian Brauner 
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
M configure.ac
M src/lxc/macro.h

  Log Message:
  ---
  macro: define __aligned_u64 to handle kernels without such support

Signed-off-by: Christian Brauner 


  Commit: 4fece28fa1193fe3ddf995b55417d89195a230e9
  https://github.com/lxc/lxc/commit/4fece28fa1193fe3ddf995b55417d89195a230e9
  Author: Stéphane Graber 
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
M configure.ac
M src/lxc/macro.h

  Log Message:
  ---
  Merge pull request #3710 from brauner/2021-03-17/fixes

macro: define __aligned_u64 to handle kernels without such support


Compare: https://github.com/lxc/lxc/compare/0f1caf26d505...4fece28fa119
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 615941: cgroups: ignore unused controllers

2021-03-17 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 6159413bc9dfe2dc2d7598dedb36df45e5b40747
  https://github.com/lxc/lxc/commit/6159413bc9dfe2dc2d7598dedb36df45e5b40747
  Author: Christian Brauner 
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: ignore unused controllers

Someone might have created a name= controller after the
container has started and so the container doesn't make use of this
controller.

Link: https://github.com/lxc/lxd/issues/8577
Signed-off-by: Christian Brauner 


  Commit: 0f1caf26d505dd3f74eb249ebd61160e840df32d
  https://github.com/lxc/lxc/commit/0f1caf26d505dd3f74eb249ebd61160e840df32d
  Author: Stéphane Graber 
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  Merge pull request #3708 from brauner/2021-03-17/fixes

cgroups: ignore unused controllers


Compare: https://github.com/lxc/lxc/compare/f62764977dbb...0f1caf26d505
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 3dd3fc: conf: tweak comment about transient procfs mount

2021-03-09 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 3dd3fc31640e5038d05548ed277bef494493587f
  https://github.com/lxc/lxc/commit/3dd3fc31640e5038d05548ed277bef494493587f
  Author: Christian Brauner 
  Date:   2021-03-09 (Tue, 09 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: tweak comment about transient procfs mount

Signed-off-by: Christian Brauner 


  Commit: ed41e764e8e7da9283b98e20ee643ea9e39808cd
  https://github.com/lxc/lxc/commit/ed41e764e8e7da9283b98e20ee643ea9e39808cd
  Author: Christian Brauner 
  Date:   2021-03-09 (Tue, 09 Mar 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/start.c

  Log Message:
  ---
  conf: simplify dependent mount logic

Signed-off-by: Christian Brauner 


  Commit: 95258e34b568acf49d684e7c96a0c67a81498dc6
  https://github.com/lxc/lxc/commit/95258e34b568acf49d684e7c96a0c67a81498dc6
  Author: Christian Brauner 
  Date:   2021-03-09 (Tue, 09 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: ensure that procfs and sysfs are unmounted

Signed-off-by: Christian Brauner 


  Commit: 75fca1ac4750dc57a51fda25cce49a3346265956
  https://github.com/lxc/lxc/commit/75fca1ac4750dc57a51fda25cce49a3346265956
  Author: Christian Brauner 
  Date:   2021-03-09 (Tue, 09 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: cleanup automounting

Signed-off-by: Christian Brauner 


  Commit: 0d33a382094536a949da0c0fde7871d45bbb555b
  https://github.com/lxc/lxc/commit/0d33a382094536a949da0c0fde7871d45bbb555b
  Author: Christian Brauner 
  Date:   2021-03-09 (Tue, 09 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: simplify logging in lxc_mount_auto_mounts()

Signed-off-by: Christian Brauner 


  Commit: 96f306e6254270b88ba1df891aa192dfb1c90597
  https://github.com/lxc/lxc/commit/96f306e6254270b88ba1df891aa192dfb1c90597
  Author: Christian Brauner 
  Date:   2021-03-09 (Tue, 09 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: add missing newline in lxc_mount_auto_mounts()

Signed-off-by: Christian Brauner 


  Commit: f62764977dbbacda85ba9d496cb011080ebae1fe
  https://github.com/lxc/lxc/commit/f62764977dbbacda85ba9d496cb011080ebae1fe
  Author: Stéphane Graber 
  Date:   2021-03-09 (Tue, 09 Mar 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/start.c

  Log Message:
  ---
  Merge pull request #3707 from brauner/2021-03-09/fixes

conf: automount fixes


Compare: https://github.com/lxc/lxc/compare/90b7adcc5ea7...f62764977dbb
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] abd80b: start: handle CLONE_PIDFD on arm64

2021-03-05 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: abd80bded6f39ef72f0206751c1553befd50d599
  https://github.com/lxc/lxc/commit/abd80bded6f39ef72f0206751c1553befd50d599
  Author: Christian Brauner 
  Date:   2021-03-05 (Fri, 05 Mar 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  start: handle CLONE_PIDFD on arm64

Reported-by: Ondrej Kubik 
Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: 90b7adcc5ea7868a93796d2d9f9775916c245644
  https://github.com/lxc/lxc/commit/90b7adcc5ea7868a93796d2d9f9775916c245644
  Author: Stéphane Graber 
  Date:   2021-03-05 (Fri, 05 Mar 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  Merge pull request #3706 from brauner/2021-03-05/fix_aarch64

start: handle CLONE_PIDFD on arm64


Compare: https://github.com/lxc/lxc/compare/673ce312c54b...90b7adcc5ea7
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] d961eb: af_unix: vet all parameters

2021-02-27 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: d961ebd945eb3c1def0f645993739dabc80aacce
  https://github.com/lxc/lxc/commit/d961ebd945eb3c1def0f645993739dabc80aacce
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/af_unix.c

  Log Message:
  ---
  af_unix: vet all parameters

Signed-off-by: Christian Brauner 


  Commit: cfe6f43599b10951ac59fcb2ccc84a4eece8aa16
  https://github.com/lxc/lxc/commit/cfe6f43599b10951ac59fcb2ccc84a4eece8aa16
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  start: fix whitespace error

Signed-off-by: Christian Brauner 


  Commit: b49f36bcdbea7a34bdce9d4331663da17ecade61
  https://github.com/lxc/lxc/commit/b49f36bcdbea7a34bdce9d4331663da17ecade61
  Author: Stéphane Graber 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/af_unix.c
M src/lxc/start.c

  Log Message:
  ---
  Merge pull request #3700 from brauner/2021-02-26/fixes_2

small fixes


Compare: https://github.com/lxc/lxc/compare/88e27cd64195...b49f36bcdbea
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] bad2f9: network: make callback naming consistent and under...

2021-02-26 Thread Stéphane Graber
 the kernel
will allocate eth0 for the first network but the second network requests
that eth1 be renamed to eth0 in the container's network namespace which
would lead to a clash.

Note, we don't handle cases like:

 lxc.net.0.type = phys
 lxc.net.0.link = eth2
 lxc.net.0.name = eth0

 lxc.net.1.type = phys
 lxc.net.1.link = eth1
 lxc.net.1.name = eth0

That'll brutally fail of course but there's nothing we can do about it. But
this can happen when e.g. a has the following LXD configuration:

devices:
  eth2:
name: eth0
nictype: physical
parent: eth2
type: nic
  eth3:
name: eth0
nictype: physical
parent: eth3
type: nic

in the container's config and the default profile has:

devices:
  eth0:
name: eth0
network: lxdbr0
type: nic

Signed-off-by: Christian Brauner 


  Commit: 88e27cd6419509d7efd75cd5b0ba705094a91b40
  https://github.com/lxc/lxc/commit/88e27cd6419509d7efd75cd5b0ba705094a91b40
  Author: Stéphane Graber 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/confile_utils.c
M src/lxc/network.c
M src/lxc/network.h

  Log Message:
  ---
  Merge pull request #3699 from brauner/2021-02-26/network

network: fix networks with switched names


Compare: https://github.com/lxc/lxc/compare/32d40452522d...88e27cd64195
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 5f2412: commands: cleanup error handling and variable naming

2021-02-25 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 5f241268dc0deb8eecde809bde62ddf7d58b88e0
  https://github.com/lxc/lxc/commit/5f241268dc0deb8eecde809bde62ddf7d58b88e0
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: cleanup error handling and variable naming

Signed-off-by: Christian Brauner 


  Commit: 46b576e56d7098325f96cdac6efb76a236d2af0b
  https://github.com/lxc/lxc/commit/46b576e56d7098325f96cdac6efb76a236d2af0b
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: rsp_one_fd_{reap,keep}() and rsp_many_fds_reap()

Signed-off-by: Christian Brauner 


  Commit: 89d51b22cc6e3cbae592a07a9481093efed95aca
  https://github.com/lxc/lxc/commit/89d51b22cc6e3cbae592a07a9481093efed95aca
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: fix indentation

Signed-off-by: Christian Brauner 


  Commit: 6d829cd2dae509a41e5e5306c569eeb2f125352c
  https://github.com/lxc/lxc/commit/6d829cd2dae509a41e5e5306c569eeb2f125352c
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: unify fd retrieval commands

Signed-off-by: Christian Brauner 


  Commit: 060aaa395a10e50c7b21df3b3e56a71720b20582
  https://github.com/lxc/lxc/commit/060aaa395a10e50c7b21df3b3e56a71720b20582
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/af_unix.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/commands.c
M src/lxc/confile.c
M src/lxc/log.h

  Log Message:
  ---
  tree-wide: s/syerrno_set()/syserror_set()/g

Signed-off-by: Christian Brauner 


  Commit: 2d7b08959063ddcd15be57cbf22d04b0d1a92c14
  https://github.com/lxc/lxc/commit/2d7b08959063ddcd15be57cbf22d04b0d1a92c14
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/af_unix.c
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/commands.c
M src/lxc/conf.c
M src/lxc/confile_utils.c

  Log Message:
  ---
  tree-wide: start replacing instances of syserrno() with syserror()

Signed-off-by: Christian Brauner 


  Commit: 9fc21b2d84d0fe21ef66125bd28b6bed085bd92d
  https://github.com/lxc/lxc/commit/9fc21b2d84d0fe21ef66125bd28b6bed085bd92d
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/commands.c
M src/lxc/log.h

  Log Message:
  ---
  tree-wide: replace remaining instances of syserrno() with syserror_ret()

Signed-off-by: Christian Brauner 


  Commit: 81d90ee56020ed4cccdf967461154343b35d7e8e
  https://github.com/lxc/lxc/commit/81d90ee56020ed4cccdf967461154343b35d7e8e
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/log.h

  Log Message:
  ---
  log: mark logging helpers to use

Signed-off-by: Christian Brauner 


  Commit: 6d95e0b7e9c32d7b7afcecdddb3534c277ac0b12
  https://github.com/lxc/lxc/commit/6d95e0b7e9c32d7b7afcecdddb3534c277ac0b12
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/commands.c
M src/lxc/log.h

  Log Message:
  ---
  tree-wide: use new logging helpers

Signed-off-by: Christian Brauner 


  Commit: b1b38fd16db4087a64af17ce36e0aef8817d8c55
  https://github.com/lxc/lxc/commit/b1b38fd16db4087a64af17ce36e0aef8817d8c55
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/commands.c
M src/lxc/log.h

  Log Message:
  ---
  tree-wide: replace old systrace logging helpers

Signed-off-by: Christian Brauner 


  Commit: 815c378b9b3044849149f481cb406343c0f3b900
  https://github.com/lxc/lxc/commit/815c378b9b3044849149f481cb406343c0f3b900
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/log.h

  Log Message:
  ---
  tree-wide: replace old-style sysinfo logging return helper

Signed-off-by: Christian Brauner 


  Commit: 32d40452522df15bcdcb2a62f246cbfcd948f7f3
  https://github.com/lxc/lxc/commit/32d40452522df15bcdcb2a62f246cbfcd948f7f3
  Author: Stéphane Graber 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/af_unix.c
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/commands.c
M src/lxc/conf.c
M src/lxc/confile.c
M src/lxc/confile_utils.c
M src/lxc/log.h

  Log

[lxc-devel] [lxc/lxc] 0437ea: commands: use IN_SET() in lxc_cmd()

2021-02-25 Thread Stéphane Graber
: dab4f69fe083a8b91814bf15db249e04f81a28f5
  https://github.com/lxc/lxc/commit/dab4f69fe083a8b91814bf15db249e04f81a28f5
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: port lxc_cmd_get_cgroup2_fd() to new helpers

Signed-off-by: Christian Brauner 


  Commit: 962c70c562621c0bafd91956f2fbb69907a8d27c
  https://github.com/lxc/lxc/commit/962c70c562621c0bafd91956f2fbb69907a8d27c
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: port lxc_cmd_get_limit_cgroup2_fd() to new helpers

Signed-off-by: Christian Brauner 


  Commit: 57fc2dd7e63628bb8ea6f777d7b47524adbd5ba0
  https://github.com/lxc/lxc/commit/57fc2dd7e63628bb8ea6f777d7b47524adbd5ba0
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: let lxc_cmd() return ssize_t to indicate that it returns not just 0 
on success

Signed-off-by: Christian Brauner 


  Commit: 265dc73af65742b65ed4bcf025f1e7c5d5fd23b1
  https://github.com/lxc/lxc/commit/265dc73af65742b65ed4bcf025f1e7c5d5fd23b1
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/macro.h

  Log Message:
  ---
  macro: add hweight*() helpers

Signed-off-by: Christian Brauner 


  Commit: 780215cf0d9d02c7d022f18c1bf7aaed509d5835
  https://github.com/lxc/lxc/commit/780215cf0d9d02c7d022f18c1bf7aaed509d5835
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/af_unix.c
M src/lxc/af_unix.h

  Log Message:
  ---
  af_unix: allow caller and callee to negotiate expectations and reality

Signed-off-by: Christian Brauner 


  Commit: 3a9daa046cf3bab85122844a97bf076f16cb9f5d
  https://github.com/lxc/lxc/commit/3a9daa046cf3bab85122844a97bf076f16cb9f5d
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/commands.c
M src/lxc/log.h

  Log Message:
  ---
  commands: rework lxc_cmd_rsp_recv() to make it more obvious

Signed-off-by: Christian Brauner 


  Commit: d2560c4e21783606a42e8e0777a4531dec97dfab
  https://github.com/lxc/lxc/commit/d2560c4e21783606a42e8e0777a4531dec97dfab
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/commands.c
M src/lxc/commands.h

  Log Message:
  ---
  commands: improve lxc_cmd_get_tty_fd()

Signed-off-by: Christian Brauner 


  Commit: 161e4bef903ed0e8b43a82d00eae96360ec782ce
  https://github.com/lxc/lxc/commit/161e4bef903ed0e8b43a82d00eae96360ec782ce
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/tests/lxc-test-lxc-attach
M src/tests/lxc-test-unpriv

  Log Message:
  ---
  tests: add logging to lxc-test-lxc-attach

Signed-off-by: Christian Brauner 


  Commit: 8aa82616b19734a3e80394da88e922c2d9ef646c
  https://github.com/lxc/lxc/commit/8aa82616b19734a3e80394da88e922c2d9ef646c
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/log.h

  Log Message:
  ---
  log: add some more log and return helpers

Signed-off-by: Christian Brauner 


  Commit: daad4f954c67d2a46309621071fb499828c61431
  https://github.com/lxc/lxc/commit/daad4f954c67d2a46309621071fb499828c61431
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: use debug logging

It is fine to fail these commands when a new client talks to an old server or
the kernel doesn't support the necessary features.

Signed-off-by: Christian Brauner 


  Commit: 885bb002a595be4337f641e0b532ff8743da29c3
  https://github.com/lxc/lxc/commit/885bb002a595be4337f641e0b532ff8743da29c3
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: port misnamed functions to general style

Signed-off-by: Christian Brauner 


  Commit: cca31bf0ac6d673f0ff6c5bce1d1f4ca04a34396
  https://github.com/lxc/lxc/commit/cca31bf0ac6d673f0ff6c5bce1d1f4ca04a34396
  Author: Stéphane Graber 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/af_unix.c
M src/lxc/af_unix.h
M src/lxc/commands.c
M src/lxc/commands.h
M src/lxc/log.h
M src/lxc/macro.h
M src/lxc/start.c
M src/tests/lxc-test-lxc-attach
M src/tests/lxc-test-unpriv

  Log Message:
  ---
  Merge pull request #3697 from brauner/2021-02-25/fixes

commands: improvements and fixes


Compare: https://github.com/lxc/lxc/compare/2be31fed4082...cca31bf0ac6d
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http

[lxc-devel] [lxc/lxc] e84841: commands: annotate array argument

2021-02-24 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: e848413e2a6f58aa24f4363b3af5352c44d2b5ce
  https://github.com/lxc/lxc/commit/e848413e2a6f58aa24f4363b3af5352c44d2b5ce
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: annotate array argument

Signed-off-by: Christian Brauner 


  Commit: 3d971319174b87f270fdc4d609aee3868cef05f0
  https://github.com/lxc/lxc/commit/3d971319174b87f270fdc4d609aee3868cef05f0
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/commands.c
M src/lxc/commands.h
M src/lxc/compiler.h

  Log Message:
  ---
  commands: ensure that non-NULL and MAX_STATE is always passed

Signed-off-by: Christian Brauner 


  Commit: 2be31fed4082f7acc6dd691ca4463360ad5479c5
  https://github.com/lxc/lxc/commit/2be31fed4082f7acc6dd691ca4463360ad5479c5
  Author: Stéphane Graber 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/commands.c
M src/lxc/commands.h
M src/lxc/compiler.h

  Log Message:
  ---
  Merge pull request #3695 from brauner/2021-02-24/fixes_3

commands: array hardening


Compare: https://github.com/lxc/lxc/compare/2ed90529b4b8...2be31fed4082
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 9d3480: cgroups: simple variable reordering

2021-02-24 Thread Stéphane Graber
 


  Commit: 53be29113c069625ed83d87832a7cf3afb91be5f
  https://github.com/lxc/lxc/commit/53be29113c069625ed83d87832a7cf3afb91be5f
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/file_utils.c

  Log Message:
  ---
  file_utils: actually open the file for reading

Signed-off-by: Christian Brauner 


  Commit: 124b60ec3e4253341a39b2385aa559453f0cbfa9
  https://github.com/lxc/lxc/commit/124b60ec3e4253341a39b2385aa559453f0cbfa9
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: extend rsp_one_fd() to also handle additional data

Signed-off-by: Christian Brauner 


  Commit: abb6f6572c6dd48efb4e76af6f9ba7ede3db528d
  https://github.com/lxc/lxc/commit/abb6f6572c6dd48efb4e76af6f9ba7ede3db528d
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/commands.c
M src/lxc/commands.h

  Log Message:
  ---
  commands: add LXC_CMD_GET_CGROUP_FD and LXC_CMD_GET_LIMIT_CGROUP_FD

and port cgroup_get() and cgroup_set(). This means no more useless cgroup
driver initialization on ever get or set.

Signed-off-by: Christian Brauner 


  Commit: 7e85a2c423464568039d7c9ce41b07e8955f9abe
  https://github.com/lxc/lxc/commit/7e85a2c423464568039d7c9ce41b07e8955f9abe
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/commands.c
M src/lxc/commands.h
M src/lxc/terminal.c

  Log Message:
  ---
  commands: s/LXC_CMD_CONSOLE/LXC_CMD_GET_TTY_FD/g

Signed-off-by: Christian Brauner 


  Commit: 2ed90529b4b83057b068b4a029b0d1e43dc4978a
  https://github.com/lxc/lxc/commit/2ed90529b4b83057b068b4a029b0d1e43dc4978a
  Author: Stéphane Graber 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/Makefile.am
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/commands.c
M src/lxc/commands.h
M src/lxc/criu.c
A src/lxc/error_utils.h
M src/lxc/file_utils.c
M src/lxc/lxccontainer.c
M src/lxc/macro.h
M src/lxc/memory_utils.h
M src/lxc/terminal.c

  Log Message:
  ---
  Merge pull request #3694 from brauner/2021-02-24/fixes_2

commands: rework and add LXC_CMD_GET_CGROUP_FD and LXC_CMD_GET_LIMIT_CGROUP_FD


Compare: https://github.com/lxc/lxc/compare/5dc90afd4931...2ed90529b4b8
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 70ba94: commands: remove faulty use of access attribute

2021-02-23 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 70ba94fb0a59ecf1c6824cadc1cf7553221d185b
  https://github.com/lxc/lxc/commit/70ba94fb0a59ecf1c6824cadc1cf7553221d185b
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/commands.h

  Log Message:
  ---
  commands: remove faulty use of access attribute

Signed-off-by: Christian Brauner 


  Commit: 327baffea38989710189feebf27dd6df02b5762e
  https://github.com/lxc/lxc/commit/327baffea38989710189feebf27dd6df02b5762e
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: fix braino during controller list creation

Co-mounted controllers are conventionally separated by ",".

Fixes: 
https://jenkins.linuxcontainers.org/job/lxd-github-commit/1905/arch=amd64,backend=dir,compiler=golang-1.15/consoleFull
Signed-off-by: Christian Brauner 


  Commit: 6ee13f5be729da11eaaa217daf7241be0d4ee89a
  https://github.com/lxc/lxc/commit/6ee13f5be729da11eaaa217daf7241be0d4ee89a
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: be paranoid about file descriptors

Signed-off-by: Christian Brauner 


  Commit: 5dc90afd4931fe1fc14ea9b9583748f50fe71488
  https://github.com/lxc/lxc/commit/5dc90afd4931fe1fc14ea9b9583748f50fe71488
  Author: Stéphane Graber 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/commands.h

  Log Message:
  ---
  Merge pull request #3692 from brauner/2021-02-23/fixes

build fix & cgroup braino


Compare: https://github.com/lxc/lxc/compare/162402ccc178...5dc90afd4931
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 1454e5: commands: only deref once

2021-02-23 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 1454e5d9a07c597e208e586b41a689a7a963f352
  https://github.com/lxc/lxc/commit/1454e5d9a07c597e208e586b41a689a7a963f352
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: only deref once

Fixes: Coverity 1473308
Signed-off-by: Christian Brauner 


  Commit: 92fea74bfe5186184d26c5bc89bd2d8f1895574b
  https://github.com/lxc/lxc/commit/92fea74bfe5186184d26c5bc89bd2d8f1895574b
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/af_unix.c

  Log Message:
  ---
  af_unix: prevent oob writes

Fixes: Coverity 1473309
Signed-off-by: Christian Brauner 


  Commit: 2d8b9ab865ea42ba5d72a3231b7d1a98c8999fc1
  https://github.com/lxc/lxc/commit/2d8b9ab865ea42ba5d72a3231b7d1a98c8999fc1
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: fix error checking

Fixes: Coverity 1473310
Signed-off-by: Christian Brauner 


  Commit: 162402ccc1789fbeeb30d356d0b017d7df0a986b
  https://github.com/lxc/lxc/commit/162402ccc1789fbeeb30d356d0b017d7df0a986b
  Author: Stéphane Graber 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/af_unix.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/commands.c

  Log Message:
  ---
  Merge pull request #3691 from brauner/2021-02-23/fixes

Fix issues reported by Coverity


Compare: https://github.com/lxc/lxc/compare/be7715476fe4...162402ccc178
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 550ede: terminal: dumb logging down

2021-02-23 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 550ede0a94cfcd40da8434c9f8fe402347abf82f
  https://github.com/lxc/lxc/commit/550ede0a94cfcd40da8434c9f8fe402347abf82f
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/terminal.c

  Log Message:
  ---
  terminal: dumb logging down

Signed-off-by: Christian Brauner 


  Commit: 8723f88e9acae40b537b5ea71db982b73b91d4be
  https://github.com/lxc/lxc/commit/8723f88e9acae40b537b5ea71db982b73b91d4be
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/sync.h

  Log Message:
  ---
  attach: make fd sending more uniform

Signed-off-by: Christian Brauner 


  Commit: bef8f784733a601ec7e5df899d6c4039bac18a42
  https://github.com/lxc/lxc/commit/bef8f784733a601ec7e5df899d6c4039bac18a42
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: handle new and old clients

Signed-off-by: Christian Brauner 


  Commit: 7ec5eee4f0598ed68ffd90f3ca0631ae98efb8c4
  https://github.com/lxc/lxc/commit/7ec5eee4f0598ed68ffd90f3ca0631ae98efb8c4
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: handle old clients for LXC_CMD_GET_CGROUP_CTX

Signed-off-by: Christian Brauner 


  Commit: be7715476fe42a2392589934252853c14088e675
  https://github.com/lxc/lxc/commit/be7715476fe42a2392589934252853c14088e675
  Author: Stéphane Graber 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/commands.c
M src/lxc/sync.h
M src/lxc/terminal.c

  Log Message:
  ---
  Merge pull request #3690 from brauner/2021-02-21/fixes

attach: improve attaching of new clients to old servers


Compare: https://github.com/lxc/lxc/compare/b6f486373948...be7715476fe4
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 1d5446: memory_utils: fix close_equal()

2021-02-23 Thread Stéphane Graber
:
  ---
  attach: remove additional newline

Signed-off-by: Christian Brauner 


  Commit: 8a95cd827108678493d14b7f85c2ffb8861cbd2d
  https://github.com/lxc/lxc/commit/8a95cd827108678493d14b7f85c2ffb8861cbd2d
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: handle older clients gracefully

Signed-off-by: Christian Brauner 


  Commit: 00df53300b9f845a8816b717dc37a2c62748ad4d
  https://github.com/lxc/lxc/commit/00df53300b9f845a8816b717dc37a2c62748ad4d
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: verify expected file descriptors were sent

Signed-off-by: Christian Brauner 


  Commit: 3a6678c7fb34324d1c71eadbbd92d0a3510a6108
  https://github.com/lxc/lxc/commit/3a6678c7fb34324d1c71eadbbd92d0a3510a6108
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: fix namespace preservation

Signed-off-by: Christian Brauner 


  Commit: b6f48637394816bec7bd0cadfd059ac9fecf0560
  https://github.com/lxc/lxc/commit/b6f48637394816bec7bd0cadfd059ac9fecf0560
  Author: Stéphane Graber 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/af_unix.c
M src/lxc/af_unix.h
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/commands.c
M src/lxc/commands.h
M src/lxc/conf.c
M src/lxc/log.h
M src/lxc/macro.h
M src/lxc/memory_utils.h
M src/lxc/seccomp.c
M src/lxc/start.c
M src/lxc/state.c
M src/lxc/utils.h

  Log Message:
  ---
  Merge pull request #3689 from brauner/2021-02-21/fixes

cgroups: introduce fd-only cgroup attach via LXC_CMD_GET_CGROUP_CTX


Compare: https://github.com/lxc/lxc/compare/793996583cfd...b6f486373948
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] d9be3d: string_utils: move lxc_iterate_parts()

2021-02-22 Thread Stéphane Graber
/67ed60ce6b7fe4869178162f781704c04169d816
  Author: Christian Brauner 
  Date:   2021-02-21 (Sun, 21 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h

  Log Message:
  ---
  cgroups: s/container_full_path/path_con/g

Signed-off-by: Christian Brauner 


  Commit: b1b1a60f165aad57fb4990d00ae5e3944cc7360b
  https://github.com/lxc/lxc/commit/b1b1a60f165aad57fb4990d00ae5e3944cc7360b
  Author: Christian Brauner 
  Date:   2021-02-21 (Sun, 21 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h

  Log Message:
  ---
  cgroups: s/container_limit_path/path_lim/g

Signed-off-by: Christian Brauner 


  Commit: 4cd3a764562841451f8df13e4649b13d0c251d69
  https://github.com/lxc/lxc/commit/4cd3a764562841451f8df13e4649b13d0c251d69
  Author: Christian Brauner 
  Date:   2021-02-21 (Sun, 21 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgroup.h

  Log Message:
  ---
  cgroups: move cgroup2 parameters into substruct

Signed-off-by: Christian Brauner 


  Commit: 042f9e9c755ef0fbfb98acc94d166f2d52dcf282
  https://github.com/lxc/lxc/commit/042f9e9c755ef0fbfb98acc94d166f2d52dcf282
  Author: Christian Brauner 
  Date:   2021-02-21 (Sun, 21 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h

  Log Message:
  ---
  cgroups: s/cgroup2_chown/delegate/g

Signed-off-by: Christian Brauner 


  Commit: ca72ccb50fe0657a671f72ba8864ac4d46616bfc
  https://github.com/lxc/lxc/commit/ca72ccb50fe0657a671f72ba8864ac4d46616bfc
  Author: Christian Brauner 
  Date:   2021-02-21 (Sun, 21 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h

  Log Message:
  ---
  cgroups: improve utility controller handling

Signed-off-by: Christian Brauner 


  Commit: 2e85effb0053bd28418198457aab9393a3802368
  https://github.com/lxc/lxc/commit/2e85effb0053bd28418198457aab9393a3802368
  Author: Christian Brauner 
  Date:   2021-02-21 (Sun, 21 Feb 2021)

  Changed paths:
M src/lxc/file_utils.c

  Log Message:
  ---
  file_utils: tweak lxc_write_openat()

Signed-off-by: Christian Brauner 


  Commit: b8a4fe12820fdbc8883b752bcb3855c5682d0ff6
  https://github.com/lxc/lxc/commit/b8a4fe12820fdbc8883b752bcb3855c5682d0ff6
  Author: Christian Brauner 
  Date:   2021-02-21 (Sun, 21 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: fix cg_legacy_freeze() return type

Signed-off-by: Christian Brauner 


  Commit: c7a1f72aca4bd0bc12e19e8bcee3d854820f2a1c
  https://github.com/lxc/lxc/commit/c7a1f72aca4bd0bc12e19e8bcee3d854820f2a1c
  Author: Christian Brauner 
  Date:   2021-02-21 (Sun, 21 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: handle lxc.cgroup.use global parameter

Signed-off-by: Christian Brauner 


  Commit: 793996583cfd0d50bc52a927de81a3b74ea68f7a
  https://github.com/lxc/lxc/commit/793996583cfd0d50bc52a927de81a3b74ea68f7a
  Author: Stéphane Graber 
  Date:   2021-02-22 (Mon, 22 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup_utils.c
M src/lxc/cgroups/cgroup_utils.h
M src/lxc/commands.c
M src/lxc/compiler.h
M src/lxc/file_utils.c
M src/lxc/log.h
M src/lxc/macro.h
M src/lxc/memory_utils.h
M src/lxc/string_utils.h

  Log Message:
  ---
  Merge pull request #3688 from brauner/2021-02-19/fixes_2

cgroups: rework cgroup initialization


Compare: https://github.com/lxc/lxc/compare/c33840f6f997...793996583cfd
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] fc4612: cgroups: ensure no garbage is returned

2021-02-19 Thread Stéphane Graber
ice list will be reset.

For example the set of rules:

lxc.cgroup2.devices.deny = a
lxc.cgroup2.devices.allow = c *:* m
lxc.cgroup2.devices.allow = b *:* m
lxc.cgroup2.devices.allow = c 1:3 rwm

implements a "allowlist" device program, i.e. the kernel will block access to
all devices not specifically allowed in this list. This particular program
states that all character and block devices might be created but only /dev/null
might be read or written.

If we to switch to the set of rules to:

lxc.cgroup2.devices.allow = a
lxc.cgroup2.devices.deny = c *:* m
lxc.cgroup2.devices.deny = b *:* m
lxc.cgroup2.devices.deny = c 1:3 rwm

then LXC would instruct the kernel to implement a "denylist", i.e. the kernel
will allow access to all devices not specifically denied in this list. This
particular program states that no character devices or block devices might be
created and that /dev/null is not allow allowed to be read, written, or
created.

Consider the same program but followed by a rule as explained in 1. or 2.:

lxc.cgroup2.devices.allow = a
lxc.cgroup2.devices.deny = c *:* m
lxc.cgroup2.devices.deny = b *:* m
lxc.cgroup2.devices.deny = c 1:3 rwm
lxc.cgroup2.devices.allow = a

The last line will cause LXC to reset the device list without changing the type
of device program.

lxc.cgroup2.devices.allow = a
lxc.cgroup2.devices.deny = c *:* m
lxc.cgroup2.devices.deny = b *:* m
lxc.cgroup2.devices.deny = c 1:3 rwm
lxc.cgroup2.devices.deny = a

The last line will cause LXC to reset the device list and switch from a
"allowlist" program to a "denylist" program.

Signed-off-by: Christian Brauner 


  Commit: e9b3d28df4235c29a27d70ac57fe738c9f0e32bd
  https://github.com/lxc/lxc/commit/e9b3d28df4235c29a27d70ac57fe738c9f0e32bd
  Author: Christian Brauner 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M doc/lxc.container.conf.sgml.in

  Log Message:
  ---
  doc: add missing ".[controller file] suffix to lxc.cgroup{2}. key explanations

Signed-off-by: Christian Brauner 


  Commit: 5025f3a69053bbddbe6c76ffb55b4bbd5759dcc8
  https://github.com/lxc/lxc/commit/5025f3a69053bbddbe6c76ffb55b4bbd5759dcc8
  Author: Christian Brauner 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M doc/lxc.container.conf.sgml.in

  Log Message:
  ---
  doc: epxlain eBPF-based device controller semantics

Signed-off-by: Christian Brauner 


  Commit: 54dbe498b9d370a21add7f4e74fcf3c42905e3e8
  https://github.com/lxc/lxc/commit/54dbe498b9d370a21add7f4e74fcf3c42905e3e8
  Author: Christian Brauner 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M doc/lxc.container.conf.sgml.in

  Log Message:
  ---
  doc: tweak cgroup headline

Signed-off-by: Christian Brauner 


  Commit: c33840f6f997fa4946eefbd3b88008cbcab20ea2
  https://github.com/lxc/lxc/commit/c33840f6f997fa4946eefbd3b88008cbcab20ea2
  Author: Stéphane Graber 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M doc/lxc.container.conf.sgml.in
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
M src/lxc/commands.c
M src/lxc/conf.c
M src/lxc/conf.h

  Log Message:
  ---
  Merge pull request #3684 from brauner/2021-02-18/fixes_2

bpf: device cgroup improvements


Compare: https://github.com/lxc/lxc/compare/02882d8358f4...c33840f6f997
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 8b145a: file_utils: allow fd_to_buf() to fail for real

2021-02-19 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 8b145a8778f28ed1c0079c008625ce907f77bbbf
  https://github.com/lxc/lxc/commit/8b145a8778f28ed1c0079c008625ce907f77bbbf
  Author: Christian Brauner 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M src/lxc/file_utils.c

  Log Message:
  ---
  file_utils: allow fd_to_buf() to fail for real

Signed-off-by: Christian Brauner 


  Commit: ba9055c96b5088772efb710481378dbc8f90abeb
  https://github.com/lxc/lxc/commit/ba9055c96b5088772efb710481378dbc8f90abeb
  Author: Christian Brauner 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M src/lxc/lsm/apparmor.c

  Log Message:
  ---
  lsm: twek apparmor_process_label_get()

Fixes: Coverity 1473189
Fixes: Coverity 1473190
Fixes: 47f4914d88df ("apparmor: prefer /proc/.../attr/apparmor/current over 
legacy interface")
Signed-off-by: Christian Brauner 


  Commit: 02882d8358f47461fedf3353cf1ae6f617ff6cb3
  https://github.com/lxc/lxc/commit/02882d8358f47461fedf3353cf1ae6f617ff6cb3
  Author: Stéphane Graber 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M src/lxc/file_utils.c
M src/lxc/lsm/apparmor.c

  Log Message:
  ---
  Merge pull request #3687 from brauner/2021-02-19/fixes

lsm: fixes


Compare: https://github.com/lxc/lxc/compare/f43ed6a0ab5a...02882d8358f4
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] bd09ee: cgroups: make it extremely obvious that we're tran...

2021-02-18 Thread Stéphane Graber
-by: Christian Brauner 


  Commit: 354d21c49129a58b2eb985229f852358b25e54ff
  https://github.com/lxc/lxc/commit/354d21c49129a58b2eb985229f852358b25e54ff
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
M src/lxc/commands.c

  Log Message:
  ---
  bpf: let bpf_list_add_device() take the device list directly

Signed-off-by: Christian Brauner 


  Commit: d202c500d69202cbf458e55dab674193daee72b0
  https://github.com/lxc/lxc/commit/d202c500d69202cbf458e55dab674193daee72b0
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  ---
  bpf: fix return values in bpf_program_cgroup_attach()

Signed-off-by: Christian Brauner 


  Commit: fd1cf1b1ab013d25f3f1e53ac53ed7b378efaf35
  https://github.com/lxc/lxc/commit/fd1cf1b1ab013d25f3f1e53ac53ed7b378efaf35
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/compiler.h

  Log Message:
  ---
  compiler: fix fallthrough attribute

Signed-off-by: Christian Brauner 


  Commit: 0a150695b49c95e3fa3c9a787e235cfc5bfdd0b3
  https://github.com/lxc/lxc/commit/0a150695b49c95e3fa3c9a787e235cfc5bfdd0b3
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
M src/lxc/commands.c

  Log Message:
  ---
  bpf: rework live device cgroup update

Signed-off-by: Christian Brauner 


  Commit: 3d01776c501b4df7c5f201ca33eafe0f030b6609
  https://github.com/lxc/lxc/commit/3d01776c501b4df7c5f201ca33eafe0f030b6609
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/lxccontainer.c

  Log Message:
  ---
  lxccontainer: fix reboot logging

Signed-off-by: Christian Brauner 


  Commit: 284868b249cd0f39ef4ef3cf2eb476b0b20ad29a
  https://github.com/lxc/lxc/commit/284868b249cd0f39ef4ef3cf2eb476b0b20ad29a
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/memory_utils.h

  Log Message:
  ---
  memory_utils: add close_equal() and free_equal()

Signed-off-by: Christian Brauner 


  Commit: 8c49586f0dc8d09a54db6cbeb4a995d52524f691
  https://github.com/lxc/lxc/commit/8c49586f0dc8d09a54db6cbeb4a995d52524f691
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c

  Log Message:
  ---
  cgroups: use close_equal() and free_equal()

Signed-off-by: Christian Brauner 


  Commit: da03dc28e1fed8571b4de6c262a5f127dfb1fe10
  https://github.com/lxc/lxc/commit/da03dc28e1fed8571b4de6c262a5f127dfb1fe10
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  ---
  bpf: prevent double-close

Signed-off-by: Christian Brauner 


  Commit: 25903ba9c0b10728a9bf2c0e7d7a9e68c84d39a8
  https://github.com/lxc/lxc/commit/25903ba9c0b10728a9bf2c0e7d7a9e68c84d39a8
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h

  Log Message:
  ---
  bpf: make bpf_program_cgroup_attach() static

Signed-off-by: Christian Brauner 


  Commit: ad755295f15029e58e716412a88d6c8cb576c1a7
  https://github.com/lxc/lxc/commit/ad755295f15029e58e716412a88d6c8cb576c1a7
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h

  Log Message:
  ---
  bpf: simplify bpf (device) program freeing

Signed-off-by: Christian Brauner 


  Commit: 35a68d6df2c240b6604625bd34979ba64db25de7
  https://github.com/lxc/lxc/commit/35a68d6df2c240b6604625bd34979ba64db25de7
  Author: Stéphane Graber 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M configure.ac
A src/include/bpf.h
A src/include/bpf_common.h
M src/lxc/Makefile.am
M src/lxc/api_extensions.h
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
M src/lxc/commands.c
M src/lxc/compiler.h
M src/lxc/conf.h
M src/lxc/lxccontainer.c
M src/lxc/macro.h
M src/lxc/memory_utils.h
M src/lxc/utils.c

  Log Message:
  ---
  Merge pull request #3681 from brauner/2021-02-18/cgroups

cgroups: fixes & bpf rework


Compare: https://github.com/lxc/lxc/compare/599a0c6c9ccb...35a68d6df2c2
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org

[lxc-devel] [lxc/lxc] 1dd71c: conf: use saner mode for console

2021-02-18 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 1dd71c90e807bc730415eb40b51c3bea19d298a9
  https://github.com/lxc/lxc/commit/1dd71c90e807bc730415eb40b51c3bea19d298a9
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: use saner mode for console

Signed-off-by: Christian Brauner 


  Commit: f3dff0805496ed131c65a2a7abb337306dd0cf1b
  https://github.com/lxc/lxc/commit/f3dff0805496ed131c65a2a7abb337306dd0cf1b
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/start.c

  Log Message:
  ---
  start: fix non-daemonized and application containers

Signed-off-by: Christian Brauner 


  Commit: f640c8187aac72d303d2edbdc25d7b1082e330e7
  https://github.com/lxc/lxc/commit/f640c8187aac72d303d2edbdc25d7b1082e330e7
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: don't log garbage

Signed-off-by: Christian Brauner 


  Commit: 599a0c6c9ccba374dcf646175792873185246dc7
  https://github.com/lxc/lxc/commit/599a0c6c9ccba374dcf646175792873185246dc7
  Author: Stéphane Graber 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/start.c

  Log Message:
  ---
  Merge pull request #3682 from brauner/2021-02-18/fixes

console: fixes


Compare: https://github.com/lxc/lxc/compare/cca7d405fe44...599a0c6c9ccb
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] e20353: cgroups: log intermediate cleanup

2021-02-17 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: e203535895db90103f70b9ff4942139011cd67d8
  https://github.com/lxc/lxc/commit/e203535895db90103f70b9ff4942139011cd67d8
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: log intermediate cleanup

Signed-off-by: Christian Brauner 


  Commit: 9bca62b30546d6713493119c76c7676f19810f62
  https://github.com/lxc/lxc/commit/9bca62b30546d6713493119c76c7676f19810f62
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: distinguish between tmpfs and unified based cgroup layouts file 
descriptors

Signed-off-by: Christian Brauner 


  Commit: f1921f351e8c399461bd0c52b2eedd10c1d43c4f
  https://github.com/lxc/lxc/commit/f1921f351e8c399461bd0c52b2eedd10c1d43c4f
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: ensure that cgroup_root is initialized in legacy codepaths

Signed-off-by: Christian Brauner 


  Commit: 8186eb8e8a09d4d1c6b4902286a54cfcb1fb3edd
  https://github.com/lxc/lxc/commit/8186eb8e8a09d4d1c6b4902286a54cfcb1fb3edd
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: prevent cgroup mount type overwrite

Signed-off-by: Christian Brauner 


  Commit: 69c296739dbe07a34ebbb9af9f16f9aab783c203
  https://github.com/lxc/lxc/commit/69c296739dbe07a34ebbb9af9f16f9aab783c203
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: validate that only a single cgroup mount type is set

Signed-off-by: Christian Brauner 


  Commit: 9394b6dc976985f377160b5cec67def96a1642fd
  https://github.com/lxc/lxc/commit/9394b6dc976985f377160b5cec67def96a1642fd
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: use brackets to clarify check semantics

Signed-off-by: Christian Brauner 


  Commit: 51feb8dbb78ef1532dd01bdd7088abf5376191f1
  https://github.com/lxc/lxc/commit/51feb8dbb78ef1532dd01bdd7088abf5376191f1
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: use non-flag based checking now that we switched all codepaths over

Signed-off-by: Christian Brauner 


  Commit: 77410c983cc680db0baec2abc80235754e13ba6f
  https://github.com/lxc/lxc/commit/77410c983cc680db0baec2abc80235754e13ba6f
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: create controller directories if missing

Signed-off-by: Christian Brauner 


  Commit: cca7d405fe44c755533891dd27d3d273becd419b
  https://github.com/lxc/lxc/commit/cca7d405fe44c755533891dd27d3d273becd419b
  Author: Stéphane Graber 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/conf.c

  Log Message:
  ---
  Merge pull request #3680 from brauner/2021-02-17/cgroups_2

cgroups: fourth batch of cgroup fixes


Compare: https://github.com/lxc/lxc/compare/b3ad27fb434f...cca7d405fe44
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 6fec43: cgroups: reorder function arguments

2021-02-17 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 6fec43278ec4da59cb9879bcba4ce92dea6f9a9c
  https://github.com/lxc/lxc/commit/6fec43278ec4da59cb9879bcba4ce92dea6f9a9c
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: reorder function arguments

Signed-off-by: Christian Brauner 


  Commit: 2291719e82e484d05cfc1b87984ab48e8fd2eb13
  https://github.com/lxc/lxc/commit/2291719e82e484d05cfc1b87984ab48e8fd2eb13
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: remove obsolote check

In the new layout we don't need to do this.

Signed-off-by: Christian Brauner 


  Commit: cb423bd38bbabac97967d0a63020061507cb20cc
  https://github.com/lxc/lxc/commit/cb423bd38bbabac97967d0a63020061507cb20cc
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: rework cgroup tree removal on creation failure

Signed-off-by: Christian Brauner 


  Commit: 6c880cdfa1d3be358c4ab04f6346c21213bbca9a
  https://github.com/lxc/lxc/commit/6c880cdfa1d3be358c4ab04f6346c21213bbca9a
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: ensure leaf cgroup is correctly pruned on creation failure

Signed-off-by: Christian Brauner 


  Commit: a6aeb9f1b927ce314c589e5b0db2cb4eb15aef6f
  https://github.com/lxc/lxc/commit/a6aeb9f1b927ce314c589e5b0db2cb4eb15aef6f
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: rework cgroup tree creation

Signed-off-by: Christian Brauner 


  Commit: 471929c6d0dcbaeaa7748b54b7b0630887002ba6
  https://github.com/lxc/lxc/commit/471929c6d0dcbaeaa7748b54b7b0630887002ba6
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: be stricter when creating payloads

Signed-off-by: Christian Brauner 


  Commit: 1e05885505522049a51bd9e26680607d321d892e
  https://github.com/lxc/lxc/commit/1e05885505522049a51bd9e26680607d321d892e
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: don't rely on absolute path

Signed-off-by: Christian Brauner 


  Commit: 57abfbb640d7ccde951941c960ef383a2c183f27
  https://github.com/lxc/lxc/commit/57abfbb640d7ccde951941c960ef383a2c183f27
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: don't move pivot cgroup under the monitor's cgroup

Otherwise we will never be able to destroy the monitor's cgroup.

Signed-off-by: Christian Brauner 


  Commit: c1ece8951856dd5357e31df9ec38bd7e3c46f624
  https://github.com/lxc/lxc/commit/c1ece8951856dd5357e31df9ec38bd7e3c46f624
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: ensure we don't remove cgroups we didn't create

Signed-off-by: Christian Brauner 


  Commit: 9981107f554d0cb2213adafb098c17038907bca5
  https://github.com/lxc/lxc/commit/9981107f554d0cb2213adafb098c17038907bca5
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: ensure we prune the limit dir

Signed-off-by: Christian Brauner 


  Commit: 8f45c49bb1ba70e2eb1af2e64f10df853c4c22bf
  https://github.com/lxc/lxc/commit/8f45c49bb1ba70e2eb1af2e64f10df853c4c22bf
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: simplify mount opening

Signed-off-by: Christian Brauner 


  Commit: 0954f6cec901759673357d1bea48f5cb6dede5b1
  https://github.com/lxc/lxc/commit/0954f6cec901759673357d1bea48f5cb6dede5b1
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: prevent NULL pointer deref

Signed-off-by: Christian Brauner 


  Commit: b3ad27fb434f29ad293ab24f2b3833c2db756b44
  https://github.com/lxc/lxc/commit/b3ad27fb434f29ad293ab24f2b3833c2db756b44
  Author: Stéphane Graber 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  Merge pull request #3679 from brauner/2021-02-17/cgroups

cgroups: third batch of cgroup fixes


Compare: https://github.com/lxc/lxc/compare/e82bb1b36086...b3ad27fb434f

[lxc-devel] [lxc/lxc] e219f8: cgroups: s/openat()/open_at()/g

2021-02-16 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: e219f8e885d129fca3ce6da067f5f017aa8a61db
  https://github.com/lxc/lxc/commit/e219f8e885d129fca3ce6da067f5f017aa8a61db
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: s/openat()/open_at()/g

Signed-off-by: Christian Brauner 


  Commit: e4db08ed3e70f83eea681fbaa2af168a8a690aa6
  https://github.com/lxc/lxc/commit/e4db08ed3e70f83eea681fbaa2af168a8a690aa6
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: check correct variable

Signed-off-by: Christian Brauner 


  Commit: 95ab26aff7230ea5e2d1eff584e429499110ef93
  https://github.com/lxc/lxc/commit/95ab26aff7230ea5e2d1eff584e429499110ef93
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: rework unified controller delegation

Signed-off-by: Christian Brauner 


  Commit: 838d155694526ed2da3260f4255b10ccb5d85a46
  https://github.com/lxc/lxc/commit/838d155694526ed2da3260f4255b10ccb5d85a46
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  start: delegate than move into the target cgroup

This is a way more sensible model.

Signed-off-by: Christian Brauner 


  Commit: e82bb1b360897667a7d65fd32c15adeade7c
  https://github.com/lxc/lxc/commit/e82bb1b360897667a7d65fd32c15adeade7c
  Author: Stéphane Graber 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/start.c

  Log Message:
  ---
  Merge pull request #3678 from brauner/2021-02-17/unified_controller_delegation

cgroups: rework unified cgroup controller delegation


Compare: https://github.com/lxc/lxc/compare/69632022417a...e82bb1b36086
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] ba559a: namespace: add missing \0 terminator

2021-02-16 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: ba559a5b19256b0dfb4822fd04d840f4e90a279d
  https://github.com/lxc/lxc/commit/ba559a5b19256b0dfb4822fd04d840f4e90a279d
  Author: Christian Brauner 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/namespace.h

  Log Message:
  ---
  namespace: add missing \0 terminator

Link: 
https://launchpadlibrarian.net/523195972/buildlog_ubuntu-groovy-ppc64el.lxc_1%3A4.0.6+master~20210215-1740-0ubuntu1~groovy_BUILDING.txt.gz
Signed-off-by: Christian Brauner 


  Commit: 701be30e1427e72d6646329c2a514fb43a1cd8af
  https://github.com/lxc/lxc/commit/701be30e1427e72d6646329c2a514fb43a1cd8af
  Author: Christian Brauner 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: prevent double-close

Fixes: Coverity 1473183
Signed-off-by: Christian Brauner 


  Commit: a218be90f5a6f5453d87d3c9ee2d9d1e9fd2d0f6
  https://github.com/lxc/lxc/commit/a218be90f5a6f5453d87d3c9ee2d9d1e9fd2d0f6
  Author: Stéphane Graber 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/namespace.h

  Log Message:
  ---
  Merge pull request #3676 from brauner/2021-02-16/fixes

cgroups: fixes


Compare: https://github.com/lxc/lxc/compare/858f62255d92...a218be90f5a6
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 634777: file_utils: move dup_cloexec() to header

2021-02-16 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 6347774b4c20e0bc7b840053c148aec247653a8e
  https://github.com/lxc/lxc/commit/6347774b4c20e0bc7b840053c148aec247653a8e
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/file_utils.c
M src/lxc/file_utils.h

  Log Message:
  ---
  file_utils: move dup_cloexec() to header

Signed-off-by: Christian Brauner 


  Commit: c55fe36d28129391f231ae9aeef7cd3b4db31b0e
  https://github.com/lxc/lxc/commit/c55fe36d28129391f231ae9aeef7cd3b4db31b0e
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
M src/lxc/cgroups/cgroup_utils.c
M src/lxc/cgroups/cgroup_utils.h
M src/lxc/file_utils.h

  Log Message:
  ---
  cgroups: fd-only cgroup tree pruning

Signed-off-by: Christian Brauner 


  Commit: dcf6a5c7c664f4b29dac1bd6345c915e31d378c1
  https://github.com/lxc/lxc/commit/dcf6a5c7c664f4b29dac1bd6345c915e31d378c1
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: remove obsolote cgroup_tree handling

Signed-off-by: Christian Brauner 


  Commit: 69632022417ae9f1474e594dec7da8dcaffb017e
  https://github.com/lxc/lxc/commit/69632022417ae9f1474e594dec7da8dcaffb017e
  Author: Stéphane Graber 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
M src/lxc/cgroups/cgroup_utils.c
M src/lxc/cgroups/cgroup_utils.h
M src/lxc/file_utils.c
M src/lxc/file_utils.h

  Log Message:
  ---
  Merge pull request #3677 from brauner/2021-02-17/cgroup_pruning

cgroups: fd-only cgroup tree pruning


Compare: https://github.com/lxc/lxc/compare/a218be90f5a6...69632022417a
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 7414bc: cgroups: s/cg_init()/__cgroup_init()/g

2021-02-16 Thread Stéphane Graber
ue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgroup.c

  Log Message:
  ---
  cgroups: fix fd leaks

They didn't really matter because we want to keep them around for as long as
the container lives anyway.

Signed-off-by: Christian Brauner 


  Commit: 060e54d6df22d3ca30db56e2809e091f816a568e
  https://github.com/lxc/lxc/commit/060e54d6df22d3ca30db56e2809e091f816a568e
  Author: Christian Brauner 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: rework how hierarchies are added

Signed-off-by: Christian Brauner 


  Commit: 858f62255d92a8dbed020d36aed7e684a0407fce
  https://github.com/lxc/lxc/commit/858f62255d92a8dbed020d36aed7e684a0407fce
  Author: Stéphane Graber 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
M src/lxc/cgroups/cgroup_utils.c
M src/lxc/cgroups/cgroup_utils.h
M src/lxc/file_utils.c
M src/lxc/log.h
M src/lxc/string_utils.c
M src/lxc/string_utils.h

  Log Message:
  ---
  Merge pull request #3675 from brauner/2021-02-16/fixes

cgroups: second batch of cgroup fixes


Compare: https://github.com/lxc/lxc/compare/136b349c94db...858f62255d92
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] ee94a8: confile: use set_config_path_item() for most cgrou...

2021-02-15 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: ee94a8b5cfbb388e5e8b43c7fe8f2cf12989e20c
  https://github.com/lxc/lxc/commit/ee94a8b5cfbb388e5e8b43c7fe8f2cf12989e20c
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: use set_config_path_item() for most cgroup layout modifiers

Signed-off-by: Christian Brauner 


  Commit: 7d714159a3e055c384238ad68211bcea9aad338b
  https://github.com/lxc/lxc/commit/7d714159a3e055c384238ad68211bcea9aad338b
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  confile_utils: normalize paths in config items

Signed-off-by: Christian Brauner 


  Commit: 0a48ee66c6e982657584a7df7ddc621d1fed9487
  https://github.com/lxc/lxc/commit/0a48ee66c6e982657584a7df7ddc621d1fed9487
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/log.h
M src/lxc/string_utils.h

  Log Message:
  ---
  confile: forbid walking upwards for confile items that modify cgroup layout

Signed-off-by: Christian Brauner 


  Commit: f63ef155271b2848ae18fcdfb5550dddad9ec852
  https://github.com/lxc/lxc/commit/f63ef155271b2848ae18fcdfb5550dddad9ec852
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/string_utils.h

  Log Message:
  ---
  confile: forbid absolute paths in config items that modify the cgroup layout

This is not a safety measure but merely is supposed to raise awareness that
these paths are always relative to the cgroup root as determined by
lxc.cgroup.relative.

Signed-off-by: Christian Brauner 


  Commit: 136b349c94dbc573ebfe762cde4f4b91faf8f428
  https://github.com/lxc/lxc/commit/136b349c94dbc573ebfe762cde4f4b91faf8f428
  Author: Stéphane Graber 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/confile_utils.c
M src/lxc/log.h
M src/lxc/string_utils.h

  Log Message:
  ---
  Merge pull request #3674 from brauner/2021-02-15/nesting

cgroups: tighten cgroup config items


Compare: https://github.com/lxc/lxc/compare/7e925736c911...136b349c94db
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] c988c8: cgroups: move cgns_supported() to cgroup utilities

2021-02-15 Thread Stéphane Graber
/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: fix flag checking in legacy mount paths

Signed-off-by: Christian Brauner 


  Commit: 6768700d24a8cab63ea0b839b5ef42fed4cb6c56
  https://github.com/lxc/lxc/commit/6768700d24a8cab63ea0b839b5ef42fed4cb6c56
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: strip LXC_AUTO_CGROUP_MIXED and LXC_AUTO_CGROUP_FULL_MIXED when 
cgroup namespaces are supported and used

Signed-off-by: Christian Brauner 


  Commit: 44234ae1e9014ec83fe3623ce386118a4a6040ff
  https://github.com/lxc/lxc/commit/44234ae1e9014ec83fe3623ce386118a4a6040ff
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: s/__cg_mount_direct()/__cgroupfs_mount()/g

Signed-off-by: Christian Brauner 


  Commit: 3a86fb378d0bab76d14788ed2487cc4ff5f4cd4a
  https://github.com/lxc/lxc/commit/3a86fb378d0bab76d14788ed2487cc4ff5f4cd4a
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: log early return

Signed-off-by: Christian Brauner 


  Commit: a3e5ec2657e90319f375b2494dd3870a2b53ca46
  https://github.com/lxc/lxc/commit/a3e5ec2657e90319f375b2494dd3870a2b53ca46
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroupfs: rework cgroup2 mounting

We now explicitly refuse to mount cgroups on pure unified layouts when the
container is not running in a separate cgroup namespace. This is not a
regression since we simply always failed before anyway. I will likely fix this
very soon though. But there are bigger fish to fry currently.

Signed-off-by: Christian Brauner 


  Commit: 7e925736c9111f2789900989af37546df4c5ce17
  https://github.com/lxc/lxc/commit/7e925736c9111f2789900989af37546df4c5ce17
  Author: Stéphane Graber 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/cgroups/cgroup_utils.h
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/log.h
M src/lxc/lsm/apparmor.c
M src/lxc/start.c
M src/lxc/start.h
M src/lxc/utils.c
M src/lxc/utils.h
M src/tests/lxc_raw_clone.c

  Log Message:
  ---
  Merge pull request #3673 from brauner/2021-02-15/nesting

cgroups: first batch of cgroup mounting fixes


Compare: https://github.com/lxc/lxc/compare/4b9467975c21...7e925736c911
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] cb3b01: start: fix error handling and improve comment

2021-02-14 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: cb3b010c168459055c6778ab46c832a178cd4260
  https://github.com/lxc/lxc/commit/cb3b010c168459055c6778ab46c832a178cd4260
  Author: Christian Brauner 
  Date:   2021-02-14 (Sun, 14 Feb 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  start: fix error handling and improve comment

Signed-off-by: Christian Brauner 


  Commit: 857ba1f0c595d4ac42e2f0ac37ce6f2d691dedea
  https://github.com/lxc/lxc/commit/857ba1f0c595d4ac42e2f0ac37ce6f2d691dedea
  Author: Christian Brauner 
  Date:   2021-02-14 (Sun, 14 Feb 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  start: improve namespace preservation

Signed-off-by: Christian Brauner 


  Commit: 9beaca55d7712d1ee0b88cea3a3df65994b4
  https://github.com/lxc/lxc/commit/9beaca55d7712d1ee0b88cea3a3df65994b4
  Author: Christian Brauner 
  Date:   2021-02-14 (Sun, 14 Feb 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  start: improve comments

Signed-off-by: Christian Brauner 


  Commit: 3a89b0ab0a26e7651d6132522f61b7bfbc5e68fe
  https://github.com/lxc/lxc/commit/3a89b0ab0a26e7651d6132522f61b7bfbc5e68fe
  Author: Christian Brauner 
  Date:   2021-02-14 (Sun, 14 Feb 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  start: improve comment in lxc_spawn()

Signed-off-by: Christian Brauner 


  Commit: 245066afbc64622cebeb93270bcda067d2d74e20
  https://github.com/lxc/lxc/commit/245066afbc64622cebeb93270bcda067d2d74e20
  Author: Christian Brauner 
  Date:   2021-02-14 (Sun, 14 Feb 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  start: fix comment about time namespace preservation

Signed-off-by: Christian Brauner 


  Commit: 4b9467975c2132afe52ab30101588b64830f8e6e
  https://github.com/lxc/lxc/commit/4b9467975c2132afe52ab30101588b64830f8e6e
  Author: Stéphane Graber 
  Date:   2021-02-14 (Sun, 14 Feb 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  Merge pull request #3672 from brauner/2021-02-14/fixes

start: small fixes


Compare: https://github.com/lxc/lxc/compare/5fd096830447...4b9467975c21
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] e8c433: attach: convert to strequal()

2021-02-13 Thread Stéphane Graber
: Christian Brauner 
  Date:   2021-02-13 (Sat, 13 Feb 2021)

  Changed paths:
M src/lxc/utils.c

  Log Message:
  ---
  utils: convert to strequal()

Signed-off-by: Christian Brauner 


  Commit: 3bcf3ba0b4e6c7b4aa4491b616f6a8b6d858cf66
  https://github.com/lxc/lxc/commit/3bcf3ba0b4e6c7b4aa4491b616f6a8b6d858cf66
  Author: Stéphane Graber 
  Date:   2021-02-13 (Sat, 13 Feb 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup_utils.c
M src/lxc/conf.c
M src/lxc/confile.c
M src/lxc/confile_utils.c
M src/lxc/criu.c
M src/lxc/file_utils.c
M src/lxc/freezer.c
M src/lxc/initutils.c
M src/lxc/log.c
M src/lxc/lsm/apparmor.c
M src/lxc/lsm/selinux.c
M src/lxc/lxccontainer.c
M src/lxc/namespace.c
M src/lxc/network.c
M src/lxc/seccomp.c
M src/lxc/start.c
M src/lxc/state.c
M src/lxc/string_utils.c
M src/lxc/terminal.c
M src/lxc/utils.c

  Log Message:
  ---
  Merge pull request #3670 from brauner/2021-02-13/fixes

tree-wide: convert to strequal() and strnequal()


Compare: https://github.com/lxc/lxc/compare/46ad3c97ab47...3bcf3ba0b4e6
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 1ff482: memory_utils: add close_move_fd()

2021-02-11 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 1ff48211584c8cc9ae75d53d0f0643763e1f1dd7
  https://github.com/lxc/lxc/commit/1ff48211584c8cc9ae75d53d0f0643763e1f1dd7
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/memory_utils.h

  Log Message:
  ---
  memory_utils: add close_move_fd()

Signed-off-by: Christian Brauner 


  Commit: 4b7686ea7b660d89bf4290f64ca4331a8ddf74e3
  https://github.com/lxc/lxc/commit/4b7686ea7b660d89bf4290f64ca4331a8ddf74e3
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/string_utils.h

  Log Message:
  ---
  string_utils: add proc_self_fd()

Signed-off-by: Christian Brauner 


  Commit: 74f4638877607afc7d9320f99c8b3fe23e59c382
  https://github.com/lxc/lxc/commit/74f4638877607afc7d9320f99c8b3fe23e59c382
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/string_utils.h

  Log Message:
  ---
  string_utils: add fdstr()

Signed-off-by: Christian Brauner 


  Commit: 8e40762dfdc8baf697934f16057689958c053efb
  https://github.com/lxc/lxc/commit/8e40762dfdc8baf697934f16057689958c053efb
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/file_utils.c
M src/lxc/file_utils.h

  Log Message:
  ---
  file_utils: add same_file_lax()

Signed-off-by: Christian Brauner 


  Commit: 4a233eab3d294df2af0608923941dc8cbae635b6
  https://github.com/lxc/lxc/commit/4a233eab3d294df2af0608923941dc8cbae635b6
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/macro.h

  Log Message:
  ---
  macro: add LXC_PROC_SELF_FD_LEN

Signed-off-by: Christian Brauner 


  Commit: 37c74fd1ef32d5dac0c68080b4b448c073f4b467
  https://github.com/lxc/lxc/commit/37c74fd1ef32d5dac0c68080b4b448c073f4b467
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: introduce lxc_bind_mount_console()

Signed-off-by: Christian Brauner 


  Commit: de7f9f3303a5ed1100e6e0683a4a9fa4eb8330cc
  https://github.com/lxc/lxc/commit/de7f9f3303a5ed1100e6e0683a4a9fa4eb8330cc
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/conf.c
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h

  Log Message:
  ---
  tree-wide: rework mount api support checks

Signed-off-by: Christian Brauner 


  Commit: 46ad3c97ab475db56759d22b6d59beb490bec0cb
  https://github.com/lxc/lxc/commit/46ad3c97ab475db56759d22b6d59beb490bec0cb
  Author: Stéphane Graber 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/conf.c
M src/lxc/file_utils.c
M src/lxc/file_utils.h
M src/lxc/macro.h
M src/lxc/memory_utils.h
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h
M src/lxc/string_utils.h

  Log Message:
  ---
  Merge pull request #3666 from brauner/2021-02-11/fixes

Improved mount api support checking & console setup hardening


Compare: https://github.com/lxc/lxc/compare/244a5017badd...46ad3c97ab47
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 66efb1: string_utils: add wrapper for snprintf()

2021-02-11 Thread Stéphane Graber
onvert to strnprintf()

Signed-off-by: Christian Brauner 


  Commit: 387c1c70a261360b7a508a95b02cdb35e01afdc5
  https://github.com/lxc/lxc/commit/387c1c70a261360b7a508a95b02cdb35e01afdc5
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/network.c

  Log Message:
  ---
  network: convert to strnprintf()

Signed-off-by: Christian Brauner 


  Commit: 608a39c23ddd5e06d7829dc23ea6b74ff6dd3ff0
  https://github.com/lxc/lxc/commit/608a39c23ddd5e06d7829dc23ea6b74ff6dd3ff0
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/rexec.c

  Log Message:
  ---
  rexec: convert to strnprintf()

Signed-off-by: Christian Brauner 


  Commit: 8a6bea9432fb4ad51a131382e4d30e50c6c98d93
  https://github.com/lxc/lxc/commit/8a6bea9432fb4ad51a131382e4d30e50c6c98d93
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/seccomp.c

  Log Message:
  ---
  seccomp: convert to strnprintf()

Signed-off-by: Christian Brauner 


  Commit: fa60cd7bf326b1de92e33796e0f3ad2d5b7ef343
  https://github.com/lxc/lxc/commit/fa60cd7bf326b1de92e33796e0f3ad2d5b7ef343
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  start: convert to strnprintf()

Signed-off-by: Christian Brauner 


  Commit: 93d5ebf1b9e4cfba124ac0be6e57b284718e854d
  https://github.com/lxc/lxc/commit/93d5ebf1b9e4cfba124ac0be6e57b284718e854d
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/terminal.c

  Log Message:
  ---
  terminal: convert to strnprintf()

Signed-off-by: Christian Brauner 


  Commit: 4af24cb74075524c5ef650e6ef4850c95ac99880
  https://github.com/lxc/lxc/commit/4af24cb74075524c5ef650e6ef4850c95ac99880
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/string_utils.c

  Log Message:
  ---
  string_utils: convert to strnprintf()

Signed-off-by: Christian Brauner 


  Commit: af00ba8b0a9ea00ffb4d45269d7ea7f3c1a68b06
  https://github.com/lxc/lxc/commit/af00ba8b0a9ea00ffb4d45269d7ea7f3c1a68b06
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/utils.c

  Log Message:
  ---
  utils: convert to strnprintf()

Signed-off-by: Christian Brauner 


  Commit: 244a5017baddfa8010db156240f84c66565440a0
  https://github.com/lxc/lxc/commit/244a5017baddfa8010db156240f84c66565440a0
  Author: Stéphane Graber 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/commands_utils.c
M src/lxc/conf.c
M src/lxc/confile.c
M src/lxc/confile_utils.c
M src/lxc/criu.c
M src/lxc/file_utils.c
M src/lxc/log.c
M src/lxc/lxccontainer.c
M src/lxc/lxclock.c
M src/lxc/monitor.c
M src/lxc/mount_utils.c
M src/lxc/network.c
M src/lxc/rexec.c
M src/lxc/seccomp.c
M src/lxc/start.c
M src/lxc/string_utils.c
M src/lxc/string_utils.h
M src/lxc/terminal.c
M src/lxc/utils.c

  Log Message:
  ---
  Merge pull request #3665 from brauner/2021-02-11/fixes

tree-wide: fixes


Compare: https://github.com/lxc/lxc/compare/ff4e4629061d...244a5017badd
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] b3a428: cgroups: use brackets to have clear semantics for ...

2021-02-10 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: b3a42865963a100b07cbdba0e77cacd0e0d88b3c
  https://github.com/lxc/lxc/commit/b3a42865963a100b07cbdba0e77cacd0e0d88b3c
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: use brackets to have clear semantics for flags checking

Signed-off-by: Christian Brauner 


  Commit: d1ee87192ef31ec073521eaafe50b4d356f27e94
  https://github.com/lxc/lxc/commit/d1ee87192ef31ec073521eaafe50b4d356f27e94
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: do not return early when entering monitor cgroups

This will happen when restoring a container via criu.

Signed-off-by: Christian Brauner 


  Commit: ebf88e5b8786f72d24e8104bd08f488ba967803e
  https://github.com/lxc/lxc/commit/ebf88e5b8786f72d24e8104bd08f488ba967803e
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: log monitor and transient process entering

Signed-off-by: Christian Brauner 


  Commit: 25db3f94405d8789bb9bbcd680d35e322f28329e
  https://github.com/lxc/lxc/commit/25db3f94405d8789bb9bbcd680d35e322f28329e
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: log container process entering

Signed-off-by: Christian Brauner 


  Commit: ff4e4629061db18d0935535ba6b82b1e434e2447
  https://github.com/lxc/lxc/commit/ff4e4629061db18d0935535ba6b82b1e434e2447
  Author: Stéphane Graber 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  Merge pull request #3664 from brauner/2021-02-10/fixes

cgroups: fixes


Compare: https://github.com/lxc/lxc/compare/ae2d267e59dd...ff4e4629061d
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 9d0e12: conf: fix memory leak

2021-02-10 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 9d0e129b54aa92d9bdfcdd462683459a0f115df9
  https://github.com/lxc/lxc/commit/9d0e129b54aa92d9bdfcdd462683459a0f115df9
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: fix memory leak

Fixes: Coverity 1472848
Signed-off-by: Christian Brauner 


  Commit: ff9edd2d04f6814b74b2f34b4bcbf2b31bedbead
  https://github.com/lxc/lxc/commit/ff9edd2d04f6814b74b2f34b4bcbf2b31bedbead
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/criu.c

  Log Message:
  ---
  criu: mark cgroups methods specific to criu

Signed-off-by: Christian Brauner 


  Commit: 59d8a539d106ba17e54f75a92c1278907c55bb56
  https://github.com/lxc/lxc/commit/59d8a539d106ba17e54f75a92c1278907c55bb56
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/criu.c
M src/lxc/macro.h
M src/lxc/memory_utils.h

  Log Message:
  ---
  criu: massage exec_criu()

Signed-off-by: Christian Brauner 


  Commit: 2541dfab3884ce8d1d5ec21c585ced09784cc207
  https://github.com/lxc/lxc/commit/2541dfab3884ce8d1d5ec21c585ced09784cc207
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/criu.c

  Log Message:
  ---
  criu: move logging under lxc_log_trace()

Signed-off-by: Christian Brauner 


  Commit: 6eff3c0d79228db7bbcfc82c38d1cad537edb571
  https://github.com/lxc/lxc/commit/6eff3c0d79228db7bbcfc82c38d1cad537edb571
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/criu.c

  Log Message:
  ---
  criu: use cleanup macro

Signed-off-by: Christian Brauner 


  Commit: 5257b91b6e6ba7ea8e865a602b1cd790d44a9c69
  https://github.com/lxc/lxc/commit/5257b91b6e6ba7ea8e865a602b1cd790d44a9c69
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/criu.c

  Log Message:
  ---
  criu: use cleanup macro when parsing mount data

Signed-off-by: Christian Brauner 


  Commit: 2539492cc93bbed11a6801f8762664d96f56b1bc
  https://github.com/lxc/lxc/commit/2539492cc93bbed11a6801f8762664d96f56b1bc
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/criu.c

  Log Message:
  ---
  criu: rework init pid retrieval

Signed-off-by: Christian Brauner 


  Commit: 92fde26d7b9c9fc15c793282310c3bec0938e3ce
  https://github.com/lxc/lxc/commit/92fde26d7b9c9fc15c793282310c3bec0938e3ce
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/criu.c

  Log Message:
  ---
  criu: warn about cgroup hierarchies without controllers

Signed-off-by: Christian Brauner 


  Commit: b41a8023b86d315b97193218e34ab47f62e7e3a9
  https://github.com/lxc/lxc/commit/b41a8023b86d315b97193218e34ab47f62e7e3a9
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/criu.c

  Log Message:
  ---
  criu: lxc_init() already initializes cgroups

Signed-off-by: Christian Brauner 


  Commit: d9fc9be8f011270b1ce22345d7d634ce9a533cd4
  https://github.com/lxc/lxc/commit/d9fc9be8f011270b1ce22345d7d634ce9a533cd4
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/criu.c

  Log Message:
  ---
  criu: handle new cgroup layout

Signed-off-by: Christian Brauner 


  Commit: ae2d267e59dd29a4cb093ec6b76c04333d083b4a
  https://github.com/lxc/lxc/commit/ae2d267e59dd29a4cb093ec6b76c04333d083b4a
  Author: Stéphane Graber 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/conf.c
M src/lxc/criu.c
M src/lxc/macro.h
M src/lxc/memory_utils.h

  Log Message:
  ---
  Merge pull request #3663 from brauner/2021-02-10/fixes

criu: fixes


Compare: https://github.com/lxc/lxc/compare/11a3696fda50...ae2d267e59dd
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 0ed79f: network: Add error message if iw couldn't be found

2021-02-09 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 0ed79f452a0e22ed4e20c34a4d5f16ef0a2ca50d
  https://github.com/lxc/lxc/commit/0ed79f452a0e22ed4e20c34a4d5f16ef0a2ca50d
  Author: Max 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/network.c

  Log Message:
  ---
  network: Add error message if iw couldn't be found

When iw is not installed on the host, lxc fails to move wireless devices
into a container. Unfortunately there is no real error message yet
(other than that it didn't work), so its quite unobvious what causes
this. This commit adds a error message that clearly states the
application iw is missing.

Signed-off-by: Maximilian Blenk 


  Commit: 11a3696fda5057589e6fb21fd8961ff228983c62
  https://github.com/lxc/lxc/commit/11a3696fda5057589e6fb21fd8961ff228983c62
  Author: Stéphane Graber 
  Date:   2021-02-09 (Tue, 09 Feb 2021)

  Changed paths:
M src/lxc/network.c

  Log Message:
  ---
  Merge pull request #3661 from blenk92/iw_error_msg

network: Add error message if iw couldn't be found


Compare: https://github.com/lxc/lxc/compare/642429e57b5d...11a3696fda50
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] ac11fe: mount_utils: add locked flag helpers

2021-02-09 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: ac11febd37494a6aea082bae504b53f053a76a45
  https://github.com/lxc/lxc/commit/ac11febd37494a6aea082bae504b53f053a76a45
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M configure.ac
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h
M src/lxc/storage/dir.c

  Log Message:
  ---
  mount_utils: add locked flag helpers

Signed-off-by: Christian Brauner 


  Commit: b28aae045ecb8d2298a92435f5e99bdc44b8d38b
  https://github.com/lxc/lxc/commit/b28aae045ecb8d2298a92435f5e99bdc44b8d38b
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: s/setup_mount()/setup_mount_fstab()/g

Signed-off-by: Christian Brauner 


  Commit: 8183f09e00912d458db8821936a07ddf906e3d55
  https://github.com/lxc/lxc/commit/8183f09e00912d458db8821936a07ddf906e3d55
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: kill PATH_MAX bytes

Signed-off-by: Christian Brauner 


  Commit: 48e5dcc85a827fcf32a185d6fb7decee72b20ea4
  https://github.com/lxc/lxc/commit/48e5dcc85a827fcf32a185d6fb7decee72b20ea4
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: don't pass struct lxc_conf

Signed-off-by: Christian Brauner 


  Commit: 9c0fd29a5ccafefe31760303015a16b7e99a93b0
  https://github.com/lxc/lxc/commit/9c0fd29a5ccafefe31760303015a16b7e99a93b0
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: kill PATH_MAX bytes

Signed-off-by: Christian Brauner 


  Commit: 4806d3b9ec5e1df7aa1ce0ced531c0cef9666776
  https://github.com/lxc/lxc/commit/4806d3b9ec5e1df7aa1ce0ced531c0cef9666776
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: kill PAT_MAX bytes

Signed-off-by: Christian Brauner 


  Commit: 79ff643d24593a1b77bb39233219d55d20efa4bc
  https://github.com/lxc/lxc/commit/79ff643d24593a1b77bb39233219d55d20efa4bc
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/start.c
M src/lxc/start.h

  Log Message:
  ---
  conf: rework rootfs pinning

Signed-off-by: Christian Brauner 


  Commit: ade356b90cd39a983872c0b9bf406b5251087768
  https://github.com/lxc/lxc/commit/ade356b90cd39a983872c0b9bf406b5251087768
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/mount_utils.c

  Log Message:
  ---
  mount_utils: s/OPEN_TREE_CLONE | OPEN_TREE_CLONE/OPEN_TREE_CLONE | 
OPEN_TREE_CLOEXEC/g

Signed-off-by: Christian Brauner 


  Commit: 7369e6bf6d5a610cd3d45e2407898722aac1d95e
  https://github.com/lxc/lxc/commit/7369e6bf6d5a610cd3d45e2407898722aac1d95e
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: fd-only tty setup

Signed-off-by: Christian Brauner 


  Commit: 17d9d07275d7b2da49f02385218f03a5708328f7
  https://github.com/lxc/lxc/commit/17d9d07275d7b2da49f02385218f03a5708328f7
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/tests/lxc-test-unpriv

  Log Message:
  ---
  tests: add logging to lxc-test-unpriv

Signed-off-by: Christian Brauner 


  Commit: 887ae844d5b91720c08557e4915908c0775a364f
  https://github.com/lxc/lxc/commit/887ae844d5b91720c08557e4915908c0775a364f
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: kill PATH_MAX bytes

Signed-off-by: Christian Brauner 


  Commit: 58b381117db181ba0b605d40e1d651cfa008e4d6
  https://github.com/lxc/lxc/commit/58b381117db181ba0b605d40e1d651cfa008e4d6
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: kill PATH_MAX bytes

Signed-off-by: Christian Brauner 


  Commit: 642429e57b5dc142832d8341bbd1b4f4398f4d25
  https://github.com/lxc/lxc/commit/642429e57b5dc142832d8341bbd1b4f4398f4d25
  Author: Stéphane Graber 
  Date:   2021-02-09 (Tue, 09 Feb 2021)

  Changed paths:
M configure.ac
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h
M src/lxc/start.c
M src/lxc/start.h
M src/lxc/storage/dir.c
M src/tests/lxc-test-unpriv

  Log Message:
  ---
  Merge pull request #3662 from brauner/2021-02-08/fixes

conf: expand fd-only setup codepaths


Compare: https://github.com/lxc

[lxc-devel] [lxc/lxc] 5cf511: mount_utils: initialize fd

2021-02-05 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 5cf51172e3031f1b739d36b24b426a2def708b9b
  https://github.com/lxc/lxc/commit/5cf51172e3031f1b739d36b24b426a2def708b9b
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/mount_utils.h

  Log Message:
  ---
  mount_utils: initialize fd

Signed-off-by: Christian Brauner 


  Commit: 0d50f2882c8427565c092ba3931eb1cad36ad96f
  https://github.com/lxc/lxc/commit/0d50f2882c8427565c092ba3931eb1cad36ad96f
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: switch to simple mount()

At the point where we're remounging proc and sys we're in the container's
namespaces so there's no chance of escape so a simple mount() syscall will
suffice.

Signed-off-by: Christian Brauner 


  Commit: 60218ee70ba6e38d83301900f3eacb02e840a4df
  https://github.com/lxc/lxc/commit/60218ee70ba6e38d83301900f3eacb02e840a4df
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h

  Log Message:
  ---
  mount_utils: kill mount_filesystem()

We have way better helpers now.

Signed-off-by: Christian Brauner 


  Commit: 01149adf724d5d3cfe79918e002c1ee5fac89080
  https://github.com/lxc/lxc/commit/01149adf724d5d3cfe79918e002c1ee5fac89080
  Author: Stéphane Graber 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h

  Log Message:
  ---
  Merge pull request #3660 from brauner/2021-02-05/fixes_1

mount_utils: initialize fd


Compare: https://github.com/lxc/lxc/compare/338c2abe8392...01149adf724d
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 74ed30: mount_utils: move mount_at() and mount_from_at() o...

2021-02-05 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 74ed30d721ccc569b4e09e67f97fa0a1b42fe2a8
  https://github.com/lxc/lxc/commit/74ed30d721ccc569b4e09e67f97fa0a1b42fe2a8
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/Makefile.am
M src/lxc/cgroups/cgfsng.c
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h
M src/lxc/utils.c
M src/lxc/utils.h
M src/tests/Makefile.am

  Log Message:
  ---
  mount_utils: move mount_at() and mount_from_at() over from utils.{c,h}

Signed-off-by: Christian Brauner 


  Commit: 1f3eb959656a5a461d3d51083bad5c03bf04f9f1
  https://github.com/lxc/lxc/commit/1f3eb959656a5a461d3d51083bad5c03bf04f9f1
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h

  Log Message:
  ---
  mount_utils: add extended helpers for new mount api

fs_prepare()
fs_set_property()
fs_attach()
fs_mount()

Signed-off-by: Christian Brauner 


  Commit: bfbfeedfab1b939993be166cadf52ac941bbed64
  https://github.com/lxc/lxc/commit/bfbfeedfab1b939993be166cadf52ac941bbed64
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: switch mount_autodev() to new mount api

Signed-off-by: Christian Brauner 


  Commit: 23a20dbea863fa4ac2c8b2a4972a5d94fb7247bc
  https://github.com/lxc/lxc/commit/23a20dbea863fa4ac2c8b2a4972a5d94fb7247bc
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: switch tmpfs mounting to new mount api

Signed-off-by: Christian Brauner 


  Commit: a099c5db1c1a3a3ce20b717a3d7269d3a55a18b3
  https://github.com/lxc/lxc/commit/a099c5db1c1a3a3ce20b717a3d7269d3a55a18b3
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: switch __cg_mount_direct() to use the new mount api

Signed-off-by: Christian Brauner 


  Commit: ca9055b47399a2040a5e1c2a8da591832380b168
  https://github.com/lxc/lxc/commit/ca9055b47399a2040a5e1c2a8da591832380b168
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h

  Log Message:
  ---
  mount_utils: kill mount_at()

Signed-off-by: Christian Brauner 


  Commit: 041d1e30545a5e21fc9631b09daa1ab817e6ff15
  https://github.com/lxc/lxc/commit/041d1e30545a5e21fc9631b09daa1ab817e6ff15
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h

  Log Message:
  ---
  mount_utils: add support for bind-mounts through the new mount api

fd_bind_mount()

Signed-off-by: Christian Brauner 


  Commit: d2c885f199a8ca6bd0f8f1acbbb2671cac04624f
  https://github.com/lxc/lxc/commit/d2c885f199a8ca6bd0f8f1acbbb2671cac04624f
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: use fd_bind_mount() in lxc_fill_autodev()

Signed-off-by: Christian Brauner 


  Commit: 55a85f4a1145a4a89354db65fbf4f3ba358cbde8
  https://github.com/lxc/lxc/commit/55a85f4a1145a4a89354db65fbf4f3ba358cbde8
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h

  Log Message:
  ---
  mount_utils: kill mount_from_at()

Signed-off-by: Christian Brauner 


  Commit: 87545854f7b641034cc79f61a03e05641b736048
  https://github.com/lxc/lxc/commit/87545854f7b641034cc79f61a03e05641b736048
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/mount_utils.h

  Log Message:
  ---
  mount_utils: detect new mount api support

Signed-off-by: Christian Brauner 


  Commit: 635e7bac019140ca33bf9f6768e4b82268ebee17
  https://github.com/lxc/lxc/commit/635e7bac019140ca33bf9f6768e4b82268ebee17
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/conf.c

  Log Message:
  ---
  tree-wide: make use of new_mount_api() where it makes sense

Signed-off-by: Christian Brauner 


  Commit: 338c2abe8392cdaf07cfa1cb8252cf19106220be
  https://github.com/lxc/lxc/commit/338c2abe8392cdaf07cfa1cb8252cf19106220be
  Author: Stéphane Graber 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/Makefile.am
M src/lxc/cgroups/cgfsng.c
M src/lxc/conf.c
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h
M src/lxc/utils.c
M src/lxc/utils.h
M src/tests/Makefile.am

  Log Message:
  ---
  Merge pull request #3659 from brauner/2021-02-05/fixes

mount: extend support

[lxc-devel] [lxc/lxc] bd6a23: attach: improve logging and terminology

2021-02-04 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: bd6a23550f88b32c2cb362a681ca6390d35ab300
  https://github.com/lxc/lxc/commit/bd6a23550f88b32c2cb362a681ca6390d35ab300
  Author: Christian Brauner 
  Date:   2021-02-04 (Thu, 04 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: improve logging and terminology

The term "intermediate process" is not very nice imho, "transient process" fits
better.

Signed-off-by: Christian Brauner 


  Commit: 7f40f0617e5a6e8bcf32d8b2ff87b016b817ddb4
  https://github.com/lxc/lxc/commit/7f40f0617e5a6e8bcf32d8b2ff87b016b817ddb4
  Author: Christian Brauner 
  Date:   2021-02-04 (Thu, 04 Feb 2021)

  Changed paths:
M src/lxc/utils.c

  Log Message:
  ---
  utils: check for snprintf() error

Signed-off-by: Christian Brauner 


  Commit: d71e4764b73a924204885030ac2f69ea8c34ed0b
  https://github.com/lxc/lxc/commit/d71e4764b73a924204885030ac2f69ea8c34ed0b
  Author: Stéphane Graber 
  Date:   2021-02-04 (Thu, 04 Feb 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/utils.c

  Log Message:
  ---
  Merge pull request #3655 from brauner/2021-02-04/fixes_1

Tiny fixes in attach and utils


Compare: https://github.com/lxc/lxc/compare/5ee510d614a1...d71e4764b73a
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 315f8a: cgroups: fix cgroup mounting

2021-02-04 Thread Stéphane Graber

Signed-off-by: Christian Brauner 


  Commit: ea57e42409bf56b60759c0fffc978ba116a711ce
  https://github.com/lxc/lxc/commit/ea57e42409bf56b60759c0fffc978ba116a711ce
  Author: Christian Brauner 
  Date:   2021-02-04 (Thu, 04 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/conf.c
M src/lxc/conf.h

  Log Message:
  ---
  tree-wide: s/mntpt_fd/dfd_mnt/g

Signed-off-by: Christian Brauner 


  Commit: ea11a215dca6208e1b6ce47db084b7fadb0a47a2
  https://github.com/lxc/lxc/commit/ea11a215dca6208e1b6ce47db084b7fadb0a47a2
  Author: Christian Brauner 
  Date:   2021-02-04 (Thu, 04 Feb 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h

  Log Message:
  ---
  tree-wide: s/dfd_root_host/dfd_host/g

Signed-off-by: Christian Brauner 


  Commit: 59114d805305928e4573d2e6936eb35e61f86ad2
  https://github.com/lxc/lxc/commit/59114d805305928e4573d2e6936eb35e61f86ad2
  Author: Christian Brauner 
  Date:   2021-02-04 (Thu, 04 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: check for correct error in __cg_unified_attach() from cgroup_attach()

Signed-off-by: Christian Brauner 


  Commit: 5ee510d614a1b186465aa0e0b15100dff8e7bba4
  https://github.com/lxc/lxc/commit/5ee510d614a1b186465aa0e0b15100dff8e7bba4
  Author: Stéphane Graber 
  Date:   2021-02-04 (Thu, 04 Feb 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/string_utils.h
M src/lxc/syscall_wrappers.h
M src/lxc/utils.c
M src/lxc/utils.h

  Log Message:
  ---
  Merge pull request #3651 from brauner/2021-02-04/fixes

cgroups: fix cgroup mounting


Compare: https://github.com/lxc/lxc/compare/dfb71524d77c...5ee510d614a1
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 8cfda4: cgroups: fix cgroup mounting

2021-02-04 Thread Stéphane Graber
  Branch: refs/heads/stable-4.0
  Home:   https://github.com/lxc/lxc
  Commit: 8cfda4171e76c7ce3e684baea7ec9dcb859a3942
  https://github.com/lxc/lxc/commit/8cfda4171e76c7ce3e684baea7ec9dcb859a3942
  Author: Christian Brauner 
  Date:   2021-02-04 (Thu, 04 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/conf.c
M src/lxc/syscall_wrappers.h
M src/lxc/utils.c
M src/lxc/utils.h

  Log Message:
  ---
  cgroups: fix cgroup mounting

Fixes: #3640
Signed-off-by: Christian Brauner 


  Commit: 80d4adf25a91401ae0cbaa2bf33306217461948b
  https://github.com/lxc/lxc/commit/80d4adf25a91401ae0cbaa2bf33306217461948b
  Author: Stéphane Graber 
  Date:   2021-02-04 (Thu, 04 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/conf.c
M src/lxc/syscall_wrappers.h
M src/lxc/utils.c
M src/lxc/utils.h

  Log Message:
  ---
  Merge pull request #3653 from brauner/2021-02-04/lxc-4.0.6-cgroup-mount-fix

cgroups: fix cgroup mounting


Compare: https://github.com/lxc/lxc/compare/252605bccc19...80d4adf25a91
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] fdb57a: conf: coding style

2021-02-03 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: fdb57ab442d22b15edd21e76aef0a06ca9be33b0
  https://github.com/lxc/lxc/commit/fdb57ab442d22b15edd21e76aef0a06ca9be33b0
  Author: Christian Brauner 
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: coding style

Signed-off-by: Christian Brauner 


  Commit: e1b9d6af00b924b9f386da9dce99159163a84b0a
  https://github.com/lxc/lxc/commit/e1b9d6af00b924b9f386da9dce99159163a84b0a
  Author: Christian Brauner 
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/utils.c
M src/lxc/utils.h

  Log Message:
  ---
  conf: make lxc_create_tmp_proc_mount() static

Signed-off-by: Christian Brauner 


  Commit: ccf5374124900f02efaf1ee41471695d3f32f591
  https://github.com/lxc/lxc/commit/ccf5374124900f02efaf1ee41471695d3f32f591
  Author: Christian Brauner 
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: restrict open call in lxc_mount_rootfs()

Signed-off-by: Christian Brauner 


  Commit: 952b5031b78b5de0716a6c4de6f35b81eb334d98
  https://github.com/lxc/lxc/commit/952b5031b78b5de0716a6c4de6f35b81eb334d98
  Author: Christian Brauner 
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h

  Log Message:
  ---
  conf: refactor transient procfs mounting

Signed-off-by: Christian Brauner 


  Commit: cbc2ddf5b347d4e230de8bedcfcf5e847ef39833
  https://github.com/lxc/lxc/commit/cbc2ddf5b347d4e230de8bedcfcf5e847ef39833
  Author: Christian Brauner 
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
M src/lxc/utils.c

  Log Message:
  ---
  utils: harden __safe_mount_beneath_at()

Signed-off-by: Christian Brauner 


  Commit: dfb71524d77c13198f62a6747e1982e348d5cf5b
  https://github.com/lxc/lxc/commit/dfb71524d77c13198f62a6747e1982e348d5cf5b
  Author: Stéphane Graber 
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/utils.c
M src/lxc/utils.h

  Log Message:
  ---
  Merge pull request #3650 from brauner/2021-02-03/fixes_1

conf: harden various mount paths


Compare: https://github.com/lxc/lxc/compare/f8dcf07fd3ca...dfb71524d77c
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 3c981f: tests: check for NULL in device_add_remove

2021-02-03 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 3c981fcb784a8130570948bf8c78e69a1b1afdd4
  https://github.com/lxc/lxc/commit/3c981fcb784a8130570948bf8c78e69a1b1afdd4
  Author: Christian Brauner 
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
M src/tests/device_add_remove.c

  Log Message:
  ---
  tests: check for NULL in device_add_remove

Fixes: Coverity 1472768
Signed-off-by: Christian Brauner 


  Commit: 6b69d7f8cf73911213cc145efe6a79aff9977f58
  https://github.com/lxc/lxc/commit/6b69d7f8cf73911213cc145efe6a79aff9977f58
  Author: Christian Brauner 
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
M src/lxc/rexec.c

  Log Message:
  ---
  rexec: check lseek() return value

Not really needed buy ok.

Fixes: Coverity: 1472769
Signed-off-by: Christian Brauner 


  Commit: e8aaef81592f4399b2cd6431476abe264d967394
  https://github.com/lxc/lxc/commit/e8aaef81592f4399b2cd6431476abe264d967394
  Author: Christian Brauner 
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
M configure.ac
M src/lxc/syscall_numbers.h
M src/lxc/syscall_wrappers.h

  Log Message:
  ---
  syscalls: add close_range()

Signed-off-by: Christian Brauner 


  Commit: 531d36ad009325b74a105d9d6956e320f37b2937
  https://github.com/lxc/lxc/commit/531d36ad009325b74a105d9d6956e320f37b2937
  Author: Christian Brauner 
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
M src/lxc/macro.h
M src/lxc/rexec.c

  Log Message:
  ---
  rexec: mark all fds as close-on-exec if possible

Signed-off-by: Christian Brauner 


  Commit: fdf7314dc4104f7422c7a5f3db3f571e04e6bf8c
  https://github.com/lxc/lxc/commit/fdf7314dc4104f7422c7a5f3db3f571e04e6bf8c
  Author: Christian Brauner 
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: remove unnecessary syscall

Signed-off-by: Christian Brauner 


  Commit: ce011f53d8d80986a875dda5109394b2d1678e35
  https://github.com/lxc/lxc/commit/ce011f53d8d80986a875dda5109394b2d1678e35
  Author: Christian Brauner 
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: restrict open of dev/

Signed-off-by: Christian Brauner 


  Commit: 814983287ea58b20429341f3dbfc5bc9777bd930
  https://github.com/lxc/lxc/commit/814983287ea58b20429341f3dbfc5bc9777bd930
  Author: Christian Brauner 
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/syscall_wrappers.h

  Log Message:
  ---
  conf: harden open in lxc_fill_autodev()

Signed-off-by: Christian Brauner 


  Commit: 79019997c82c4a2337b0120b4bc8a0da950deb0e
  https://github.com/lxc/lxc/commit/79019997c82c4a2337b0120b4bc8a0da950deb0e
  Author: Christian Brauner 
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: fd-only operations in lxc_setup_dev_symlinks()

Signed-off-by: Christian Brauner 


  Commit: 99ca563299f82cf0fb9e8e592fd8a96cf785bc4a
  https://github.com/lxc/lxc/commit/99ca563299f82cf0fb9e8e592fd8a96cf785bc4a
  Author: Christian Brauner 
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/syscall_wrappers.h

  Log Message:
  ---
  conf: restrict open for lxc_mount_rootfs()

Signed-off-by: Christian Brauner 


  Commit: 7f50ec8bd0d4d686ed3a346358d402ef4d5f7cfb
  https://github.com/lxc/lxc/commit/7f50ec8bd0d4d686ed3a346358d402ef4d5f7cfb
  Author: Christian Brauner 
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: fd-only pivot root

Signed-off-by: Christian Brauner 


  Commit: a26822c5d28d20c8b0c8d26c2312628b40ce6c0d
  https://github.com/lxc/lxc/commit/a26822c5d28d20c8b0c8d26c2312628b40ce6c0d
  Author: Christian Brauner 
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: fd-only devtps setup

Signed-off-by: Christian Brauner 


  Commit: f8dcf07fd3caafbfa98ec95d14c84aeb90c41ef8
  https://github.com/lxc/lxc/commit/f8dcf07fd3caafbfa98ec95d14c84aeb90c41ef8
  Author: Stéphane Graber 
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
M configure.ac
M src/lxc/conf.c
M src/lxc/macro.h
M src/lxc/rexec.c
M src/lxc/syscall_numbers.h
M src/lxc/syscall_wrappers.h
M src/tests/device_add_remove.c

  Log Message:
  ---
  Merge pull request #3648 from brauner/2021-02-03/fixes

conf: open hardening & fd-only operations


Compare: https://github.com/lxc/lxc/compare/b5e75029967a...f8dcf07fd3ca
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 9b31ab: attach: attach to namespaces via pidfds

2021-02-03 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 9b31ab5859247b70ba707e8c98a95a0870ea8809
  https://github.com/lxc/lxc/commit/9b31ab5859247b70ba707e8c98a95a0870ea8809
  Author: Christian Brauner 
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: attach to namespaces via pidfds

This is a feature we've enabled in kernel v5.8 and v5.9.

Signed-off-by: Christian Brauner 


  Commit: b5e75029967ac1ed25bfa93ecd5100a2152c4789
  https://github.com/lxc/lxc/commit/b5e75029967ac1ed25bfa93ecd5100a2152c4789
  Author: Stéphane Graber 
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  Merge pull request #3649 from brauner/2021-02-03/attach_via_pidfds

attach: attach to namespaces via pidfds


Compare: https://github.com/lxc/lxc/compare/07f89a4faf1c...b5e75029967a
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 6de35c: macro: abuse ENOMEDIUM as ENOCGROUP2

2021-02-02 Thread Stéphane Graber
/lxcseccomp.h
M src/lxc/seccomp.c

  Log Message:
  ---
  attach: explicitly close seccomp notifier fd

Signed-off-by: Christian Brauner 


  Commit: 44322ead3981b47d7c8e4c578f0e8fd5790b0414
  https://github.com/lxc/lxc/commit/44322ead3981b47d7c8e4c578f0e8fd5790b0414
  Author: Christian Brauner 
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
M src/tests/cgpath.c

  Log Message:
  ---
  cgpath: add logging

Signed-off-by: Christian Brauner 


  Commit: 6f7f2966b10602227a325ff2e8f01a111afc19aa
  https://github.com/lxc/lxc/commit/6f7f2966b10602227a325ff2e8f01a111afc19aa
  Author: Christian Brauner 
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: add missing lxc_cmd_get_limiting_cgroup2_fd() implementation

Signed-off-by: Christian Brauner 


  Commit: ae4fcc7b11bf1f616752bc2c0a02e84a54a8ea93
  https://github.com/lxc/lxc/commit/ae4fcc7b11bf1f616752bc2c0a02e84a54a8ea93
  Author: Christian Brauner 
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: use lxc_cmd_get_limiting_cgroup2_fd()

Signed-off-by: Christian Brauner 


  Commit: c9c814f4d445812d2338b084d4ee149b49114878
  https://github.com/lxc/lxc/commit/c9c814f4d445812d2338b084d4ee149b49114878
  Author: Christian Brauner 
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h

  Log Message:
  ---
  cgroups: export __cgroup_unfreeze() for use in commands

Signed-off-by: Christian Brauner 


  Commit: 9d47970b9be9b1ebd425fde8c8bb949b1ba8965c
  https://github.com/lxc/lxc/commit/9d47970b9be9b1ebd425fde8c8bb949b1ba8965c
  Author: Christian Brauner 
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: use __cgroup_unfreeze() directly

Signed-off-by: Christian Brauner 


  Commit: ea299bfc9860b4e2f12c5d47da562412e1b840de
  https://github.com/lxc/lxc/commit/ea299bfc9860b4e2f12c5d47da562412e1b840de
  Author: Christian Brauner 
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
M src/lxc/freezer.c

  Log Message:
  ---
  freezer: remove lxc_cmd_freeze() and lxc_cmd_unfreeze() calls

We're now handling them better.

Signed-off-by: Christian Brauner 


  Commit: a4f24357189fd74965d516c8373f1ca75a405668
  https://github.com/lxc/lxc/commit/a4f24357189fd74965d516c8373f1ca75a405668
  Author: Christian Brauner 
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
M src/tests/Makefile.am
M src/tests/device_add_remove.c

  Log Message:
  ---
  test: add logging to device_add_remove

Signed-off-by: Christian Brauner 


  Commit: 7d013cccf9784d69ea3a40b75f2c95979e517e3a
  https://github.com/lxc/lxc/commit/7d013cccf9784d69ea3a40b75f2c95979e517e3a
  Author: Christian Brauner 
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
M src/tests/cgpath.c

  Log Message:
  ---
  tests: support pure unified cgroup layouts in cgpath test

Signed-off-by: Christian Brauner 


  Commit: b7aeda9691f782e1d13b6ab57bd6c27d5dc4cc87
  https://github.com/lxc/lxc/commit/b7aeda9691f782e1d13b6ab57bd6c27d5dc4cc87
  Author: Christian Brauner 
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/lxccontainer.c

  Log Message:
  ---
  cgroups: improve parameter vetting

Signed-off-by: Christian Brauner 


  Commit: 07f89a4faf1ce60727015e8e68ac26f4647f768b
  https://github.com/lxc/lxc/commit/07f89a4faf1ce60727015e8e68ac26f4647f768b
  Author: Stéphane Graber 
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/commands.c
M src/lxc/commands_utils.c
M src/lxc/commands_utils.h
M src/lxc/file_utils.c
M src/lxc/file_utils.h
M src/lxc/freezer.c
M src/lxc/lxccontainer.c
M src/lxc/lxcseccomp.h
M src/lxc/macro.h
M src/lxc/seccomp.c
M src/tests/Makefile.am
M src/tests/cgpath.c
M src/tests/device_add_remove.c

  Log Message:
  ---
  Merge pull request #3647 from brauner/2021-02-02/fixes

cgroup2: only rely on command socket when getting cgroup values


Compare: https://github.com/lxc/lxc/compare/b22ae8438939...07f89a4faf1c
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 72a19d: attach: stricter lookup semantics for fdopen_at() ...

2021-02-02 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 72a19d2f382d11d3f10c6f439d35b8a8f0b16122
  https://github.com/lxc/lxc/commit/72a19d2f382d11d3f10c6f439d35b8a8f0b16122
  Author: Christian Brauner 
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: stricter lookup semantics for fdopen_at() calls

Signed-off-by: Christian Brauner 


  Commit: 92466fe34b54940da4cb03ee616aa4cb22cebd90
  https://github.com/lxc/lxc/commit/92466fe34b54940da4cb03ee616aa4cb22cebd90
  Author: Christian Brauner 
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: move file descriptor closing into attach_context_container()

This reduces the possibility of forgetting to close the namespace file
descriptors when we change this codepath.

Signed-off-by: Christian Brauner 


  Commit: e18aba7d2a706f477458098e2f014f0c0cb97f26
  https://github.com/lxc/lxc/commit/e18aba7d2a706f477458098e2f014f0c0cb97f26
  Author: Christian Brauner 
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: move loading seccomp as late as possible

We want to minimize the change that the profile blocks syscalls we need during
attach setup and has the notifier enabled.

Signed-off-by: Christian Brauner 


  Commit: 4c6c4794dc0c7f51980071216c906fa586e82ebb
  https://github.com/lxc/lxc/commit/4c6c4794dc0c7f51980071216c906fa586e82ebb
  Author: Christian Brauner 
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
M src/lxc/memory_utils.h

  Log Message:
  ---
  memory_utils: add close_prot_errno_mov()

Signed-off-by: Christian Brauner 


  Commit: bcf9793d4351cd54f2de272fe52979e9fed2c1d4
  https://github.com/lxc/lxc/commit/bcf9793d4351cd54f2de272fe52979e9fed2c1d4
  Author: Christian Brauner 
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
M src/lxc/syscall_wrappers.h

  Log Message:
  ---
  syscall_wrappers: add PROTECT_OPEN_W_* variants

Signed-off-by: Christian Brauner 


  Commit: 87c7dbcb9c6ec987ee4f39f3ebf3132c192ee9de
  https://github.com/lxc/lxc/commit/87c7dbcb9c6ec987ee4f39f3ebf3132c192ee9de
  Author: Christian Brauner 
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
M src/lxc/file_utils.c

  Log Message:
  ---
  file_utils: harden lxc_open_dirfd()

Signed-off-by: Christian Brauner 


  Commit: 3c5fa7f3e83f5831f6443c49e57eda5c1025a55e
  https://github.com/lxc/lxc/commit/3c5fa7f3e83f5831f6443c49e57eda5c1025a55e
  Author: Christian Brauner 
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
M src/lxc/file_utils.c

  Log Message:
  ---
  file_utils: harden lxc_writeat()

Signed-off-by: Christian Brauner 


  Commit: 6d15354365ef2312de5a08682b3e7e6e6b73e24f
  https://github.com/lxc/lxc/commit/6d15354365ef2312de5a08682b3e7e6e6b73e24f
  Author: Christian Brauner 
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgroup_utils.c
M src/lxc/cgroups/cgroup_utils.h

  Log Message:
  ---
  cgroups: add unified_cgroup_fd() helper

Signed-off-by: Christian Brauner 


  Commit: ac01a9b83ca0ec3ee0cf4b7b983f7081eb67528c
  https://github.com/lxc/lxc/commit/ac01a9b83ca0ec3ee0cf4b7b983f7081eb67528c
  Author: Christian Brauner 
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: switch controller delegation to fd-only operations

Signed-off-by: Christian Brauner 


  Commit: b22ae84389391363ef5bc93bdc2be2aa26ece70b
  https://github.com/lxc/lxc/commit/b22ae84389391363ef5bc93bdc2be2aa26ece70b
  Author: Stéphane Graber 
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup_utils.c
M src/lxc/cgroups/cgroup_utils.h
M src/lxc/file_utils.c
M src/lxc/memory_utils.h
M src/lxc/syscall_wrappers.h

  Log Message:
  ---
  Merge pull request #3646 from brauner/2021-02-02/fixes

attach & cgroup hardening


Compare: https://github.com/lxc/lxc/compare/c7d644983ff4...b22ae8438939
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] cd5f35: attach: prevent UAF

2021-02-01 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: cd5f35ec672934165c20298b2c33f493033267f2
  https://github.com/lxc/lxc/commit/cd5f35ec672934165c20298b2c33f493033267f2
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: prevent UAF

Fixes: Coverity 1472761
Signed-off-by: Christian Brauner 


  Commit: 52ed870ed05a5d046d3754db94898b86ddfa2eb9
  https://github.com/lxc/lxc/commit/52ed870ed05a5d046d3754db94898b86ddfa2eb9
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: use correct put method

Fixes: Coverity 1472763
Signed-off-by: Christian Brauner 


  Commit: 570e1173387dba2a173ace8fbab350655599349e
  https://github.com/lxc/lxc/commit/570e1173387dba2a173ace8fbab350655599349e
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/commands_utils.c

  Log Message:
  ---
  commands_utils: don't leak memory

Signed-off-by: Christian Brauner 


  Commit: 62fef886dcdb18c0b2427ce45c906fd3cb2002fe
  https://github.com/lxc/lxc/commit/62fef886dcdb18c0b2427ce45c906fd3cb2002fe
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: use lxc_log_trace()

Signed-off-by: Christian Brauner 


  Commit: 4ac35afb78de15e87e0c91c12675ac34b57f9225
  https://github.com/lxc/lxc/commit/4ac35afb78de15e87e0c91c12675ac34b57f9225
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  confile_utils: use lxc_log_trace()

Signed-off-by: Christian Brauner 


  Commit: c7d644983ff4817c93ff3f0ff96be6015dda3e6a
  https://github.com/lxc/lxc/commit/c7d644983ff4817c93ff3f0ff96be6015dda3e6a
  Author: Stéphane Graber 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/commands_utils.c
M src/lxc/conf.c
M src/lxc/confile_utils.c

  Log Message:
  ---
  Merge pull request #3645 from brauner/2021-02-01/fixes_4

attach: bugfixes


Compare: https://github.com/lxc/lxc/compare/32947602fd7b...c7d644983ff4
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 7166ab: file_utils: add open_at()

2021-02-01 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 7166ab759e3137cf338bb127f2e7400d7d0ce362
  https://github.com/lxc/lxc/commit/7166ab759e3137cf338bb127f2e7400d7d0ce362
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/file_utils.c
M src/lxc/file_utils.h

  Log Message:
  ---
  file_utils: add open_at()

Signed-off-by: Christian Brauner 


  Commit: cce677d168761da7a1e979bd396a63638c859c50
  https://github.com/lxc/lxc/commit/cce677d168761da7a1e979bd396a63638c859c50
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/file_utils.c
M src/lxc/file_utils.h
M src/lxc/syscall_wrappers.h

  Log Message:
  ---
  syscall_wrappers: add PROTECT_LOOKUP, PROTECT_OPEN, 
PROTECT_LOOKUP_WITH_SYMLINKS, PROTECT_OPEN_WITH_TRAILING_SYMLINKS

Signed-off-by: Christian Brauner 


  Commit: 5129b2d3edcaef2feebdb80ae478f3268cfba454
  https://github.com/lxc/lxc/commit/5129b2d3edcaef2feebdb80ae478f3268cfba454
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/file_utils.c
M src/lxc/file_utils.h

  Log Message:
  ---
  attach: harden open calls

Signed-off-by: Christian Brauner 


  Commit: 46bf13b7c35fb26186ec31dba971e1ddaeec66c4
  https://github.com/lxc/lxc/commit/46bf13b7c35fb26186ec31dba971e1ddaeec66c4
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/file_utils.c
M src/lxc/file_utils.h
M src/lxc/lsm/apparmor.c
M src/lxc/lsm/selinux.c

  Log Message:
  ---
  tree-wide: extend read_file_at()

Signed-off-by: Christian Brauner 


  Commit: 6fc8a0dd822843fc96738f2b3c1c59e1c77fcd50
  https://github.com/lxc/lxc/commit/6fc8a0dd822843fc96738f2b3c1c59e1c77fcd50
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/lsm/apparmor.c
M src/lxc/lsm/selinux.c

  Log Message:
  ---
  lsm: harden read_file_at()

Signed-off-by: Christian Brauner 


  Commit: 8e5d175935cf9ac16dfa7949a8b4f1f7e6535908
  https://github.com/lxc/lxc/commit/8e5d175935cf9ac16dfa7949a8b4f1f7e6535908
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/file_utils.c

  Log Message:
  ---
  file_utils: remove O_NOFOLLOW from open_at() defaults

Signed-off-by: Christian Brauner 


  Commit: 6f0c2cea14d0a573a0a7cefd5661fe7d30887caa
  https://github.com/lxc/lxc/commit/6f0c2cea14d0a573a0a7cefd5661fe7d30887caa
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: file descriptor based fdinfo handling

Signed-off-by: Christian Brauner 


  Commit: 32947602fd7b370fdc5fa916cc8e90fe4ecbcefd
  https://github.com/lxc/lxc/commit/32947602fd7b370fdc5fa916cc8e90fe4ecbcefd
  Author: Stéphane Graber 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/file_utils.c
M src/lxc/file_utils.h
M src/lxc/lsm/apparmor.c
M src/lxc/lsm/selinux.c
M src/lxc/syscall_wrappers.h

  Log Message:
  ---
  Merge pull request #3644 from brauner/2021-02-01/fixes_3

attach: harden open() calls


Compare: https://github.com/lxc/lxc/compare/42673edd0503...32947602fd7b
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] a60d8c: file_utils: add fdopenat()

2021-02-01 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: a60d8c4ea7e77897e79fe91421490a55bb850ea1
  https://github.com/lxc/lxc/commit/a60d8c4ea7e77897e79fe91421490a55bb850ea1
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/file_utils.c
M src/lxc/file_utils.h
M src/lxc/utils.c
M src/lxc/utils.h

  Log Message:
  ---
  file_utils: add fdopenat()

Signed-off-by: Christian Brauner 


  Commit: 9680e7b062ff3e947bd3e0460d76758d44f15bb4
  https://github.com/lxc/lxc/commit/9680e7b062ff3e947bd3e0460d76758d44f15bb4
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: unifiy /proc//status parsing

and move it out of do_attach(). The less we do in the container's context the
better.

Signed-off-by: Christian Brauner 


  Commit: bac33ebdcbe881147ba1a2b5cd32bd98d94f9ddb
  https://github.com/lxc/lxc/commit/bac33ebdcbe881147ba1a2b5cd32bd98d94f9ddb
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: initialize init_pid field to -ESRCH

Signed-off-by: Christian Brauner 


  Commit: 4475fabb0edf30b1a4d269373d63d6401a67bbd1
  https://github.com/lxc/lxc/commit/4475fabb0edf30b1a4d269373d63d6401a67bbd1
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: move uid and gid handling to get_attach_context()

the less we do in do_attach(), the better.

Signed-off-by: Christian Brauner 


  Commit: 595798bbcae788d38390ccd457269c6632344928
  https://github.com/lxc/lxc/commit/595798bbcae788d38390ccd457269c6632344928
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: simplify opening of /proc/self

Signed-off-by: Christian Brauner 


  Commit: 20718e3987967f800f8171b812fb153a68e1aec2
  https://github.com/lxc/lxc/commit/20718e3987967f800f8171b812fb153a68e1aec2
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: document attach_context

Signed-off-by: Christian Brauner 


  Commit: 7e90889dbd2869a08ef4e7eb1c7dd3663a7d0412
  https://github.com/lxc/lxc/commit/7e90889dbd2869a08ef4e7eb1c7dd3663a7d0412
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/utils.c

  Log Message:
  ---
  utils: use SYSTRACE() when logging stdio permission fixup failures

Signed-off-by: Christian Brauner 


  Commit: a7563434ac69693305f217e41c2ed819634c3777
  https://github.com/lxc/lxc/commit/a7563434ac69693305f217e41c2ed819634c3777
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: log failues to dup2() with SYSDEBUG()

Signed-off-by: Christian Brauner 


  Commit: 93b9960a09c63b67df64aa6baeeba61d09fecb71
  https://github.com/lxc/lxc/commit/93b9960a09c63b67df64aa6baeeba61d09fecb71
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: fix logging for stdfd replacement

Signed-off-by: Christian Brauner 


  Commit: 40301d4895f0ca4f43d0aa1060e7d3c40e1ec562
  https://github.com/lxc/lxc/commit/40301d4895f0ca4f43d0aa1060e7d3c40e1ec562
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: fix error checking for dup2()

Signed-off-by: Christian Brauner 


  Commit: 3ac4480a6cd2f9a44c4c8e60b9924b42e47d4ab5
  https://github.com/lxc/lxc/commit/3ac4480a6cd2f9a44c4c8e60b9924b42e47d4ab5
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: stash host uid and host gid in attach_context

Signed-off-by: Christian Brauner 


  Commit: 42673edd05035c7d90cf1fcfd6d16c22bdfa29c2
  https://github.com/lxc/lxc/commit/42673edd05035c7d90cf1fcfd6d16c22bdfa29c2
  Author: Stéphane Graber 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/file_utils.c
M src/lxc/file_utils.h
M src/lxc/utils.c
M src/lxc/utils.h

  Log Message:
  ---
  Merge pull request #3642 from brauner/2021-02-01/fixes

attach: rework id handling


Compare: https://github.com/lxc/lxc/compare/2b5259634ae5...42673edd0503
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] bb6dba: cgroups: remove pointless NULL checks

2021-02-01 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: bb6dbaf0dfbba308cd3e999f6a15a96dcb1bc7c4
  https://github.com/lxc/lxc/commit/bb6dbaf0dfbba308cd3e999f6a15a96dcb1bc7c4
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: remove pointless NULL checks

We're already ensuring before that conf isn't NULL.

Signed-off-by: Christian Brauner 


  Commit: ed75d76e70233986364da5a4186088ecff335c0d
  https://github.com/lxc/lxc/commit/ed75d76e70233986364da5a4186088ecff335c0d
  Author: Christian Brauner 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: initialize variable

Fixes: Coverity 1472651
Signed-off-by: Christian Brauner 


  Commit: 2b5259634ae5642ca3bd119468629c18390b5815
  https://github.com/lxc/lxc/commit/2b5259634ae5642ca3bd119468629c18390b5815
  Author: Stéphane Graber 
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  Merge pull request #3643 from brauner/2021-02-01/fixes_2

cgroups: remove pointless NULL checks


Compare: https://github.com/lxc/lxc/compare/326bb02cbb93...2b5259634ae5
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] ca76ba: cgroups: align methods

2021-01-31 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: ca76baed1062636ff57fb61e2512b5974d39c6b8
  https://github.com/lxc/lxc/commit/ca76baed1062636ff57fb61e2512b5974d39c6b8
  Author: Christian Brauner 
  Date:   2021-01-31 (Sun, 31 Jan 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: align methods

Signed-off-by: Christian Brauner 


  Commit: afc691a01a793161faaf1484fc1089bc4ae37f6d
  https://github.com/lxc/lxc/commit/afc691a01a793161faaf1484fc1089bc4ae37f6d
  Author: Christian Brauner 
  Date:   2021-01-31 (Sun, 31 Jan 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/attach_options.h
M src/lxc/lsm/apparmor.c
M src/lxc/lsm/lsm.h
M src/lxc/lsm/nop.c
M src/lxc/lsm/selinux.c

  Log Message:
  ---
  attach: file descriptors based LSM handling

Signed-off-by: Christian Brauner 


  Commit: d87640256f2e0bc0bfb7f18b8724f588b4b9da7f
  https://github.com/lxc/lxc/commit/d87640256f2e0bc0bfb7f18b8724f588b4b9da7f
  Author: Christian Brauner 
  Date:   2021-01-31 (Sun, 31 Jan 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: hardening through use of pidfds

Signed-off-by: Christian Brauner 


  Commit: fbf281d3f449ff56401d3c691ff3f18ae534b7ee
  https://github.com/lxc/lxc/commit/fbf281d3f449ff56401d3c691ff3f18ae534b7ee
  Author: Christian Brauner 
  Date:   2021-01-31 (Sun, 31 Jan 2021)

  Changed paths:
M src/lxc/lsm/apparmor.c

  Log Message:
  ---
  lsm/apparmor: cleanup apparmor_process_label_set()

Signed-off-by: Christian Brauner 


  Commit: 326bb02cbb934f2000801e6d0267fe718ad985d9
  https://github.com/lxc/lxc/commit/326bb02cbb934f2000801e6d0267fe718ad985d9
  Author: Stéphane Graber 
  Date:   2021-01-31 (Sun, 31 Jan 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/attach_options.h
M src/lxc/cgroups/cgfsng.c
M src/lxc/lsm/apparmor.c
M src/lxc/lsm/lsm.h
M src/lxc/lsm/nop.c
M src/lxc/lsm/selinux.c

  Log Message:
  ---
  Merge pull request #3641 from brauner/2021-01-30/fixes

attach: pidfd-based hardening and file-descriptor-only LSM interactions


Compare: https://github.com/lxc/lxc/compare/ee4aad1e1f04...326bb02cbb93
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] dcbb9e: cgroups: bpf fixes

2021-01-30 Thread Stéphane Graber
: use lxc_log_get_level()

This will now enable LXD users to dump the seccomp filter in the log when
logging at TRACE level.

Signed-off-by: Christian Brauner 


  Commit: 4a888de15de5ec2337ef4faec5f2ea8fccb7461b
  https://github.com/lxc/lxc/commit/4a888de15de5ec2337ef4faec5f2ea8fccb7461b
  Author: Christian Brauner 
  Date:   2021-01-30 (Sat, 30 Jan 2021)

  Changed paths:
M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  ---
  cgroups: use bpf log when logging at trace level

Signed-off-by: Christian Brauner 


  Commit: de96cd600c968c5ed830a61a3979d2e2d7229104
  https://github.com/lxc/lxc/commit/de96cd600c968c5ed830a61a3979d2e2d7229104
  Author: Christian Brauner 
  Date:   2021-01-30 (Sat, 30 Jan 2021)

  Changed paths:
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/log.h
M src/lxc/seccomp.c

  Log Message:
  ---
  log: add lxc_log_trace() helper

Signed-off-by: Christian Brauner 


  Commit: 640952e53838c7a05535c9e015a67e533a355795
  https://github.com/lxc/lxc/commit/640952e53838c7a05535c9e015a67e533a355795
  Author: Christian Brauner 
  Date:   2021-01-30 (Sat, 30 Jan 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: don't needless check for NULL

Signed-off-by: Christian Brauner 


  Commit: 7d2f7ae18514ed1b3abb70bb559716ebafaebdc9
  https://github.com/lxc/lxc/commit/7d2f7ae18514ed1b3abb70bb559716ebafaebdc9
  Author: Christian Brauner 
  Date:   2021-01-30 (Sat, 30 Jan 2021)

  Changed paths:
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/macro.h

  Log Message:
  ---
  cgroups: use PTR_TO_U64()

Signed-off-by: Christian Brauner 


  Commit: ee4aad1e1f043d8d519eabcd13964ccc42a4b029
  https://github.com/lxc/lxc/commit/ee4aad1e1f043d8d519eabcd13964ccc42a4b029
  Author: Stéphane Graber 
  Date:   2021-01-30 (Sat, 30 Jan 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
M src/lxc/log.c
M src/lxc/log.h
M src/lxc/macro.h
M src/lxc/seccomp.c

  Log Message:
  ---
  Merge pull request #3639 from brauner/2021-01-28/fixes

cgroups: fixes and improvements


Compare: https://github.com/lxc/lxc/compare/0e24c5600da3...ee4aad1e1f04
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 5b514c: attach: coding style fixes

2021-01-30 Thread Stéphane Graber
/lxc/sync.h

  Log Message:
  ---
  sync: make all sync helpers return bool

Signed-off-by: Christian Brauner 


  Commit: 6e36c29770ee460590279ab0bf66a3416ed0f6b7
  https://github.com/lxc/lxc/commit/6e36c29770ee460590279ab0bf66a3416ed0f6b7
  Author: Christian Brauner 
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: introduce sync_wait_fd() and sync_wake_fd()

Signed-off-by: Christian Brauner 


  Commit: f8e88e94201861ed4c08adb4f59873898ebf4a95
  https://github.com/lxc/lxc/commit/f8e88e94201861ed4c08adb4f59873898ebf4a95
  Author: Christian Brauner 
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/sync.h

  Log Message:
  ---
  attach: use dummy macros to make it easier to follow sync logic

Signed-off-by: Christian Brauner 


  Commit: 26abd7eacac6d203ae9721e2bf825a3a50b844c8
  https://github.com/lxc/lxc/commit/26abd7eacac6d203ae9721e2bf825a3a50b844c8
  Author: Christian Brauner 
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: move new_cwd into tighter scope

Signed-off-by: Christian Brauner 


  Commit: 5d2b46fbb8f1bca6cbaa68f2e1b56f7e84b0f6fd
  https://github.com/lxc/lxc/commit/5d2b46fbb8f1bca6cbaa68f2e1b56f7e84b0f6fd
  Author: Christian Brauner 
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: use STDIN_FILENO instead of hard-coding 0

Signed-off-by: Christian Brauner 


  Commit: 3a24f14edfae62082caf72bd1e2b14701201e52d
  https://github.com/lxc/lxc/commit/3a24f14edfae62082caf72bd1e2b14701201e52d
  Author: Christian Brauner 
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: remove unneeded assignment

Signed-off-by: Christian Brauner 


  Commit: 39b3b69b21510bf2f297e6ba7038cc3671ff7e78
  https://github.com/lxc/lxc/commit/39b3b69b21510bf2f297e6ba7038cc3671ff7e78
  Author: Christian Brauner 
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: rework attaching to namespace fds

Signed-off-by: Christian Brauner 


  Commit: c538837d045c32c82aa2736a2f934787dd7d1281
  https://github.com/lxc/lxc/commit/c538837d045c32c82aa2736a2f934787dd7d1281
  Author: Christian Brauner 
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/macro.h

  Log Message:
  ---
  attach: move to file descriptor-only interactions

Signed-off-by: Christian Brauner 


  Commit: 25c659d5000190c1d96b36a8ed935181fc99e65d
  https://github.com/lxc/lxc/commit/25c659d5000190c1d96b36a8ed935181fc99e65d
  Author: Christian Brauner 
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/namespace.c
M src/lxc/namespace.h

  Log Message:
  ---
  attach: move to file descriptor only namespace interactions

Signed-off-by: Christian Brauner 


  Commit: 581b849a74c33598b24440220dc17e5ca0e946ff
  https://github.com/lxc/lxc/commit/581b849a74c33598b24440220dc17e5ca0e946ff
  Author: Christian Brauner 
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: init file descriptors to -EBADF

Signed-off-by: Christian Brauner 


  Commit: 0e24c5600da38f84c3d3b8d66ffe05244f15251d
  https://github.com/lxc/lxc/commit/0e24c5600da38f84c3d3b8d66ffe05244f15251d
  Author: Stéphane Graber 
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
M configure.ac
M src/lxc/attach.c
M src/lxc/attach.h
M src/lxc/attach_options.h
M src/lxc/confile.c
M src/lxc/confile.h
M src/lxc/lsm/lsm.c
M src/lxc/lsm/lsm.h
M src/lxc/macro.h
M src/lxc/namespace.c
M src/lxc/namespace.h
M src/lxc/start.c
M src/lxc/sync.c
M src/lxc/sync.h
M src/tests/attach.c

  Log Message:
  ---
  Merge pull request #3638 from brauner/2021-01-28/fixes

attach: improve attach codepaths


Compare: https://github.com/lxc/lxc/compare/0fa84a8cd2fe...0e24c5600da3
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 4f25e7: attach: invert child/parent handling

2021-01-27 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 4f25e72fb01a60dbe2d3be195582bab1fbd9707c
  https://github.com/lxc/lxc/commit/4f25e72fb01a60dbe2d3be195582bab1fbd9707c
  Author: Christian Brauner 
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: invert child/parent handling

This makes it more consistent with th rest of the shared library.

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: e11f5b8c91ef585e5764a32498a716b9813fcf47
  https://github.com/lxc/lxc/commit/e11f5b8c91ef585e5764a32498a716b9813fcf47
  Author: Christian Brauner 
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: use __do_free cleanup macro for cwd

but still yield memory immediately once we're done with it to not have it lying
around while the parent process is around.

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: 4f3b6a85ed04d223ac5590e20037e9a9ae26754e
  https://github.com/lxc/lxc/commit/4f3b6a85ed04d223ac5590e20037e9a9ae26754e
  Author: Christian Brauner 
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: tweak logging

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: ad001fb6d76361625fda40a1ae80b402734ef394
  https://github.com/lxc/lxc/commit/ad001fb6d76361625fda40a1ae80b402734ef394
  Author: Christian Brauner 
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: use __do_close for labelfd

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: 76783714397b18971644dcc2294ea32a2a08a3eb
  https://github.com/lxc/lxc/commit/76783714397b18971644dcc2294ea32a2a08a3eb
  Author: Christian Brauner 
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: coding style fixes

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: 7444657c87fddb97b50318ae64f5963f8eca705b
  https://github.com/lxc/lxc/commit/7444657c87fddb97b50318ae64f5963f8eca705b
  Author: Christian Brauner 
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: use free_disarm()

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: 16d19b34eaa5e5aed383269cce85d5e0733e8904
  https://github.com/lxc/lxc/commit/16d19b34eaa5e5aed383269cce85d5e0733e8904
  Author: Christian Brauner 
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: s/attach_child_main/do_attach/g

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: 737a8d85150be1ebc51356fd6e81dfc955a9b708
  https://github.com/lxc/lxc/commit/737a8d85150be1ebc51356fd6e81dfc955a9b708
  Author: Christian Brauner 
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: mark do_attach() as __noreturn

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: dab02267f01e4201c1a38600516ae0bd6baf620d
  https://github.com/lxc/lxc/commit/dab02267f01e4201c1a38600516ae0bd6baf620d
  Author: Christian Brauner 
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: make do_attach() void

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: 578d4b6202a667c6b88cb065eb721695176adb83
  https://github.com/lxc/lxc/commit/578d4b6202a667c6b88cb065eb721695176adb83
  Author: Christian Brauner 
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: use close_prot_errno_disarm()

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: b495984869abb70c7a7223d143efbce9694047f2
  https://github.com/lxc/lxc/commit/b495984869abb70c7a7223d143efbce9694047f2
  Author: Christian Brauner 
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: add some DEBUG() logging to stdfd dpulication

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: 0fa84a8cd2fea8d1db416b36ee053a21a08cad1e
  https://github.com/lxc/lxc/commit/0fa84a8cd2fea8d1db416b36ee053a21a08cad1e
  Author: Stéphane Graber 
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  Merge pull request #3637 from brauner/2021-01-27/fixes

attach: fixes


Compare: https://github.com/lxc/lxc/compare/665fcdf9031e...0fa84a8cd2fe
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] e25af1: conf: fix coding style

2021-01-27 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: e25af1bc389f259991dad3c522af820352adeddb
  https://github.com/lxc/lxc/commit/e25af1bc389f259991dad3c522af820352adeddb
  Author: Christian Brauner 
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: fix coding style

Signed-off-by: Christian Brauner 


  Commit: 7b371c1e0b03ee9988465bb5c89588c9f72b80fe
  https://github.com/lxc/lxc/commit/7b371c1e0b03ee9988465bb5c89588c9f72b80fe
  Author: Christian Brauner 
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: coding style fixes

Signed-off-by: Christian Brauner 


  Commit: f4bea7cc76c4ec0b1abbfb7f57eb623b625ccc6a
  https://github.com/lxc/lxc/commit/f4bea7cc76c4ec0b1abbfb7f57eb623b625ccc6a
  Author: Christian Brauner 
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: move proc and sys mountpoint creation int lxc_mount_auto_mounts()

Fixes: 493e00b68da4 ("mkdir -p /proc /sys on container startup")
Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: 665fcdf9031e18e90dd10c10c6fe622e24a1db64
  https://github.com/lxc/lxc/commit/665fcdf9031e18e90dd10c10c6fe622e24a1db64
  Author: Stéphane Graber 
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  Merge pull request #3636 from brauner/2021-01-27/fixes

conf: proc and sys mountpoint creation fixes


Compare: https://github.com/lxc/lxc/compare/e9636f4f4859...665fcdf9031e
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] d23cb2: file_utils: introduce read_file_at()

2021-01-26 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: d23cb29e64c61ba2a1ab9b7604fed43a816a65eb
  https://github.com/lxc/lxc/commit/d23cb29e64c61ba2a1ab9b7604fed43a816a65eb
  Author: Christian Brauner 
  Date:   2021-01-26 (Tue, 26 Jan 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/file_utils.c
M src/lxc/file_utils.h

  Log Message:
  ---
  file_utils: introduce read_file_at()

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: 9cde8a8ab43195a6ce9374bb893efdd392ba6ef3
  https://github.com/lxc/lxc/commit/9cde8a8ab43195a6ce9374bb893efdd392ba6ef3
  Author: Christian Brauner 
  Date:   2021-01-26 (Tue, 26 Jan 2021)

  Changed paths:
M src/lxc/string_utils.h

  Log Message:
  ---
  string_utils: add must_make_path_relative()

Stolen without shame from my previous implementation in LXCFS.

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: 09ed8992c586c1370fee984c1b655344e50896c2
  https://github.com/lxc/lxc/commit/09ed8992c586c1370fee984c1b655344e50896c2
  Author: Christian Brauner 
  Date:   2021-01-26 (Tue, 26 Jan 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: coding style fixes

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: f914ae08c498205b1661d743dffc368d2024cee0
  https://github.com/lxc/lxc/commit/f914ae08c498205b1661d743dffc368d2024cee0
  Author: Christian Brauner 
  Date:   2021-01-26 (Tue, 26 Jan 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: rework cg_unified_init()

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: 6dcd6f0284f2b4054bcf59dcebd27330e0389486
  https://github.com/lxc/lxc/commit/6dcd6f0284f2b4054bcf59dcebd27330e0389486
  Author: Christian Brauner 
  Date:   2021-01-26 (Tue, 26 Jan 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h

  Log Message:
  ---
  cgroups: detect and record cgroup2 freezer support

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: 928b065d34e2a8eecdfcd008d169a21bc1106a1d
  https://github.com/lxc/lxc/commit/928b065d34e2a8eecdfcd008d169a21bc1106a1d
  Author: Christian Brauner 
  Date:   2021-01-26 (Tue, 26 Jan 2021)

  Changed paths:
M src/lxc/criu.c

  Log Message:
  ---
  criu: handle cgroup2 freezer

Signed-off-by: Christian Brauner 


  Commit: 2c64170505bf9dfa640856621e631f601c82eb7b
  https://github.com/lxc/lxc/commit/2c64170505bf9dfa640856621e631f601c82eb7b
  Author: Stéphane Graber 
  Date:   2021-01-26 (Tue, 26 Jan 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/criu.c
M src/lxc/file_utils.c
M src/lxc/file_utils.h
M src/lxc/string_utils.h

  Log Message:
  ---
  Merge pull request #3633 from brauner/2021-01-25/criu

cgroups: fixes and cgroup2 improvements


Compare: https://github.com/lxc/lxc/compare/6f2f65909ede...2c64170505bf
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 123ca4: config: update ax_pthread.m4

2021-01-25 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 123ca49e2d8cacd87c02eaefd924dd1888563609
  https://github.com/lxc/lxc/commit/123ca49e2d8cacd87c02eaefd924dd1888563609
  Author: Christian Brauner 
  Date:   2021-01-25 (Mon, 25 Jan 2021)

  Changed paths:
M config/ax_pthread.m4

  Log Message:
  ---
  config: update ax_pthread.m4

Signed-off-by: Christian Brauner 


  Commit: 1aaf81c338fcf2d4fabb7a01dc7ede0d9ce2b8cb
  https://github.com/lxc/lxc/commit/1aaf81c338fcf2d4fabb7a01dc7ede0d9ce2b8cb
  Author: Christian Brauner 
  Date:   2021-01-25 (Mon, 25 Jan 2021)

  Changed paths:
M configure.ac

  Log Message:
  ---
  configure: add AC_SYS_LARGEFILE checking

Signed-off-by: Christian Brauner 


  Commit: b59bc011e3f90075218a3a851660be9ea7b5ab82
  https://github.com/lxc/lxc/commit/b59bc011e3f90075218a3a851660be9ea7b5ab82
  Author: Christian Brauner 
  Date:   2021-01-25 (Mon, 25 Jan 2021)

  Changed paths:
M Makefile.am
A config/attributes.m4
R config/ax_check_compile_flag.m4
R config/ax_check_link_flag.m4
M configure.ac
M src/lxc/Makefile.am
M src/tests/Makefile.am

  Log Message:
  ---
  autotools: update build

Signed-off-by: Christian Brauner 


  Commit: 6f2f65909ede8ef044850a1c60e676b85da4dea4
  https://github.com/lxc/lxc/commit/6f2f65909ede8ef044850a1c60e676b85da4dea4
  Author: Stéphane Graber 
  Date:   2021-01-25 (Mon, 25 Jan 2021)

  Changed paths:
M Makefile.am
A config/attributes.m4
R config/ax_check_compile_flag.m4
R config/ax_check_link_flag.m4
M config/ax_pthread.m4
M configure.ac
M src/lxc/Makefile.am
M src/tests/Makefile.am

  Log Message:
  ---
  Merge pull request #3632 from brauner/2021-01-25/fixes

autotools: update build


Compare: https://github.com/lxc/lxc/compare/8061dd6e67c8...6f2f65909ede
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 39b725: tree-wide: fix compilation with-Wstrict-prototypes...

2021-01-24 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 39b725730c74c63ac3685c2530d22790bed11c38
  https://github.com/lxc/lxc/commit/39b725730c74c63ac3685c2530d22790bed11c38
  Author: Christian Brauner 
  Date:   2021-01-24 (Sun, 24 Jan 2021)

  Changed paths:
M src/lxc/log.c
M src/lxc/lsm/apparmor.c
M src/lxc/tools/arguments.c
M src/lxc/tools/lxc_copy.c
M src/lxc/utils.c
M src/tests/cgpath.c
M src/tests/lxcpath.c
M src/tests/mount_injection.c

  Log Message:
  ---
  tree-wide: fix compilation with-Wstrict-prototypes -Wold-style-definition

Fixes: #3630
Signed-off-by: Christian Brauner 


  Commit: 8061dd6e67c82d7662b774f34377347501458ad4
  https://github.com/lxc/lxc/commit/8061dd6e67c82d7662b774f34377347501458ad4
  Author: Stéphane Graber 
  Date:   2021-01-24 (Sun, 24 Jan 2021)

  Changed paths:
M src/lxc/log.c
M src/lxc/lsm/apparmor.c
M src/lxc/tools/arguments.c
M src/lxc/tools/lxc_copy.c
M src/lxc/utils.c
M src/tests/cgpath.c
M src/tests/lxcpath.c
M src/tests/mount_injection.c

  Log Message:
  ---
  Merge pull request #3631 from brauner/2021-01-24/fixes

tree-wide: fix compilation with-Wstrict-prototypes -Wold-style-defini…


Compare: https://github.com/lxc/lxc/compare/609d2b2e6337...8061dd6e67c8
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 5f1269: tree-wide: fix some header inclusions

2021-01-22 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 5f1269773cd070a681717c26b86ce1b630d121f1
  https://github.com/lxc/lxc/commit/5f1269773cd070a681717c26b86ce1b630d121f1
  Author: Christian Brauner 
  Date:   2021-01-22 (Fri, 22 Jan 2021)

  Changed paths:
M src/lxc/commands.c
M src/lxc/conf.c
M src/lxc/confile.c

  Log Message:
  ---
  tree-wide: fix some header inclusions

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: 3382f3ede0bc54ed9ce9cb5877303e8000ea2ab7
  https://github.com/lxc/lxc/commit/3382f3ede0bc54ed9ce9cb5877303e8000ea2ab7
  Author: Christian Brauner 
  Date:   2021-01-22 (Fri, 22 Jan 2021)

  Changed paths:
M src/lxc/initutils.h

  Log Message:
  ---
  initutils: fix missing includes

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: 014a65ef161ab96068cd4d828ab92e19c9804d4d
  https://github.com/lxc/lxc/commit/014a65ef161ab96068cd4d828ab92e19c9804d4d
  Author: Christian Brauner 
  Date:   2021-01-22 (Fri, 22 Jan 2021)

  Changed paths:
M configure.ac

  Log Message:
  ---
  configure: support static binaries

Including openssl handling.

Signed-off-by: Christian Brauner 


  Commit: 8e43f33e65c3a9b9c439bf614bade2d959282e4e
  https://github.com/lxc/lxc/commit/8e43f33e65c3a9b9c439bf614bade2d959282e4e
  Author: Christian Brauner 
  Date:   2021-01-22 (Fri, 22 Jan 2021)

  Changed paths:
M src/lxc/Makefile.am

  Log Message:
  ---
  autotools: enable static builds for tools

Signed-off-by: Christian Brauner 


  Commit: 1d9188016357dcd8793fcdfaf2377d426bbe7cc9
  https://github.com/lxc/lxc/commit/1d9188016357dcd8793fcdfaf2377d426bbe7cc9
  Author: Christian Brauner 
  Date:   2021-01-22 (Fri, 22 Jan 2021)

  Changed paths:
M src/lxc/Makefile.am

  Log Message:
  ---
  autotools: enable static builds for commands

Signed-off-by: Christian Brauner 


  Commit: 609d2b2e63374c502d9bafe0cc61cd1d3b950608
  https://github.com/lxc/lxc/commit/609d2b2e63374c502d9bafe0cc61cd1d3b950608
  Author: Stéphane Graber 
  Date:   2021-01-22 (Fri, 22 Jan 2021)

  Changed paths:
M configure.ac
M src/lxc/Makefile.am
M src/lxc/commands.c
M src/lxc/conf.c
M src/lxc/confile.c
M src/lxc/initutils.h

  Log Message:
  ---
  Merge pull request #3629 from brauner/2021-01-22/static_binaries

build: allow to build all binaries statically via --enable-static-binaries


Compare: https://github.com/lxc/lxc/compare/2b6ad639eb94...609d2b2e6337
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 5d1bf4: conf: fix containers retaining CAP_NET_ADMIN

2021-01-22 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 5d1bf4c4e1c652ef99aa74cd6b3544461bb884b3
  https://github.com/lxc/lxc/commit/5d1bf4c4e1c652ef99aa74cd6b3544461bb884b3
  Author: Christian Brauner 
  Date:   2021-01-22 (Fri, 22 Jan 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/conf.c
M src/lxc/conf.h

  Log Message:
  ---
  conf: fix containers retaining CAP_NET_ADMIN

Fixes: #3627
Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: e6d4df7895ed1f17058e60dd4239131163d96566
  https://github.com/lxc/lxc/commit/e6d4df7895ed1f17058e60dd4239131163d96566
  Author: Christian Brauner 
  Date:   2021-01-22 (Fri, 22 Jan 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/utils.c

  Log Message:
  ---
  cgroups: fix cgroup mounting

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: b85b44169a2effb254f0f319cb1ba3e14332a174
  https://github.com/lxc/lxc/commit/b85b44169a2effb254f0f319cb1ba3e14332a174
  Author: Christian Brauner 
  Date:   2021-01-22 (Fri, 22 Jan 2021)

  Changed paths:
M src/lxc/lsm/apparmor.c

  Log Message:
  ---
  lsm: remove obsolute comment about constructor

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: 7b854e37a72808ba92be00a7effc6b3149b2b0af
  https://github.com/lxc/lxc/commit/7b854e37a72808ba92be00a7effc6b3149b2b0af
  Author: Christian Brauner 
  Date:   2021-01-22 (Fri, 22 Jan 2021)

  Changed paths:
M src/lxc/tools/lxc_attach.c

  Log Message:
  ---
  lxc_attach: include rexec conditionally

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: be0fb2f759c1294198c9c148ffbaaf5ab2ae9c83
  https://github.com/lxc/lxc/commit/be0fb2f759c1294198c9c148ffbaaf5ab2ae9c83
  Author: Stéphane Graber 
  Date:   2021-01-22 (Fri, 22 Jan 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/lsm/apparmor.c
M src/lxc/tools/lxc_attach.c
M src/lxc/utils.c

  Log Message:
  ---
  Merge pull request #3628 from brauner/2021-01-22/fixes

conf: fix containers retaining CAP_NET_ADMIN


Compare: https://github.com/lxc/lxc/compare/092529eaef5d...be0fb2f759c1
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc]

2021-01-11 Thread Stéphane Graber
  Branch: refs/tags/lxc-4.0.6
  Home:   https://github.com/lxc/lxc
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 1048d5: Release LXC 4.0.6

2021-01-11 Thread Stéphane Graber
  Branch: refs/heads/stable-4.0
  Home:   https://github.com/lxc/lxc
  Commit: 1048d5e1f63979b76a1088eb34cf0aba8b237506
  https://github.com/lxc/lxc/commit/1048d5e1f63979b76a1088eb34cf0aba8b237506
  Author: Stéphane Graber 
  Date:   2021-01-11 (Mon, 11 Jan 2021)

  Changed paths:
M configure.ac

  Log Message:
  ---
  Release LXC 4.0.6

Signed-off-by: Stéphane Graber 


___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 60a43d: make lxc-net hermetic w.r.t. existing dnsmasq config

2021-01-11 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 60a43d5564e1b6f076c2234b538c5e5fead5f726
  https://github.com/lxc/lxc/commit/60a43d5564e1b6f076c2234b538c5e5fead5f726
  Author: Motiejus Jakštys 
  Date:   2021-01-11 (Mon, 11 Jan 2021)

  Changed paths:
M config/init/common/lxc-net.in

  Log Message:
  ---
  make lxc-net hermetic w.r.t. existing dnsmasq config

lxc's dnsmasq will try to read system's dnsmasq if `--conf-file` is not
specified. This is likely not desirable, as lxc's dnsmasq should be
self-contained.

On my system the conflicting options are `--bind-interfaces` and
`--bind-dynamic`, since the same host is doing other DNS-y things
unrelated to lxc.

This is an incompatible change, since lxc's dnsmasq will stop honoring
system's `/etc/dnsmasq.conf`, and some systems may be relying on it.
Given that, I believe it should not depend on it by default, since
dnsmasq is lxc's implementation detail. However, if the user desires,
the old behavior could be brought back by setting
`LXC_DHCP_CONFILE=/etc/dnsmasq.conf` in `/etc/default/lxc-net`.

Signed-off-by: Motiejus Jakštys 


  Commit: 092529eaef5d72af8b5c8865e6f4fbecb834b23c
  https://github.com/lxc/lxc/commit/092529eaef5d72af8b5c8865e6f4fbecb834b23c
  Author: Stéphane Graber 
  Date:   2021-01-11 (Mon, 11 Jan 2021)

  Changed paths:
M config/init/common/lxc-net.in

  Log Message:
  ---
  Merge pull request #3617 from motiejus/lxc-net-dnsmasq

make lxc-net's dnsmasq hermetic


Compare: https://github.com/lxc/lxc/compare/5e4dddcf9b2f...092529eaef5d
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 949b30: Changed Version from 2.*.* to 4.*.*

2021-01-09 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 949b3059a2b12767505fafe4e9b51ff900364a18
  https://github.com/lxc/lxc/commit/949b3059a2b12767505fafe4e9b51ff900364a18
  Author: sirh3e 
  Date:   2021-01-09 (Sat, 09 Jan 2021)

  Changed paths:
M README.md

  Log Message:
  ---
  Changed Version from 2.*.* to 4.*.*

Signed-off-by: sirh3e 


  Commit: 5e4dddcf9b2f84f52f71095f2e8b8c59872ec861
  https://github.com/lxc/lxc/commit/5e4dddcf9b2f84f52f71095f2e8b8c59872ec861
  Author: Stéphane Graber 
  Date:   2021-01-09 (Sat, 09 Jan 2021)

  Changed paths:
M README.md

  Log Message:
  ---
  Merge pull request #3615 from sirh3e/master

Changed Version from 2.*.* to 4.*.*


Compare: https://github.com/lxc/lxc/compare/239578849f6c...5e4dddcf9b2f
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 24b77f: macro: use ascending order for capabilities

2021-01-04 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 24b77f47ad4cc791f6be0221b53cc791951a0ee5
  https://github.com/lxc/lxc/commit/24b77f47ad4cc791f6be0221b53cc791951a0ee5
  Author: Christian Brauner 
  Date:   2021-01-04 (Mon, 04 Jan 2021)

  Changed paths:
M src/lxc/macro.h

  Log Message:
  ---
  macro: use ascending order for capabilities

Signed-off-by: Christian Brauner 


  Commit: f2da98c04597cc55c84da67fca6ae54ee68e119d
  https://github.com/lxc/lxc/commit/f2da98c04597cc55c84da67fca6ae54ee68e119d
  Author: Christian Brauner 
  Date:   2021-01-04 (Mon, 04 Jan 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/macro.h

  Log Message:
  ---
  conf: define missing capabilities

Signed-off-by: Christian Brauner 


  Commit: 7b4cd4681da399acc1775773d7967a3c94635346
  https://github.com/lxc/lxc/commit/7b4cd4681da399acc1775773d7967a3c94635346
  Author: Christian Brauner 
  Date:   2021-01-04 (Mon, 04 Jan 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/macro.h

  Log Message:
  ---
  conf: add new capabilities 
CAP_{BLOCK_SUSPEND,PERFMON,BPF,CAP_CHECKPOINT_RESTORE}

Signed-off-by: Christian Brauner 


  Commit: fa934e3e24bd08ab1b49f5bd3aeff0406eff12f0
  https://github.com/lxc/lxc/commit/fa934e3e24bd08ab1b49f5bd3aeff0406eff12f0
  Author: Christian Brauner 
  Date:   2021-01-04 (Mon, 04 Jan 2021)

  Changed paths:
M src/lxc/macro.h

  Log Message:
  ---
  macro: define all capabilities

Fixes: #3612
Signed-off-by: Christian Brauner 


  Commit: 309ae2876fe9f58a8db21c5218b859cfc441e597
  https://github.com/lxc/lxc/commit/309ae2876fe9f58a8db21c5218b859cfc441e597
  Author: Christian Brauner 
  Date:   2021-01-04 (Mon, 04 Jan 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/conf.h

  Log Message:
  ---
  conf: add lxc_wants_cap() helper

Signed-off-by: Christian Brauner 


  Commit: d84b26bc8b531c8a8491b6c2061146d958acb63a
  https://github.com/lxc/lxc/commit/d84b26bc8b531c8a8491b6c2061146d958acb63a
  Author: Christian Brauner 
  Date:   2021-01-04 (Mon, 04 Jan 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h

  Log Message:
  ---
  conf: fix CAP_NET_ADMIN-based mount handling

Fixes: e8b9c9ec6fb9 ("unmounted proc/sys/net if dropping CAP_NET_ADMIN")
Signed-off-by: Christian Brauner 


  Commit: 239578849f6c7dd390b5d2b0b7da9910ccc5427f
  https://github.com/lxc/lxc/commit/239578849f6c7dd390b5d2b0b7da9910ccc5427f
  Author: Stéphane Graber 
  Date:   2021-01-04 (Mon, 04 Jan 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/macro.h

  Log Message:
  ---
  Merge pull request #3614 from brauner/2021-01-04/fixes

capability fixes


Compare: https://github.com/lxc/lxc/compare/bfcd663fc78f...239578849f6c
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] c1c919: utils: allow cross-device resolution

2021-01-01 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: c1c9193cfc89d2d126c31f5797b18a89413b1042
  https://github.com/lxc/lxc/commit/c1c9193cfc89d2d126c31f5797b18a89413b1042
  Author: Christian Brauner 
  Date:   2020-12-27 (Sun, 27 Dec 2020)

  Changed paths:
M src/lxc/utils.c

  Log Message:
  ---
  utils: allow cross-device resolution

This is needed to enable containers without a rootfs.

Fixes: #3607
Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: 31b84c7a026fb9f75e4f9fc625790af2b6a6c92b
  https://github.com/lxc/lxc/commit/31b84c7a026fb9f75e4f9fc625790af2b6a6c92b
  Author: Christian Brauner 
  Date:   2020-12-27 (Sun, 27 Dec 2020)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
M src/lxc/commands.c
M src/lxc/conf.c
M src/lxc/conf.h

  Log Message:
  ---
  cgroup2: move bpf device cgroup program to struct cgroup_ops

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: bfcd663fc78f2496934abd171eb7189872deb46d
  https://github.com/lxc/lxc/commit/bfcd663fc78f2496934abd171eb7189872deb46d
  Author: Stéphane Graber 
  Date:   2020-12-28 (Mon, 28 Dec 2020)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
M src/lxc/commands.c
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/utils.c

  Log Message:
  ---
  Merge pull request #3608 from brauner/2020-12-27/no_rootfs

bugfixes


Compare: https://github.com/lxc/lxc/compare/708e0653c859...bfcd663fc78f
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 667fcc: confile: cleanup set_config_hooks()

2020-12-15 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 667fcc0e3ca733c62fc0f68606b437225b3287d5
  https://github.com/lxc/lxc/commit/667fcc0e3ca733c62fc0f68606b437225b3287d5
  Author: Christian Brauner 
  Date:   2020-12-15 (Tue, 15 Dec 2020)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: cleanup set_config_hooks()

Signed-off-by: Christian Brauner 


  Commit: c583072d67e3079f9dc4b4b78c141190cd30a6cc
  https://github.com/lxc/lxc/commit/c583072d67e3079f9dc4b4b78c141190cd30a6cc
  Author: Christian Brauner 
  Date:   2020-12-15 (Tue, 15 Dec 2020)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: don't accidently alter lxc.cgroup.dir

Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: 708e0653c859914b41cdfa091c599f31dd003a61
  https://github.com/lxc/lxc/commit/708e0653c859914b41cdfa091c599f31dd003a61
  Author: Stéphane Graber 
  Date:   2020-12-15 (Tue, 15 Dec 2020)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  Merge pull request #3603 from brauner/2020-12-15/bugfixes

confile: don't accidently alter lxc.cgroup.dir


Compare: https://github.com/lxc/lxc/compare/8a0e2272ac58...708e0653c859
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 26ea55: conf: fix block-device based rootfs mounting

2020-12-14 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 26ea5533c941baee14923dfc3edfb9c91666d245
  https://github.com/lxc/lxc/commit/26ea5533c941baee14923dfc3edfb9c91666d245
  Author: Christian Brauner 
  Date:   2020-12-14 (Mon, 14 Dec 2020)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: fix block-device based rootfs mounting

Fixes: #3598
Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: 8a0e2272ac584b0af8febf26772f11a2d8396a6d
  https://github.com/lxc/lxc/commit/8a0e2272ac584b0af8febf26772f11a2d8396a6d
  Author: Stéphane Graber 
  Date:   2020-12-14 (Mon, 14 Dec 2020)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  Merge pull request #3601 from brauner/2020-12-14/bugfixes

conf: fix block-device based rootfs mounting


Compare: https://github.com/lxc/lxc/compare/970c8d964db6...8a0e2272ac58
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[lxc-devel] [lxc/lxc] 62af65: confile: cleanup set_config_personality()

2020-12-10 Thread Stéphane Graber
  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 62af653cc125c90997b48179fbcff7e0fe6317b6
  https://github.com/lxc/lxc/commit/62af653cc125c90997b48179fbcff7e0fe6317b6
  Author: Christian Brauner 
  Date:   2020-12-08 (Tue, 08 Dec 2020)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: cleanup set_config_personality()

Signed-off-by: Christian Brauner 


  Commit: 49aabd9d60e3879254ac6601a2fadb268259cc7e
  https://github.com/lxc/lxc/commit/49aabd9d60e3879254ac6601a2fadb268259cc7e
  Author: Christian Brauner 
  Date:   2020-12-08 (Tue, 08 Dec 2020)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: cleanup set_config_pty_max()

Signed-off-by: Christian Brauner 


  Commit: 572f6a14705f2e1a187cc50f40e825a774cf5de1
  https://github.com/lxc/lxc/commit/572f6a14705f2e1a187cc50f40e825a774cf5de1
  Author: Christian Brauner 
  Date:   2020-12-08 (Tue, 08 Dec 2020)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: cleanup set_config_start()

Signed-off-by: Christian Brauner 


  Commit: e16659731606d7f2ef9debe62dd872cbc403eb75
  https://github.com/lxc/lxc/commit/e16659731606d7f2ef9debe62dd872cbc403eb75
  Author: Christian Brauner 
  Date:   2020-12-08 (Tue, 08 Dec 2020)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: cleanup set_config_monitor()

Signed-off-by: Christian Brauner 


  Commit: cb5f3df2588ecf3c34716c6cac49dbfcaf6a83ff
  https://github.com/lxc/lxc/commit/cb5f3df2588ecf3c34716c6cac49dbfcaf6a83ff
  Author: Christian Brauner 
  Date:   2020-12-08 (Tue, 08 Dec 2020)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: cleanup set_config_monitor_signal_pdeath()

Signed-off-by: Christian Brauner 


  Commit: 154369953583fa1b321f588f142bdee724d4106e
  https://github.com/lxc/lxc/commit/154369953583fa1b321f588f142bdee724d4106e
  Author: Christian Brauner 
  Date:   2020-12-08 (Tue, 08 Dec 2020)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: cleanup set_config_group()

Signed-off-by: Christian Brauner 


  Commit: a6bf1128ebe08bd56a7e1f4481294485e22213fd
  https://github.com/lxc/lxc/commit/a6bf1128ebe08bd56a7e1f4481294485e22213fd
  Author: Christian Brauner 
  Date:   2020-12-08 (Tue, 08 Dec 2020)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: cleanup set_config_environment()

Signed-off-by: Christian Brauner 


  Commit: 755d65326956b5950e9e32057fdef3f288e52b70
  https://github.com/lxc/lxc/commit/755d65326956b5950e9e32057fdef3f288e52b70
  Author: Christian Brauner 
  Date:   2020-12-08 (Tue, 08 Dec 2020)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: cleanup set_config_tty_max()

Signed-off-by: Christian Brauner 


  Commit: 042f87117f4336273ebce6d6f233d858a66e1a1d
  https://github.com/lxc/lxc/commit/042f87117f4336273ebce6d6f233d858a66e1a1d
  Author: Christian Brauner 
  Date:   2020-12-08 (Tue, 08 Dec 2020)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: cleanup set_config_apparmor_allow_incomplete()

Signed-off-by: Christian Brauner 


  Commit: 55a7689135b3e8f47891d85e983422a40146d0ab
  https://github.com/lxc/lxc/commit/55a7689135b3e8f47891d85e983422a40146d0ab
  Author: Christian Brauner 
  Date:   2020-12-08 (Tue, 08 Dec 2020)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: cleanup set_config_apparmor_allow_nesting()

Signed-off-by: Christian Brauner 


  Commit: 7f44fda1da647d40771facaa771916151eb7bd84
  https://github.com/lxc/lxc/commit/7f44fda1da647d40771facaa771916151eb7bd84
  Author: Christian Brauner 
  Date:   2020-12-08 (Tue, 08 Dec 2020)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: cleanup set_config_apparmor_raw()

Signed-off-by: Christian Brauner 


  Commit: 34f3b30a78a74e543ba9029570fd07d0ba780200
  https://github.com/lxc/lxc/commit/34f3b30a78a74e543ba9029570fd07d0ba780200
  Author: Christian Brauner 
  Date:   2020-12-08 (Tue, 08 Dec 2020)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: cleanup set_config_log_file()

Signed-off-by: Christian Brauner 


  Commit: 806244c69d2faf83172efe70c7f9a5326e6a2582
  https://github.com/lxc/lxc/commit/806244c69d2faf83172efe70c7f9a5326e6a2582
  Author: Christian Brauner 
  Date:   2020-12-08 (Tue, 08 Dec 2020)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: cleanup set_config_log_level()

Signed-off-by: Christian Brauner 


  Commit: 0c48b874fda6f23bee0a438ca67b4dc0a1e98dcb
  https://github.com/lxc/lxc/commit/0c48b874fda6f23bee0a438ca67b4dc0a1e98dcb
  Author: Christian Brauner 
  Date:   2020-12-08 (Tue, 08 Dec 2020)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: cleanup set_config_log_level()


  1   2   3   4   5   6   7   8   9   10   >