Re: [lxc-devel] [PATCH] cgroupfs: get rid of the redundant error info

[Serge Hallyn]

Quoting Qiang Huang (h.huangqi...@huawei.com):
> 
> Signed-off-by: Qiang Huang 
> ---

Acked-by: Serge E. Hallyn 

>  src/lxc/cgroup.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/src/lxc/cgroup.c b/src/lxc/cgroup.c
> index 34bf126..9513e96 100644
> --- a/src/lxc/cgroup.c
> +++ b/src/lxc/cgroup.c
> @@ -976,10 +976,8 @@ struct cgroup_process_info *lxc_cgroupfs_create(const 
> char *name, const char *pa
>   /* if we didn't create the cgroup, then we have 
> to make sure that
>* further cgroups will be created properly
>*/
> - if (handle_cgroup_settings(mp, 
> info_ptr->cgroup_path) < 0) {
> - ERROR("Could not set clone_children to 
> 1 for cpuset hierarchy in pre-existing cgroup.");
> + if (handle_cgroup_settings(mp, 
> info_ptr->cgroup_path) < 0)
>   goto cleanup_from_error;
> - }
> 
>   /* already existed but path component of 
> pattern didn't contain '%n',
>* so this is not an error; but then we don't 
> need current_entire_path
> -- 
> 1.8.3
> 
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [PATCH] cgroupfs: get rid of the redundant error info

[Qiang Huang]

Signed-off-by: Qiang Huang 
---
 src/lxc/cgroup.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/lxc/cgroup.c b/src/lxc/cgroup.c
index 34bf126..9513e96 100644
--- a/src/lxc/cgroup.c
+++ b/src/lxc/cgroup.c
@@ -976,10 +976,8 @@ struct cgroup_process_info *lxc_cgroupfs_create(const char 
*name, const char *pa
/* if we didn't create the cgroup, then we have 
to make sure that
 * further cgroups will be created properly
 */
-   if (handle_cgroup_settings(mp, 
info_ptr->cgroup_path) < 0) {
-   ERROR("Could not set clone_children to 
1 for cpuset hierarchy in pre-existing cgroup.");
+   if (handle_cgroup_settings(mp, 
info_ptr->cgroup_path) < 0)
goto cleanup_from_error;
-   }

/* already existed but path component of 
pattern didn't contain '%n',
 * so this is not an error; but then we don't 
need current_entire_path
-- 
1.8.3

___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel