subject:"\[lxc\-devel\] \[lxc\/lxc\]"

[lxc-devel] [lxc/lxc] f80950: tests: fix a memory leak in cgpath

2021-04-13 Thread Christian Brauner

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: f80950eeefd6e8e133bdf21c4f10fb110f5b3de2
  https://github.com/lxc/lxc/commit/f80950eeefd6e8e133bdf21c4f10fb110f5b3de2
  Author: Evgeny Vereshchagin 
  Date:   2021-04-10 (Sat, 10 Apr 2021)

  Changed paths:
M src/tests/cgpath.c

  Log Message:
  ---
  tests: fix a memory leak in cgpath

```
==131188==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 568 byte(s) in 1 object(s) allocated from:
#0 0x7f8918943bc8 in malloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10dbc8)
#1 0x7f89181ee5a3 in lxc_container_new 
/home/vagrant/lxc/src/lxc/lxccontainer.c:5264
#2 0x55ffc5022869 in test_container /home/vagrant/lxc/src/tests/cgpath.c:176
#3 0x55ffc5023023 in main /home/vagrant/lxc/src/tests/cgpath.c:233
#4 0x7f891709e0b2 in __libc_start_main 
(/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
```

Signed-off-by: Evgeny Vereshchagin 


  Commit: c4142ec2a0ccffcfa6e78c01e8b60cf3848e1244
  https://github.com/lxc/lxc/commit/c4142ec2a0ccffcfa6e78c01e8b60cf3848e1244
  Author: Christian Brauner 
  Date:   2021-04-13 (Tue, 13 Apr 2021)

  Changed paths:
M src/tests/cgpath.c

  Log Message:
  ---
  Merge pull request #3783 from evverx/cgpath-memleak2

tests: fix a memory leak in cgpath


Compare: https://github.com/lxc/lxc/compare/ca52b7ff13c8...c4142ec2a0cc
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 8e2ef3: Revert "confile: make lxc_get_config() and lxc_get...

2021-04-13 Thread Christian Brauner

  Branch: refs/heads/stable-4.0
  Home:   https://github.com/lxc/lxc
  Commit: 8e2ef39ba53871acc526207285320a14f820d62d
  https://github.com/lxc/lxc/commit/8e2ef39ba53871acc526207285320a14f820d62d
  Author: Christian Brauner 
  Date:   2021-04-13 (Tue, 13 Apr 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  Revert "confile: make lxc_get_config() and lxc_get_config_net() always return 
non-NULL"

This reverts commit 674791ed75c53fb18c5823c5807876bde4865616.

Our stable queue tool somehow still listed this patch as pending when it
had already been applied earlier.

Signed-off-by: Christian Brauner 


___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 674791: confile: make lxc_get_config() and lxc_get_config_...

2021-04-13 Thread Evgeny Vereshchagin

  Branch: refs/heads/stable-4.0
  Home:   https://github.com/lxc/lxc
  Commit: 674791ed75c53fb18c5823c5807876bde4865616
  https://github.com/lxc/lxc/commit/674791ed75c53fb18c5823c5807876bde4865616
  Author: Christian Brauner 
  Date:   2021-04-13 (Tue, 13 Apr 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: make lxc_get_config() and lxc_get_config_net() always return non-NULL

Introduce the concept of an unsupported config item.

Signed-off-by: Christian Brauner 


  Commit: e46bffbb19e91d4b4c6e677b70f245f73a7c323a
  https://github.com/lxc/lxc/commit/e46bffbb19e91d4b4c6e677b70f245f73a7c323a
  Author: Evgeny Vereshchagin 
  Date:   2021-04-13 (Tue, 13 Apr 2021)

  Changed paths:
M src/tests/cgpath.c

  Log Message:
  ---
  tests: fix a memory leak in cgpath

```
$ sudo ./src/tests/lxc-test-cgpath
Container creation tests...Passed
Container creation with LXCPATH tests...Passed

=
==57206==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 296 byte(s) in 1 object(s) allocated from:
#0 0x7fef22c27dc6 in calloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10ddc6)
#1 0x557c6e3ce3d9 in cgroup_ops_init cgroups/cgfsng.c:3347
#2 0x557c6e3d6516 in cgroup_init cgroups/cgroup.c:33
#3 0x557c6e3788e2 in test_running_container 
/home/vagrant/lxc/src/tests/cgpath.c:102
#4 0x557c6e379c69 in test_container /home/vagrant/lxc/src/tests/cgpath.c:197
#5 0x557c6e379e37 in main /home/vagrant/lxc/src/tests/cgpath.c:233
#6 0x7fef2136c0b2 in __libc_start_main 
(/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

Direct leak of 296 byte(s) in 1 object(s) allocated from:
#0 0x7fef22c27dc6 in calloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10ddc6)
#1 0x557c6e3ce3d9 in cgroup_ops_init cgroups/cgfsng.c:3347
#2 0x557c6e3d6516 in cgroup_init cgroups/cgroup.c:33
#3 0x557c6e3788e2 in test_running_container 
/home/vagrant/lxc/src/tests/cgpath.c:102
#4 0x557c6e379c69 in test_container /home/vagrant/lxc/src/tests/cgpath.c:197
#5 0x557c6e379e61 in main /home/vagrant/lxc/src/tests/cgpath.c:237
#6 0x7fef2136c0b2 in __libc_start_main 
(/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
```

Signed-off-by: Evgeny Vereshchagin 


  Commit: 2cba1595e66c62d4a6ed4f8cd813bb06030238d8
  https://github.com/lxc/lxc/commit/2cba1595e66c62d4a6ed4f8cd813bb06030238d8
  Author: Evgeny Vereshchagin 
  Date:   2021-04-13 (Tue, 13 Apr 2021)

  Changed paths:
M src/tests/lxcpath.c

  Log Message:
  ---
  tests: fix a memory leak in lxcpath

```
$ sudo ./src/tests/lxc-test-lxcpath

=
==95911==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 39 byte(s) in 1 object(s) allocated from:
#0 0x7effafc8d3dd in strdup (/lib/x86_64-linux-gnu/libasan.so.5+0x963dd)
#1 0x7effaf5a2de6 in lxcapi_config_file_name 
/home/vagrant/lxc/src/lxc/lxccontainer.c:3190
#2 0x562961680c30 in main /home/vagrant/lxc/src/tests/lxcpath.c:49
#3 0x7effae5150b2 in __libc_start_main 
(/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

Direct leak of 21 byte(s) in 1 object(s) allocated from:
#0 0x7effafc8d3dd in strdup (/lib/x86_64-linux-gnu/libasan.so.5+0x963dd)
#1 0x7effaf5a2de6 in lxcapi_config_file_name 
/home/vagrant/lxc/src/lxc/lxccontainer.c:3190
#2 0x56296168115e in main /home/vagrant/lxc/src/tests/lxcpath.c:77
#3 0x7effae5150b2 in __libc_start_main 
(/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

Direct leak of 21 byte(s) in 1 object(s) allocated from:
#0 0x7effafc8d3dd in strdup (/lib/x86_64-linux-gnu/libasan.so.5+0x963dd)
#1 0x7effaf5a2de6 in lxcapi_config_file_name 
/home/vagrant/lxc/src/lxc/lxccontainer.c:3190
#2 0x562961680f0a in main /home/vagrant/lxc/src/tests/lxcpath.c:63
#3 0x7effae5150b2 in __libc_start_main 
(/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

SUMMARY: AddressSanitizer: 81 byte(s) leaked in 3 allocation(s).
```

Signed-off-by: Evgeny Vereshchagin 


Compare: https://github.com/lxc/lxc/compare/9c75153c5c2b...2cba1595e66c
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 4cd72b: tests: fix a memory leak in lxcpath

2021-04-13 Thread Christian Brauner

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 4cd72b693cc0c9f5d37464eb27844dfdd1ddf9ad
  https://github.com/lxc/lxc/commit/4cd72b693cc0c9f5d37464eb27844dfdd1ddf9ad
  Author: Evgeny Vereshchagin 
  Date:   2021-04-10 (Sat, 10 Apr 2021)

  Changed paths:
M src/tests/lxcpath.c

  Log Message:
  ---
  tests: fix a memory leak in lxcpath

```
$ sudo ./src/tests/lxc-test-lxcpath

=
==95911==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 39 byte(s) in 1 object(s) allocated from:
#0 0x7effafc8d3dd in strdup (/lib/x86_64-linux-gnu/libasan.so.5+0x963dd)
#1 0x7effaf5a2de6 in lxcapi_config_file_name 
/home/vagrant/lxc/src/lxc/lxccontainer.c:3190
#2 0x562961680c30 in main /home/vagrant/lxc/src/tests/lxcpath.c:49
#3 0x7effae5150b2 in __libc_start_main 
(/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

Direct leak of 21 byte(s) in 1 object(s) allocated from:
#0 0x7effafc8d3dd in strdup (/lib/x86_64-linux-gnu/libasan.so.5+0x963dd)
#1 0x7effaf5a2de6 in lxcapi_config_file_name 
/home/vagrant/lxc/src/lxc/lxccontainer.c:3190
#2 0x56296168115e in main /home/vagrant/lxc/src/tests/lxcpath.c:77
#3 0x7effae5150b2 in __libc_start_main 
(/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

Direct leak of 21 byte(s) in 1 object(s) allocated from:
#0 0x7effafc8d3dd in strdup (/lib/x86_64-linux-gnu/libasan.so.5+0x963dd)
#1 0x7effaf5a2de6 in lxcapi_config_file_name 
/home/vagrant/lxc/src/lxc/lxccontainer.c:3190
#2 0x562961680f0a in main /home/vagrant/lxc/src/tests/lxcpath.c:63
#3 0x7effae5150b2 in __libc_start_main 
(/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

SUMMARY: AddressSanitizer: 81 byte(s) leaked in 3 allocation(s).
```

Signed-off-by: Evgeny Vereshchagin 


  Commit: ca52b7ff13c8e37bb8c33feb38c1efe74fa73382
  https://github.com/lxc/lxc/commit/ca52b7ff13c8e37bb8c33feb38c1efe74fa73382
  Author: Christian Brauner 
  Date:   2021-04-13 (Tue, 13 Apr 2021)

  Changed paths:
M src/tests/lxcpath.c

  Log Message:
  ---
  Merge pull request #3781 from evverx/lxcpath-memleak

tests: fix a memory leak in lxcpath


Compare: https://github.com/lxc/lxc/compare/274615f9e3f2...ca52b7ff13c8
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 5a9fae: tests: fix a memory leak in cgpath

2021-04-13 Thread Christian Brauner

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 5a9fae9e7f2177f374d0d842a63bd134a4eeb943
  https://github.com/lxc/lxc/commit/5a9fae9e7f2177f374d0d842a63bd134a4eeb943
  Author: Evgeny Vereshchagin 
  Date:   2021-04-10 (Sat, 10 Apr 2021)

  Changed paths:
M src/tests/cgpath.c

  Log Message:
  ---
  tests: fix a memory leak in cgpath

```
$ sudo ./src/tests/lxc-test-cgpath
Container creation tests...Passed
Container creation with LXCPATH tests...Passed

=
==57206==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 296 byte(s) in 1 object(s) allocated from:
#0 0x7fef22c27dc6 in calloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10ddc6)
#1 0x557c6e3ce3d9 in cgroup_ops_init cgroups/cgfsng.c:3347
#2 0x557c6e3d6516 in cgroup_init cgroups/cgroup.c:33
#3 0x557c6e3788e2 in test_running_container 
/home/vagrant/lxc/src/tests/cgpath.c:102
#4 0x557c6e379c69 in test_container /home/vagrant/lxc/src/tests/cgpath.c:197
#5 0x557c6e379e37 in main /home/vagrant/lxc/src/tests/cgpath.c:233
#6 0x7fef2136c0b2 in __libc_start_main 
(/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

Direct leak of 296 byte(s) in 1 object(s) allocated from:
#0 0x7fef22c27dc6 in calloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10ddc6)
#1 0x557c6e3ce3d9 in cgroup_ops_init cgroups/cgfsng.c:3347
#2 0x557c6e3d6516 in cgroup_init cgroups/cgroup.c:33
#3 0x557c6e3788e2 in test_running_container 
/home/vagrant/lxc/src/tests/cgpath.c:102
#4 0x557c6e379c69 in test_container /home/vagrant/lxc/src/tests/cgpath.c:197
#5 0x557c6e379e61 in main /home/vagrant/lxc/src/tests/cgpath.c:237
#6 0x7fef2136c0b2 in __libc_start_main 
(/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
```

Signed-off-by: Evgeny Vereshchagin 


  Commit: 274615f9e3f2bbb0e2b7a9c007b6dcd54169404f
  https://github.com/lxc/lxc/commit/274615f9e3f2bbb0e2b7a9c007b6dcd54169404f
  Author: Christian Brauner 
  Date:   2021-04-13 (Tue, 13 Apr 2021)

  Changed paths:
M src/tests/cgpath.c

  Log Message:
  ---
  Merge pull request #3780 from evverx/cgpath-mem-leak

tests: fix a memory leak in cgpath


Compare: https://github.com/lxc/lxc/compare/aeff7df6e44d...274615f9e3f2
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 2d6a6c: github: Try to fix action naming

2021-04-12 Thread Christian Brauner

  Branch: refs/heads/stable-4.0
  Home:   https://github.com/lxc/lxc
  Commit: 2d6a6cb5a9a40382871428f3a98df7cdf6f18dd3
  https://github.com/lxc/lxc/commit/2d6a6cb5a9a40382871428f3a98df7cdf6f18dd3
  Author: Stéphane Graber 
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
M .github/workflows/build.yml
M .github/workflows/cifuzz.yml
M .github/workflows/coverity.yml
M .github/workflows/static-analysis.yml

  Log Message:
  ---
  github: Try to fix action naming

Signed-off-by: Stéphane Graber 


  Commit: 933acfaa431ed4d28bb3301dec0eae9cc375b422
  https://github.com/lxc/lxc/commit/933acfaa431ed4d28bb3301dec0eae9cc375b422
  Author: Christian Brauner 
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
M src/lxc/commands.c
M src/lxc/confile.c
M src/lxc/lxccontainer.c

  Log Message:
  ---
  confile: make lxc_get_config() and lxc_get_config_net() always return non-NULL

Introduce the concept of an unsupported config item.

Signed-off-by: Christian Brauner 


  Commit: 24d1ef2b2fae13033c322f0479c2c44d6ce3dda2
  https://github.com/lxc/lxc/commit/24d1ef2b2fae13033c322f0479c2c44d6ce3dda2
  Author: Christian Brauner 
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: simplify idmaptool_on_path_and_privileged()

Signed-off-by: Christian Brauner 


  Commit: c0f1dc951f29c6d492580b6da3d18d8c63020c2e
  https://github.com/lxc/lxc/commit/c0f1dc951f29c6d492580b6da3d18d8c63020c2e
  Author: Christian Brauner 
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: don't report success when idmaptools lack all privilege

Fixes: #3777
Signed-off-by: Christian Brauner 


  Commit: 0c167942df6ceba0bb05e0529350cc37dae5ae48
  https://github.com/lxc/lxc/commit/0c167942df6ceba0bb05e0529350cc37dae5ae48
  Author: Christian Brauner 
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: don't return early when calculating namespaces via pidfd

Signed-off-by: Christian Brauner 


  Commit: 9c75153c5c2b2c38a7461a2b35267f68e4471c4c
  https://github.com/lxc/lxc/commit/9c75153c5c2b2c38a7461a2b35267f68e4471c4c
  Author: Christian Brauner 
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
M src/lxc/rexec.c

  Log Message:
  ---
  Revert "rexec: mark all fds as close-on-exec if possible"

This reverts commit 531d36ad009325b74a105d9d6956e320f37b2937.

Callers might want to explicilty inhert file descriptors so we can't
close them behind their back when we exec.

Signed-off-by: Christian Brauner 


Compare: https://github.com/lxc/lxc/compare/fe38f0b14933...9c75153c5c2b
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 0b8e87: attach: don't return early when calculating namesp...

2021-04-12 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 0b8e876fbda6d7198b483ac7a96169e78f97e519
  https://github.com/lxc/lxc/commit/0b8e876fbda6d7198b483ac7a96169e78f97e519
  Author: Christian Brauner 
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: don't return early when calculating namespaces via pidfd

Signed-off-by: Christian Brauner 


  Commit: 09a83db55bf54f6afbde166f7edbe6bc68b90b67
  https://github.com/lxc/lxc/commit/09a83db55bf54f6afbde166f7edbe6bc68b90b67
  Author: Christian Brauner 
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
M src/lxc/rexec.c

  Log Message:
  ---
  Revert "rexec: mark all fds as close-on-exec if possible"

This reverts commit 531d36ad009325b74a105d9d6956e320f37b2937.

Callers might want to explicilty inhert file descriptors so we can't
close them behind their back when we exec.

Signed-off-by: Christian Brauner 


  Commit: aeff7df6e44d76a14e57646e9a63dee9c5aefbce
  https://github.com/lxc/lxc/commit/aeff7df6e44d76a14e57646e9a63dee9c5aefbce
  Author: Stéphane Graber 
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/rexec.c

  Log Message:
  ---
  Merge pull request #3779 from brauner/2021-04-12/attach_fixes

attach: fixes


Compare: https://github.com/lxc/lxc/compare/d32dcd01e730...aeff7df6e44d
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 83cb73: conf: simplify idmaptool_on_path_and_privileged()

2021-04-12 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 83cb7362189f122ce8820021d65c6fe182952950
  https://github.com/lxc/lxc/commit/83cb7362189f122ce8820021d65c6fe182952950
  Author: Christian Brauner 
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: simplify idmaptool_on_path_and_privileged()

Signed-off-by: Christian Brauner 


  Commit: a864a2e10537310c0455f843f4bfaff8dd90d222
  https://github.com/lxc/lxc/commit/a864a2e10537310c0455f843f4bfaff8dd90d222
  Author: Christian Brauner 
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: don't report success when idmaptools lack all privilege

Fixes: #3777
Signed-off-by: Christian Brauner 


  Commit: d32dcd01e730bdca53f607e861c8c646bbd4bb0d
  https://github.com/lxc/lxc/commit/d32dcd01e730bdca53f607e861c8c646bbd4bb0d
  Author: Stéphane Graber 
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  Merge pull request #3778 from brauner/2021-04-12/fixes

conf: idmaptool fixes


Compare: https://github.com/lxc/lxc/compare/965502a09cbc...d32dcd01e730
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 6773e1: confile: make lxc_get_config() and lxc_get_config_...

2021-04-07 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 6773e108515b6f595e0e43b806c52f834ec88467
  https://github.com/lxc/lxc/commit/6773e108515b6f595e0e43b806c52f834ec88467
  Author: Christian Brauner 
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
M src/lxc/commands.c
M src/lxc/confile.c
M src/lxc/lxccontainer.c

  Log Message:
  ---
  confile: make lxc_get_config() and lxc_get_config_net() always return non-NULL

Introduce the concept of an unsupported config item.

Signed-off-by: Christian Brauner 


  Commit: 965502a09cbc0e0cb5da2db0ad5f247a58924f79
  https://github.com/lxc/lxc/commit/965502a09cbc0e0cb5da2db0ad5f247a58924f79
  Author: Stéphane Graber 
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
M src/lxc/commands.c
M src/lxc/confile.c
M src/lxc/lxccontainer.c

  Log Message:
  ---
  Merge pull request #3775 from brauner/2021-04-07/fixes

confile: make lxc_get_config() and lxc_get_config_net() always return…


Compare: https://github.com/lxc/lxc/compare/33c0a5466e0d...965502a09cbc
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 7e8b9b: github: Try to fix action naming

2021-04-07 Thread Christian Brauner

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 7e8b9b04f24d19420fb177a62a1379363aa3e011
  https://github.com/lxc/lxc/commit/7e8b9b04f24d19420fb177a62a1379363aa3e011
  Author: Stéphane Graber 
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
M .github/workflows/build.yml
M .github/workflows/cifuzz.yml
M .github/workflows/coverity.yml
M .github/workflows/static-analysis.yml

  Log Message:
  ---
  github: Try to fix action naming

Signed-off-by: Stéphane Graber 


  Commit: 33c0a5466e0d7789a2971ae212a5885b7b31ed46
  https://github.com/lxc/lxc/commit/33c0a5466e0d7789a2971ae212a5885b7b31ed46
  Author: Christian Brauner 
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
M .github/workflows/build.yml
M .github/workflows/cifuzz.yml
M .github/workflows/coverity.yml
M .github/workflows/static-analysis.yml

  Log Message:
  ---
  Merge pull request #3774 from stgraber/master

github: Try to fix action naming


Compare: https://github.com/lxc/lxc/compare/f0c6219acbc6...33c0a5466e0d
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] cc5212: oss-fuzz: fuzz lxc_config_define_add and lxc_confi...

2021-04-07 Thread Christian Brauner

  Branch: refs/heads/stable-4.0
  Home:   https://github.com/lxc/lxc
  Commit: cc521256fa03ad49cecf160edd2ae61bfc6cbe05
  https://github.com/lxc/lxc/commit/cc521256fa03ad49cecf160edd2ae61bfc6cbe05
  Author: Evgeny Vereshchagin 
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
M src/lxc/confile.c
A src/tests/fuzz-lxc-define-load.c
M src/tests/oss-fuzz.sh

  Log Message:
  ---
  oss-fuzz: fuzz lxc_config_define_add and lxc_config_define_load

Signed-off-by: Evgeny Vereshchagin 


  Commit: dc95a270de4cb984dfa4ca81573ab22ff6ed29d1
  https://github.com/lxc/lxc/commit/dc95a270de4cb984dfa4ca81573ab22ff6ed29d1
  Author: Evgeny Vereshchagin 
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: fix a memory leak lxc_config_define_add

```
2021-04-02T05:45:54.9410345Z ==13==ERROR: LeakSanitizer: detected memory leaks
2021-04-02T05:45:54.9410737Z
2021-04-02T05:45:54.9411488Z Direct leak of 16 byte(s) in 1 object(s) allocated 
from:
2021-04-02T05:45:54.9412556Z #0 0x54d752 in calloc 
/src/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:154:3
2021-04-02T05:45:54.9413360Z #1 0x583795 in parse_new_conf_line 
/src/lxc/src/lxc/confile.c:3048:8
2021-04-02T05:45:54.9414057Z #2 0x582f1a in lxc_config_define_add 
/src/lxc/src/lxc/confile.c:3090:15
2021-04-02T05:45:54.9415352Z #3 0x5810fa in LLVMFuzzerTestOneInput 
/src/lxc/src/tests/fuzz-lxc-define-load.c:30:6
2021-04-02T05:45:54.9419212Z #4 0x483b93 in 
fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) 
/src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:599:15
2021-04-02T05:45:54.9421819Z #5 0x48309a in fuzzer::Fuzzer::RunOne(unsigned 
char const*, unsigned long, bool, fuzzer::InputInfo*, bool, bool*) 
/src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:505:3
2021-04-02T05:45:54.9424205Z #6 0x485474 in 
fuzzer::Fuzzer::ReadAndExecuteSeedCorpora(std::__Fuzzer::vector >&) 
/src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:814:7
2021-04-02T05:45:54.9426658Z #7 0x485689 in 
fuzzer::Fuzzer::Loop(std::__Fuzzer::vector >&) 
/src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:845:3
2021-04-02T05:45:54.9428616Z #8 0x473717 in fuzzer::FuzzerDriver(int*, 
char***, int (*)(unsigned char const*, unsigned long)) 
/src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:906:6
2021-04-02T05:45:54.9429989Z #9 0x49f572 in main 
/src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
2021-04-02T05:45:54.9433312Z #10 0x7fa96041b83f in __libc_start_main 
(/lib/x86_64-linux-gnu/libc.so.6+0x2083f)
2021-04-02T05:45:54.9433795Z
2021-04-02T05:45:54.9434661Z DEDUP_TOKEN: 
calloc--parse_new_conf_line--lxc_config_define_add
2021-04-02T05:45:54.9435483Z SUMMARY: AddressSanitizer: 16 byte(s) leaked in 1 
allocation(s).
2021-04-02T05:45:54.9435958Z
2021-04-02T05:45:54.9436404Z INFO: a leak has been found in the initial corpus.
```

Signed-off-by: Evgeny Vereshchagin 


  Commit: 2be8511d3b020febed50266e1d76a769b8f8c888
  https://github.com/lxc/lxc/commit/2be8511d3b020febed50266e1d76a769b8f8c888
  Author: Evgeny Vereshchagin 
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
M .github/workflows/cifuzz.yml

  Log Message:
  ---
  cifuzz: fuzz longer

Signed-off-by: Evgeny Vereshchagin 


  Commit: b425aad13f4a2a5e10a50e37dad83b771312a108
  https://github.com/lxc/lxc/commit/b425aad13f4a2a5e10a50e37dad83b771312a108
  Author: Christian Brauner 
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
M src/lxc/macro.h

  Log Message:
  ---
  macro: ensure ret_errno() always returns negative

Signed-off-by: Christian Brauner 


  Commit: b33f435db702da255cf4990174629e032ebd84e1
  https://github.com/lxc/lxc/commit/b33f435db702da255cf4990174629e032ebd84e1
  Author: Christian Brauner 
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
M src/lxc/log.h

  Log Message:
  ---
  log: add error_ret()

Signed-off-by: Christian Brauner 


  Commit: fe38f0b149338f89bcf9a540e695e664bdd2d55b
  https://github.com/lxc/lxc/commit/fe38f0b149338f89bcf9a540e695e664bdd2d55b
  Author: Christian Brauner 
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: enforce maximum subkey length

Signed-off-by: Christian Brauner 


Compare: https://github.com/lxc/lxc/compare/5a624e087078...fe38f0b14933
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 0a3b86: macro: ensure ret_errno() always returns negative

2021-04-07 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 0a3b86f90ceac8de887095fc7904851d67fac413
  https://github.com/lxc/lxc/commit/0a3b86f90ceac8de887095fc7904851d67fac413
  Author: Christian Brauner 
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
M src/lxc/macro.h

  Log Message:
  ---
  macro: ensure ret_errno() always returns negative

Signed-off-by: Christian Brauner 


  Commit: c3cef319e34c5041833387136b89881634fe982c
  https://github.com/lxc/lxc/commit/c3cef319e34c5041833387136b89881634fe982c
  Author: Christian Brauner 
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
M src/lxc/log.h

  Log Message:
  ---
  log: add error_ret()

Signed-off-by: Christian Brauner 


  Commit: ae393e1328b5c107d1ffc735cfdd25690a2702ff
  https://github.com/lxc/lxc/commit/ae393e1328b5c107d1ffc735cfdd25690a2702ff
  Author: Christian Brauner 
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: enforce maximum subkey length

Signed-off-by: Christian Brauner 


  Commit: f0c6219acbc68553921fc599f1939cdbd1999e0b
  https://github.com/lxc/lxc/commit/f0c6219acbc68553921fc599f1939cdbd1999e0b
  Author: Stéphane Graber 
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/log.h
M src/lxc/macro.h

  Log Message:
  ---
  Merge pull request #3773 from brauner/2021-04-06/fixes_2

confile & log: fixes


Compare: https://github.com/lxc/lxc/compare/9d984c3fb5b4...f0c6219acbc6
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] e8694d: oss-fuzz: fuzz lxc_config_define_add and lxc_confi...

2021-04-07 Thread Christian Brauner

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: e8694d9a22fd331ef8208bd2c9725eef729bb6dc
  https://github.com/lxc/lxc/commit/e8694d9a22fd331ef8208bd2c9725eef729bb6dc
  Author: Evgeny Vereshchagin 
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
M src/lxc/confile.c
A src/tests/fuzz-lxc-define-load.c
M src/tests/oss-fuzz.sh

  Log Message:
  ---
  oss-fuzz: fuzz lxc_config_define_add and lxc_config_define_load

Signed-off-by: Evgeny Vereshchagin 


  Commit: 1a46f8537ecfb1229564fa13ce6cd864bc5a4ca6
  https://github.com/lxc/lxc/commit/1a46f8537ecfb1229564fa13ce6cd864bc5a4ca6
  Author: Evgeny Vereshchagin 
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: fix a memory leak lxc_config_define_add

```
2021-04-02T05:45:54.9410345Z ==13==ERROR: LeakSanitizer: detected memory leaks
2021-04-02T05:45:54.9410737Z
2021-04-02T05:45:54.9411488Z Direct leak of 16 byte(s) in 1 object(s) allocated 
from:
2021-04-02T05:45:54.9412556Z #0 0x54d752 in calloc 
/src/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:154:3
2021-04-02T05:45:54.9413360Z #1 0x583795 in parse_new_conf_line 
/src/lxc/src/lxc/confile.c:3048:8
2021-04-02T05:45:54.9414057Z #2 0x582f1a in lxc_config_define_add 
/src/lxc/src/lxc/confile.c:3090:15
2021-04-02T05:45:54.9415352Z #3 0x5810fa in LLVMFuzzerTestOneInput 
/src/lxc/src/tests/fuzz-lxc-define-load.c:30:6
2021-04-02T05:45:54.9419212Z #4 0x483b93 in 
fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) 
/src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:599:15
2021-04-02T05:45:54.9421819Z #5 0x48309a in fuzzer::Fuzzer::RunOne(unsigned 
char const*, unsigned long, bool, fuzzer::InputInfo*, bool, bool*) 
/src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:505:3
2021-04-02T05:45:54.9424205Z #6 0x485474 in 
fuzzer::Fuzzer::ReadAndExecuteSeedCorpora(std::__Fuzzer::vector >&) 
/src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:814:7
2021-04-02T05:45:54.9426658Z #7 0x485689 in 
fuzzer::Fuzzer::Loop(std::__Fuzzer::vector >&) 
/src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:845:3
2021-04-02T05:45:54.9428616Z #8 0x473717 in fuzzer::FuzzerDriver(int*, 
char***, int (*)(unsigned char const*, unsigned long)) 
/src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:906:6
2021-04-02T05:45:54.9429989Z #9 0x49f572 in main 
/src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
2021-04-02T05:45:54.9433312Z #10 0x7fa96041b83f in __libc_start_main 
(/lib/x86_64-linux-gnu/libc.so.6+0x2083f)
2021-04-02T05:45:54.9433795Z
2021-04-02T05:45:54.9434661Z DEDUP_TOKEN: 
calloc--parse_new_conf_line--lxc_config_define_add
2021-04-02T05:45:54.9435483Z SUMMARY: AddressSanitizer: 16 byte(s) leaked in 1 
allocation(s).
2021-04-02T05:45:54.9435958Z
2021-04-02T05:45:54.9436404Z INFO: a leak has been found in the initial corpus.
```

Signed-off-by: Evgeny Vereshchagin 


  Commit: 55376ebd14060e5a950af289a48c8317f1ca8423
  https://github.com/lxc/lxc/commit/55376ebd14060e5a950af289a48c8317f1ca8423
  Author: Evgeny Vereshchagin 
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
M .github/workflows/cifuzz.yml

  Log Message:
  ---
  cifuzz: fuzz longer

Signed-off-by: Evgeny Vereshchagin 


  Commit: 9d984c3fb5b4ae386ef956704977dc687488c74e
  https://github.com/lxc/lxc/commit/9d984c3fb5b4ae386ef956704977dc687488c74e
  Author: Christian Brauner 
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
M .github/workflows/cifuzz.yml
M src/lxc/confile.c
A src/tests/fuzz-lxc-define-load.c
M src/tests/oss-fuzz.sh

  Log Message:
  ---
  Merge pull request #3763 from evverx/fuzz-lxc-define-load

oss-fuzz: fuzz lxc_config_define_add and lxc_config_define_load


Compare: https://github.com/lxc/lxc/compare/ace51ce88d91...9d984c3fb5b4
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] cfc0a4: conf: fix setups where /dev is outside of LXC's co...

2021-04-06 Thread Christian Ratzenhofer

  Branch: refs/heads/stable-4.0
  Home:   https://github.com/lxc/lxc
  Commit: cfc0a48ea2162f5377edd5d19f4e1c8e6f0adf66
  https://github.com/lxc/lxc/commit/cfc0a48ea2162f5377edd5d19f4e1c8e6f0adf66
  Author: Christian Brauner 
  Date:   2021-04-06 (Tue, 06 Apr 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: fix setups where /dev is outside of LXC's control

Fixes: #3770
Suggested-by: Ruben Jenster 
Signed-off-by: Christian Brauner 


  Commit: 2e6527320e93ea3af75332eedc97f60d9654995c
  https://github.com/lxc/lxc/commit/2e6527320e93ea3af75332eedc97f60d9654995c
  Author: Christian Brauner 
  Date:   2021-04-06 (Tue, 06 Apr 2021)

  Changed paths:
M src/lxc/log.h

  Log Message:
  ---
  log: ensure we always return negative errno

Signed-off-by: Christian Brauner 


  Commit: 5a624e0870789ddd352ec27cdf0c5ea05883762d
  https://github.com/lxc/lxc/commit/5a624e0870789ddd352ec27cdf0c5ea05883762d
  Author: Christian Ratzenhofer 
  Date:   2021-04-06 (Tue, 06 Apr 2021)

  Changed paths:
M templates/lxc-busybox.in
M templates/lxc-download.in
M templates/lxc-local.in
M templates/lxc-oci.in

  Log Message:
  ---
  templates/*.in: fixed PATH handling with spaces

if $PATH already contains a path with a space the append of the
default directories in all template scripts fails with an error
like the following:

/usr/share/lxc/templates/lxc-download: 69: export: (x86)/NVIDIA: bad
variable name

Signed-off-by: Christian Ratzenhofer 


Compare: https://github.com/lxc/lxc/compare/448462dd3788...5a624e087078
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 655d10: templates/*.in: fixed PATH handling with spaces

2021-04-06 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 655d10ed7f4eff465cf2be1f0a3664f86df7b83c
  https://github.com/lxc/lxc/commit/655d10ed7f4eff465cf2be1f0a3664f86df7b83c
  Author: Christian Ratzenhofer 
  Date:   2021-04-06 (Tue, 06 Apr 2021)

  Changed paths:
M templates/lxc-busybox.in
M templates/lxc-download.in
M templates/lxc-local.in
M templates/lxc-oci.in

  Log Message:
  ---
  templates/*.in: fixed PATH handling with spaces

if $PATH already contains a path with a space the append of the
default directories in all template scripts fails with an error
like the following:

/usr/share/lxc/templates/lxc-download: 69: export: (x86)/NVIDIA: bad
variable name

Signed-off-by: Christian Ratzenhofer 


  Commit: ace51ce88d919428889819332233075937050fc7
  https://github.com/lxc/lxc/commit/ace51ce88d919428889819332233075937050fc7
  Author: Stéphane Graber 
  Date:   2021-04-06 (Tue, 06 Apr 2021)

  Changed paths:
M templates/lxc-busybox.in
M templates/lxc-download.in
M templates/lxc-local.in
M templates/lxc-oci.in

  Log Message:
  ---
  Merge pull request #3772 from merlin1991/master

templates/*.in: fixed PATH handling with spaces


Compare: https://github.com/lxc/lxc/compare/093bfcc83cb5...ace51ce88d91
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 1f0a3b: conf: fix setups where /dev is outside of LXC's co...

2021-04-06 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 1f0a3b6e48bf84a1405affeb52b8cdb4b19fcfce
  https://github.com/lxc/lxc/commit/1f0a3b6e48bf84a1405affeb52b8cdb4b19fcfce
  Author: Christian Brauner 
  Date:   2021-04-06 (Tue, 06 Apr 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: fix setups where /dev is outside of LXC's control

Fixes: #3770
Suggested-by: Ruben Jenster 
Signed-off-by: Christian Brauner 


  Commit: e2c8dbd8bc78784c831a19ac25500960f0601c6e
  https://github.com/lxc/lxc/commit/e2c8dbd8bc78784c831a19ac25500960f0601c6e
  Author: Christian Brauner 
  Date:   2021-04-06 (Tue, 06 Apr 2021)

  Changed paths:
M src/lxc/log.h

  Log Message:
  ---
  log: ensure we always return negative errno

Signed-off-by: Christian Brauner 


  Commit: 093bfcc83cb5cdacf2f67f69fda404527b9149b8
  https://github.com/lxc/lxc/commit/093bfcc83cb5cdacf2f67f69fda404527b9149b8
  Author: Stéphane Graber 
  Date:   2021-04-06 (Tue, 06 Apr 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/log.h

  Log Message:
  ---
  Merge pull request #3771 from brauner/2021-04-06/fixes

conf: fix setups where /dev is outside of LXC's control


Compare: https://github.com/lxc/lxc/compare/d75ddd9b1b5b...093bfcc83cb5
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] d6df2b: confile: complain when LXC is built without selinu...

2021-04-02 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: d6df2b8fdf11bbe01a1caf3130c6fed34a9850f1
  https://github.com/lxc/lxc/commit/d6df2b8fdf11bbe01a1caf3130c6fed34a9850f1
  Author: Christian Brauner 
  Date:   2021-04-02 (Fri, 02 Apr 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: complain when LXC is built without selinux support

Link: https://github.com/lxc/lxc/issues/3765
Signed-off-by: Christian Brauner 


  Commit: 8f899a4a127b40f9af13c8fdf116e7c9d4bfde56
  https://github.com/lxc/lxc/commit/8f899a4a127b40f9af13c8fdf116e7c9d4bfde56
  Author: Christian Brauner 
  Date:   2021-04-02 (Fri, 02 Apr 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: complain when LXC is built without AppArmor support

Signed-off-by: Christian Brauner 


  Commit: d75ddd9b1b5b083fc4562347cd44668f060286a3
  https://github.com/lxc/lxc/commit/d75ddd9b1b5b083fc4562347cd44668f060286a3
  Author: Stéphane Graber 
  Date:   2021-04-02 (Fri, 02 Apr 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  Merge pull request #3766 from brauner/2021-04-02/fixes_2

lsm: fixes


Compare: https://github.com/lxc/lxc/compare/6fde9fb187a6...d75ddd9b1b5b
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 057d2c: confile: fix lxc.namespace.share.[identifier]

2021-04-02 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 057d2caecbb11c7127a17d4eda33ba2e250a752a
  https://github.com/lxc/lxc/commit/057d2caecbb11c7127a17d4eda33ba2e250a752a
  Author: Christian Brauner 
  Date:   2021-04-02 (Fri, 02 Apr 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: fix lxc.namespace.share.[identifier]

Link: https://github.com/lxc/lxc/pull/3763/files#r606089660
Signed-off-by: Christian Brauner 


  Commit: 6fde9fb187a63f67e8790ad897f43e77c25edb27
  https://github.com/lxc/lxc/commit/6fde9fb187a63f67e8790ad897f43e77c25edb27
  Author: Stéphane Graber 
  Date:   2021-04-02 (Fri, 02 Apr 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  Merge pull request #3764 from brauner/2021-04-02/fixes

confile: fix lxc.namespace.share.[identifier]


Compare: https://github.com/lxc/lxc/compare/8aa602556a42...6fde9fb187a6
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 4c7de7: lxc_user_nic: cleanup append_alloted()

2021-04-01 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 4c7de7c5ee74d6c92cadc1e75e3f4e355baec9ba
  https://github.com/lxc/lxc/commit/4c7de7c5ee74d6c92cadc1e75e3f4e355baec9ba
  Author: Christian Brauner 
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
M src/lxc/cmd/lxc_user_nic.c

  Log Message:
  ---
  lxc_user_nic: cleanup append_alloted()

Signed-off-by: Christian Brauner 


  Commit: 68dd0ea545c9e6e9ce1c772ca7a88b663da59ddf
  https://github.com/lxc/lxc/commit/68dd0ea545c9e6e9ce1c772ca7a88b663da59ddf
  Author: Christian Brauner 
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
M src/lxc/cmd/lxc_user_nic.c

  Log Message:
  ---
  lxc_user_nic: cleanup get_alloted()

Signed-off-by: Christian Brauner 


  Commit: 5fba37a1341457363d1b172bfb3453322a1854b0
  https://github.com/lxc/lxc/commit/5fba37a1341457363d1b172bfb3453322a1854b0
  Author: Christian Brauner 
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
M src/lxc/string_utils.c
M src/lxc/string_utils.h
M src/lxc/tools/lxc_copy.c

  Log Message:
  ---
  string_utils: move to lxc-copy() sources

It's the only place where it is still used.

Signed-off-by: Christian Brauner 


  Commit: 90e69d7178610809e0531a77182dc12869455f9e
  https://github.com/lxc/lxc/commit/90e69d7178610809e0531a77182dc12869455f9e
  Author: Christian Brauner 
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
M src/lxc/string_utils.c

  Log Message:
  ---
  string_utils: ensure that errno is set on return

Signed-off-by: Christian Brauner 


  Commit: 59f5a10311c25503ad072657e8a615be0004
  https://github.com/lxc/lxc/commit/59f5a10311c25503ad072657e8a615be0004
  Author: Christian Brauner 
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
M src/lxc/string_utils.c
M src/lxc/string_utils.h

  Log Message:
  ---
  string_utils: use restrict for lxc_safe_int64_residual()

Signed-off-by: Christian Brauner 


  Commit: 7707b0e06e35fa25dee42f9295d1707389b1676c
  https://github.com/lxc/lxc/commit/7707b0e06e35fa25dee42f9295d1707389b1676c
  Author: Christian Brauner 
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/confile.h

  Log Message:
  ---
  confile: simplify get_network_config_ops()

Signed-off-by: Christian Brauner 


  Commit: 8aa602556a425eee359847aaf01015ea146fd164
  https://github.com/lxc/lxc/commit/8aa602556a425eee359847aaf01015ea146fd164
  Author: Stéphane Graber 
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
M src/lxc/cmd/lxc_user_nic.c
M src/lxc/confile.c
M src/lxc/confile.h
M src/lxc/string_utils.c
M src/lxc/string_utils.h
M src/lxc/tools/lxc_copy.c

  Log Message:
  ---
  Merge pull request #3762 from brauner/2021-03-31/fixes

fixes: Makefile, lxc-user-nic, simplify get_network_config_ops()


Compare: https://github.com/lxc/lxc/compare/b405dec645ae...8aa602556a42
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] e7e034: oss-fuzz: reject giant configs early

2021-04-01 Thread Christian Brauner

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: e7e0343fd9f0cbe3d876860a1cd68afc848278ab
  https://github.com/lxc/lxc/commit/e7e0343fd9f0cbe3d876860a1cd68afc848278ab
  Author: Evgeny Vereshchagin 
  Date:   2021-03-30 (Tue, 30 Mar 2021)

  Changed paths:
M src/tests/fuzz-lxc-config-read.c

  Log Message:
  ---
  oss-fuzz: reject giant configs early

It should help the fuzzer to avoid running into timeouts
like https://oss-fuzz.com/testcase-detail/513248632064.
Hopefully, once this is merged OSS-Fuzz will report only
infinite loops as timeouts.

Signed-off-by: Evgeny Vereshchagin 


  Commit: b405dec645aec2ded7c52dadd180a7f5cd88d7fb
  https://github.com/lxc/lxc/commit/b405dec645aec2ded7c52dadd180a7f5cd88d7fb
  Author: Christian Brauner 
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
M src/tests/fuzz-lxc-config-read.c

  Log Message:
  ---
  Merge pull request #3760 from evverx/reject-giant-configs

oss-fuzz: reject giant configs early


Compare: https://github.com/lxc/lxc/compare/f5312e35d3b4...b405dec645ae
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 85d70b: ci: stop passing --enable-ubsan

2021-03-31 Thread Christian Brauner

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 85d70be752b26c9cb68d2f7067f12d4f5ebb91a7
  https://github.com/lxc/lxc/commit/85d70be752b26c9cb68d2f7067f12d4f5ebb91a7
  Author: Evgeny Vereshchagin 
  Date:   2021-03-30 (Tue, 30 Mar 2021)

  Changed paths:
M .github/workflows/build.yml

  Log Message:
  ---
  ci: stop passing --enable-ubsan

It's just a follow-up to 5f404236273bb211 (where --enable-ubsan
was removed).

Signed-off-by: Evgeny Vereshchagin 


  Commit: 49ffe5da49b1ec8e7617530112de8fda7400fe10
  https://github.com/lxc/lxc/commit/49ffe5da49b1ec8e7617530112de8fda7400fe10
  Author: Evgeny Vereshchagin 
  Date:   2021-03-30 (Tue, 30 Mar 2021)

  Changed paths:
M src/tests/oss-fuzz.sh

  Log Message:
  ---
  oss-fuzz.sh: get rid of the sed "no-undefined" kludge

Signed-off-by: Evgeny Vereshchagin 


  Commit: 7bf9dc49e72cbd635a3ef861592bfbb4da02c0d9
  https://github.com/lxc/lxc/commit/7bf9dc49e72cbd635a3ef861592bfbb4da02c0d9
  Author: Evgeny Vereshchagin 
  Date:   2021-03-30 (Tue, 30 Mar 2021)

  Changed paths:
M .github/workflows/build.yml

  Log Message:
  ---
  ci: also build with ASan/UBsan

Signed-off-by: Evgeny Vereshchagin 


  Commit: b31484bd1bdee7e20dc651b816bf42daf48ad4db
  https://github.com/lxc/lxc/commit/b31484bd1bdee7e20dc651b816bf42daf48ad4db
  Author: Evgeny Vereshchagin 
  Date:   2021-03-30 (Tue, 30 Mar 2021)

  Changed paths:
M .github/workflows/build.yml

  Log Message:
  ---
  ci: enable PAM

to make sure pam_cgfs is buildable with ASan/UBsan too

Signed-off-by: Evgeny Vereshchagin 


  Commit: 792a48b18092413110488cfabbdaacf12faef8a4
  https://github.com/lxc/lxc/commit/792a48b18092413110488cfabbdaacf12faef8a4
  Author: Evgeny Vereshchagin 
  Date:   2021-03-30 (Tue, 30 Mar 2021)

  Changed paths:
M configure.ac
M src/lxc/Makefile.am

  Log Message:
  ---
  build-system: make it compatible with ASan/UBsan/MSan

Closes: https://github.com/lxc/lxc/issues/3727

Signed-off-by: Evgeny Vereshchagin 


  Commit: f5312e35d3b4482293d237863d3cc7a8295818fb
  https://github.com/lxc/lxc/commit/f5312e35d3b4482293d237863d3cc7a8295818fb
  Author: Christian Brauner 
  Date:   2021-03-31 (Wed, 31 Mar 2021)

  Changed paths:
M .github/workflows/build.yml
M configure.ac
M src/lxc/Makefile.am
M src/tests/oss-fuzz.sh

  Log Message:
  ---
  Merge pull request #3759 from evverx/san-compatible

build-system: make it compatible with ASan/UBsan/Msan


Compare: https://github.com/lxc/lxc/compare/6dcd23e2bd36...f5312e35d3b4
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 365136: confile: cap to last bit in set_config_net_ipv4_ad...

2021-03-31 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 365136359f8bf991ed172b498909000ec18b32de
  https://github.com/lxc/lxc/commit/365136359f8bf991ed172b498909000ec18b32de
  Author: Christian Brauner 
  Date:   2021-03-31 (Wed, 31 Mar 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/macro.h

  Log Message:
  ---
  confile: cap to last bit in set_config_net_ipv4_address()

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32708
Signed-off-by: Christian Brauner 


  Commit: 6dcd23e2bd3642af93cc333d09dc7d8a59c75681
  https://github.com/lxc/lxc/commit/6dcd23e2bd3642af93cc333d09dc7d8a59c75681
  Author: Stéphane Graber 
  Date:   2021-03-31 (Wed, 31 Mar 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/macro.h

  Log Message:
  ---
  Merge pull request #3758 from brauner/2021-03-31/fixes

confile: cap to last bit in set_config_net_ipv4_address()


Compare: https://github.com/lxc/lxc/compare/ea35e2ccda17...6dcd23e2bd36
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 593f13: oss-fuzz.sh: put the "lxc.net" keys in the seed co...

2021-03-30 Thread Christian Brauner

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 593f13bf0ad89da75f4f052dfdecf6b08b29ac1d
  https://github.com/lxc/lxc/commit/593f13bf0ad89da75f4f052dfdecf6b08b29ac1d
  Author: Evgeny Vereshchagin 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M src/tests/oss-fuzz.sh

  Log Message:
  ---
  oss-fuzz.sh: put the "lxc.net" keys in the seed corpus as well

It's just a follow-up to 0abcc213e2291d71 (where the "lxc.net" keys
were moved from config_jump_table to config_jump_table_net)

Signed-off-by: Evgeny Vereshchagin 


  Commit: ea35e2ccda17d53e283575193a13c3b3172fadef
  https://github.com/lxc/lxc/commit/ea35e2ccda17d53e283575193a13c3b3172fadef
  Author: Christian Brauner 
  Date:   2021-03-30 (Tue, 30 Mar 2021)

  Changed paths:
M src/tests/oss-fuzz.sh

  Log Message:
  ---
  Merge pull request #3755 from evverx/lxc-net

oss-fuzz.sh: put the "lxc.net" keys to the seed corpus as well


Compare: https://github.com/lxc/lxc/compare/21e9bead1200...ea35e2ccda17
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 28e54b: string_utils: switch to path_simplify()

2021-03-30 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 28e54be15fbb9c56edd3a0733377d7668739fc93
  https://github.com/lxc/lxc/commit/28e54be15fbb9c56edd3a0733377d7668739fc93
  Author: Christian Brauner 
  Date:   2021-03-30 (Tue, 30 Mar 2021)

  Changed paths:
M src/lxc/confile_utils.c
M src/lxc/criu.c
M src/lxc/storage/overlay.c
M src/lxc/string_utils.c
M src/lxc/string_utils.h
M src/tests/lxc-test-utils.c

  Log Message:
  ---
  string_utils: switch to path_simplify()

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32689
Signed-off-by: Christian Brauner 


  Commit: 21e9bead1200c986e32a1275d074b4ee94568329
  https://github.com/lxc/lxc/commit/21e9bead1200c986e32a1275d074b4ee94568329
  Author: Stéphane Graber 
  Date:   2021-03-30 (Tue, 30 Mar 2021)

  Changed paths:
M src/lxc/confile_utils.c
M src/lxc/criu.c
M src/lxc/storage/overlay.c
M src/lxc/string_utils.c
M src/lxc/string_utils.h
M src/tests/lxc-test-utils.c

  Log Message:
  ---
  Merge pull request #3756 from brauner/2021-03-30/fixes_3

string_utils: switch to path_simplify()


Compare: https://github.com/lxc/lxc/compare/ec6de2c3e71d...21e9bead1200
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 0abcc2: confile: don't jump into the global table twice

2021-03-30 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 0abcc213e2291d718cb93484f87add9c4b640f9d
  https://github.com/lxc/lxc/commit/0abcc213e2291d718cb93484f87add9c4b640f9d
  Author: Christian Brauner 
  Date:   2021-03-30 (Tue, 30 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: don't jump into the global table twice

instead move networking keys into a subtable. This avoids even just the
remote danger of recursion and also speeds up config parsing.

Signed-off-by: Christian Brauner 


  Commit: ec6de2c3e71d98fbaf31b1db697652ec42e0fe4a
  https://github.com/lxc/lxc/commit/ec6de2c3e71d98fbaf31b1db697652ec42e0fe4a
  Author: Stéphane Graber 
  Date:   2021-03-30 (Tue, 30 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  Merge pull request #3754 from brauner/2021-03-30/fixes_2

confile: don't jump into the global table twice


Compare: https://github.com/lxc/lxc/compare/dce56ec2284f...ec6de2c3e71d
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 5f4042: autotools: remove --enable-{asan, ubsan} in favor o...

2021-03-29 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 5f404236273bb293d81788d2d26a33a57a78
  https://github.com/lxc/lxc/commit/5f404236273bb293d81788d2d26a33a57a78
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M configure.ac
M src/lxc/Makefile.am

  Log Message:
  ---
  autotools: remove --enable-{asan,ubsan} in favor of --enable-sanitizers

Signed-off-by: Christian Brauner 


  Commit: 73c852f7d68d3d38004f9006e5d04f96b21a60bd
  https://github.com/lxc/lxc/commit/73c852f7d68d3d38004f9006e5d04f96b21a60bd
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M README.md

  Log Message:
  ---
  README: remove Travis and add Github actions badge

Signed-off-by: Christian Brauner 


  Commit: dce56ec2284fc8e7f014b3b01a4f1631c4ca18ac
  https://github.com/lxc/lxc/commit/dce56ec2284fc8e7f014b3b01a4f1631c4ca18ac
  Author: Stéphane Graber 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M README.md
M configure.ac
M src/lxc/Makefile.am

  Log Message:
  ---
  Merge pull request #3750 from brauner/2021-03-29/fixes_2

autotools: remove --enable-{asan,ubsan} in favor of --enable-sanitizers


Compare: https://github.com/lxc/lxc/compare/fb33b35c8830...dce56ec2284f
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 320061: doc: Documented that net type field must come befo...

2021-03-29 Thread Christian Brauner

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 320061b34fea7d7f280b0a421dddeac7dac7f1bf
  https://github.com/lxc/lxc/commit/320061b34fea7d7f280b0a421dddeac7dac7f1bf
  Author: Thomas Parrott 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M doc/lxc.container.conf.sgml.in

  Log Message:
  ---
  doc: Documented that net type field must come before other options on the net 
device

Signed-off-by: Thomas Parrott 


  Commit: fb33b35c8830c99aefebccb62361e84b94dc8f73
  https://github.com/lxc/lxc/commit/fb33b35c8830c99aefebccb62361e84b94dc8f73
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M doc/lxc.container.conf.sgml.in

  Log Message:
  ---
  Merge pull request #3751 from tomponline/tp-nic-ordering

doc: Documented that net type field must come before other options on the net 
device


Compare: https://github.com/lxc/lxc/compare/d96134fa74e1...fb33b35c8830
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 96160d: conf: fix a memory leak

2021-03-29 Thread Christian Brauner

  Branch: refs/heads/stable-4.0
  Home:   https://github.com/lxc/lxc
  Commit: 96160d10745b695ce2325f231917453db6f90840
  https://github.com/lxc/lxc/commit/96160d10745b695ce2325f231917453db6f90840
  Author: Evgeny Vereshchagin 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: fix a memory leak

It was triggered by passing "lxc.selinux.context.keyring=xroot" to the
fuzz target introduced in https://github.com/google/oss-fuzz/pull/5498
```
=
==22==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 6 byte(s) in 1 object(s) allocated from:
#0 0x538ca4 in __strdup 
/src/llvm-project/compiler-rt/lib/asan/asan_interceptors.cpp:468:3
#1 0x5c40e8 in set_config_string_item 
/src/lxc/src/lxc/confile_utils.c:635:14
#2 0x44394e in set_config_selinux_context_keyring 
/src/lxc/src/lxc/confile.c:1596:9
#3 0x5af955 in parse_line /src/lxc/src/lxc/confile.c:2953:9
#4 0x4475cd in lxc_file_for_each_line_mmap /src/lxc/src/lxc/parse.c:125:9
#5 0x5af24f in lxc_config_read /src/lxc/src/lxc/confile.c:3024:9
#6 0x580b04 in LLVMFuzzerTestOneInput /src/fuzz-lxc-config-read.c:36:2
#7 0x483643 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, 
unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:599:15
#8 0x46d4a2 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned 
long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:323:6
#9 0x4732ea in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char 
const*, unsigned long)) 
/src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:856:9
#10 0x49f022 in main 
/src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
#11 0x7f16d09b883f in __libc_start_main 
(/lib/x86_64-linux-gnu/libc.so.6+0x2083f)
```

This is a follow-up to https://github.com/lxc/lxc/commit/4fef78bc332a2d186dca6f

Signed-off-by: Evgeny Vereshchagin 


  Commit: 54b0023f26483ac01de384e0e3487e1daf35949f
  https://github.com/lxc/lxc/commit/54b0023f26483ac01de384e0e3487e1daf35949f
  Author: Evgeny Vereshchagin 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
A .github/workflows/cifuzz.yml

  Log Message:
  ---
  ci: turn on CIFuzz

Now that lxc has been integrated into OSS-Fuzz it should be
possible to start using 
https://google.github.io/oss-fuzz/getting-started/continuous-integration/
(mostly to make sure that the project is buildable there).

It should help to keep the integration in more or less good shape.

Signed-off-by: Evgeny Vereshchagin 


  Commit: 0b382e933d0efaace297054be2841872d71aeba8
  https://github.com/lxc/lxc/commit/0b382e933d0efaace297054be2841872d71aeba8
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: fix set_config_sysctl()

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32487
Signed-off-by: Christian Brauner 


  Commit: ab0df3689b6373d73c409d1272b5b37d893f0686
  https://github.com/lxc/lxc/commit/ab0df3689b6373d73c409d1272b5b37d893f0686
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: reinitialize sysctl list after clearing it

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32474
Signed-off-by: Christian Brauner 


  Commit: 4e16a3acf995f093bf4b9f7b1dac4295f635e5ef
  https://github.com/lxc/lxc/commit/4e16a3acf995f093bf4b9f7b1dac4295f635e5ef
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  confile_utils: delete netdev from list

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32478
Signed-off-by: Christian Brauner 


  Commit: dee51406f2d7f8b07014ca4b0ce41998e0c25023
  https://github.com/lxc/lxc/commit/dee51406f2d7f8b07014ca4b0ce41998e0c25023
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M src/lxc/list.h

  Log Message:
  ---
  list: add lxc_list_new() helper

Signed-off-by: Christian Brauner 


  Commit: abd9627adc851f8bdade2752270f233fceba2bb3
  https://github.com/lxc/lxc/commit/abd9627adc851f8bdade2752270f233fceba2bb3
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: use lxc_list_new() everywhere

Signed-off-by: Christian Brauner 


  Commit: 503e11fdc965473ea833896de1cccf9452c8fa21
  https://github.com/lxc/lxc/commit/503e11fdc965473ea833896de1cccf9452c8fa21
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: use lxc_list_new() everywhere

Signed-off-by: Christian Brauner 


  Commit: 6fc91bb1c7b97234e0948c3aae35036c640248c5

[lxc-devel] [lxc/lxc] 448439: compiler: fix thread_local detection

2021-03-29 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 448439729d091f428101288fb04d7e90d2e61ef8
  https://github.com/lxc/lxc/commit/448439729d091f428101288fb04d7e90d2e61ef8
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M configure.ac
M src/lxc/compiler.h
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/initutils.c

  Log Message:
  ---
  compiler: fix thread_local detection

Signed-off-by: Christian Brauner 


  Commit: d96134fa74e1de7f8272c305cad51922b68ae1ec
  https://github.com/lxc/lxc/commit/d96134fa74e1de7f8272c305cad51922b68ae1ec
  Author: Stéphane Graber 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M configure.ac
M src/lxc/compiler.h
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/initutils.c

  Log Message:
  ---
  Merge pull request #3749 from brauner/2021-03-29/fixes

compiler: fix thread_local detection


Compare: https://github.com/lxc/lxc/compare/86624ee4a5b2...d96134fa74e1
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] cf0f7a: cifuzz: turn on MSan

2021-03-29 Thread Christian Brauner

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: cf0f7aba41f5a7475ca5755f1a3f6f7ceca41336
  https://github.com/lxc/lxc/commit/cf0f7aba41f5a7475ca5755f1a3f6f7ceca41336
  Author: Evgeny Vereshchagin 
  Date:   2021-03-28 (Sun, 28 Mar 2021)

  Changed paths:
M .github/workflows/cifuzz.yml

  Log Message:
  ---
  cifuzz: turn on MSan

Signed-off-by: Evgeny Vereshchagin 


  Commit: f6727edbf7af86f4373f0c750c836e3a8f1d23d9
  https://github.com/lxc/lxc/commit/f6727edbf7af86f4373f0c750c836e3a8f1d23d9
  Author: Evgeny Vereshchagin 
  Date:   2021-03-28 (Sun, 28 Mar 2021)

  Changed paths:
M src/lxc/string_utils.c

  Log Message:
  ---
  string_utils: work around an MSan false positive

MSan doesn't instrument stpncpy 
(https://github.com/google/sanitizers/issues/926),
which causes the fuzzer to fail with:
```
$ cat ../minimized-from-740f56329efc60eab59b8194132b712a873e88a3
lxc.console.size=123

$ ./out/fuzz-lxc-config-read 
../minimized-from-740f56329efc60eab59b8194132b712a873e88a3
INFO: Seed: 3561494591
INFO: Loaded 1 modules   (18795 inline 8-bit counters): 18795 [0x866b98, 
0x86b503),
INFO: Loaded 1 PC tables (18795 PCs): 18795 [0x86b508,0x8b4bb8),
./out/fuzz-lxc-config-read: Running 1 inputs 1 time(s) each.
Running: ../minimized-from-740f56329efc60eab59b8194132b712a873e88a3
==850885==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x6b3e7f in parse_byte_size_string 
/home/vagrant/lxc/src/lxc/string_utils.c:912:6
#1 0x550991 in set_config_console_size 
/home/vagrant/lxc/src/lxc/confile.c:2483:8
#2 0x5346e2 in parse_line /home/vagrant/lxc/src/lxc/confile.c:2962:9
#3 0x64b3cd in lxc_file_for_each_line_mmap 
/home/vagrant/lxc/src/lxc/parse.c:125:9
#4 0x53340c in lxc_config_read /home/vagrant/lxc/src/lxc/confile.c:3039:9
#5 0x4e7ec2 in LLVMFuzzerTestOneInput 
/home/vagrant/lxc/src/tests/fuzz-lxc-config-read.c:23:2
#6 0x44ad2c in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, 
unsigned long) (/home/vagrant/lxc/out/fuzz-lxc-config-read+0x44ad2c)
#7 0x42ca4d in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned 
long) (/home/vagrant/lxc/out/fuzz-lxc-config-read+0x42ca4d)
#8 0x433af0 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char 
const*, unsigned long)) (/home/vagrant/lxc/out/fuzz-lxc-config-read+0x433af0)
#9 0x423ff6 in main (/home/vagrant/lxc/out/fuzz-lxc-config-read+0x423ff6)
#10 0x7f79bdc89081 in __libc_start_main (/lib64/libc.so.6+0x27081)
#11 0x42402d in _start (/home/vagrant/lxc/out/fuzz-lxc-config-read+0x42402d)

  Uninitialized value was created by an allocation of 'dup' in the stack frame 
of function 'parse_byte_size_string'
#0 0x6b3330 in parse_byte_size_string 
/home/vagrant/lxc/src/lxc/string_utils.c:901

SUMMARY: MemorySanitizer: use-of-uninitialized-value 
/home/vagrant/lxc/src/lxc/string_utils.c:912:6 in parse_byte_size_string
Exiting
```

Closes https://oss-fuzz.com/testcase-detail/5829890470445056

Signed-off-by: Evgeny Vereshchagin 


  Commit: 86624ee4a5b2c497c3346802c302bf5c9ec5140a
  https://github.com/lxc/lxc/commit/86624ee4a5b2c497c3346802c302bf5c9ec5140a
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M .github/workflows/cifuzz.yml
M src/lxc/string_utils.c

  Log Message:
  ---
  Merge pull request #3746 from evverx/CIFuzz-unblock-msan

CIFuzz: turn on MSan


Compare: https://github.com/lxc/lxc/compare/be43adcda979...86624ee4a5b2
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] e0f420: confile: safely clean previous value in set_config...

2021-03-29 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: e0f420d5ae0f11f5cb538c93ff4aa956202958e0
  https://github.com/lxc/lxc/commit/e0f420d5ae0f11f5cb538c93ff4aa956202958e0
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: safely clean previous value in set_config_net_ipv6_gateway()

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32610
Signed-off-by: Christian Brauner 


  Commit: d21e9500594c504934fc217a6688e2748bd105dc
  https://github.com/lxc/lxc/commit/d21e9500594c504934fc217a6688e2748bd105dc
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: safely clean previous value in set_config_net_ipv4_gateway()

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32586
Signed-off-by: Christian Brauner 


  Commit: 12babd78e37d58850cf99f6b4e3faf104e0da2cd
  https://github.com/lxc/lxc/commit/12babd78e37d58850cf99f6b4e3faf104e0da2cd
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/confile.h

  Log Message:
  ---
  confile: vet keys more aggressively

Enforce an exact match for all keys where we now the subkeys must match
exactly.

Signed-off-by: Christian Brauner 


  Commit: 8d508eaa9b7df4a9df908649735e4d6b3cb75994
  https://github.com/lxc/lxc/commit/8d508eaa9b7df4a9df908649735e4d6b3cb75994
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/confile_utils.c
M src/lxc/confile_utils.h

  Log Message:
  ---
  confile: clear netdev on network type change

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32584
Signed-off-by: Christian Brauner 


  Commit: a8b7aefc156d5e57d5b7b6faa0d7e7e231dba96b
  https://github.com/lxc/lxc/commit/a8b7aefc156d5e57d5b7b6faa0d7e7e231dba96b
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: cleanup set_config_net_hwaddr()

Signed-off-by: Christian Brauner 


  Commit: 6d0297b9ae653c4f99a4a41988460d96f03053b1
  https://github.com/lxc/lxc/commit/6d0297b9ae653c4f99a4a41988460d96f03053b1
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: cleanup set_config_net_mtu()

Signed-off-by: Christian Brauner 


  Commit: 040b3e1d24c646d0a90d7f8c1f42368bec93b9ba
  https://github.com/lxc/lxc/commit/040b3e1d24c646d0a90d7f8c1f42368bec93b9ba
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: cleanup set_config_net_script_up()

Signed-off-by: Christian Brauner 


  Commit: f0383b96e0226e2c6f66b46eb102d41ccdfc0657
  https://github.com/lxc/lxc/commit/f0383b96e0226e2c6f66b46eb102d41ccdfc0657
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: cleanup set_config_net_script_down()

Signed-off-by: Christian Brauner 


  Commit: cea88c47ac71c320b7a113840092b6cdbc6fe198
  https://github.com/lxc/lxc/commit/cea88c47ac71c320b7a113840092b6cdbc6fe198
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M src/tests/parse_config_file.c

  Log Message:
  ---
  tests: fix two false negatives in parse_config_file()

Signed-off-by: Christian Brauner 


  Commit: 2d676c005c1a53086af423ea35631b46d1854f41
  https://github.com/lxc/lxc/commit/2d676c005c1a53086af423ea35631b46d1854f41
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M src/tests/parse_config_file.c

  Log Message:
  ---
  tests: add another test for garbage config key

where a valid key has trailing garbage at the end before the "=".

Signed-off-by: Christian Brauner 


  Commit: 52ce85046b4cbb4af431c99f260a8f9aabc57054
  https://github.com/lxc/lxc/commit/52ce85046b4cbb4af431c99f260a8f9aabc57054
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M configure.ac
M src/lxc/compiler.h
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/initutils.c

  Log Message:
  ---
  conf: fix thread_local support detection

Our detection for TLS wasn't working. Fix it.

Fixes: https://github.com/lxc/lxd/issues/8327
Signed-off-by: Christian Brauner 


  Commit: ea60ca9565243a34335477ea213ebba897db18b7
  https://github.com/lxc/lxc/commit/ea60ca9565243a34335477ea213ebba897db18b7
  Author: Christian Brauner 
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
M src/lxc/lxccontainer.c

  Log Message:
  ---
  lxccontainer: ensure second parameter to bsearch is

[lxc-devel] [lxc/lxc] 745d60: oss-fuzz.sh: take SANITIZER into account

2021-03-28 Thread Christian Brauner

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 745d60487b41cb0c677c699c3b98f021277ae2a5
  https://github.com/lxc/lxc/commit/745d60487b41cb0c677c699c3b98f021277ae2a5
  Author: Evgeny Vereshchagin 
  Date:   2021-03-28 (Sun, 28 Mar 2021)

  Changed paths:
M src/tests/oss-fuzz.sh

  Log Message:
  ---
  oss-fuzz.sh: take SANITIZER into account

to make it possible to build the fuzzer with UBSan and MSan locally

```
$ SANITIZER=undefined ./src/tests/oss-fuzz.sh
$ printf 'lxc.signal.stop=sigrtmax-0220' >oss-fuzz-32596
$ UBSAN_OPTIONS=print_stacktrace=1:print_summary=1:halt_on_error=1 
./out/fuzz-lxc-config-read oss-fuzz-32596
INFO: Seed: 595864277
INFO: Loaded 1 modules   (61553 inline 8-bit counters): 61553 [0x80a1b0, 
0x819221),
INFO: Loaded 1 PC tables (61553 PCs): 61553 [0x819228,0x909938),
./out/fuzz-lxc-config-read: Running 1 inputs 1 time(s) each.
Running: oss-fuzz-32596
confile_utils.c:1051:20: runtime error: signed integer overflow: 64 - 
-2147483632 cannot be represented in type 'int'
#0 0x51799a in rt_sig_num /home/vagrant/lxc/src/lxc/confile_utils.c:1051:20
#1 0x517268 in sig_parse /home/vagrant/lxc/src/lxc/confile_utils.c:1069:11
#2 0x500ca4 in set_config_signal_stop 
/home/vagrant/lxc/src/lxc/confile.c:1738:10
#3 0x4b8c7c in parse_line /home/vagrant/lxc/src/lxc/confile.c:2962:9
#4 0x5a5eb0 in lxc_file_for_each_line_mmap 
/home/vagrant/lxc/src/lxc/parse.c:125:9

```

Signed-off-by: Evgeny Vereshchagin 


  Commit: a6fa6772e11c9d65df366181314e69e7ec1c32aa
  https://github.com/lxc/lxc/commit/a6fa6772e11c9d65df366181314e69e7ec1c32aa
  Author: Evgeny Vereshchagin 
  Date:   2021-03-28 (Sun, 28 Mar 2021)

  Changed paths:
M .github/workflows/cifuzz.yml

  Log Message:
  ---
  cifuzz: turn on UBsan

Signed-off-by: Evgeny Vereshchagin 


  Commit: cc19bc54067493812f13f0bf102b068c0014dbcb
  https://github.com/lxc/lxc/commit/cc19bc54067493812f13f0bf102b068c0014dbcb
  Author: Christian Brauner 
  Date:   2021-03-28 (Sun, 28 Mar 2021)

  Changed paths:
M .github/workflows/cifuzz.yml
M src/tests/oss-fuzz.sh

  Log Message:
  ---
  Merge pull request #3745 from evverx/ubsan-msan-support

oss-fuzz/cifuzz: a couple of follow-up commits


Compare: https://github.com/lxc/lxc/compare/94d05c50c9f3...cc19bc540674
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] e6b35f: confile_utils: fix a signed integer overflow

2021-03-28 Thread Christian Brauner

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: e6b35fbfb603fa5c9d047411e3d1678acdd2eb56
  https://github.com/lxc/lxc/commit/e6b35fbfb603fa5c9d047411e3d1678acdd2eb56
  Author: Evgeny Vereshchagin 
  Date:   2021-03-28 (Sun, 28 Mar 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  confile_utils: fix a signed integer overflow

This was triggered by the following chain of conversions:

lxc_safe_uint("0220") -> 2147483664 (uint)
sig_num(2147483664 (uint)) -> -2147483632 (int)

64 - -2147483632 cannot be represented in type 'int'

Closes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32596

Signed-off-by: Evgeny Vereshchagin 


  Commit: 94d05c50c9f3cfe3ca310ab263d4aad52a3e4cbc
  https://github.com/lxc/lxc/commit/94d05c50c9f3cfe3ca310ab263d4aad52a3e4cbc
  Author: Christian Brauner 
  Date:   2021-03-28 (Sun, 28 Mar 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  Merge pull request #3744 from evverx/oss-fuzz-32596

confile_utils: fix a signed integer overflow


Compare: https://github.com/lxc/lxc/compare/db62570f0f89...94d05c50c9f3
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 79d2f5: confile: add missing prefix validation

2021-03-28 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 79d2f54fd5f26c69c6e0c3e5e813c9752ae0cc4c
  https://github.com/lxc/lxc/commit/79d2f54fd5f26c69c6e0c3e5e813c9752ae0cc4c
  Author: Christian Brauner 
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: add missing prefix validation

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32488
Signed-off-by: Christian Brauner 


  Commit: 405b28a4de42c15a060ecb95b63fcee08b98885b
  https://github.com/lxc/lxc/commit/405b28a4de42c15a060ecb95b63fcee08b98885b
  Author: Christian Brauner 
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: don't leak memory in case multiple shmounts are set

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32503
Signed-off-by: Christian Brauner 


  Commit: 4c5479d21e4d8d0bd1ca6abc04f6800a92fd34e5
  https://github.com/lxc/lxc/commit/4c5479d21e4d8d0bd1ca6abc04f6800a92fd34e5
  Author: Christian Brauner 
  Date:   2021-03-28 (Sun, 28 Mar 2021)

  Changed paths:
M src/lxc/compiler.h
M src/lxc/confile.c
M src/lxc/string_utils.c
M src/lxc/string_utils.h
M src/tests/lxc-test-utils.c

  Log Message:
  ---
  string_utils: handle overflow correct in parse_byte_size_string()

This takes the overflow handling code from the kernel.

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32549
Signed-off-by: Christian Brauner 


  Commit: db62570f0f89cb33e6ea3f37f19ba8c028dafe2d
  https://github.com/lxc/lxc/commit/db62570f0f89cb33e6ea3f37f19ba8c028dafe2d
  Author: Stéphane Graber 
  Date:   2021-03-28 (Sun, 28 Mar 2021)

  Changed paths:
M src/lxc/compiler.h
M src/lxc/confile.c
M src/lxc/string_utils.c
M src/lxc/string_utils.h
M src/tests/lxc-test-utils.c

  Log Message:
  ---
  Merge pull request #3743 from brauner/2021-03-27/fixes_3

oss-fuzz: fixes


Compare: https://github.com/lxc/lxc/compare/d734e61169f5...db62570f0f89
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 9a096e: confile_utils: free list during lxc_remove_nic_by_...

2021-03-27 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 9a096e987e8a38735d305dcf02582a25a983d3d0
  https://github.com/lxc/lxc/commit/9a096e987e8a38735d305dcf02582a25a983d3d0
  Author: Christian Brauner 
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  confile_utils: free list during lxc_remove_nic_by_idx()

Reported-by: Evgeny Vereshchagin 
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32484
Signed-off-by: Christian Brauner 


  Commit: d734e61169f5d69a833a8b3ba37b921cbe33d606
  https://github.com/lxc/lxc/commit/d734e61169f5d69a833a8b3ba37b921cbe33d606
  Author: Stéphane Graber 
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  Merge pull request #3741 from brauner/2021-03-27/fixes_2

confile_utils: free list during lxc_remove_nic_by_idx()


Compare: https://github.com/lxc/lxc/compare/cc98c4702132...d734e61169f5
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] c45833: string_utils: always memset buf in lxc_safe_int64_...

2021-03-27 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: c45833e39c85c5e16270aa4122b1929dd086127a
  https://github.com/lxc/lxc/commit/c45833e39c85c5e16270aa4122b1929dd086127a
  Author: Christian Brauner 
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
M src/lxc/string_utils.c

  Log Message:
  ---
  string_utils: always memset buf in lxc_safe_int64_residual()

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32482
Signed-off-by: Christian Brauner 


  Commit: cc36133d43b65a2e7b0e1e6fa086d5ff20854392
  https://github.com/lxc/lxc/commit/cc36133d43b65a2e7b0e1e6fa086d5ff20854392
  Author: Christian Brauner 
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: reinitialize lists

Signed-off-by: Christian Brauner 


  Commit: 25ed0305b1e511ef79cbbc725628476099d18afd
  https://github.com/lxc/lxc/commit/25ed0305b1e511ef79cbbc725628476099d18afd
  Author: Christian Brauner 
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  confile_utils: free network list items

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32484
Signed-off-by: Christian Brauner 


  Commit: ced5587c03620e61ff402d24dc45898b9c0eed30
  https://github.com/lxc/lxc/commit/ced5587c03620e61ff402d24dc45898b9c0eed30
  Author: Christian Brauner 
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: coding style cleanups

Signed-off-by: Christian Brauner 


  Commit: 6a52a513f9015926ccc023863e17fa7a2bad7a8d
  https://github.com/lxc/lxc/commit/6a52a513f9015926ccc023863e17fa7a2bad7a8d
  Author: Christian Brauner 
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: make string calculations in get_network_config_ops() more obvious

Signed-off-by: Christian Brauner 


  Commit: bbc9892535bb5fb8e2571372a9d82513c22732ab
  https://github.com/lxc/lxc/commit/bbc9892535bb5fb8e2571372a9d82513c22732ab
  Author: Christian Brauner 
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: use correct check for too large network lists

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32558
Signed-off-by: Christian Brauner 


  Commit: 299ddd1663b86eabb0080b0cca044d2b7850e3c8
  https://github.com/lxc/lxc/commit/299ddd1663b86eabb0080b0cca044d2b7850e3c8
  Author: Christian Brauner 
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: improve network vetting

Move all input sanity checks up and add two missing checks for the
correct network type when using veth-vlan and vlan network types.

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32513
Signed-off-by: Christian Brauner 


  Commit: f6848c5fbc29ebbe3363dc93b8575a7f024399c9
  https://github.com/lxc/lxc/commit/f6848c5fbc29ebbe3363dc93b8575a7f024399c9
  Author: Evgeny Vereshchagin 
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: fix a memory leak in set_config_net_hwaddr

It was found by ClusterFuzz in 
https://oss-fuzz.com/testcase-detail/4747480244813824
but hasn't been reported on Monorail
(https://bugs.chromium.org/p/oss-fuzz/) yet

```
$ cat minimized-from-1a18983c13ce64e8a3bd0f699a97d25beb21481e
lxc.net.0.hwaddr=0
lxc.net.0.hwaddr=4

./out/fuzz-lxc-config-read 
minimized-from-1a18983c13ce64e8a3bd0f699a97d25beb21481e
INFO: Seed: 1473396311
INFO: Loaded 1 modules   (18821 inline 8-bit counters): 18821 [0x885fa0, 
0x88a925),
INFO: Loaded 1 PC tables (18821 PCs): 18821 [0x88a928,0x8d4178),
./out/fuzz-lxc-config-read: Running 1 inputs 1 time(s) each.
Running: minimized-from-1a18983c13ce64e8a3bd0f699a97d25beb21481e

=
==226185==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 2 byte(s) in 1 object(s) allocated from:
#0 0x4d25d7 in strdup (/home/vagrant/lxc/out/fuzz-lxc-config-read+0x4d25d7)
#1 0x58e48f in set_config_net_hwaddr 
/home/vagrant/lxc/src/lxc/confile.c:654:14
#2 0x59af3b in set_config_net_nic /home/vagrant/lxc/src/lxc/confile.c:5276:9
#3 0x571c29 in parse_line /home/vagrant/lxc/src/lxc/confile.c:2958:9
#4 0x61b0b2 in lxc_file_for_each_line_mmap 
/home/vagrant/lxc/src/lxc/parse.c:125:9
#5 0x5710ed in lxc_config_read /home/vagrant/lxc/src/lxc/confile.c:3035:9
#6 0x542cd6 in LLVMFuzzerTestOneInput 
/home/vagrant/lxc/src/tests/fuzz-lxc-config-read.c:23:2
#7 0x449e8c in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, 
unsigned long) (/home/vagrant/lxc/out/fuzz-lxc-config-read+0x449e8c)
#8 0x42bbad in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned 
long) (/home/vagrant/lxc/out/fuzz-lxc-config-read+0x42bbad)

[lxc-devel] [lxc/lxc] 0b73eb: confile_utils: improve network parser

2021-03-26 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 0b73eb0590e9c140a8d4595572ca9f85f2faddf8
  https://github.com/lxc/lxc/commit/0b73eb0590e9c140a8d4595572ca9f85f2faddf8
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/confile_utils.c

  Log Message:
  ---
  confile_utils: improve network parser

Signed-off-by: Christian Brauner 


  Commit: b2480b29508bd4068e985e1cb9fbb63a67d2531d
  https://github.com/lxc/lxc/commit/b2480b29508bd4068e985e1cb9fbb63a67d2531d
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/string_utils.c

  Log Message:
  ---
  string_utils: fix parse_byte_size_string()

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32475
Signed-off-by: Christian Brauner 


  Commit: 06fdc710a8c9962563e6cf9fc264427fd77097b6
  https://github.com/lxc/lxc/commit/06fdc710a8c9962563e6cf9fc264427fd77097b6
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/log.c

  Log Message:
  ---
  log: avoid regressions for relative log paths

We need to allow relative log paths.

Signed-off-by: Christian Brauner 


  Commit: 8c70a4080b9625f476bf2b538d4aefbfbb96c03d
  https://github.com/lxc/lxc/commit/8c70a4080b9625f476bf2b538d4aefbfbb96c03d
  Author: Stéphane Graber 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/confile_utils.c
M src/lxc/log.c
M src/lxc/string_utils.c

  Log Message:
  ---
  Merge pull request #3736 from brauner/2021-03-26/fixes_3

oss-fuzz: fixes


Compare: https://github.com/lxc/lxc/compare/6583a6509089...8c70a4080b96
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] bb301d: network: handle name collisions when returning phy...

2021-03-26 Thread Christian Brauner

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: bb301db761fb719c743a314bd5ff466f29af590c
  https://github.com/lxc/lxc/commit/bb301db761fb719c743a314bd5ff466f29af590c
  Author: Sam Boyles 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/network.c
M src/lxc/network.h

  Log Message:
  ---
  network: handle name collisions when returning physical interfaces to host

Reviewed-by: Blair Steven 
Signed-off-by: Sam Boyles 


  Commit: 647d0e011add887090568cbdf855aead917d7f44
  https://github.com/lxc/lxc/commit/647d0e011add887090568cbdf855aead917d7f44
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/network.c
M src/lxc/network.h

  Log Message:
  ---
  Merge pull request #3731 from samboyles1/master

network: handle name collisions when returning interfaces to host


Compare: https://github.com/lxc/lxc/compare/627c766cba40...647d0e011add
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] c04f42: confile: don't leak memory when overwriting lxc.ro...

2021-03-26 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: c04f422182501585e2e92a238dc416ce21ff077d
  https://github.com/lxc/lxc/commit/c04f422182501585e2e92a238dc416ce21ff077d
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: don't leak memory when overwriting lxc.rootfs.options

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32473
Signed-off-by: Christian Brauner 


  Commit: b8e539f44814cd1760c7dc21c027d7e6c51b72fd
  https://github.com/lxc/lxc/commit/b8e539f44814cd1760c7dc21c027d7e6c51b72fd
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  confile_utils: fix real-time signal parsing

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32521
Signed-off-by: Christian Brauner 


  Commit: 786467cbdd2e170839a2f58da8f1b634388361b7
  https://github.com/lxc/lxc/commit/786467cbdd2e170839a2f58da8f1b634388361b7
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: prevent UAF in lxc_clear_limits()

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32532
Signed-off-by: Christian Brauner 


  Commit: 627c766cba4073be3280defbcc3b7ac90d19518f
  https://github.com/lxc/lxc/commit/627c766cba4073be3280defbcc3b7ac90d19518f
  Author: Stéphane Graber 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/confile.c
M src/lxc/confile_utils.c

  Log Message:
  ---
  Merge pull request #3735 from brauner/2021-03-26/fixes_2

oss-fuzz: fixes


Compare: https://github.com/lxc/lxc/compare/e50319aaaf6d...627c766cba40
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] dec648: oss-fuzz: make it possible to build the fuzzer wit...

2021-03-26 Thread Christian Brauner

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: dec64820a3859b1943c521682aacc2f77751b39d
  https://github.com/lxc/lxc/commit/dec64820a3859b1943c521682aacc2f77751b39d
  Author: Evgeny Vereshchagin 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
A src/tests/fuzz-lxc-config-read.c
A src/tests/oss-fuzz.sh

  Log Message:
  ---
  oss-fuzz: make it possible to build the fuzzer without docker

With this patch applied the fuzz target can be built (with ASan)
and run with
```
./src/tests/oss-fuzz.sh
./out/fuzz-lxc-config-read doc/examples/
```

https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32475 can be
reproduced by running
```
$ echo "lxc.console.buffer.size=d" >oss-fuzz-32475
$ ./out/fuzz-lxc-config-read ./oss-fuzz-32475
INFO: Seed: 1044753468
INFO: Loaded 1 modules   (18770 inline 8-bit counters): 18770 [0x883cc0, 
0x888612),
INFO: Loaded 1 PC tables (18770 PCs): 18770 [0x888618,0x8d1b38),
./out/fuzz-lxc-config-read: Running 1 inputs 1 time(s) each.
Running: oss-fuzz-32475
=
==2052097==ERROR: AddressSanitizer: stack-buffer-overflow on address 
0x7ffcca063e7f at pc 0x00659e0d bp 0x7ffcca063e30 sp 0x7ffcca063e28
READ of size 1 at 0x7ffcca063e7f thread T0
...
```

I'll point OSS-Fuzz to the build script once this patch is merged.

Signed-off-by: Evgeny Vereshchagin 


  Commit: e50319aaaf6df3c349a90893a2682d14f35cf6cf
  https://github.com/lxc/lxc/commit/e50319aaaf6df3c349a90893a2682d14f35cf6cf
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
A src/tests/fuzz-lxc-config-read.c
A src/tests/oss-fuzz.sh

  Log Message:
  ---
  Merge pull request #3733 from evverx/move-from-oss-fuzz

oss-fuzz: make it possible to build the fuzzer without docker


Compare: https://github.com/lxc/lxc/compare/6a3b579505dc...e50319aaaf6d
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] d60ba5: confile: be stricter in config helpers

2021-03-26 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: d60ba56821985618bfe90a84b6c6c80ba1019402
  https://github.com/lxc/lxc/commit/d60ba56821985618bfe90a84b6c6c80ba1019402
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: be stricter in config helpers

We never call these helper without an initialized config afaict but
since we're now exposing these two functions to oss-fuzz directly in a
way we never do to users so let's be stricter about it.

Inspired-by: #3733
Signed-off-by: Christian Brauner 


  Commit: 6a3b579505dc70d6495ac9909d5cf69a0758ab61
  https://github.com/lxc/lxc/commit/6a3b579505dc70d6495ac9909d5cf69a0758ab61
  Author: Stéphane Graber 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  Merge pull request #3734 from brauner/2021-03-26/fixes_2

confile: be stricter in config helpers


Compare: https://github.com/lxc/lxc/compare/0912bf6b77c5...6a3b579505dc
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] a30a4e: log: dont create log file for fuzz builds

2021-03-26 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: a30a4efae5207ec3aa9aab872db8b0bb805d391e
  https://github.com/lxc/lxc/commit/a30a4efae5207ec3aa9aab872db8b0bb805d391e
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/log.c

  Log Message:
  ---
  log: dont create log file for fuzz builds

Fixes: #3730
Fixes: https://github.com/google/oss-fuzz/issues/5509
Signed-off-by: Christian Brauner 


  Commit: e459cf683160a2ab9b253d03e64e6de22576978b
  https://github.com/lxc/lxc/commit/e459cf683160a2ab9b253d03e64e6de22576978b
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/log.c

  Log Message:
  ---
  log: don't create directories for fuzz builds

Fixes: #3730
Fixes: https://github.com/google/oss-fuzz/issues/5509
Suggested-by: Evgeny Vereshchagin 
Signed-off-by: Christian Brauner 


  Commit: 2f6d309983feeb6942ca170961cf0663cbacbbd2
  https://github.com/lxc/lxc/commit/2f6d309983feeb6942ca170961cf0663cbacbbd2
  Author: Christian Brauner 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/log.c
M src/tests/parse_config_file.c

  Log Message:
  ---
  log: handle empty log name

Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32491
Signed-off-by: Christian Brauner 


  Commit: 0912bf6b77c5dd8c62c454e84d7c4c1dc861cdbc
  https://github.com/lxc/lxc/commit/0912bf6b77c5dd8c62c454e84d7c4c1dc861cdbc
  Author: Stéphane Graber 
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/log.c
M src/tests/parse_config_file.c

  Log Message:
  ---
  Merge pull request #3732 from brauner/2021-03-26/fixes

log: dont create log file for fuzz builds


Compare: https://github.com/lxc/lxc/compare/27df2528171f...0912bf6b77c5
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] b5fdc1: confile: fix set_config_sysctl()

2021-03-25 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: b5fdc164e310c8c4d6d92200bd4433e8fac61c69
  https://github.com/lxc/lxc/commit/b5fdc164e310c8c4d6d92200bd4433e8fac61c69
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: fix set_config_sysctl()

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32487
Signed-off-by: Christian Brauner 


  Commit: 4a2c9b40233fd1725701feb7d9fa8326a7aeedf0
  https://github.com/lxc/lxc/commit/4a2c9b40233fd1725701feb7d9fa8326a7aeedf0
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: reinitialize sysctl list after clearing it

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32474
Signed-off-by: Christian Brauner 


  Commit: c461b9c7edbdd0d632425715a757a68d9e9df856
  https://github.com/lxc/lxc/commit/c461b9c7edbdd0d632425715a757a68d9e9df856
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  confile_utils: delete netdev from list

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32478
Signed-off-by: Christian Brauner 


  Commit: 89d34eb2eda5c2e6bf9ffa8382bba41d0257828e
  https://github.com/lxc/lxc/commit/89d34eb2eda5c2e6bf9ffa8382bba41d0257828e
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/lxc/list.h

  Log Message:
  ---
  list: add lxc_list_new() helper

Signed-off-by: Christian Brauner 


  Commit: 642751ccd07d923c1645575d900a4cfabf8d4cb6
  https://github.com/lxc/lxc/commit/642751ccd07d923c1645575d900a4cfabf8d4cb6
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: use lxc_list_new() everywhere

Signed-off-by: Christian Brauner 


  Commit: b8e43ef0bd5959a550356871de27fa3835719e87
  https://github.com/lxc/lxc/commit/b8e43ef0bd5959a550356871de27fa3835719e87
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: use lxc_list_new() everywhere

Signed-off-by: Christian Brauner 


  Commit: 27df2528171f36d88f4761abbfcfc4bb4d31a55f
  https://github.com/lxc/lxc/commit/27df2528171f36d88f4761abbfcfc4bb4d31a55f
  Author: Stéphane Graber 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/confile.c
M src/lxc/confile_utils.c
M src/lxc/list.h

  Log Message:
  ---
  Merge pull request #3729 from brauner/2021-03-25/fixes_3

oss-fuzz: fixes


Compare: https://github.com/lxc/lxc/compare/65c5bc571b94...27df2528171f
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 4117b2: ci: turn on CIFuzz

2021-03-25 Thread Christian Brauner

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 4117b26a0e53058339c5f121ce2e14f4df6a4e74
  https://github.com/lxc/lxc/commit/4117b26a0e53058339c5f121ce2e14f4df6a4e74
  Author: Evgeny Vereshchagin 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
A .github/workflows/cifuzz.yml

  Log Message:
  ---
  ci: turn on CIFuzz

Now that lxc has been integrated into OSS-Fuzz it should be
possible to start using 
https://google.github.io/oss-fuzz/getting-started/continuous-integration/
(mostly to make sure that the project is buildable there).

It should help to keep the integration in more or less good shape.

Signed-off-by: Evgeny Vereshchagin 


  Commit: 65c5bc571b94345decd779092056c11981f6fea4
  https://github.com/lxc/lxc/commit/65c5bc571b94345decd779092056c11981f6fea4
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
A .github/workflows/cifuzz.yml

  Log Message:
  ---
  Merge pull request #3726 from evverx/cifuzz

ci: turn on CIFuzz


Compare: https://github.com/lxc/lxc/compare/854e6c5c0130...65c5bc571b94
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 1ed59e: conf: fix a memory leak

2021-03-25 Thread Christian Brauner

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 1ed59e6d8d27db32d9cb73f64e17a508fff6cba0
  https://github.com/lxc/lxc/commit/1ed59e6d8d27db32d9cb73f64e17a508fff6cba0
  Author: Evgeny Vereshchagin 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: fix a memory leak

It was triggered by passing "lxc.selinux.context.keyring=xroot" to the
fuzz target introduced in https://github.com/google/oss-fuzz/pull/5498
```
=
==22==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 6 byte(s) in 1 object(s) allocated from:
#0 0x538ca4 in __strdup 
/src/llvm-project/compiler-rt/lib/asan/asan_interceptors.cpp:468:3
#1 0x5c40e8 in set_config_string_item 
/src/lxc/src/lxc/confile_utils.c:635:14
#2 0x44394e in set_config_selinux_context_keyring 
/src/lxc/src/lxc/confile.c:1596:9
#3 0x5af955 in parse_line /src/lxc/src/lxc/confile.c:2953:9
#4 0x4475cd in lxc_file_for_each_line_mmap /src/lxc/src/lxc/parse.c:125:9
#5 0x5af24f in lxc_config_read /src/lxc/src/lxc/confile.c:3024:9
#6 0x580b04 in LLVMFuzzerTestOneInput /src/fuzz-lxc-config-read.c:36:2
#7 0x483643 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, 
unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:599:15
#8 0x46d4a2 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned 
long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:323:6
#9 0x4732ea in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char 
const*, unsigned long)) 
/src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:856:9
#10 0x49f022 in main 
/src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
#11 0x7f16d09b883f in __libc_start_main 
(/lib/x86_64-linux-gnu/libc.so.6+0x2083f)
```

This is a follow-up to https://github.com/lxc/lxc/commit/4fef78bc332a2d186dca6f

Signed-off-by: Evgeny Vereshchagin 


  Commit: 854e6c5c01308fddc8dbdb3b88e7af319d2cdc9a
  https://github.com/lxc/lxc/commit/854e6c5c01308fddc8dbdb3b88e7af319d2cdc9a
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  Merge pull request #3725 from evverx/se_keyring_context_memory_leak

conf: fix a memory leak


Compare: https://github.com/lxc/lxc/compare/3c9c460953e8...854e6c5c0130
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 700c9f: string_utils: provide a version of strchrnul() in ...

2021-03-25 Thread Christian Brauner

  Branch: refs/heads/stable-4.0
  Home:   https://github.com/lxc/lxc
  Commit: 700c9f66305ef94c64167684566558c35a06c5e7
  https://github.com/lxc/lxc/commit/700c9f66305ef94c64167684566558c35a06c5e7
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M configure.ac
A src/include/stchrnul.c
A src/include/stchrnul.h
M src/lxc/string_utils.h

  Log Message:
  ---
  string_utils: provide a version of strchrnul() in case it's not available

This should only happen on Android.

Signed-off-by: Christian Brauner 


  Commit: 3c09417b48b38107426b6944f82ec981ed536e9b
  https://github.com/lxc/lxc/commit/3c09417b48b38107426b6944f82ec981ed536e9b
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
R src/include/stchrnul.c
R src/include/stchrnul.h
A src/include/strchrnul.c
A src/include/strchrnul.h

  Log Message:
  ---
  include: fix typo

Signed-off-by: Christian Brauner 


  Commit: 682ae756287d4447e656527a6ee2af90d3e122ed
  https://github.com/lxc/lxc/commit/682ae756287d4447e656527a6ee2af90d3e122ed
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M configure.ac
M src/lxc/Makefile.am

  Log Message:
  ---
  configure: fix strchrnul conditiona compilation

Signed-off-by: Christian Brauner 


  Commit: f2f5af0d208a0b1af1d10e49d64a97e4db3f3d0a
  https://github.com/lxc/lxc/commit/f2f5af0d208a0b1af1d10e49d64a97e4db3f3d0a
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/include/strchrnul.c

  Log Message:
  ---
  strchrnul: ignore increased required alignment warning

Fixes: 
https://jenkins.linuxcontainers.org/view/LXC/job/lxc-build-android/7949/console
Signed-off-by: Christian Brauner 


  Commit: baeb6dade5baaebda6d1368980920cfc223ce565
  https://github.com/lxc/lxc/commit/baeb6dade5baaebda6d1368980920cfc223ce565
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/include/strchrnul.c

  Log Message:
  ---
  strchrnul: fix copy-paste braino

Signed-off-by: Christian Brauner 


  Commit: 85de87b568201de9700203fa567856fea218a4a2
  https://github.com/lxc/lxc/commit/85de87b568201de9700203fa567856fea218a4a2
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  confile_utils: don't free netdev twice

lxc_free_netdev() will already free the list element.

Fixes: https://github.com/google/oss-fuzz/pull/5498
Signed-off-by: Christian Brauner 


Compare: https://github.com/lxc/lxc/compare/4f9e3f46d0db...85de87b56820
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 5b1030: confile_utils: don't free netdev twice

2021-03-25 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 5b1030e26ca9b925ea4f9f79c4939958474806db
  https://github.com/lxc/lxc/commit/5b1030e26ca9b925ea4f9f79c4939958474806db
  Author: Christian Brauner 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  confile_utils: don't free netdev twice

lxc_free_netdev() will already free the list element.

Fixes: https://github.com/google/oss-fuzz/pull/5498
Signed-off-by: Christian Brauner 


  Commit: 3c9c460953e8af3b76bae1b6d1819093c92b5ccf
  https://github.com/lxc/lxc/commit/3c9c460953e8af3b76bae1b6d1819093c92b5ccf
  Author: Stéphane Graber 
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  Merge pull request #3724 from brauner/2021-03-25/fixes

confile_utils: don't free netdev twice


Compare: https://github.com/lxc/lxc/compare/38b4b216bb9d...3c9c460953e8
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 10bf1a: strchrnul: fix copy-paste braino

2021-03-23 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 10bf1adb4315d8fbc38656fbb734e27bac20f668
  https://github.com/lxc/lxc/commit/10bf1adb4315d8fbc38656fbb734e27bac20f668
  Author: Christian Brauner 
  Date:   2021-03-23 (Tue, 23 Mar 2021)

  Changed paths:
M src/include/strchrnul.c

  Log Message:
  ---
  strchrnul: fix copy-paste braino

Signed-off-by: Christian Brauner 


  Commit: 38b4b216bb9dc07b284d8a60862b3c6413a1ad57
  https://github.com/lxc/lxc/commit/38b4b216bb9dc07b284d8a60862b3c6413a1ad57
  Author: Stéphane Graber 
  Date:   2021-03-23 (Tue, 23 Mar 2021)

  Changed paths:
M src/include/strchrnul.c

  Log Message:
  ---
  Merge pull request #3720 from brauner/2021-03-23/fixes

strchrnul: fix copy-paste braino


Compare: https://github.com/lxc/lxc/compare/678d600f50c5...38b4b216bb9d
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 09c3ee: strchrnul: ignore increased required alignment war...

2021-03-22 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 09c3ee139024a1eda45c326b503a6fc33bf2737e
  https://github.com/lxc/lxc/commit/09c3ee139024a1eda45c326b503a6fc33bf2737e
  Author: Christian Brauner 
  Date:   2021-03-22 (Mon, 22 Mar 2021)

  Changed paths:
M src/include/strchrnul.c

  Log Message:
  ---
  strchrnul: ignore increased required alignment warning

Fixes: 
https://jenkins.linuxcontainers.org/view/LXC/job/lxc-build-android/7949/console
Signed-off-by: Christian Brauner 


  Commit: 678d600f50c570f78975d678d05f5e1f5996b34a
  https://github.com/lxc/lxc/commit/678d600f50c570f78975d678d05f5e1f5996b34a
  Author: Stéphane Graber 
  Date:   2021-03-22 (Mon, 22 Mar 2021)

  Changed paths:
M src/include/strchrnul.c

  Log Message:
  ---
  Merge pull request #3719 from brauner/2021-03-22/fixes

strchrnul: ignore increased required alignment warning


Compare: https://github.com/lxc/lxc/compare/1d358fe9c0c7...678d600f50c5
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 7e4ea7: configure: fix strchrnul conditiona compilation

2021-03-21 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 7e4ea7bffdf2afa7c6f8d0aa9a8c5c227ed557b4
  https://github.com/lxc/lxc/commit/7e4ea7bffdf2afa7c6f8d0aa9a8c5c227ed557b4
  Author: Christian Brauner 
  Date:   2021-03-21 (Sun, 21 Mar 2021)

  Changed paths:
M configure.ac
M src/lxc/Makefile.am

  Log Message:
  ---
  configure: fix strchrnul conditiona compilation

Signed-off-by: Christian Brauner 


  Commit: 1d358fe9c0c701bfd221f25d2a0fb502f08ff114
  https://github.com/lxc/lxc/commit/1d358fe9c0c701bfd221f25d2a0fb502f08ff114
  Author: Stéphane Graber 
  Date:   2021-03-21 (Sun, 21 Mar 2021)

  Changed paths:
M configure.ac
M src/lxc/Makefile.am

  Log Message:
  ---
  Merge pull request #3718 from brauner/2021-03-21/fixes_2

configure: fix strchrnul conditiona compilation


Compare: https://github.com/lxc/lxc/compare/3e7605b397a0...1d358fe9c0c7
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 5582dd: include: fix typo

2021-03-21 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 5582dd63c3f1ea942f14e8095eb1c923a12438ce
  https://github.com/lxc/lxc/commit/5582dd63c3f1ea942f14e8095eb1c923a12438ce
  Author: Christian Brauner 
  Date:   2021-03-21 (Sun, 21 Mar 2021)

  Changed paths:
R src/include/stchrnul.c
R src/include/stchrnul.h
A src/include/strchrnul.c
A src/include/strchrnul.h

  Log Message:
  ---
  include: fix typo

Signed-off-by: Christian Brauner 


  Commit: 3e7605b397a02533f262df6e2877c16b4065fe72
  https://github.com/lxc/lxc/commit/3e7605b397a02533f262df6e2877c16b4065fe72
  Author: Stéphane Graber 
  Date:   2021-03-21 (Sun, 21 Mar 2021)

  Changed paths:
R src/include/stchrnul.c
R src/include/stchrnul.h
A src/include/strchrnul.c
A src/include/strchrnul.h

  Log Message:
  ---
  Merge pull request #3717 from brauner/2021-03-21/fixes

include: fix typo


Compare: https://github.com/lxc/lxc/compare/f62beebe22d6...3e7605b397a0
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 88cf32: string_utils: provide a version of strchrnul() in ...

2021-03-20 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 88cf3229fe5dec0df3c560eb714c7365ba987f4d
  https://github.com/lxc/lxc/commit/88cf3229fe5dec0df3c560eb714c7365ba987f4d
  Author: Christian Brauner 
  Date:   2021-03-20 (Sat, 20 Mar 2021)

  Changed paths:
M configure.ac
A src/include/stchrnul.c
A src/include/stchrnul.h
M src/lxc/string_utils.h

  Log Message:
  ---
  string_utils: provide a version of strchrnul() in case it's not available

This should only happen on Android.

Signed-off-by: Christian Brauner 


  Commit: f62beebe22d638ae001211fc9407925d41e5ccc2
  https://github.com/lxc/lxc/commit/f62beebe22d638ae001211fc9407925d41e5ccc2
  Author: Stéphane Graber 
  Date:   2021-03-20 (Sat, 20 Mar 2021)

  Changed paths:
M configure.ac
A src/include/stchrnul.c
A src/include/stchrnul.h
M src/lxc/string_utils.h

  Log Message:
  ---
  Merge pull request #3716 from brauner/2021-03-19/fixes

string_utils: provide a version of strchrnul() in case it's not avail…


Compare: https://github.com/lxc/lxc/compare/1718e6d6018d...f62beebe22d6
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 4f9e3f: rexec: don't close stderr

2021-03-19 Thread Christian Brauner

  Branch: refs/heads/stable-4.0
  Home:   https://github.com/lxc/lxc
  Commit: 4f9e3f46d0db063d775013065cbd792242681ba6
  https://github.com/lxc/lxc/commit/4f9e3f46d0db063d775013065cbd792242681ba6
  Author: Christian Brauner 
  Date:   2021-03-19 (Fri, 19 Mar 2021)

  Changed paths:
M src/lxc/rexec.c

  Log Message:
  ---
  rexec: don't close stderr

Otherwise we'll fail to attach to containers later on.

Fixes: 
https://discuss.linuxcontainers.org/t/error-failed-to-retrieve-pid-of-executing-child-process
Signed-off-by: Christian Brauner 


___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] b75c1e: rexec: don't close stderr

2021-03-18 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: b75c1e611d984a2fe48236cd779b9edb1dfbecdd
  https://github.com/lxc/lxc/commit/b75c1e611d984a2fe48236cd779b9edb1dfbecdd
  Author: Christian Brauner 
  Date:   2021-03-18 (Thu, 18 Mar 2021)

  Changed paths:
M src/lxc/rexec.c

  Log Message:
  ---
  rexec: don't close stderr

Otherwise we'll fail to attach to containers later on.

Fixes: 
https://discuss.linuxcontainers.org/t/error-failed-to-retrieve-pid-of-executing-child-process
Signed-off-by: Christian Brauner 


  Commit: 1718e6d6018d5d6072a01d92a11d5aafc314f98f
  https://github.com/lxc/lxc/commit/1718e6d6018d5d6072a01d92a11d5aafc314f98f
  Author: Stéphane Graber 
  Date:   2021-03-18 (Thu, 18 Mar 2021)

  Changed paths:
M src/lxc/rexec.c

  Log Message:
  ---
  Merge pull request #3715 from brauner/2021-03-18/fixes

rexec: don't close stderr


Compare: https://github.com/lxc/lxc/compare/45580870b05c...1718e6d6018d
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] b6153e: cgroups: ignore unused controllers

2021-03-17 Thread Stéphane Graber

  Branch: refs/heads/stable-4.0
  Home:   https://github.com/lxc/lxc
  Commit: b6153ed81899d807be2de932e364320f899d174a
  https://github.com/lxc/lxc/commit/b6153ed81899d807be2de932e364320f899d174a
  Author: Christian Brauner 
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: ignore unused controllers

Someone might have created a name= controller after the
container has started and so the container doesn't make use of this
controller.

Link: https://github.com/lxc/lxd/issues/8577
Signed-off-by: Christian Brauner 


  Commit: dcf690189a5771e931c5b974658e2287a3fca18b
  https://github.com/lxc/lxc/commit/dcf690189a5771e931c5b974658e2287a3fca18b
  Author: Christian Brauner 
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
M configure.ac
M src/lxc/macro.h

  Log Message:
  ---
  macro: define __aligned_u64 to handle kernels without such support

Signed-off-by: Christian Brauner 


  Commit: 652e39c6c5c5944010f958d9e5abaf0cae188705
  https://github.com/lxc/lxc/commit/652e39c6c5c5944010f958d9e5abaf0cae188705
  Author: Stéphane Graber 
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
A .github/workflows/build.yml
A .github/workflows/coverity.yml
A .github/workflows/static-analysis.yml
R .travis.yml
M src/tests/Makefile.am
R src/tests/travis.sh

  Log Message:
  ---
  Switch to Github actions

Travis-CI has been a disaster lately with us running out of credits or
their system thinking we're out of credit anyway...

So with Jenkins now covering arm64, let's move the rest of the CI to
Github Actions instead.

Signed-off-by: Stéphane Graber 


  Commit: 3bcb8895a40b2f0bf7dc72ced6d285f77f28b8d5
  https://github.com/lxc/lxc/commit/3bcb8895a40b2f0bf7dc72ced6d285f77f28b8d5
  Author: Stéphane Graber 
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
M .github/workflows/coverity.yml

  Log Message:
  ---
  github: Fix invalid syntax for coverity

Signed-off-by: Stéphane Graber 


Compare: https://github.com/lxc/lxc/compare/cca16c4ff90e...3bcb8895a40b
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 7b89a4: github: Fix invalid syntax for coverity

2021-03-17 Thread Christian Brauner

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 7b89a43d048bb7a2918735e60eb9e019a1442dfe
  https://github.com/lxc/lxc/commit/7b89a43d048bb7a2918735e60eb9e019a1442dfe
  Author: Stéphane Graber 
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
M .github/workflows/coverity.yml

  Log Message:
  ---
  github: Fix invalid syntax for coverity

Signed-off-by: Stéphane Graber 


  Commit: 45580870b05c75142948cfc12f4f2fbc5e2fcd3e
  https://github.com/lxc/lxc/commit/45580870b05c75142948cfc12f4f2fbc5e2fcd3e
  Author: Christian Brauner 
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
M .github/workflows/coverity.yml

  Log Message:
  ---
  Merge pull request #3712 from stgraber/master

github: Fix invalid syntax for coverity


Compare: https://github.com/lxc/lxc/compare/e38b519e344c...45580870b05c
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 4bc1da: Switch to Github actions

2021-03-17 Thread Christian Brauner

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 4bc1dabe069f85d0090e4d86382a72b3da904b0e
  https://github.com/lxc/lxc/commit/4bc1dabe069f85d0090e4d86382a72b3da904b0e
  Author: Stéphane Graber 
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
A .github/workflows/build.yml
A .github/workflows/coverity.yml
A .github/workflows/static-analysis.yml
R .travis.yml
M src/tests/Makefile.am
R src/tests/travis.sh

  Log Message:
  ---
  Switch to Github actions

Travis-CI has been a disaster lately with us running out of credits or
their system thinking we're out of credit anyway...

So with Jenkins now covering arm64, let's move the rest of the CI to
Github Actions instead.

Signed-off-by: Stéphane Graber 


  Commit: e38b519e344c6f032e050953d0ce7282181a7e1a
  https://github.com/lxc/lxc/commit/e38b519e344c6f032e050953d0ce7282181a7e1a
  Author: Christian Brauner 
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
A .github/workflows/build.yml
A .github/workflows/coverity.yml
A .github/workflows/static-analysis.yml
R .travis.yml
M src/tests/Makefile.am
R src/tests/travis.sh

  Log Message:
  ---
  Merge pull request #3711 from stgraber/master

Switch to Github actions


Compare: https://github.com/lxc/lxc/compare/4fece28fa119...e38b519e344c
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] b1abf1: macro: define __aligned_u64 to handle kernels with...

2021-03-17 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: b1abf15db2b5fb5126ae1f9221e6e3de3b4e0768
  https://github.com/lxc/lxc/commit/b1abf15db2b5fb5126ae1f9221e6e3de3b4e0768
  Author: Christian Brauner 
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
M configure.ac
M src/lxc/macro.h

  Log Message:
  ---
  macro: define __aligned_u64 to handle kernels without such support

Signed-off-by: Christian Brauner 


  Commit: 4fece28fa1193fe3ddf995b55417d89195a230e9
  https://github.com/lxc/lxc/commit/4fece28fa1193fe3ddf995b55417d89195a230e9
  Author: Stéphane Graber 
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
M configure.ac
M src/lxc/macro.h

  Log Message:
  ---
  Merge pull request #3710 from brauner/2021-03-17/fixes

macro: define __aligned_u64 to handle kernels without such support


Compare: https://github.com/lxc/lxc/compare/0f1caf26d505...4fece28fa119
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 615941: cgroups: ignore unused controllers

2021-03-17 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 6159413bc9dfe2dc2d7598dedb36df45e5b40747
  https://github.com/lxc/lxc/commit/6159413bc9dfe2dc2d7598dedb36df45e5b40747
  Author: Christian Brauner 
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: ignore unused controllers

Someone might have created a name= controller after the
container has started and so the container doesn't make use of this
controller.

Link: https://github.com/lxc/lxd/issues/8577
Signed-off-by: Christian Brauner 


  Commit: 0f1caf26d505dd3f74eb249ebd61160e840df32d
  https://github.com/lxc/lxc/commit/0f1caf26d505dd3f74eb249ebd61160e840df32d
  Author: Stéphane Graber 
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  Merge pull request #3708 from brauner/2021-03-17/fixes

cgroups: ignore unused controllers


Compare: https://github.com/lxc/lxc/compare/f62764977dbb...0f1caf26d505
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] c07b68: start: handle CLONE_PIDFD on arm64

2021-03-10 Thread Christian Brauner

  Branch: refs/heads/stable-4.0
  Home:   https://github.com/lxc/lxc
  Commit: c07b6837e30b8d969060ce7d3f95a30abec637de
  https://github.com/lxc/lxc/commit/c07b6837e30b8d969060ce7d3f95a30abec637de
  Author: Christian Brauner 
  Date:   2021-03-10 (Wed, 10 Mar 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  start: handle CLONE_PIDFD on arm64

Reported-by: Ondrej Kubik 
Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: b2b8a8361991c2d138bb19311279f8b9f9c236f5
  https://github.com/lxc/lxc/commit/b2b8a8361991c2d138bb19311279f8b9f9c236f5
  Author: Christian Brauner 
  Date:   2021-03-10 (Wed, 10 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: tweak comment about transient procfs mount

Signed-off-by: Christian Brauner 


  Commit: c71964ed3a20d72be336272fd67c2e755e492a77
  https://github.com/lxc/lxc/commit/c71964ed3a20d72be336272fd67c2e755e492a77
  Author: Christian Brauner 
  Date:   2021-03-10 (Wed, 10 Mar 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/start.c

  Log Message:
  ---
  conf: simplify dependent mount logic

Signed-off-by: Christian Brauner 


  Commit: 87cd93a6b6339156b0d850798c9a03c934d36d9d
  https://github.com/lxc/lxc/commit/87cd93a6b6339156b0d850798c9a03c934d36d9d
  Author: Christian Brauner 
  Date:   2021-03-10 (Wed, 10 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: ensure that procfs and sysfs are unmounted

Signed-off-by: Christian Brauner 


  Commit: 9654c74a929ebd93629d1bde5849867c80c664a4
  https://github.com/lxc/lxc/commit/9654c74a929ebd93629d1bde5849867c80c664a4
  Author: Christian Brauner 
  Date:   2021-03-10 (Wed, 10 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: cleanup automounting

Signed-off-by: Christian Brauner 


  Commit: e780adae641c8bc995201b5c806bb085133b787c
  https://github.com/lxc/lxc/commit/e780adae641c8bc995201b5c806bb085133b787c
  Author: Christian Brauner 
  Date:   2021-03-10 (Wed, 10 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: simplify logging in lxc_mount_auto_mounts()

Signed-off-by: Christian Brauner 


  Commit: cca16c4ff90e4bec137deb3390e59582340ff3d1
  https://github.com/lxc/lxc/commit/cca16c4ff90e4bec137deb3390e59582340ff3d1
  Author: Christian Brauner 
  Date:   2021-03-10 (Wed, 10 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: add missing newline in lxc_mount_auto_mounts()

Signed-off-by: Christian Brauner 


Compare: https://github.com/lxc/lxc/compare/e6135627c555...cca16c4ff90e
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 3dd3fc: conf: tweak comment about transient procfs mount

2021-03-09 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 3dd3fc31640e5038d05548ed277bef494493587f
  https://github.com/lxc/lxc/commit/3dd3fc31640e5038d05548ed277bef494493587f
  Author: Christian Brauner 
  Date:   2021-03-09 (Tue, 09 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: tweak comment about transient procfs mount

Signed-off-by: Christian Brauner 


  Commit: ed41e764e8e7da9283b98e20ee643ea9e39808cd
  https://github.com/lxc/lxc/commit/ed41e764e8e7da9283b98e20ee643ea9e39808cd
  Author: Christian Brauner 
  Date:   2021-03-09 (Tue, 09 Mar 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/start.c

  Log Message:
  ---
  conf: simplify dependent mount logic

Signed-off-by: Christian Brauner 


  Commit: 95258e34b568acf49d684e7c96a0c67a81498dc6
  https://github.com/lxc/lxc/commit/95258e34b568acf49d684e7c96a0c67a81498dc6
  Author: Christian Brauner 
  Date:   2021-03-09 (Tue, 09 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: ensure that procfs and sysfs are unmounted

Signed-off-by: Christian Brauner 


  Commit: 75fca1ac4750dc57a51fda25cce49a3346265956
  https://github.com/lxc/lxc/commit/75fca1ac4750dc57a51fda25cce49a3346265956
  Author: Christian Brauner 
  Date:   2021-03-09 (Tue, 09 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: cleanup automounting

Signed-off-by: Christian Brauner 


  Commit: 0d33a382094536a949da0c0fde7871d45bbb555b
  https://github.com/lxc/lxc/commit/0d33a382094536a949da0c0fde7871d45bbb555b
  Author: Christian Brauner 
  Date:   2021-03-09 (Tue, 09 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: simplify logging in lxc_mount_auto_mounts()

Signed-off-by: Christian Brauner 


  Commit: 96f306e6254270b88ba1df891aa192dfb1c90597
  https://github.com/lxc/lxc/commit/96f306e6254270b88ba1df891aa192dfb1c90597
  Author: Christian Brauner 
  Date:   2021-03-09 (Tue, 09 Mar 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: add missing newline in lxc_mount_auto_mounts()

Signed-off-by: Christian Brauner 


  Commit: f62764977dbbacda85ba9d496cb011080ebae1fe
  https://github.com/lxc/lxc/commit/f62764977dbbacda85ba9d496cb011080ebae1fe
  Author: Stéphane Graber 
  Date:   2021-03-09 (Tue, 09 Mar 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/start.c

  Log Message:
  ---
  Merge pull request #3707 from brauner/2021-03-09/fixes

conf: automount fixes


Compare: https://github.com/lxc/lxc/compare/90b7adcc5ea7...f62764977dbb
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] abd80b: start: handle CLONE_PIDFD on arm64

2021-03-05 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: abd80bded6f39ef72f0206751c1553befd50d599
  https://github.com/lxc/lxc/commit/abd80bded6f39ef72f0206751c1553befd50d599
  Author: Christian Brauner 
  Date:   2021-03-05 (Fri, 05 Mar 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  start: handle CLONE_PIDFD on arm64

Reported-by: Ondrej Kubik 
Cc: stable-4.0
Signed-off-by: Christian Brauner 


  Commit: 90b7adcc5ea7868a93796d2d9f9775916c245644
  https://github.com/lxc/lxc/commit/90b7adcc5ea7868a93796d2d9f9775916c245644
  Author: Stéphane Graber 
  Date:   2021-03-05 (Fri, 05 Mar 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  Merge pull request #3706 from brauner/2021-03-05/fix_aarch64

start: handle CLONE_PIDFD on arm64


Compare: https://github.com/lxc/lxc/compare/673ce312c54b...90b7adcc5ea7
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 69c8ec: af_unix: vet all parameters

2021-03-05 Thread Christian Brauner

  Branch: refs/heads/stable-4.0
  Home:   https://github.com/lxc/lxc
  Commit: 69c8ec8a4f796ba7b299f970537c9f9047aaace5
  https://github.com/lxc/lxc/commit/69c8ec8a4f796ba7b299f970537c9f9047aaace5
  Author: Christian Brauner 
  Date:   2021-03-05 (Fri, 05 Mar 2021)

  Changed paths:
M src/lxc/af_unix.c

  Log Message:
  ---
  af_unix: vet all parameters

Signed-off-by: Christian Brauner 


  Commit: 95ef7b2f98f486c2cceb8a5576e275f815454460
  https://github.com/lxc/lxc/commit/95ef7b2f98f486c2cceb8a5576e275f815454460
  Author: Tycho Andersen 
  Date:   2021-03-05 (Fri, 05 Mar 2021)

  Changed paths:
M src/lxc/cgroups/cgroup.c

  Log Message:
  ---
  cgroup: do not fail if there are no writable heirarchies

This is a spiritual revert of 5c7b81439cecfbd885b3c10f9edfefdc1ac7c45b (it
doesn't add back any of the logs, just removes the bad check).

Not having writable hierarchies is not actually a problem:

1. if I remove this check, things work just fine; below is a successful log
   of a run where there are no writable hierarchies

2. I believe the test for writability is slightly incorrect.
   unified_hierarchy_delegated() and legacy_hierarchy_delegated() both test
   the writability of $current_hierarchy/cgroup.procs. On my system, I
   have:

~ cat /proc/self/cgroup
12:hugetlb:/
11:pids:/user.slice/user-1000.slice/session-c38.scope
10:memory:/user.slice/user-1000.slice/session-c38.scope
9:freezer:/user/tycho/0
8:cpuset:/
7:net_cls,net_prio:/
6:blkio:/user.slice
5:devices:/user.slice
4:rdma:/
3:cpu,cpuacct:/user.slice
2:perf_event:/
1:name=systemd:/user.slice/user-1000.slice/session-c38.scope
0::/user.slice/user-1000.slice/session-c38.scope
~ ls -al /sys/fs/cgroup/freezer/user/tycho/0/
total 0
drwxr-xr-x 2 tycho tycho 0 Feb 22 09:17 ./
drwxr-xr-x 3 root  root  0 Mar  2 14:07 ../
-rw-r--r-- 1 root  root  0 Mar  2 14:07 cgroup.clone_children
-rw-r--r-- 1 root  root  0 Mar  2 14:09 cgroup.procs
-r--r--r-- 1 root  root  0 Mar  2 14:07 freezer.parent_freezing
-r--r--r-- 1 root  root  0 Mar  2 14:07 freezer.self_freezing
-rw-r--r-- 1 root  root  0 Mar  2 14:07 freezer.state
-rw-r--r-- 1 root  root  0 Mar  2 14:07 notify_on_release
-rw-r--r-- 1 root  root  0 Mar  2 14:07 tasks

i.e. the cgroup.procs is not writable by me. but since the directory is
owned by me, it is actually usable in the way LXC would use it. When I
start an unprivileged container, it could make a subdirectory in whatever
current hierarchy I happen to be before applying rules.

In any case, let's just revert the bad check for now.

lxc 20210302210944.785 INFO confile - confile.c:set_config_idmaps:2151 - 
Read uid map: type u nsid 0 hostid 1000 range 1
lxc 20210302210944.785 INFO confile - confile.c:set_config_idmaps:2151 - 
Read uid map: type u nsid 1 hostid 11 range 65535
lxc 20210302210944.785 INFO confile - confile.c:set_config_idmaps:2151 - 
Read uid map: type g nsid 0 hostid 1000 range 1
lxc 20210302210944.785 INFO confile - confile.c:set_config_idmaps:2151 - 
Read uid map: type g nsid 1 hostid 11 range 65535
lxc 20210302210944.786 INFO conf - conf.c:userns_exec_mapped_root:4644 - 
Container root id is mapped to our uid
lxc 20210302210944.799 TRACEcommands - commands.c:lxc_cmd:510 - Connection 
refused - Command "get_init_pid" failed to connect command socket
lxc base 20210302210944.801 TRACEcommands - commands.c:lxc_server_init:2065 
- Created abstract unix socket "lxc/9beb6bd65573affd/command"
lxc base 20210302210944.801 TRACEstart - start.c:lxc_init_handler:726 - 
Unix domain socket 3 for command server is ready
lxc base 20210302210944.801 TRACEexecute - execute.c:lxc_execute:97 - Doing 
lxc_execute
lxc base 20210302210944.801 WARN apparmor - 
lsm/apparmor.c:lsm_apparmor_ops_init:1268 - Per-container AppArmor profiles are 
disabled because the mac_admin capability is missing
lxc base 20210302210944.801 INFO lsm - lsm/lsm.c:lsm_init_static:40 - 
Initialized LSM security driver AppArmor
lxc base 20210302210944.801 TRACEstart - start.c:lxc_init:750 - Initialized 
LSM
lxc base 20210302210944.801 TRACEstart - 
start.c:lxc_serve_state_clients:448 - Set container state to STARTING
lxc base 20210302210944.801 TRACEstart - 
start.c:lxc_serve_state_clients:451 - No state clients registered
lxc base 20210302210944.801 INFO utils - utils.c:get_rundir:260 - 
XDG_RUNTIME_DIR isn't set in the environment
lxc base 20210302210944.801 TRACEstart - start.c:lxc_init:756 - Set 
container state to "STARTING"
lxc base 20210302210944.801 TRACEstart - start.c:lxc_init:812 - Set 
environment variables
lxc base 20210302210944.801 TRACEstart - start.c:lxc_init:817 - Ran 
pre-start hooks
lxc base 20210302210944.801 TRACEstart - start.c:setup_signal_fd:341 - 
Created signal file descriptor 6
lxc base 20210302210944.801 TRACEstart - start.c:lxc_init:826 - Set up 
signal fd
lxc base 20210302210944.803 INFO conf - conf.c:userns_exec_mapped_root:4644

[lxc-devel] [lxc/lxc] d961eb: af_unix: vet all parameters

2021-02-27 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: d961ebd945eb3c1def0f645993739dabc80aacce
  https://github.com/lxc/lxc/commit/d961ebd945eb3c1def0f645993739dabc80aacce
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/af_unix.c

  Log Message:
  ---
  af_unix: vet all parameters

Signed-off-by: Christian Brauner 


  Commit: cfe6f43599b10951ac59fcb2ccc84a4eece8aa16
  https://github.com/lxc/lxc/commit/cfe6f43599b10951ac59fcb2ccc84a4eece8aa16
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  start: fix whitespace error

Signed-off-by: Christian Brauner 


  Commit: b49f36bcdbea7a34bdce9d4331663da17ecade61
  https://github.com/lxc/lxc/commit/b49f36bcdbea7a34bdce9d4331663da17ecade61
  Author: Stéphane Graber 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/af_unix.c
M src/lxc/start.c

  Log Message:
  ---
  Merge pull request #3700 from brauner/2021-02-26/fixes_2

small fixes


Compare: https://github.com/lxc/lxc/compare/88e27cd64195...b49f36bcdbea
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] c27490: confile: initialize network struct

2021-02-27 Thread Christian Brauner

  Branch: refs/heads/stable-4.0
  Home:   https://github.com/lxc/lxc
  Commit: c27490d32cee6d6e8a1693ac09070437a72d5d79
  https://github.com/lxc/lxc/commit/c27490d32cee6d6e8a1693ac09070437a72d5d79
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: initialize network struct

Signed-off-by: Christian Brauner 


___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] bad2f9: network: make callback naming consistent and under...

2021-02-26 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: bad2f9131a6b58bd13f2f3b72c479c85912a2030
  https://github.com/lxc/lxc/commit/bad2f9131a6b58bd13f2f3b72c479c85912a2030
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/network.c

  Log Message:
  ---
  network: make callback naming consistent and understandable

Signed-off-by: Christian Brauner 


  Commit: 071d09345f402420dfbc14cafbaa48fb1f11d954
  https://github.com/lxc/lxc/commit/071d09345f402420dfbc14cafbaa48fb1f11d954
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/network.c

  Log Message:
  ---
  network: fix coding style in lxc_create_network_unpriv_exec()

Signed-off-by: Christian Brauner 


  Commit: 9dffc40e2a400a208fff7af5dc3151dc1b2c3ca6
  https://github.com/lxc/lxc/commit/9dffc40e2a400a208fff7af5dc3151dc1b2c3ca6
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  confile_utils: ensure memory is zeroed

Signed-off-by: Christian Brauner 


  Commit: 4a037d618e3fbcaa9d27bd6039f252d9a3f61c5b
  https://github.com/lxc/lxc/commit/4a037d618e3fbcaa9d27bd6039f252d9a3f61c5b
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/network.c

  Log Message:
  ---
  network: fix grammar

Signed-off-by: Christian Brauner 


  Commit: 3392d3794166f4e4ab5eb273e03e52d5865b5e36
  https://github.com/lxc/lxc/commit/3392d3794166f4e4ab5eb273e03e52d5865b5e36
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/network.c

  Log Message:
  ---
  network: add lxc_network_info struct

Signed-off-by: Christian Brauner 


  Commit: fdd6be55c1f58ddcfde3443a49ea6884878b343e
  https://github.com/lxc/lxc/commit/fdd6be55c1f58ddcfde3443a49ea6884878b343e
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/network.c
M src/lxc/network.h

  Log Message:
  ---
  network: handle name collisions when renaming network devices

LXC moves network devices into the target namespace based on their created
name. The created name can either be randomly generated for e.g. veth
devices or it can be the name of the existing device in the server's
namespaces. This is e.g. the case when moving physical devices. However this
can lead to weird clashes. Consider we have a network namespace that has the
following devices:

4: eth1:  mtu 1500 qdisc noop state DOWN group default 
qlen 1000
   link/ether 00:16:3e:91:d3:ae brd ff:ff:ff:ff:ff:ff permaddr 00:16:3e:e7:5d:10
   altname enp7s0
5: eth2:  mtu 1500 qdisc noop state DOWN group default 
qlen 1000
   link/ether 00:16:3e:e7:5d:10 brd ff:ff:ff:ff:ff:ff permaddr 00:16:3e:91:d3:ae
   altname enp8s0

and the user generates the following network config for their container:

 lxc.net.0.type = phys
 lxc.net.0.name = eth1
 lxc.net.0.link = eth2

 lxc.net.1.type = phys
 lxc.net.1.name = eth2
 lxc.net.1.link = eth1

This would cause LXC to move the devices eth1 and eth2 from the server's
network namespace into the container's network namespace:

24: eth1:  mtu 1500 qdisc noop state DOWN group default 
qlen 1000
link/ether 00:16:3e:91:d3:ae brd ff:ff:ff:ff:ff:ff permaddr 
00:16:3e:e7:5d:10
altname enp7s0
25: eth2:  mtu 1500 qdisc noop state DOWN group default 
qlen 1000
link/ether 00:16:3e:e7:5d:10 brd ff:ff:ff:ff:ff:ff permaddr 
00:16:3e:91:d3:ae
 altname enp8s0

According to the network config above we now need to rename the network
devices in the container's network namespace. Let's say we start with
renaming eth2 to eth1. This would immediately lead to a clash since the
container's network namespace already contains a network device with that
name. Renaming the other device would have the same problem.

There are multiple ways to fix this but I'm concerned with keeping the logic
somewhat reasonable which is why we simply start creating transient device
names that are unique which we'll use to move and rename the network device
in the container's network namespace at the same time. And then we rename
based on those random devices names to the target name.

Fixes: #3696
Reported-by: Sam Boyles 
Reported-by: Blair Steven 
Signed-off-by: Christian Brauner 


  Commit: 3a197a1b63d010943fbc88c31d63c05b73f81682
  https://github.com/lxc/lxc/commit/3a197a1b63d010943fbc88c31d63c05b73f81682
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/network.c

  Log Message:
  ---
  network: use two passes through networks

Consider the following network layout:

 lxc.net.0.type = phys
 lxc.net.0.link = eth2
 lxc.net.0.name = eth%d

 lxc.net.1.type = phys
 lxc.net.1.link = eth1
 lxc.net.1.name = eth0

If we simply follow this order and create the first network first the

[lxc-devel] [lxc/lxc] 5f2412: commands: cleanup error handling and variable naming

2021-02-25 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 5f241268dc0deb8eecde809bde62ddf7d58b88e0
  https://github.com/lxc/lxc/commit/5f241268dc0deb8eecde809bde62ddf7d58b88e0
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: cleanup error handling and variable naming

Signed-off-by: Christian Brauner 


  Commit: 46b576e56d7098325f96cdac6efb76a236d2af0b
  https://github.com/lxc/lxc/commit/46b576e56d7098325f96cdac6efb76a236d2af0b
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: rsp_one_fd_{reap,keep}() and rsp_many_fds_reap()

Signed-off-by: Christian Brauner 


  Commit: 89d51b22cc6e3cbae592a07a9481093efed95aca
  https://github.com/lxc/lxc/commit/89d51b22cc6e3cbae592a07a9481093efed95aca
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: fix indentation

Signed-off-by: Christian Brauner 


  Commit: 6d829cd2dae509a41e5e5306c569eeb2f125352c
  https://github.com/lxc/lxc/commit/6d829cd2dae509a41e5e5306c569eeb2f125352c
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: unify fd retrieval commands

Signed-off-by: Christian Brauner 


  Commit: 060aaa395a10e50c7b21df3b3e56a71720b20582
  https://github.com/lxc/lxc/commit/060aaa395a10e50c7b21df3b3e56a71720b20582
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/af_unix.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/commands.c
M src/lxc/confile.c
M src/lxc/log.h

  Log Message:
  ---
  tree-wide: s/syerrno_set()/syserror_set()/g

Signed-off-by: Christian Brauner 


  Commit: 2d7b08959063ddcd15be57cbf22d04b0d1a92c14
  https://github.com/lxc/lxc/commit/2d7b08959063ddcd15be57cbf22d04b0d1a92c14
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/af_unix.c
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/commands.c
M src/lxc/conf.c
M src/lxc/confile_utils.c

  Log Message:
  ---
  tree-wide: start replacing instances of syserrno() with syserror()

Signed-off-by: Christian Brauner 


  Commit: 9fc21b2d84d0fe21ef66125bd28b6bed085bd92d
  https://github.com/lxc/lxc/commit/9fc21b2d84d0fe21ef66125bd28b6bed085bd92d
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/commands.c
M src/lxc/log.h

  Log Message:
  ---
  tree-wide: replace remaining instances of syserrno() with syserror_ret()

Signed-off-by: Christian Brauner 


  Commit: 81d90ee56020ed4cccdf967461154343b35d7e8e
  https://github.com/lxc/lxc/commit/81d90ee56020ed4cccdf967461154343b35d7e8e
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/log.h

  Log Message:
  ---
  log: mark logging helpers to use

Signed-off-by: Christian Brauner 


  Commit: 6d95e0b7e9c32d7b7afcecdddb3534c277ac0b12
  https://github.com/lxc/lxc/commit/6d95e0b7e9c32d7b7afcecdddb3534c277ac0b12
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/commands.c
M src/lxc/log.h

  Log Message:
  ---
  tree-wide: use new logging helpers

Signed-off-by: Christian Brauner 


  Commit: b1b38fd16db4087a64af17ce36e0aef8817d8c55
  https://github.com/lxc/lxc/commit/b1b38fd16db4087a64af17ce36e0aef8817d8c55
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/commands.c
M src/lxc/log.h

  Log Message:
  ---
  tree-wide: replace old systrace logging helpers

Signed-off-by: Christian Brauner 


  Commit: 815c378b9b3044849149f481cb406343c0f3b900
  https://github.com/lxc/lxc/commit/815c378b9b3044849149f481cb406343c0f3b900
  Author: Christian Brauner 
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/log.h

  Log Message:
  ---
  tree-wide: replace old-style sysinfo logging return helper

Signed-off-by: Christian Brauner 


  Commit: 32d40452522df15bcdcb2a62f246cbfcd948f7f3
  https://github.com/lxc/lxc/commit/32d40452522df15bcdcb2a62f246cbfcd948f7f3
  Author: Stéphane Graber 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/af_unix.c
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/commands.c
M src/lxc/conf.c
M src/lxc/confile.c
M src/lxc/confile_utils.c
M src/lxc/log.h

  Log

[lxc-devel] [lxc/lxc] 0437ea: commands: use IN_SET() in lxc_cmd()

2021-02-25 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 0437eac56910160adbf2f722711c0577c28ed5dc
  https://github.com/lxc/lxc/commit/0437eac56910160adbf2f722711c0577c28ed5dc
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: use IN_SET() in lxc_cmd()

Signed-off-by: Christian Brauner 


  Commit: 8a598112ddf03ab4709cfbaf53127eebbfa8b9a8
  https://github.com/lxc/lxc/commit/8a598112ddf03ab4709cfbaf53127eebbfa8b9a8
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: switch to bool

Signed-off-by: Christian Brauner 


  Commit: 6834acfffbe8ed5f021533c9ccaafd07f62f3bed
  https://github.com/lxc/lxc/commit/6834acfffbe8ed5f021533c9ccaafd07f62f3bed
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/commands.c
M src/lxc/commands.h
M src/lxc/start.c

  Log Message:
  ---
  commands: s/lxc_cmd_init()/lxc_server_init()/g

Signed-off-by: Christian Brauner 


  Commit: 58a8d1f07de30ddbd79ca6405a70c3f930e1c56e
  https://github.com/lxc/lxc/commit/58a8d1f07de30ddbd79ca6405a70c3f930e1c56e
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/commands.h

  Log Message:
  ---
  commands: add lxc_cmd_init() and lxc_cmd_data()

Signed-off-by: Christian Brauner 


  Commit: 38d14ebda65bb1a8eaa2b0e6a50b811e38d355b6
  https://github.com/lxc/lxc/commit/38d14ebda65bb1a8eaa2b0e6a50b811e38d355b6
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: port lxc_try_cmd() to new helpers

Signed-off-by: Christian Brauner 


  Commit: 22642823aca74f32c87390f7b9c2c25ab78fd638
  https://github.com/lxc/lxc/commit/22642823aca74f32c87390f7b9c2c25ab78fd638
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: port lxc_cmd_get_init_pid() to new helpers

Signed-off-by: Christian Brauner 


  Commit: 7208e700bb9f3376367146a31479900fda5570a7
  https://github.com/lxc/lxc/commit/7208e700bb9f3376367146a31479900fda5570a7
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: port lxc_cmd_get_init_pidfd() to new helpers

Signed-off-by: Christian Brauner 


  Commit: f7a7b0955ad2936b2a5e7b12fe0d66c99e6d9fa5
  https://github.com/lxc/lxc/commit/f7a7b0955ad2936b2a5e7b12fe0d66c99e6d9fa5
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: port lxc_cmd_get_devpts_fd() to new helpers

Signed-off-by: Christian Brauner 


  Commit: f0af9082578c146700f52f3e49364198b6d8a9b8
  https://github.com/lxc/lxc/commit/f0af9082578c146700f52f3e49364198b6d8a9b8
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: port lxc_cmd_get_seccomp_notify_fd() to new helpers

Signed-off-by: Christian Brauner 


  Commit: 19d141f686456f5fdd698a1a5e5a9715e7b130d5
  https://github.com/lxc/lxc/commit/19d141f686456f5fdd698a1a5e5a9715e7b130d5
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: port lxc_cmd_get_cgroup_ctx() to new helpers

Signed-off-by: Christian Brauner 


  Commit: b4e1a2e8e7ea8e846048b7367225d75b2b83c75e
  https://github.com/lxc/lxc/commit/b4e1a2e8e7ea8e846048b7367225d75b2b83c75e
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: port lxc_cmd_get_clone_flags() to new helpers

Signed-off-by: Christian Brauner 


  Commit: f85d2385c03eaa1e1a930b1be39674726c48eaae
  https://github.com/lxc/lxc/commit/f85d2385c03eaa1e1a930b1be39674726c48eaae
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/commands.c
M src/lxc/commands.h

  Log Message:
  ---
  commands: portlxc_cmd_get_cgroup_path_do() to new helpers

Signed-off-by: Christian Brauner 


  Commit: 187e46ab3216e670239ed1e2549cd3ea0bfd8ffd
  https://github.com/lxc/lxc/commit/187e46ab3216e670239ed1e2549cd3ea0bfd8ffd
  Author: Christian Brauner 
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: port lxc_cmd_get_config_item() to new helpers

Signed-off-by: Christian Brauner 


  Commit: 1b08494ee5470ae8e5d49824fb857bd83de20f69
  https://github.com/lxc/lxc/commit/1b08494ee5470ae8e5d49824fb857bd83de20f69
  Author:

[lxc-devel] [lxc/lxc] e84841: commands: annotate array argument

2021-02-24 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: e848413e2a6f58aa24f4363b3af5352c44d2b5ce
  https://github.com/lxc/lxc/commit/e848413e2a6f58aa24f4363b3af5352c44d2b5ce
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: annotate array argument

Signed-off-by: Christian Brauner 


  Commit: 3d971319174b87f270fdc4d609aee3868cef05f0
  https://github.com/lxc/lxc/commit/3d971319174b87f270fdc4d609aee3868cef05f0
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/commands.c
M src/lxc/commands.h
M src/lxc/compiler.h

  Log Message:
  ---
  commands: ensure that non-NULL and MAX_STATE is always passed

Signed-off-by: Christian Brauner 


  Commit: 2be31fed4082f7acc6dd691ca4463360ad5479c5
  https://github.com/lxc/lxc/commit/2be31fed4082f7acc6dd691ca4463360ad5479c5
  Author: Stéphane Graber 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/commands.c
M src/lxc/commands.h
M src/lxc/compiler.h

  Log Message:
  ---
  Merge pull request #3695 from brauner/2021-02-24/fixes_3

commands: array hardening


Compare: https://github.com/lxc/lxc/compare/2ed90529b4b8...2be31fed4082
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 9d3480: cgroups: simple variable reordering

2021-02-24 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 9d3480dab480ec52538da591f4788acf2d6437ff
  https://github.com/lxc/lxc/commit/9d3480dab480ec52538da591f4788acf2d6437ff
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: simple variable reordering

Signed-off-by: Christian Brauner 


  Commit: 38fa7e479cea516d2cf303bbe8f3a8f88ea2a3c9
  https://github.com/lxc/lxc/commit/38fa7e479cea516d2cf303bbe8f3a8f88ea2a3c9
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/Makefile.am
M src/lxc/cgroups/cgfsng.c
A src/lxc/error_utils.h
M src/lxc/macro.h
M src/lxc/memory_utils.h

  Log Message:
  ---
  error_utils: move error helper to separate header

Signed-off-by: Christian Brauner 


  Commit: 5dc24a8c2886464a6844f64f419f1352dc78fbbe
  https://github.com/lxc/lxc/commit/5dc24a8c2886464a6844f64f419f1352dc78fbbe
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: tweak return values

Signed-off-by: Christian Brauner 


  Commit: 7924f36a15cb3b198e6299ed541c2011d73d3098
  https://github.com/lxc/lxc/commit/7924f36a15cb3b198e6299ed541c2011d73d3098
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/error_utils.h

  Log Message:
  ---
  error_utils: copy over Lennart's IN_SET()

Signed-off-by: Christian Brauner 


  Commit: f740bc634347adaca6d31e3f4b6327ad93cfe8af
  https://github.com/lxc/lxc/commit/f740bc634347adaca6d31e3f4b6327ad93cfe8af
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: make use of ERRNO_IS_NOT_SUPPORTED()

This will hopefully prevent backwards compatibility fallback errors.

Signed-off-by: Christian Brauner 


  Commit: 8dfcf0df6c14dbf31c92a66e42faeba98f03609d
  https://github.com/lxc/lxc/commit/8dfcf0df6c14dbf31c92a66e42faeba98f03609d
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/lxccontainer.c

  Log Message:
  ---
  cgroups: handle fallback gracefully

Signed-off-by: Christian Brauner 


  Commit: ac5eacc62e3e9a33972cce40e693db2fb7f5e5c3
  https://github.com/lxc/lxc/commit/ac5eacc62e3e9a33972cce40e693db2fb7f5e5c3
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: fix alignment for lxc_cmd_get_cgroup_ctx()

Signed-off-by: Christian Brauner 


  Commit: bce2970f8071dcd2f0db71a8a94f1243073464db
  https://github.com/lxc/lxc/commit/bce2970f8071dcd2f0db71a8a94f1243073464db
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/commands.c
M src/lxc/commands.h

  Log Message:
  ---
  commands: simplify lxc_cmd_get_cgroup_ctx()

Instead of allowing individual hierarchy fd retrieval through
lxc_cmd_get_cgroup_ctx() let's add a dedicated method instead.

Signed-off-by: Christian Brauner 


  Commit: a9b642ee5c63ebdabe6ed89ac4201dced32be0b8
  https://github.com/lxc/lxc/commit/a9b642ee5c63ebdabe6ed89ac4201dced32be0b8
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/commands.c
M src/lxc/commands.h
M src/lxc/criu.c

  Log Message:
  ---
  commands: s/_LIMITING_/_LIMIT_/g and s/_limiting_/_limit_/g

Signed-off-by: Christian Brauner 


  Commit: c206ac24b3d974d9b9f2e07d415dbf851179afa2
  https://github.com/lxc/lxc/commit/c206ac24b3d974d9b9f2e07d415dbf851179afa2
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/commands.c
M src/lxc/commands.h

  Log Message:
  ---
  commands: add LXC_CMD_GET_CGROUP_FD and LXC_CMD_GET_LIMIT_CGROUP_FD

Signed-off-by: Christian Brauner 


  Commit: 61983e15d2842997142c0df9b5eef80796686c94
  https://github.com/lxc/lxc/commit/61983e15d2842997142c0df9b5eef80796686c94
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h

  Log Message:
  ---
  cgroups: s/cgroup_layout/layout/g

Signed-off-by: Christian Brauner 


  Commit: 28c738ebe09db759b4f75be349da00ef11ec3532
  https://github.com/lxc/lxc/commit/28c738ebe09db759b4f75be349da00ef11ec3532
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: set rsp.ret to 0 for lxc_cmd_get_cgroup_ctx_callback()

Signed-off-by: Christian Brauner

[lxc-devel] [lxc/lxc] 70ba94: commands: remove faulty use of access attribute

2021-02-23 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 70ba94fb0a59ecf1c6824cadc1cf7553221d185b
  https://github.com/lxc/lxc/commit/70ba94fb0a59ecf1c6824cadc1cf7553221d185b
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/commands.h

  Log Message:
  ---
  commands: remove faulty use of access attribute

Signed-off-by: Christian Brauner 


  Commit: 327baffea38989710189feebf27dd6df02b5762e
  https://github.com/lxc/lxc/commit/327baffea38989710189feebf27dd6df02b5762e
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: fix braino during controller list creation

Co-mounted controllers are conventionally separated by ",".

Fixes: 
https://jenkins.linuxcontainers.org/job/lxd-github-commit/1905/arch=amd64,backend=dir,compiler=golang-1.15/consoleFull
Signed-off-by: Christian Brauner 


  Commit: 6ee13f5be729da11eaaa217daf7241be0d4ee89a
  https://github.com/lxc/lxc/commit/6ee13f5be729da11eaaa217daf7241be0d4ee89a
  Author: Christian Brauner 
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: be paranoid about file descriptors

Signed-off-by: Christian Brauner 


  Commit: 5dc90afd4931fe1fc14ea9b9583748f50fe71488
  https://github.com/lxc/lxc/commit/5dc90afd4931fe1fc14ea9b9583748f50fe71488
  Author: Stéphane Graber 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/commands.h

  Log Message:
  ---
  Merge pull request #3692 from brauner/2021-02-23/fixes

build fix & cgroup braino


Compare: https://github.com/lxc/lxc/compare/162402ccc178...5dc90afd4931
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 1454e5: commands: only deref once

2021-02-23 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 1454e5d9a07c597e208e586b41a689a7a963f352
  https://github.com/lxc/lxc/commit/1454e5d9a07c597e208e586b41a689a7a963f352
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: only deref once

Fixes: Coverity 1473308
Signed-off-by: Christian Brauner 


  Commit: 92fea74bfe5186184d26c5bc89bd2d8f1895574b
  https://github.com/lxc/lxc/commit/92fea74bfe5186184d26c5bc89bd2d8f1895574b
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/af_unix.c

  Log Message:
  ---
  af_unix: prevent oob writes

Fixes: Coverity 1473309
Signed-off-by: Christian Brauner 


  Commit: 2d8b9ab865ea42ba5d72a3231b7d1a98c8999fc1
  https://github.com/lxc/lxc/commit/2d8b9ab865ea42ba5d72a3231b7d1a98c8999fc1
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: fix error checking

Fixes: Coverity 1473310
Signed-off-by: Christian Brauner 


  Commit: 162402ccc1789fbeeb30d356d0b017d7df0a986b
  https://github.com/lxc/lxc/commit/162402ccc1789fbeeb30d356d0b017d7df0a986b
  Author: Stéphane Graber 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/af_unix.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/commands.c

  Log Message:
  ---
  Merge pull request #3691 from brauner/2021-02-23/fixes

Fix issues reported by Coverity


Compare: https://github.com/lxc/lxc/compare/be7715476fe4...162402ccc178
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 550ede: terminal: dumb logging down

2021-02-23 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 550ede0a94cfcd40da8434c9f8fe402347abf82f
  https://github.com/lxc/lxc/commit/550ede0a94cfcd40da8434c9f8fe402347abf82f
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/terminal.c

  Log Message:
  ---
  terminal: dumb logging down

Signed-off-by: Christian Brauner 


  Commit: 8723f88e9acae40b537b5ea71db982b73b91d4be
  https://github.com/lxc/lxc/commit/8723f88e9acae40b537b5ea71db982b73b91d4be
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/sync.h

  Log Message:
  ---
  attach: make fd sending more uniform

Signed-off-by: Christian Brauner 


  Commit: bef8f784733a601ec7e5df899d6c4039bac18a42
  https://github.com/lxc/lxc/commit/bef8f784733a601ec7e5df899d6c4039bac18a42
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: handle new and old clients

Signed-off-by: Christian Brauner 


  Commit: 7ec5eee4f0598ed68ffd90f3ca0631ae98efb8c4
  https://github.com/lxc/lxc/commit/7ec5eee4f0598ed68ffd90f3ca0631ae98efb8c4
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: handle old clients for LXC_CMD_GET_CGROUP_CTX

Signed-off-by: Christian Brauner 


  Commit: be7715476fe42a2392589934252853c14088e675
  https://github.com/lxc/lxc/commit/be7715476fe42a2392589934252853c14088e675
  Author: Stéphane Graber 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/commands.c
M src/lxc/sync.h
M src/lxc/terminal.c

  Log Message:
  ---
  Merge pull request #3690 from brauner/2021-02-21/fixes

attach: improve attaching of new clients to old servers


Compare: https://github.com/lxc/lxc/compare/b6f486373948...be7715476fe4
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 1d5446: memory_utils: fix close_equal()

2021-02-23 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 1d5446120b4312647fd700bf984e955ab65aa21c
  https://github.com/lxc/lxc/commit/1d5446120b4312647fd700bf984e955ab65aa21c
  Author: Christian Brauner 
  Date:   2021-02-22 (Mon, 22 Feb 2021)

  Changed paths:
M src/lxc/memory_utils.h

  Log Message:
  ---
  memory_utils: fix close_equal()

Signed-off-by: Christian Brauner 


  Commit: 7f02fd24f726d0f01b4946415fdb91ec906d17ea
  https://github.com/lxc/lxc/commit/7f02fd24f726d0f01b4946415fdb91ec906d17ea
  Author: Christian Brauner 
  Date:   2021-02-22 (Mon, 22 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: skip and warn about invalid file descriptors

Signed-off-by: Christian Brauner 


  Commit: d39f72b8b675fc4751b4fac4cd5279a20262106c
  https://github.com/lxc/lxc/commit/d39f72b8b675fc4751b4fac4cd5279a20262106c
  Author: Christian Brauner 
  Date:   2021-02-22 (Mon, 22 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: start stashing all fds

Signed-off-by: Christian Brauner 


  Commit: 840eec19c3bd3d26b4bc38fab30339bfc43d0890
  https://github.com/lxc/lxc/commit/840eec19c3bd3d26b4bc38fab30339bfc43d0890
  Author: Christian Brauner 
  Date:   2021-02-22 (Mon, 22 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/start.c

  Log Message:
  ---
  cgroups: close dfd_mon but keep dfd_con and dfd_lim open for all cgroup 
hierarchies

Signed-off-by: Christian Brauner 


  Commit: 61cebd7a1bed01fb989f7f0d9516847468355a81
  https://github.com/lxc/lxc/commit/61cebd7a1bed01fb989f7f0d9516847468355a81
  Author: Christian Brauner 
  Date:   2021-02-22 (Mon, 22 Feb 2021)

  Changed paths:
M src/lxc/commands.h

  Log Message:
  ---
  commands: explicitly number enums

Signed-off-by: Christian Brauner 


  Commit: da63ea6b4dd886bb1b8c2f04dce2030d13d4b843
  https://github.com/lxc/lxc/commit/da63ea6b4dd886bb1b8c2f04dce2030d13d4b843
  Author: Christian Brauner 
  Date:   2021-02-22 (Mon, 22 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: tweak validate_string_request()

Signed-off-by: Christian Brauner 


  Commit: d17c815dedffb98b5e7ffc7b1f8fb69577358f63
  https://github.com/lxc/lxc/commit/d17c815dedffb98b5e7ffc7b1f8fb69577358f63
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/af_unix.c
M src/lxc/af_unix.h
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/commands.c
M src/lxc/conf.c
M src/lxc/seccomp.c
M src/lxc/start.c

  Log Message:
  ---
  af_unix: improve SCM_RIGHTS file descriptor retrieval

Signed-off-by: Christian Brauner 


  Commit: c674e0f6e7895c101b240fe6a4babef029748c41
  https://github.com/lxc/lxc/commit/c674e0f6e7895c101b240fe6a4babef029748c41
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgroup.h

  Log Message:
  ---
  cgroups: add cgroup_fds() helper

Signed-off-by: Christian Brauner 


  Commit: 89420aff3681cd1d7b878b4ee61c2bb112a18b3d
  https://github.com/lxc/lxc/commit/89420aff3681cd1d7b878b4ee61c2bb112a18b3d
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/state.c

  Log Message:
  ---
  state: _never_ return NULL from lxc_state2str()

Cc: Thomas Parrott 
Signed-off-by: Christian Brauner 


  Commit: 32fd8d4f85534705eee90e828d58c27f870e215e
  https://github.com/lxc/lxc/commit/32fd8d4f85534705eee90e828d58c27f870e215e
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: be more explicit during command processing

Signed-off-by: Christian Brauner 


  Commit: 4b5f4bdcdee78d8a0080db68b86b9f3090b8cdef
  https://github.com/lxc/lxc/commit/4b5f4bdcdee78d8a0080db68b86b9f3090b8cdef
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: introduce lxc_cmd_rsp_send_reap()

Signed-off-by: Christian Brauner 


  Commit: c2f40088896cff9c86c8f0dcb78f2611afa5fd03
  https://github.com/lxc/lxc/commit/c2f40088896cff9c86c8f0dcb78f2611afa5fd03
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: introduce rsp_one_fd()

Signed-off-by: Christian Brauner 


  Commit: 9c3eb8d5258aa06ce057847c6fe03ff1db75736b
  https://github.com/lxc/lxc/commit/9c3eb8d5258aa06ce057847c6fe03ff1db75736b
  Author: Christian Brauner 
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
M src/lxc/commands.c

  Log Message:
  ---
  commands: introduce rsp_many_fds()

Signed-off-by: Christian Brauner 


  Commit:

[lxc-devel] [lxc/lxc] d9be3d: string_utils: move lxc_iterate_parts()

2021-02-22 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: d9be3d269433165da879dac87d56f84949fbe135
  https://github.com/lxc/lxc/commit/d9be3d269433165da879dac87d56f84949fbe135
  Author: Christian Brauner 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M src/lxc/macro.h
M src/lxc/string_utils.h

  Log Message:
  ---
  string_utils: move lxc_iterate_parts()

Signed-off-by: Christian Brauner 


  Commit: 37ac0b481d0f7420b632a7de829a44f7e72e2cb4
  https://github.com/lxc/lxc/commit/37ac0b481d0f7420b632a7de829a44f7e72e2cb4
  Author: Christian Brauner 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
M src/lxc/cgroups/cgroup_utils.c
M src/lxc/cgroups/cgroup_utils.h

  Log Message:
  ---
  cgroups: fix prune_init_scope()

Signed-off-by: Christian Brauner 


  Commit: 0d83967fa39bb2dc72eeb395989e59aa3ae81842
  https://github.com/lxc/lxc/commit/0d83967fa39bb2dc72eeb395989e59aa3ae81842
  Author: Christian Brauner 
  Date:   2021-02-20 (Sat, 20 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: avoid additional variable for single access

Signed-off-by: Christian Brauner 


  Commit: 7a0c8ed32c142f8f5fc34c95c372b09eadaa7587
  https://github.com/lxc/lxc/commit/7a0c8ed32c142f8f5fc34c95c372b09eadaa7587
  Author: Christian Brauner 
  Date:   2021-02-20 (Sat, 20 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: s/must_copy_string()/strdup()/g

Signed-off-by: Christian Brauner 


  Commit: 0fbf99d6005a906805565e521fa28dabbb8ca4a0
  https://github.com/lxc/lxc/commit/0fbf99d6005a906805565e521fa28dabbb8ca4a0
  Author: Christian Brauner 
  Date:   2021-02-20 (Sat, 20 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: tweak lxc.cgroup.use handling in __cgroup_init()

Signed-off-by: Christian Brauner 


  Commit: a96be3c335961f255de4f629cba4bd384b75d39d
  https://github.com/lxc/lxc/commit/a96be3c335961f255de4f629cba4bd384b75d39d
  Author: Christian Brauner 
  Date:   2021-02-20 (Sat, 20 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: tweak return values

Signed-off-by: Christian Brauner 


  Commit: 8033666ce2fec932ef6d7e773c157c5cc54dd4aa
  https://github.com/lxc/lxc/commit/8033666ce2fec932ef6d7e773c157c5cc54dd4aa
  Author: Christian Brauner 
  Date:   2021-02-20 (Sat, 20 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: simplify current cgroup retrieval on pure unified cgroup layouts

Signed-off-by: Christian Brauner 


  Commit: 0eb3b1ceed16bc01267441d1faf3a15c7c168935
  https://github.com/lxc/lxc/commit/0eb3b1ceed16bc01267441d1faf3a15c7c168935
  Author: Christian Brauner 
  Date:   2021-02-20 (Sat, 20 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: s/basecginfo/cgroup_info/g

Signed-off-by: Christian Brauner 


  Commit: 45069107aa81495e96b57156fa49e6afe13f8208
  https://github.com/lxc/lxc/commit/45069107aa81495e96b57156fa49e6afe13f8208
  Author: Christian Brauner 
  Date:   2021-02-20 (Sat, 20 Feb 2021)

  Changed paths:
M src/lxc/compiler.h

  Log Message:
  ---
  compiler: add likely() and unlikely() support

Signed-off-by: Christian Brauner 


  Commit: 844d929d2e92a7b19b1b4f93ea95916284f0a14a
  https://github.com/lxc/lxc/commit/844d929d2e92a7b19b1b4f93ea95916284f0a14a
  Author: Christian Brauner 
  Date:   2021-02-20 (Sat, 20 Feb 2021)

  Changed paths:
M src/lxc/macro.h

  Log Message:
  ---
  macro: add pointer error encoding support

Signed-off-by: Christian Brauner 


  Commit: 6407ddf4dac667258fdc16a71a500bccd211e76e
  https://github.com/lxc/lxc/commit/6407ddf4dac667258fdc16a71a500bccd211e76e
  Author: Christian Brauner 
  Date:   2021-02-20 (Sat, 20 Feb 2021)

  Changed paths:
M src/lxc/memory_utils.h

  Log Message:
  ---
  memory_utils: adapt to new pointer error macros

Signed-off-by: Christian Brauner 


  Commit: 0e3af26b2ff6e9e22b6a8214d8d730a4d16c1f49
  https://github.com/lxc/lxc/commit/0e3af26b2ff6e9e22b6a8214d8d730a4d16c1f49
  Author: Christian Brauner 
  Date:   2021-02-20 (Sat, 20 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: split out unified cgroup helpers

Signed-off-by: Christian Brauner 


  Commit: 35ec1a385a2b0521b522d2c7cc82bfc7ef633e88
  https://github.com/lxc/lxc/commit/35ec1a385a2b0521b522d2c7cc82bfc7ef633e88
  Author: Christian Brauner 
  Date:   2021-02-21 (Sun, 21 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
M src/lxc/cgroups/cgroup_utils.c
M src/lxc/cgroups/cgroup_utils.h

  Log Message:
  ---
  cgroups: rework cgroup initialization

[lxc-devel] [lxc/lxc] fc4612: cgroups: ensure no garbage is returned

2021-02-19 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: fc4612cb398d3091854708a822680a9cc2c60d04
  https://github.com/lxc/lxc/commit/fc4612cb398d3091854708a822680a9cc2c60d04
  Author: Christian Brauner 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: ensure no garbage is returned

Signed-off-by: Christian Brauner 


  Commit: a134099de529d5436a359b109dfdf44e13470451
  https://github.com/lxc/lxc/commit/a134099de529d5436a359b109dfdf44e13470451
  Author: Christian Brauner 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
M src/lxc/commands.c
M src/lxc/conf.c
M src/lxc/conf.h

  Log Message:
  ---
  cgroups: make device cgroup handling smarter and simpler

Signed-off-by: Christian Brauner 


  Commit: 60532b18f4cce4e444c467209ce440a730ab4e01
  https://github.com/lxc/lxc/commit/60532b18f4cce4e444c467209ce440a730ab4e01
  Author: Christian Brauner 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h

  Log Message:
  ---
  commands: only update bpf device program if really needed

Signed-off-by: Christian Brauner 


  Commit: a0f0e9df1d0a2291ae50165f45a2adc3e31b37c2
  https://github.com/lxc/lxc/commit/a0f0e9df1d0a2291ae50165f45a2adc3e31b37c2
  Author: Christian Brauner 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  ---
  bpf: comment bpf_cgroup_devices_update()

Signed-off-by: Christian Brauner 


  Commit: 159702774c56a0e7898570ff0c0673d20c972c96
  https://github.com/lxc/lxc/commit/159702774c56a0e7898570ff0c0673d20c972c96
  Author: Christian Brauner 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h

  Log Message:
  ---
  bpf: fix typos

Signed-off-by: Christian Brauner 


  Commit: d6c06927dff74122f8bd2cc357b828fcc81f8650
  https://github.com/lxc/lxc/commit/d6c06927dff74122f8bd2cc357b828fcc81f8650
  Author: Christian Brauner 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: improve lxc_clear_cgroups()

Signed-off-by: Christian Brauner 


  Commit: a7744f125e65de7a5f70511049b89ecd844bd5e1
  https://github.com/lxc/lxc/commit/a7744f125e65de7a5f70511049b89ecd844bd5e1
  Author: Christian Brauner 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h

  Log Message:
  ---
  conf: expose lxc_clear_cgroup2_devices()

Signed-off-by: Christian Brauner 


  Commit: 30bfbd3ff1638b57949db66060317a0a34d2b838
  https://github.com/lxc/lxc/commit/30bfbd3ff1638b57949db66060317a0a34d2b838
  Author: Christian Brauner 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: tweak bpf_device_cgroup_prepare()

Signed-off-by: Christian Brauner 


  Commit: 0ede37250ceaf602e974cb00ef2563a2308553f4
  https://github.com/lxc/lxc/commit/0ede37250ceaf602e974cb00ef2563a2308553f4
  Author: Christian Brauner 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h

  Log Message:
  ---
  bpf: update device cgroup semantics

LXC has supported the bpf device controlller for a while now. A bpf device
program can be attached to the container's cgroup if this is a pure cgroup2
host.

The format for specifying device rules for the cgroup2 bpf device controller is
the same as for the legacy cgroup device controller; only the configuration key
prefix has to change. Specifically, device rules for the legacy cgroup device
controller are specified by via lxc.cgroup.devices.{allow,deny} whereas for the
cgroup2 bpf device controller lxc.cgroup2.devices.{allow,deny} must be used.

The following semantics apply:
1. The device rule "lxc.cgroup2.devices.deny = a" will cause LXC to instruct
   the kernel to block access to all devices by default. To grant access to
   devices "allow device rules" must be added via the
   "lxc.cgroup2.devices.allow" key. This is referred to as a "allowlist" device
   program.
2. The device rule "lxc.cgroup2.devices.allow = a" will cause LXC to instruct
   the kernel to allow access to all devices by default. To deny access to
   devices "deny device rules" must be added via "lxc.cgroup2.devices.deny"
   key. This is referred to as a "denylist" device program.
3. Specifying a rule as explained in 1. or 2. will cause all previous rules to
   be cleared, i.e. the device list will be reset.

For example the set of rules:

lxc.cgroup2.devices.deny = a

[lxc-devel] [lxc/lxc] 8b145a: file_utils: allow fd_to_buf() to fail for real

2021-02-19 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 8b145a8778f28ed1c0079c008625ce907f77bbbf
  https://github.com/lxc/lxc/commit/8b145a8778f28ed1c0079c008625ce907f77bbbf
  Author: Christian Brauner 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M src/lxc/file_utils.c

  Log Message:
  ---
  file_utils: allow fd_to_buf() to fail for real

Signed-off-by: Christian Brauner 


  Commit: ba9055c96b5088772efb710481378dbc8f90abeb
  https://github.com/lxc/lxc/commit/ba9055c96b5088772efb710481378dbc8f90abeb
  Author: Christian Brauner 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M src/lxc/lsm/apparmor.c

  Log Message:
  ---
  lsm: twek apparmor_process_label_get()

Fixes: Coverity 1473189
Fixes: Coverity 1473190
Fixes: 47f4914d88df ("apparmor: prefer /proc/.../attr/apparmor/current over 
legacy interface")
Signed-off-by: Christian Brauner 


  Commit: 02882d8358f47461fedf3353cf1ae6f617ff6cb3
  https://github.com/lxc/lxc/commit/02882d8358f47461fedf3353cf1ae6f617ff6cb3
  Author: Stéphane Graber 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M src/lxc/file_utils.c
M src/lxc/lsm/apparmor.c

  Log Message:
  ---
  Merge pull request #3687 from brauner/2021-02-19/fixes

lsm: fixes


Compare: https://github.com/lxc/lxc/compare/f43ed6a0ab5a...02882d8358f4
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 301a5f: apparmor: clean up apparmor_process_label_get

2021-02-19 Thread Christian Brauner

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 301a5f8e786c61fb3dcc107a9ae18ae507857895
  https://github.com/lxc/lxc/commit/301a5f8e786c61fb3dcc107a9ae18ae507857895
  Author: Aleksa Sarai 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M src/lxc/lsm/apparmor.c

  Log Message:
  ---
  apparmor: clean up apparmor_process_label_get

Rather than open-coding file reading and retry semantics and
implementing the path generation logic separately to
apparmor_process_label_fd_get, refactor the logic so that it looks
closer to the pidfd version.

This will make it easier to implement the two-step handling for
/proc/self/attr/apparmor/current and makes this code slightly less
confusing.

Signed-off-by: Aleksa Sarai 


  Commit: 47f4914d88dfb8d8b2207c955c37af347032444d
  https://github.com/lxc/lxc/commit/47f4914d88dfb8d8b2207c955c37af347032444d
  Author: Aleksa Sarai 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M src/lxc/lsm/apparmor.c
M src/lxc/macro.h

  Log Message:
  ---
  apparmor: prefer /proc/.../attr/apparmor/current over legacy interface

It turns out that since Linux 5.1 there are now per-LSM subdirectories
for major LSMs, which users are recommended to use over the "legacy"
top-level /proc/$pid/attr/... files[1]:

> Process attributes associated with “major” security modules should be
> accessed and maintained using the special files in /proc/.../attr. A
> security module may maintain a module specific subdirectory there,
> named after the module. /proc/.../attr/smack is provided by the Smack
> security module and contains all its special files. The files directly
> in /proc/.../attr remain as legacy interfaces for modules that provide
> subdirectories.

AppArmor has had such a directory since Linux 5.8[2], and it turns out
that with certain CONFIG_LSM configurations you can end up with AppArmor
files not being accessible from the legacy interface. Arch Linux
recently added BPF as one of the enabled LSM in their configuration, and
this broke runc[3] and LXC.

The solution is to first try to use /proc/$pid/attr/apparmor/current and
fall back to /proc/$pid/attr/current if the former is not available.

[1]: https://www.kernel.org/doc/html/latest/admin-guide/LSM/index.html
[2]: Linux 5.8 ; commit 6413f852ce08 ("apparmor: add proc subdir to attrs")
[3]: https://github.com/opencontainers/runc/issues/2801

Signed-off-by: Aleksa Sarai 


  Commit: f43ed6a0ab5a2b3658cebf6f4360a0fb76aeec52
  https://github.com/lxc/lxc/commit/f43ed6a0ab5a2b3658cebf6f4360a0fb76aeec52
  Author: Christian Brauner 
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
M src/lxc/lsm/apparmor.c
M src/lxc/macro.h

  Log Message:
  ---
  Merge pull request #3686 from cyphar/apparmor-attr-subdir

apparmor: prefer /proc/.../attr/apparmor/current over legacy interface


Compare: https://github.com/lxc/lxc/compare/35a68d6df2c2...f43ed6a0ab5a
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] bd09ee: cgroups: make it extremely obvious that we're tran...

2021-02-18 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: bd09ee987dce37f6204a35bb0c147438351b1cfd
  https://github.com/lxc/lxc/commit/bd09ee987dce37f6204a35bb0c147438351b1cfd
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: make it extremely obvious that we're transitioning from a flag to a 
type

Signed-off-by: Christian Brauner 


  Commit: 2c4348bd1c3b4ce2c44d255a41b2ad9da6b3c62c
  https://github.com/lxc/lxc/commit/2c4348bd1c3b4ce2c44d255a41b2ad9da6b3c62c
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: don't overwrite type

Signed-off-by: Christian Brauner 


  Commit: bce04069bc1523e6ac7d99a8fc7f0747b57e9055
  https://github.com/lxc/lxc/commit/bce04069bc1523e6ac7d99a8fc7f0747b57e9055
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: fix error values

Signed-off-by: Christian Brauner 


  Commit: 05fe99f3a97d12ddf546af4bb2b19cbe60e28216
  https://github.com/lxc/lxc/commit/05fe99f3a97d12ddf546af4bb2b19cbe60e28216
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/utils.c

  Log Message:
  ---
  utils: fix print_r() debugging helper

Signed-off-by: Christian Brauner 


  Commit: 11e5c6783e0a1dc40f606e492c169b75c696ae1d
  https://github.com/lxc/lxc/commit/11e5c6783e0a1dc40f606e492c169b75c696ae1d
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgroup.c

  Log Message:
  ---
  cgroups: free correct path

Signed-off-by: Christian Brauner 


  Commit: 7064ee3a922174499dfc65f812cba4de8ea47b0a
  https://github.com/lxc/lxc/commit/7064ee3a922174499dfc65f812cba4de8ea47b0a
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h

  Log Message:
  ---
  cgroups: kill monitor_full_path

Signed-off-by: Christian Brauner 


  Commit: 7c37e93740f684b6ec3300ecc99905f0c6eb87e7
  https://github.com/lxc/lxc/commit/7c37e93740f684b6ec3300ecc99905f0c6eb87e7
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
M src/lxc/commands.c

  Log Message:
  ---
  bpf: use cgroup fd directly instead of paths

Signed-off-by: Christian Brauner 


  Commit: 4b9dc703d2d0a62a475ed664b7d45ea8ab31a652
  https://github.com/lxc/lxc/commit/4b9dc703d2d0a62a475ed664b7d45ea8ab31a652
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/conf.h

  Log Message:
  ---
  conf: introduce lxc_bpf_devices_rule_t type

Signed-off-by: Christian Brauner 


  Commit: bee6ee17b0c7bf48f277137944d4581e27783f12
  https://github.com/lxc/lxc/commit/bee6ee17b0c7bf48f277137944d4581e27783f12
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgroup2_devices.h

  Log Message:
  ---
  bpf: use return macros

Signed-off-by: Christian Brauner 


  Commit: 8828c61a8b201405e1c3a6ba5a9fc1d14f8a
  https://github.com/lxc/lxc/commit/8828c61a8b201405e1c3a6ba5a9fc1d14f8a
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  ---
  bpf: align struct initialization

Signed-off-by: Christian Brauner 


  Commit: 0d450efcf25c2568075bad9651f5aabdf3df2b17
  https://github.com/lxc/lxc/commit/0d450efcf25c2568075bad9651f5aabdf3df2b17
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
M src/lxc/commands.c

  Log Message:
  ---
  bpf: enable helpers to let caller replace existing bpf programs

Signed-off-by: Christian Brauner 


  Commit: 69885a7656802c2698183d5b1017c6b93c1f8e6a
  https://github.com/lxc/lxc/commit/69885a7656802c2698183d5b1017c6b93c1f8e6a
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: make device cgroups semantics clearer

Signed-off-by: Christian Brauner 


  Commit: e41afad55e20327b6fbad77fa531cd90175da3eb
  https://github.com/lxc/lxc/commit/e41afad55e20327b6fbad77fa531cd90175da3eb
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: improve bpf device program handling

Signed-off-by: Christian Brauner 


  Commit:

[lxc-devel] [lxc/lxc] 1dd71c: conf: use saner mode for console

2021-02-18 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 1dd71c90e807bc730415eb40b51c3bea19d298a9
  https://github.com/lxc/lxc/commit/1dd71c90e807bc730415eb40b51c3bea19d298a9
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: use saner mode for console

Signed-off-by: Christian Brauner 


  Commit: f3dff0805496ed131c65a2a7abb337306dd0cf1b
  https://github.com/lxc/lxc/commit/f3dff0805496ed131c65a2a7abb337306dd0cf1b
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/start.c

  Log Message:
  ---
  start: fix non-daemonized and application containers

Signed-off-by: Christian Brauner 


  Commit: f640c8187aac72d303d2edbdc25d7b1082e330e7
  https://github.com/lxc/lxc/commit/f640c8187aac72d303d2edbdc25d7b1082e330e7
  Author: Christian Brauner 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: don't log garbage

Signed-off-by: Christian Brauner 


  Commit: 599a0c6c9ccba374dcf646175792873185246dc7
  https://github.com/lxc/lxc/commit/599a0c6c9ccba374dcf646175792873185246dc7
  Author: Stéphane Graber 
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/start.c

  Log Message:
  ---
  Merge pull request #3682 from brauner/2021-02-18/fixes

console: fixes


Compare: https://github.com/lxc/lxc/compare/cca7d405fe44...599a0c6c9ccb
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] e20353: cgroups: log intermediate cleanup

2021-02-17 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: e203535895db90103f70b9ff4942139011cd67d8
  https://github.com/lxc/lxc/commit/e203535895db90103f70b9ff4942139011cd67d8
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: log intermediate cleanup

Signed-off-by: Christian Brauner 


  Commit: 9bca62b30546d6713493119c76c7676f19810f62
  https://github.com/lxc/lxc/commit/9bca62b30546d6713493119c76c7676f19810f62
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: distinguish between tmpfs and unified based cgroup layouts file 
descriptors

Signed-off-by: Christian Brauner 


  Commit: f1921f351e8c399461bd0c52b2eedd10c1d43c4f
  https://github.com/lxc/lxc/commit/f1921f351e8c399461bd0c52b2eedd10c1d43c4f
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: ensure that cgroup_root is initialized in legacy codepaths

Signed-off-by: Christian Brauner 


  Commit: 8186eb8e8a09d4d1c6b4902286a54cfcb1fb3edd
  https://github.com/lxc/lxc/commit/8186eb8e8a09d4d1c6b4902286a54cfcb1fb3edd
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: prevent cgroup mount type overwrite

Signed-off-by: Christian Brauner 


  Commit: 69c296739dbe07a34ebbb9af9f16f9aab783c203
  https://github.com/lxc/lxc/commit/69c296739dbe07a34ebbb9af9f16f9aab783c203
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: validate that only a single cgroup mount type is set

Signed-off-by: Christian Brauner 


  Commit: 9394b6dc976985f377160b5cec67def96a1642fd
  https://github.com/lxc/lxc/commit/9394b6dc976985f377160b5cec67def96a1642fd
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: use brackets to clarify check semantics

Signed-off-by: Christian Brauner 


  Commit: 51feb8dbb78ef1532dd01bdd7088abf5376191f1
  https://github.com/lxc/lxc/commit/51feb8dbb78ef1532dd01bdd7088abf5376191f1
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: use non-flag based checking now that we switched all codepaths over

Signed-off-by: Christian Brauner 


  Commit: 77410c983cc680db0baec2abc80235754e13ba6f
  https://github.com/lxc/lxc/commit/77410c983cc680db0baec2abc80235754e13ba6f
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: create controller directories if missing

Signed-off-by: Christian Brauner 


  Commit: cca7d405fe44c755533891dd27d3d273becd419b
  https://github.com/lxc/lxc/commit/cca7d405fe44c755533891dd27d3d273becd419b
  Author: Stéphane Graber 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/conf.c

  Log Message:
  ---
  Merge pull request #3680 from brauner/2021-02-17/cgroups_2

cgroups: fourth batch of cgroup fixes


Compare: https://github.com/lxc/lxc/compare/b3ad27fb434f...cca7d405fe44
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 6fec43: cgroups: reorder function arguments

2021-02-17 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 6fec43278ec4da59cb9879bcba4ce92dea6f9a9c
  https://github.com/lxc/lxc/commit/6fec43278ec4da59cb9879bcba4ce92dea6f9a9c
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: reorder function arguments

Signed-off-by: Christian Brauner 


  Commit: 2291719e82e484d05cfc1b87984ab48e8fd2eb13
  https://github.com/lxc/lxc/commit/2291719e82e484d05cfc1b87984ab48e8fd2eb13
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: remove obsolote check

In the new layout we don't need to do this.

Signed-off-by: Christian Brauner 


  Commit: cb423bd38bbabac97967d0a63020061507cb20cc
  https://github.com/lxc/lxc/commit/cb423bd38bbabac97967d0a63020061507cb20cc
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: rework cgroup tree removal on creation failure

Signed-off-by: Christian Brauner 


  Commit: 6c880cdfa1d3be358c4ab04f6346c21213bbca9a
  https://github.com/lxc/lxc/commit/6c880cdfa1d3be358c4ab04f6346c21213bbca9a
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: ensure leaf cgroup is correctly pruned on creation failure

Signed-off-by: Christian Brauner 


  Commit: a6aeb9f1b927ce314c589e5b0db2cb4eb15aef6f
  https://github.com/lxc/lxc/commit/a6aeb9f1b927ce314c589e5b0db2cb4eb15aef6f
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: rework cgroup tree creation

Signed-off-by: Christian Brauner 


  Commit: 471929c6d0dcbaeaa7748b54b7b0630887002ba6
  https://github.com/lxc/lxc/commit/471929c6d0dcbaeaa7748b54b7b0630887002ba6
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: be stricter when creating payloads

Signed-off-by: Christian Brauner 


  Commit: 1e05885505522049a51bd9e26680607d321d892e
  https://github.com/lxc/lxc/commit/1e05885505522049a51bd9e26680607d321d892e
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: don't rely on absolute path

Signed-off-by: Christian Brauner 


  Commit: 57abfbb640d7ccde951941c960ef383a2c183f27
  https://github.com/lxc/lxc/commit/57abfbb640d7ccde951941c960ef383a2c183f27
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: don't move pivot cgroup under the monitor's cgroup

Otherwise we will never be able to destroy the monitor's cgroup.

Signed-off-by: Christian Brauner 


  Commit: c1ece8951856dd5357e31df9ec38bd7e3c46f624
  https://github.com/lxc/lxc/commit/c1ece8951856dd5357e31df9ec38bd7e3c46f624
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: ensure we don't remove cgroups we didn't create

Signed-off-by: Christian Brauner 


  Commit: 9981107f554d0cb2213adafb098c17038907bca5
  https://github.com/lxc/lxc/commit/9981107f554d0cb2213adafb098c17038907bca5
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: ensure we prune the limit dir

Signed-off-by: Christian Brauner 


  Commit: 8f45c49bb1ba70e2eb1af2e64f10df853c4c22bf
  https://github.com/lxc/lxc/commit/8f45c49bb1ba70e2eb1af2e64f10df853c4c22bf
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: simplify mount opening

Signed-off-by: Christian Brauner 


  Commit: 0954f6cec901759673357d1bea48f5cb6dede5b1
  https://github.com/lxc/lxc/commit/0954f6cec901759673357d1bea48f5cb6dede5b1
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: prevent NULL pointer deref

Signed-off-by: Christian Brauner 


  Commit: b3ad27fb434f29ad293ab24f2b3833c2db756b44
  https://github.com/lxc/lxc/commit/b3ad27fb434f29ad293ab24f2b3833c2db756b44
  Author: Stéphane Graber 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  Merge pull request #3679 from brauner/2021-02-17/cgroups

cgroups: third batch of cgroup fixes


Compare: https://github.com/lxc/lxc/compare/e82bb1b36086...b3ad27fb434f

[lxc-devel] [lxc/lxc] e219f8: cgroups: s/openat()/open_at()/g

2021-02-16 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: e219f8e885d129fca3ce6da067f5f017aa8a61db
  https://github.com/lxc/lxc/commit/e219f8e885d129fca3ce6da067f5f017aa8a61db
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: s/openat()/open_at()/g

Signed-off-by: Christian Brauner 


  Commit: e4db08ed3e70f83eea681fbaa2af168a8a690aa6
  https://github.com/lxc/lxc/commit/e4db08ed3e70f83eea681fbaa2af168a8a690aa6
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: check correct variable

Signed-off-by: Christian Brauner 


  Commit: 95ab26aff7230ea5e2d1eff584e429499110ef93
  https://github.com/lxc/lxc/commit/95ab26aff7230ea5e2d1eff584e429499110ef93
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: rework unified controller delegation

Signed-off-by: Christian Brauner 


  Commit: 838d155694526ed2da3260f4255b10ccb5d85a46
  https://github.com/lxc/lxc/commit/838d155694526ed2da3260f4255b10ccb5d85a46
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  start: delegate than move into the target cgroup

This is a way more sensible model.

Signed-off-by: Christian Brauner 


  Commit: e82bb1b360897667a7d65fd32c15adeade7c
  https://github.com/lxc/lxc/commit/e82bb1b360897667a7d65fd32c15adeade7c
  Author: Stéphane Graber 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/start.c

  Log Message:
  ---
  Merge pull request #3678 from brauner/2021-02-17/unified_controller_delegation

cgroups: rework unified cgroup controller delegation


Compare: https://github.com/lxc/lxc/compare/69632022417a...e82bb1b36086
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] ba559a: namespace: add missing \0 terminator

2021-02-16 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: ba559a5b19256b0dfb4822fd04d840f4e90a279d
  https://github.com/lxc/lxc/commit/ba559a5b19256b0dfb4822fd04d840f4e90a279d
  Author: Christian Brauner 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/namespace.h

  Log Message:
  ---
  namespace: add missing \0 terminator

Link: 
https://launchpadlibrarian.net/523195972/buildlog_ubuntu-groovy-ppc64el.lxc_1%3A4.0.6+master~20210215-1740-0ubuntu1~groovy_BUILDING.txt.gz
Signed-off-by: Christian Brauner 


  Commit: 701be30e1427e72d6646329c2a514fb43a1cd8af
  https://github.com/lxc/lxc/commit/701be30e1427e72d6646329c2a514fb43a1cd8af
  Author: Christian Brauner 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: prevent double-close

Fixes: Coverity 1473183
Signed-off-by: Christian Brauner 


  Commit: a218be90f5a6f5453d87d3c9ee2d9d1e9fd2d0f6
  https://github.com/lxc/lxc/commit/a218be90f5a6f5453d87d3c9ee2d9d1e9fd2d0f6
  Author: Stéphane Graber 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/namespace.h

  Log Message:
  ---
  Merge pull request #3676 from brauner/2021-02-16/fixes

cgroups: fixes


Compare: https://github.com/lxc/lxc/compare/858f62255d92...a218be90f5a6
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 634777: file_utils: move dup_cloexec() to header

2021-02-16 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 6347774b4c20e0bc7b840053c148aec247653a8e
  https://github.com/lxc/lxc/commit/6347774b4c20e0bc7b840053c148aec247653a8e
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/file_utils.c
M src/lxc/file_utils.h

  Log Message:
  ---
  file_utils: move dup_cloexec() to header

Signed-off-by: Christian Brauner 


  Commit: c55fe36d28129391f231ae9aeef7cd3b4db31b0e
  https://github.com/lxc/lxc/commit/c55fe36d28129391f231ae9aeef7cd3b4db31b0e
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
M src/lxc/cgroups/cgroup_utils.c
M src/lxc/cgroups/cgroup_utils.h
M src/lxc/file_utils.h

  Log Message:
  ---
  cgroups: fd-only cgroup tree pruning

Signed-off-by: Christian Brauner 


  Commit: dcf6a5c7c664f4b29dac1bd6345c915e31d378c1
  https://github.com/lxc/lxc/commit/dcf6a5c7c664f4b29dac1bd6345c915e31d378c1
  Author: Christian Brauner 
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: remove obsolote cgroup_tree handling

Signed-off-by: Christian Brauner 


  Commit: 69632022417ae9f1474e594dec7da8dcaffb017e
  https://github.com/lxc/lxc/commit/69632022417ae9f1474e594dec7da8dcaffb017e
  Author: Stéphane Graber 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
M src/lxc/cgroups/cgroup_utils.c
M src/lxc/cgroups/cgroup_utils.h
M src/lxc/file_utils.c
M src/lxc/file_utils.h

  Log Message:
  ---
  Merge pull request #3677 from brauner/2021-02-17/cgroup_pruning

cgroups: fd-only cgroup tree pruning


Compare: https://github.com/lxc/lxc/compare/a218be90f5a6...69632022417a
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 7414bc: cgroups: s/cg_init()/__cgroup_init()/g

2021-02-16 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 7414bc72c3eec9a9e77799eccad71bcacd6a03f2
  https://github.com/lxc/lxc/commit/7414bc72c3eec9a9e77799eccad71bcacd6a03f2
  Author: Christian Brauner 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: s/cg_init()/__cgroup_init()/g

Signed-off-by: Christian Brauner 


  Commit: d4cff3525dfc9c5407893918361d493e7f2a9a37
  https://github.com/lxc/lxc/commit/d4cff3525dfc9c5407893918361d493e7f2a9a37
  Author: Christian Brauner 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
M src/lxc/cgroups/cgroup_utils.c
M src/lxc/cgroups/cgroup_utils.h

  Log Message:
  ---
  cgroups: stash host's cgroupfs file descriptor

Signed-off-by: Christian Brauner 


  Commit: 008ccca920fc0e5162620b444933d8dbfddc40ed
  https://github.com/lxc/lxc/commit/008ccca920fc0e5162620b444933d8dbfddc40ed
  Author: Christian Brauner 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgroup.h

  Log Message:
  ---
  cgroups: better document stashed file descriptors

Signed-off-by: Christian Brauner 


  Commit: c72e7cb584a1ed011ff4808cb4b782f7f6f1f31d
  https://github.com/lxc/lxc/commit/c72e7cb584a1ed011ff4808cb4b782f7f6f1f31d
  Author: Christian Brauner 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: rework add_hierarchy()

Signed-off-by: Christian Brauner 


  Commit: 600a016384af297d96a70018cbc159a40247f618
  https://github.com/lxc/lxc/commit/600a016384af297d96a70018cbc159a40247f618
  Author: Christian Brauner 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
M src/lxc/string_utils.h

  Log Message:
  ---
  cgroups: rework base cgroup parsing

Signed-off-by: Christian Brauner 


  Commit: 5c7b81439cecfbd885b3c10f9edfefdc1ac7c45b
  https://github.com/lxc/lxc/commit/5c7b81439cecfbd885b3c10f9edfefdc1ac7c45b
  Author: Christian Brauner 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c

  Log Message:
  ---
  cgroups: fail when no cgroup hierarchies are found

Signed-off-by: Christian Brauner 


  Commit: 3486d9935a531be98d7f6006f6166552d20eeb94
  https://github.com/lxc/lxc/commit/3486d9935a531be98d7f6006f6166552d20eeb94
  Author: Christian Brauner 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h

  Log Message:
  ---
  cgroups: stash fds for the controller mountpoint and base cgroup path

Signed-off-by: Christian Brauner 


  Commit: da42ac7b4b49f492da714bdabdc8032117396aa2
  https://github.com/lxc/lxc/commit/da42ac7b4b49f492da714bdabdc8032117396aa2
  Author: Christian Brauner 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/file_utils.c
M src/lxc/log.h

  Log Message:
  ---
  cgroups: fd-based only cgroup creation

Signed-off-by: Christian Brauner 


  Commit: 033267c93a50b1162976c26d611d8ae5cd4f9849
  https://github.com/lxc/lxc/commit/033267c93a50b1162976c26d611d8ae5cd4f9849
  Author: Christian Brauner 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/file_utils.c

  Log Message:
  ---
  cgroups: rework legacy cpuset handling

Signed-off-by: Christian Brauner 


  Commit: 088db01b85d45f1e873fd549c5ecc6508c6eed7d
  https://github.com/lxc/lxc/commit/088db01b85d45f1e873fd549c5ecc6508c6eed7d
  Author: Christian Brauner 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: improve logging

Signed-off-by: Christian Brauner 


  Commit: 192812516e2faef3ee0846c0ba706a7828451f52
  https://github.com/lxc/lxc/commit/192812516e2faef3ee0846c0ba706a7828451f52
  Author: Christian Brauner 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/string_utils.c

  Log Message:
  ---
  string_utils: handle empty strings in must_make_path()

Signed-off-by: Christian Brauner 


  Commit: f5b049452ee4aa85729ce5bb5441d7930fbe0096
  https://github.com/lxc/lxc/commit/f5b049452ee4aa85729ce5bb5441d7930fbe0096
  Author: Christian Brauner 
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: allow "" base cgroup paths

Signed-off-by: Christian Brauner 


  Commit: c426abeaa940bfbdb6df0560d7924050cd9c7ae8
  https://github.com/lxc/lxc/commit/c426abeaa940bfbdb6df0560d7924050cd9c7ae8
  Author: Christian Brauner 
  Date:   2021-02-16 (Tue, 16 Feb

[lxc-devel] [lxc/lxc] ee94a8: confile: use set_config_path_item() for most cgrou...

2021-02-15 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: ee94a8b5cfbb388e5e8b43c7fe8f2cf12989e20c
  https://github.com/lxc/lxc/commit/ee94a8b5cfbb388e5e8b43c7fe8f2cf12989e20c
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: use set_config_path_item() for most cgroup layout modifiers

Signed-off-by: Christian Brauner 


  Commit: 7d714159a3e055c384238ad68211bcea9aad338b
  https://github.com/lxc/lxc/commit/7d714159a3e055c384238ad68211bcea9aad338b
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  confile_utils: normalize paths in config items

Signed-off-by: Christian Brauner 


  Commit: 0a48ee66c6e982657584a7df7ddc621d1fed9487
  https://github.com/lxc/lxc/commit/0a48ee66c6e982657584a7df7ddc621d1fed9487
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/log.h
M src/lxc/string_utils.h

  Log Message:
  ---
  confile: forbid walking upwards for confile items that modify cgroup layout

Signed-off-by: Christian Brauner 


  Commit: f63ef155271b2848ae18fcdfb5550dddad9ec852
  https://github.com/lxc/lxc/commit/f63ef155271b2848ae18fcdfb5550dddad9ec852
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/string_utils.h

  Log Message:
  ---
  confile: forbid absolute paths in config items that modify the cgroup layout

This is not a safety measure but merely is supposed to raise awareness that
these paths are always relative to the cgroup root as determined by
lxc.cgroup.relative.

Signed-off-by: Christian Brauner 


  Commit: 136b349c94dbc573ebfe762cde4f4b91faf8f428
  https://github.com/lxc/lxc/commit/136b349c94dbc573ebfe762cde4f4b91faf8f428
  Author: Stéphane Graber 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/confile.c
M src/lxc/confile_utils.c
M src/lxc/log.h
M src/lxc/string_utils.h

  Log Message:
  ---
  Merge pull request #3674 from brauner/2021-02-15/nesting

cgroups: tighten cgroup config items


Compare: https://github.com/lxc/lxc/compare/7e925736c911...136b349c94db
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] c988c8: cgroups: move cgns_supported() to cgroup utilities

2021-02-15 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: c988c8b1ceb45c8104af501961468a7b8b1d92cd
  https://github.com/lxc/lxc/commit/c988c8b1ceb45c8104af501961468a7b8b1d92cd
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/cgroups/cgroup_utils.h
M src/lxc/lsm/apparmor.c
M src/lxc/start.c
M src/lxc/utils.c
M src/lxc/utils.h
M src/tests/lxc_raw_clone.c

  Log Message:
  ---
  cgroups: move cgns_supported() to cgroup utilities

Signed-off-by: Christian Brauner 


  Commit: 6d25a524d8133bced20e0a8e8bfb0f2b42155d70
  https://github.com/lxc/lxc/commit/6d25a524d8133bced20e0a8e8bfb0f2b42155d70
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: don't pass conf separately to lxc_mount_auto_mounts()

Signed-off-by: Christian Brauner 


  Commit: ab8cd5d9e2841cb632e64b1680fdef03c9c4e112
  https://github.com/lxc/lxc/commit/ab8cd5d9e2841cb632e64b1680fdef03c9c4e112
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/conf.c

  Log Message:
  ---
  cgroups: pass handler to cgroup mount() method

Signed-off-by: Christian Brauner 


  Commit: 937a3af94e48b8f38ec0e717af456d4f11b7b9cc
  https://github.com/lxc/lxc/commit/937a3af94e48b8f38ec0e717af456d4f11b7b9cc
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/start.h

  Log Message:
  ---
  cgroups: verify that we are actually running in cgroup namespace

Signed-off-by: Christian Brauner 


  Commit: e7e45fdffc6158974af96749aac04257790b65d8
  https://github.com/lxc/lxc/commit/e7e45fdffc6158974af96749aac04257790b65d8
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/log.h

  Log Message:
  ---
  cgroups: improve cgroup mounting

Signed-off-by: Christian Brauner 


  Commit: 8cdbef77df69c0a4b7e6c351b7ba47ce06add3b1
  https://github.com/lxc/lxc/commit/8cdbef77df69c0a4b7e6c351b7ba47ce06add3b1
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/utils.c
M src/lxc/utils.h

  Log Message:
  ---
  utils: add development helper to quickly dump a directories contents

Signed-off-by: Christian Brauner 


  Commit: cdd3b77d0ca6d32cd61e1149769673fb752965eb
  https://github.com/lxc/lxc/commit/cdd3b77d0ca6d32cd61e1149769673fb752965eb
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: make clear that a flag argument is passed to cgroup mount functions

Signed-off-by: Christian Brauner 


  Commit: 68599aab1055b27f3c29246f93c24ee32db44436
  https://github.com/lxc/lxc/commit/68599aab1055b27f3c29246f93c24ee32db44436
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: don't strip LXC_AUTO_CGROUP_FORCE

Signed-off-by: Christian Brauner 


  Commit: c581c8a365ea946570b7a8d9efbaf742855958f5
  https://github.com/lxc/lxc/commit/c581c8a365ea946570b7a8d9efbaf742855958f5
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: switch to flag-based checking

Signed-off-by: Christian Brauner 


  Commit: 6cc501f3e08c45aa6d5d99b6dc485aa65801c86a
  https://github.com/lxc/lxc/commit/6cc501f3e08c45aa6d5d99b6dc485aa65801c86a
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/conf.h

  Log Message:
  ---
  conf: remove wrong comment

Signed-off-by: Christian Brauner 


  Commit: 074af8903c5a2e6737be72403ae4dec310900ac0
  https://github.com/lxc/lxc/commit/074af8903c5a2e6737be72403ae4dec310900ac0
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: s/cg_mount_in_cgroup_namespace()/cgroupfs_mount()/g

Signed-off-by: Christian Brauner 


  Commit: 1411165033c4085c3ed1c1fef4657532ebf0821f
  https://github.com/lxc/lxc/commit/1411165033c4085c3ed1c1fef4657532ebf0821f
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: s/cg_mount_cgroup_full()/cgroupfs_bind_mount()/g

Signed-off-by: Christian Brauner 


  Commit: 80262447c9133c98f0c355ebb69112091e89ef95
  https://github.com/lxc/lxc/commit/80262447c9133c98f0c355ebb69112091e89ef95
  Author: Christian Brauner 
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
M

[lxc-devel] [lxc/lxc] cb3b01: start: fix error handling and improve comment

2021-02-14 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: cb3b010c168459055c6778ab46c832a178cd4260
  https://github.com/lxc/lxc/commit/cb3b010c168459055c6778ab46c832a178cd4260
  Author: Christian Brauner 
  Date:   2021-02-14 (Sun, 14 Feb 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  start: fix error handling and improve comment

Signed-off-by: Christian Brauner 


  Commit: 857ba1f0c595d4ac42e2f0ac37ce6f2d691dedea
  https://github.com/lxc/lxc/commit/857ba1f0c595d4ac42e2f0ac37ce6f2d691dedea
  Author: Christian Brauner 
  Date:   2021-02-14 (Sun, 14 Feb 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  start: improve namespace preservation

Signed-off-by: Christian Brauner 


  Commit: 9beaca55d7712d1ee0b88cea3a3df65994b4
  https://github.com/lxc/lxc/commit/9beaca55d7712d1ee0b88cea3a3df65994b4
  Author: Christian Brauner 
  Date:   2021-02-14 (Sun, 14 Feb 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  start: improve comments

Signed-off-by: Christian Brauner 


  Commit: 3a89b0ab0a26e7651d6132522f61b7bfbc5e68fe
  https://github.com/lxc/lxc/commit/3a89b0ab0a26e7651d6132522f61b7bfbc5e68fe
  Author: Christian Brauner 
  Date:   2021-02-14 (Sun, 14 Feb 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  start: improve comment in lxc_spawn()

Signed-off-by: Christian Brauner 


  Commit: 245066afbc64622cebeb93270bcda067d2d74e20
  https://github.com/lxc/lxc/commit/245066afbc64622cebeb93270bcda067d2d74e20
  Author: Christian Brauner 
  Date:   2021-02-14 (Sun, 14 Feb 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  start: fix comment about time namespace preservation

Signed-off-by: Christian Brauner 


  Commit: 4b9467975c2132afe52ab30101588b64830f8e6e
  https://github.com/lxc/lxc/commit/4b9467975c2132afe52ab30101588b64830f8e6e
  Author: Stéphane Graber 
  Date:   2021-02-14 (Sun, 14 Feb 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  Merge pull request #3672 from brauner/2021-02-14/fixes

start: small fixes


Compare: https://github.com/lxc/lxc/compare/5fd096830447...4b9467975c21
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] e8c433: attach: convert to strequal()

2021-02-13 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: e8c43357563bc493df281676a7fcb75458e82a83
  https://github.com/lxc/lxc/commit/e8c43357563bc493df281676a7fcb75458e82a83
  Author: Christian Brauner 
  Date:   2021-02-13 (Sat, 13 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: convert to strequal()

Signed-off-by: Christian Brauner 


  Commit: 8b99a20a184bc50b34a2d3812568560bda6757e8
  https://github.com/lxc/lxc/commit/8b99a20a184bc50b34a2d3812568560bda6757e8
  Author: Christian Brauner 
  Date:   2021-02-13 (Sat, 13 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  ---
  cgroups: convert to strequal()

Signed-off-by: Christian Brauner 


  Commit: 715287420e4f6616acce0509312a03fb667527f4
  https://github.com/lxc/lxc/commit/715287420e4f6616acce0509312a03fb667527f4
  Author: Christian Brauner 
  Date:   2021-02-13 (Sat, 13 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: convert to strequal()

Signed-off-by: Christian Brauner 


  Commit: d62177e99a5cc8a045d677a7e32d2f1eb863350f
  https://github.com/lxc/lxc/commit/d62177e99a5cc8a045d677a7e32d2f1eb863350f
  Author: Christian Brauner 
  Date:   2021-02-13 (Sat, 13 Feb 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: convert to strequal()

Signed-off-by: Christian Brauner 


  Commit: 676cd75cdd4729d4105103ad5a2e767a7164d3d6
  https://github.com/lxc/lxc/commit/676cd75cdd4729d4105103ad5a2e767a7164d3d6
  Author: Christian Brauner 
  Date:   2021-02-13 (Sat, 13 Feb 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  confile_utils: convert to strequal()

Signed-off-by: Christian Brauner 


  Commit: 066af2cbef1f4679d1693b67a582491278e2cebe
  https://github.com/lxc/lxc/commit/066af2cbef1f4679d1693b67a582491278e2cebe
  Author: Christian Brauner 
  Date:   2021-02-13 (Sat, 13 Feb 2021)

  Changed paths:
M src/lxc/criu.c

  Log Message:
  ---
  criu: convert to strequal()

Signed-off-by: Christian Brauner 


  Commit: 32ec743a3e78901fac7b150e2f03e5ae6c626fa4
  https://github.com/lxc/lxc/commit/32ec743a3e78901fac7b150e2f03e5ae6c626fa4
  Author: Christian Brauner 
  Date:   2021-02-13 (Sat, 13 Feb 2021)

  Changed paths:
M src/lxc/initutils.c

  Log Message:
  ---
  initutils: convert to strequal()

Signed-off-by: Christian Brauner 


  Commit: c72ad27f4ab7a78433c61a9042955fde6f852c2e
  https://github.com/lxc/lxc/commit/c72ad27f4ab7a78433c61a9042955fde6f852c2e
  Author: Christian Brauner 
  Date:   2021-02-13 (Sat, 13 Feb 2021)

  Changed paths:
M src/lxc/log.c

  Log Message:
  ---
  log: convert to strequal()

Signed-off-by: Christian Brauner 


  Commit: 644bbdbceadb112878a8f4714ba14dd9c61b7eb1
  https://github.com/lxc/lxc/commit/644bbdbceadb112878a8f4714ba14dd9c61b7eb1
  Author: Christian Brauner 
  Date:   2021-02-13 (Sat, 13 Feb 2021)

  Changed paths:
M src/lxc/lsm/apparmor.c
M src/lxc/lsm/selinux.c

  Log Message:
  ---
  lsm: convert to strequal()

Signed-off-by: Christian Brauner 


  Commit: 62dcc033f29dc56c633222be4de9745688155a7d
  https://github.com/lxc/lxc/commit/62dcc033f29dc56c633222be4de9745688155a7d
  Author: Christian Brauner 
  Date:   2021-02-13 (Sat, 13 Feb 2021)

  Changed paths:
M src/lxc/lxccontainer.c

  Log Message:
  ---
  lxccontainer: convert to strequal()

Signed-off-by: Christian Brauner 


  Commit: 6ee997a743ac197e193449381b04099a96387e78
  https://github.com/lxc/lxc/commit/6ee997a743ac197e193449381b04099a96387e78
  Author: Christian Brauner 
  Date:   2021-02-13 (Sat, 13 Feb 2021)

  Changed paths:
M src/lxc/network.c

  Log Message:
  ---
  network: convert to strequal()

Signed-off-by: Christian Brauner 


  Commit: dc2c2622a2f8a898ef935bba3f5509d7a10303e7
  https://github.com/lxc/lxc/commit/dc2c2622a2f8a898ef935bba3f5509d7a10303e7
  Author: Christian Brauner 
  Date:   2021-02-13 (Sat, 13 Feb 2021)

  Changed paths:
M src/lxc/seccomp.c

  Log Message:
  ---
  seccomp: convert to strequal()

Signed-off-by: Christian Brauner 


  Commit: c92bfdb06537301e74bfd23e30c30d7d37b2bdbe
  https://github.com/lxc/lxc/commit/c92bfdb06537301e74bfd23e30c30d7d37b2bdbe
  Author: Christian Brauner 
  Date:   2021-02-13 (Sat, 13 Feb 2021)

  Changed paths:
M src/lxc/namespace.c

  Log Message:
  ---
  namespace: convert to strequal()

Signed-off-by: Christian Brauner 


  Commit: d0269705d2e347bc678a2a97197023ca1c77b540
  https://github.com/lxc/lxc/commit/d0269705d2e347bc678a2a97197023ca1c77b540
  Author: Christian Brauner 
  Date:   2021-02-13 (Sat, 13 Feb 2021)

  Changed paths:
M src/lxc/start.c

  Log Message:
  ---
  start: convert to strequal()

Signed-off-by: Christian Brauner 


  Commit:

[lxc-devel] [lxc/lxc] 1ff482: memory_utils: add close_move_fd()

2021-02-11 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 1ff48211584c8cc9ae75d53d0f0643763e1f1dd7
  https://github.com/lxc/lxc/commit/1ff48211584c8cc9ae75d53d0f0643763e1f1dd7
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/memory_utils.h

  Log Message:
  ---
  memory_utils: add close_move_fd()

Signed-off-by: Christian Brauner 


  Commit: 4b7686ea7b660d89bf4290f64ca4331a8ddf74e3
  https://github.com/lxc/lxc/commit/4b7686ea7b660d89bf4290f64ca4331a8ddf74e3
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/string_utils.h

  Log Message:
  ---
  string_utils: add proc_self_fd()

Signed-off-by: Christian Brauner 


  Commit: 74f4638877607afc7d9320f99c8b3fe23e59c382
  https://github.com/lxc/lxc/commit/74f4638877607afc7d9320f99c8b3fe23e59c382
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/string_utils.h

  Log Message:
  ---
  string_utils: add fdstr()

Signed-off-by: Christian Brauner 


  Commit: 8e40762dfdc8baf697934f16057689958c053efb
  https://github.com/lxc/lxc/commit/8e40762dfdc8baf697934f16057689958c053efb
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/file_utils.c
M src/lxc/file_utils.h

  Log Message:
  ---
  file_utils: add same_file_lax()

Signed-off-by: Christian Brauner 


  Commit: 4a233eab3d294df2af0608923941dc8cbae635b6
  https://github.com/lxc/lxc/commit/4a233eab3d294df2af0608923941dc8cbae635b6
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/macro.h

  Log Message:
  ---
  macro: add LXC_PROC_SELF_FD_LEN

Signed-off-by: Christian Brauner 


  Commit: 37c74fd1ef32d5dac0c68080b4b448c073f4b467
  https://github.com/lxc/lxc/commit/37c74fd1ef32d5dac0c68080b4b448c073f4b467
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: introduce lxc_bind_mount_console()

Signed-off-by: Christian Brauner 


  Commit: de7f9f3303a5ed1100e6e0683a4a9fa4eb8330cc
  https://github.com/lxc/lxc/commit/de7f9f3303a5ed1100e6e0683a4a9fa4eb8330cc
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/conf.c
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h

  Log Message:
  ---
  tree-wide: rework mount api support checks

Signed-off-by: Christian Brauner 


  Commit: 46ad3c97ab475db56759d22b6d59beb490bec0cb
  https://github.com/lxc/lxc/commit/46ad3c97ab475db56759d22b6d59beb490bec0cb
  Author: Stéphane Graber 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/conf.c
M src/lxc/file_utils.c
M src/lxc/file_utils.h
M src/lxc/macro.h
M src/lxc/memory_utils.h
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h
M src/lxc/string_utils.h

  Log Message:
  ---
  Merge pull request #3666 from brauner/2021-02-11/fixes

Improved mount api support checking & console setup hardening


Compare: https://github.com/lxc/lxc/compare/244a5017badd...46ad3c97ab47
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 66efb1: string_utils: add wrapper for snprintf()

2021-02-11 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 66efb199f75a49c13246d760e894bd0f4891e5ce
  https://github.com/lxc/lxc/commit/66efb199f75a49c13246d760e894bd0f4891e5ce
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/string_utils.h

  Log Message:
  ---
  string_utils: add wrapper for snprintf()

This let's us avoid the tedious

if (ret < 0 || (size_t)ret >= sizeof(buf))

style of error checking.

Signed-off-by: Christian Brauner 


  Commit: 0bba27c1b783121ff80b0c8bcb4e1b3427cc557f
  https://github.com/lxc/lxc/commit/0bba27c1b783121ff80b0c8bcb4e1b3427cc557f
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: convert to strnprintf()

Signed-off-by: Christian Brauner 


  Commit: f51c7eb43eab61086d02c1c67ed11c28f2d9585c
  https://github.com/lxc/lxc/commit/f51c7eb43eab61086d02c1c67ed11c28f2d9585c
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: convert to strnprintf()

Signed-off-by: Christian Brauner 


  Commit: 92e6ae287c1734a96da1088795e20a465f60a643
  https://github.com/lxc/lxc/commit/92e6ae287c1734a96da1088795e20a465f60a643
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/commands_utils.c

  Log Message:
  ---
  commands_utils: convert to strnprintf()

Signed-off-by: Christian Brauner 


  Commit: 9bcde680c52abed674abde104531010634c4257e
  https://github.com/lxc/lxc/commit/9bcde680c52abed674abde104531010634c4257e
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: convert to strnprintf()

Signed-off-by: Christian Brauner 


  Commit: 3948c2529a77e026bbfd7d5ef0f0c9b6cc66a058
  https://github.com/lxc/lxc/commit/3948c2529a77e026bbfd7d5ef0f0c9b6cc66a058
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/confile.c

  Log Message:
  ---
  confile: convert to strnprintf()

Signed-off-by: Christian Brauner 


  Commit: 34a51534fd280a1ff78aaf2c822b2e985aaad60d
  https://github.com/lxc/lxc/commit/34a51534fd280a1ff78aaf2c822b2e985aaad60d
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/confile_utils.c

  Log Message:
  ---
  confile_utils: convert to strnprintf()

Signed-off-by: Christian Brauner 


  Commit: 8eaa5ae36cf9236b896e9de7dd07b288cf0535d9
  https://github.com/lxc/lxc/commit/8eaa5ae36cf9236b896e9de7dd07b288cf0535d9
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/criu.c

  Log Message:
  ---
  criu: convert to strnprintf()

Signed-off-by: Christian Brauner 


  Commit: 82c24a730645addda12b8200166aa9f67cf12b5e
  https://github.com/lxc/lxc/commit/82c24a730645addda12b8200166aa9f67cf12b5e
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/file_utils.c

  Log Message:
  ---
  file_utils: convert to strnprintf()

Signed-off-by: Christian Brauner 


  Commit: 08f7f1fd348eb554ef43f9cec4b94a5bcb865583
  https://github.com/lxc/lxc/commit/08f7f1fd348eb554ef43f9cec4b94a5bcb865583
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/log.c

  Log Message:
  ---
  log: convert to strnprintf()

Signed-off-by: Christian Brauner 


  Commit: 94aeacb7a36f914e1900bad8aeb2191b04f89fac
  https://github.com/lxc/lxc/commit/94aeacb7a36f914e1900bad8aeb2191b04f89fac
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/lxccontainer.c

  Log Message:
  ---
  lxccontainer: convert to strnprintf()

Signed-off-by: Christian Brauner 


  Commit: ff88c2b4af4bbe9a4707d4502e1eeb9dc9d57bf0
  https://github.com/lxc/lxc/commit/ff88c2b4af4bbe9a4707d4502e1eeb9dc9d57bf0
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/lxclock.c

  Log Message:
  ---
  lxclock: convert to strnprintf()

Signed-off-by: Christian Brauner 


  Commit: 3ca3b23065b8d77d8c647f8230375342ccba45a7
  https://github.com/lxc/lxc/commit/3ca3b23065b8d77d8c647f8230375342ccba45a7
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/monitor.c

  Log Message:
  ---
  monitor: convert to strnprintf()

Signed-off-by: Christian Brauner 


  Commit: d0c6b86e82121c41cdaecd2f52fabae7b0c06071
  https://github.com/lxc/lxc/commit/d0c6b86e82121c41cdaecd2f52fabae7b0c06071
  Author: Christian Brauner 
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
M src/lxc/mount_utils.c

  Log Message:
  ---
  mount_utils: convert to

[lxc-devel] [lxc/lxc] b3a428: cgroups: use brackets to have clear semantics for ...

2021-02-10 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: b3a42865963a100b07cbdba0e77cacd0e0d88b3c
  https://github.com/lxc/lxc/commit/b3a42865963a100b07cbdba0e77cacd0e0d88b3c
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: use brackets to have clear semantics for flags checking

Signed-off-by: Christian Brauner 


  Commit: d1ee87192ef31ec073521eaafe50b4d356f27e94
  https://github.com/lxc/lxc/commit/d1ee87192ef31ec073521eaafe50b4d356f27e94
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: do not return early when entering monitor cgroups

This will happen when restoring a container via criu.

Signed-off-by: Christian Brauner 


  Commit: ebf88e5b8786f72d24e8104bd08f488ba967803e
  https://github.com/lxc/lxc/commit/ebf88e5b8786f72d24e8104bd08f488ba967803e
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: log monitor and transient process entering

Signed-off-by: Christian Brauner 


  Commit: 25db3f94405d8789bb9bbcd680d35e322f28329e
  https://github.com/lxc/lxc/commit/25db3f94405d8789bb9bbcd680d35e322f28329e
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: log container process entering

Signed-off-by: Christian Brauner 


  Commit: ff4e4629061db18d0935535ba6b82b1e434e2447
  https://github.com/lxc/lxc/commit/ff4e4629061db18d0935535ba6b82b1e434e2447
  Author: Stéphane Graber 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  Merge pull request #3664 from brauner/2021-02-10/fixes

cgroups: fixes


Compare: https://github.com/lxc/lxc/compare/ae2d267e59dd...ff4e4629061d
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 9d0e12: conf: fix memory leak

2021-02-10 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 9d0e129b54aa92d9bdfcdd462683459a0f115df9
  https://github.com/lxc/lxc/commit/9d0e129b54aa92d9bdfcdd462683459a0f115df9
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: fix memory leak

Fixes: Coverity 1472848
Signed-off-by: Christian Brauner 


  Commit: ff9edd2d04f6814b74b2f34b4bcbf2b31bedbead
  https://github.com/lxc/lxc/commit/ff9edd2d04f6814b74b2f34b4bcbf2b31bedbead
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/criu.c

  Log Message:
  ---
  criu: mark cgroups methods specific to criu

Signed-off-by: Christian Brauner 


  Commit: 59d8a539d106ba17e54f75a92c1278907c55bb56
  https://github.com/lxc/lxc/commit/59d8a539d106ba17e54f75a92c1278907c55bb56
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/criu.c
M src/lxc/macro.h
M src/lxc/memory_utils.h

  Log Message:
  ---
  criu: massage exec_criu()

Signed-off-by: Christian Brauner 


  Commit: 2541dfab3884ce8d1d5ec21c585ced09784cc207
  https://github.com/lxc/lxc/commit/2541dfab3884ce8d1d5ec21c585ced09784cc207
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/criu.c

  Log Message:
  ---
  criu: move logging under lxc_log_trace()

Signed-off-by: Christian Brauner 


  Commit: 6eff3c0d79228db7bbcfc82c38d1cad537edb571
  https://github.com/lxc/lxc/commit/6eff3c0d79228db7bbcfc82c38d1cad537edb571
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/criu.c

  Log Message:
  ---
  criu: use cleanup macro

Signed-off-by: Christian Brauner 


  Commit: 5257b91b6e6ba7ea8e865a602b1cd790d44a9c69
  https://github.com/lxc/lxc/commit/5257b91b6e6ba7ea8e865a602b1cd790d44a9c69
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/criu.c

  Log Message:
  ---
  criu: use cleanup macro when parsing mount data

Signed-off-by: Christian Brauner 


  Commit: 2539492cc93bbed11a6801f8762664d96f56b1bc
  https://github.com/lxc/lxc/commit/2539492cc93bbed11a6801f8762664d96f56b1bc
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/criu.c

  Log Message:
  ---
  criu: rework init pid retrieval

Signed-off-by: Christian Brauner 


  Commit: 92fde26d7b9c9fc15c793282310c3bec0938e3ce
  https://github.com/lxc/lxc/commit/92fde26d7b9c9fc15c793282310c3bec0938e3ce
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/criu.c

  Log Message:
  ---
  criu: warn about cgroup hierarchies without controllers

Signed-off-by: Christian Brauner 


  Commit: b41a8023b86d315b97193218e34ab47f62e7e3a9
  https://github.com/lxc/lxc/commit/b41a8023b86d315b97193218e34ab47f62e7e3a9
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/criu.c

  Log Message:
  ---
  criu: lxc_init() already initializes cgroups

Signed-off-by: Christian Brauner 


  Commit: d9fc9be8f011270b1ce22345d7d634ce9a533cd4
  https://github.com/lxc/lxc/commit/d9fc9be8f011270b1ce22345d7d634ce9a533cd4
  Author: Christian Brauner 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/criu.c

  Log Message:
  ---
  criu: handle new cgroup layout

Signed-off-by: Christian Brauner 


  Commit: ae2d267e59dd29a4cb093ec6b76c04333d083b4a
  https://github.com/lxc/lxc/commit/ae2d267e59dd29a4cb093ec6b76c04333d083b4a
  Author: Stéphane Graber 
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/conf.c
M src/lxc/criu.c
M src/lxc/macro.h
M src/lxc/memory_utils.h

  Log Message:
  ---
  Merge pull request #3663 from brauner/2021-02-10/fixes

criu: fixes


Compare: https://github.com/lxc/lxc/compare/11a3696fda50...ae2d267e59dd
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 0ed79f: network: Add error message if iw couldn't be found

2021-02-09 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 0ed79f452a0e22ed4e20c34a4d5f16ef0a2ca50d
  https://github.com/lxc/lxc/commit/0ed79f452a0e22ed4e20c34a4d5f16ef0a2ca50d
  Author: Max 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/network.c

  Log Message:
  ---
  network: Add error message if iw couldn't be found

When iw is not installed on the host, lxc fails to move wireless devices
into a container. Unfortunately there is no real error message yet
(other than that it didn't work), so its quite unobvious what causes
this. This commit adds a error message that clearly states the
application iw is missing.

Signed-off-by: Maximilian Blenk 


  Commit: 11a3696fda5057589e6fb21fd8961ff228983c62
  https://github.com/lxc/lxc/commit/11a3696fda5057589e6fb21fd8961ff228983c62
  Author: Stéphane Graber 
  Date:   2021-02-09 (Tue, 09 Feb 2021)

  Changed paths:
M src/lxc/network.c

  Log Message:
  ---
  Merge pull request #3661 from blenk92/iw_error_msg

network: Add error message if iw couldn't be found


Compare: https://github.com/lxc/lxc/compare/642429e57b5d...11a3696fda50
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] ac11fe: mount_utils: add locked flag helpers

2021-02-09 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: ac11febd37494a6aea082bae504b53f053a76a45
  https://github.com/lxc/lxc/commit/ac11febd37494a6aea082bae504b53f053a76a45
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M configure.ac
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h
M src/lxc/storage/dir.c

  Log Message:
  ---
  mount_utils: add locked flag helpers

Signed-off-by: Christian Brauner 


  Commit: b28aae045ecb8d2298a92435f5e99bdc44b8d38b
  https://github.com/lxc/lxc/commit/b28aae045ecb8d2298a92435f5e99bdc44b8d38b
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: s/setup_mount()/setup_mount_fstab()/g

Signed-off-by: Christian Brauner 


  Commit: 8183f09e00912d458db8821936a07ddf906e3d55
  https://github.com/lxc/lxc/commit/8183f09e00912d458db8821936a07ddf906e3d55
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: kill PATH_MAX bytes

Signed-off-by: Christian Brauner 


  Commit: 48e5dcc85a827fcf32a185d6fb7decee72b20ea4
  https://github.com/lxc/lxc/commit/48e5dcc85a827fcf32a185d6fb7decee72b20ea4
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: don't pass struct lxc_conf

Signed-off-by: Christian Brauner 


  Commit: 9c0fd29a5ccafefe31760303015a16b7e99a93b0
  https://github.com/lxc/lxc/commit/9c0fd29a5ccafefe31760303015a16b7e99a93b0
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: kill PATH_MAX bytes

Signed-off-by: Christian Brauner 


  Commit: 4806d3b9ec5e1df7aa1ce0ced531c0cef9666776
  https://github.com/lxc/lxc/commit/4806d3b9ec5e1df7aa1ce0ced531c0cef9666776
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: kill PAT_MAX bytes

Signed-off-by: Christian Brauner 


  Commit: 79ff643d24593a1b77bb39233219d55d20efa4bc
  https://github.com/lxc/lxc/commit/79ff643d24593a1b77bb39233219d55d20efa4bc
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/start.c
M src/lxc/start.h

  Log Message:
  ---
  conf: rework rootfs pinning

Signed-off-by: Christian Brauner 


  Commit: ade356b90cd39a983872c0b9bf406b5251087768
  https://github.com/lxc/lxc/commit/ade356b90cd39a983872c0b9bf406b5251087768
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/mount_utils.c

  Log Message:
  ---
  mount_utils: s/OPEN_TREE_CLONE | OPEN_TREE_CLONE/OPEN_TREE_CLONE | 
OPEN_TREE_CLOEXEC/g

Signed-off-by: Christian Brauner 


  Commit: 7369e6bf6d5a610cd3d45e2407898722aac1d95e
  https://github.com/lxc/lxc/commit/7369e6bf6d5a610cd3d45e2407898722aac1d95e
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: fd-only tty setup

Signed-off-by: Christian Brauner 


  Commit: 17d9d07275d7b2da49f02385218f03a5708328f7
  https://github.com/lxc/lxc/commit/17d9d07275d7b2da49f02385218f03a5708328f7
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/tests/lxc-test-unpriv

  Log Message:
  ---
  tests: add logging to lxc-test-unpriv

Signed-off-by: Christian Brauner 


  Commit: 887ae844d5b91720c08557e4915908c0775a364f
  https://github.com/lxc/lxc/commit/887ae844d5b91720c08557e4915908c0775a364f
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: kill PATH_MAX bytes

Signed-off-by: Christian Brauner 


  Commit: 58b381117db181ba0b605d40e1d651cfa008e4d6
  https://github.com/lxc/lxc/commit/58b381117db181ba0b605d40e1d651cfa008e4d6
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: kill PATH_MAX bytes

Signed-off-by: Christian Brauner 


  Commit: 642429e57b5dc142832d8341bbd1b4f4398f4d25
  https://github.com/lxc/lxc/commit/642429e57b5dc142832d8341bbd1b4f4398f4d25
  Author: Stéphane Graber 
  Date:   2021-02-09 (Tue, 09 Feb 2021)

  Changed paths:
M configure.ac
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h
M src/lxc/start.c
M src/lxc/start.h
M src/lxc/storage/dir.c
M src/tests/lxc-test-unpriv

  Log Message:
  ---
  Merge pull request #3662 from brauner/2021-02-08/fixes

conf: expand fd-only setup codepaths


Compare:

[lxc-devel] [lxc/lxc] f9f187: cgroups: bpf fixes

2021-02-08 Thread Christian Brauner

  Branch: refs/heads/stable-4.0
  Home:   https://github.com/lxc/lxc
  Commit: f9f1879966261923e7b106717e804cbdb597f8bf
  https://github.com/lxc/lxc/commit/f9f1879966261923e7b106717e804cbdb597f8bf
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  ---
  cgroups: bpf fixes

Signed-off-by: Christian Brauner 


  Commit: 8d22ec0166ee8bbf6b51596e0f93ea99026b37c4
  https://github.com/lxc/lxc/commit/8d22ec0166ee8bbf6b51596e0f93ea99026b37c4
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgroup2_devices.h

  Log Message:
  ---
  croups: improve __do_bpf_program_free

Signed-off-by: Christian Brauner 


  Commit: 5e84adf6ffb649e56c445ae4bba138654263f65b
  https://github.com/lxc/lxc/commit/5e84adf6ffb649e56c445ae4bba138654263f65b
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  ---
  cgroups: coding style fixes

Signed-off-by: Christian Brauner 


  Commit: 9dee31e50145ccd06061f8e3277e7874696f9d36
  https://github.com/lxc/lxc/commit/9dee31e50145ccd06061f8e3277e7874696f9d36
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  ---
  cgroups: don't initiliaze NULL log

Signed-off-by: Christian Brauner 


  Commit: 8f9cd8d0d27399c9a7301125a30942227ee694c2
  https://github.com/lxc/lxc/commit/8f9cd8d0d27399c9a7301125a30942227ee694c2
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  ---
  cgroups: ensure all memory is zeroed

Signed-off-by: Christian Brauner 


  Commit: 61eb36f89cf8079c59b7a4784448c4b3da8c7142
  https://github.com/lxc/lxc/commit/61eb36f89cf8079c59b7a4784448c4b3da8c7142
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: use zalloc

Signed-off-by: Christian Brauner 


  Commit: 1aac9f39a0587e52a83197668eee651b0e46b14c
  https://github.com/lxc/lxc/commit/1aac9f39a0587e52a83197668eee651b0e46b14c
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: tweak cgroup initialization

Signed-off-by: Christian Brauner 


  Commit: 17b2106bf01d7c58642458c5c622787d3760b91b
  https://github.com/lxc/lxc/commit/17b2106bf01d7c58642458c5c622787d3760b91b
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/log.c

  Log Message:
  ---
  log: remove pointless inline

Signed-off-by: Christian Brauner 


  Commit: 7491f5a162c26796d8baaac4e51a8e819d676073
  https://github.com/lxc/lxc/commit/7491f5a162c26796d8baaac4e51a8e819d676073
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/log.c
M src/lxc/log.h

  Log Message:
  ---
  log: add lxc_log_get_fd()

Signed-off-by: Christian Brauner 


  Commit: cc486b115749a467506dee9d58bf3f03c65736a5
  https://github.com/lxc/lxc/commit/cc486b115749a467506dee9d58bf3f03c65736a5
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/seccomp.c

  Log Message:
  ---
  seccomp: use lxc_log_get_fd()

Signed-off-by: Christian Brauner 


  Commit: 599086c8487dce6c68ce8807e3e6bcd3c3ef5edc
  https://github.com/lxc/lxc/commit/599086c8487dce6c68ce8807e3e6bcd3c3ef5edc
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/log.c

  Log Message:
  ---
  log: rework lxc_log_get_level()

Signed-off-by: Christian Brauner 


  Commit: 5e651c8e7fc99e71bab74cd679da4e8365f5100f
  https://github.com/lxc/lxc/commit/5e651c8e7fc99e71bab74cd679da4e8365f5100f
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/seccomp.c

  Log Message:
  ---
  seccomp: use lxc_log_get_level()

This will now enable LXD users to dump the seccomp filter in the log when
logging at TRACE level.

Signed-off-by: Christian Brauner 


  Commit: 4e977ae8d026247e9126769a8161b5b0eeb4ae42
  https://github.com/lxc/lxc/commit/4e977ae8d026247e9126769a8161b5b0eeb4ae42
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  ---
  cgroups: use bpf log when logging at trace level

Signed-off-by: Christian Brauner 


  Commit: b4a42b37d5381da4cc7a8ba8289ed4edab41998b
  https://github.com/lxc/lxc/commit/b4a42b37d5381da4cc7a8ba8289ed4edab41998b
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed

[lxc-devel] [lxc/lxc] 5b8e41: configure: fix static builds with clang-12 and LTO

2021-02-08 Thread Christian Brauner

  Branch: refs/heads/stable-4.0
  Home:   https://github.com/lxc/lxc
  Commit: 5b8e411ec79ac4c85e5410bc974e19b5feb0b60b
  https://github.com/lxc/lxc/commit/5b8e411ec79ac4c85e5410bc974e19b5feb0b60b
  Author: Christian Brauner 
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
M configure.ac

  Log Message:
  ---
  configure: fix static builds with clang-12 and LTO

Signed-off-by: Christian Brauner 


___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 5cf511: mount_utils: initialize fd

2021-02-05 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 5cf51172e3031f1b739d36b24b426a2def708b9b
  https://github.com/lxc/lxc/commit/5cf51172e3031f1b739d36b24b426a2def708b9b
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/mount_utils.h

  Log Message:
  ---
  mount_utils: initialize fd

Signed-off-by: Christian Brauner 


  Commit: 0d50f2882c8427565c092ba3931eb1cad36ad96f
  https://github.com/lxc/lxc/commit/0d50f2882c8427565c092ba3931eb1cad36ad96f
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/attach.c

  Log Message:
  ---
  attach: switch to simple mount()

At the point where we're remounging proc and sys we're in the container's
namespaces so there's no chance of escape so a simple mount() syscall will
suffice.

Signed-off-by: Christian Brauner 


  Commit: 60218ee70ba6e38d83301900f3eacb02e840a4df
  https://github.com/lxc/lxc/commit/60218ee70ba6e38d83301900f3eacb02e840a4df
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h

  Log Message:
  ---
  mount_utils: kill mount_filesystem()

We have way better helpers now.

Signed-off-by: Christian Brauner 


  Commit: 01149adf724d5d3cfe79918e002c1ee5fac89080
  https://github.com/lxc/lxc/commit/01149adf724d5d3cfe79918e002c1ee5fac89080
  Author: Stéphane Graber 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/attach.c
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h

  Log Message:
  ---
  Merge pull request #3660 from brauner/2021-02-05/fixes_1

mount_utils: initialize fd


Compare: https://github.com/lxc/lxc/compare/338c2abe8392...01149adf724d
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 74ed30: mount_utils: move mount_at() and mount_from_at() o...

2021-02-05 Thread Stéphane Graber

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 74ed30d721ccc569b4e09e67f97fa0a1b42fe2a8
  https://github.com/lxc/lxc/commit/74ed30d721ccc569b4e09e67f97fa0a1b42fe2a8
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/Makefile.am
M src/lxc/cgroups/cgfsng.c
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h
M src/lxc/utils.c
M src/lxc/utils.h
M src/tests/Makefile.am

  Log Message:
  ---
  mount_utils: move mount_at() and mount_from_at() over from utils.{c,h}

Signed-off-by: Christian Brauner 


  Commit: 1f3eb959656a5a461d3d51083bad5c03bf04f9f1
  https://github.com/lxc/lxc/commit/1f3eb959656a5a461d3d51083bad5c03bf04f9f1
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h

  Log Message:
  ---
  mount_utils: add extended helpers for new mount api

fs_prepare()
fs_set_property()
fs_attach()
fs_mount()

Signed-off-by: Christian Brauner 


  Commit: bfbfeedfab1b939993be166cadf52ac941bbed64
  https://github.com/lxc/lxc/commit/bfbfeedfab1b939993be166cadf52ac941bbed64
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: switch mount_autodev() to new mount api

Signed-off-by: Christian Brauner 


  Commit: 23a20dbea863fa4ac2c8b2a4972a5d94fb7247bc
  https://github.com/lxc/lxc/commit/23a20dbea863fa4ac2c8b2a4972a5d94fb7247bc
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: switch tmpfs mounting to new mount api

Signed-off-by: Christian Brauner 


  Commit: a099c5db1c1a3a3ce20b717a3d7269d3a55a18b3
  https://github.com/lxc/lxc/commit/a099c5db1c1a3a3ce20b717a3d7269d3a55a18b3
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c

  Log Message:
  ---
  cgroups: switch __cg_mount_direct() to use the new mount api

Signed-off-by: Christian Brauner 


  Commit: ca9055b47399a2040a5e1c2a8da591832380b168
  https://github.com/lxc/lxc/commit/ca9055b47399a2040a5e1c2a8da591832380b168
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h

  Log Message:
  ---
  mount_utils: kill mount_at()

Signed-off-by: Christian Brauner 


  Commit: 041d1e30545a5e21fc9631b09daa1ab817e6ff15
  https://github.com/lxc/lxc/commit/041d1e30545a5e21fc9631b09daa1ab817e6ff15
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h

  Log Message:
  ---
  mount_utils: add support for bind-mounts through the new mount api

fd_bind_mount()

Signed-off-by: Christian Brauner 


  Commit: d2c885f199a8ca6bd0f8f1acbbb2671cac04624f
  https://github.com/lxc/lxc/commit/d2c885f199a8ca6bd0f8f1acbbb2671cac04624f
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/conf.c

  Log Message:
  ---
  conf: use fd_bind_mount() in lxc_fill_autodev()

Signed-off-by: Christian Brauner 


  Commit: 55a85f4a1145a4a89354db65fbf4f3ba358cbde8
  https://github.com/lxc/lxc/commit/55a85f4a1145a4a89354db65fbf4f3ba358cbde8
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h

  Log Message:
  ---
  mount_utils: kill mount_from_at()

Signed-off-by: Christian Brauner 


  Commit: 87545854f7b641034cc79f61a03e05641b736048
  https://github.com/lxc/lxc/commit/87545854f7b641034cc79f61a03e05641b736048
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/mount_utils.h

  Log Message:
  ---
  mount_utils: detect new mount api support

Signed-off-by: Christian Brauner 


  Commit: 635e7bac019140ca33bf9f6768e4b82268ebee17
  https://github.com/lxc/lxc/commit/635e7bac019140ca33bf9f6768e4b82268ebee17
  Author: Christian Brauner 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/conf.c

  Log Message:
  ---
  tree-wide: make use of new_mount_api() where it makes sense

Signed-off-by: Christian Brauner 


  Commit: 338c2abe8392cdaf07cfa1cb8252cf19106220be
  https://github.com/lxc/lxc/commit/338c2abe8392cdaf07cfa1cb8252cf19106220be
  Author: Stéphane Graber 
  Date:   2021-02-05 (Fri, 05 Feb 2021)

  Changed paths:
M src/lxc/Makefile.am
M src/lxc/cgroups/cgfsng.c
M src/lxc/conf.c
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h
M src/lxc/utils.c
M src/lxc/utils.h
M src/tests/Makefile.am

  Log Message:
  ---
  Merge pull request #3659 from brauner/2021-02-05/fixes

mount: extend support for the

1 2 3 4 5 6 7 8 9 10 >

1 - 100 of 2874 matches

Mail list logo