Re: feature request for 1.2.1 or 1.3.0 or 1.3.1 or ...

2002-05-22 Thread Rod Pinna

 R. Lahaye [EMAIL PROTECTED] writes:
 
 | Rod Pinna writes:
 
  Just wondering in a reread button could be added in the next version, in
  the graphics insert box. Currently, if I update a picture externally,
  there isn't a way to update the picture without closing lyx.
 
 | What about a watch file in the graphics dialog, or even such a selection
 | button in the preferences for all graphics (same as the ghostview option).
 
 Why?
 This is how we should behave by default.

Indeed. My request was predicated that watching the files in such a way
would be more difficult than implementing a button to force a reread. I'm
somewhat reticent to create work for others that I have no hope of doing
myself :)

Rod

_
rod   | Beneath the waves, the waves / That's where I will be /
  | I'm going to see the cow beneath the sea.
  | They Might Be Giants, Lincoln




Re: compile error due to -fno-exception and boost

2002-05-22 Thread Lars Gullik Bjønnes

Andre Poenitz [EMAIL PROTECTED] writes:

| On Wed, May 22, 2002 at 08:12:53AM +0200, Lars Gullik Bjønnes wrote:
 I wonder if we ever will be able to use exceptions...
 Or will we for ever need to cripple third-party libraries.

| What's wrong with exceptions?

Nothing, except for the compilers that we still support.

-- 
Lgb





Re: compile error due to -fno-exception and boost

2002-05-22 Thread Michael Koziarski

On Wed, May 22, 2002 at 08:12:53AM +0200 or thereabouts, Lars Gullik Bjønnes wrote:
 Andre Poenitz [EMAIL PROTECTED] writes:
 
 | ... can be worked around by  'export CXXFLAGS=-fexceptions', './configure'.
 
 | Not exactly nice though.
 
 I wonder if we ever will be able to use exceptions...
 Or will we for ever need to cripple third-party libraries.

Gtkmm2 now uses exceptions, so I'll need to work around the
-fno-exceptions anyway.  However, the ANSI standard has been around
for a long time.  How many compilers do we 'support' which don't
support them?  What else don't they support that we'd like to use?




-- 

| Michael Koziarski   |Conventional wisdom is often   |
| Data Engineer, Linux user   | long on convention and short   |
|  Objectivist.  | on wisdom --  |
| http://www.koziarski.com| Warren E. Buffett, BRK.A   |




Re: compile error due to -fno-exception and boost

2002-05-22 Thread Lars Gullik Bjønnes

Michael Koziarski [EMAIL PROTECTED] writes:

| On Wed, May 22, 2002 at 08:12:53AM +0200 or thereabouts, Lars Gullik Bjønnes wrote:
 Andre Poenitz [EMAIL PROTECTED] writes:
 
 | ... can be worked around by  'export CXXFLAGS=-fexceptions', './configure'.
 
 | Not exactly nice though.
 
 I wonder if we ever will be able to use exceptions...
 Or will we for ever need to cripple third-party libraries.

| Gtkmm2 now uses exceptions, so I'll need to work around the
| -fno-exceptions anyway.  However, the ANSI standard has been around
| for a long time.  How many compilers do we 'support' which don't
| support them?  What else don't they support that we'd like to use?

I do only know about the GCC compilers... 2.95 should be ok with
exceptions, 3.0 and 3.1 too of course. (And I do not see the point in
supporting compilers older than 2.95)

It is the other platforms that I am not so sure about.

IMHO we should turn exceptions on.

-- 
Lgb



Re: 1.2.0pre5 compile problems w/ gcc 3.1 on Tru64 4.0D

2002-05-22 Thread Angus Leeming

On Tuesday 21 May 2002 9:17 pm, Lars Gullik Bjønnes wrote:
 Angus Leeming [EMAIL PROTECTED] writes:
  Try putting it in ftp.devel.lyx.org:/incoming  (or pub/incoming)
 |
 | I can't upload. Do I have to log in as [EMAIL PROTECTED]? But then my
 | password is visible to the world...

 then put it in your home dir and I can just get it there.

Find it at 

http://www.devel.lyx.org/~leeming/lyx-1.2.0rc1-bin.Tru64.tar.gz

It's 3.4Mbytes in size. If you tell me when you've grabbed it, then I'll 
delete it.

Angus



new math font stuff

2002-05-22 Thread Andre Poenitz


Isn't this supposed to work automagially nowadays?

I even have the fonts under /usr/lib/X11/fonts/... and xfontsel finds them,
but neither configure not Edit-Reconfigure can see them.

Andre'

-- 
Those who desire to give up Freedom in order to gain Security,
will not have, nor do they deserve, either one. (T. Jefferson)



Re: new math font stuff

2002-05-22 Thread Andre Poenitz

On Wed, May 22, 2002 at 08:21:59AM -0300, Garst R. Reese wrote:
 Well, for me I had to add a FontPath /usr/local/share/lyx/xfonts to
 XF86Config

Ok, I just noticed the I lost bluesky fonts in my tex installation after
setting up my new machine. There have been real copies in
/usr/X11/lib/X11/fonts, but LyX does not seem to take those into account.

[Why, btw?]

Well... they are found by configure now, however, LyX still does not use
them...

Andre'

-- 
Those who desire to give up Freedom in order to gain Security,
will not have, nor do they deserve, either one. (T. Jefferson)



Re: new math font stuff

2002-05-22 Thread Andre Poenitz

On Wed, May 22, 2002 at 11:16:29AM -0300, Garst R. Reese wrote:
 What does xset q say. In particular does it show the path to xfonts?

It shows /usr/X11/lib/X11/font/test, and that's the place where I put the
fonts. As I said, 'xfontsel' show the fonts just fine.

Andre'

-- 
Those who desire to give up Freedom in order to gain Security,
will not have, nor do they deserve, either one. (T. Jefferson)



compile problem

2002-05-22 Thread Kayvan A. Sylvan

Latest CVS, ./configure --with-included-string:

g++ -DHAVE_CONFIG_H -I. -I. -I../../src -I./../ -I../.. -I../../boost -isystem
+/usr/X11R6/include -O2 -m486 -fno-strength-reduce -W -Wall -c insetgraphics.C
+-Wp,-MD,.deps/insetgraphics.TPlo
In file included from ../../src/insets/inset.h:19,
 from ../../src/insets/insetgraphics.h:23,
 from insetgraphics.C:78:
../../src/LString.h:24: #error The string header has been included before
+LString.h
make[4]: *** [insetgraphics.lo] Error 1



msg38235/pgp0.pgp
Description: PGP signature


Re: feature request for 1.2.1 or 1.3.0 or 1.3.1 or ...

2002-05-22 Thread Herbert Voss

Rod Pinna wrote:

 
 Just wondering in a reread button could be added in the next version, in
 the graphics insert box. Currently, if I update a picture externally,
 there isn't a way to update the picture without closing lyx.


this is not true, it's still part of the code!
- reread the bb
- the only problem is that you have to enable
   the clip to bounding box, then the lyx-view
   is updated, too.
- and an apply to view the changes

with the attached patch it works without enabling the
clip to ... checkbox

Herbert



-- 
http://www.lyx.org/help/


Index: src/graphics/GraphicsParams.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/graphics/GraphicsParams.C,v
retrieving revision 1.13
diff -u -r1.13 GraphicsParams.C
--- src/graphics/GraphicsParams.C   1 May 2002 11:12:02 -   1.13
+++ src/graphics/GraphicsParams.C   22 May 2002 17:00:32 -
 -33,7 +33,7 
filename = MakeAbsPath(filename, filepath);
}
 
-   if (iparams.clip) {
+// if (iparams.clip) {
bb = iparams.bb;
 
// Get the original Bounding Box from the file
 -55,16 +55,16 
bb.yt = std::max(0, bb.yt);
 
// Paranoia check.
-   int const width  = bb.xr - bb.xl;
-   int const height = bb.yt - bb.yb;
+   int const width_bb  = bb.xr - bb.xl;
+   int const height_bb = bb.yt - bb.yb;
 
-   if (width   0 || height  0) {
+   if (width_bb   0 || height_bb  0) {
bb.xl = 0;
bb.xr = 0;
bb.yb = 0;
bb.yt = 0;
}
-   }
+// }

if (iparams.rotate)
 



Re: feature request for 1.2.1 or 1.3.0 or 1.3.1 or ...

2002-05-22 Thread John Levon

On Wed, May 22, 2002 at 07:04:37PM +0200, Herbert Voss wrote:

 this is not true, it's still part of the code!
 - reread the bb

This is nearly useless in terms of UI

regards
john

-- 
I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit.
- Toon Moene



Re: tmda test list

2002-05-22 Thread mw

On Wed, May 22, 2002 at 09:40:38AM +0200, Guenter Milde wrote:
 On Tue, 21 May 2002 15:14:41 -0500 wrote Mate Wierdl 
[EMAIL PROTECTED]:
 
  OK, I have set up the list
  
  [EMAIL PROTECTED]
 
 Hi Mate and Spamlist readers,
 
 If the test comes out nice, would it be possible, to have the tmda scheme
 just for html-mails to the lyx-* lists? IMO, this would be a reasonable
 tradeoff between anti-spam and ease of use. Maybe it would also be sensible
 for mails with attachments, i.e.
 
a standard mail (no html, no attachments) get through (as presently)
a html mail needs confirmation (- anti-spam)

There is no need to do any more antispam measures once tmda is
implemented.  I have been using tmda for almost a year now, and
received not a single spam.  Spammers never confirm their email, so
they will never be whitelisted.

Presently, html parts are cut out, and if the whole message is cut
out, then the message bounces.  

a mail with attachment needs confirmation (- anti virus)


No, that would be very inconvenient.  Instead, I will be just blocking
certain file extensions, and hope for the best. I am already blocking
.exe and .scr.  But with tmda, very few virus should make it through
(basically coming from subscribers' addresses).

I was going to try out moderation as well, but I am not sure why
people would do it.  What would be the advantage over using tmda,
which automates moderation, basically?

I have been rather busy (my son's school is over), but I will
nevertheless set up a moderated list with John and Lars moderators.  I
do not know exactly when, though.

I also had to read up on laws regarding virus prevention.  In fact, an
ISP is responsible for users' getting viruses only if they promise
virus prevention.  So I will never officially promise antivirus
measures here.

Mate







Wednesday

2002-05-22 Thread John Levon


It's release day ... so ... ??

john

-- 
I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit.
- Toon Moene



Here to find out more!

2002-05-22 Thread fmartinez


articulo;seccion=170;sz=468x60;tile=1;ord=2941570662987709[1].html
Description: Binary data


[PATCH] use template for undo stack

2002-05-22 Thread John Levon


Also some minor cleanups, and one not-so-minor: now when createUndo
returns 0, it is not added to the undostack. As I understand it, this
led to us adding to the stack sizeof(Undo *) on every character the user
added.

Please apply (can applier add limited_stack.h to support/Makefile.am
themselves also)

thanks
john

-- 
I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit.
- Toon Moene


Index: src/ChangeLog
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/ChangeLog,v
retrieving revision 1.718
diff -u -r1.718 ChangeLog
--- src/ChangeLog   22 May 2002 12:33:01 -  1.718
+++ src/ChangeLog   22 May 2002 19:16:29 -
@@ -1,3 +1,14 @@
+2002-05-22  John Levon  [EMAIL PROTECTED]
+
+   * Makefile.am:
+   * undostack.h:
+   * undostack.C: remove
+ 
+   * undo_funcs.h:
+   * undo_funcs.C:
+   * buffer.h: from above change. Small changes. Don't
+ add non-undos to the undostack
+ 
 2002-05-22  Lars Gullik Bjønnes  [EMAIL PROTECTED]
 
* buffer.C: comment out some some code that depend upon lyx_format
Index: src/buffer.h
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/buffer.h,v
retrieving revision 1.97
diff -u -r1.97 buffer.h
--- src/buffer.h22 May 2002 12:33:02 -  1.97
+++ src/buffer.h22 May 2002 19:16:46 -
@@ -19,7 +19,8 @@
 
 #include LString.h
 #include undo.h
-#include undostack.h
+#include support/limited_stack.h
+ 
 #include lyxvc.h
 #include bufferparams.h
 #include texrow.h
@@ -298,11 +299,11 @@
bool isMultiLingual();
 
/// Does this mean that this is buffer local?
-   UndoStack undostack;
-
-   /// Does this mean that this is buffer local?
-   UndoStack redostack;
-
+   limited_stackUndo * undostack;
+   
+   /// Does this mean that this is buffer local? 
+   limited_stackUndo * redostack;
+   
///
BufferParams params;
 
Index: src/undo_funcs.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/undo_funcs.C,v
retrieving revision 1.22
diff -u -r1.22 undo_funcs.C
--- src/undo_funcs.C21 Mar 2002 17:25:32 -  1.22
+++ src/undo_funcs.C22 May 2002 19:17:05 -
@@ -23,318 +23,199 @@
 
 #include iterators.h
 
-#define DELETE_UNUSED_PARAGRAPHS 1
-#ifdef DELETE_UNUSED_PARAGRAPHS
 #include vector
-#endif
 
 using std::vector;
 
 
 /// the flag used by FinishUndo();
 bool undo_finished;
-/// a flag
+/// FIXME
 bool undo_frozen;
 
+namespace {
 
-bool textUndo(BufferView * bv)
+// returns false if no undo possible
+bool textHandleUndo(BufferView * bv, Undo * undo)
 {
-   // returns false if no undo possible
-   Undo * undo = bv-buffer()-undostack.top();
-   bv-buffer()-undostack.pop();
-   if (undo) {
+   if (!undo) {
finishUndo();
-   if (!undo_frozen) {
-   Paragraph * first = 
bv-buffer()-getParFromID(undo-number_of_before_par);
-   if (first  first-next())
-   first = first-next();
-   else if (!first)
-   first = firstUndoParagraph(bv, 
undo-number_of_inset_id);
-   if (first) {
-   bv-buffer()-redostack.push(
-   createUndo(bv, undo-kind, first,
-  
bv-buffer()-getParFromID(undo-number_of_behind_par)));
-   }
-   }
+   bv-text-status(bv, LyXText::NEED_MORE_REFRESH);
+   return false;
}
-   // now we can unlock the inset for saftey because the inset pointer could
-   // be changed during the undo-function. Anyway if needed we have to lock
-   // the right inset/position if this is requested.
-   freezeUndo();
-   bv-unlockInset(bv-theLockingInset());
-   bool ret = textHandleUndo(bv, undo);
-   unFreezeUndo();
-   return ret;
-}
-
-
-bool textRedo(BufferView * bv)
-{
-   // returns false if no redo possible
-   Undo * undo = bv-buffer()-redostack.top();
-   bv-buffer()-redostack.pop();
-   if (undo) {
-   finishUndo();
-   if (!undo_frozen) {
-   Paragraph * first = 
bv-buffer()-getParFromID(undo-number_of_before_par);
-   if (first  first-next())
-   first = first-next();
-   else if (!first)
-   first = firstUndoParagraph(bv, 
undo-number_of_inset_id);
-   if (first) {
-   bv-buffer()-undostack.push(
-   createUndo(bv, undo-kind, first,
-  

Re: [PATCH] use template for undo stack

2002-05-22 Thread John Levon

On Wed, May 22, 2002 at 08:25:04PM +0100, John Levon wrote:

 + /// limit is the maximum size of the stack
 + limited_stack(size_type limit = 10) {

Sigh, and change this back to the non-debug default of 100 not 10 :))

thanks
john

-- 
I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit.
- Toon Moene



[PATCH] document texrow.[hC]

2002-05-22 Thread John Levon


also some minor cleanup

please apply

thanks
john

-- 
I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit.
- Toon Moene


Index: src/ChangeLog
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/ChangeLog,v
retrieving revision 1.718
diff -u -r1.718 ChangeLog
--- src/ChangeLog   22 May 2002 12:33:01 -  1.718
+++ src/ChangeLog   22 May 2002 19:29:38 -
@@ -1,3 +1,8 @@
+2002-05-22  John Levon  [EMAIL PROTECTED]
+
+   * texrow.h:
+   * texrow.C: document + small cleanup
+ 
 2002-05-22  Lars Gullik Bjønnes  [EMAIL PROTECTED]
 
* buffer.C: comment out some some code that depend upon lyx_format
Index: src/texrow.h
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/texrow.h,v
retrieving revision 1.14
diff -u -r1.14 texrow.h
--- src/texrow.h21 Mar 2002 17:25:29 -  1.14
+++ src/texrow.h22 May 2002 19:29:38 -
@@ -1,13 +1,12 @@
 // -*- C++ -*-
-/* This file is part of
- * ==
+/**
+ * \file texrow.h
+ * Copyright 1995-2002 the LyX Team
+ * Read the file COPYING
  *
- *   LyX, The Document Processor
- *
- *   Copyright 1995 Matthias Ettrich
- *   Copyright 1995-2001 The LyX Team
- *
- * == */
+ * \author Matthias Ettrich
+ */
+
 
 #ifndef TEXROW_H
 #define TEXROW_H
@@ -20,7 +19,7 @@
 
 class Paragraph;
 
-// Controls correspondance between paragraphs and the generated LaTeX file
+/// Represents the correspondence between paragraphs and the generated LaTeX file
 class TexRow {
 public:
///
@@ -35,65 +34,69 @@
/// Insert node when line is completed
void newline();
 
-   /// Returns paragraph id and position from a row number
+   /**
+* getIdFromRow - find pid and position for a given row
+* @param row row number to find
+* @param id set to id if found
+* @param pos set to paragraph position if found
+* @return true if found, false otherwise
+*
+* If the row could not be found, pos is set to zero and
+* id is set to -1
+*/
bool getIdFromRow(int row, int  id, int  pos) const;
 
-   /// Appends another TexRow
TexRow  operator+= (TexRow const );
 
-   /// Returns the number of rows in this texrow
+   /// Returns the number of rows contained
int rows() const { return count; }
 
-   /// Linked list of items
+   /// an individual id/pos = row mapping
class RowItem {
public:
-   ///
-   RowItem() : id_(-1), pos_(-1), rownumber_(0) {}
-   ///
-   void id(int i) {
-   id_ = i;
-   }
-   ///
+   RowItem(int id, int pos, int row) 
+   : id_(id), pos_(pos), rownumber_(row)
+   {}
+
+   /// paragraph id
int id() const {
return id_;
}
-   ///
+ 
+   /// set paragraph position
void pos(int p) {
pos_ = p;
}
-   ///
+
+   /// paragraph position
int pos() const {
return pos_;
}
-   ///
-   void rownumber(int r) {
-   rownumber_ = r;
-   }
-   ///
+
+   /// row number
int rownumber() const {
return rownumber_;
}
private:
-   ///
int id_;
-   ///
int pos_;
-   ///
int rownumber_;
};
///
typedef std::listRowItem RowList;
-   ///
-   void increasePos(int id, int pos) const;
+   /// increment position of all other RowItems
+   /// with same par id, to avoid placing error insets
+   /// at the same position
+   void increasePos(int id, int pos);
 private:
-   ///
+   /// number of lines
unsigned int count;
-   ///
-   mutable RowList rowlist;
+   /// container of id/pos = row mapping
+   RowList rowlist;
/// Last paragraph
Paragraph * lastpar;
/// Last position
int lastpos;
-
 };
-#endif
+ 
+#endif // TEXROW_H
Index: src/texrow.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/texrow.C,v
retrieving revision 1.22
diff -u -r1.22 texrow.C
--- src/texrow.C21 Mar 2002 17:25:28 -  1.22
+++ src/texrow.C22 May 2002 19:29:38 -
@@ -1,12 +1,10 @@
-/* This file is part of
- * 

1.2.0pre5 : ps-eps conversion and usepackage{babel} position

2002-05-22 Thread Nabil Hathout

Hello,

when I insert a postscript figure in a document, lyx 1.2.0 says that it cannot
convert ps to eps.  This makes many of my lyx 1.1.6 documents not usable with
lyx 1.2.0.

a second compatibility problem comes from the fact that lyx 1.2.0 inserts the
\usepackage{babel} after the preamble. So I have to add to all my lyx 1.1.6
French documents the previous command in the preamble in order to set some
frenchb variables.

thank you.

--Nabil Hathout



[PATCH] remove dead files, add some srcdoc

2002-05-22 Thread John Levon


There's no point having unused files in CVS, and there are several
points against.

Can we remove support/strerror.C too ? What uses it when ?

regards
john

-- 
I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit.
- Toon Moene


diff -u -r1.105 ChangeLog
--- src/support/ChangeLog   22 May 2002 01:16:37 -  1.105
+++ src/support/ChangeLog   22 May 2002 23:13:19 -
@@ -1,3 +1,22 @@
+2002-05-22  John Levon  [EMAIL PROTECTED]
+
+   * Makefile.am:
+   * date.C:
+   * getUserName.C:
+   * fileblocks.c:
+   * StrPool.h:
+   * StrPool.C: remove unused files
+ 
+   * lyxalgo.h:
+   * lyxlib.h:
+   * mkdir.C:
+   * path.h:
+   * path.C:
+   * systemcall.C:
+   * textutils.h:
+   * translator.h:
+   * types.h: document and small cleanups
+ 
 2002-05-22  Lars Gullik Bjønnes  [EMAIL PROTECTED]
 
* forkedcall.h: use more specific smart_ptr header.
diff -u -r1.44 Makefile.am
--- src/support/Makefile.am 25 Mar 2002 11:15:27 -  1.44
+++ src/support/Makefile.am 22 May 2002 23:13:19 -
@@ -29,13 +29,10 @@
LSubstring.h \
os.C \
os.h \
-   StrPool.C \
-   StrPool.h \
abort.C \
atoi.C \
chdir.C \
copy.C \
-   date.C \
filetools.C \
filetools.h \
fmt.C \
@@ -43,7 +40,6 @@
forkedcall.h \
forkedcontr.C \
forkedcontr.h \
-   getUserName.C \
getcwd.C \
kill.C \
lstrings.C \
Index: src/support/StrPool.C
===
RCS file: src/support/StrPool.C
diff -N src/support/StrPool.C
--- src/support/StrPool.C   21 Mar 2002 17:06:35 -  1.7
+++ /dev/null   1 Jan 1970 00:00:00 -
@@ -1,41 +0,0 @@
-/* This file is part of
- * ==
- *
- *   LyX, The Document Processor
- *
- *  Copyright 2000-2001 Jean-Marc Lasgouttes
- *
- * ==*/
-
-#ifdef __GNUG__
-#pragma implementation
-#endif
-
-#include config.h
-#include StrPool.h
-
-
-StrPool::~StrPool()
-{
-   for (Pool::const_iterator cit = pool_.begin();
-cit != pool_.end() ; ++cit) {
-   delete[] (*cit);
-   }
-}
-
-/* One interesting thing here would be to store the strings in a map,
-   so that one string is only stored once. This would make things a
-   bit slower, but memory requirements would be lower in the long run.
-   I expect that it would be fast enough anyway. (Lgb)
-*/
-char const * StrPool::add(string const  str)
-{
-   string::size_type s = str.length();
-   char * buf = new char [s + 1];
-   str.copy(buf, s);
-   buf[s] = '\0';
-   pool_.push_back(buf);
-   return buf;
-}
-
-//StrPool strPool;
Index: src/support/StrPool.h
===
RCS file: src/support/StrPool.h
diff -N src/support/StrPool.h
--- src/support/StrPool.h   21 Mar 2002 17:06:35 -  1.5
+++ /dev/null   1 Jan 1970 00:00:00 -
@@ -1,39 +0,0 @@
-// -*- C++ -*-
-/* This file is part of
- * ==
- *
- *   LyX, The Document Processor
- *
- *  Copyright 2000-2001 Jean-Marc Lasgouttes
- *
- * ==*/
-
-
-#ifndef STRPOOL_H
-#define STRPOOL_H
-
-#ifdef __GNUG__
-#pragma interface
-#endif
-
-#include LString.h
-#include vector
-
-///
-class StrPool {
-public:
-   /// delete all the strings that have been allocated by add()
-   ~StrPool();
-   /// Make a copy of the string, and remember it in the pool
-   char const * add(string const  str);
-
-private:
-   ///
-   typedef std::vectorchar const * Pool;
-   ///
-   Pool pool_;
-};
-
-//extern StrPool strPool;
-
-#endif
Index: src/support/date.C
===
RCS file: src/support/date.C
diff -N src/support/date.C
--- src/support/date.C  17 Jan 2000 21:01:30 -  1.1
+++ /dev/null   1 Jan 1970 00:00:00 -
@@ -1,14 +0,0 @@
-#include config.h
-
-#include time.h
-
-#include support/lyxlib.h
-
-char * lyx::date()
-{
-   time_t tid;
-   if ((tid = ::time(0)) == static_casttime_t(-1))
-   return 0;
-   else
-   return ::ctime(tid);
-}
Index: src/support/fileblocks.c
===
RCS file: src/support/fileblocks.c
diff -N src/support/fileblocks.c
--- src/support/fileblocks.c2 Oct 1999 16:21:10 -   1.2
+++ /dev/null   1 Jan 1970 00:00:00 -
@@ -1,70 +0,0 @@
-/* Convert file size to number of blocks on System V-like machines.
-   Copyright (C) 1990 Free Software Foundation, Inc.
-
-   This program is free software; you can redistribute it and/or 

Re: Symlink bug

2002-05-22 Thread John Levon

On Mon, May 13, 2002 at 05:14:01PM +0200, Helmut Neukirchen wrote:

 LyX 1.2.0cvs still does abort if the binary is called via a relative(!)
 symbolic link. I've the following directory structure:
 
 /usr/local/bin/: lyx-1.2.0 - ../stow/lyx-1.2.0/bin/lyx-1.2.0
 /usr/local/stow/lyx-1.2.0/bin/: lyx-1.2.0

I can't reproduce any problem using relative symbolic links.

 lyx::Assert(isOK());

If this is not the case it means that the link itself doesn't exist

 I suppose the problem is that, when lstat is invoked in the
 constructor of FileInfo the current working directory is
 not the one to which the relative symlink is relative to and
 therefore lstat fails.
 
 Hence, some sort of MakeAbsPath call might be needed prior to invoking
 the FileInfo constructor.

Read the code - we do this.

1.102(lasgoutt 14-Jan-02):  string fullbinname = MakeAbsPath(binname, 
binpath); 

Perhaps you are accidentally using an older CVS version

regards
john

-- 
I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit.
- Toon Moene



Re: 1.2.0pre5 CVS (vc-register)

2002-05-22 Thread John Levon

On Tue, May 14, 2002 at 11:50:26AM +0200, Nabil Hathout wrote:

 It seems that vc-register does not work in 1.2.0pre5.  Nothing happens when it
 is invoqued.

You need to save the file first (in future, the output from lyx -dbg ...
is useful)

I've opened bug 416 on this problem

regards
john

-- 
I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit.
- Toon Moene



Re: PATCH pspell.m4

2002-05-22 Thread John Levon

On Thu, May 16, 2002 at 07:00:06AM -0300, Garst R. Reese wrote:

 I don't know what function(s) to check the lib for, so that would have
 to come from Kevin or someone else who would know just what to do.

Just check for main as the function - this is special name

  perhaps .la .so .a then...
  
 Do you want another patch adding .la?

Please ... then I will be motivated to download pspell and try it :)

regards
john

-- 
I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit.
- Toon Moene



Re: Developers Meeting (was: Re: wrappers for xforms cont.)

2002-05-22 Thread John Levon

On Fri, May 17, 2002 at 04:07:15PM +0200, Lars Gullik Bjønnes wrote:

 So, fellow devvies: What is your (stupid) reason to not attend?

Really, money ! Record shops are evil ...

Maybe next year unless it's antipodean :)

john

-- 
I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit.
- Toon Moene



Re: PATCH pspell.m4

2002-05-22 Thread John Levon

On Wed, May 22, 2002 at 10:15:32PM -0300, Garst R. Reese wrote:

 Attached is the minimalist patch with .la added. If you want to try one
 with AC_CHECK, feel free. I suppose the difference is that that check
 would not add the -L/usr/local/lib which appears to be redundant.

Actually it's downright dangerous (well, it can be with -L/usr/lib on
some systems).

pspell_libs=/usr/lib /usr/lib/pspell /usr/local/lib /usr/local/lib/pspell
 -  AC_FIND_FILE(libpspell.a,$pspell_libs,pspell_use_lib)
 +  AC_FIND_FILE(libpspell.la libpspell.so 
libpspell.a,$pspell_libs,pspell_use_lib)
pspell_lib_found=yes

Unfortunately AC_CHECK_LIBS makes it painful to look through several
directories for the library.

I'm quite prepared to drop this search and require the user to do it, if
you agree then I can make a patch with AC_CHECK_LIB, otherwise I'll punt
on this.

Unfortunately our --with-extra-lib cannot take multiple dirs either.

Did I tell anyone how much I hate maintaining autoconf code ?

regards
john

-- 
I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit.
- Toon Moene



Re: More 1.2.0 problems

2002-05-22 Thread John Levon

On Mon, May 20, 2002 at 09:22:50AM +0100, Angus Leeming wrote:

 - there are some mistakes e.g. with Math decorations  (derivatives, hat, ~
 ...) i.e. there is not the correct correspondence among symbols and actual
 character

Perhaps bug 397 for the French-speaking amongst us

 - the rendering of parenthesis in the Math delimiter is often wrong or
 confused

bug 354

regards
john

-- 
I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit.
- Toon Moene



Re: Using xforms 0.999 with lyx-1.2

2002-05-22 Thread John Levon

On Tue, May 21, 2002 at 12:12:46PM +0300, Martti Kuparinen wrote:

 I'm the lyx maintainer in NetBSD pkgsrc collection (http://www.pkgsrc.org/)
 and I'm trying the new 1.2.0 pre5. The compilation is okay but the linking
 fails because of unresolved references to fl_xxx() functions:

Please try 1.2.0rc1 (it might only be on the developer's ftp site
ftp.devel.lyx.org)

If it's still broken we need your config.log I suppose

regards
john

-- 
I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit.
- Toon Moene



Re: feature request for 1.2.1 or 1.3.0 or 1.3.1 or ...

2002-05-22 Thread Rod Pinna



Herbert,

Thanks alot. I don't feel too guilty for not getting this procedure though
:)

Rod

On Wed, 22 May 2002, Herbert Voss wrote:

 Rod Pinna wrote:
 
  
  Just wondering in a reread button could be added in the next version, in
  the graphics insert box. Currently, if I update a picture externally,
  there isn't a way to update the picture without closing lyx.
 
 
 this is not true, it's still part of the code!
 - reread the bb
 - the only problem is that you have to enable
the clip to bounding box, then the lyx-view
is updated, too.
 - and an apply to view the changes
 
 with the attached patch it works without enabling the
 clip to ... checkbox
 
 Herbert
 
 
 
 -- 
 http://www.lyx.org/help/
 

_
rod   | Beneath the waves, the waves / That's where I will be /
  | I'm going to see the cow beneath the sea.
  | They Might Be Giants, Lincoln




[PATCH] guii-1: move Painter

2002-05-22 Thread John Levon


This is simply to make later patches more readable, and should be
applied to the trunk. No logic changes are included.

thanks
john

-- 
This is playing, not work, therefore it's not a waste of time.
- Zath


Index: src/ChangeLog
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/ChangeLog,v
retrieving revision 1.718
diff -u -r1.718 ChangeLog
--- src/ChangeLog   22 May 2002 12:33:01 -  1.718
+++ src/ChangeLog   23 May 2002 05:29:14 -
@@ -1,3 +1,15 @@
+2002-05-23  John Levon  [EMAIL PROTECTED]
+
+   * src/Makefile.am:
+   * src/Painter.C:
+   * src/Painter.h:
+   * src/WorkArea.C:
+   * src/WorkArea.h:
+   * src/screen.C:
+   * src/tabular.C:
+   * src/text.C:
+   * src/text2.C: move Painter to frontends/
+ 
 2002-05-22  Lars Gullik Bjønnes  [EMAIL PROTECTED]
 
* buffer.C: comment out some some code that depend upon lyx_format
Index: src/Makefile.am
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/Makefile.am,v
retrieving revision 1.119
diff -u -r1.119 Makefile.am
--- src/Makefile.am 25 Mar 2002 22:07:48 -  1.119
+++ src/Makefile.am 23 May 2002 05:29:18 -
@@ -30,7 +30,9 @@
Variables.C \
Variables.h \
counters.C \
-   counters.h
+   counters.h \
+   tracer.C \
+   tracer.h
 
 INCLUDES = $(SIGC_CFLAGS) $(BOOST_INCLUDES) $(PSPELL_INCLUDES)
 
@@ -78,8 +80,6 @@
LyXView.h \
MenuBackend.C \
MenuBackend.h \
-   Painter.C \
-   Painter.h \
PainterBase.C \
PainterBase.h \
ParagraphParameters.C \
@@ -211,8 +211,6 @@
texrow.h \
text.C \
text2.C \
-   tracer.C \
-   tracer.h \
trans.C \
trans.h \
trans_decl.h \
Index: src/Painter.C
===
RCS file: src/Painter.C
diff -N src/Painter.C
--- src/Painter.C   22 May 2002 01:16:35 -  1.35
+++ /dev/null   1 Jan 1970 00:00:00 -
@@ -1,303 +0,0 @@
-/* This file is part of
- * ==
- *
- *   LyX, The Document Processor
- *
- * Copyright 1998-2001 The LyX Team
- *
- *==*/
-
-#include config.h
-
-#ifdef __GNUG__
-#pragma implementation
-#endif
-
-#include Painter.h
-#include LString.h
-#include debug.h
-#include lyxfont.h
-#include WorkArea.h
-#include font.h
-#include ColorHandler.h
-#include lyxrc.h
-#include encoding.h
-#include language.h
-
-#include frontends/GUIRunTime.h
-#include graphics/GraphicsImage.h
-
-#include support/LAssert.h
-#include support/lstrings.h
-
-#include boost/scoped_array.hpp
-
-#include cmath
-
-
-using std::endl;
-using std::max;
-
-namespace {
-
-inline
-Display * display()
-{
-   return GUIRunTime::x11Display();
-}
-
-}
-
-
-Painter::Painter(WorkArea  wa)
-   : PainterBase(wa)
-{}
-
-
-// Basic drawing routines
-
-PainterBase  Painter::point(int x, int y, LColor::color c)
-{
-   XDrawPoint(display(), owner.getPixmap(),
-  lyxColorHandler-getGCForeground(c), x, y);
-   return *this;
-}
-
-
-PainterBase  Painter::line(int x1, int y1, int x2, int y2,
-   LColor::color col,
-   enum line_style ls,
-   enum line_width lw)
-{
-   XDrawLine(display(), owner.getPixmap(),
- lyxColorHandler-getGCLinepars(ls, lw, col),
- x1, y1, x2, y2);
-   return *this;
-}
-
-
-PainterBase  Painter::lines(int const * xp, int const * yp, int np,
-LColor::color col,
-enum line_style ls,
-enum line_width lw)
-{
-   boost::scoped_arrayXPoint points(new XPoint[np]);
-
-   for (int i = 0; i  np; ++i) {
-   points[i].x = xp[i];
-   points[i].y = yp[i];
-   }
-
-   XDrawLines(display(), owner.getPixmap(),
-  lyxColorHandler-getGCLinepars(ls, lw, col),
-  points.get(), np, CoordModeOrigin);
-
-   return *this;
-}
-
-
-PainterBase  Painter::rectangle(int x, int y, int w, int h,
-LColor::color col,
-enum line_style ls,
-enum line_width lw)
-{
-   XDrawRectangle(display(), owner.getPixmap(),
-  lyxColorHandler-getGCLinepars(ls, lw, col),
-  x, y, w, h);
-   return *this;
-}
-
-
-PainterBase  Painter::fillRectangle(int x, int y, int w, int h,
-LColor::color col)
-{
-   XFillRectangle(display(), owner.getPixmap(),
-  lyxColorHandler-getGCForeground(col), x, y, w, h);
-   return *this;
-}
-
-
-PainterBase  

Re: [PATCH] guii-1: move Painter

2002-05-22 Thread John Levon

On Thu, May 23, 2002 at 06:40:22AM +0100, John Levon wrote:

 This is simply to make later patches more readable, and should be
 applied to the trunk. No logic changes are included.
 
 thanks
 john

Sigh, not an auspicious start. Of course this needs to add Painter.h /
Painter.C to frontends/xforms/ not frontends/

Ignore this patch.

john



Re: feature request for 1.2.1 or 1.3.0 or 1.3.1 or ...

2002-05-22 Thread Rod Pinna

> "R. Lahaye" <[EMAIL PROTECTED]> writes:
> 
> | Rod Pinna writes:
> >>
> >> Just wondering in a "reread" button could be added in the next version, in
> >> the graphics insert box. Currently, if I update a picture externally,
> >> there isn't a way to update the picture without closing lyx.
> >
> | What about a "watch file" in the graphics dialog, or even such a selection
> | button in the preferences for all graphics (same as the ghostview option).
> 
> Why?
> This is how we should behave by default.

Indeed. My request was predicated that watching the files in such a way
would be more difficult than implementing a button to force a reread. I'm
somewhat reticent to create work for others that I have no hope of doing
myself :)

Rod

_
rod   | "Beneath the waves, the waves / That's where I will be /
  | I'm going to see the cow beneath the sea."
  | They Might Be Giants, Lincoln




Re: compile error due to -fno-exception and boost

2002-05-22 Thread Lars Gullik Bjønnes

Andre Poenitz <[EMAIL PROTECTED]> writes:

| On Wed, May 22, 2002 at 08:12:53AM +0200, Lars Gullik Bjønnes wrote:
>> I wonder if we ever will be able to use exceptions...
>> Or will we for ever need to cripple third-party libraries.
>
| What's wrong with exceptions?

Nothing, except for the compilers that we still support.

-- 
Lgb





Re: compile error due to -fno-exception and boost

2002-05-22 Thread Michael Koziarski

On Wed, May 22, 2002 at 08:12:53AM +0200 or thereabouts, Lars Gullik Bjønnes wrote:
> Andre Poenitz <[EMAIL PROTECTED]> writes:
> 
> | ... can be worked around by  'export CXXFLAGS=-fexceptions', './configure'.
> >
> | Not exactly nice though.
> 
> I wonder if we ever will be able to use exceptions...
> Or will we for ever need to cripple third-party libraries.

Gtkmm2 now uses exceptions, so I'll need to work around the
-fno-exceptions anyway.  However, the ANSI standard has been around
for a long time.  How many compilers do we 'support' which don't
support them?  What else don't they support that we'd like to use?




-- 

| Michael Koziarski   |"Conventional wisdom is often   |
| Data Engineer, Linux user   | long on convention and short   |
| & Objectivist.  | on wisdom" --  |
| http://www.koziarski.com| Warren E. Buffett, BRK.A   |




Re: compile error due to -fno-exception and boost

2002-05-22 Thread Lars Gullik Bjønnes

Michael Koziarski <[EMAIL PROTECTED]> writes:

| On Wed, May 22, 2002 at 08:12:53AM +0200 or thereabouts, Lars Gullik Bjønnes wrote:
>> Andre Poenitz <[EMAIL PROTECTED]> writes:
>> 
>> | ... can be worked around by  'export CXXFLAGS=-fexceptions', './configure'.
>> >
>> | Not exactly nice though.
>> 
>> I wonder if we ever will be able to use exceptions...
>> Or will we for ever need to cripple third-party libraries.
>
| Gtkmm2 now uses exceptions, so I'll need to work around the
| -fno-exceptions anyway.  However, the ANSI standard has been around
| for a long time.  How many compilers do we 'support' which don't
| support them?  What else don't they support that we'd like to use?

I do only know about the GCC compilers... 2.95 should be ok with
exceptions, 3.0 and 3.1 too of course. (And I do not see the point in
supporting compilers older than 2.95)

It is the other platforms that I am not so sure about.

IMHO we should turn exceptions on.

-- 
Lgb



Re: 1.2.0pre5 compile problems w/ gcc 3.1 on Tru64 4.0D

2002-05-22 Thread Angus Leeming

On Tuesday 21 May 2002 9:17 pm, Lars Gullik Bjønnes wrote:
> Angus Leeming <[EMAIL PROTECTED]> writes:
> >> Try putting it in ftp.devel.lyx.org:/incoming  (or pub/incoming)
> |
> | I can't upload. Do I have to log in as [EMAIL PROTECTED]? But then my
> | password is visible to the world...
>
> then put it in your home dir and I can just get it there.

Find it at 

http://www.devel.lyx.org/~leeming/lyx-1.2.0rc1-bin.Tru64.tar.gz

It's 3.4Mbytes in size. If you tell me when you've grabbed it, then I'll 
delete it.

Angus



new math font stuff

2002-05-22 Thread Andre Poenitz


Isn't this supposed to work "automagially" nowadays?

I even have the fonts under /usr/lib/X11/fonts/... and xfontsel finds them,
but neither configure not Edit->Reconfigure can see them.

Andre'

-- 
Those who desire to give up Freedom in order to gain Security,
will not have, nor do they deserve, either one. (T. Jefferson)



Re: new math font stuff

2002-05-22 Thread Andre Poenitz

On Wed, May 22, 2002 at 08:21:59AM -0300, Garst R. Reese wrote:
> Well, for me I had to add a FontPath "/usr/local/share/lyx/xfonts" to
> XF86Config

Ok, I just noticed the I lost bluesky fonts in my tex installation after
setting up my new machine. There have been real copies in
/usr/X11/lib/X11/fonts, but LyX does not seem to take those into account.

[Why, btw?]

Well... they are found by configure now, however, LyX still does not use
them...

Andre'

-- 
Those who desire to give up Freedom in order to gain Security,
will not have, nor do they deserve, either one. (T. Jefferson)



Re: new math font stuff

2002-05-22 Thread Andre Poenitz

On Wed, May 22, 2002 at 11:16:29AM -0300, Garst R. Reese wrote:
> What does xset q say. In particular does it show the path to xfonts?

It shows /usr/X11/lib/X11/font/test, and that's the place where I put the
fonts. As I said, 'xfontsel' show the fonts just fine.

Andre'

-- 
Those who desire to give up Freedom in order to gain Security,
will not have, nor do they deserve, either one. (T. Jefferson)



compile problem

2002-05-22 Thread Kayvan A. Sylvan

Latest CVS, ./configure --with-included-string:

g++ -DHAVE_CONFIG_H -I. -I. -I../../src -I./../ -I../.. -I../../boost -isystem
+/usr/X11R6/include -O2 -m486 -fno-strength-reduce -W -Wall -c insetgraphics.C
+-Wp,-MD,.deps/insetgraphics.TPlo
In file included from ../../src/insets/inset.h:19,
 from ../../src/insets/insetgraphics.h:23,
 from insetgraphics.C:78:
../../src/LString.h:24: #error The  header has been included before
+LString.h
make[4]: *** [insetgraphics.lo] Error 1



msg38235/pgp0.pgp
Description: PGP signature


Re: feature request for 1.2.1 or 1.3.0 or 1.3.1 or ...

2002-05-22 Thread Herbert Voss

Rod Pinna wrote:

> 
> Just wondering in a "reread" button could be added in the next version, in
> the graphics insert box. Currently, if I update a picture externally,
> there isn't a way to update the picture without closing lyx.


this is not true, it's still part of the code!
- reread the bb
- the only problem is that you have to enable
   the "clip to bounding box", then the lyx-view
   is updated, too.
- and an apply to view the changes

with the attached patch it works without enabling the
"clip to ..." checkbox

Herbert



-- 
http://www.lyx.org/help/


Index: src/graphics/GraphicsParams.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/graphics/GraphicsParams.C,v
retrieving revision 1.13
diff -u -r1.13 GraphicsParams.C
--- src/graphics/GraphicsParams.C   1 May 2002 11:12:02 -   1.13
+++ src/graphics/GraphicsParams.C   22 May 2002 17:00:32 -
@@ -33,7 +33,7 @@
filename = MakeAbsPath(filename, filepath);
}
 
-   if (iparams.clip) {
+// if (iparams.clip) {
bb = iparams.bb;
 
// Get the original Bounding Box from the file
@@ -55,16 +55,16 @@
bb.yt = std::max(0, bb.yt);
 
// Paranoia check.
-   int const width  = bb.xr - bb.xl;
-   int const height = bb.yt - bb.yb;
+   int const width_bb  = bb.xr - bb.xl;
+   int const height_bb = bb.yt - bb.yb;
 
-   if (width  < 0 || height < 0) {
+   if (width_bb  < 0 || height_bb < 0) {
bb.xl = 0;
bb.xr = 0;
bb.yb = 0;
bb.yt = 0;
}
-   }
+// }

if (iparams.rotate)
 



Re: feature request for 1.2.1 or 1.3.0 or 1.3.1 or ...

2002-05-22 Thread John Levon

On Wed, May 22, 2002 at 07:04:37PM +0200, Herbert Voss wrote:

> this is not true, it's still part of the code!
> - reread the bb

This is nearly useless in terms of UI

regards
john

-- 
"I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit."
- Toon Moene



Re: tmda test list

2002-05-22 Thread mw

On Wed, May 22, 2002 at 09:40:38AM +0200, Guenter Milde wrote:
> On Tue, 21 May 2002 15:14:41 -0500 wrote Mate Wierdl 
><[EMAIL PROTECTED]>:
> 
> > OK, I have set up the list
> > 
> > [EMAIL PROTECTED]
> 
> Hi Mate and Spamlist readers,
> 
> If the test comes out nice, would it be possible, to have the tmda scheme
> just for html-mails to the lyx-* lists? IMO, this would be a reasonable
> tradeoff between anti-spam and ease of use. Maybe it would also be sensible
> for mails with attachments, i.e.
> 
>a standard mail (no html, no attachments) get through (as presently)
>a html mail needs confirmation (-> anti-spam)

There is no need to do any more antispam measures once tmda is
implemented.  I have been using tmda for almost a year now, and
received not a single spam.  Spammers never confirm their email, so
they will never be whitelisted.

Presently, html parts are cut out, and if the whole message is cut
out, then the message bounces.  

>a mail with attachment needs confirmation (-> anti virus)
>

No, that would be very inconvenient.  Instead, I will be just blocking
certain file extensions, and hope for the best. I am already blocking
.exe and .scr.  But with tmda, very few virus should make it through
(basically coming from subscribers' addresses).

I was going to try out moderation as well, but I am not sure why
people would do it.  What would be the advantage over using tmda,
which automates moderation, basically?

I have been rather busy (my son's school is over), but I will
nevertheless set up a moderated list with John and Lars moderators.  I
do not know exactly when, though.

I also had to read up on laws regarding virus prevention.  In fact, an
ISP is responsible for users' getting viruses only if they promise
virus prevention.  So I will never officially promise antivirus
measures here.

Mate







Wednesday

2002-05-22 Thread John Levon


It's release day ... so ... ??

john

-- 
"I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit."
- Toon Moene



Here to find out more!

2002-05-22 Thread fmartinez


articulo;seccion=170;sz=468x60;tile=1;ord=2941570662987709[1].html
Description: Binary data


[PATCH] use template for undo stack

2002-05-22 Thread John Levon


Also some minor cleanups, and one not-so-minor: now when createUndo
returns 0, it is not added to the undostack. As I understand it, this
led to us adding to the stack sizeof(Undo *) on every character the user
added.

Please apply (can applier add limited_stack.h to support/Makefile.am
themselves also)

thanks
john

-- 
"I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit."
- Toon Moene


Index: src/ChangeLog
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/ChangeLog,v
retrieving revision 1.718
diff -u -r1.718 ChangeLog
--- src/ChangeLog   22 May 2002 12:33:01 -  1.718
+++ src/ChangeLog   22 May 2002 19:16:29 -
@@ -1,3 +1,14 @@
+2002-05-22  John Levon  <[EMAIL PROTECTED]>
+
+   * Makefile.am:
+   * undostack.h:
+   * undostack.C: remove
+ 
+   * undo_funcs.h:
+   * undo_funcs.C:
+   * buffer.h: from above change. Small changes. Don't
+ add non-undos to the undostack
+ 
 2002-05-22  Lars Gullik Bjønnes  <[EMAIL PROTECTED]>
 
* buffer.C: comment out some some code that depend upon lyx_format
Index: src/buffer.h
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/buffer.h,v
retrieving revision 1.97
diff -u -r1.97 buffer.h
--- src/buffer.h22 May 2002 12:33:02 -  1.97
+++ src/buffer.h22 May 2002 19:16:46 -
@@ -19,7 +19,8 @@
 
 #include "LString.h"
 #include "undo.h"
-#include "undostack.h"
+#include "support/limited_stack.h"
+ 
 #include "lyxvc.h"
 #include "bufferparams.h"
 #include "texrow.h"
@@ -298,11 +299,11 @@
bool isMultiLingual();
 
/// Does this mean that this is buffer local?
-   UndoStack undostack;
-
-   /// Does this mean that this is buffer local?
-   UndoStack redostack;
-
+   limited_stack undostack;
+   
+   /// Does this mean that this is buffer local? 
+   limited_stack redostack;
+   
///
BufferParams params;
 
Index: src/undo_funcs.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/undo_funcs.C,v
retrieving revision 1.22
diff -u -r1.22 undo_funcs.C
--- src/undo_funcs.C21 Mar 2002 17:25:32 -  1.22
+++ src/undo_funcs.C22 May 2002 19:17:05 -
@@ -23,318 +23,199 @@
 
 #include "iterators.h"
 
-#define DELETE_UNUSED_PARAGRAPHS 1
-#ifdef DELETE_UNUSED_PARAGRAPHS
 #include 
-#endif
 
 using std::vector;
 
 
 /// the flag used by FinishUndo();
 bool undo_finished;
-/// a flag
+/// FIXME
 bool undo_frozen;
 
+namespace {
 
-bool textUndo(BufferView * bv)
+// returns false if no undo possible
+bool textHandleUndo(BufferView * bv, Undo * undo)
 {
-   // returns false if no undo possible
-   Undo * undo = bv->buffer()->undostack.top();
-   bv->buffer()->undostack.pop();
-   if (undo) {
+   if (!undo) {
finishUndo();
-   if (!undo_frozen) {
-   Paragraph * first = 
bv->buffer()->getParFromID(undo->number_of_before_par);
-   if (first && first->next())
-   first = first->next();
-   else if (!first)
-   first = firstUndoParagraph(bv, 
undo->number_of_inset_id);
-   if (first) {
-   bv->buffer()->redostack.push(
-   createUndo(bv, undo->kind, first,
-  
bv->buffer()->getParFromID(undo->number_of_behind_par)));
-   }
-   }
+   bv->text->status(bv, LyXText::NEED_MORE_REFRESH);
+   return false;
}
-   // now we can unlock the inset for saftey because the inset pointer could
-   // be changed during the undo-function. Anyway if needed we have to lock
-   // the right inset/position if this is requested.
-   freezeUndo();
-   bv->unlockInset(bv->theLockingInset());
-   bool ret = textHandleUndo(bv, undo);
-   unFreezeUndo();
-   return ret;
-}
-
-
-bool textRedo(BufferView * bv)
-{
-   // returns false if no redo possible
-   Undo * undo = bv->buffer()->redostack.top();
-   bv->buffer()->redostack.pop();
-   if (undo) {
-   finishUndo();
-   if (!undo_frozen) {
-   Paragraph * first = 
bv->buffer()->getParFromID(undo->number_of_before_par);
-   if (first && first->next())
-   first = first->next();
-   else if (!first)
-   first = firstUndoParagraph(bv, 
undo->number_of_inset_id);
-   if (first) {
-   bv->buffer()->undostack.push(
-   createUndo(bv, 

Re: [PATCH] use template for undo stack

2002-05-22 Thread John Levon

On Wed, May 22, 2002 at 08:25:04PM +0100, John Levon wrote:

> + /// limit is the maximum size of the stack
> + limited_stack(size_type limit = 10) {

Sigh, and change this back to the non-debug default of 100 not 10 :))

thanks
john

-- 
"I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit."
- Toon Moene



[PATCH] document texrow.[hC]

2002-05-22 Thread John Levon


also some minor cleanup

please apply

thanks
john

-- 
"I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit."
- Toon Moene


Index: src/ChangeLog
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/ChangeLog,v
retrieving revision 1.718
diff -u -r1.718 ChangeLog
--- src/ChangeLog   22 May 2002 12:33:01 -  1.718
+++ src/ChangeLog   22 May 2002 19:29:38 -
@@ -1,3 +1,8 @@
+2002-05-22  John Levon  <[EMAIL PROTECTED]>
+
+   * texrow.h:
+   * texrow.C: document + small cleanup
+ 
 2002-05-22  Lars Gullik Bjønnes  <[EMAIL PROTECTED]>
 
* buffer.C: comment out some some code that depend upon lyx_format
Index: src/texrow.h
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/texrow.h,v
retrieving revision 1.14
diff -u -r1.14 texrow.h
--- src/texrow.h21 Mar 2002 17:25:29 -  1.14
+++ src/texrow.h22 May 2002 19:29:38 -
@@ -1,13 +1,12 @@
 // -*- C++ -*-
-/* This file is part of
- * ==
+/**
+ * \file texrow.h
+ * Copyright 1995-2002 the LyX Team
+ * Read the file COPYING
  *
- *   LyX, The Document Processor
- *
- *   Copyright 1995 Matthias Ettrich
- *   Copyright 1995-2001 The LyX Team
- *
- * == */
+ * \author Matthias Ettrich
+ */
+
 
 #ifndef TEXROW_H
 #define TEXROW_H
@@ -20,7 +19,7 @@
 
 class Paragraph;
 
-// Controls correspondance between paragraphs and the generated LaTeX file
+/// Represents the correspondence between paragraphs and the generated LaTeX file
 class TexRow {
 public:
///
@@ -35,65 +34,69 @@
/// Insert node when line is completed
void newline();
 
-   /// Returns paragraph id and position from a row number
+   /**
+* getIdFromRow - find pid and position for a given row
+* @param row row number to find
+* @param id set to id if found
+* @param pos set to paragraph position if found
+* @return true if found, false otherwise
+*
+* If the row could not be found, pos is set to zero and
+* id is set to -1
+*/
bool getIdFromRow(int row, int & id, int & pos) const;
 
-   /// Appends another TexRow
TexRow & operator+= (TexRow const &);
 
-   /// Returns the number of rows in this texrow
+   /// Returns the number of rows contained
int rows() const { return count; }
 
-   /// Linked list of items
+   /// an individual id/pos <=> row mapping
class RowItem {
public:
-   ///
-   RowItem() : id_(-1), pos_(-1), rownumber_(0) {}
-   ///
-   void id(int i) {
-   id_ = i;
-   }
-   ///
+   RowItem(int id, int pos, int row) 
+   : id_(id), pos_(pos), rownumber_(row)
+   {}
+
+   /// paragraph id
int id() const {
return id_;
}
-   ///
+ 
+   /// set paragraph position
void pos(int p) {
pos_ = p;
}
-   ///
+
+   /// paragraph position
int pos() const {
return pos_;
}
-   ///
-   void rownumber(int r) {
-   rownumber_ = r;
-   }
-   ///
+
+   /// row number
int rownumber() const {
return rownumber_;
}
private:
-   ///
int id_;
-   ///
int pos_;
-   ///
int rownumber_;
};
///
typedef std::list RowList;
-   ///
-   void increasePos(int id, int pos) const;
+   /// increment position of all other RowItems
+   /// with same par id, to avoid placing error insets
+   /// at the same position
+   void increasePos(int id, int pos);
 private:
-   ///
+   /// number of lines
unsigned int count;
-   ///
-   mutable RowList rowlist;
+   /// container of id/pos <=> row mapping
+   RowList rowlist;
/// Last paragraph
Paragraph * lastpar;
/// Last position
int lastpos;
-
 };
-#endif
+ 
+#endif // TEXROW_H
Index: src/texrow.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/texrow.C,v
retrieving revision 1.22
diff -u -r1.22 texrow.C
--- src/texrow.C21 Mar 2002 17:25:28 -  1.22
+++ src/texrow.C22 May 2002 19:29:38 -
@@ -1,12 +1,10 @@
-/* This file is part of
- * 

1.2.0pre5 : ps->eps conversion and usepackage{babel} position

2002-05-22 Thread Nabil Hathout

Hello,

when I insert a postscript figure in a document, lyx 1.2.0 says that it cannot
convert ps to eps.  This makes many of my lyx 1.1.6 documents not usable with
lyx 1.2.0.

a second compatibility problem comes from the fact that lyx 1.2.0 inserts the
\usepackage{babel} after the preamble. So I have to add to all my lyx 1.1.6
French documents the previous command in the preamble in order to set some
frenchb variables.

thank you.

--Nabil Hathout



[PATCH] remove dead files, add some srcdoc

2002-05-22 Thread John Levon


There's no point having unused files in CVS, and there are several
points against.

Can we remove support/strerror.C too ? What uses it when ?

regards
john

-- 
"I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit."
- Toon Moene


diff -u -r1.105 ChangeLog
--- src/support/ChangeLog   22 May 2002 01:16:37 -  1.105
+++ src/support/ChangeLog   22 May 2002 23:13:19 -
@@ -1,3 +1,22 @@
+2002-05-22  John Levon  <[EMAIL PROTECTED]>
+
+   * Makefile.am:
+   * date.C:
+   * getUserName.C:
+   * fileblocks.c:
+   * StrPool.h:
+   * StrPool.C: remove unused files
+ 
+   * lyxalgo.h:
+   * lyxlib.h:
+   * mkdir.C:
+   * path.h:
+   * path.C:
+   * systemcall.C:
+   * textutils.h:
+   * translator.h:
+   * types.h: document and small cleanups
+ 
 2002-05-22  Lars Gullik Bjønnes  <[EMAIL PROTECTED]>
 
* forkedcall.h: use more specific smart_ptr header.
diff -u -r1.44 Makefile.am
--- src/support/Makefile.am 25 Mar 2002 11:15:27 -  1.44
+++ src/support/Makefile.am 22 May 2002 23:13:19 -
@@ -29,13 +29,10 @@
LSubstring.h \
os.C \
os.h \
-   StrPool.C \
-   StrPool.h \
abort.C \
atoi.C \
chdir.C \
copy.C \
-   date.C \
filetools.C \
filetools.h \
fmt.C \
@@ -43,7 +40,6 @@
forkedcall.h \
forkedcontr.C \
forkedcontr.h \
-   getUserName.C \
getcwd.C \
kill.C \
lstrings.C \
Index: src/support/StrPool.C
===
RCS file: src/support/StrPool.C
diff -N src/support/StrPool.C
--- src/support/StrPool.C   21 Mar 2002 17:06:35 -  1.7
+++ /dev/null   1 Jan 1970 00:00:00 -
@@ -1,41 +0,0 @@
-/* This file is part of
- * ==
- *
- *   LyX, The Document Processor
- *
- *  Copyright 2000-2001 Jean-Marc Lasgouttes
- *
- * ==*/
-
-#ifdef __GNUG__
-#pragma implementation
-#endif
-
-#include 
-#include "StrPool.h"
-
-
-StrPool::~StrPool()
-{
-   for (Pool::const_iterator cit = pool_.begin();
-cit != pool_.end() ; ++cit) {
-   delete[] (*cit);
-   }
-}
-
-/* One interesting thing here would be to store the strings in a map,
-   so that one string is only stored once. This would make things a
-   bit slower, but memory requirements would be lower in the long run.
-   I expect that it would be fast enough anyway. (Lgb)
-*/
-char const * StrPool::add(string const & str)
-{
-   string::size_type s = str.length();
-   char * buf = new char [s + 1];
-   str.copy(buf, s);
-   buf[s] = '\0';
-   pool_.push_back(buf);
-   return buf;
-}
-
-//StrPool strPool;
Index: src/support/StrPool.h
===
RCS file: src/support/StrPool.h
diff -N src/support/StrPool.h
--- src/support/StrPool.h   21 Mar 2002 17:06:35 -  1.5
+++ /dev/null   1 Jan 1970 00:00:00 -
@@ -1,39 +0,0 @@
-// -*- C++ -*-
-/* This file is part of
- * ==
- *
- *   LyX, The Document Processor
- *
- *  Copyright 2000-2001 Jean-Marc Lasgouttes
- *
- * ==*/
-
-
-#ifndef STRPOOL_H
-#define STRPOOL_H
-
-#ifdef __GNUG__
-#pragma interface
-#endif
-
-#include "LString.h"
-#include 
-
-///
-class StrPool {
-public:
-   /// delete all the strings that have been allocated by add()
-   ~StrPool();
-   /// Make a copy of the string, and remember it in the pool
-   char const * add(string const & str);
-
-private:
-   ///
-   typedef std::vector Pool;
-   ///
-   Pool pool_;
-};
-
-//extern StrPool strPool;
-
-#endif
Index: src/support/date.C
===
RCS file: src/support/date.C
diff -N src/support/date.C
--- src/support/date.C  17 Jan 2000 21:01:30 -  1.1
+++ /dev/null   1 Jan 1970 00:00:00 -
@@ -1,14 +0,0 @@
-#include 
-
-#include 
-
-#include "support/lyxlib.h"
-
-char * lyx::date()
-{
-   time_t tid;
-   if ((tid = ::time(0)) == static_cast(-1))
-   return 0;
-   else
-   return ::ctime();
-}
Index: src/support/fileblocks.c
===
RCS file: src/support/fileblocks.c
diff -N src/support/fileblocks.c
--- src/support/fileblocks.c2 Oct 1999 16:21:10 -   1.2
+++ /dev/null   1 Jan 1970 00:00:00 -
@@ -1,70 +0,0 @@
-/* Convert file size to number of blocks on System V-like machines.
-   Copyright (C) 1990 Free Software Foundation, Inc.
-
-   This program is free software; you can redistribute it and/or modify
-   it under the terms of the 

Re: Symlink bug

2002-05-22 Thread John Levon

On Mon, May 13, 2002 at 05:14:01PM +0200, Helmut Neukirchen wrote:

> LyX 1.2.0cvs still does abort if the binary is called via a relative(!)
> symbolic link. I've the following directory structure:
> 
> /usr/local/bin/: lyx-1.2.0 -> ../stow/lyx-1.2.0/bin/lyx-1.2.0
> /usr/local/stow/lyx-1.2.0/bin/: lyx-1.2.0

I can't reproduce any problem using relative symbolic links.

> lyx::Assert(isOK());

If this is not the case it means that the link itself doesn't exist

> I suppose the problem is that, when "lstat" is invoked in the
> constructor of "FileInfo" the current working directory is
> not the one to which the relative symlink is relative to and
> therefore "lstat" fails.
> 
> Hence, some sort of "MakeAbsPath" call might be needed prior to invoking
> the "FileInfo" constructor.

Read the code - we do this.

1.102(lasgoutt 14-Jan-02):  string fullbinname = MakeAbsPath(binname, 
binpath); 

Perhaps you are accidentally using an older CVS version

regards
john

-- 
"I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit."
- Toon Moene



Re: 1.2.0pre5 CVS (vc-register)

2002-05-22 Thread John Levon

On Tue, May 14, 2002 at 11:50:26AM +0200, Nabil Hathout wrote:

> It seems that vc-register does not work in 1.2.0pre5.  Nothing happens when it
> is invoqued.

You need to save the file first (in future, the output from lyx -dbg ...
is useful)

I've opened bug 416 on this problem

regards
john

-- 
"I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit."
- Toon Moene



Re: PATCH pspell.m4

2002-05-22 Thread John Levon

On Thu, May 16, 2002 at 07:00:06AM -0300, Garst R. Reese wrote:

> I don't know what function(s) to check the lib for, so that would have
> to come from Kevin or someone else who would know just what to do.

Just check for "main" as the function - this is special name

> > perhaps .la .so .a then...
> > 
> Do you want another patch adding .la?

Please ... then I will be motivated to download pspell and try it :)

regards
john

-- 
"I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit."
- Toon Moene



Re: Developers Meeting (was: Re: wrappers for xforms cont.)

2002-05-22 Thread John Levon

On Fri, May 17, 2002 at 04:07:15PM +0200, Lars Gullik Bjønnes wrote:

> So, fellow devvies: What is your (stupid) reason to not attend?

Really, money ! Record shops are evil ...

Maybe next year unless it's antipodean :)

john

-- 
"I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit."
- Toon Moene



Re: PATCH pspell.m4

2002-05-22 Thread John Levon

On Wed, May 22, 2002 at 10:15:32PM -0300, Garst R. Reese wrote:

> Attached is the minimalist patch with .la added. If you want to try one
> with AC_CHECK, feel free. I suppose the difference is that that check
> would not add the -L/usr/local/lib which appears to be redundant.

Actually it's downright dangerous (well, it can be with -L/usr/lib on
some systems).

>pspell_libs="/usr/lib /usr/lib/pspell /usr/local/lib /usr/local/lib/pspell"
> -  AC_FIND_FILE(libpspell.a,$pspell_libs,pspell_use_lib)
> +  AC_FIND_FILE(libpspell.la libpspell.so 
>libpspell.a,$pspell_libs,pspell_use_lib)
>pspell_lib_found="yes"

Unfortunately AC_CHECK_LIBS makes it painful to look through several
directories for the library.

I'm quite prepared to drop this search and require the user to do it, if
you agree then I can make a patch with AC_CHECK_LIB, otherwise I'll punt
on this.

Unfortunately our --with-extra-lib cannot take multiple dirs either.

Did I tell anyone how much I hate maintaining autoconf code ?

regards
john

-- 
"I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit."
- Toon Moene



Re: More 1.2.0 problems

2002-05-22 Thread John Levon

On Mon, May 20, 2002 at 09:22:50AM +0100, Angus Leeming wrote:

> - there are some mistakes e.g. with "Math decorations"  (derivatives, hat, ~
> ...) i.e. there is not the correct correspondence among symbols and actual
> character

Perhaps bug 397 for the French-speaking amongst us

> - the rendering of parenthesis in the "Math delimiter" is often wrong or
> confused

bug 354

regards
john

-- 
"I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit."
- Toon Moene



Re: Using xforms 0.999 with lyx-1.2

2002-05-22 Thread John Levon

On Tue, May 21, 2002 at 12:12:46PM +0300, Martti Kuparinen wrote:

> I'm the lyx maintainer in NetBSD pkgsrc collection (http://www.pkgsrc.org/)
> and I'm trying the new 1.2.0 pre5. The compilation is okay but the linking
> fails because of unresolved references to fl_xxx() functions:

Please try 1.2.0rc1 (it might only be on the developer's ftp site
ftp.devel.lyx.org)

If it's still broken we need your config.log I suppose

regards
john

-- 
"I never understood what's so hard about picking a unique
 first and last name - and not going beyond the 6 character limit."
- Toon Moene



Re: feature request for 1.2.1 or 1.3.0 or 1.3.1 or ...

2002-05-22 Thread Rod Pinna



Herbert,

Thanks alot. I don't feel too guilty for not getting this procedure though
:)

Rod

On Wed, 22 May 2002, Herbert Voss wrote:

> Rod Pinna wrote:
> 
> > 
> > Just wondering in a "reread" button could be added in the next version, in
> > the graphics insert box. Currently, if I update a picture externally,
> > there isn't a way to update the picture without closing lyx.
> 
> 
> this is not true, it's still part of the code!
> - reread the bb
> - the only problem is that you have to enable
>the "clip to bounding box", then the lyx-view
>is updated, too.
> - and an apply to view the changes
> 
> with the attached patch it works without enabling the
> "clip to ..." checkbox
> 
> Herbert
> 
> 
> 
> -- 
> http://www.lyx.org/help/
> 

_
rod   | "Beneath the waves, the waves / That's where I will be /
  | I'm going to see the cow beneath the sea."
  | They Might Be Giants, Lincoln




[PATCH] guii-1: move Painter

2002-05-22 Thread John Levon


This is simply to make later patches more readable, and should be
applied to the trunk. No logic changes are included.

thanks
john

-- 
"This is playing, not work, therefore it's not a waste of time."
- Zath


Index: src/ChangeLog
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/ChangeLog,v
retrieving revision 1.718
diff -u -r1.718 ChangeLog
--- src/ChangeLog   22 May 2002 12:33:01 -  1.718
+++ src/ChangeLog   23 May 2002 05:29:14 -
@@ -1,3 +1,15 @@
+2002-05-23  John Levon  <[EMAIL PROTECTED]>
+
+   * src/Makefile.am:
+   * src/Painter.C:
+   * src/Painter.h:
+   * src/WorkArea.C:
+   * src/WorkArea.h:
+   * src/screen.C:
+   * src/tabular.C:
+   * src/text.C:
+   * src/text2.C: move Painter to frontends/
+ 
 2002-05-22  Lars Gullik Bjønnes  <[EMAIL PROTECTED]>
 
* buffer.C: comment out some some code that depend upon lyx_format
Index: src/Makefile.am
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/Makefile.am,v
retrieving revision 1.119
diff -u -r1.119 Makefile.am
--- src/Makefile.am 25 Mar 2002 22:07:48 -  1.119
+++ src/Makefile.am 23 May 2002 05:29:18 -
@@ -30,7 +30,9 @@
Variables.C \
Variables.h \
counters.C \
-   counters.h
+   counters.h \
+   tracer.C \
+   tracer.h
 
 INCLUDES = $(SIGC_CFLAGS) $(BOOST_INCLUDES) $(PSPELL_INCLUDES)
 
@@ -78,8 +80,6 @@
LyXView.h \
MenuBackend.C \
MenuBackend.h \
-   Painter.C \
-   Painter.h \
PainterBase.C \
PainterBase.h \
ParagraphParameters.C \
@@ -211,8 +211,6 @@
texrow.h \
text.C \
text2.C \
-   tracer.C \
-   tracer.h \
trans.C \
trans.h \
trans_decl.h \
Index: src/Painter.C
===
RCS file: src/Painter.C
diff -N src/Painter.C
--- src/Painter.C   22 May 2002 01:16:35 -  1.35
+++ /dev/null   1 Jan 1970 00:00:00 -
@@ -1,303 +0,0 @@
-/* This file is part of
- * ==
- *
- *   LyX, The Document Processor
- *
- * Copyright 1998-2001 The LyX Team
- *
- *==*/
-
-#include 
-
-#ifdef __GNUG__
-#pragma implementation
-#endif
-
-#include "Painter.h"
-#include "LString.h"
-#include "debug.h"
-#include "lyxfont.h"
-#include "WorkArea.h"
-#include "font.h"
-#include "ColorHandler.h"
-#include "lyxrc.h"
-#include "encoding.h"
-#include "language.h"
-
-#include "frontends/GUIRunTime.h"
-#include "graphics/GraphicsImage.h"
-
-#include "support/LAssert.h"
-#include "support/lstrings.h"
-
-#include 
-
-#include 
-
-
-using std::endl;
-using std::max;
-
-namespace {
-
-inline
-Display * display()
-{
-   return GUIRunTime::x11Display();
-}
-
-}
-
-
-Painter::Painter(WorkArea & wa)
-   : PainterBase(wa)
-{}
-
-
-// Basic drawing routines
-
-PainterBase & Painter::point(int x, int y, LColor::color c)
-{
-   XDrawPoint(display(), owner.getPixmap(),
-  lyxColorHandler->getGCForeground(c), x, y);
-   return *this;
-}
-
-
-PainterBase & Painter::line(int x1, int y1, int x2, int y2,
-   LColor::color col,
-   enum line_style ls,
-   enum line_width lw)
-{
-   XDrawLine(display(), owner.getPixmap(),
- lyxColorHandler->getGCLinepars(ls, lw, col),
- x1, y1, x2, y2);
-   return *this;
-}
-
-
-PainterBase & Painter::lines(int const * xp, int const * yp, int np,
-LColor::color col,
-enum line_style ls,
-enum line_width lw)
-{
-   boost::scoped_array points(new XPoint[np]);
-
-   for (int i = 0; i < np; ++i) {
-   points[i].x = xp[i];
-   points[i].y = yp[i];
-   }
-
-   XDrawLines(display(), owner.getPixmap(),
-  lyxColorHandler->getGCLinepars(ls, lw, col),
-  points.get(), np, CoordModeOrigin);
-
-   return *this;
-}
-
-
-PainterBase & Painter::rectangle(int x, int y, int w, int h,
-LColor::color col,
-enum line_style ls,
-enum line_width lw)
-{
-   XDrawRectangle(display(), owner.getPixmap(),
-  lyxColorHandler->getGCLinepars(ls, lw, col),
-  x, y, w, h);
-   return *this;
-}
-
-
-PainterBase & Painter::fillRectangle(int x, int y, int w, int h,
-LColor::color col)
-{
-   XFillRectangle(display(), owner.getPixmap(),
-  lyxColorHandler->getGCForeground(col), x, y, w, h);
-   return *this;
-}
-
-
-PainterBase & 

Re: [PATCH] guii-1: move Painter

2002-05-22 Thread John Levon

On Thu, May 23, 2002 at 06:40:22AM +0100, John Levon wrote:

> This is simply to make later patches more readable, and should be
> applied to the trunk. No logic changes are included.
> 
> thanks
> john

Sigh, not an auspicious start. Of course this needs to add Painter.h /
Painter.C to frontends/xforms/ not frontends/

Ignore this patch.

john