Re: Problem with INSTALL.Win32 -

2006-02-28 Thread Angus Leeming
Joost Verburg <[EMAIL PROTECTED]> writes:
> Thanks for these detailed instructions. Maybe it would be a good idea to 
> update the old build_lyxwin script to automate parts of the process. If 
> this is not going to happen, make sure that it's removed so it won't 
> confuse people.

I'll try and do so tomorrow.

Angus

ps Michael, Vielen Dank!





Re: Problem with INSTALL.Win32 -

2006-02-28 Thread Joost Verburg

Michael Gerz wrote:
> I cleaned up and updated my compile instructions (see attachment). If
> you like to, you can have a look at my file and update INSTALL.Win32
> accordingly (sorry, I will have no time before next weekend).

Thanks for these detailed instructions. Maybe it would be a good idea to 
update the old build_lyxwin script to automate parts of the process. If 
this is not going to happen, make sure that it's removed so it won't 
confuse people.


Joost


Re: Problem with INSTALL.Win32 -

2006-02-28 Thread Michael Gerz

[EMAIL PROTECTED] wrote:


I think INSTALL.Win32 is seriously out of date and needs to be looked over
by someonw who knows this stuff... Here's a patch where I'm *guessing* -
it should *not* be applied as it is.

I changed 'MinSYS' be changed into 'MSYS', is that correct?

Does the procedure described in this file even work?

Maybe the file should refer to the Windows installers that exist?

/Christian
 


Christian, Angus, Uwe,

today I managed to compile LyX 1.4.0 using MinGW (as usual...). Ok, I 
had to use cygwin's automake but this won't be a problem for the final 
LyX 1.4 tar package.


I cleaned up and updated my compile instructions (see attachment). If 
you like to, you can have a look at my file and update INSTALL.Win32 
accordingly (sorry, I will have no time before next weekend).


Please note that my compile instructions differ in two ways from what is 
described in INSTALL.Win32 and supported by the build scripts in 
./development/Win32/...:


- I link the Qt library statically rather than dynamically (link times 
are below 4 minutes on my 3 GHz machine).
- I use Aspell 0.60.4 rather than 0.50.X (much fewer problems when 
building with MinGW)


There seems to be an apparent bug in 
./development/Win32/packaging/package_lyxwin.sh: AFAICS, LyX 1.4 no 
longer has a "lyx" directory in "Resources". The script should be fixed 
independently from INSTALL.Win32. Does anybody volunteer?


Michael


1 MinGW & MSYS

1.1 Download the following packages from http://www.mingw.org/download.shtml

  binutils-2.16.91-...tar.gz
  gcc-core-3.4.5-...tar.gz
  gcc-g++-3.4.5-...tar.gz
  mingw32-make-3.80.0-3.tar.gz
  mingw-runtime-3.9.tar.gz
  mingw-utils-0.3.tar.gz
  MSYS-1.0.11-...exe
  msys-autoconf-2.59.tar.bz2
  msys-automake-1.8.2.tar.bz2
  msysDTK-1.0.1.exe
  msys-libtool-1.5.tar.bz2
  w32api-3.6.tar.gz

1.2 Install in C:\MinGW

  binutils, gcc-core, gcc-g++, mingw32-make, mingw-runtime,
  mingw-utils, w32api

1.3 Install in C:\msys

  MSYS, msys-autoconf, msys-automake, msysDTK, msys-libtool

--

2. Gettext & Libiconv

2.1 Download the following packages from 
http://www.gnu.org/software/gettext/gettext.html

  gettext-tools-0.13.1.bin.woe32.zip
  gettext-runtime-0.13.1.bin.woe32.zip
  libiconv-1.9.1.bin.woe32.zip

2.2 Extract the three packages in C:\MinGW

--

3 qtwin

3.1 Get the latest CVS version

Open the MSYS window/bash. In your home directory, enter

  cvs -d :pserver:[EMAIL PROTECTED]:/cvsroot/qtwin login
   (no password)
  cvs -z3 -d :pserver:[EMAIL PROTECTED]:/cvsroot/qtwin co \
 -r QT_WIN32_3_3_BRANCH qt-3

3.2 Compile a static (!) QT library (dynamic linking with MinGW causes 
nightmares!)

Open Window command line (run cmd.exe) and enter 

  cd 
  set QMAKESPEC=win32-g++
  setenv.bat
  configure.bat -release -static

--

4. Aspell

4.1 Download the following packages from http://aspell.net/

  aspell-0.60.4.tar.gz
  aspell6-en-6.0-0.tar.bz2
  aspell6-de-20030222-1.tar.bz2

4.2 Extract all files in your MSYS home directory 

4.3 Enter 

  cd aspell-0.60.4

4.4 Edit file ./common/file_util.cpp: Add before line 29

  #include "asc_ctype.hpp"

4.5 Enter

  ./configure --enable-static --disable-shared 
--prefix=c:/Programme/Aspell-0.60.4
  make
  make install

4.6 Compile the German dictionary 

  cd ../aspell6-de-20030222-1
  export PATH=/c/Programme/Aspell-0.60.4/bin:$PATH
  ./configure
  make
  make install

4.7 Repeat 4.6 for the English dictionary

--

5. Compile the LyX sources (given as tar package)

5.1 Enter

  export LDFLAGS="-L/home/user/qt-3/lib -lqtmain -lqt-mt -lopengl32 -lglu32 
-lkernel32 -luser32 -lgdi32 -lcomdlg32 -ladvapi32 -lshell32 -lole32 -loleaut32 
-luuid -limm32 -lwinmm -lwsock32 -lwinspool"

5.2 Edit file ./configure:

  - Search for string "-DQT_DLL"; remove the complete line

  - Search for string "-lqt-mt"; 6 lines above, move "conftest.$ac_ext" in 
front of "$CXXFLAGS"

  ac_link='$CXX -o conftest$ac_exeext conftest.$ac_ext $CXXFLAGS 
$CPPFLAGS $LDFLAGS $LIBS >&5'

5.3 Configure LyX

  export PATH=/c/Programme/Python23:$PATH (you need Python!)

  ./configure --without-x --with-aspell 
--with-extra-prefix=/c/Programme/Aspell-0.60.4 \
  --with-frontend=qt --disable-maintainer-mode --disable-debug 
--enable-optimization   \
  --with-qt-dir=/home/user/qt-3 --prefix=/c/Programme/LyX-1.4 --disable-pch 
\
  --disable-concept-checks --disable-stdlib-debug

5.4 Build LyX

  make
  make install

5.5 Create DTL tools

  cd ./development/Win32/packaging/dtl
  make

5.6 Package LyX

Re: project structure

2006-02-28 Thread Andre Poenitz
On Mon, Feb 27, 2006 at 09:40:43AM +0100, Lars Gullik Bjønnes wrote:
> But if you are only talking about the translations, then I am more
> inclined to agree that those could be in a repo/module of their own.

Would be nice.

Andre'


Re: Lyx 1.4 matbb/mathcal/mathrm issue

2006-02-28 Thread Andre Poenitz
On Tue, Feb 28, 2006 at 10:55:14AM +0100, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
> 
> >> If we can get some more people to test this and also test other
> >> operations to try to make sure that no regressions are introcuced,
> >> then if all agree we can have this too for 1.4.0.
> 
> Martin> Did the following tests.
> 
> What bothers me with this patch is that I never really understood what
> the semantics of niceInsert are (wrt other inserts).

Cut the selection (if there is any), create the inset, go to a suitable
cell, paste the previously cut stuff there.

That was at least the intention.

Andre'


Re: Source cosmetics

2006-02-28 Thread Andre Poenitz
On Mon, Feb 27, 2006 at 09:29:25AM +0100, Lars Gullik Bjønnes wrote:
> Not sure... I see that as a limitation in Java. Nothing that we should
> absolutely try to mimic.

No, but it doesn't hurt and is really nice to grep for stuff in #include
lines and main text. And it makes editor macros for 'I am in a class
member implementation and want to go to the definition of the class'
dead easy.

Andre'


Re: CVS build error on windows

2006-02-28 Thread Andre Poenitz
On Mon, Feb 27, 2006 at 11:00:01AM +, Angus Leeming wrote:
> Careful! Paul said he was using VS2005, so the .vcproj file he posts won't be
> useable by VS2003 people. (Unless there's a compatability switch; dunno.)

No. The conversion is (as usual..) one-way.

Just save the 2005 project files in parallel to the 2003 files (and
maintain both ...)

Andre'


Re: Source cosmetics

2006-02-28 Thread Andre Poenitz
On Sun, Feb 26, 2006 at 02:43:34PM +0100, [EMAIL PROTECTED] wrote:
> On Sun, 26 Feb 2006, Andre Poenitz wrote:
> 
> > Since LyX uses svn now and svn is a bit more forgiving when it comes
> > to renaming files I thought it would be a good idea to talk a bit 
> > about 'source cosmetics', most notably renaming classes and files.
> 
> Besides being "preittier", and that we all like to tweak, I think a change 
> like this would make it easier for a new developer to know what's what...
> 
> Wouldn't this be quite a lot of work?

A bit, but managable. I've done siilar things to projects in the order
of maybe 1/4 of LyX, so it should be do-able for LyX.

> > ... I propose to use
> > 
> >CamelBump.h
> >CamelBump.C
> > 
> > implementing 
> > 
> >   namespace lyx {
> > 
> > class CamelBump;
> > 
> >   }
> > 
> > i.e. no {lyx,LyX,L}-prefix, instead everything in namespace lyx, usually one
> > class per .h/.C combo, and files named the same way as the class.
> 
> I'm not at all familiar with the code... is the majority of the classes in
> the lyx namespace?

No. But I think they should. On the other hand I don't see much reason
for nesting namespace much further than that.
 
> > I'd probaly also rename math_fooinset/MathFooInset to InsetFoo/InsetFoo.
> 
> Eh... also in the lyx namespace?

Yes.

 
> > Opinions?
> 
> I'd probably not notice that the lyx namespace is assumed as default when
> there's nothing in the name that indicates this. I wouldn't mind having
> something like 'lyx_' prepended to indicate the namespace.

In every class/free function? Nah..

Andre'


Re: Source cosmetics

2006-02-28 Thread Andre Poenitz
On Sun, Feb 26, 2006 at 04:11:51PM +, John Spray wrote:
> On Sun, 2006-02-26 at 15:50 +0100, Lars Gullik Bjønnes wrote:
> > Sometime ago we even agreed on *.C -> *.cxx change. But today to aim
> > for a what seems to be commonly used I'd use *.C -> *.cpp instead.
> 
> I can't find this in the list archive - why was it thought a good idea?
> I personally like being able to do "foo.[Ch]".

Me too, but foo.{cpp,h} is only slightly less convenient and for some
reason I get the impression we started caring for Windows people. And
they certainly don't like .C for C++ files (even if they could work
around that)

So I really don't have a strong opinion on that one.

Andre'


Re: Lyx 1.4 matbb/mathcal/mathrm issue

2006-02-28 Thread Andre Poenitz
On Mon, Feb 27, 2006 at 10:07:44AM +0100, Jean-Marc Lasgouttes wrote:
> > "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes:
> 
> >> you mean \mathbb{R}, then select and C-M? Typing \mathbbR
> >> gives the expected result to me.
> 
> Andre> That this space is rquired is also a regression and I do not
> Andre> really remember leaving mathed in this state. Could this be
> Andre> related to the 'macroModeClose' changes?
> 
> What do you mean? That \mathbbR should work? That can't be. One needs
> to type something after \mathbb, after all.

\mathbb is a bad example as it most likely get a character argument.
But \frac12 should work.

Andre'


Re: Source cosmetics

2006-02-28 Thread Andre Poenitz
On Sun, Feb 26, 2006 at 04:16:36PM +0200, Martin Vermeer wrote:
> What to do with the lyxtext/text/1/2 mess?

Text.h:

namespace lyx {

class Text {
};

} 


Text.C:

// Implementation.


Re: Lyx 1.4 matbb/mathcal/mathrm issue

2006-02-28 Thread Martin Vermeer
On Tue, Feb 28, 2006 at 07:43:23PM +0100, Georg Baum wrote:
> Am Dienstag, 28. Februar 2006 18:44 schrieb Martin Vermeer:
> 
> > OK if I commit this? It's your fix as much as mine
> 
> Yes, of course.

Done.

- Martin 


pgpF6emm1yB6w.pgp
Description: PGP signature


Re: Lyx 1.4 matbb/mathcal/mathrm issue

2006-02-28 Thread Georg Baum
Am Dienstag, 28. Februar 2006 16:15 schrieb Georg Baum:
> We can be sure that it does not break anything that was not already 
broken
> before Michael did fix the "insert delimiters around selection" bug,

Of course that was Martin.

Sorry,

Georg



Re: Lyx 1.4 matbb/mathcal/mathrm issue

2006-02-28 Thread Georg Baum
Am Dienstag, 28. Februar 2006 18:44 schrieb Martin Vermeer:

> OK if I commit this? It's your fix as much as mine

Yes, of course.


Georg



Re: Lyx 1.4 matbb/mathcal/mathrm issue

2006-02-28 Thread Martin Vermeer
On Tue, Feb 28, 2006 at 05:30:49PM +0100, Lars Gullik Bjønnes wrote:
> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
> 
> | > "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
> | 
> | Georg> What makes me
> | Georg> also sure that this patch is correct is the fact that
> | Georg> niceInsert() is used in 1.3 unconditionally, too.
> | 
> | That is a convincing reason indeed:
> 
> go for it then

Georg,

OK if I commit this? It's your fix as much as mine

- Martin
 
Index: ChangeLog
===
--- ChangeLog   (revision 13279)
+++ ChangeLog   (working copy)
@@ -1,3 +1,8 @@
+2006-02-28  Martin Vermeer  <[EMAIL PROTECTED]>
+
+   * cursor.C (niceInsert): fix (properly) insertion of
+   fonts/decorations around selection
+
 2006-02-25  Georg Baum  <[EMAIL PROTECTED]>
 
* lyxfont.C (lyxWriteChanges): Don't write \lang latex
Index: cursor.C
===
--- cursor.C(revision 13276)
+++ cursor.C(working copy)
@@ -379,6 +379,8 @@
 }
 
 
+// Don't use this routine. It is erroneous: LFUN_PASTE should be called with
+// buffer number, not data to be inserted -- MV 26.02.2006
 void LCursor::paste(string const & data)
 {
if (!data.empty())
@@ -712,7 +714,10 @@
// be careful here: don't use 'pushLeft(t)' as this we need to
// push the clone, not the original
pushLeft(*nextInset());
-   paste(safe);
+   // We may not use niceInsert here (recursion)
+   MathArray ar;
+   asArray(safe, ar);
+   insert(ar);
}
 }
 
Index: mathed/ChangeLog
===
--- mathed/ChangeLog(revision 13279)
+++ mathed/ChangeLog(working copy)
@@ -1,3 +1,8 @@
+2006-02-28  Martin Vermeer  <[EMAIL PROTECTED]>
+
+   * math_nestinset.C (doDispatch): fix (properly) insertion of
+   fonts/decorations around selection
+
 2006-02-23  Jean-Marc Lasgouttes  <[EMAIL PROTECTED]>
 
* math_data.C (x2pos): Place cursor correctly in the case of
Index: mathed/math_nestinset.C
===
--- mathed/math_nestinset.C (revision 13276)
+++ mathed/math_nestinset.C (working copy)
@@ -888,13 +888,7 @@
int cell(0);
if (cmd.argument == "\\root")
cell = 1;
-   // math macros are nest insets and may have 0 cells.
-   // handleNest would crash in this case.
-   if (ar.size() == 1 && (ar[0].nucleus()->asNestInset()) &&
-   ar[0].nucleus()->nargs() > MathInset::idx_type(cell)) {
-   cur.handleNest(ar[0], cell);
-   } else
-   cur.niceInsert(cmd.argument);
+   cur.niceInsert(cmd.argument);
break;
}
 


pgpJcrBiRgCc7.pgp
Description: PGP signature


Re: Lyx 1.4 matbb/mathcal/mathrm issue

2006-02-28 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:

| > "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
| 
| Georg> We can be sure that it does not break anything that was not
| Georg> already broken before Michael did fix the "insert delimiters
| Georg> around selection" bug, because the part of the patch that
| Georg> touches niceInsert() simply reverts that fix. What makes me
| Georg> also sure that this patch is correct is the fact that
| Georg> niceInsert() is used in 1.3 unconditionally, too.
| 
| That is a convincing reason indeed:

go for it then

-- 
Lgb



Re: Lyx 1.4 matbb/mathcal/mathrm issue

2006-02-28 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:

Georg> We can be sure that it does not break anything that was not
Georg> already broken before Michael did fix the "insert delimiters
Georg> around selection" bug, because the part of the patch that
Georg> touches niceInsert() simply reverts that fix. What makes me
Georg> also sure that this patch is correct is the fact that
Georg> niceInsert() is used in 1.3 unconditionally, too.

That is a convincing reason indeed:

JMarc


Re: Lyx 1.4 matbb/mathcal/mathrm issue

2006-02-28 Thread Martin Vermeer
On Tue, 2006-02-28 at 16:19 +0100, Georg Baum wrote:
> Martin Vermeer wrote:
> 
> > How relevant is the semantics of non-working code?
> 
> It is very important;-)
> 
> > LCursor::paste(data) takes a string, and calls LFUN_PASTE with that
> > string as the data to be pasted. Correct syntax would be to call with
> > the buffer number to be pasted from. It cannot and does not work.
> > 
> > niceInsert used this method, expecting it to work. Georg changed it so
> > it does work in all cases he could think of. Even if he overlooked a few
> > (don't think he did), this is still a patch to be applied.
> 
> Everybody should agree that this part of the patch is safe. I guess that
> Jean-Marc was concerned about the part in MathNestInset, where you reverted
> your earlier fix for inserting things around the selection (see my other
> mail).

Yes... I remember that was meant precisely to fix this... wrong fix, and
broke \mathbb R etc.

- Martin



signature.asc
Description: This is a digitally signed message part


Re: Lyx 1.4 matbb/mathcal/mathrm issue

2006-02-28 Thread Georg Baum
Martin Vermeer wrote:

> How relevant is the semantics of non-working code?

It is very important;-)

> LCursor::paste(data) takes a string, and calls LFUN_PASTE with that
> string as the data to be pasted. Correct syntax would be to call with
> the buffer number to be pasted from. It cannot and does not work.
> 
> niceInsert used this method, expecting it to work. Georg changed it so
> it does work in all cases he could think of. Even if he overlooked a few
> (don't think he did), this is still a patch to be applied.

Everybody should agree that this part of the patch is safe. I guess that
Jean-Marc was concerned about the part in MathNestInset, where you reverted
your earlier fix for inserting things around the selection (see my other
mail).


Georg



Focus not returned to text after insert

2006-02-28 Thread Daniel Watkins
This is exactly what I just posted to lyx-users, but in the intended list
this time. :p

Using 1.4.0svn of a couple of days ago, whenever I try to insert anything
that is on the first level of the Insert menu (i.e. 'Insert > Footnote' as
opposed to 'Insert > Note > ...') using the keyboard, focus is not returned
to the text window after the item is inserted. For example, were I to use
'M-i f' to insert a footnote and then typed 'f', the File menu would be
opened.

In addition to this, and possibly a separate issue, if I then press the Meta
key (Alt) again, to return the cursor to the text area (as happens even
under normal LyX conditions) the menus are no longer selected but neither
is the text area usable. Pressing keys on the keyboard does nothing.

Dan



Re: Lyx 1.4 matbb/mathcal/mathrm issue

2006-02-28 Thread Georg Baum
Jean-Marc Lasgouttes wrote:

> What bothers me with this patch is that I never really understood what
> the semantics of niceInsert are (wrt other inserts). So how can we be
> sure that the patch does not break something else?

We can be sure that it does not break anything that was not already broken
before Michael did fix the "insert delimiters around selection" bug,
because the part of the patch that touches niceInsert() simply reverts that
fix.
What makes me also sure that this patch is correct is the fact that
niceInsert() is used in 1.3 unconditionally, too.

I am pretty sure that the following description of niceInsert(arg) is
correct:

Insert the arg at the current cursor possition. If there is a selection, and
if arg has cells, put the selction into the first cell of arg. Otherwise,
replace the selection with arg.


Georg



Re: Lyx 1.4 matbb/mathcal/mathrm issue

2006-02-28 Thread Martin Vermeer
On Tue, 2006-02-28 at 10:55 +0100, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
> 
> >> If we can get some more people to test this and also test other
> >> operations to try to make sure that no regressions are introcuced,
> >> then if all agree we can have this too for 1.4.0.
> 
> Martin> Did the following tests.
> 
> What bothers me with this patch is that I never really understood what
> the semantics of niceInsert are (wrt other inserts). So how can we be
> sure that the patch does not break something else?

How relevant is the semantics of non-working code?

LCursor::paste(data) takes a string, and calls LFUN_PASTE with that
string as the data to be pasted. Correct syntax would be to call with
the buffer number to be pasted from. It cannot and does not work.

niceInsert used this method, expecting it to work. Georg changed it so
it does work in all cases he could think of. Even if he overlooked a few
(don't think he did), this is still a patch to be applied.

LCursor::paste is called from one other place, where it doesn't work
either... let sleeping dogs lie for now ;-)

- Martin



signature.asc
Description: This is a digitally signed message part


Re: Lyx 1.4 matbb/mathcal/mathrm issue

2006-02-28 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:

>> If we can get some more people to test this and also test other
>> operations to try to make sure that no regressions are introcuced,
>> then if all agree we can have this too for 1.4.0.

Martin> Did the following tests.

What bothers me with this patch is that I never really understood what
the semantics of niceInsert are (wrt other inserts). So how can we be
sure that the patch does not break something else?

JMarc


Help > ToC Broken

2006-02-28 Thread Daniel Watkins
Running 1.4.0svn (of a couple of days ago), I click on 'Help > Table of
Contents'. Nothing comes up and I get the following error message (on the
CLI):
  LyX: unable to find documentation file `TOC'. Bad installation?

Is this my installation, documented, or a new bug? A quick Bugzilla search
doesn't turn anything up.

Dan



[Patch] Re: Lyx 1.4 matbb/mathcal/mathrm issue

2006-02-28 Thread Martin Vermeer
On Tue, 2006-02-28 at 16:19 +0200, Martin Vermeer wrote:
> On Tue, 2006-02-28 at 13:02 +0100, Lars Gullik Bjønnes wrote:
> > Martin Vermeer <[EMAIL PROTECTED]> writes:

...

> ...but I may soon have a patch for the above problem...
> 

Being

"Only, with 2), and even with 1) \textrm, it is possible to insert
textual (non-math) fonts, which will lead to incorrect LaTeX if placed
around formulas.

This is of course a well known, unrelated problem. It just becomes a lot
more visible now."

> Joking.

...but only half in jest. See patch.

- Martin

Index: math_fontinset.C
===
--- math_fontinset.C	(revision 13276)
+++ math_fontinset.C	(working copy)
@@ -78,6 +78,25 @@
 }
 
 
+void MathFontInset::write(WriteStream & os) const
+{
+	bool text_type = (name().find("text") != string::npos);
+	os << '\\' << name().c_str() << '{';
+	MathArray::const_iterator end = cell(0).end();
+	MathArray::const_iterator it = cell(0).begin();
+	for (; it < end; ++it)
+		{
+			if ((*it)->asNestInset() && os.latex() && text_type)
+os << '$' << *it << '$';
+			else
+os << *it;
+		}
+	os << '}';
+}
+
+
+
+
 void MathFontInset::validate(LaTeXFeatures & features) const
 {
 	MathNestInset::validate(features);
Index: math_fontinset.h
===
--- math_fontinset.h	(revision 13276)
+++ math_fontinset.h	(working copy)
@@ -39,6 +39,8 @@
 	///
 	void drawT(TextPainter & pi, int x, int y) const;
 	///
+	void write(WriteStream & os) const;
+	///
 	void validate(LaTeXFeatures & features) const;
 	///
 	void infoize(std::ostream & os) const;


signature.asc
Description: This is a digitally signed message part


Re: Lyx 1.4 matbb/mathcal/mathrm issue

2006-02-28 Thread Martin Vermeer
On Tue, 2006-02-28 at 13:02 +0100, Lars Gullik Bjønnes wrote:
> Martin Vermeer <[EMAIL PROTECTED]> writes:
> 
> | On Mon, 2006-02-27 at 14:55 +0100, Lars Gullik Bjønnes wrote:
> | > Joost Verburg <[EMAIL PROTECTED]> writes:
> | > 
> | > | Georg Baum wrote:
> | > | > Fortunately this is easy to fix, see the attached patch. (...)
> | > | > I agree with Joost that it should be in 1.4.0. This is a major
> | > | > problem, and LCursor::paste() is so utterly broken that every
> | > | > replacement that works at least in one single case is better.
> | > | 
> | > | I have tested this patch and can confirm that it works fine and fixes
> | > | the issues, most notably that it is possible again to insert
> | > | blackboard and calligraphic symbols from the math panel.
> | > | 
> | > | This is definitely something for 1.4.0. Lars, what do you think about 
> it?
> | > 
> | > If we can get some more people to test this and also test other
> | > operations to try to make sure that no regressions are introcuced,
> | > then if all agree we can have this too for 1.4.0.
> | 
> | Did the following tests.
> | 
> | - Insert calligraphic font around math selection (complex formula) using
> | 1) math panel
> | 2) menu: Insert->Math->Font change
> | 3) keyboard: control-E.
> | 
> | - Inserted other font variations in the same ways where available.
> | 
> | All work correctly.
> 
> do you think this is enough testing for 1.4.0?

Yes, I would say so.

...but I may soon have a patch for the above problem...

Joking.

- Martin



signature.asc
Description: This is a digitally signed message part


Re: Lyx 1.4 matbb/mathcal/mathrm issue

2006-02-28 Thread Georg Baum
Lars Gullik Bjønnes wrote:

> do you think this is enough testing for 1.4.0?

I also did some more testing, and found no problem except one that also
exists without the patch: http://bugzilla.lyx.org/show_bug.cgi?id=2331

I would say that the patch is tested enough for 1.4.0.

Lars, do you agree? When can we expect 1.4.0 to be released? I am sure that
people will propose more patches for 1.4.0 if it is not released soon. The
easiest way to avoid that would be to release it :-)


Georg



Re: Lyx 1.4 matbb/mathcal/mathrm issue

2006-02-28 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes:

| On Mon, 2006-02-27 at 14:55 +0100, Lars Gullik Bjønnes wrote:
| > Joost Verburg <[EMAIL PROTECTED]> writes:
| > 
| > | Georg Baum wrote:
| > | > Fortunately this is easy to fix, see the attached patch. (...)
| > | > I agree with Joost that it should be in 1.4.0. This is a major
| > | > problem, and LCursor::paste() is so utterly broken that every
| > | > replacement that works at least in one single case is better.
| > | 
| > | I have tested this patch and can confirm that it works fine and fixes
| > | the issues, most notably that it is possible again to insert
| > | blackboard and calligraphic symbols from the math panel.
| > | 
| > | This is definitely something for 1.4.0. Lars, what do you think about it?
| > 
| > If we can get some more people to test this and also test other
| > operations to try to make sure that no regressions are introcuced,
| > then if all agree we can have this too for 1.4.0.
| 
| Did the following tests.
| 
| - Insert calligraphic font around math selection (complex formula) using
| 1) math panel
| 2) menu: Insert->Math->Font change
| 3) keyboard: control-E.
| 
| - Inserted other font variations in the same ways where available.
| 
| All work correctly.

do you think this is enough testing for 1.4.0?

-- 
Lgb



Re: CVS build error on windows

2006-02-28 Thread Angus Leeming
Joost Verburg <[EMAIL PROTECTED]> writes:
> Angus Leeming wrote:
> > Are you volunteering? You'd be made very welcome! (There are no active
> > developers using VS at the moment.)

> I can help by pointing out the specific functions that cause the problems.

> The console window issue is caused by spawnvp in support/forkedcall.c. 
> The MinGW implementation does not show a console window, however the 
> Visual C++ variant does (there seems to be no standard that defines the 
> correct behavior).

spawnvp is a unix-like wrapper for CreateProcess.

http://msdn2.microsoft.com/en-us/library/ms235352.aspx
http://msdn2.microsoft.com/en-us/library/275khfab.aspx
http://msdn.microsoft.com/library/en-us/dllproc/base/createprocess.asp

CreateProcess provides much more control but the code would need some
refactoring to use it. We store an integer id to the created process rather than
a HANDLE (a pointer to void). However, it is possible to go from one to the
other, so that's not a real reason not to make the change.

> Unfortunately I have no knowledge of the LyX source code (I'm just an 
> end-user),

We all have to start somewhere.

> so I cannot provide the patch myself.

Sure you can. Where there's a will there's a way :)

Angus




Re: Lyx 1.4 matbb/mathcal/mathrm issue

2006-02-28 Thread Martin Vermeer
On Mon, 2006-02-27 at 14:55 +0100, Lars Gullik Bjønnes wrote:
> Joost Verburg <[EMAIL PROTECTED]> writes:
> 
> | Georg Baum wrote:
> | > Fortunately this is easy to fix, see the attached patch. (...)
> | > I agree with Joost that it should be in 1.4.0. This is a major
> | > problem, and LCursor::paste() is so utterly broken that every
> | > replacement that works at least in one single case is better.
> | 
> | I have tested this patch and can confirm that it works fine and fixes
> | the issues, most notably that it is possible again to insert
> | blackboard and calligraphic symbols from the math panel.
> | 
> | This is definitely something for 1.4.0. Lars, what do you think about it?
> 
> If we can get some more people to test this and also test other
> operations to try to make sure that no regressions are introcuced,
> then if all agree we can have this too for 1.4.0.

Did the following tests.

- Insert calligraphic font around math selection (complex formula) using
1) math panel
2) menu: Insert->Math->Font change
3) keyboard: control-E.

- Inserted other font variations in the same ways where available.

All work correctly. Only, with 2), and even with 1) \textrm, it is
possible to insert textual (non-math) fonts, which will lead to
incorrect LaTeX if placed around formulas.

This is of course a well known, unrelated problem. It just becomes a lot
more visible now.

- Martin



signature.asc
Description: This is a digitally signed message part