Re: make distcheck: cannot remove '../../po/lyx.pot'

2015-12-15 Thread Scott Kostyshak 
On Tue, Dec 15, 2015 at 02:20:50PM +0100, Jean-Marc Lasgouttes wrote:

> > I have no idea why, but the attached patch seems to fix 'make 
> > distcheck' for me.
> > 
> > Can it go in?
> 
> It is strange that it can fix anything. But it should definitely go
> in.

OK it's in at 7c4a1e16.

> Did you check whether there are other missing entries?

I did not. I'll add this to the release manager checklist.

Scott


signature.asc
Description: PGP signature

Re: 'make distcheck' fails for me when --disable-nls

2015-12-15 Thread Scott Kostyshak 
On Tue, Dec 15, 2015 at 02:31:50PM +0100, Kornel Benko wrote:
> Am Dienstag, 15. Dezember 2015 um 07:23:58, schrieb Scott Kostyshak 
> 
> > 'make distcheck' fails with --disable-nls.
> > 
> > After applying my patch at
> > https://www.mail-archive.com/search?l=mid=20151214211415.GA17643%40cotopaxi
> > 
> > from the following command
> > ./autogen.sh && ./configure --enable-build-type=pre --disable-nls && make 
> > && make check && make distcheck
> > 
> > I get:
> > 
> > Making all in qt4
> > make[6]: Entering directory
> > '/tmp/tmp.LIZufYOGEq/lyx-2.2.0dev/_build/src/frontends/qt4'
> > make[6]: *** No rule to make target 'ui/AboutUi.ui', needed by
> > 'ui_AboutUi.h'.  Stop.
> > make[6]: Leaving directory
> > '/tmp/tmp.LIZufYOGEq/lyx-2.2.0dev/_build/src/frontends/qt4'
> > Makefile:748: recipe for target 'all-recursive' failed
> > make[5]: *** [all-recursive] Error 1
> > 
> > Any idea?
> 
> I cannot see it, works here. Fresh tree (with your patch)
> The only (not relevant) difference is that I used 'make -j12' instead of make 
> only.

hmm thanks for testing. I will try again and if I get the error again I
will investigate.

Scott


signature.asc
Description: PGP signature

Re: beamer workflow

2015-12-15 Thread Scott Kostyshak 
On Tue, Dec 15, 2015 at 03:58:41PM +0100, Edwin Leuven wrote:
> On 12 Nov 2015, at 13:38, Jürgen Spitzmüller  wrote:
> > 2015-11-12 10:43 GMT+01:00 Edwin Leuven:
> > but even so, perhaps we should consider the behaviour that we have with 
> > itemize:
> > 
> >  preserves indent, and  on an empty itemize decreases indent
> > 
> > we could do the same with nesting no?
> > 
> > i think that would be natural
> > 
> > I agree.
> 
> what about the attached?

I do not see an attachment.

Scott


signature.asc
Description: PGP signature

Re: beamer workflow

2015-12-15 Thread Kornel Benko 
Am Dienstag, 15. Dezember 2015 um 12:31:26, schrieb Scott Kostyshak 

> On Tue, Dec 15, 2015 at 03:58:41PM +0100, Edwin Leuven wrote:
> > On 12 Nov 2015, at 13:38, Jürgen Spitzmüller  wrote:
> > > 2015-11-12 10:43 GMT+01:00 Edwin Leuven:
> > > but even so, perhaps we should consider the behaviour that we have with 
> > > itemize:
> > > 
> > >  preserves indent, and  on an empty itemize decreases indent
> > > 
> > > we could do the same with nesting no?
> > > 
> > > i think that would be natural
> > > 
> > > I agree.
> > 
> > what about the attached?
> 
> I do not see an attachment.

It is there, hidden between the html parts.

> Scott

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: beamer workflow

2015-12-15 Thread Edwin Leuven 
On 15 Dec 2015, at 18:36, Kornel Benko  wrote:
> Am Dienstag, 15. Dezember 2015 um 12:31:26, schrieb Scott Kostyshak 
> 
>> On Tue, Dec 15, 2015 at 03:58:41PM +0100, Edwin Leuven wrote:
>>> On 12 Nov 2015, at 13:38, Jürgen Spitzmüller  wrote:
 2015-11-12 10:43 GMT+01:00 Edwin Leuven:
 but even so, perhaps we should consider the behaviour that we have with 
 itemize:
 
  preserves indent, and  on an empty itemize decreases indent
 
 we could do the same with nesting no?
 
 i think that would be natural
 
 I agree.
>>> 
>>> what about the attached?
>> 
>> I do not see an attachment.
> 
> It is there, hidden between the html parts.

another try:



depth.diff
Description: Binary data

Re: [patch] Do not pretend that MSVC 12 can use dependencies compiled with MSVC 10

2015-12-15 Thread Peter Kümmel 

Am 15.12.2015 um 18:34 schrieb Scott Kostyshak:

On Mon, Dec 07, 2015 at 09:53:44PM +0100, Georg Baum wrote:

First, for those who don't know, something about MSVC versions (it is easy
to get confused there):

MSVC 8: Microsoft Visual Studio 2005
MSVC 9: Microsoft Visual Studio 2008
MSVC 10: Microsoft Visual Studio 2010 Don't be mislead by the nice fit!
MSVC 11: Microsoft Visual Studio 2012 From here on we are "one off"!
MSVC 12: Microsoft Visual Studio 2013
MSVC 14: Microsoft Visual Studio 2015

Peter added a workaround for mixing code compiled by MSVC 12 and MSVC 10
some time ago:
http://www.lyx.org/trac/changeset/6b4c3036/lyxgit/ According to
https://msdn.microsoft.com/en-us/library/7sf3txa8.aspx the /vd2 option is
only needed if one wants to violate the C++ standard (using dynamic_cast on
an object being constrcuted does not work in standard conforming compilers).

I'd like to get rid of this for two reasons:

1) Mixing different MSVC versions is a bad idea as explained in the other
thread, so we should not help people to shoot themselves in the foot.

2) We cannot use dynamic_cast on not fully constrcuted objects anyway, since
we support other compilers besides MSVC.

OK to go in?


Was a decision made on this? Peter seems to be around so let's see if he
has a comment. If no one else comments, I would say please commit.

Scott



I already removed the /vd2 flag when adding the download of the new 2013 
dependencies.
But in meantime it shows that it is impossible to use msvc2013 or msvc2015:
http://www.lyx.org/trac/ticket/9892

So when someone wanna use msvc2012 he should enable the 3rdparty build,
-DLYX_3RDPARTY_BUILD=1 .

Peter

Re: [patch] Do not pretend that MSVC 12 can use dependencies compiled with MSVC 10

2015-12-15 Thread Scott Kostyshak 
On Mon, Dec 07, 2015 at 09:53:44PM +0100, Georg Baum wrote:
> First, for those who don't know, something about MSVC versions (it is easy 
> to get confused there):
> 
> MSVC 8: Microsoft Visual Studio 2005
> MSVC 9: Microsoft Visual Studio 2008
> MSVC 10: Microsoft Visual Studio 2010 Don't be mislead by the nice fit!
> MSVC 11: Microsoft Visual Studio 2012 From here on we are "one off"!
> MSVC 12: Microsoft Visual Studio 2013
> MSVC 14: Microsoft Visual Studio 2015
> 
> Peter added a workaround for mixing code compiled by MSVC 12 and MSVC 10 
> some time ago:
> http://www.lyx.org/trac/changeset/6b4c3036/lyxgit/ According to 
> https://msdn.microsoft.com/en-us/library/7sf3txa8.aspx the /vd2 option is 
> only needed if one wants to violate the C++ standard (using dynamic_cast on 
> an object being constrcuted does not work in standard conforming compilers).
> 
> I'd like to get rid of this for two reasons:
> 
> 1) Mixing different MSVC versions is a bad idea as explained in the other 
> thread, so we should not help people to shoot themselves in the foot.
> 
> 2) We cannot use dynamic_cast on not fully constrcuted objects anyway, since 
> we support other compilers besides MSVC.
> 
> OK to go in?

Was a decision made on this? Peter seems to be around so let's see if he
has a comment. If no one else comments, I would say please commit.

Scott


signature.asc
Description: PGP signature

Re: beamer workflow

2015-12-15 Thread Scott Kostyshak 
On Tue, Dec 15, 2015 at 06:40:47PM +0100, Edwin Leuven wrote:
> On 15 Dec 2015, at 18:36, Kornel Benko  wrote:
> > Am Dienstag, 15. Dezember 2015 um 12:31:26, schrieb Scott Kostyshak 
> > 
> >> On Tue, Dec 15, 2015 at 03:58:41PM +0100, Edwin Leuven wrote:
> >>> On 12 Nov 2015, at 13:38, Jürgen Spitzmüller  wrote:
>  2015-11-12 10:43 GMT+01:00 Edwin Leuven:
>  but even so, perhaps we should consider the behaviour that we have with 
>  itemize:
>  
>   preserves indent, and  on an empty itemize decreases 
>  indent
>  
>  we could do the same with nesting no?
>  
>  i think that would be natural
>  
>  I agree.
> >>> 
> >>> what about the attached?
> >> 
> >> I do not see an attachment.
> > 
> > It is there, hidden between the html parts.
> 
> another try:

Ah thanks. On a second look I could find it on the previous email as
well.

Scott


signature.asc
Description: PGP signature

Re: [PATCH] avoid segmentation fault when quitting

2015-12-15 Thread Scott Kostyshak 
On Fri, Dec 11, 2015 at 04:45:41PM +0100, Jean-Marc Lasgouttes wrote:
> 
> It turns out that there was a bad bug in f3cdf74e68bd : this commit
> introduced a static variable used as a cache. This is a bad idea for
> QObjects, as explained in the commit log of patch below.
> 
> Comments welcome.

I do not understand it well but I would say please commit.

Scott


signature.asc
Description: PGP signature

'make distcheck' fails for me when --disable-nls

2015-12-15 Thread Scott Kostyshak 
'make distcheck' fails with --disable-nls.

After applying my patch at
https://www.mail-archive.com/search?l=mid=20151214211415.GA17643%40cotopaxi

from the following command
./autogen.sh && ./configure --enable-build-type=pre --disable-nls && make && 
make check && make distcheck

I get:

Making all in qt4
make[6]: Entering directory
'/tmp/tmp.LIZufYOGEq/lyx-2.2.0dev/_build/src/frontends/qt4'
make[6]: *** No rule to make target 'ui/AboutUi.ui', needed by
'ui_AboutUi.h'.  Stop.
make[6]: Leaving directory
'/tmp/tmp.LIZufYOGEq/lyx-2.2.0dev/_build/src/frontends/qt4'
Makefile:748: recipe for target 'all-recursive' failed
make[5]: *** [all-recursive] Error 1

Any idea?

Scott


signature.asc
Description: PGP signature

Re: make distcheck: cannot remove '../../po/lyx.pot'

2015-12-15 Thread Jean-Marc Lasgouttes 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Le 14/12/2015 22:14, Scott Kostyshak a écrit :
> On Thu, Dec 10, 2015 at 09:35:57PM +0100, Georg Baum wrote:
>> Scott Kostyshak wrote:
>> 
>>> Interesting idea. In this case, a git bisect would be worthless
>>> so I will wait before doing it. Is there a way to test your
>>> theory? If we use 'touch' to update a file and then try?
>> 
>> I'd think so.
> 
> I have no idea why, but the attached patch seems to fix 'make 
> distcheck' for me.
> 
> Can it go in?

It is strange that it can fix anything. But it should definitely go
in. Did you check whether there are other missing entries?

JMarc
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.17 (GNU/Linux)

iQIcBAEBAgAGBQJWcBOyAAoJEM5u12ge/IfVvucP/2HmTB/jKivbnCHnULt1QZni
OEsw1q4SC6Sxizdcc4Ha4VEnY9ZFdpKJfKwCX0sK8AbVGAUPHY+k2bddXhmyJVu/
TujFx/m0ciehOYJ9/4Wxznu6vOYidm9UqP4l+GoOyLqPrhT8BzSeB0JC3PhSwA1C
b4/JwQzx7U5DjPSNB8HC98C65J+MJx34uQ0pqRhBiit8JbU9AZu7TArvtalDzUWw
8xv9lV1jFAN8CTABfizq/89IDWhKbzmndDKpe8NgEjpCBtgm54e8K9TLiFlhIG5i
x1e0RXvut5MpMtKpG9V+0oOjqJEw9yst3u2pvIUZT1DDVY1Gqn3uWCu4TAoDMkQw
t1cv0npixIaKV4ZMmx2QrVhIZP5o9fznMH+3PtMrgrmhQJIo4YaqYuotvojPkS2w
Cm0yl4Rg9J8S413D9UO4Au2iXGuVg0cn1jLOe+j2bZxOezpxQVDMkcT2bV3cfSp0
iN5EKUE6ILDHw+CP5vHWWYlRLo5yvQAbpbY+F8eqj3H3w38A1mtCOaO3fG8CAwfI
1r6On5IbVmwNXzwfG5u3mnP3uC3gWup4UWmjMo3ubL9TyWoWR9UGqsoxMJqYJdOB
yR76Qau5Mi5VEFuaHqYP1fA+9DnHntUbguEc0rJgKPNTnbmTnoe19NbGAeZqLrUq
uBJVnw7BN7ky3wcQJpoG
=7tYM
-END PGP SIGNATURE-

Re: Bundled 3rdparty libraries

2015-12-15 Thread Peter Kümmel 


I pushed the changes, 3rdparty/ is now on the same level as src/.

It also builds on Windows with MinGW now.

The MinGW based system it's the simplest way to get a developer setup on Windows: use Qt installer from qt.io, install 
the MinGW Qt and the MinGW Compiler under Tools (same compiler version which Qt is build with), that's it. And install 
Ninja, the fastest way to build on Windows, ​https://ninja-build.org .


PATH changes with standard Qt installation on C:

set PATH=C:\Qt\5.5\mingw492_32\bin;%PATH%
set PATH=C:\Qt\Tools\mingw492_32\bin;%PATH%

Build:

cmake -GNinja ..\lyx -DLYX_USE_QT=QT5 -DLYX_3RDPARTY_BUILD=1 -DLYX_RELEASE=1
ninja
ninja install/strip

Peter

Re: 'make distcheck' fails for me when --disable-nls

2015-12-15 Thread Kornel Benko 
Am Dienstag, 15. Dezember 2015 um 07:23:58, schrieb Scott Kostyshak 

> 'make distcheck' fails with --disable-nls.
> 
> After applying my patch at
> https://www.mail-archive.com/search?l=mid=20151214211415.GA17643%40cotopaxi
> 
> from the following command
> ./autogen.sh && ./configure --enable-build-type=pre --disable-nls && make && 
> make check && make distcheck
> 
> I get:
> 
> Making all in qt4
> make[6]: Entering directory
> '/tmp/tmp.LIZufYOGEq/lyx-2.2.0dev/_build/src/frontends/qt4'
> make[6]: *** No rule to make target 'ui/AboutUi.ui', needed by
> 'ui_AboutUi.h'.  Stop.
> make[6]: Leaving directory
> '/tmp/tmp.LIZufYOGEq/lyx-2.2.0dev/_build/src/frontends/qt4'
> Makefile:748: recipe for target 'all-recursive' failed
> make[5]: *** [all-recursive] Error 1
> 
> Any idea?

I cannot see it, works here. Fresh tree (with your patch)
The only (not relevant) difference is that I used 'make -j12' instead of make 
only.

> Scott

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: beamer workflow

2015-12-15 Thread Edwin Leuven 
On 12 Nov 2015, at 13:38, Jürgen Spitzmüller  wrote:2015-11-12 10:43 GMT+01:00 Edwin Leuven:
but even so, perhaps we should consider the behaviour that we have with itemize:

 preserves indent, and  on an empty itemize decreases indent

we could do the same with nesting no?

i think that would be naturalI agree.what about the attached?

depth.diff
Description: Binary data