Re: [LyX/master] Re-implement math markers logic.

[Scott Kostyshak]

On Wed, Jan 11, 2017 at 04:35:49PM +, Jean-Marc Lasgouttes wrote:
> commit 89662a6852ca8f68caa557808d7b7e1d669344d4
> Author: Jean-Marc Lasgouttes 
> Date:   Fri Jan 6 09:52:10 2017 +0100
> 
> Re-implement math markers logic.
> 
> The goal of this patch is to be able to properly remove the space
> needed for markers in the case of insets that are inside macros and do
> not need these markers. This was attempted at 9a9a6a8, but did not
> work reliably.
> 
> To this end, the following simplifications are made:
> 
> * instead of drawing its own markers, each inset has a virtual method
>   marker() which prescribes either NO_MARKER, MARKER (normal bottom
>   marker) or MARKER2 (top and bottom marker). All explicit calls to
>   (draw|metrics)Markers(|2) are removed.
> 
> * the space necessary for the markers is now counted in the
>   before/above margins in the row structure. Therefore painting will
>   not happen at (x + 1, y), but just (x,y).
> 
> * the methods drawDecoration are removed.
> 
> * the helper methods InsetMath::(draw|metrics)Markers(|2) are removed
>   and replaced by a new function drawMarkers in MathRow.cpp.
> 
> Now the marker type is kept in the MathRow::Element object (and set to
> NO_MARKER in not editable context) and the marker is accounted for in
> MathRow::(metrics|draw).
> 
> Moreover, the extra pixel for the marker is taken on the before/After
> space if possible. The marker will only require extra space when
> before/after is 0.
> 
> See comment 168 of #8883 to understand what issues are fixed.

Screenshots referenced below are here:

  https://www.dropbox.com/sh/ouw0zkmoeb0iiph/AADVv047Iw2RODHHcEw5cN4oa?dl=0

Starting with this commit, there is a very minor shift of the character
when I press "_" (to get a subscript). The shift is very minor. In the
screenshots, "after" refers to this commit (89662a68), and "before"
refers to commit 89662a68^.

To see the issue, if you flip back and forth between after1.png and
after2.png many times, you should see that the \beta moves. If you shift
between beta1.png and beta2.png, the \beta does not move.

In case the change is hard to see, I also include "difference" pngs,
created with the following commands:

  composite after1.png after2.png -compose difference after_difference.png
  composite before1.png before2.png -compose difference before_difference.png

Scott


signature.asc
Description: PGP signature

Re: Update on 2.3.0 situation and Windows-specific issues

[Uwe Stöhr]

Am 19.03.2018 um 00:44 schrieb Pavel Sanda:


I checked it out. When I used the installer I did not give me any option,
it just 'informed' that MiKTeX is going to be upgraded and forced me to
accept it. That's what I said can make some people mad and decent application
should not do without asking.


You still did not get my point. Average users don't care about 
internals, they just need a running LyX. MiKTeX must be updated to 
assure this.


As said, if you are an expert and have some background knowledge you can 
prevent that the MiKTeX packaging system will be touched by denying any 
package update in the MiKTeX settings. therefore I proposed to add this 
info to the release announcement for experienced users.



I believe that if we add the part of the message I wrote last time which
would simply state something along the lines "If you are not sure, the
answer is most probably Yes." anyone with basic school education would
pass the test, don't you think so?


Again, users that don't understand what the decision is about and press 
No will end up with an unchanged MiKTeX and this will sooner or later 
break their LaTeX setup in such a complete way that you cannot compile 
any LyX document.
The probability of pressing No if you don't understand is 50%. I mean, 
some people are afraid if they don't understand and therefore say no.



Release notes is must read for packagers or maybe also interesting for
people who look for particular fix or feature, general audience will
not read it...


Correct and therefore it is the right place for experts. Average users 
don't read the announcement line by line, also because most users are 
not that familiar with English and our announcements are only in English.


Experienced users with background knowledge will read announcements and 
can also understand what to do.

Off-topic in this thread, but installing experience on Windows was somewhat
frustraing here, mainly because of this on-fly update miktex feature. I have
decent broadband connectivity, but it took *ages* for the update to finish the
first install.


Yes, the first installation can take some time. It will download about 
400 MB. A complete MiKTeX however needs several GB.
However, this is not specific to MiKTeX, if you use TeXLive you will 
need the same download size.



If I were to show LyX to my friend on his Windows computer I
wouldn't be able to reach basic functionality within first hour of install(!).


OK, then the download mirror had problem. I installed LyX today on a PC 
the first time and after 5 minutes everything was ready. Also abroad I 
never needed more than 20 minutes.



Also there seems to be bug, that lyx icon does not disappear from desktop
after unistalling.


So you uninstalled LyX 2.3? Did you install it as admin but uninstall it 
from a non-admin account? In this case the icon cannot be removed 
automatically.


thanks for testing the installer. I find it important that developers 
discussing the installer know how it works and what is possible with it 
and with MiKTeX.


regards Uwe

Re: Fw: Re: LyX 2.3.0 Released

[Uwe Stöhr]

Am 19.03.2018 um 10:17 schrieb Sivan Frenkel:

I am a Win10 user and Scott has directed me to the LyX 2.3 win 
installer, which is still not on the website. The installer worked. I 
have updated my MiKTeX before I ran the installer but it still took a 
while when the MiKTeX was updated in the background.


Very good.


Here are two comments in general on the win installer:
every time there is a major release LyX is installed in a new folder 
(LyX 2.3 in this case). As a result:
(a) All my preferences and shortcuts are reset (as they stay in the LyX 
2.2 folder); this is in contrast to minor releases that are updated 
within the same folder;

(b) I am left with two versions of LyX on my computer.


This is correct. LyX 2.2 and 2.3 can be installed side by side. This way 
you can try out LyX 2.3 but still have LyX 2.2 in case there are 
problems with 2.3.


This behavior was often requested to be able to collaborate with others 
without any problems. For example I am currently working on a operation 
manual with someone using LyX 2.2. We decided to keep with LyX 2.2 until 
the manual is ready. For other documents I use already LyX 2.3.


As for (a): do you know where am I supposed to find the preferences file 
(or its name) so I could copy it to the new folder?


The preferences of LyX 2.3 are stored in e.g.
C:\Users\\AppData\Roaming\LyX2.3

The fileformat and also the format of the preferences of major LyX 
versions differ. Therefore every major LyX version has its own 
preferences. You can try out to copy your preferences from LyX 2.2 but 
we cannot guarantee that they will work correctly also with LyX 2.3. 
because of the different preferences format.


As for (b), for me it is not a big problem as I will simply uninstall 
LyX 2.2 manually


I recommend to keep LyX 2.2 installed. In the past users found some bugs 
in new major LyX versions. If you uninstall LyX 2.2 and encounter an 
unforeseen bug in LyX 2.3 you can have a problem. Just keep your LyX 2.2 
since it doesn't harm and disk space is usually no problem.


thanks for testing and regards
Uwe

Re: lyx2lyx conversion problem

[Richard Kimberly Heck]

On 03/19/2018 04:05 PM, Pavel Sanda wrote:
> I guess we have some lyx2lyx conversion routines problem (from 2.2 format).
>
>
> Load lib/fonts/test/stmary10.lyx:
>
> LyX: Bad integer `\font_tt_scale' [around line 25 of file 
> /trash/lyx_tmpdir.pycDEaV11132/Buffer_convertLyXFormatI11132.lyx current 
> token: '\font_tt_scale' context: '']
> BufferParams::readToken(): Unknown token: 100

This is actually a problem in the conversion TO 2.2 format. I actually
remember this bug,
because I fixed it. I'm guessing that stmary10.lyx got updated before
the bug was fixed,
which I think was shortly before the 2.2 release.

I've fixed it in both stable and master.

Riki

Re: master/branch crash

[Kornel Benko]

Am Montag, 19. März 2018 21:28:09 CET schrieb Pavel Sanda :
> 1. open lib/fonts/test/stmary10.lyx
> 2. go to preferences->display
> 3. instant preview->off (from on)
> 4. apply
> 5. kaboom
> 
> I can reproduce on qt4, not qt5.
> 
> On commandline: CoordCache.cpp (30): break on pointer: 0x96ff0e0 hint: dim
> size: 0
> 
> For some weird reason I can't get meaningful backtrace.
> Anyone can?
> 
> Pavel

Cannot reproduce, neither with qt4.8.7 nor with qt5.6.1

Kornel


signature.asc
Description: This is a digitally signed message part.

master/branch crash

[Pavel Sanda]

1. open lib/fonts/test/stmary10.lyx
2. go to preferences->display
3. instant preview->off (from on)
4. apply
5. kaboom

I can reproduce on qt4, not qt5.

On commandline: CoordCache.cpp (30): break on pointer: 0x96ff0e0 hint: dim 
size: 0

For some weird reason I can't get meaningful backtrace.
Anyone can?

Pavel

lyx2lyx conversion problem

[Pavel Sanda]

I guess we have some lyx2lyx conversion routines problem (from 2.2 format).


Load lib/fonts/test/stmary10.lyx:

LyX: Bad integer `\font_tt_scale' [around line 25 of file 
/trash/lyx_tmpdir.pycDEaV11132/Buffer_convertLyXFormatI11132.lyx current token: 
'\font_tt_scale' context: '']
BufferParams::readToken(): Unknown token: 100

P

Re: [LyX/master] Change lookup order for enchant-2 vs. enchant (prefer the former)

[Kornel Benko]

Am Montag, 19. März 2018 18:40:43 CET schrieb Jürgen Spitzmüller 
:
> Am Montag, den 19.03.2018, 17:31 + schrieb José Abílio Matos:
> > On Monday, 19 March 2018 08.57.24 WET Juergen Spitzmueller wrote:
> > > commit 1ae537c5437d0f1abbf877e40a09ad59385f621b
> > > Author: Juergen Spitzmueller 
> > > Date:   Mon Mar 19 09:56:53 2018 +0100
> > > 
> > > Change lookup order for enchant-2 vs. enchant (prefer the
> > 
> > former)
> > 
> > FWIW I tested this on 2.4 and it works. With both enchant 1 and 2
> > installed lyx was linked against version 2.
> 
> Excellent, thanks for testing!
> 
> Jürgen
> 
> > Regards,

Remains test of cmake build?

Kornel


signature.asc
Description: This is a digitally signed message part.

Re: Configure with automake-1.16

[Joel Kulesza]

On Mon, Mar 19, 2018 at 9:45 AM, Jean-Marc Lasgouttes 
wrote:

> Le 19/03/2018 à 16:37, Richard Kimberly Heck a écrit :
>
>> I did that. Thanks for the patch. Riki, I guess this is OK for 2.3.1.
>>> It is too late for 2.2.4 unfortunately.
>>>
>>
>> Yes, good for 2.3.1.
>>
>
> Thanks, done.
>
> JMarc
>

Thanks JMarc for the legwork and Riki for the approval to integrate it ASAP.

Re: [LyX/master] Change lookup order for enchant-2 vs. enchant (prefer the former)

[Jürgen Spitzmüller]

Am Montag, den 19.03.2018, 17:31 + schrieb José Abílio Matos:
> On Monday, 19 March 2018 08.57.24 WET Juergen Spitzmueller wrote:
> > commit 1ae537c5437d0f1abbf877e40a09ad59385f621b
> > Author: Juergen Spitzmueller 
> > Date:   Mon Mar 19 09:56:53 2018 +0100
> > 
> > Change lookup order for enchant-2 vs. enchant (prefer the
> former)
>  
> FWIW I tested this on 2.4 and it works. With both enchant 1 and 2
> installed lyx was linked against version 2.

Excellent, thanks for testing!

Jürgen

>  
> Regards,
> -- 
> José Abílio

signature.asc
Description: This is a digitally signed message part

Re: [LyX/master] Change lookup order for enchant-2 vs. enchant (prefer the former)

[José Abílio Matos]

On Monday, 19 March 2018 08.57.24 WET Juergen Spitzmueller wrote:
> commit 1ae537c5437d0f1abbf877e40a09ad59385f621b
> Author: Juergen Spitzmueller 
> Date:   Mon Mar 19 09:56:53 2018 +0100
> 
> Change lookup order for enchant-2 vs. enchant (prefer the former)

FWIW I tested this on 2.4 and it works. With both enchant 1 and 2 installed 
lyx was linked against version 2.

Regards,
-- 
José Abílio

Re: integral upper limit adjacent to integral sign

[Scott Kostyshak]

On Mon, Mar 19, 2018 at 11:06:43AM +, Jean-Marc Lasgouttes wrote:
> Le 17/02/2018 à 17:00, Jean-Marc Lasgouttes a écrit :
> > Le 07/02/2018 à 11:56, Enrico Forestieri a écrit :
> > > On Tue, Feb 06, 2018 at 12:19:47PM -0500, Scott Kostyshak wrote:
> > > > I tried a vanilla "git revert" on master and there was a conflict so I
> > > > did not look further. If you have a patch that reverts it, I could test
> > > > that.
> > > 
> > > Please, try the attached.
> > 
> > Here is a version of this revert that still takes care of the \not case.
> > It _seems_ to work and I pushed it to master for evaluation.
> 
> What about 2.3?

No strong opinion.

> Is everyone happy with superscripts now? I know it is not
> perfect, but I am not sure I can improve on it.

You mean in master, right? I think it's OK now. Hopefully we can
eventually offset the subscript and superscript as we used to do, which
corresponds with the PDF output.

Scott


signature.asc
Description: PGP signature

Windows installer: install for all users

[racoon]

Hi,

Under windows some installers ask the user whether the installation 
should be performed for all or only the current user. See for example:


https://ca.nctu.edu.tw/images/how-to-use/2-ftp-client-installation/en-gb/2-Me_or_everyone.png

With the current LyX installer one can only do one or the other 
depending on whether the installer is executed with administrator 
privileges or not. If it is feasible, I think it is helpful to give this 
option - especially for


- those not familiar with how to execute an installation as an 
administrator and


- those who don't know that LyX will install only the one or the other 
depending on how the installation is executed.


Daniel

Re: [RFC][PATCH] native file dialogs

[Richard Kimberly Heck]

On 03/19/2018 11:57 AM, Jean-Marc Lasgouttes wrote:
> Le 19/03/2018 à 15:51, Jürgen Spitzmüller a écrit :
>> Am Montag, den 19.03.2018, 15:03 +0100 schrieb Jean-Marc Lasgouttes:
 I would not be opposed to a backport.
>>>
>>> As it is with native dialogs for everyone by default?
>>
>> Yes.
>
> Riki, what do you think about it? Is it 2.3.2 stuff? I guess it will
> have to be documented.

Yes, I'd guess 2.3.2. It's a reasonably big change. Presumably packagers
will have to
decide how to handle it, too.

Riki

Re: [LyX/master] Fix default spellchecker when only Enchant is available

[Jean-Marc Lasgouttes]

Le 19/03/2018 à 16:38, Richard Kimberly Heck a écrit :

  Fix default spellchecker when only Enchant is available
   This has been annoying me for ages.


Riki,

OK for 2.3.x ?


OK.


Done. I wonder why it took me so long to actually look at the cause.

JMarc

Re: [RFC][PATCH] native file dialogs

[Jean-Marc Lasgouttes]

Le 19/03/2018 à 15:51, Jürgen Spitzmüller a écrit :

Am Montag, den 19.03.2018, 15:03 +0100 schrieb Jean-Marc Lasgouttes:

I would not be opposed to a backport.


As it is with native dialogs for everyone by default?


Yes.


Riki, what do you think about it? Is it 2.3.2 stuff? I guess it will 
have to be documented.


JMarc

Re: Configure with automake-1.16

[Jean-Marc Lasgouttes]

Le 19/03/2018 à 16:37, Richard Kimberly Heck a écrit :

I did that. Thanks for the patch. Riki, I guess this is OK for 2.3.1.
It is too late for 2.2.4 unfortunately.


Yes, good for 2.3.1.


Thanks, done.

JMarc

Re: [LyX/master] Fix default spellchecker when only Enchant is available

[Richard Kimberly Heck]

On 03/19/2018 09:21 AM, Jean-Marc Lasgouttes wrote:
> Le 19/03/2018 à 14:08, Jean-Marc Lasgouttes a écrit :
>> commit ae473b012a9c7605919f3f3bfad35710cab29566
>> Author: Jean-Marc Lasgouttes 
>> Date:   Mon Mar 19 14:07:03 2018 +0100
>>
>>  Fix default spellchecker when only Enchant is available
>>   This has been annoying me for ages.
>
> Riki,
>
> OK for 2.3.x ?

OK.

Riki

Re: Configure with automake-1.16

[Richard Kimberly Heck]

On 03/19/2018 05:14 AM, Jean-Marc Lasgouttes wrote:
> Le 19/03/2018 à 06:26, Joel Kulesza a écrit :
>>>     However, it looks as though autogen.sh was and is
>>>     self-inconsistent.  Line 14 claims LyX requires automake >=1.14
>>>     and Lines 19/23 claimed automake 1.14 or 1.15 were required.  My
>>>     patch only addresses the latter point because I'm not sure how
>>>     cavalier automake version validation should be.  My requests:
>>>
>>>  1. Can a developer commit this patch after it's been cleared via
>>>     discussion/review?
>
> I did that. Thanks for the patch. Riki, I guess this is OK for 2.3.1.
> It is too late for 2.2.4 unfortunately.

Yes, good for 2.3.1.

Riki

Re: [RFC][PATCH] native file dialogs

[Jürgen Spitzmüller]

Am Montag, den 19.03.2018, 15:03 +0100 schrieb Jean-Marc Lasgouttes:
> > I would not be opposed to a backport.
> 
> As it is with native dialogs for everyone by default?

Yes.

Jürgen

> 
> JMarc

signature.asc
Description: This is a digitally signed message part

Re: [RFC][PATCH] native file dialogs

[Jean-Marc Lasgouttes]

Le 19/03/2018 à 14:40, Jürgen Spitzmüller a écrit :

Am Montag, den 19.03.2018, 11:52 +0100 schrieb Jean-Marc Lasgouttes:

It is in now.


Works here.


I am not sure what we want wrt 2.3.x.


I would not be opposed to a backport.


As it is with native dialogs for everyone by default?

JMarc

Re: [RFC][PATCH] native file dialogs

[Jürgen Spitzmüller]

Am Montag, den 19.03.2018, 11:52 +0100 schrieb Jean-Marc Lasgouttes:
> It is in now. 

Works here.

> I am not sure what we want wrt 2.3.x.

I would not be opposed to a backport.

Jürgen

> 
> JMarc

signature.asc
Description: This is a digitally signed message part

Re: [LyX/master] Fix default spellchecker when only Enchant is available

[Jean-Marc Lasgouttes]

Le 19/03/2018 à 14:08, Jean-Marc Lasgouttes a écrit :

commit ae473b012a9c7605919f3f3bfad35710cab29566
Author: Jean-Marc Lasgouttes 
Date:   Mon Mar 19 14:07:03 2018 +0100

 Fix default spellchecker when only Enchant is available
 
 This has been annoying me for ages.


Riki,

OK for 2.3.x ?

JMarc


---
  src/LyXRC.cpp |2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/LyXRC.cpp b/src/LyXRC.cpp
index 471873d..7e2dab8 100644
--- a/src/LyXRC.cpp
+++ b/src/LyXRC.cpp
@@ -284,6 +284,8 @@ void LyXRC::setDefaults()
  // FIXME: this check should test the target platform (darwin)
  #if defined(USE_MACOSX_PACKAGING)
spellchecker = "native";
+#elif defined(USE_ENCHANT)
+   spellchecker = "enchant";
  #elif defined(USE_ASPELL)
spellchecker = "aspell";
  #elif defined(USE_HUNSPELL)

Re: popup IPA toolbar

[Jean-Marc Lasgouttes]

Le 19/03/2018 à 12:09, Jürgen Spitzmüller a écrit :

The menu is inserting an inset, it does not insert any IPA character
(that is done via the toolbar or the keyboard [if you prefer IPA
shortcuts] or the Symbols dialog or via Paste).


IOW we could certainly force the toolbar to check whether the cursor is
in an IPA inset and insert one if not, but I think this would
unnecessarily limit the functionality of the toolbar.


Sorry, I should actually try things before commenting :)

JMarc

Re: popup IPA toolbar

[Jürgen Spitzmüller]

Am Montag, den 19.03.2018, 12:06 +0100 schrieb Jürgen Spitzmüller:
> The toolbar actually always does the same thing: Inserting an IPA
> character. _Where_ this character is inserted, is open (but this is
> also the case for any other toolbar).
> 
> The menu is inserting an inset, it does not insert any IPA character
> (that is done via the toolbar or the keyboard [if you prefer IPA
> shortcuts] or the Symbols dialog or via Paste).

IOW we could certainly force the toolbar to check whether the cursor is
in an IPA inset and insert one if not, but I think this would
unnecessarily limit the functionality of the toolbar.

Jürgen

> 
> Jürgen
> 
> > 
> > JMarc

signature.asc
Description: This is a digitally signed message part

Re: popup IPA toolbar

[Jürgen Spitzmüller]

Am Montag, den 19.03.2018, 11:55 +0100 schrieb Jean-Marc Lasgouttes:
> While I am not a IPA user at all, this strikes me as a very weird
> thing 
> to do. How is the user supposed to know that the toolbar and the menu
> do 
> different things?

The toolbar actually always does the same thing: Inserting an IPA
character. _Where_ this character is inserted, is open (but this is
also the case for any other toolbar).

The menu is inserting an inset, it does not insert any IPA character
(that is done via the toolbar or the keyboard [if you prefer IPA
shortcuts] or the Symbols dialog or via Paste).

Jürgen

> 
> JMarc

signature.asc
Description: This is a digitally signed message part

Re: integral upper limit adjacent to integral sign

[Jean-Marc Lasgouttes]

Le 17/02/2018 à 17:00, Jean-Marc Lasgouttes a écrit :

Le 07/02/2018 à 11:56, Enrico Forestieri a écrit :

On Tue, Feb 06, 2018 at 12:19:47PM -0500, Scott Kostyshak wrote:

I tried a vanilla "git revert" on master and there was a conflict so I
did not look further. If you have a patch that reverts it, I could test
that.


Please, try the attached.


Here is a version of this revert that still takes care of the \not case. 
It _seems_ to work and I pushed it to master for evaluation.


What about 2.3? Is everyone happy with superscripts now? I know it is 
not perfect, but I am not sure I can improve on it.


JMarc

Re: popup IPA toolbar

[Jean-Marc Lasgouttes]

Le 14/03/2018 à 16:35, Jürgen Spitzmüller a écrit :
2018-03-14 16:20 GMT+01:00 mike >:


You are absolutely right.  I missed that sorry.  Thank you very much
for your answer.  I'm in heaven now.


What this doesn't do, though, is to insert an IPA "inset" (which happens 
when you go via Special Characters). This conforms to


\textipa{...} in the output and is recommended for better output quality.


While I am not a IPA user at all, this strikes me as a very weird thing 
to do. How is the user supposed to know that the toolbar and the menu do 
different things?


JMarc

Re: Trac Links to HTTPS

[Jean-Marc Lasgouttes]

Le 17/03/2018 à 21:44, Richard Kimberly Heck a écrit :

https redirects have now been established for lyx.org, wiki.lyx.org, and
git.lyx.org.
Please let me know if there are any problems.


Great news!

JMarc

Re: [RFC][PATCH] native file dialogs

[Jean-Marc Lasgouttes]

Le 14/03/2018 à 12:06, Kornel Benko a écrit :

Only if it affects previous lyx-versions IMHO.
Since lyx ignores (with warning) unknown settings, it should not be needed.


It is in now. I am not sure what we want wrt 2.3.x.

JMarc

Fw: Re: LyX 2.3.0 Released

[Sivan Frenkel]

Hello All,
I am a Win10 user and Scott has directed me to the LyX 2.3 win installer, which 
is still not on the website. The installer worked. I have updated my MiKTeX 
before I ran the installer but it still took a while when the MiKTeX was 
updated in the background.
Here are two comments in general on the win installer:
every time there is a major release LyX is installed in a new folder (LyX 2.3 
in this case). As a result: (a) All my preferences and shortcuts are reset (as 
they stay in the LyX 2.2 folder); this is in contrast to minor releases that 
are updated within the same folder; (b) I am left with two versions of LyX on 
my computer.
As for (a): do you know where am I supposed to find the preferences file (or 
its name) so I could copy it to the new folder?
As for (b), for me it is not a big problem as I will simply uninstall LyX 2.2 
manually, but it may be more of a problem for some of my firends and coworkers 
whom I continuously trying to convince to move to LYX, and they do not want to 
be bothered by manual operations. It would be great if you could add a step in 
the end of the installer where it checks and then asks the user whether to 
uninstall LyX 2.2. 
Thank you very much for the new version.
Best,
Sivan Frenkel

Re: Configure with automake-1.16

[Jean-Marc Lasgouttes]

Le 19/03/2018 à 06:26, Joel Kulesza a écrit :

However, it looks as though autogen.sh was and is
self-inconsistent.  Line 14 claims LyX requires automake >=1.14
and Lines 19/23 claimed automake 1.14 or 1.15 were required.  My
patch only addresses the latter point because I'm not sure how
cavalier automake version validation should be.  My requests:

 1. Can a developer commit this patch after it's been cleared via
discussion/review?


I did that. Thanks for the patch. Riki, I guess this is OK for 2.3.1. It 
is too late for 2.2.4 unfortunately.



 2. Can a developer please review autogen.sh to see which
condition (automake >= 1.14 or automake == 1.14, 1.15, 1.16,
etc.) should be the one validated against?


The intention is indeed to accept everything starting from 1.14. But we 
add versions one by one. I kept the two conditions as they are for now. 
This is one place we do not have to update at every automake minor 
release (although they are actually  even less frequent than LyX major 
releases :)


JMarc