Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-06-02 Thread Jean-Marc Lasgouttes

Le 25/05/2019 à 02:07, Isaac Oscar Gariano a écrit :

Dear Jean and lyx-devel@lists,
So sorry, I have been really busy at work and completely forgot about this!

I hereby grantpermission to license my contributions to LyX under
the GNU GeneralPublic License, version 2 or later


The above grant applies to any code I have, or will, email to 
lyx-devel@lists.


Dear Isaac,

Thanks a lot. I pushed your patch and the undo patch to master. I tried 
to add some description of the patch and its use, but it would be better 
if you can do that in the future. See commit bed546d6f.


I will add your name to credits tomorrow. What is your preferred e-mail 
address?


I have also attached another patch here that turns off the keyboard 
shortcuts ("!" and "space") that turn on/off autocrrect, as I find this 
feature incrediably annoying and it is now unecesary thanks to the 
ability to undo-autocorrects that Jean allready implemented. Note that 
you can still turn autocorrect of/on using the checkbox in the options 
dialog.


Nice! I will push this ASAP.

I have not however removed references to this feature in docoumentation, 
hopefully someone more familiary with the LyX code base will know where 
these are.


Indeed we have to check that. I actually suspect that this feature is 
not documented. How did you learn about it?


And finally, I have another patch, (relying on the above) that places 
autocorrect at the top of `InsetMathNest::interpretChar`, ensuring that 
any autocorrections that trigger on special characters (such as '^' or 
'~') work. In particular, you can now make an autocorrection from "<~" 
to "\preceq"!


How sure are you that it works?

On a side note, when I build LyX on windows (using MSVC 2017), I get an 
annoying console window when I run LyX, it also seems to run slower than 
when I build for linux.


This is controller by the LYX_CONSOLE option of the cmake script. How do 
you build LyX?


JMarc


Re: Probl??me de réversion lineno

2019-06-02 Thread Jean-Marc Lasgouttes

Le 02/06/2019 à 19:19, Jürgen Spitzmüller a écrit :

Am Mittwoch, den 29.05.2019, 16:23 + schrieb Guenter Milde:

I have seen this problem as some stage during my work on lyx2lyx.
So, maybe it was present between 09e69f96d and 45c5b39692c but is
fixed now?


No, it was still there. The problem is that \lineno_options was written
even if there were no options. This choked with following params.

Fixed now.


Thaanks for that. Isn't it though better to output
  \lineno_options ""
? I thought we tried to make the list of buffer parameters as explicit 
and predictable as possible.


JMarc


Re: Probl??me de réversion lineno

2019-06-02 Thread Jürgen Spitzmüller
Am Mittwoch, den 29.05.2019, 16:23 + schrieb Guenter Milde:
> I have seen this problem as some stage during my work on lyx2lyx.
> So, maybe it was present between 09e69f96d and 45c5b39692c but is
> fixed now?

No, it was still there. The problem is that \lineno_options was written
even if there were no options. This choked with following params.

Fixed now.

Jürgen


signature.asc
Description: This is a digitally signed message part


Re: Broken preview

2019-06-02 Thread José Abílio Matos
On Sunday, 2 June 2019 15.19.03 WEST Jürgen Womser-Schütz wrote:
> Python file "lyxpreview2bitmap.py" isn't correct: it seems for me that
> near line 381 the statement
>  "import lyxpreview_tools"
> is missing.
> 
> Jürgen

Oops. It was my mistake. It should be fixed now.

The reason I failed to detect it is that once you do "import lyxpreview_tools" 
it will be known inside the file.

So instead of hiding the import I made it available and now it will work.

Thank you for the report,
-- 
José Abílio




Re: Broken preview

2019-06-02 Thread Kornel Benko
Am Sonntag, 2. Juni 2019, 16:19:03 CEST schrieb Jürgen Womser-Schütz:
> 
> Python file "lyxpreview2bitmap.py" isn't correct: it seems for me that
> near line 381 the statement
>  "import lyxpreview_tools"
> is missing.
> 
> Jürgen
> 
> 

Do you have a mwe?

Kornel


signature.asc
Description: This is a digitally signed message part.


Broken preview

2019-06-02 Thread Jürgen Womser-Schütz


Python file "lyxpreview2bitmap.py" isn't correct: it seems for me that
near line 381 the statement
 "    import lyxpreview_tools"
is missing.

Jürgen



Re: Reverse search with Skim broken again

2019-06-02 Thread Enrico Forestieri
On Sat, Jun 01, 2019 at 02:30:30PM -0700, list_em...@icloud.com wrote:
> 
> I found the problem—it was a broken LyX pipe or something like that.
> (I don’t understand this well.) I discovered that when LyX quit it was
> leaving .lyxpipe.in and .lyxpipe.out and the LyX wiki says that these
> should be deleted when LyX quit.
> 
> How did I figure this out? I was using BibDesk (Mac GUI for BibTeX)
> and the “Send to LyX” command. It failed with a very specific error
> dialog about the LyX pipe. So I figured that Skim must do something
> similar.
> 
> Is it possible to have LyX also provide a helpful error dialog when
> there are pipe problems instead of just failing quietly?

LyX detects dangling pipes on start and automatically deletes them.
I don't know why this mechanism was not working for you.

-- 
Enrico