Re: Stable-Only Branch Related Bug

2019-09-16 Thread Richard Kimberly Heck 
On 9/16/19 3:27 PM, Pavel Sanda wrote:
> On Sun, Sep 15, 2019 at 08:20:48PM -0400, Richard Kimberly Heck wrote:
>> The attached file illustrates the bug: If we have a branch inset, then
>> it seems always to be followed by a \selectlanguage command, followed
>> then by a newline. This inserts unwanted space on export to PDF.
> Is it against the most recent version of branch?
> I was bitten by it in older checkouts but not now.

Yes, this seems to have been #11616.

Riki

Re: Stable-Only Branch Related Bug

2019-09-16 Thread Pavel Sanda 
On Sun, Sep 15, 2019 at 08:20:48PM -0400, Richard Kimberly Heck wrote:
> The attached file illustrates the bug: If we have a branch inset, then
> it seems always to be followed by a \selectlanguage command, followed
> then by a newline. This inserts unwanted space on export to PDF.

Is it against the most recent version of branch?
I was bitten by it in older checkouts but not now.
Pavel

Re: [LyX/master] Fix cut-n-paste error

2019-09-16 Thread Jürgen Spitzmüller 
Am Montag, den 16.09.2019, 11:27 +0200 schrieb Pavel Sanda:
> Looks like real bug for backport? 

That's only in master.

Jürgen


signature.asc
Description: This is a digitally signed message part

Re: [LyX/master] Fix cut-n-paste error

2019-09-16 Thread Pavel Sanda 
On Mon, Sep 16, 2019 at 12:35:32AM +0200, Jean-Marc Lasgouttes wrote:
> commit 3fffa6eb8318939a861ac7f5d4706a5e83cbbab6
> Author: Jean-Marc Lasgouttes 
> Date:   Mon Sep 16 00:46:55 2019 +0200
> 
> Fix cut-n-paste error
> 
> Spotted by cppcheck.
> ---
>  src/insets/InsetTabular.cpp |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/insets/InsetTabular.cpp b/src/insets/InsetTabular.cpp
> index 11fc934..4651c4b 100644
> --- a/src/insets/InsetTabular.cpp
> +++ b/src/insets/InsetTabular.cpp
> @@ -653,7 +653,7 @@ Tabular::CellData & Tabular::CellData::operator=(CellData 
> const & cs)
>   top_line_rtrimmed = cs.top_line_rtrimmed;
>   top_line_ltrimmed = cs.top_line_ltrimmed;
>   bottom_line_rtrimmed = cs.bottom_line_rtrimmed;
> - bottom_line_rtrimmed = cs.bottom_line_rtrimmed;
> + bottom_line_ltrimmed = cs.bottom_line_ltrimmed;

Looks like real bug for backport? 
P