Re: 2.3.x is Closed

2020-01-17 Thread Jürgen Spitzmüller
Am Freitag, den 17.01.2020, 23:57 +0100 schrieb Kornel Benko:
> Still closed? Or may I commit (slightly modified) patch from Eugene?

I understood that you can. Riki said he might add this fix to the
windows binaries, then.

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: 2.3.x is Closed

2020-01-17 Thread Kornel Benko
Am Sun, 12 Jan 2020 13:54:21 -0500
schrieb Richard Kimberly Heck :

> ...for preparation of 2.3.4.
> 
> Riki
> 
> 

Still closed? Or may I commit (slightly modified) patch from Eugene?

Kornel


pgpmII6ikzsCO.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Source for 2.3.4

2020-01-17 Thread Yu Jin
Ok, as you proposed I renamed the first variable and defined the other one
to 0. Also I have found another file, where these needed to be passed to
the IDE, I attached a patch file. It compiles successfully for me now.

Eugene

Am Fr., 17. Jan. 2020 um 12:52 Uhr schrieb Kornel Benko :

> Am Wed, 15 Jan 2020 12:01:22 +0100
> schrieb Kornel Benko :
>
> > Am Tue, 14 Jan 2020 23:41:30 +0100
> > schrieb Kornel Benko :
> >
> > > Am Tue, 14 Jan 2020 22:40:48 +0100
> > > schrieb Yu Jin :
> > >
> > > > Compiling LyX 2.3.3 also works fine for me, but in
> > > >
> https://www.lyx.org/trac/changeset/446769203f157ef5ff964e6d7355f840c8c91cac/lyxgit/development/cmake/lyx.rc
> > > > the lyx.rc file was changed, lines 24 and 25 now contain "
> > > > LYX_RELEASE_LEVEL,LYX_RELEASE_PATCH ", I could not find these
> anywhere else
> > > > (unlike the other two,  LYX_MAJOR_VERSION,LYX_MINOR_VERSION, which
> are set
> > > > in CMakeLists.txt (main folder)). So for me Visual Studio fails to
> compile
> > > > with "unidentified keyword or key" error.
> > > >
> > > > Eugene
> > >
> > > True, these two values are not set. Have to think about it. For now,
> we could use
> > > value '0'.
> > >
> >
> > In CMakeLists.txt:
> > LYX_PATCH_VERSION should be renamed to LYX_RELEASE_LEVEL
> > new LYX_RELEASE_PATCH variable could be set to '0'
> >
> > My 2 ct.
> >
> >   Kornel
>
>
> Eugene, could you elaborate what would the expected/suttisfying content of
> this file
> looks like?
>
> Kornel
> --
> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel
>


rcDefs.patch
Description: Binary data
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


REVTeX_(V.4.1).lyx not compilable

2020-01-17 Thread Kornel Benko

Looks like the sec:level1-label is not found.
Renaming to SEC:LEVEL1 (uppercase) cures it.

Kornel


pgp1K3onYWlTN.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Source for 2.3.4

2020-01-17 Thread Kornel Benko
Am Wed, 15 Jan 2020 12:01:22 +0100
schrieb Kornel Benko :

> Am Tue, 14 Jan 2020 23:41:30 +0100
> schrieb Kornel Benko :
> 
> > Am Tue, 14 Jan 2020 22:40:48 +0100
> > schrieb Yu Jin :
> >   
> > > Compiling LyX 2.3.3 also works fine for me, but in
> > > https://www.lyx.org/trac/changeset/446769203f157ef5ff964e6d7355f840c8c91cac/lyxgit/development/cmake/lyx.rc
> > > the lyx.rc file was changed, lines 24 and 25 now contain "
> > > LYX_RELEASE_LEVEL,LYX_RELEASE_PATCH ", I could not find these anywhere 
> > > else
> > > (unlike the other two,  LYX_MAJOR_VERSION,LYX_MINOR_VERSION, which are set
> > > in CMakeLists.txt (main folder)). So for me Visual Studio fails to compile
> > > with "unidentified keyword or key" error.
> > > 
> > > Eugene
> > 
> > True, these two values are not set. Have to think about it. For now, we 
> > could use
> > value '0'.
> >   
> 
> In CMakeLists.txt:
> LYX_PATCH_VERSION should be renamed to LYX_RELEASE_LEVEL
> new LYX_RELEASE_PATCH variable could be set to '0'
> 
> My 2 ct.
> 
>   Kornel


Eugene, could you elaborate what would the expected/suttisfying content of this 
file
looks like?

Kornel


pgpcx2G2Jq7CC.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel