Re: Patches for Python scripts
On 1/28/21 10:51 PM, Thibaut Cuvelier wrote: > Dear list, > > While working on the ePub output, I ran through many Python scripts. I > corrected a few bgs and a lot of formatting, plus one feature (find > Java in the Windows registry in configure.py), here are the patches. > May I push them on the master branch? José, can you look at these please? Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Patches for Python scripts
On 1/28/21 10:51 PM, Thibaut Cuvelier wrote: > Dear list, > > While working on the ePub output, I ran through many Python scripts. I > corrected a few bgs and a lot of formatting, plus one feature (find > Java in the Windows registry in configure.py), here are the patches. > May I push them on the master branch? José knows more about Python than any of us (and some of us know a fair bit!). Let's see what he has to say. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests for Additioonal.lyx lyx2lyx round trip failing on master
On Thu, Jan 28, 2021 at 08:45:19AM +0100, Jürgen Spitzmüller wrote: > Am Montag, dem 25.01.2021 um 15:09 -0500 schrieb Scott Kostyshak: > > The "doc/Additional" ctests all pass now, but the following ctests > > for > > the Spanish Additional manual fail: > > > > 2179 - export/doc/es/Additional_lyx16 (Failed) > > 2180 - export/doc/es/Additional_lyx20 (Failed) > > 2181 - export/doc/es/Additional_lyx21 (Failed) > > 2182 - export/doc/es/Additional_lyx22 (Failed) > > 2183 - export/doc/es/Additional_lyx23 (Failed) > > > > It seems they fail the convergence criteria of the test. That is, > > with > > successive round trips the .lyx files keep changing. This is expected > > in > > some cases (and we can adapt the tests), but I don't know enough to > > know > > whether it's expected here. Also, it was surprising that the English > > version converges but not the Spanish version. Here [1] is a > > screenshot > > of the Spanish Additional manual after a few iterations. > > Interestingly, > > the first column has only one pair of ERTs, but the second and third > > columns show the failed convergence. Here [2] is a screenshot of the > > English Additional manual in case it is helpful for comparison. > > > > Let me know if I should adapt the tests (i.e., if the failed > > convergence > > is unavoidable or if it is avoidable but just not worth the time or > > complexity to fix). > > Might be fixed after 364532a724c3 Thanks for the fix. Tested and works well. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: master: French Additional manual 2.3.x export -> failed compilation
On Thu, Jan 28, 2021 at 10:15:20AM +0100, Kornel Benko wrote: > Am Thu, 28 Jan 2021 09:26:18 +0100 > schrieb Jürgen Spitzmüller : > > > Am Mittwoch, dem 27.01.2021 um 20:09 -0500 schrieb Scott Kostyshak: > > > The following ctests are failing: > > > > > > 2416 - export/doc/fr/Additional_lyx22 (Failed) > > > 2417 - export/doc/fr/Additional_lyx23 (Failed) > > > > > > I think it is because of the non-default language in the table cell. > > > If > > > it's not worth the time to fix this case, let me know and I'll adapt > > > the > > > tests. > > > > Please try again after ab1d418f36edca. > > > > Thanks > > Jürgen > > > > > Both tests pass her now. Thanks. > (Mark, that the lyx2lyx tests do also a latex compilation as the last step) +1 thanks. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Run updateBuffer when adding/merging changes
On 1/28/21 5:28 AM, Jean-Marc Lasgouttes wrote:
commit f3a0e8ff9a9b914d40eb520bb31674d1ad4eb0d0
Author: Jean-Marc Lasgouttes
Date: Thu Jan 28 10:10:18 2021 +0100
Run updateBuffer when adding/merging changes
Following 4a4ded22, the enabling of some change-related functions is
handled in updateBuffer. However, this method is not ran at every
document change for performance reasons.
This patch adds code to every place that modifies
Paragraph::Private::changes_ that checks whether the `changedness' of
the paragraph, err... changes.
To this end, a new helper struct is introduced that remembers
paragraph state at contruction time, and compares it to new state in
the destructor.
New forceUpdate/needUpdate methods are added to Buffer class, since
the cursor is in general not available in the places where these
changes are made.
Fixes bug #12074.
---
src/Buffer.cpp | 17 -
src/Buffer.h |6 -
src/BufferView.cpp |2 +-
src/Paragraph.cpp | 69
4 files changed, 91 insertions(+), 3 deletions(-)
diff --git a/src/Buffer.cpp b/src/Buffer.cpp
index 6454ba3..f2a3702 100644
--- a/src/Buffer.cpp
+++ b/src/Buffer.cpp
diff --git a/src/BufferView.cpp b/src/BufferView.cpp
index ec89084..8094c64 100644
--- a/src/BufferView.cpp
+++ b/src/BufferView.cpp
@@ -2417,7 +2417,7 @@ void BufferView::mouseEventDispatch(FuncRequest const &
cmd0)
// Do we have a selection?
theSelection().haveSelection(cursor().selection());
- if (cur.needBufferUpdate()) {
+ if (cur.needBufferUpdate() || buffer().needUpdate()) {
cur.clearBufferUpdate();
Shouldn't the Buffer::updateBuffer_ member also be reset here?
Riki
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: master: French Additional manual 2.3.x export -> failed compilation
Am Thu, 28 Jan 2021 09:26:18 +0100 schrieb Jürgen Spitzmüller : > Am Mittwoch, dem 27.01.2021 um 20:09 -0500 schrieb Scott Kostyshak: > > The following ctests are failing: > > > > 2416 - export/doc/fr/Additional_lyx22 (Failed) > > 2417 - export/doc/fr/Additional_lyx23 (Failed) > > > > I think it is because of the non-default language in the table cell. > > If > > it's not worth the time to fix this case, let me know and I'll adapt > > the > > tests. > > Please try again after ab1d418f36edca. > > Thanks > Jürgen > Both tests pass her now. Thanks. (Mark, that the lyx2lyx tests do also a latex compilation as the last step) Kornel pgp18rDrykpgo.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: master: French Additional manual 2.3.x export -> failed compilation
Am Mittwoch, dem 27.01.2021 um 20:09 -0500 schrieb Scott Kostyshak: > The following ctests are failing: > > 2416 - export/doc/fr/Additional_lyx22 (Failed) > 2417 - export/doc/fr/Additional_lyx23 (Failed) > > I think it is because of the non-default language in the table cell. > If > it's not worth the time to fix this case, let me know and I'll adapt > the > tests. Please try again after ab1d418f36edca. Thanks Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
