Re: Beta 1
Am Mo., 24. Mai 2021 um 21:18 Uhr schrieb Richard Kimberly Heck < rikih...@lyx.org>: > Hi, all, > > I have put tarballs for beta 1 here: > > > https://drive.google.com/drive/folders/1Zl_20mzi9ndDDQdzeFyvR07O4lLDtcW3?usp=sharing > > I need to get my IP updated with our FTP people before I can upload > again to ftp.lyx.org. Usually that does not take too long. In any event, > please prepare binaries, and I'll release later this week. > Hi Riki, what do you think? Should I build the Windows installer with Qt 6.1? Qt 6 upwards only delivers precompiled 64 bit binaries, I'm not sure what I would do about that. The options would be to continue building with Qt 5, build 64 bit LyX with Qt 6 and 32 bit with Qt 5 (don't really want to build Qt 6 32 bit myself) or only build 64 bit LyX. That said I can't really imagine people still using 32 bit windows, so I would prefer the last option. -- Eugene -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Revert "Fix bug #10263"
On Mon, May 24, 2021 at 11:37:44PM +0200, Thibaut Cuvelier wrote: > Hi Scott, > > Thanks for bringing this to my attention. Indeed, the DocBook code becomes > wrong with the new patch (I just tested with master, though): the > element should contain a , and it does no more. I pushed > 39a9e370, it fixes the problem locally. Great, thanks for the fix, Thibaut. I just tested master and all DocBook tests pass here. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Revert "Fix bug #10263"
Hi Scott,
Thanks for bringing this to my attention. Indeed, the DocBook code becomes
wrong with the new patch (I just tested with master, though): the
element should contain a , and it does no more. I pushed
39a9e370, it fixes the problem locally.
On Sun, 23 May 2021 at 03:49, Scott Kostyshak wrote:
> On Tue, Apr 13, 2021 at 10:13:16AM +0200, Jean-Marc Lasgouttes wrote:
> > commit 441c6a93590698c3c57982c8b80179d6809fb106
> > Author: Jean-Marc Lasgouttes
> > Date: Mon Apr 12 20:44:58 2021 +0200
> >
> > Revert "Fix bug #10263"
> >
> > A series of commits, culminating at 812ff7de, pushed a few days
> later,
> > fixes the bug at its root. This one is not needed anymore to fix
> >
> > This reverts commit 001f5a47861f04c985323677dfd17ef15b8c33a7
> > ---
> > src/insets/InsetFoot.h |4
> > 1 files changed, 0 insertions(+), 4 deletions(-)
> >
> > diff --git a/src/insets/InsetFoot.h b/src/insets/InsetFoot.h
> > index 1e4b0d2..0c3f65a 100644
> > --- a/src/insets/InsetFoot.h
> > +++ b/src/insets/InsetFoot.h
> > @@ -45,10 +45,6 @@ private:
> > ///
> > Inset * clone() const override { return new InsetFoot(*this); }
> > ///
> > - bool inheritFont() const override { return true; }
> > - ///
> > - bool allowMultiPar() const override { return true; }
> > - ///
> > docstring custom_label_;
> > ///
> > bool intitle_;
> > --
>
> Starting with this commit a lot of docbook ctests started to fail.
> Thibaut, does the docbook code need to be adapted?
>
> More information in case it is helpful:
>
> With commit 441c6a93^:
> 99% tests passed, 1 tests failed out of 380
> The following tests FAILED:
> 3730 - export/examples/External_Material/Spreadsheet_docbook5
> (Failed)
>
>
> Starting with 441c6a93:
> 88% tests passed, 46 tests failed out of 380
> The following tests FAILED:
> 1648 - export/doc/Customization_docbook5 (Failed)
> 1666 - export/doc/Development_docbook5 (Failed)
> 1756 - export/doc/Intro_docbook5 (Failed)
> 1851 - export/doc/Tutorial_docbook5 (Failed)
> 1923 - export/doc/ca/Intro_docbook5 (Failed)
> 1995 - export/doc/de/Customization_docbook5 (Failed)
> 2085 - export/doc/de/Intro_docbook5 (Failed)
> 2139 - export/doc/de/Tutorial_docbook5 (Failed)
> 2175 - export/doc/el/Intro_docbook5 (Failed)
> 2301 - export/doc/es/Intro_docbook5 (Failed)
> 2355 - export/doc/es/Tutorial_docbook5 (Failed)
> 2391 - export/doc/eu/Intro_docbook5 (Failed)
> 2409 - export/doc/eu/Tutorial_docbook5 (Failed)
> 2535 - export/doc/fr/Intro_docbook5 (Failed)
> 2589 - export/doc/fr/Tutorial_docbook5 (Failed)
> 2625 - export/doc/gl/Intro_docbook5 (Failed)
> 2661 - export/doc/he/Intro_docbook5 (Failed)
> 2679 - export/doc/he/Tutorial_docbook5 (Failed)
> 2697 - export/doc/hu/Intro_docbook5 (Failed)
> 2715 - export/doc/hu/Tutorial_docbook5 (Failed)
> 2733 - export/doc/id/Intro_docbook5 (Failed)
> 2751 - export/doc/id/Shortcuts_docbook5 (Failed)
> 2769 - export/doc/id/Tutorial_docbook5 (Failed)
> 2787 - export/doc/it/Intro_docbook5 (Failed)
> 2805 - export/doc/it/Tutorial_docbook5 (Failed)
> 2907 - export/doc/ja/Intro_docbook5 (Failed)
> 2968 - export/doc/ja/Tutorial_docbook5 (Failed)
> 2996 - export/doc/nb/Intro_docbook5 (Failed)
> 3014 - export/doc/nb/Tutorial_docbook5 (Failed)
> 3032 - export/doc/nl/Intro_docbook5 (Failed)
> 3068 - export/doc/nl/Tutorial_docbook5 (Failed)
> 3158 - export/doc/ro/Intro_docbook5 (Failed)
> 3212 - export/doc/ru/Intro_docbook5 (Failed)
> 3266 - export/doc/ru/Tutorial_docbook5 (Failed)
> 3302 - export/doc/sk/Intro_docbook5 (Failed)
> 3374 - export/doc/sv/Intro_docbook5 (Failed)
> 3410 - export/doc/sv/Tutorial_docbook5 (Failed)
> 3428 - export/doc/uk/Intro_docbook5 (Failed)
> 3446 - export/doc/zh_CN/Intro_docbook5 (Failed)
> 3461 - export/doc/zh_CN/Tutorial_docbook5 (Failed)
> 3730 - export/examples/External_Material/Spreadsheet_docbook5
> (Failed)
> 4057 - export/examples/Modules/Noweb_docbook5 (Failed)
> 4146 - export/examples/Modules/Rnw_%28knitr%29_docbook5 (Failed)
> 5069 -
> export/examples/fr/Graphics_and_Insets/Feynman_Diagrams_docbook5 (Failed)
> 5087 -
> export/examples/fr/Graphics_and_Insets/Itemize_Bullets_docbook5 (Failed)
> 5141 - export/examples/fr/Modules/Braille_docbook5 (Failed)
>
> Scott
>
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Beta 1
Hi, all, I have put tarballs for beta 1 here: https://drive.google.com/drive/folders/1Zl_20mzi9ndDDQdzeFyvR07O4lLDtcW3?usp=sharing I need to get my IP updated with our FTP people before I can upload again to ftp.lyx.org. Usually that does not take too long. In any event, please prepare binaries, and I'll release later this week. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Qt 6 errors on Windows
Am Mo., 24. Mai 2021 um 18:47 Uhr schrieb Kornel Benko : > Am Mon, 24 May 2021 18:19:47 +0200 > schrieb Yu Jin : > > > Am Mo., 24. Mai 2021 um 15:19 Uhr schrieb Kornel Benko : > > > > > Am Mon, 24 May 2021 09:50:27 +0200 > > > schrieb Yu Jin : > > > > I found what causes this, it is the /Zc compile option. With Qt5 it > is > > > set > > > > to wchar_t and with Qt6 to wchar_t- in all targets, which causes > > > troubles. > > > > I have changed it in Visual Studio on a test basis and successfully > > > > compiled LyX, but I guess it would need to be changed in CMake code. > > > > Kornel, can you help me out here? > > > > > > This is set at ./CMakeLists.txt:1112 > > > Try to change > > > if (NOT Qt5Core_FOUND) > > > to > > > if (NOT (Qt5Core_FOUND OR Qt6Core_FOUND)) > > > > > > > Yes, that worked, should I commit? > > Yes please. > Done. Thank you. I will adapt wininstaller's NSIS code to be compatible with Qt6 later. -- Eugene -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Qt 6 errors on Windows
Am Mon, 24 May 2021 18:19:47 +0200 schrieb Yu Jin : > Am Mo., 24. Mai 2021 um 15:19 Uhr schrieb Kornel Benko : > > > Am Mon, 24 May 2021 09:50:27 +0200 > > schrieb Yu Jin : > > > I found what causes this, it is the /Zc compile option. With Qt5 it is > > set > > > to wchar_t and with Qt6 to wchar_t- in all targets, which causes > > troubles. > > > I have changed it in Visual Studio on a test basis and successfully > > > compiled LyX, but I guess it would need to be changed in CMake code. > > > Kornel, can you help me out here? > > > > This is set at ./CMakeLists.txt:1112 > > Try to change > > if (NOT Qt5Core_FOUND) > > to > > if (NOT (Qt5Core_FOUND OR Qt6Core_FOUND)) > > > > Yes, that worked, should I commit? Yes please. Kornel pgphJY50PxiJN.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Qt 6 errors on Windows
Am Mo., 24. Mai 2021 um 15:19 Uhr schrieb Kornel Benko : > Am Mon, 24 May 2021 09:50:27 +0200 > schrieb Yu Jin : > > I found what causes this, it is the /Zc compile option. With Qt5 it is > set > > to wchar_t and with Qt6 to wchar_t- in all targets, which causes > troubles. > > I have changed it in Visual Studio on a test basis and successfully > > compiled LyX, but I guess it would need to be changed in CMake code. > > Kornel, can you help me out here? > > This is set at ./CMakeLists.txt:1112 > Try to change > if (NOT Qt5Core_FOUND) > to > if (NOT (Qt5Core_FOUND OR Qt6Core_FOUND)) > Yes, that worked, should I commit? -- Eugene -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Qt 6 errors on Windows
Am Mon, 24 May 2021 09:50:27 +0200 schrieb Yu Jin : > Am So., 23. Mai 2021 um 09:52 Uhr schrieb Yu Jin : > > > I still can't compile with Qt 6, I just tried again with the recently > > released Qt 6.1 but I get a lot of these errors: > > > > Severity Code Description Project File Line Suppression State > > Error C2535 'QChar::QChar(ushort) noexcept': member function already > > defined or declared support (applications\LyX\support) > > C:\Qt\6.1.0\msvc2019_64\include\QtCore\qchar.h 120 > > > > Severity Code Description Project File Line Suppression State > > Error C2572 'qHash': redefinition of default argument: parameter 1 support > > (applications\LyX\support) > > C:\Qt\6.1.0\msvc2019_64\include\QtCore\qhashfunctions.h 143 > > > > Severity Code Description Project File Line Suppression State > > Error C3615 constexpr function 'qHash' cannot result in a constant > > expression support (applications\LyX\support) > > C:\Qt\6.1.0\msvc2019_64\include\QtCore\qhashfunctions.h 143 > > > > Severity Code Description Project File Line Suppression State > > Error C2084 function 'size_t qHash(ushort,size_t) noexcept' already has a > > body support (applications\LyX\support) > > C:\Qt\6.1.0\msvc2019_64\include\QtCore\qhashfunctions.h 143 > > > > It looks like these are Qt bugs, but I wanted to ask first before going to > > Qt and making bug reports... maybe I am missing something. What do you > > think? > > > > I found what causes this, it is the /Zc compile option. With Qt5 it is set > to wchar_t and with Qt6 to wchar_t- in all targets, which causes troubles. > I have changed it in Visual Studio on a test basis and successfully > compiled LyX, but I guess it would need to be changed in CMake code. > Kornel, can you help me out here? This is set at ./CMakeLists.txt:1112 Try to change if (NOT Qt5Core_FOUND) to if (NOT (Qt5Core_FOUND OR Qt6Core_FOUND)) Kornel pgpG4GVSvFm2h.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Qt 6 errors on Windows
Am So., 23. Mai 2021 um 09:52 Uhr schrieb Yu Jin : > I still can't compile with Qt 6, I just tried again with the recently > released Qt 6.1 but I get a lot of these errors: > > Severity Code Description Project File Line Suppression State > Error C2535 'QChar::QChar(ushort) noexcept': member function already > defined or declared support (applications\LyX\support) > C:\Qt\6.1.0\msvc2019_64\include\QtCore\qchar.h 120 > > Severity Code Description Project File Line Suppression State > Error C2572 'qHash': redefinition of default argument: parameter 1 support > (applications\LyX\support) > C:\Qt\6.1.0\msvc2019_64\include\QtCore\qhashfunctions.h 143 > > Severity Code Description Project File Line Suppression State > Error C3615 constexpr function 'qHash' cannot result in a constant > expression support (applications\LyX\support) > C:\Qt\6.1.0\msvc2019_64\include\QtCore\qhashfunctions.h 143 > > Severity Code Description Project File Line Suppression State > Error C2084 function 'size_t qHash(ushort,size_t) noexcept' already has a > body support (applications\LyX\support) > C:\Qt\6.1.0\msvc2019_64\include\QtCore\qhashfunctions.h 143 > > It looks like these are Qt bugs, but I wanted to ask first before going to > Qt and making bug reports... maybe I am missing something. What do you > think? > I found what causes this, it is the /Zc compile option. With Qt5 it is set to wchar_t and with Qt6 to wchar_t- in all targets, which causes troubles. I have changed it in Visual Studio on a test basis and successfully compiled LyX, but I guess it would need to be changed in CMake code. Kornel, can you help me out here? -- Eugene -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
