Re: Compile warnings with docbook

2021-09-23 Thread Thibaut Cuvelier
Hi Kornel,

Thanks for pointing these out, they didn't show on my side. I could quite
easily fix the one about the unused argument in the constructor (it's
already pushed: dca39815), but I don't know what to do for the others.
Maybe the attached patch solves the rest of the warnings?

On Fri, 24 Sept 2021 at 00:55, Kornel Benko  wrote:

>
> See attached.
>
> Kornel
> --
> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel
>


Fix_a_few_warnings_in_Floating_.patch
Description: Binary data
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Compile warnings with docbook

2021-09-23 Thread Kornel Benko

See attached.

Kornel


Warnings
Description: Binary data


pgpvNNTRcQ84O.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Remove underline from tracked changes?

2021-09-23 Thread Scott Kostyshak
On Thu, Sep 23, 2021 at 06:45:51PM +0200, Rasmus K. Rendsvig wrote:
> >
> > On Thu, Sep 23, 2021 at 02:32:55PM +0200, Rasmus K. Rendsvig wrote:
> > > Hi LyX devs,
> > >
> > > I tried asking this on the users' list a few weeks ago, but perhaps I
> > > should have asked here instead:
> > >
> > > I find that the underlining of added text when tracking changes is a bit
> > > distracting. I would like to disable just the underlining.
> > >
> > > Is there any way I can do that? I will happily attempt to edit the source
> > > and compile myself.
> > >
> > > Kind regards,
> > > Rasmus
> >
> > Hi Rasmus,
> >
> > Thanks for following up and sorry you didn't get a response on lyx-users.
> >
> > In LyX 2.4.0 (not yet released), there will be a preference to control
> > whether added text is underlined in LyX's display. You can see how it will
> > look in the attached screenshot.
> >
> > In case you're curious, here was the feature request that was implemented:
> > https://www.lyx.org/trac/ticket/10102
> >
> > If this issue is annoying enough that you would like to test a pre-release
> > of 2.4.0, we can give you information on that. The main problem is that any
> > LyX file you save with a 2.4.0 pre-release could not be opened in LyX
> > 2.3.x, meaning that if you are working with someone else, they would also
> > have to use a 2.4.0 pre-release. So it's best to wait until 2.4.0 is
> > officially released if you can.
> >
> > Best,
> > Scott
> >
> 
> Hi Scott,
> 
> Thank you for the quick reply, and I apologize if I now reply in an
> incorrect format: I was digest subscribed.

Your reply went to the list so that worked well.

> Also thank you for the information. I'm torn on using 2.4.0, as most of the
> work I that involves track changes also involves collaborators. I am
> curious to try it for fun, though, and see packages listed in the
> development ppa.
> 
> Since you do not mention five lines of code that I could possibly edit in
> the source code of 2.3.6, I suppose the matter is not as easily as that.
> 
> Again, thank you for the quick reply.
> As with every new release, I will look forward to 2.4.0.

Actually it might take even less than 5 lines of code to change it. You can see 
the fix here:

  
https://git.lyx.org/?p=lyx.git;a=commitdiff;h=8e62dcc20fc226deb7fb48a9934391d2f9a0c712;hp=7c63896c601f43ced313b74e04336235ff09212e

On a quick look, my guess is that it would be feasible to modify 2.3.x. Are you 
on Linux? If you can compile LyX, then we can take a look to see how difficult 
it would be to backport the relevant code. Most of the diff above is about 
adding a preference, but you just wanted "no underline" hardcoded so you don't 
need to actually have the code about the preference.

Best,
Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Remove underline from tracked changes?

2021-09-23 Thread Rasmus K. Rendsvig
>
> On Thu, Sep 23, 2021 at 02:32:55PM +0200, Rasmus K. Rendsvig wrote:
> > Hi LyX devs,
> >
> > I tried asking this on the users' list a few weeks ago, but perhaps I
> > should have asked here instead:
> >
> > I find that the underlining of added text when tracking changes is a bit
> > distracting. I would like to disable just the underlining.
> >
> > Is there any way I can do that? I will happily attempt to edit the source
> > and compile myself.
> >
> > Kind regards,
> > Rasmus
>
> Hi Rasmus,
>
> Thanks for following up and sorry you didn't get a response on lyx-users.
>
> In LyX 2.4.0 (not yet released), there will be a preference to control
> whether added text is underlined in LyX's display. You can see how it will
> look in the attached screenshot.
>
> In case you're curious, here was the feature request that was implemented:
> https://www.lyx.org/trac/ticket/10102
>
> If this issue is annoying enough that you would like to test a pre-release
> of 2.4.0, we can give you information on that. The main problem is that any
> LyX file you save with a 2.4.0 pre-release could not be opened in LyX
> 2.3.x, meaning that if you are working with someone else, they would also
> have to use a 2.4.0 pre-release. So it's best to wait until 2.4.0 is
> officially released if you can.
>
> Best,
> Scott
>

Hi Scott,

Thank you for the quick reply, and I apologize if I now reply in an
incorrect format: I was digest subscribed.

Also thank you for the information. I'm torn on using 2.4.0, as most of the
work I that involves track changes also involves collaborators. I am
curious to try it for fun, though, and see packages listed in the
development ppa.

Since you do not mention five lines of code that I could possibly edit in
the source code of 2.3.6, I suppose the matter is not as easily as that.

Again, thank you for the quick reply.
As with every new release, I will look forward to 2.4.0.

Best,
Rasmus

>
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Remove underline from tracked changes?

2021-09-23 Thread Scott Kostyshak
On Thu, Sep 23, 2021 at 02:32:55PM +0200, Rasmus K. Rendsvig wrote:
> Hi LyX devs,
> 
> I tried asking this on the users' list a few weeks ago, but perhaps I
> should have asked here instead:
> 
> I find that the underlining of added text when tracking changes is a bit
> distracting. I would like to disable just the underlining.
> 
> Is there any way I can do that? I will happily attempt to edit the source
> and compile myself.
> 
> Kind regards,
> Rasmus

Hi Rasmus,

Thanks for following up and sorry you didn't get a response on lyx-users.

In LyX 2.4.0 (not yet released), there will be a preference to control whether 
added text is underlined in LyX's display. You can see how it will look in the 
attached screenshot.

In case you're curious, here was the feature request that was implemented: 
https://www.lyx.org/trac/ticket/10102

If this issue is annoying enough that you would like to test a pre-release of 
2.4.0, we can give you information on that. The main problem is that any LyX 
file you save with a 2.4.0 pre-release could not be opened in LyX 2.3.x, 
meaning that if you are working with someone else, they would also have to use 
a 2.4.0 pre-release. So it's best to wait until 2.4.0 is officially released if 
you can.

Best,
Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Remove underline from tracked changes?

2021-09-23 Thread Rasmus K. Rendsvig
Hi LyX devs,

I tried asking this on the users' list a few weeks ago, but perhaps I
should have asked here instead:

I find that the underlining of added text when tracking changes is a bit
distracting. I would like to disable just the underlining.

Is there any way I can do that? I will happily attempt to edit the source
and compile myself.

Kind regards,
Rasmus


   --
Rasmus K. Rendsvig , assistant
professor,
Center for Information and Bubble Studies ,
University of Copenhagen
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel