Re: New Theorems Module
On Tue, 20 Sept 2022 at 16:54, Kornel Benko wrote: > Am Tue, 20 Sep 2022 16:57:02 +0300 > schrieb Udicoudco : > > > On Tue, Sep 20, 2022 at 4:36 PM Kornel Benko wrote: > > > > > > Am Tue, 20 Sep 2022 05:26:49 +0300 > > > schrieb Udicoudco : > > > > > You may want to add the module to the list of math-modules. > > > Add > > > #\DeclareCategory{Maths} > > > as the second line (before the #DescriptionBegin) > > > > Hi Kornel, > > > > Thank you for the suggestion, I'm guessing this is related to the > > redesigned module selection dialog in LyX 2.4? > > Yes, that is the case. > > > Also, could you care to explain what is the purpose of the new tags i > > saw in the master (DocBookWrapperTag, DocBookTag, DocBookAttr)? > > They are important for export to docbook (in contrast to exporting to pdf > via some latex > engine) > But the better reference person (than me) is Thibaut Cuvelier ( > tcuvel...@lyx.org). > > > It > > might be a good idea to add those too, but i did not want to add these > > without knowing their functionality (I've noticed that all theorem > > layouts has "DocBookTag para" wouldn't it be copied with the > > CopyStyle tag?) > > You should test docbook export before this can go to trunk IMO. But > Thibaut can help you > more. > I'm jumping in the conversation as my ears were buzzing :). @Udi: as long as your new theorems are roughly similar to the previous ones (without more nesting, for instance), you should be able to use exactly the same configuration. I haven't been focusing on having the smallest configuration that works yet. If you need help or want to delegate the DocBook export, no problem, just let me know :). I think that we can proceed with merging your patch without any DocBook-related changes first (unless your module makes the DocBook export crash, I believe that's not likely t all), then I can have a look later on. But everything DocBook requires LyX 2.4, that might make it harder for you to test. Nevertheless, it would be best to have an example document with all your new constructs to be used in the test suite (a file like autotests/export/docbook/theorems-thmtools.lyx), even if you don't touch the DocBook part: it would be very useful in the longer term to ensure that nothing breaks regarding the DocBook export of your new constructs, and also simply to write the required configuration. You would be the best person to build this document, as you know how everything is supposed to be used, I would have to figure it out almost from scratch. I have noticed your included test_thmtools_module.lyx, but I don't know how complete it is :). -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: New Theorems Module
Am Tue, 20 Sep 2022 16:57:02 +0300 schrieb Udicoudco : > On Tue, Sep 20, 2022 at 4:36 PM Kornel Benko wrote: > > > > Am Tue, 20 Sep 2022 05:26:49 +0300 > > schrieb Udicoudco : > > > You may want to add the module to the list of math-modules. > > Add > > #\DeclareCategory{Maths} > > as the second line (before the #DescriptionBegin) > > Hi Kornel, > > Thank you for the suggestion, I'm guessing this is related to the > redesigned module selection dialog in LyX 2.4? Yes, that is the case. > Also, could you care to explain what is the purpose of the new tags i > saw in the master (DocBookWrapperTag, DocBookTag, DocBookAttr)? They are important for export to docbook (in contrast to exporting to pdf via some latex engine) But the better reference person (than me) is Thibaut Cuvelier (tcuvel...@lyx.org). > It > might be a good idea to add those too, but i did not want to add these > without knowing their functionality (I've noticed that all theorem > layouts has "DocBookTag para" wouldn't it be copied with the > CopyStyle tag?) You should test docbook export before this can go to trunk IMO. But Thibaut can help you more. > Regrads, > Udi Kornel pgpe_N4CRzqVx.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: New Theorems Module
On Tue, Sep 20, 2022 at 4:36 PM Kornel Benko wrote: > > Am Tue, 20 Sep 2022 05:26:49 +0300 > schrieb Udicoudco : > You may want to add the module to the list of math-modules. > Add > #\DeclareCategory{Maths} > as the second line (before the #DescriptionBegin) Hi Kornel, Thank you for the suggestion, I'm guessing this is related to the redesigned module selection dialog in LyX 2.4? Also, could you care to explain what is the purpose of the new tags i saw in the master (DocBookWrapperTag, DocBookTag, DocBookAttr)? It might be a good idea to add those too, but i did not want to add these without knowing their functionality (I've noticed that all theorem layouts has "DocBookTag para" wouldn't it be copied with the CopyStyle tag?) Regrads, Udi -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: New Theorems Module
Am Tue, 20 Sep 2022 05:26:49 +0300 schrieb Udicoudco : > I've noticed that the definition environment is not numbered in the > output files. After checking the module again, I hope there are no > issues any more. The fixed module is attached. > > Regards, > Udi You may want to add the module to the list of math-modules. Add #\DeclareCategory{Maths} as the second line (before the #DescriptionBegin) Kornel pgpTeyGF3QkyA.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel