Re: [Cvslog] r16780 - /lyx-devel/trunk/src/output_plaintext.C

2007-01-21 Thread Michael Gerz

Angus Leeming schrieb:

-   docstring const abst = _(Abstract: );
+   docstring const abst = _(Abstract) + from_ascii(: );



Not all languages will use ':' in the same way as the English and in
RtL languages the thing won't go to the right of the word either...
  


Hpmf $§#!

Fixed/Reverted in r16791. Thank you very much for the hint, Angus

Michael



Re: [Cvslog] r16780 - /lyx-devel/trunk/src/output_plaintext.C

2007-01-21 Thread Michael Gerz

Angus Leeming schrieb:

-   docstring const abst = _("Abstract: ");
+   docstring const abst = _("Abstract") + from_ascii(": ");



Not all languages will use ':' in the same way as the English and in
RtL languages the thing won't go to the right of the word either...
  


Hpmf $&§#!

Fixed/Reverted in r16791. Thank you very much for the hint, Angus

Michael



Re: [Cvslog] r16780 - /lyx-devel/trunk/src/output_plaintext.C

2007-01-20 Thread Michael Gerz


The implications of this fix are marginal. I don't see any difference in 
a typical document.


Michael



[EMAIL PROTECTED] schrieb:

Author: schmitt
Date: Sat Jan 20 17:14:39 2007
New Revision: 16780

URL: http://www.lyx.org/trac/changeset/16780
Log:
	* src/output_plaintext.C: save two *.po entries; 
	output label+space only if label is not empty


Modified:
lyx-devel/trunk/src/output_plaintext.C

Modified: lyx-devel/trunk/src/output_plaintext.C
URL: 
http://www.lyx.org/trac/file/lyx-devel/trunk/src/output_plaintext.C?rev=16780
==
--- lyx-devel/trunk/src/output_plaintext.C (original)
+++ lyx-devel/trunk/src/output_plaintext.C Sat Jan 20 17:14:39 2007
@@ -152,7 +152,7 @@
os  _(Abstract)  \n\n;
currlinelen = 0;
} else {
-   docstring const abst = _(Abstract: );
+   docstring const abst = _(Abstract) + from_ascii(: );
os  abst;
currlinelen += abst.length();
}
@@ -164,7 +164,7 @@
os  _(References)  \n\n;
currlinelen = 0;
} else {
-   docstring const refs = _(References: );
+   docstring const refs = _(References) + 
from_ascii(: );
os  refs;
currlinelen += refs.length();
}
@@ -174,14 +174,16 @@
 
 	default: {

docstring const label = par.params().labelString();
-   os  label  ' ';
-   currlinelen += label.length() + 1;
-   break;
-   }
-
-   }
-
-   if (!currlinelen) {
+   if (!label.empty()) {
+   os  label  ' ';
+   currlinelen += label.length() + 1;
+   }
+   break;
+   }
+
+   }
+
+   if (currlinelen == 0) {
pairint, docstring p = addDepth(depth, ltype_depth);
os  p.second;
currlinelen += p.first;


___
Cvslog mailing list
[EMAIL PROTECTED]
http://www.lyx.org/mailman/listinfo/cvslog


  


Re: [Cvslog] r16780 - /lyx-devel/trunk/src/output_plaintext.C

2007-01-20 Thread Angus Leeming
 The implications of this fix are marginal. I don't see any
 difference in a typical document.

Maybe not. But the translation changes you've made are absolutely
wrong.

 - docstring const abst = _(Abstract: );
 + docstring const abst = _(Abstract) + from_ascii(: );

Not all languages will use ':' in the same way as the English and in
RtL languages the thing won't go to the right of the word either...

Angus

[EMAIL PROTECTED] schrieb:
 Author: schmitt
 Date: Sat Jan 20 17:14:39 2007
 New Revision: 16780

 URL: http://www.lyx.org/trac/changeset/16780
 Log:
   * src/output_plaintext.C: save two *.po entries; 
   output label+space only if label is not empty

 Modified:
 lyx-devel/trunk/src/output_plaintext.C

 Modified: lyx-devel/trunk/src/output_plaintext.C
 URL:
http://www.lyx.org/trac/file/lyx-devel/trunk/src/output_plaintext.C?rev=16780

==
 --- lyx-devel/trunk/src/output_plaintext.C (original)
 +++ lyx-devel/trunk/src/output_plaintext.C Sat Jan 20 17:14:39 2007
 @@ -152,7 +152,7 @@
   os  _(Abstract)  \n\n;
   currlinelen = 0;
   } else {
 - docstring const abst = _(Abstract: );
 + docstring const abst = _(Abstract) + from_ascii(: );
   os  abst;
   currlinelen += abst.length();
   }
 @@ -164,7 +164,7 @@
   os  _(References)  \n\n;
   currlinelen = 0;
   } else {
 - docstring const refs = _(References: );
 + docstring const refs = _(References) + 
 from_ascii(: );
   os  refs;
   currlinelen += refs.length();
   }
 @@ -174,14 +174,16 @@



Re: [Cvslog] r16780 - /lyx-devel/trunk/src/output_plaintext.C

2007-01-20 Thread Michael Gerz


The implications of this fix are marginal. I don't see any difference in 
a typical document.


Michael



[EMAIL PROTECTED] schrieb:

Author: schmitt
Date: Sat Jan 20 17:14:39 2007
New Revision: 16780

URL: http://www.lyx.org/trac/changeset/16780
Log:
	* src/output_plaintext.C: save two *.po entries; 
	output label+space only if label is not empty


Modified:
lyx-devel/trunk/src/output_plaintext.C

Modified: lyx-devel/trunk/src/output_plaintext.C
URL: 
http://www.lyx.org/trac/file/lyx-devel/trunk/src/output_plaintext.C?rev=16780
==
--- lyx-devel/trunk/src/output_plaintext.C (original)
+++ lyx-devel/trunk/src/output_plaintext.C Sat Jan 20 17:14:39 2007
@@ -152,7 +152,7 @@
os << _("Abstract") << "\n\n";
currlinelen = 0;
} else {
-   docstring const abst = _("Abstract: ");
+   docstring const abst = _("Abstract") + from_ascii(": ");
os << abst;
currlinelen += abst.length();
}
@@ -164,7 +164,7 @@
os << _("References") << "\n\n";
currlinelen = 0;
} else {
-   docstring const refs = _("References: ");
+   docstring const refs = _("References") + 
from_ascii(": ");
os << refs;
currlinelen += refs.length();
}
@@ -174,14 +174,16 @@
 
 	default: {

docstring const label = par.params().labelString();
-   os << label << ' ';
-   currlinelen += label.length() + 1;
-   break;
-   }
-
-   }
-
-   if (!currlinelen) {
+   if (!label.empty()) {
+   os << label << ' ';
+   currlinelen += label.length() + 1;
+   }
+   break;
+   }
+
+   }
+
+   if (currlinelen == 0) {
pair p = addDepth(depth, ltype_depth);
os << p.second;
currlinelen += p.first;


___
Cvslog mailing list
[EMAIL PROTECTED]
http://www.lyx.org/mailman/listinfo/cvslog


  


Re: [Cvslog] r16780 - /lyx-devel/trunk/src/output_plaintext.C

2007-01-20 Thread Angus Leeming
> The implications of this fix are marginal. I don't see any
> difference in a typical document.

Maybe not. But the translation changes you've made are absolutely
wrong.

> - docstring const abst = _("Abstract: ");
> + docstring const abst = _("Abstract") + from_ascii(": ");

Not all languages will use ':' in the same way as the English and in
RtL languages the thing won't go to the right of the word either...

Angus

[EMAIL PROTECTED] schrieb:
> Author: schmitt
> Date: Sat Jan 20 17:14:39 2007
> New Revision: 16780
>
> URL: http://www.lyx.org/trac/changeset/16780
> Log:
>   * src/output_plaintext.C: save two *.po entries; 
>   output label+space only if label is not empty
>
> Modified:
> lyx-devel/trunk/src/output_plaintext.C
>
> Modified: lyx-devel/trunk/src/output_plaintext.C
> URL:
http://www.lyx.org/trac/file/lyx-devel/trunk/src/output_plaintext.C?rev=16780
>
==
> --- lyx-devel/trunk/src/output_plaintext.C (original)
> +++ lyx-devel/trunk/src/output_plaintext.C Sat Jan 20 17:14:39 2007
> @@ -152,7 +152,7 @@
>   os << _("Abstract") << "\n\n";
>   currlinelen = 0;
>   } else {
> - docstring const abst = _("Abstract: ");
> + docstring const abst = _("Abstract") + from_ascii(": ");
>   os << abst;
>   currlinelen += abst.length();
>   }
> @@ -164,7 +164,7 @@
>   os << _("References") << "\n\n";
>   currlinelen = 0;
>   } else {
> - docstring const refs = _("References: ");
> + docstring const refs = _("References") + 
> from_ascii(": ");
>   os << refs;
>   currlinelen += refs.length();
>   }
> @@ -174,14 +174,16 @@