Re: [LyX/master] Move class definitions inside main class

2016-10-22 Thread Enrico Forestieri 
On Sun, Oct 23, 2016 at 12:26:55AM +0200, Guillaume Munch wrote:

> Le 23/10/2016 à 00:09, Enrico Forestieri a écrit :
> > On Sat, Oct 22, 2016 at 11:26:15PM +0200, Guillaume Munch wrote:
> > 
> > > commit 148b3ae773c441430311feb29eba01a765bc6c48
> > > Author: Guillaume Munch 
> > > Date:   Tue Oct 11 12:09:38 2016 +0200
> > > 
> > > Move class definitions inside main class
> > > 
> > > Prepare for following commits.
> > > 
> > > This prevent's forward-declaration, but including the TexRow header 
> > > should be
> > > inexpensive.
> > 
> > This does not compile on cygwin:
> > 
> 
> Should be fixed now.

Confirmed. Thanks.

-- 
Enrico

Re: [LyX/master] Move class definitions inside main class

2016-10-22 Thread Guillaume Munch 

Le 23/10/2016 à 00:09, Enrico Forestieri a écrit :

On Sat, Oct 22, 2016 at 11:26:15PM +0200, Guillaume Munch wrote:


commit 148b3ae773c441430311feb29eba01a765bc6c48
Author: Guillaume Munch 
Date:   Tue Oct 11 12:09:38 2016 +0200

Move class definitions inside main class

Prepare for following commits.

This prevent's forward-declaration, but including the TexRow header should 
be
inexpensive.


This does not compile on cygwin:



Should be fixed now.

Re: [LyX/master] Move class definitions inside main class

2016-10-22 Thread Enrico Forestieri 
On Sat, Oct 22, 2016 at 11:26:15PM +0200, Guillaume Munch wrote:

> commit 148b3ae773c441430311feb29eba01a765bc6c48
> Author: Guillaume Munch 
> Date:   Tue Oct 11 12:09:38 2016 +0200
> 
> Move class definitions inside main class
> 
> Prepare for following commits.
> 
> This prevent's forward-declaration, but including the TexRow header 
> should be
> inexpensive.

This does not compile on cygwin:

  CXX  ErrorList.o
In file included from ../../src/ErrorList.h:15:0,
 from ../../src/ErrorList.cpp:13:
../../src/TexRow.h:240:12: error: field ‘str’ has incomplete type 
‘lyx::docstring {aka std::basic_string, std::allocator >}’
  docstring str;
^
In file included from ../../src/support/debug.h:18:0,
 from ../../src/TexRow.h:31,
 from ../../src/ErrorList.h:15,
 from ../../src/ErrorList.cpp:13:
../../src/support/strfwd.h:55:64: note: declaration of ‘lyx::docstring {aka 
class std::basic_string, 
std::allocator >}’
 template class basic_string;
^
make[4]: *** [Makefile:2430: ErrorList.o] Error 1

-- 
Enrico