Re: [PATCH] Improved Fix for Bug 3461
On Thursday 17 May 2007 05:09:50 Jürgen Spitzmüller wrote: I guess you do not want to commit this part? Jürgen It can go (the fix, not the debug statement). :-) -- José Abílio
Re: [PATCH] Improved Fix for Bug 3461
On Thursday 17 May 2007 05:09:50 Jürgen Spitzmüller wrote: > > I guess you do not want to commit this part? > > Jürgen It can go (the fix, not the debug statement). :-) -- José Abílio
[PATCH] Improved Fix for Bug 3461
I've discussed this with Abdel already but am sending the fix to the list before committing. The problem is that hitting escape (which emits the rejected() signal) bypasses such closeEvent() and the like. Unfortunately, Abdel's suggestion that we should call slotRestore() here, although sensible, doesn't work. We could call that additionally, but since the dialog is being hidden and will be updated on show(), there's no real reason to do so. Richard -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/ == Get my public key from http://sks.keyserver.penguin.de Hash: 0x1DE91F1E66FFBDEC Learn how to sign your email using Thunderbird and GnuPG at: http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto Index: QRef.cpp === --- QRef.cpp (revision 18373) +++ QRef.cpp (working copy) @@ -51,6 +51,7 @@ connect(applyPB, SIGNAL(clicked()), form_, SLOT(slotApply())); connect(closePB, SIGNAL(clicked()), form_, SLOT(slotClose())); connect(closePB, SIGNAL(clicked()), this, SLOT(reset_dialog())); + connect(this, SIGNAL(rejected()), this, SLOT(reset_dialog())); connect(typeCO, SIGNAL(activated(int)), this, SLOT(changed_adaptor())); Index: QCitationDialog.cpp === --- QCitationDialog.cpp (revision 18373) +++ QCitationDialog.cpp (working copy) @@ -190,6 +190,8 @@ textBeforeLA-setEnabled(!basic_engine); string const command = form_-params().getCmdName(); + + lyxerr command std::endl; // Find the style of the citekeys vectorbiblio::CiteStyle const styles =
Re: [PATCH] Improved Fix for Bug 3461
Richard Heck wrote: + + lyxerr command std::endl; I guess you do not want to commit this part? Jürgen
[PATCH] Improved Fix for Bug 3461
I've discussed this with Abdel already but am sending the fix to the list before committing. The problem is that hitting escape (which emits the rejected() signal) bypasses such closeEvent() and the like. Unfortunately, Abdel's suggestion that we should call slotRestore() here, although sensible, doesn't work. We could call that additionally, but since the dialog is being hidden and will be updated on show(), there's no real reason to do so. Richard -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/ == Get my public key from http://sks.keyserver.penguin.de Hash: 0x1DE91F1E66FFBDEC Learn how to sign your email using Thunderbird and GnuPG at: http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto Index: QRef.cpp === --- QRef.cpp (revision 18373) +++ QRef.cpp (working copy) @@ -51,6 +51,7 @@ connect(applyPB, SIGNAL(clicked()), form_, SLOT(slotApply())); connect(closePB, SIGNAL(clicked()), form_, SLOT(slotClose())); connect(closePB, SIGNAL(clicked()), this, SLOT(reset_dialog())); + connect(this, SIGNAL(rejected()), this, SLOT(reset_dialog())); connect(typeCO, SIGNAL(activated(int)), this, SLOT(changed_adaptor())); Index: QCitationDialog.cpp === --- QCitationDialog.cpp (revision 18373) +++ QCitationDialog.cpp (working copy) @@ -190,6 +190,8 @@ textBeforeLA->setEnabled(!basic_engine); string const & command = form_->params().getCmdName(); + + lyxerr << command << std::endl; // Find the style of the citekeys vector const & styles =
Re: [PATCH] Improved Fix for Bug 3461
Richard Heck wrote: > + > + lyxerr << command << std::endl; I guess you do not want to commit this part? Jürgen
