Re: [Patch] Bug 1119: Disable recursive Dialog::show()

2005-02-25 Thread Jean-Marc Lasgouttes
 Andreas == Andreas Vox [EMAIL PROTECTED] writes:

Andreas Hi Angus! Is this patch now in an acceptable state for
Andreas committing? :-)

Andreas I made 'in_show' a private member of Dialogs and cleaned up a
Andreas little.

Andreas, do you think you could make a 1.3.x patch (since your
computer is soo fast!)

JMarc




Re: [Patch] Bug 1119: Disable recursive Dialog::show()

2005-02-25 Thread Jean-Marc Lasgouttes
> "Andreas" == Andreas Vox <[EMAIL PROTECTED]> writes:

Andreas> Hi Angus! Is this patch now in an acceptable state for
Andreas> committing? :-)

Andreas> I made 'in_show' a private member of Dialogs and cleaned up a
Andreas> little.

Andreas, do you think you could make a 1.3.x patch (since your
computer is soo fast!)

JMarc




Re: [Patch] Bug 1119: Disable recursive Dialog::show()

2005-02-22 Thread Jean-Marc Lasgouttes
 Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes:

Juergen Andreas Vox wrote:
   or would you like me to commit it on your behalf?
 
 Yes please.

Juergen JMarc, I think this is also interesting for 1.3

If it is, I would be interested by a tested patch.

JMarc


Re: [Patch] Bug 1119: Disable recursive Dialog::show()

2005-02-22 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:

Juergen> Andreas Vox wrote:
>> >  or would you like me to commit it on your behalf?
>> 
>> Yes please.

Juergen> JMarc, I think this is also interesting for 1.3

If it is, I would be interested by a tested patch.

JMarc


[Patch] Bug 1119: Disable recursive Dialog::show()

2005-02-21 Thread Andreas Vox
Hi Angus!
Is this patch now in an acceptable state for committing? :-)
I made 'in_show' a private member of Dialogs and cleaned up a little.
Ciao
/Andreas
Changlog:
2005-02-21  Andreas Vox  [EMAIL PROTECTED]
* Dialogs.[hC] (show,show): prevent that show() gets called 
recursively





dialogs-show.diff
Description: Binary data


Re: [Patch] Bug 1119: Disable recursive Dialog::show()

2005-02-21 Thread Angus Leeming
Andreas Vox wrote:
Hi Angus!
Is this patch now in an acceptable state for committing? :-)
I made 'in_show' a private member of Dialogs and cleaned up a little.
It looks good to me. Do you have karma or would you like me to commit it on 
your behalf?
Angus


Re: [Patch] Bug 1119: Disable recursive Dialog::show()

2005-02-21 Thread Andreas Vox
Angus Leeming [EMAIL PROTECTED] writes:

 It looks good to me. Do you have karma

Karma ??? Like in CVS-write-karma?
Nah, I'm a rational scientific atheist! ;-)

  or would you like me to commit it on your behalf?

Yes please. 

/Andreas



Re: [Patch] Bug 1119: Disable recursive Dialog::show()

2005-02-21 Thread Juergen Spitzmueller
Andreas Vox wrote:
   or would you like me to commit it on your behalf?

 Yes please.

JMarc, I think this is also interesting for 1.3

Jürgen


[Patch] Bug 1119: Disable recursive Dialog::show()

2005-02-21 Thread Andreas Vox
Hi Angus!
Is this patch now in an acceptable state for committing? :-)
I made 'in_show' a private member of Dialogs and cleaned up a little.
Ciao
/Andreas
Changlog:
2005-02-21  Andreas Vox  <[EMAIL PROTECTED]>
* Dialogs.[hC] (show,show): prevent that show() gets called 
recursively





dialogs-show.diff
Description: Binary data


Re: [Patch] Bug 1119: Disable recursive Dialog::show()

2005-02-21 Thread Angus Leeming
Andreas Vox wrote:
Hi Angus!
Is this patch now in an acceptable state for committing? :-)
I made 'in_show' a private member of Dialogs and cleaned up a little.
It looks good to me. Do you have karma or would you like me to commit it on 
your behalf?
Angus


Re: [Patch] Bug 1119: Disable recursive Dialog::show()

2005-02-21 Thread Andreas Vox
Angus Leeming <[EMAIL PROTECTED]> writes:

> It looks good to me. Do you have karma

Karma ??? Like in CVS-write-karma?
Nah, I'm a rational scientific atheist! ;-)

>  or would you like me to commit it on your behalf?

Yes please. 

/Andreas



Re: [Patch] Bug 1119: Disable recursive Dialog::show()

2005-02-21 Thread Juergen Spitzmueller
Andreas Vox wrote:
> >  or would you like me to commit it on your behalf?
>
> Yes please.

JMarc, I think this is also interesting for 1.3

Jürgen