Re: [Patch] RtL space width bug fix
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin The displayed width of a space on-screen is taken from the Martin wrong position in the row... but only for RtL text. And thus Martin the row display is messed up if it contains spaces. Patch Martin fixes this. Martin I believe this to be correct, but please test. Bug and patch Martin are in bugzilla: bug 2029. The fix looks indeed correct. getChar should not be passed a visible pos, but a logical one. Please apply. JMarc
Re: [Patch] RtL space width bug fix
On Mon, 2005-09-19 at 11:48 +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin The displayed width of a space on-screen is taken from the Martin wrong position in the row... but only for RtL text. And thus Martin the row display is messed up if it contains spaces. Patch Martin fixes this. Martin I believe this to be correct, but please test. Bug and patch Martin are in bugzilla: bug 2029. The fix looks indeed correct. getChar should not be passed a visible pos, but a logical one. Please apply. Done. Martin V signature.asc Description: This is a digitally signed message part
Re: [Patch] RtL space width bug fix
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> The displayed width of a space on-screen is taken from the Martin> wrong position in the row... but only for RtL text. And thus Martin> the row display is messed up if it contains spaces. Patch Martin> fixes this. Martin> I believe this to be correct, but please test. Bug and patch Martin> are in bugzilla: bug 2029. The fix looks indeed correct. getChar should not be passed a visible pos, but a logical one. Please apply. JMarc
Re: [Patch] RtL space width bug fix
On Mon, 2005-09-19 at 11:48 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> The displayed width of a space on-screen is taken from the > Martin> wrong position in the row... but only for RtL text. And thus > Martin> the row display is messed up if it contains spaces. Patch > Martin> fixes this. > > Martin> I believe this to be correct, but please test. Bug and patch > Martin> are in bugzilla: bug 2029. > > The fix looks indeed correct. getChar should not be passed a visible > pos, but a logical one. > > Please apply. Done. Martin V signature.asc Description: This is a digitally signed message part
[Patch] RtL space width bug fix
The displayed width of a space on-screen is taken from the wrong
position in the row... but only for RtL text. And thus the row display
is messed up if it contains spaces. Patch fixes this.
I believe this to be correct, but please test. Bug and patch are in
bugzilla: bug 2029.
- Martin
Index: rowpainter.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/rowpainter.C,v
retrieving revision 1.155
diff -u -p -r1.155 rowpainter.C
--- rowpainter.C7 Sep 2005 10:37:00 - 1.155
+++ rowpainter.C16 Sep 2005 14:38:37 -
@@ -627,7 +627,7 @@ void RowPainter::paintText()
}
const int width_pos =
- text_.singleWidth(par_, vpos, par_.getChar(vpos), font);
+ text_.singleWidth(par_, pos, par_.getChar(pos), font);
if (x_ + width_pos 0) {
x_ += width_pos;
[Patch] RtL space width bug fix
The displayed width of a space on-screen is taken from the wrong
position in the row... but only for RtL text. And thus the row display
is messed up if it contains spaces. Patch fixes this.
I believe this to be correct, but please test. Bug and patch are in
bugzilla: bug 2029.
- Martin
Index: rowpainter.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/rowpainter.C,v
retrieving revision 1.155
diff -u -p -r1.155 rowpainter.C
--- rowpainter.C7 Sep 2005 10:37:00 - 1.155
+++ rowpainter.C16 Sep 2005 14:38:37 -
@@ -627,7 +627,7 @@ void RowPainter::paintText()
}
const int width_pos =
- text_.singleWidth(par_, vpos, par_.getChar(vpos), font);
+ text_.singleWidth(par_, pos, par_.getChar(pos), font);
if (x_ + width_pos < 0) {
x_ += width_pos;
