Re: [Patch Bug 3727] Environment combobox not updated when clicking bullet on toolbar
Alfredo Braunstein wrote: This whole current_layout business smells bad though... Indeed. Jürgen
Re: [Patch Bug 3727] Environment combobox not updated when clicking bullet on toolbar
Alfredo Braunstein wrote: > This whole current_layout business smells bad though... Indeed. Jürgen
[Patch Bug 3727] Environment combobox not updated when clicking bullet on toolbar
The attached onliner fixes the issue for me (and Uwe).
Explanation: if current_layout is updated here, the test in LyXView.cpp:462
returns false and the combo is not updated. Furthermore, current_layout will
be reset in LyXView.cpp (after the combo update).
OK?
Jürgen
Index: src/Text3.cpp
===
--- src/Text3.cpp (Revision 18821)
+++ src/Text3.cpp (Arbeitskopie)
@@ -947,7 +947,6 @@
}
if (change_layout) {
- current_layout = layout;
setLayout(cur, layout);
// inform the GUI that the layout has changed.
bv-layoutChanged(layout);
Re: [Patch Bug 3727] Environment combobox not updated when clicking bullet on toolbar
On Friday 22 June 2007 16:37:53 Jürgen Spitzmüller wrote: The attached onliner fixes the issue for me (and Uwe). Explanation: if current_layout is updated here, the test in LyXView.cpp:462 returns false and the combo is not updated. Furthermore, current_layout will be reset in LyXView.cpp (after the combo update). OK? Jürgen OK. -- José Abílio
Re: [Patch Bug 3727] Environment combobox not updated when clicking bullet on toolbar
Jürgen Spitzmüller wrote: The attached onliner fixes the issue for me (and Uwe). Explanation: if current_layout is updated here, the test in LyXView.cpp:462 returns false and the combo is not updated. Furthermore, current_layout will be reset in LyXView.cpp (after the combo update). OK? Jürgen OK. This whole current_layout business smells bad though... A/
Re: [Patch Bug 3727] Environment combobox not updated when clicking bullet on toolbar
Explanation: if current_layout is updated here, the test in LyXView.cpp:462 returns false and the combo is not updated. Furthermore, current_layout will be reset in LyXView.cpp (after the combo update). Does this fix the issue of layout change with shortcut? Bo
Re: [Patch Bug 3727] Environment combobox not updated when clicking bullet on toolbar
Does this fix the issue of layout change with shortcut? Yes. Uwe
[Patch Bug 3727] Environment combobox not updated when clicking bullet on toolbar
The attached onliner fixes the issue for me (and Uwe).
Explanation: if current_layout is updated here, the test in LyXView.cpp:462
returns false and the combo is not updated. Furthermore, current_layout will
be reset in LyXView.cpp (after the combo update).
OK?
Jürgen
Index: src/Text3.cpp
===
--- src/Text3.cpp (Revision 18821)
+++ src/Text3.cpp (Arbeitskopie)
@@ -947,7 +947,6 @@
}
if (change_layout) {
- current_layout = layout;
setLayout(cur, layout);
// inform the GUI that the layout has changed.
bv->layoutChanged(layout);
Re: [Patch Bug 3727] Environment combobox not updated when clicking bullet on toolbar
On Friday 22 June 2007 16:37:53 Jürgen Spitzmüller wrote: > The attached onliner fixes the issue for me (and Uwe). > > Explanation: if current_layout is updated here, the test in LyXView.cpp:462 > returns false and the combo is not updated. Furthermore, current_layout > will be reset in LyXView.cpp (after the combo update). > > OK? > > Jürgen OK. -- José Abílio
Re: [Patch Bug 3727] Environment combobox not updated when clicking bullet on toolbar
Jürgen Spitzmüller wrote: > The attached onliner fixes the issue for me (and Uwe). > > Explanation: if current_layout is updated here, the test in > LyXView.cpp:462 returns false and the combo is not updated. Furthermore, > current_layout will be reset in LyXView.cpp (after the combo update). > > OK? > > Jürgen OK. This whole current_layout business smells bad though... A/
Re: [Patch Bug 3727] Environment combobox not updated when clicking bullet on toolbar
> Explanation: if current_layout is updated here, the test in LyXView.cpp:462 > returns false and the combo is not updated. Furthermore, current_layout > will be reset in LyXView.cpp (after the combo update). Does this fix the issue of layout change with shortcut? Bo
Re: [Patch Bug 3727] Environment combobox not updated when clicking bullet on toolbar
> Does this fix the issue of layout change with shortcut? Yes. Uwe
