Re: [patch] Do not open or close branches after doc settings
On Sun, Mar 12, 2017 at 11:23:33PM -0400, Scott Kostyshak wrote: > > > Thanks for the feedback, Günter and Andrew. I propose two questions for > > > going forward: > > > (2) Which behavior should be changed? > > I'm still looking for feedback on the above issue. > > If no one has feedback, I'll make a decision and commit to master. I removed the behavior of automatically opening all branch insets on activation in document settings, and closing them on deactivation, at 742b39f4. This behavior was inconsistent with activating/deactivating in the context-menu of a branch inset, and assumed a workflow of the user. Günter, Andrew, and Scott seemed to prefer this change. Pavel seemed against the change, but not enough to put up a fight. Scott signature.asc Description: PGP signature
Re: [patch] Do not open or close branches after doc settings
On Sat, Jan 21, 2017 at 11:32:27PM -0500, Scott Kostyshak wrote: > On Mon, Nov 21, 2016 at 09:34:40PM -0500, Scott Kostyshak wrote: > > On Tue, Nov 22, 2016 at 09:07:35AM +1300, Andrew Parsloe wrote: > > > On 21/11/2016 6:34 p.m., Scott Kostyshak wrote: > > > > > As an occasional user of branches, when I deactivate a branch I expect the > > > state of insets in the branch to be left in their current state, some > > > open, > > > some closed, as the case may be. When I reactivate the branch I expect to > > > recover that previous state. This seems to me the *minimal* assumption for > > > LyX to make -- there was, presumably, good reason for the insets to be in > > > that particular configuration. LyX should respect that when the branch is > > > reactivated. > > > > Thanks for the feedback, Günter and Andrew. I propose two questions for > > going forward: > > > > (1) Do others agree that LyX should be consistent and treat > > activating/deactivating branches from right-clicking on a branch inset > > the same as activating from Document Settings? > > > > (2) Which behavior should be changed? > > > > If the answer to (1) is "it is not inconsistent to treat those > > situations differently", then we can just leave things as they are and > > we don't need to change anything. If the answer is that we should change > > one or the other to be consistent, then we need to debate (2). > > > > For (2), the code for document settings explicitly makes a point to > > open/close the activated/deactivated branches, and it has been this way > > for a very long time, from what I see. So the burden would be on us to > > argue that changing it makes considerably more sense than changing the > > right-click activate/deactivate. I'm not sure how to proceed in this > > case. If other developers agree, we could ask on lyx-users to see what > > they think. I think this is a perfect situation for taking a poll of > > users. > > I'm still looking for feedback on the above issue. If no one has feedback, I'll make a decision and commit to master. Scott signature.asc Description: PGP signature
Re: [patch] Do not open or close branches after doc settings
On Mon, Nov 21, 2016 at 09:34:40PM -0500, Scott Kostyshak wrote: > On Tue, Nov 22, 2016 at 09:07:35AM +1300, Andrew Parsloe wrote: > > On 21/11/2016 6:34 p.m., Scott Kostyshak wrote: > > > As an occasional user of branches, when I deactivate a branch I expect the > > state of insets in the branch to be left in their current state, some open, > > some closed, as the case may be. When I reactivate the branch I expect to > > recover that previous state. This seems to me the *minimal* assumption for > > LyX to make -- there was, presumably, good reason for the insets to be in > > that particular configuration. LyX should respect that when the branch is > > reactivated. > > Thanks for the feedback, Günter and Andrew. I propose two questions for > going forward: > > (1) Do others agree that LyX should be consistent and treat > activating/deactivating branches from right-clicking on a branch inset > the same as activating from Document Settings? > > (2) Which behavior should be changed? > > If the answer to (1) is "it is not inconsistent to treat those > situations differently", then we can just leave things as they are and > we don't need to change anything. If the answer is that we should change > one or the other to be consistent, then we need to debate (2). > > For (2), the code for document settings explicitly makes a point to > open/close the activated/deactivated branches, and it has been this way > for a very long time, from what I see. So the burden would be on us to > argue that changing it makes considerably more sense than changing the > right-click activate/deactivate. I'm not sure how to proceed in this > case. If other developers agree, we could ask on lyx-users to see what > they think. I think this is a perfect situation for taking a poll of > users. I'm still looking for feedback on the above issue. Scott signature.asc Description: PGP signature
Re: [patch] Do not open or close branches after doc settings
On Tue, Nov 22, 2016 at 09:07:35AM +1300, Andrew Parsloe wrote: > On 21/11/2016 6:34 p.m., Scott Kostyshak wrote: > As an occasional user of branches, when I deactivate a branch I expect the > state of insets in the branch to be left in their current state, some open, > some closed, as the case may be. When I reactivate the branch I expect to > recover that previous state. This seems to me the *minimal* assumption for > LyX to make -- there was, presumably, good reason for the insets to be in > that particular configuration. LyX should respect that when the branch is > reactivated. Thanks for the feedback, Günter and Andrew. I propose two questions for going forward: (1) Do others agree that LyX should be consistent and treat activating/deactivating branches from right-clicking on a branch inset the same as activating from Document Settings? (2) Which behavior should be changed? If the answer to (1) is "it is not inconsistent to treat those situations differently", then we can just leave things as they are and we don't need to change anything. If the answer is that we should change one or the other to be consistent, then we need to debate (2). For (2), the code for document settings explicitly makes a point to open/close the activated/deactivated branches, and it has been this way for a very long time, from what I see. So the burden would be on us to argue that changing it makes considerably more sense than changing the right-click activate/deactivate. I'm not sure how to proceed in this case. If other developers agree, we could ask on lyx-users to see what they think. I think this is a perfect situation for taking a poll of users. Scott signature.asc Description: PGP signature
Re: [patch] Do not open or close branches after doc settings
On 21/11/2016 6:34 p.m., Scott Kostyshak wrote: On Wed, Nov 02, 2016 at 09:22:19PM -0400, Scott Kostyshak wrote: On Wed, Nov 02, 2016 at 05:22:57PM -0700, Pavel Sanda wrote: Shrug. Opening branch insets I'm activating seems pretty intuitive to me. Pavel OK let's keep that behavior then, especially since it's been in LyX for a long time. So to be consistent, when right-clicking on a branch inset and deactivating it, all insets in that branch should close also in this case? And vice-versa when activating? I personally don't like this, but I do like consistency. Scott As an occasional user of branches, when I deactivate a branch I expect the state of insets in the branch to be left in their current state, some open, some closed, as the case may be. When I reactivate the branch I expect to recover that previous state. This seems to me the *minimal* assumption for LyX to make -- there was, presumably, good reason for the insets to be in that particular configuration. LyX should respect that when the branch is reactivated. Andrew --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus
Re: [patch] Do not open or close branches after doc settings
On 2016-11-21, Scott Kostyshak wrote: > [-- Type: text/plain, Encoding: quoted-printable --] > On Wed, Nov 02, 2016 at 09:22:19PM -0400, Scott Kostyshak wrote: >> On Wed, Nov 02, 2016 at 05:22:57PM -0700, Pavel Sanda wrote: >> > Shrug. Opening branch insets I'm activating seems pretty intuitive >> > to me. Pavel >> OK let's keep that behavior then, especially since it's been in LyX for >> a long time. > So to be consistent, when right-clicking on a branch inset and > deactivating it, all insets in that branch should close also in this > case? And vice-versa when activating? I personally don't like this, I don't like this either. > but I do like consistency. Günter
Re: [patch] Do not open or close branches after doc settings
On Wed, Nov 02, 2016 at 09:22:19PM -0400, Scott Kostyshak wrote: > On Wed, Nov 02, 2016 at 05:22:57PM -0700, Pavel Sanda wrote: > > > Shrug. Opening branch insets I'm activating seems pretty intuitive to me. > > Pavel > > OK let's keep that behavior then, especially since it's been in LyX for > a long time. So to be consistent, when right-clicking on a branch inset and deactivating it, all insets in that branch should close also in this case? And vice-versa when activating? I personally don't like this, but I do like consistency. Scott signature.asc Description: PGP signature
Re: [patch] Do not open or close branches after doc settings
On Wed, Nov 02, 2016 at 05:22:57PM -0700, Pavel Sanda wrote: > Shrug. Opening branch insets I'm activating seems pretty intuitive to me. > Pavel OK let's keep that behavior then, especially since it's been in LyX for a long time. Scott signature.asc Description: PGP signature
Re: [patch] Do not open or close branches after doc settings
Scott Kostyshak wrote: > On Mon, Oct 31, 2016 at 09:39:01PM -0700, Pavel Sanda wrote: > > Scott Kostyshak wrote: > > > Even if the intention is to only do it when the user > > > activates/deactivates a branch in the branches tab of document settings, > > > > that's the point. if you have many branches it can be annoying > > change all of that manually. > > I see. But shouldn't activating a branch and opening the insets be two > different operations? To me bundling them assumes a certain workflow > that I'm not convinced is that common. Shrug. Opening branch insets I'm activating seems pretty intuitive to me. Pavel
Re: [patch] Do not open or close branches after doc settings
On Mon, Oct 31, 2016 at 09:39:01PM -0700, Pavel Sanda wrote: > Scott Kostyshak wrote: > > Even if the intention is to only do it when the user > > activates/deactivates a branch in the branches tab of document settings, > > that's the point. if you have many branches it can be annoying > change all of that manually. I see. But shouldn't activating a branch and opening the insets be two different operations? To me bundling them assumes a certain workflow that I'm not convinced is that common. Scott signature.asc Description: PGP signature
Re: [patch] Do not open or close branches after doc settings
Scott Kostyshak wrote: > Even if the intention is to only do it when the user > activates/deactivates a branch in the branches tab of document settings, that's the point. if you have many branches it can be annoying change all of that manually. that does not justify global opening/closing when br. settings were not changed though. p
Re: [patch] Do not open or close branches after doc settings
On Sun, Oct 30, 2016 at 06:08:13PM -0400, Scott Kostyshak wrote: > Thoughts? Patch attached. Scott From d0df5f87ca180e2b6ab8c1276718f644061d44d7 Mon Sep 17 00:00:00 2001 From: Scott Kostyshak Date: Sun, 30 Oct 2016 17:50:40 -0400 Subject: [PATCH] Do not open or close branches after doc settings When changing applying or saving Document Settings, there is no reason to open or close branch insets based on whether the branch of the inset is active. The user likely does not expect this. This modifies fd6cd728. --- src/frontends/qt4/GuiDocument.cpp | 4 1 file changed, 4 deletions(-) diff --git a/src/frontends/qt4/GuiDocument.cpp b/src/frontends/qt4/GuiDocument.cpp index 2a40873..1b3236a 100644 --- a/src/frontends/qt4/GuiDocument.cpp +++ b/src/frontends/qt4/GuiDocument.cpp @@ -3828,10 +3828,6 @@ void GuiDocument::dispatchParams() docstring const str = current_branch + ' ' + from_ascii(x11hexname); dispatch(FuncRequest(LFUN_SET_COLOR, str)); } - - // Open insets of selected branches, close deselected ones - dispatch(FuncRequest(LFUN_INSET_FORALL, - "Branch inset-toggle assign")); } // rename branches in the document executeBranchRenaming(); -- 2.7.4 signature.asc Description: PGP signature
[patch] Do not open or close branches after doc settings
I wouldn't be surprised if I'm missing something here, but what is the point of opening and closing branch insets based on whether they are active, for every change of document setting? The attached patch removes this behavior, which was first introduced a long time ago at fd6cd728. To reproduce the behavior this patch changes: 1. create two new branches. Make one of them active and the other not. Have both of them open. 2. go to Document > Settings and change a setting. Result: the branch inset that is not activated is closed. Even if the intention is to only do it when the user activates/deactivates a branch in the branches tab of document settings, I still would prefer not to assume a workflow of the user. Thoughts? Scott signature.asc Description: PGP signature
