Re: [patch] fix bug 2418

2007-01-18 Thread Jean-Marc Lasgouttes
 Uwe == Uwe Stöhr [EMAIL PROTECTED] writes:

Uwe I got no complaints, so it's in now. JMarc, do you want this for
Uwe branch too?

Yes please.

JMarc


Re: [patch] fix bug 2418

2007-01-18 Thread Jean-Marc Lasgouttes
> "Uwe" == Uwe Stöhr <[EMAIL PROTECTED]> writes:

Uwe> I got no complaints, so it's in now. JMarc, do you want this for
Uwe> branch too?

Yes please.

JMarc


Re: [patch] fix bug 2418

2007-01-17 Thread Uwe Stöhr

I got no complaints, so it's in now.

JMarc, do you want this for branch too?

regards Uwe


Re: [patch] fix bug 2418

2007-01-17 Thread Uwe Stöhr

I got no complaints, so it's in now.

JMarc, do you want this for branch too?

regards Uwe


Re: [patch] fix bug 2418

2007-01-15 Thread Uwe Stöhr

Georg wrote:

 Can you please test it on Linux as well?

 Sorry, my imagemagick is too old: 6.2.4

No, this is perfect! If the patch works with your ImageMagick version I can put it in. All newer 
versions are already tested.


regards Uwe


Re: [patch] fix bug 2418

2007-01-15 Thread Uwe Stöhr

Georg wrote:

>> Can you please test it on Linux as well?
>
> Sorry, my imagemagick is too old: 6.2.4

No, this is perfect! If the patch works with your ImageMagick version I can put it in. All newer 
versions are already tested.


regards Uwe


Re: [patch] fix bug 2418

2007-01-14 Thread Georg Baum
Am Sonntag, 14. Januar 2007 02:54 schrieb Uwe Stöhr:

 What do you mean? What is broken or incorrect?

I wrote that some days ago: 
http://www.mail-archive.com/lyx-devel%40lists.lyx.org/msg108584.html. Did 
you not see my message?


Georg



Re: [patch] fix bug 2418

2007-01-14 Thread Georg Baum
Am Sonntag, 14. Januar 2007 02:54 schrieb Uwe Stöhr:

> What do you mean? What is broken or incorrect?

I wrote that some days ago: 
http://www.mail-archive.com/lyx-devel%40lists.lyx.org/msg108584.html. Did 
you not see my message?


Georg



[patch] fix bug 2418

2007-01-13 Thread Uwe Stöhr

The fix for this is quite simple: call ImageMagick with an additional parameter.

The parameter only has an effect when at least mageMagick 6.2.6-4 is installed, for older versions 
it does nothing and keeps the current situation.


The fix is included in my win builds for ten months now, so thousands of users tested it without 
problems.

Can you please test it on Linux as well?
A test PDF-file is attached in bug 2418:
http://bugzilla.lyx.org/show_bug.cgi?id=2418

As the ImageMagick option was build especially for us, we should use it. And personally this was one 
of the most annoying bugs since I use PDF-images in all of my documents and then my documents 
consists of huge A4-sized whitespace monsters that totally destroys the layout.


Note this doesn't change the output result as the problem is only the display 
of PDF-images within LyX.

thanks and regards
Uwe
Index: convertDefault.py
===
--- convertDefault.py	(revision 16655)
+++ convertDefault.py	(working copy)
@@ -18,7 +18,7 @@
 
 # converts an image from $1 to $2 format
 import os, sys
-if os.system(r'convert -depth 8 %s %s' % (sys.argv[1], sys.argv[2])) != 0:
+if os.system(r'convert -define pdf:use-cropbox=true -depth 8 %s %s' % (sys.argv[1], sys.argv[2])) != 0:
 print  sys.stderr, sys.argv[0], 'ERROR'
 print  sys.stderr, 'Execution of convert failed.'
 sys.exit(1)


Re: [patch] fix bug 2418

2007-01-13 Thread Georg Baum
Am Samstag, 13. Januar 2007 18:37 schrieb Uwe Stöhr:

 Can you please test it on Linux as well?

Sorry, my imagemagick is too old: 6.2.4

 Note this doesn't change the output result as the problem is only the 
display of PDF-images within LyX.

Why? I would think that it would also affect the conversion from pdf to eps 
for plain latex output. This would be fine for me personally.


Georg

PS: You should fix your documentation commits before doing any further 
changes IMO.



Re: [patch] fix bug 2418

2007-01-13 Thread Uwe Stöhr

 Why? I would think that it would also affect the conversion from pdf to eps
 for plain latex output. This would be fine for me personally.

In this case yes.

 PS: You should fix your documentation commits before doing any further
 changes IMO.

What do you mean? What is broken or incorrect?

regards Uwe


[patch] fix bug 2418

2007-01-13 Thread Uwe Stöhr

The fix for this is quite simple: call ImageMagick with an additional parameter.

The parameter only has an effect when at least mageMagick 6.2.6-4 is installed, for older versions 
it does nothing and keeps the current situation.


The fix is included in my win builds for ten months now, so thousands of users tested it without 
problems.

Can you please test it on Linux as well?
A test PDF-file is attached in bug 2418:
http://bugzilla.lyx.org/show_bug.cgi?id=2418

As the ImageMagick option was build especially for us, we should use it. And personally this was one 
of the most annoying bugs since I use PDF-images in all of my documents and then my documents 
consists of huge A4-sized whitespace monsters that totally destroys the layout.


Note this doesn't change the output result as the problem is only the display 
of PDF-images within LyX.

thanks and regards
Uwe
Index: convertDefault.py
===
--- convertDefault.py	(revision 16655)
+++ convertDefault.py	(working copy)
@@ -18,7 +18,7 @@
 
 # converts an image from $1 to $2 format
 import os, sys
-if os.system(r'convert -depth 8 "%s" "%s"' % (sys.argv[1], sys.argv[2])) != 0:
+if os.system(r'convert -define pdf:use-cropbox=true -depth 8 "%s" "%s"' % (sys.argv[1], sys.argv[2])) != 0:
 print >> sys.stderr, sys.argv[0], 'ERROR'
 print >> sys.stderr, 'Execution of "convert" failed.'
 sys.exit(1)


Re: [patch] fix bug 2418

2007-01-13 Thread Georg Baum
Am Samstag, 13. Januar 2007 18:37 schrieb Uwe Stöhr:

> Can you please test it on Linux as well?

Sorry, my imagemagick is too old: 6.2.4

> Note this doesn't change the output result as the problem is only the 
display of PDF-images within LyX.

Why? I would think that it would also affect the conversion from pdf to eps 
for plain latex output. This would be fine for me personally.


Georg

PS: You should fix your documentation commits before doing any further 
changes IMO.



Re: [patch] fix bug 2418

2007-01-13 Thread Uwe Stöhr

> Why? I would think that it would also affect the conversion from pdf to eps
> for plain latex output. This would be fine for me personally.

In this case yes.

> PS: You should fix your documentation commits before doing any further
> changes IMO.

What do you mean? What is broken or incorrect?

regards Uwe