Re: 1.5.X Patch Candidate List #3

2007-09-20 Thread Juergen Spitzmueller 
Richard Heck wrote:

 I've committed this.

OK. Thanks.

Jürgen

Re: 1.5.X Patch Candidate List #3

2007-09-20 Thread José Matos 
On Wednesday 19 September 2007 19:43:39 Juergen Spitzmueller wrote:
  http://www.lyx.org/trac/changeset/20279 - lyx2lyx: use parseopt instead
  of getopt

 Jürgen

The change is only relevant to the command line interface so it is not 
relevant for the moment. Eventually in the latest stable version we will 
backport this so I am not in a hurry. :-)

-- 
José Abílio

Re: 1.5.X Patch Candidate List #3

2007-09-20 Thread Juergen Spitzmueller 
José Matos wrote:

 The change is only relevant to the command line interface so it is not
 relevant for the moment. Eventually in the latest stable version we will
 backport this so I am not in a hurry.

OK.

Jürgen

Re: 1.5.X Patch Candidate List #3

2007-09-20 Thread Andre Poenitz 
On Thu, Sep 20, 2007 at 12:22:16AM +0200, Enrico Forestieri wrote:
 On Wed, Sep 19, 2007 at 06:56:34PM +0200, Michael Gerz wrote:
 
  http://www.lyx.org/trac/changeset/20260 - Darken vertical stroke on + 
  sign as it disappears on some graphic cards.
 
 Not applicable. This only happens with png images and not xpm ones.
 In general, it seems that xpm images are better rendered on various
 platforms. For example, png images really suck with Qt4 on Solaris,
 whereas xpm images are Ok (however, I must say that Qt4 sucks on Solaris).

Can you please provide a screenshot or such?

Andre'

Re: 1.5.X Patch Candidate List #3

2007-09-20 Thread Juergen Spitzmueller 
Richard Heck wrote:

> I've committed this.

OK. Thanks.

Jürgen

Re: 1.5.X Patch Candidate List #3

2007-09-20 Thread José Matos 
On Wednesday 19 September 2007 19:43:39 Juergen Spitzmueller wrote:
> > http://www.lyx.org/trac/changeset/20279 - lyx2lyx: use parseopt instead
> > of getopt
>
> Jürgen

The change is only relevant to the command line interface so it is not 
relevant for the moment. Eventually in the latest stable version we will 
backport this so I am not in a hurry. :-)

-- 
José Abílio

Re: 1.5.X Patch Candidate List #3

2007-09-20 Thread Juergen Spitzmueller 
José Matos wrote:

> The change is only relevant to the command line interface so it is not
> relevant for the moment. Eventually in the latest stable version we will
> backport this so I am not in a hurry.

OK.

Jürgen

Re: 1.5.X Patch Candidate List #3

2007-09-20 Thread Andre Poenitz 
On Thu, Sep 20, 2007 at 12:22:16AM +0200, Enrico Forestieri wrote:
> On Wed, Sep 19, 2007 at 06:56:34PM +0200, Michael Gerz wrote:
> 
> > http://www.lyx.org/trac/changeset/20260 - Darken vertical stroke on + 
> > sign as it disappears on some graphic cards.
> 
> Not applicable. This only happens with png images and not xpm ones.
> In general, it seems that xpm images are better rendered on various
> platforms. For example, png images really suck with Qt4 on Solaris,
> whereas xpm images are Ok (however, I must say that Qt4 sucks on Solaris).

Can you please provide a screenshot or such?

Andre'

1.5.X Patch Candidate List #3

2007-09-19 Thread Michael Gerz 

Hi,

here comes a new 1.5.X patch candidate list. Please tell me which 
patches are (ir)relevant/(not) applicable.


Regards, Michael


New
---
http://www.lyx.org/trac/changeset/20260 - Darken vertical stroke on + 
sign as it disappears on some graphic cards.
http://www.lyx.org/trac/changeset/20261 - Force current font to red 
typewriter in ERT
http://www.lyx.org/trac/changeset/20264 - amsmaths.inc: fix copy and 
paste bug spotted by Georg
http://www.lyx.org/trac/changeset/20267 - Somehow this got missed when 
(partially) fixing the recursive include problem.
http://www.lyx.org/trac/changeset/20274 - Text::breakParagraph wants a 
bool as second parameter, not an int
http://www.lyx.org/trac/changeset/20277 - Fix Cursor::setCurrentFont() 
within mathed.
http://www.lyx.org/trac/changeset/20279 - lyx2lyx: use parseopt instead 
of getopt
http://www.lyx.org/trac/changeset/20283 - Give PageDown/Up scrolling a 
sane behaviour. Does not work with selection yet...
http://www.lyx.org/trac/changeset/20287 - Give a sane behaviour to page 
up/down scrolling when clicking in the page scroll area of the scrollbar.
http://www.lyx.org/trac/changeset/20288 - LFUN_SCREEN_UP/DOWN: Take into 
account the off-screen cursor case.
http://www.lyx.org/trac/changeset/20296 - [...] prevent double deletion 
of socket notifier
http://www.lyx.org/trac/changeset/20326 - Cleanup the 
TEXT_TO_INSET_OFFSET mess. This correction is done now once in InsetText.
http://www.lyx.org/trac/changeset/20327 - remove 
InsetCollapsable::drawSelection(): this was not used.
http://www.lyx.org/trac/changeset/20328 - remove 
InsetCaption::drawSelection(): this was not used.

http://www.lyx.org/trac/changeset/20329 - little simplification
http://www.lyx.org/trac/changeset/20331 - InsetCollapsable::draw(): 
replace use of dim_ with InsetText::dimension().

http://www.lyx.org/trac/changeset/20332 - small simplification
http://www.lyx.org/trac/changeset/20334 - Fix InsetBox drawing and 
remove remnant of the wide() hack.
http://www.lyx.org/trac/changeset/20353 - Pick up some stitches dropped 
by Abdel

http://www.lyx.org/trac/changeset/20354 - Polish
http://www.lyx.org/trac/changeset/20357 - make sure formats are sorted 
and converters up-to-date

Re: 1.5.X Patch Candidate List #3

2007-09-19 Thread Juergen Spitzmueller 
Michael Gerz wrote:
 here comes a new 1.5.X patch candidate list. Please tell me which
 patches are (ir)relevant/(not) applicable.

I think (but others might correct me), none of these (except for those that
are aready in or on the list I sent last week) are relevant, except perhaps
for these:

 http://www.lyx.org/trac/changeset/20267 - Somehow this got missed when
 (partially) fixing the recursive include problem.

 http://www.lyx.org/trac/changeset/20277 - Fix Cursor::setCurrentFont()
 within mathed.

 http://www.lyx.org/trac/changeset/20279 - lyx2lyx: use parseopt instead
 of getopt

Jürgen

Re: 1.5.X Patch Candidate List #3

2007-09-19 Thread Abdelrazak Younes 

Juergen Spitzmueller wrote:

Michael Gerz wrote:

here comes a new 1.5.X patch candidate list. Please tell me which
patches are (ir)relevant/(not) applicable.


I think (but others might correct me), none of these (except for those that
are aready in or on the list I sent last week) are relevant,


Agreed.


except perhaps
for these:


http://www.lyx.org/trac/changeset/20267 - Somehow this got missed when
(partially) fixing the recursive include problem.


Possibly yes.




http://www.lyx.org/trac/changeset/20277 - Fix Cursor::setCurrentFont()
within mathed.


No.

Abdel.

Re: 1.5.X Patch Candidate List #3

2007-09-19 Thread Enrico Forestieri 
On Wed, Sep 19, 2007 at 06:56:34PM +0200, Michael Gerz wrote:

 http://www.lyx.org/trac/changeset/20260 - Darken vertical stroke on + 
 sign as it disappears on some graphic cards.

Not applicable. This only happens with png images and not xpm ones.
In general, it seems that xpm images are better rendered on various
platforms. For example, png images really suck with Qt4 on Solaris,
whereas xpm images are Ok (however, I must say that Qt4 sucks on Solaris).

-- 
Enrico

Re: 1.5.X Patch Candidate List #3

2007-09-19 Thread Richard Heck 

Abdelrazak Younes wrote:

Juergen Spitzmueller wrote:

http://www.lyx.org/trac/changeset/20267 - Somehow this got missed when
(partially) fixing the recursive include problem.

Possibly yes.
I've committed this. I don't know that it was causing problems. I don't 
even know that this function gets used---it's the non-const version of 
getMasterBuffer(). But it ought to parallel the const version, and there 
easily could be problems here. The more serious question is how best to 
check for recursive includes in general, as opposed just to a document 
that includes itself.


Richard

--
==
Richard G Heck, Jr
Professor of Philosophy
Brown University
http://frege.brown.edu/heck/
==
Get my public key from http://sks.keyserver.penguin.de
Hash: 0x1DE91F1E66FFBDEC
Learn how to sign your email using Thunderbird and GnuPG at:
http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto

1.5.X Patch Candidate List #3

2007-09-19 Thread Michael Gerz 

Hi,

here comes a new 1.5.X patch candidate list. Please tell me which 
patches are (ir)relevant/(not) applicable.


Regards, Michael


New
---
http://www.lyx.org/trac/changeset/20260 - Darken vertical stroke on + 
sign as it disappears on some graphic cards.
http://www.lyx.org/trac/changeset/20261 - Force current font to red 
typewriter in ERT
http://www.lyx.org/trac/changeset/20264 - amsmaths.inc: fix copy and 
paste bug spotted by Georg
http://www.lyx.org/trac/changeset/20267 - Somehow this got missed when 
(partially) fixing the recursive include problem.
http://www.lyx.org/trac/changeset/20274 - Text::breakParagraph wants a 
bool as second parameter, not an int
http://www.lyx.org/trac/changeset/20277 - Fix Cursor::setCurrentFont() 
within mathed.
http://www.lyx.org/trac/changeset/20279 - lyx2lyx: use parseopt instead 
of getopt
http://www.lyx.org/trac/changeset/20283 - Give PageDown/Up scrolling a 
sane behaviour. Does not work with selection yet...
http://www.lyx.org/trac/changeset/20287 - Give a sane behaviour to page 
up/down scrolling when clicking in the page scroll area of the scrollbar.
http://www.lyx.org/trac/changeset/20288 - LFUN_SCREEN_UP/DOWN: Take into 
account the off-screen cursor case.
http://www.lyx.org/trac/changeset/20296 - [...] prevent double deletion 
of socket notifier
http://www.lyx.org/trac/changeset/20326 - Cleanup the 
TEXT_TO_INSET_OFFSET mess. This correction is done now once in InsetText.
http://www.lyx.org/trac/changeset/20327 - remove 
InsetCollapsable::drawSelection(): this was not used.
http://www.lyx.org/trac/changeset/20328 - remove 
InsetCaption::drawSelection(): this was not used.

http://www.lyx.org/trac/changeset/20329 - little simplification
http://www.lyx.org/trac/changeset/20331 - InsetCollapsable::draw(): 
replace use of dim_ with InsetText::dimension().

http://www.lyx.org/trac/changeset/20332 - small simplification
http://www.lyx.org/trac/changeset/20334 - Fix InsetBox drawing and 
remove remnant of the wide() hack.
http://www.lyx.org/trac/changeset/20353 - Pick up some stitches dropped 
by Abdel

http://www.lyx.org/trac/changeset/20354 - Polish
http://www.lyx.org/trac/changeset/20357 - make sure formats are sorted 
and converters up-to-date

Re: 1.5.X Patch Candidate List #3

2007-09-19 Thread Juergen Spitzmueller 
Michael Gerz wrote:
> here comes a new 1.5.X patch candidate list. Please tell me which
> patches are (ir)relevant/(not) applicable.

I think (but others might correct me), none of these (except for those that
are aready in or on the list I sent last week) are relevant, except perhaps
for these:

> http://www.lyx.org/trac/changeset/20267 - Somehow this got missed when
> (partially) fixing the recursive include problem.

> http://www.lyx.org/trac/changeset/20277 - Fix Cursor::setCurrentFont()
> within mathed.

> http://www.lyx.org/trac/changeset/20279 - lyx2lyx: use parseopt instead
> of getopt

Jürgen

Re: 1.5.X Patch Candidate List #3

2007-09-19 Thread Abdelrazak Younes 

Juergen Spitzmueller wrote:

Michael Gerz wrote:

here comes a new 1.5.X patch candidate list. Please tell me which
patches are (ir)relevant/(not) applicable.


I think (but others might correct me), none of these (except for those that
are aready in or on the list I sent last week) are relevant,


Agreed.


except perhaps
for these:


http://www.lyx.org/trac/changeset/20267 - Somehow this got missed when
(partially) fixing the recursive include problem.


Possibly yes.




http://www.lyx.org/trac/changeset/20277 - Fix Cursor::setCurrentFont()
within mathed.


No.

Abdel.

Re: 1.5.X Patch Candidate List #3

2007-09-19 Thread Enrico Forestieri 
On Wed, Sep 19, 2007 at 06:56:34PM +0200, Michael Gerz wrote:

> http://www.lyx.org/trac/changeset/20260 - Darken vertical stroke on + 
> sign as it disappears on some graphic cards.

Not applicable. This only happens with png images and not xpm ones.
In general, it seems that xpm images are better rendered on various
platforms. For example, png images really suck with Qt4 on Solaris,
whereas xpm images are Ok (however, I must say that Qt4 sucks on Solaris).

-- 
Enrico

Re: 1.5.X Patch Candidate List #3

2007-09-19 Thread Richard Heck 

Abdelrazak Younes wrote:

Juergen Spitzmueller wrote:

http://www.lyx.org/trac/changeset/20267 - Somehow this got missed when
(partially) fixing the recursive include problem.

Possibly yes.
I've committed this. I don't know that it was causing problems. I don't 
even know that this function gets used---it's the non-const version of 
getMasterBuffer(). But it ought to parallel the const version, and there 
easily could be problems here. The more serious question is how best to 
check for recursive includes in general, as opposed just to a document 
that includes itself.


Richard

--
==
Richard G Heck, Jr
Professor of Philosophy
Brown University
http://frege.brown.edu/heck/
==
Get my public key from http://sks.keyserver.penguin.de
Hash: 0x1DE91F1E66FFBDEC
Learn how to sign your email using Thunderbird and GnuPG at:
http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto