Re: Alt key shortcut change

[Scott Kostyshak]

On Thu, Aug 7, 2014 at 10:20 PM, Pavel Sanda sa...@lyx.org wrote:

 Here is a patch, I don't know what others think:

 Legit to me. P

It's in at f63146c0.

Scott

Re: Alt key shortcut change

[Scott Kostyshak]

On Thu, Aug 7, 2014 at 10:20 PM, Pavel Sanda  wrote:

>> Here is a patch, I don't know what others think:
>
> Legit to me. P

It's in at f63146c0.

Scott

Re: Alt key shortcut change

[Pavel Sanda]

Scott Kostyshak wrote:
  I found a way to bind the raw command to a particular shortcut (Prefs 
  Editing  Shortcuts  Cursor...Functions  box-insert) but inserting via
  the menu allows me to choose which style of box.
 
 Here is a patch, I don't know what others think:

Legit to me. P
 
 diff --git a/lib/ui/stdmenus.inc b/lib/ui/stdmenus.inc
 index 32ed83e..d26456d 100644
 --- a/lib/ui/stdmenus.inc
 +++ b/lib/ui/stdmenus.inc
 @@ -365,7 +365,7 @@ Menuset
   Submenu Branch|B insert_branches
   Submenu Custom Insets insert_custom
   Submenu File|e insert_file
 - Submenu Box[[Menu]] insert_box
 + Submenu Box[[Menu]]|x insert_box
   OptSubmenu Insert Regular Expression context-edit-regexp
   Separator
   Item Citation...|C dialog-show-new-inset citation
 @@ -382,7 +382,7 @@ Menuset
   Item Footnote|F footnote-insert
   Item Marginal Note|M marginalnote-insert
   Arguments
 - Item TeX Code|X ert-insert
 + Item TeX Code ert-insert
   Item Program Listing[[Menu]] listing-insert
   Item Date date-insert
   Item Preview|w preview-insert
 -- 
 
 [If this can be customized, I haven't discovered how yet.]
 
 You can make your own menu file and put it in your user directory. I
 think this is discussed in Help  Customization.
 
 Scott

Re: Alt key shortcut change

[Pavel Sanda]

Scott Kostyshak wrote:
> > I found a way to bind the raw command to a particular shortcut (Prefs >
> > Editing > Shortcuts > Cursor...Functions > box-insert) but inserting via
> > the menu allows me to choose which style of box.
> 
> Here is a patch, I don't know what others think:

Legit to me. P
 
> diff --git a/lib/ui/stdmenus.inc b/lib/ui/stdmenus.inc
> index 32ed83e..d26456d 100644
> --- a/lib/ui/stdmenus.inc
> +++ b/lib/ui/stdmenus.inc
> @@ -365,7 +365,7 @@ Menuset
>   Submenu "Branch|B" "insert_branches"
>   Submenu "Custom Insets" "insert_custom"
>   Submenu "File|e" "insert_file"
> - Submenu "Box[[Menu]]" "insert_box"
> + Submenu "Box[[Menu]]|x" "insert_box"
>   OptSubmenu "Insert Regular Expression" "context-edit-regexp"
>   Separator
>   Item "Citation...|C" "dialog-show-new-inset citation"
> @@ -382,7 +382,7 @@ Menuset
>   Item "Footnote|F" "footnote-insert"
>   Item "Marginal Note|M" "marginalnote-insert"
>   Arguments
> - Item "TeX Code|X" "ert-insert"
> + Item "TeX Code" "ert-insert"
>   Item "Program Listing[[Menu]]" "listing-insert"
>   Item "Date" "date-insert"
>   Item "Preview|w" "preview-insert"
> -- 
> 
> [If this can be customized, I haven't discovered how yet.]
> 
> You can make your own menu file and put it in your user directory. I
> think this is discussed in Help > Customization.
> 
> Scott

Re: Alt key shortcut change

[Scott Kostyshak]

On Tue, Aug 5, 2014 at 7:22 PM, Patrick O'Keeffe pokee...@wsu.edu wrote:
 I'm not sure this is the same issue: #9227 is about the main menu
 superceding non-modal dialogs. I was suggesting changing the binding
 within the Insert menu so Alt+I, x opens the box submenu instead of
 inserting a Tex code box (since Ctrl+L does that).

You're right, I see what you mean now.

 I found a way to bind the raw command to a particular shortcut (Prefs 
 Editing  Shortcuts  Cursor...Functions  box-insert) but inserting via
 the menu allows me to choose which style of box.

Here is a patch, I don't know what others think:

diff --git a/lib/ui/stdmenus.inc b/lib/ui/stdmenus.inc
index 32ed83e..d26456d 100644
--- a/lib/ui/stdmenus.inc
+++ b/lib/ui/stdmenus.inc
@@ -365,7 +365,7 @@ Menuset
  Submenu Branch|B insert_branches
  Submenu Custom Insets insert_custom
  Submenu File|e insert_file
- Submenu Box[[Menu]] insert_box
+ Submenu Box[[Menu]]|x insert_box
  OptSubmenu Insert Regular Expression context-edit-regexp
  Separator
  Item Citation...|C dialog-show-new-inset citation
@@ -382,7 +382,7 @@ Menuset
  Item Footnote|F footnote-insert
  Item Marginal Note|M marginalnote-insert
  Arguments
- Item TeX Code|X ert-insert
+ Item TeX Code ert-insert
  Item Program Listing[[Menu]] listing-insert
  Item Date date-insert
  Item Preview|w preview-insert
-- 

[If this can be customized, I haven't discovered how yet.]

You can make your own menu file and put it in your user directory. I
think this is discussed in Help  Customization.

Scott

Re: Alt key shortcut change

[Scott Kostyshak]

On Wed, Aug 6, 2014 at 7:40 PM, Patrick O'Keeffe pokee...@wsu.edu wrote:
 I was able to patch `Resources/ui/stdmenus.inc` without having to
 recompile Lyx. Thank you for doing the legwork. I'll take a look at the
 Customization help file regarding a user-defined menu file.

Glad it works. I think you can just put the menus file in the
corresponding ui file in your user dir. But yes, please consult Help 
Customization for details.

Best,

Scott

Re: Alt key shortcut change

[Scott Kostyshak]

On Tue, Aug 5, 2014 at 7:22 PM, Patrick O'Keeffe  wrote:
> I'm not sure this is the same issue: #9227 is about the main menu
> superceding non-modal dialogs. I was suggesting changing the binding
> within the Insert menu so "Alt+I, x" opens the box submenu instead of
> inserting a Tex code box (since Ctrl+L does that).

You're right, I see what you mean now.

> I found a way to bind the raw command to a particular shortcut (Prefs >
> Editing > Shortcuts > Cursor...Functions > box-insert) but inserting via
> the menu allows me to choose which style of box.

Here is a patch, I don't know what others think:

diff --git a/lib/ui/stdmenus.inc b/lib/ui/stdmenus.inc
index 32ed83e..d26456d 100644
--- a/lib/ui/stdmenus.inc
+++ b/lib/ui/stdmenus.inc
@@ -365,7 +365,7 @@ Menuset
  Submenu "Branch|B" "insert_branches"
  Submenu "Custom Insets" "insert_custom"
  Submenu "File|e" "insert_file"
- Submenu "Box[[Menu]]" "insert_box"
+ Submenu "Box[[Menu]]|x" "insert_box"
  OptSubmenu "Insert Regular Expression" "context-edit-regexp"
  Separator
  Item "Citation...|C" "dialog-show-new-inset citation"
@@ -382,7 +382,7 @@ Menuset
  Item "Footnote|F" "footnote-insert"
  Item "Marginal Note|M" "marginalnote-insert"
  Arguments
- Item "TeX Code|X" "ert-insert"
+ Item "TeX Code" "ert-insert"
  Item "Program Listing[[Menu]]" "listing-insert"
  Item "Date" "date-insert"
  Item "Preview|w" "preview-insert"
-- 

[If this can be customized, I haven't discovered how yet.]

You can make your own menu file and put it in your user directory. I
think this is discussed in Help > Customization.

Scott

Re: Alt key shortcut change

[Scott Kostyshak]

On Wed, Aug 6, 2014 at 7:40 PM, Patrick O'Keeffe  wrote:
> I was able to patch `Resources/ui/stdmenus.inc` without having to
> recompile Lyx. Thank you for doing the legwork. I'll take a look at the
> Customization help file regarding a user-defined menu file.

Glad it works. I think you can just put the menus file in the
corresponding ui file in your user dir. But yes, please consult Help >
Customization for details.

Best,

Scott

Alt key shortcut change

[Patrick O'Keeffe]

Thought it might be easier to ask via mailing list than by filing new
issue...

Pressing 'Alt+I' to access the Insert menu, then 'x' inserts a new TeX
code box. Since this has a top-level shortcut (Ctrl+L) I'd like to see
'x' mapped to 'InsertBox' submenu instead. [If this can be customized,
I haven't discovered how yet.]

What does the community think? Is this no-go from the start or up for
discussion? Maybe a change to wait until the next major release?

Patrick O'Keeffe

Re: Alt key shortcut change

[Scott Kostyshak]

n Tue, Aug 5, 2014 at 5:43 PM, Patrick O'Keeffe pokee...@wsu.edu wrote:
 Thought it might be easier to ask via mailing list than by filing new
 issue...

 Pressing 'Alt+I' to access the Insert menu, then 'x' inserts a new TeX
 code box. Since this has a top-level shortcut (Ctrl+L) I'd like to see
 'x' mapped to 'InsertBox' submenu instead. [If this can be customized,
 I haven't discovered how yet.]

 What does the community think? Is this no-go from the start or up for
 discussion? Maybe a change to wait until the next major release?

There is a ticket with the same issue here: http://www.lyx.org/trac/ticket/9227

Scott

Re: Alt key shortcut change

[Patrick O'Keeffe]

I'm not sure this is the same issue: #9227 is about the main menu
superceding non-modal dialogs. I was suggesting changing the binding
within the Insert menu so Alt+I, x opens the box submenu instead of
inserting a Tex code box (since Ctrl+L does that).

I found a way to bind the raw command to a particular shortcut (Prefs 
Editing  Shortcuts  Cursor...Functions  box-insert) but inserting via
the menu allows me to choose which style of box.

Patrick

On 8/5/2014 3:35 PM, Scott Kostyshak wrote:
 n Tue, Aug 5, 2014 at 5:43 PM, Patrick O'Keeffe pokee...@wsu.edu wrote:
 Thought it might be easier to ask via mailing list than by filing new
 issue...

 Pressing 'Alt+I' to access the Insert menu, then 'x' inserts a new TeX
 code box. Since this has a top-level shortcut (Ctrl+L) I'd like to see
 'x' mapped to 'InsertBox' submenu instead. [If this can be customized,
 I haven't discovered how yet.]

 What does the community think? Is this no-go from the start or up for
 discussion? Maybe a change to wait until the next major release?
 There is a ticket with the same issue here: 
 http://www.lyx.org/trac/ticket/9227

 Scott

Alt key shortcut change

[Patrick O'Keeffe]

Thought it might be easier to ask via mailing list than by filing new
issue...

Pressing 'Alt+I' to access the Insert menu, then 'x' inserts a new TeX
code box. Since this has a top-level shortcut (Ctrl+L) I'd like to see
'x' mapped to 'Insert>Box' submenu instead. [If this can be customized,
I haven't discovered how yet.]

What does the community think? Is this no-go from the start or up for
discussion? Maybe a change to wait until the next major release?

Patrick O'Keeffe

Re: Alt key shortcut change

[Scott Kostyshak]

n Tue, Aug 5, 2014 at 5:43 PM, Patrick O'Keeffe  wrote:
> Thought it might be easier to ask via mailing list than by filing new
> issue...
>
> Pressing 'Alt+I' to access the Insert menu, then 'x' inserts a new TeX
> code box. Since this has a top-level shortcut (Ctrl+L) I'd like to see
> 'x' mapped to 'Insert>Box' submenu instead. [If this can be customized,
> I haven't discovered how yet.]
>
> What does the community think? Is this no-go from the start or up for
> discussion? Maybe a change to wait until the next major release?

There is a ticket with the same issue here: http://www.lyx.org/trac/ticket/9227

Scott

Re: Alt key shortcut change

[Patrick O'Keeffe]

I'm not sure this is the same issue: #9227 is about the main menu
superceding non-modal dialogs. I was suggesting changing the binding
within the Insert menu so "Alt+I, x" opens the box submenu instead of
inserting a Tex code box (since Ctrl+L does that).

I found a way to bind the raw command to a particular shortcut (Prefs >
Editing > Shortcuts > Cursor...Functions > box-insert) but inserting via
the menu allows me to choose which style of box.

Patrick

On 8/5/2014 3:35 PM, Scott Kostyshak wrote:
> n Tue, Aug 5, 2014 at 5:43 PM, Patrick O'Keeffe  wrote:
>> Thought it might be easier to ask via mailing list than by filing new
>> issue...
>>
>> Pressing 'Alt+I' to access the Insert menu, then 'x' inserts a new TeX
>> code box. Since this has a top-level shortcut (Ctrl+L) I'd like to see
>> 'x' mapped to 'Insert>Box' submenu instead. [If this can be customized,
>> I haven't discovered how yet.]
>>
>> What does the community think? Is this no-go from the start or up for
>> discussion? Maybe a change to wait until the next major release?
> There is a ticket with the same issue here: 
> http://www.lyx.org/trac/ticket/9227
>
> Scott