Re: Bug: counter of recent documents in Preferences dialog
On Fri, Aug 25, 2023 at 01:36:41PM +0200, Pavel Sanda wrote: > > At this point I suggest reverting the change you made, unless someone else > > claims to have reproduced the bug. But it is just a suggestion. > > Ok, I can do that. Committed. P -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Bug: counter of recent documents in Preferences dialog
On Wed, Aug 23, 2023 at 11:06:01AM +0200, Dan wrote: > >> The problem > >> > >> Follow through > >> 1. Run Lyx (version, build and OS info in the text attatchment). > >> 2. Open the Preferences dialog (Tools > Preferences). 3. In the Look and > >> Feel section, choose User Interface. > >> 4. Set the number of recent documents to more than 9. > >> 5. The last digit of the two-digit number is barely visible (see > >> attatched image). > >> > > > > Should be fixed by 06198fbe1854. > > > > Could you actually reproduce the problem? I ask because I get the same > problem after your patch. Actually I could not, but the issue and the fix seemed obvious, so I thought that with some Qt sytle and Qt version things go wrong. > At this point I suggest reverting the change you made, unless someone else > claims to have reproduced the bug. But it is just a suggestion. Ok, I can do that. You could try whether setting lastfiles->minimumSize->Width fixes the problem if you encounter it again. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Bug: counter of recent documents in Preferences dialog
Am Mittwoch, dem 23.08.2023 um 11:06 +0200 schrieb Dan: > Could you actually reproduce the problem? I ask because I get the > same problem after your patch. > > Honestly, I am confused right now > 1. I tried both versions (prior to and after your patch) in Debian > 12.1 with MATE 1.26, and the problem did not appear. > 2. Although your patch > (https://www.lyx.org/trac/changeset?old_path=%2Flyxgit&old=06198fbe18 > 54c64cd62acdbd8bcaafdb2a3b3b9e&new_path=%2Flyxgit&new=06198fbe1854c64 > cd62acdbd8bcaafdb2a3b3b9e) does not fix the problem (in my Linuxmint > 21.2 with Cinnamon at least), it really SHOULD: actually just > setting the maximum property to 10 should suffice. > 3. The maximum limit set in the QT ui file is ignored: actual > maximum is always 50 (you can check by running the program and > incrementing one by one). Therefore, this problem should not appear > to begin with... > > For contrast see Tools > Preferences > Look & Feel > Document > Handling. > The spin box for the number of minutes > (https://www.lyx.org/trac/browser/lyxgit/src/frontends/qt/ui/PrefDocH > andlingUi.ui#L111): if you change the maximum from 300 to 100 or 9 > and compile, the spinbox shrinks! I can't reproduce the problem, and in the UI settings, there is nothing wrong I can see (the settings for last files and Snapshot minutes are identical). -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Bug: counter of recent documents in Preferences dialog
>> The problem >> >> Follow through >> 1. Run Lyx (version, build and OS info in the text attatchment). >> 2. Open the Preferences dialog (Tools > Preferences). 3. In the Look and >> Feel section, choose User Interface. >> 4. Set the number of recent documents to more than 9. >> 5. The last digit of the two-digit number is barely visible (see attatched >> image). >> > > Should be fixed by 06198fbe1854. > Could you actually reproduce the problem? I ask because I get the same problem after your patch. Honestly, I am confused right now 1. I tried both versions (prior to and after your patch) in Debian 12.1 with MATE 1.26, and the problem did not appear. 2. Although your patch (https://www.lyx.org/trac/changeset?old_path=%2Flyxgit&old=06198fbe1854c64cd62acdbd8bcaafdb2a3b3b9e&new_path=%2Flyxgit&new=06198fbe1854c64cd62acdbd8bcaafdb2a3b3b9e) does not fix the problem (in my Linuxmint 21.2 with Cinnamon at least), it really SHOULD: actually just setting the maximum property to 10 should suffice. 3. The maximum limit set in the QT ui file is ignored: actual maximum is always 50 (you can check by running the program and incrementing one by one). Therefore, this problem should not appear to begin with... For contrast see Tools > Preferences > Look & Feel > Document Handling. The spin box for the number of minutes (https://www.lyx.org/trac/browser/lyxgit/src/frontends/qt/ui/PrefDocHandlingUi.ui#L111): if you change the maximum from 300 to 100 or 9 and compile, the spinbox shrinks! So it seems spinboxes adjust their size to be able to accomodate their range limits, which actually makes sense, since it won't let you get past those limits. The structure of this UI element (container layout) is the very same as the recent documents spinbox, so I guess something is done in code to this particular preference to override the maximum limit given in the QT ui file. At this point I suggest reverting the change you made, unless someone else claims to have reproduced the bug. But it is just a suggestion. Sorry for the headache :(. Daniel. -- Enviat amb Tutanota. -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Bug: counter of recent documents in Preferences dialog
On Tue, Aug 22, 2023 at 09:48:07AM +0200, Dan wrote: > Hello, > > I think I have stumbled upon a bug in Lyx (development version) not yet > reported, or at least I did not manage to find it in the bug tracker. > > The problem > > Follow through > 1. Run Lyx (version, build and OS info in the text attatchment). > 2. Open the Preferences dialog (Tools > Preferences). 3. In the Look and > Feel section, choose User Interface. > 4. Set the number of recent documents to more than 9. > 5. The last digit of the two-digit number is barely visible (see attatched > image). Should be fixed by 06198fbe1854. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Bug: counter of recent documents in Preferences dialog
Hello, I think I have stumbled upon a bug in Lyx (development version) not yet reported, or at least I did not manage to find it in the bug tracker. The problem Follow through 1. Run Lyx (version, build and OS info in the text attatchment). 2. Open the Preferences dialog (Tools > Preferences). 3. In the Look and Feel section, choose User Interface. 4. Set the number of recent documents to more than 9. 5. The last digit of the two-digit number is barely visible (see attatched image). Expected behaviour -- The number of recent documents Lyx will remember should be completely visible for two-digit numbers as well. This (little) bug is so easy to spot that feels very unlikely I am the first one to notice, but I did not see any bug report on this. If it was already reported, please, excuse me. As Homer Simpson would say: "It's my first day". Daniel. -- Enviat amb Tutanota. --- Build info --- LyX 2.4.0~RC1.devel (not released yet) Git commit hash 576e9749 Configuration Host type: x86_64-pc-linux-gnu Special build flags: build=development warnings assertions stdlib-assertions callback-printing use-enchant Bundled libraries:nod C++ Compiler:g++ (11.4.0) C++ Compiler flags: -Wall -Wextra -fPIC -g -O -std=c++17 -Wno-deprecated-copy C++ Compiler user flags: Linker flags: -rdynamic Linker user flags: Qt Frontend: Qt version: 5.15.3 --- Version info --- Version 2.4.0~RC1.devel (not released yet) Built from git commit hash 576e9749 Qt Version (run-time): 5.15.3 on platform xcb Qt Version (compile-time): 5.15.3 OS Version (run-time): Linux Mint 21.2 Python detected: python3 -tt -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
