Citation dialog
Hi Edwin, hi John, I fully understand the complaints of the LyX users. The citation dialog of 1.3 is much more convenient than the one of 1.4! If there is any chance to revive the 1.3 solution, I would really like to see it back in 1.4.1 or 1.4.2. Michael
citation dialog
Title: citation dialog the attached adds a toolbutton that clears the search box (and restores the full citation list): http://leuven.ecodip.net/lyx/cit.png ok to commit? cit.patch Description: cit.patch
Citation dialog
I've been slowly adding functionality to this citation dialog, but now I want some input about the aesthetics of the thing. Attached is a screenshot of the dialog in action. The "Bibliography keys" browser contains all keys in the Bibliography database. The "Citation keys" browser contains those keys chosen for the current inset. * Selecting a key in one browser highlights it in the other (if present). * Selecting a key in either browser causes information associated with the key to be displayed in the "Info" browser. (Inelegantly at present.) * Highlighting a key in the Bibliography browser that is not yet present in the Citation browser will enable the "Add" button (left facing arrow), allowing this key to be added to the Citation dialog if so desired. * Highlighting a key in the Citation dialog will enable the "Delete", "Up" and "Down" buttons, allowing the key to be removed or reordered, if so desired. I've placed the buttons where I have because the "Add" key copies info from the Bibliography browser to the Citation browser, whilst the other three keys manipulate keys in the Citation browser only. Any comments/suggestions about the look of the thing? Perhaps the group of three buttons should be vertically arranged from the top left of the Citation browser or have different symbols? Angus bib.png
citation dialog
re-sizing it is not fun, not at all. but having a "long" style in the style button goes wrong too. and it doesn't seem to be running bibtex for some reason john -- "You lose it if you talk about it." - Ernest Hemingway
Citation dialog
Hi, what is the meaning of the "Upper Case" switch in the citation reference dialog? I was expecting that is keeps all capital letters specified in a bib entry as capital letters in the bibliography of the document but it doesn't. Could you please enlighten me? Thanks in advance, Michael
Re: citation dialog
Leuven, E. wrote: the attached adds a toolbutton that clears the search box (and restores the full citation list): http://leuven.ecodip.net/lyx/cit.png ok to commit? this is going in unless someone shouts...
Re: citation dialog
> "Edwin" == Edwin Leuven <[EMAIL PROTECTED]> writes: Edwin> Leuven, E. wrote: >> the attached adds a toolbutton that clears the search box (and >> restores the full citation list): >> >> http://leuven.ecodip.net/lyx/cit.png >> >> ok to commit? Edwin> this is going in unless someone shouts... Wouldn't it be as intuitive to remove the search string and press return? Or have find as you type. Looking at your screenshot, I would not have guessed by myself what clear does. JMarc
Re: citation dialog
Jean-Marc Lasgouttes wrote: Wouldn't it be as intuitive to remove the search string and press return? don't understand you here Or have find as you type. it is find as you type, that's why it is handy to have a quick way of clearing the find box... Looking at your screenshot, I would not have guessed by myself what clear does. Clear Find <- Clear ?
Re: citation dialog
Edwin Leuven wrote: > Jean-Marc Lasgouttes wrote: >> Wouldn't it be as intuitive to remove the search string and press >> return? > > don't understand you here > >> Or have find as you type. > > it is find as you type, that's why it is handy to have a quick way of > clearing the find box... Maybe 'filter' is more appropriate than 'find' (be aware that i'm a gui ignorant)? why not a small icon at the left of the search box as in konqueror f.ex.? A/ PS: there's a surprising (good) amount of activity on this list!
Re: citation dialog
> "Edwin" == Edwin Leuven <[EMAIL PROTECTED]> writes: Edwin> Jean-Marc Lasgouttes wrote: >> Wouldn't it be as intuitive to remove the search string and press >> return? Edwin> don't understand you here I guess I'll have to practice with the dialog before making more uninform comments. >> Or have find as you type. Edwin> it is find as you type, that's why it is handy to have a quick Edwin> way of clearing the find box... Would it be clearer to name it "No filter" or something? Or use an icon as Alfredo proposed. Anyway, I do not want to be annoying with that, just do what feels right to you. I am just trying to instill doubt in your mind and see what happens :) JMarc
Re: citation dialog
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: Alfredo> PS: there's a surprising (good) amount of activity on this Alfredo> list! Hello Alfredo, Do you feel like coming back to have fun with us? JMarc
Re: citation dialog
Am Donnerstag, 9. November 2006 16:09 schrieb Jean-Marc Lasgouttes: > > "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: > > Alfredo> PS: there's a surprising (good) amount of activity on this > Alfredo> list! > > Hello Alfredo, > > Do you feel like coming back to have fun with us? That would be great! Georg
Re: citation dialog
Georg Baum wrote: > Am Donnerstag, 9. November 2006 16:09 schrieb Jean-Marc Lasgouttes: >> > "Alfredo" == Alfredo Braunstein >> > <[EMAIL PROTECTED]> writes: >> >> Alfredo> PS: there's a surprising (good) amount of activity on this >> Alfredo> list! >> >> Hello Alfredo, >> >> Do you feel like coming back to have fun with us? > > That would be great! Hello Jean-Marc, hello Georg! Hehe I'd love to come back... I hope to find some time soon (more than the one needed to occasionally lurk on the list at least!) Btw, it seems that you guys are doing a wonderful job with 1.5! A/
Re: citation dialog
On Fri, Nov 10, 2006 at 10:15:56PM +0100, Alfredo Braunstein wrote: > Hehe I'd love to come back... I hope to find some time soon (more than the > one needed to occasionally lurk on the list at least!) > > Btw, it seems that you guys are doing a wonderful job with 1.5! Looks like you haven't even compiled 1.5.x so far... Andre'
Re: citation dialog
Andre Poenitz wrote: > On Fri, Nov 10, 2006 at 10:15:56PM +0100, Alfredo Braunstein wrote: >> Hehe I'd love to come back... I hope to find some time soon (more than >> the one needed to occasionally lurk on the list at least!) >> >> Btw, it seems that you guys are doing a wonderful job with 1.5! > > Looks like you haven't even compiled 1.5.x so far... Why? I did. A/
Re: citation dialog
Alfredo Braunstein wrote: > Andre Poenitz wrote: > >> On Fri, Nov 10, 2006 at 10:15:56PM +0100, Alfredo Braunstein wrote: >>> Hehe I'd love to come back... I hope to find some time soon (more than >>> the one needed to occasionally lurk on the list at least!) >>> >>> Btw, it seems that you guys are doing a wonderful job with 1.5! >> >> Looks like you haven't even compiled 1.5.x so far... > > Why? I did. > > A/ Btw, hello ;-) A/
Re: citation dialog
On Sun, Nov 12, 2006 at 12:58:10PM +0100, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > On Fri, Nov 10, 2006 at 10:15:56PM +0100, Alfredo Braunstein wrote: > >> Hehe I'd love to come back... I hope to find some time soon (more than > >> the one needed to occasionally lurk on the list at least!) > >> > >> Btw, it seems that you guys are doing a wonderful job with 1.5! > > > > Looks like you haven't even compiled 1.5.x so far... > > Why? I did. Because of the 'wonderful' job... 1.5.x is not exactly usable right now. Andre'
Re: citation dialog
Andre Poenitz wrote: > On Sun, Nov 12, 2006 at 12:58:10PM +0100, Alfredo Braunstein wrote: >> Andre Poenitz wrote: >> >> > On Fri, Nov 10, 2006 at 10:15:56PM +0100, Alfredo Braunstein wrote: >> >> Hehe I'd love to come back... I hope to find some time soon (more than >> >> the one needed to occasionally lurk on the list at least!) >> >> >> >> Btw, it seems that you guys are doing a wonderful job with 1.5! >> > >> > Looks like you haven't even compiled 1.5.x so far... >> >> Why? I did. > > Because of the 'wonderful' job... 1.5.x is not exactly usable right now. > > Andre' Maybe because I'm comparing with last time I used svn (was cvs a couple of years ago), just after some 'wonderful job' of yours? SCNR ;-) A/
qt4 citation dialog
the attached patch puts the citation dialog in a workable state for me
comments appreciated
ed.
Index: src/frontends/qt4/QCitation.C
===
--- src/frontends/qt4/QCitation.C (revision 14247)
+++ src/frontends/qt4/QCitation.C (working copy)
@@ -68,7 +68,8 @@
void QCitation::apply(int const choice, bool const full, bool const force,
QString before, QString after)
{
-// InsetCommandParams & params = params();
+ if (!isValid())
+ return;
vector const & styles =
ControlCitation::getCiteStyles();
@@ -77,25 +78,11 @@
biblio::CitationStyle(styles[choice], full, force)
.asLatexStr();
+ params().setCmdName(command);
params().setContents(fromqstr(selected_keys_.stringList().join(",")));
params().setSecOptions(fromqstr(before));
params().setOptions(fromqstr(after));
dispatchParams();
-
-/*
- if (dialog().controller().isBufferDependent()) {
- if (!dialog().kernel().isBufferAvailable() ||
- dialog().kernel().isBufferReadonly())
- return;
- }
- dialog().controller().dispatchParams();
-
- if (dialog().controller().disconnectOnApply()) {
- dialog().kernel().disconnect(name());
- dialog().controller().initialiseParams(string());
- dialog().view().update();
- }
-*/
}
@@ -142,85 +129,43 @@
}
-QModelIndex QCitation::findKey(QString const & str) const
+void QCitation::findKey(QString const & str)
{
- cout << "Find text " << fromqstr(str) << endl;
-
- QStringList const avail = available_keys_.stringList();
- QRegExp reg_exp(str);
-
- int const pos = avail.indexOf(reg_exp);
- if (pos == -1)
- return QModelIndex();
-
- cout << "found key " << fromqstr(avail[pos]) << " at pos " << pos <<
endl;
- return available_keys_.index(pos);
+ QStringList sl = available_keys_.stringList().filter(str,
Qt::CaseInsensitive);
+ found_keys_.setStringList(sl);
}
-void QCitation::addKeys(QModelIndexList const & indexes)
+void QCitation::addKey(QModelIndex const & index)
{
- QModelIndex index;
-
- if (indexes.empty())
- return;
-
QStringList keys = selected_keys_.stringList();
-
- foreach(index, indexes) {
- if (keys.indexOf(index.data().toString()) == -1)
- keys.append(index.data().toString());
- }
-
+ keys.append(index.data().toString());
selected_keys_.setStringList(keys);
}
-void QCitation::deleteKeys(QModelIndexList const & indexes)
+void QCitation::deleteKey(QModelIndex const & index)
{
- QModelIndex index;
-
- if (indexes.empty())
- return;
-
QStringList keys = selected_keys_.stringList();
-
- foreach(index, indexes) {
- int const pos = keys.indexOf(index.data().toString());
- if (pos != -1)
- keys.removeAt(pos);
- }
-
+ keys.removeAt(index.row());
selected_keys_.setStringList(keys);
}
-void QCitation::upKey(QModelIndexList const & indexes)
+void QCitation::upKey(QModelIndex const & index)
{
- if (indexes.empty() || indexes.size() > 1)
- return;
-
- int pos = indexes[0].row();
- if (pos < 1)
- return;
-
QStringList keys = selected_keys_.stringList();
- keys.swap(pos, pos-1);
+ int pos = index.row();
+ keys.swap(pos, pos - 1);
selected_keys_.setStringList(keys);
}
-void QCitation::downKey(QModelIndexList const & indexes)
+void QCitation::downKey(QModelIndex const & index)
{
- if (indexes.empty() || indexes.size() > 1)
- return;
-
- int pos = indexes[0].row();
- if (pos >= selected_keys_.rowCount() - 1)
- return;
-
QStringList keys = selected_keys_.stringList();
- keys.swap(pos, pos+1);
+ int pos = index.row();
+ keys.swap(pos, pos + 1);
selected_keys_.setStringList(keys);
}
@@ -228,9 +173,18 @@
QStringList QCitation::citationStyles(int sel)
{
string key = fromqstr(selected_keys_.stringList()[sel]);
-
return toQStringList(getCiteStrings(key));
}
+
+QString QCitation::getKeyInfo(QString const & sel)
+{
+ if (!bibkeysInfo().empty())
+ return toqstr(biblio::getInfo(bibkeysInfo(), fromqstr(sel) ));
+
+ return QString();
+}
+
+
} // namespace frontend
} // namespace lyx
Index: src/frontends/qt4/QCitation.h
===
--- src/frontends/qt4/QCitation.h
New citation dialog
The attached file, patch.tar.bz2, contains a directory, patch, which contains four files angus.patch cite.fd insetcite.C insetcite.h angus.patch was created against current CVS with cvs diff -p -u > angus.patch (Sorry, JMarc, -N doesn't work!) cite.fd, the xforms dialog goes in forms/, insetcite.[Ch] go in src/insets/ This is a patch for a brand new citation dialog, together with new files insetcite.[Ch] to control it. Please try it out and tell me what you think. This patch is for a modified citation dialog only. Its sole additional functionality is to allow the user to input multiple citation keys in one inset easily. It makes no attempt to wrap the citation inset over multiple lines, nor does it support any new citation packages. What does it do? * Bibliography keys and citation keys for the current inset are visible in two separate browsers. * These browsers (and the dialog as a whole) resize automatically so that the number of visible keys lies in the range 4 <= noKeys <= 15. Ie, if there are 2 keys in the bibliography, then the dialog will be small. If there are 1, it will be big, but not soo big! * Users can add and remove keys from the list of the current inset, but they cannot add the same key twice. * If there are no keys in the bibliography, adding is disabled. * Clicking on a key in the current inset list highlights this key in the bibliography (if it exists). Quite enough for one day, I think! Have a good weekend, Angus Incidentally, I wasn't going crazy with my report of a bug in the old citation dialog. It didn't display the list of references because I was running lyx from the src/ directory and the .lyx file (together with the references) was elsewhere. LyX couldn't cope with this. I live and learn! A. patch.tar.bz2
Re: Citation dialog
Angus Leeming <[EMAIL PROTECTED]> writes: | The "Bibliography keys" browser contains all keys in the | Bibliography database. How would a small search field work for this? some kind of incremental search. | The "Citation keys" browser contains those keys chosen for the | current inset. | * Selecting a key in one browser highlights it in the other (if |present). Why not make the lists disjunct. | * Selecting a key in either browser causes information associated | with the key to | be displayed in the "Info" browser. (Inelegantly at present.) mmm. this can be done a bit nicer yes. Perhaps make it look somewhat similar to what it will look in the bibliography. | * Highlighting a key in the Citation dialog will enable the | "Delete", "Up" and | "Down" buttons, allowing the key to be removed or reordered, if so |desired. I think all the buttons below should be moved up between the lists, and change the delete button to a right pointing arrow button. | I've placed the buttons where I have because the "Add" key copies | info from the | Bibliography browser to the Citation browser, whilst the other three keys | manipulate keys in the Citation browser only. I makes the dialog so large. and since we will have visual feedback anyway I don't think the placement is that important. | Any comments/suggestions about the look of the thing? Perhaps the group of | three buttons should be vertically arranged from the top left of the Citation | browser or have different symbols? I have no clue what the X is supposed to mean? Delete? why not have two arrows between the lists. in/out. (you could remove the items on the left from the list on the right...) Currently the form also seems _way_ too big. I would also like you to have natbib in mind when doing this. I think that we will use natbib as the default bibliography package/style since we then will have all the power that we will care to support. Lgb
Re: Citation dialog
On Tue, May 30, 2000 at 10:18:03PM +0200, Lars Gullik Bj&resh;nnes wrote: > > How would a small search field work for this? > some kind of incremental search. > > | The "Citation keys" browser contains those keys chosen for the > | current inset. > > | * Selecting a key in one browser highlights it in the other (if > |present). > > Why not make the lists disjunct. Keeping two copies of a key in the two browsers helps if you want to replace(or add) an item by an item with a similar key (i.e., two papers with same authors).
Re: Citation dialog
Lars> | The "Bibliography keys" browser contains all keys in the Lars> | Bibliography database. Lars> How would a small search field work for this? Lars> some kind of incremental search. Don't understand what you mean. Sorry. Lars> | * Selecting a key in either browser causes information associated Lars> | with the key to Lars> | be displayed in the "Info" browser. (Inelegantly at present.) Lars> mmm. this can be done a bit nicer yes. Perhaps make it look somewhat Lars> similar to what it will look in the bibliography. I have plans for this. Lars> | * Highlighting a key in the Citation dialog will enable the Lars> | "Delete", "Up" and Lars> | "Down" buttons, allowing the key to be removed or reordered, if so Lars> |desired. Lars> I think all the buttons below should be moved up between the lists, Lars> and change the delete button to a right pointing arrow button. Ok. This is essentially what I had originally. Lars> I have no clue what the X is supposed to mean? Delete? why not have Lars> two arrows between the lists. in/out. (you could remove the items on Lars> the left from the list on the right...) I don't like this. My philosophy is that the bibliographic keys are fixed; only the citation keys should change. Lars> Currently the form also seems _way_ too big. Well, I think I've been pretty clever here! The dialog will resize automatically, depending on how many keys there are in the bibliography. If there are many keys, then the dialog is large, showing a maximum of 15 keys. If, however, there are few, then the browsers will be smaller, being big enough to display only 4 keys. Lars> I would also like you to have natbib in mind when doing this. I think Lars> that we will use natbib as the default bibliography Lars> package/style since we then will have all the power that we Lars> will care to support. This is simple to add to the dialog. The only additional objects to add to the citation dialog are a "Text before" input field and a drop down list of the citation style (\citep, \citet etc). Choosing the actual natbib style should be done in the layout dialog. Angus
Re: Citation dialog
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Lars> How would a small search field work for this? some kind of Lars> incremental search. Angus> Don't understand what you mean. Sorry. I guess Lars thinks of a text field where you can type the beginning of a word and see the browser update to the first entry beginning with these letters (in real time). A bit like incremental search (C-s) in emacs. JMarc
[BUG] citation dialog
Hi, I noticed this problem with lyx-1.1.6fix1, but didn't report it (bad, bad boy...). Now I notice it's still there in lyx-1.1.6fix2. When you open a citation dialog on an existing citation with a "Text after", and edit just the "Text after", you cannot press OK and you cannot press apply. To enable these buttons, you have to change the citation in some way - eg by adding a new one and deleting it. You should be able to press OK or apply after editing the "Text after". Ben.
the citation dialog
seems to have grown lately. perhaps someone can put it on a diet?
as an aside: do we need something like the attached since the selection manager
is created without a parent?
Index: src/frontends/qt4/GuiCitation.cpp
===
--- src/frontends/qt4/GuiCitation.cpp (revision 24552)
+++ src/frontends/qt4/GuiCitation.cpp (working copy)
@@ -116,6 +116,12 @@
}
+GuiCitation::~GuiCitation()
+{
+ delete selectionManager;
+}
+
+
void GuiCitation::cleanUp()
{
clearSelection();
Index: src/frontends/qt4/GuiCitation.h
===
--- src/frontends/qt4/GuiCitation.h (revision 24552)
+++ src/frontends/qt4/GuiCitation.h (working copy)
@@ -37,8 +37,9 @@
public:
///
GuiCitation(GuiView & lv);
-
///
+ ~GuiCitation();
+ ///
void applyView();
public Q_SLOTS:
Insert citation dialog
I regularily only cite a single source in one place, so the dialog need one click to much (select the item form the list, press the "<-" button to put it into the "active list" and press "Ok"). Would it be possible to use the item selected in the list when pressing "Ok"? Another thing: The scroll lists are far too short in some cases. Insert->Reference gives me labels in chunks of seven. Even if I sort them, I easily get a few "pages" worth of labels called "eq:something". Scrolling is far to slow. I'd suggest making the dialog a bit larger in both directions, move the Reference:/Format:/Name" to the right and use the full length of the left half for a scrolllist with maybe 15 or 18 entries. Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson)
Citation Dialog 1.2.0cvs
Hi, Have you ever tried the new (XForms) Citation Dialog on a 800x600 dpi screen? It's _way_ too large (if a database is chosen). Here's a screenshot: http://home.t-online.de/home/juergen.sp/citation.png I tried to rearrange the dialog by myself with the forms designer (src/frontends/xforms/forms/form_citation.fd), but I must admit that I have not the slightest clue what needs to be done. Anyway, I attached a diff from form_citation.fd, maybe it's totally nonsense, but maybe it's useful (well, since I never used cvs until today, please don't beat me). Oh, and please don't consider fixing it by removing all those beautiful new features again ;-) Thanks, Jürgen Index: form_citation.fd === RCS file: /cvs/lyx/lyx-devel/src/frontends/xforms/forms/form_citation.fd,v retrieving revision 1.17 diff -u -r1.17 form_citation.fd --- form_citation.fd2001/03/30 13:47:39 1.17 +++ form_citation.fd2001/07/09 15:50:31 @@ -9,13 +9,13 @@ === FORM === Name: form_citation Width: 430 -Height: 830 +Height: 550 Number of Objects: 21 class: FL_BOX type: UP_BOX -box: 0 0 430 830 +box: 0 0 430 550 boxtype: FL_UP_BOX colors: FL_COL1 FL_COL1 alignment: FL_ALIGN_CENTER @@ -33,7 +33,7 @@ class: FL_BROWSER type: HOLD_BROWSER -box: 10 30 180 300 +box: 10 30 180 170 boxtype: FL_DOWN_BOX colors: FL_COL1 FL_YELLOW alignment: FL_ALIGN_TOP_LEFT @@ -51,7 +51,7 @@ class: FL_BROWSER type: HOLD_BROWSER -box: 240 30 180 300 +box: 240 30 170 170 boxtype: FL_DOWN_BOX colors: FL_COL1 FL_YELLOW alignment: FL_ALIGN_TOP_LEFT @@ -69,7 +69,7 @@ class: FL_BUTTON type: NORMAL_BUTTON -box: 200 30 30 30 +box: 200 40 30 30 boxtype: FL_UP_BOX colors: FL_COL1 FL_COL1 alignment: FL_ALIGN_CENTER @@ -87,7 +87,7 @@ class: FL_BUTTON type: NORMAL_BUTTON -box: 200 65 30 30 +box: 200 80 30 30 boxtype: FL_UP_BOX colors: FL_COL1 FL_COL1 alignment: FL_ALIGN_CENTER @@ -105,7 +105,7 @@ class: FL_BUTTON type: NORMAL_BUTTON -box: 200 100 30 30 +box: 200 120 30 30 boxtype: FL_UP_BOX colors: FL_COL1 FL_COL1 alignment: FL_ALIGN_CENTER @@ -123,7 +123,7 @@ class: FL_BUTTON type: NORMAL_BUTTON -box: 200 135 30 30 +box: 200 160 30 30 boxtype: FL_UP_BOX colors: FL_COL1 FL_COL1 alignment: FL_ALIGN_CENTER @@ -141,7 +141,7 @@ class: FL_BROWSER type: NORMAL_BROWSER -box: 10 360 410 95 +box: 10 220 410 80 boxtype: FL_DOWN_BOX colors: FL_COL1 FL_YELLOW alignment: FL_ALIGN_TOP_LEFT @@ -159,7 +159,7 @@ class: FL_LABELFRAME type: ENGRAVED_FRAME -box: 10 475 410 125 +box: 10 310 410 110 boxtype: FL_NO_BOX colors: FL_BLACK FL_COL1 alignment: FL_ALIGN_TOP_LEFT @@ -177,7 +177,7 @@ class: FL_INPUT type: NORMAL_INPUT -box: 25 490 380 30 +box: 20 320 380 30 boxtype: FL_DOWN_BOX colors: FL_COL1 FL_MCOL alignment: FL_ALIGN_TOP @@ -195,7 +195,7 @@ class: FL_CHECKBUTTON type: PUSH_BUTTON -box: 25 525 30 30 +box: 30 360 30 30 boxtype: FL_NO_BOX colors: FL_COL1 FL_YELLOW alignment: FL_ALIGN_CENTER @@ -207,13 +207,13 @@ resize: FL_RESIZE_ALL gravity: FL_SouthWest FL_SouthWest name: button_search_type -callback: -argument: +callback: +argument: class: FL_CHECKBUTTON type: PUSH_BUTTON -box: 25 560 30 30 +box: 30 390 30 30 boxtype: FL_NO_BOX colors: FL_COL1 FL_YELLOW alignment: FL_ALIGN_CENTER @@ -231,7 +231,7 @@ class: FL_BUTTON type: NORMAL_BUTTON -box: 315 525 90 30 +box: 210 380 90 30 boxtype: FL_UP_BOX colors: FL_COL1 FL_COL1 alignment: FL_ALIGN_CENTER @@ -249,7 +249,7 @@ class: FL_BUTTON type: NORMAL_BUTTON -box: 315 560 90 30 +box: 310 380 90 30 boxtype: FL_UP_BOX colors: FL_COL1 FL_COL1 alignment: FL_ALIGN_CENTER @@ -267,7 +267,7 @@ class: FL_CHOICE type: NORMAL_CHOICE -box: 160 630 130 30 +box: 90 430 130 30 boxtype: FL_FRAME_BOX colors: FL_COL1 FL_BLACK alignment: FL_ALIGN_LEFT @@ -285,7 +285,7 @@ class: FL_INPUT type: NORMAL_INPUT -box: 100 680 250 30 +box: 90 470 130 30 boxtype: FL_DOWN_BOX colors: FL_COL1 FL_MCOL alignment: FL_ALIGN_LEFT @@ -303,7 +303,7 @@ class: FL_INPUT type: NORMAL_INPUT -box: 100 730 250 30 +box: 290 470 130 30 boxtype: FL_DOWN_BOX colors: FL_COL1 FL_MCOL alignment: FL_ALIGN_LEFT @@ -321,7 +321,7 @@ class: FL_BUTTON type: NORMAL_BUTTON -box: 10 790 90 30 +box: 10 510 90 30 boxtype: FL_UP_BOX colors: FL_COL1 FL_COL1 alignment: FL_ALIGN_CENTER @@ -339,7 +339,7 @@ class: FL_BUTTON type: RETURN_BUTTON -box: 130 790 90 30 +box: 120 510 90 30 boxtype: FL_UP_BOX colors: FL_COL1 FL_COL1 alignment: FL
Re: citation dialog
Am Mit, 01 Aug 2001 21:14:35 schrieb John Levon: > > re-sizing it is not fun, not at all. but having a "long" style > in the style button goes wrong too. I suppose, I'm to blame for this because I did the last resizising of the citation dialog (only made it a little bit narrower for 800x600 screens). Unfortunately I can't even have a look at the problem because my machine had a BIOS-crash and I only have an old laptop with limited space and no cvs for the next time :-(( Very sorry about that, Jürgen PS: If someone resizes this dialog again, *please* take care that it will not become bigger than 800x600 again, not everybody has a >17"-Screen. > john
Re: citation dialog
On Wednesday 01 August 2001 20:14, John Levon wrote: > re-sizing it is not fun, not at all. but having a "long" style > in the style button goes wrong too. Resizing: why not fix the size and be done with it. "long" style: ??? > and it doesn't seem to be running bibtex for some reason I've seen this too. Either the file in your InsetBibtex has a .bib extension and shouldn't or hasn't and should! Can't remember which. Perhaps you could sort that out? Angus
Re: citation dialog
On Thu, Aug 02, 2001 at 10:30:08AM +0100, Angus Leeming wrote: > On Wednesday 01 August 2001 20:14, John Levon wrote: > > re-sizing it is not fun, not at all. but having a "long" style > > in the style button goes wrong too. > > Resizing: why not fix the size and be done with it. I agree. Juergen, it's not your fault btw - xforms has never been able to resize things correctly. If this current dialog will fit in 800x600 then we can fix its size I suppose. > "long" style: ??? I mean the button that starts off "No database". The strings it gets set to writes outside of it - I can make the button larger. > I've seen this too. Either the file in your InsetBibtex has a .bib extension > and shouldn't or hasn't and should! Can't remember which. Perhaps you could > sort that out? hmm, I thought I'd tried both. maybe not. john -- "You lose it if you talk about it." - Ernest Hemingway
qt2 citation dialog
Just in case you haven't noticed ;-) In the Qt2-Citation dialog (which looks *very* nice), the checkboxes "Force Upper Case" and "Full Author List" are missing from the xforms version. Regards, Jürgen BTW: Very impressive speed of qt2-porting at the moment!
[PATCH] Citation Dialog
This dialog is still a real pain on a 800x600 Screen (it covers the whole screen, which strikes me sick). However, with a little rearrangement I managed to get it remarkably smaller. If you want to see the differences on my screen, have a look at the following screenshots: http://omnibus.uni-freiburg.de/~spitzmue/cit_before.png http://omnibus.uni-freiburg.de/~spitzmue/cit_after.png The patch additionally features some small tweaks to form_graphics.fd (sorry, I must have been tired yesterday). All in all safe to apply. Thanks, Jürgen. citation.diff.gz Description: GNU Zip compressed data
Re: Citation dialog
On Thursday 31 January 2002 1:24 pm, [EMAIL PROTECTED] wrote: > Hi, > > what is the meaning of the "Upper Case" switch in the citation reference > dialog? I was expecting that is keeps all capital letters specified in a > bib entry as capital letters in the bibliography of the document but it > doesn't. > > Could you please enlighten me? > > Thanks in advance, > > Michael If you have a reference A. del Piero, then the citation will appear as Del Piero rather than del Piero. Useful for the start of a sentence. Angus
Re: GTK Citation dialog
On Fri, 2006-01-20 at 14:45 +0100, Bernhard Reiter wrote: > And what exactly is happening to "Preamble"? It has been marked as > "pending" for several months and there is no code in CVS, though it > looks not too complicated... The preamble is pending because it's going to be part of the Document dialog, which is in progress. John
Re: GTK Citation dialog
Bernhard Reiter wrote: > New year, new dialogs! Comments highly requested. If nobody comments it is probably becuase of the 1.4.0 release, so don't hold your breath. > On a sidenote, what does "Listing" denote? I couldn't find any menu item > or file of that name. See here: http://bugzilla.lyx.org/show_bug.cgi?id=508. IMHO it should not be mentioned on the GUII page as long as the inset does not exist in the official sources. Georg
Re: GTK Citation dialog
On Fri, 2006-01-20 at 14:45 +0100, Bernhard Reiter wrote: > New year, new dialogs! Comments highly requested. You seem to have forgotten to send the .glade file! Judging from the screenshots I'll make a few tweaks to the widget spacing for you (being a GNOME HIG fascist), but apart from that looks good. I'll test and probably commit it once I have the glade. John
Re: GTK Citation dialog
Am Freitag, den 20.01.2006, 16:50 + schrieb John C. Spray:
> On Fri, 2006-01-20 at 14:45 +0100, Bernhard Reiter wrote:
> > New year, new dialogs! Comments highly requested.
>
> You seem to have forgotten to send the .glade file!
damnit. always the same. but as I've discovered a little issue with the
bc().valid() logic, I'm also re-attaching the .C file.
> Judging from the
> screenshots I'll make a few tweaks to the widget spacing for you (being
> a GNOME HIG fascist), but apart from that looks good.
Yeah, I remember having tried to read them once, but I didn't come much
further than the part about the naming guidelines for desktop icons and
applications menu entries. Maybe I should try again... Thanks in advance
for the tweaking which I'll highly welcome, anyway. I'll take a look at
the result so I can watch and learn...
Bernhard
> I'll test and
> probably commit it once I have the glade.
>
> John
>
/**
* \file GCitation.C
* This file is part of LyX, the document processor.
* Licence details can be found in the file COPYING.
*
* \author Bernhard Reiter
*
* Full author contact details are available in file CREDITS.
*/
#include
// Too hard to make concept checks work with this file
#ifdef _GLIBCXX_CONCEPT_CHECKS
#undef _GLIBCXX_CONCEPT_CHECKS
#endif
#ifdef _GLIBCPP_CONCEPT_CHECKS
#undef _GLIBCPP_CONCEPT_CHECKS
#endif
#include "GCitation.h"
#include "ControlCitation.h"
#include "ghelpers.h"
#include "bufferparams.h"
#include "support/lstrings.h"
#include
using std::string;
using std::vector;
namespace lyx {
namespace frontend {
class bibModelColumns : public Gtk::TreeModel::ColumnRecord
{
public:
bibModelColumns() { add(name); add(cite); add(bib_order); add(info); }
Gtk::TreeModelColumn name;
Gtk::TreeModelColumn cite;
Gtk::TreeModelColumn bib_order;
Gtk::TreeModelColumn info;
};
bibModelColumns bibColumns;
class styleModelColumns : public Gtk::TreeModel::ColumnRecord
{
public:
styleModelColumns() { add(name); }
Gtk::TreeModelColumn name;
};
bool GCitation::bib_visible(const Gtk::TreeModel::const_iterator& iter)
{
if (iter)
return !((*iter)[bibColumns.cite]);
return true;
}
styleModelColumns styleColumns;
GCitation::GCitation(Dialog & parent)
: GViewCB(parent, _("Citation"), false)
{}
void GCitation::doBuild()
{
string const gladeName = findGladeFile("citation");
xml_ = Gnome::Glade::Xml::create(gladeName);
xml_->get_widget("Restore", restorebutton_);
setRestore(restorebutton_);
xml_->get_widget("Cancel", cancelbutton_);
setCancel(cancelbutton_);
xml_->get_widget("Apply", applybutton_);
setApply(applybutton_);
xml_->get_widget("OK", okbutton_);
setOK(okbutton_);
xml_->get_widget("Remove", removebutton_);
xml_->get_widget("Add", addbutton_);
xml_->get_widget("Back", backbutton_);
xml_->get_widget("Forward", forwardbutton_);
xml_->get_widget("Up", upbutton_);
xml_->get_widget("Down", downbutton_);
xml_->get_widget("CiteKeys", citekeysview_);
xml_->get_widget("BibKeys", bibkeysview_);
xml_->get_widget("Info", infoview_);
xml_->get_widget("CaseSensitive", casecheck_);
xml_->get_widget("SearchCite", citeradio_);
xml_->get_widget("SearchBib", bibradio_);
xml_->get_widget("SearchString", findentry_);
xml_->get_widget("CaseSensitive", casecheck_);
xml_->get_widget("RegularExpression", regexpcheck_);
xml_->get_widget("StyleLabel", stylelabel_);
xml_->get_widget("Style", stylecombo_);
xml_->get_widget("TextBeforeLabel", beforelabel_);
xml_->get_widget("TextBefore", beforeentry_);
xml_->get_widget("TextAfter", afterentry_);
xml_->get_widget("FullAuthorList", authorcheck_);
xml_->get_widget("ForceUpperCase", uppercasecheck_);
info_ = Gtk::TextBuffer::create();
infoview_->set_buffer(info_);
allListStore_ = Gtk::ListStore::create(bibColumns);
Gtk::TreeModel::Path rootpath; //required for gtkmm < 2.6
citekeysview_->append_column(_("CiteKeys"), bibColumns.name);
citeFilter_ = Gtk::TreeModelFilter::create(allListStore_, rootpath);
citeFilter_->set_visible_column(bibColumns.cite);
citekeysview_->set_model(citeFilter_);
citeselection_ = citekeysview_->get_selection();
bibkeysview_->append_column(_("BibKeys"), bibColumns.name);
bibSort_ = Gtk::TreeModelSort::create(allListStore_);
bibSort_->set_sort_column(bibColumns.bib_order, Gtk::SORT_ASCENDING );
bibFilter_ = Gtk::TreeModelFilter::create(bibSort_, rootpath);
bibFilter_->set_visible_func(&GCitation::bib_visible);
bibkeysview_->set_model(bibFilter_);
bibselection_ = bibkeysview_->get_selection();
styleStore_ = Gtk::ListStore::create(styleColumns);
stylecombo_->set_model(styleStore_);
upbutton_->signal_clicked().connect(
sigc::mem_fun(*this, &GCitation::up));
downbutton_->signal_clicked().connect(
sigc::mem_fun(*this, &GCitation::down));
addbutton_->signal_clicked().connect(
sigc::mem_fun(*this, &GCitation::add));
removebutton_->signal_clicked().connect(
sigc::mem_fun(*this, &GCitation::remove));
backbutton_->signal_clicked().connect(
sigc::m
Re: GTK Citation dialog
Am Freitag, den 20.01.2006, 20:01 +0100 schrieb Bernhard Reiter: > > I'll test and > > probably commit it once I have the glade. I've committed this now. John
Re: qt4 citation dialog
Edwin Leuven wrote: the attached patch puts the citation dialog in a workable state for me comments appreciated Hi Edwin, I welcome your initiative :-) Could you give me a summary of what you did please? I understand that you are disabling multiple add/delete citations, aren't you? Does "find as you type" work now? Abdel.
Re: qt4 citation dialog
Abdelrazak Younes wrote: Could you give me a summary of what you did please? I understand that you are disabling multiple add/delete citations, aren't you? yes. i didn't see the big advantage, it simplifies the code, and it makes the behavior consistent with the up/down buttons that handle one entry at a time... other things that now work: - natbib style (the combox) - when moving/up down the item stays selected (allowing sequential ups/downs) - when deleting the next selected entry gets focus (allowing sequential deletes) - the info is now shown and updated - find subsets the available entries as you type am not so sure we need the advanced search dialog, i would suggest to get rid of it
Re: qt4 citation dialog
Edwin Leuven wrote: > yes. i didn't see the big advantage, it simplifies the code, and it > makes the behavior consistent with the up/down buttons that handle one > entry at a time... It was added as a compromise when the "add dialog" has been introduced. Its advantage then was that you didn't have to reopen that subdialog multiple times for multiple citations. IMHO you can rid of it now that the add dialog has gone again in qt4 (which is a good move IMO). Jürgen
Re: qt4 citation dialog
Edwin Leuven wrote: Abdelrazak Younes wrote: Could you give me a summary of what you did please? I understand that you are disabling multiple add/delete citations, aren't you? yes. i didn't see the big advantage, it simplifies the code, and it makes the behavior consistent with the up/down buttons that handle one entry at a time... Fine with me but how do you handle the multiple-selection case? other things that now work: - natbib style (the combox) Good. - when moving/up down the item stays selected (allowing sequential ups/downs) Good. - when deleting the next selected entry gets focus (allowing sequential deletes) Good. - the info is now shown and updated Good. - find subsets the available entries as you type Very Good! am not so sure we need the advanced search dialog, i would suggest to get rid of it I thought it might be useful for advanced Natbib and BibTex with Regexp etc. But I don't care much. So, do you like my design? Abdel.
Re: qt4 citation dialog
Abdelrazak Younes wrote: Fine with me but how do you handle the multiple-selection case? is this different from multiple add/delete? am not so sure we need the advanced search dialog, i would suggest to get rid of it I thought it might be useful for advanced Natbib and BibTex with Regexp etc. But I don't care much. others? So, do you like my design? i think i understand it better than the previous one ;-) i have a question: QCitation inherits from ControlCitation which means that it needs to be reset if the dialog is shown in another buffer atm this is not the case any ideas on how to handle this? thanks, edwin
Re: qt4 citation dialog
Juergen Spitzmueller wrote: It was added as a compromise when the "add dialog" has been introduced. Its advantage then was that you didn't have to reopen that subdialog multiple times for multiple citations. IMHO you can rid of it now that the add dialog has gone again in qt4 (which is a good move IMO). i am all for it...
Re: qt4 citation dialog
Edwin Leuven wrote:
Abdelrazak Younes wrote:
Fine with me but how do you handle the multiple-selection case?
is this different from multiple add/delete?
I mean, do you disable multiple-selection in the widget list? If not
there would be a problem if you click on add or delete when two items
are selected.
i have a question:
QCitation inherits from ControlCitation
which means that it needs to be reset if the dialog is shown in another
buffer
atm this is not the case
any ideas on how to handle this?
I guess you need to overload "ControlCitation::initialiseParams()":
bool QCitation::initialiseParams(std::string const & data)
{
// do QCitation models initialisation...
return ControlCitation::initialiseParams(data);
}
thanks, edwin
Re: qt4 citation dialog
Abdelrazak Younes wrote: I mean, do you disable multiple-selection in the widget list? If not there would be a problem if you click on add or delete when two items are selected. only 1 item can be selected at a time.. I guess you need to overload "ControlCitation::initialiseParams()": will give it a try, thanks
Re: qt4 citation dialog
Edwin Leuven wrote: > the attached patch puts the citation dialog in a workable state for me > > comments appreciated > > ed. 1) Would it be possible to add a 'jurabib face' to the dialog with a subset of the natbib version : a) the text after field that should be renamed 'pagination' b) a check box for the \nopage option 2) For usability, it would be nice if when you try to insert a citation when you have not chosen a bibtex file to get a dialog box with an explanation "You have not inserted a bibliography in your document" Cheers, Charles -- http://www.kde-france.org
Re: qt4 citation dialog
Charles de Miramon wrote: 2) For usability, it would be nice if when you try to insert a citation when you have not chosen a bibtex file to get a dialog box with an explanation "You have not inserted a bibliography in your document" I would even suggest a button that will call the "insert bibtex file" dialog. Maybe this button should be visible only if the proper document preference is set. Abdel.
Re: qt4 citation dialog
Abdelrazak Younes wrote: >> 2) For usability, it would be nice if when you try to insert a citation >> when you have not chosen a bibtex file to get a dialog box with an >> explanation "You have not inserted a bibliography in your document" > > I would even suggest a button that will call the "insert bibtex file" > dialog. Maybe this button should be visible only if the proper document > preference is set. But only if the user does not use the Bibliography environment. Jürgen
Re: qt4 citation dialog
On Tuesday 27 June 2006 17:41, Juergen Spitzmueller wrote: > But only if the user does not use the Bibliography environment. ... and we should walk through all include files to guarantee this. > Jürgen -- José Abílio
Re: qt4 citation dialog
updated patch attached. i would suggest to put this in (unless i have
overseen something important). things can always be taken further from
there...
- natbib style (the combox) works
- when moving/up down the item stays selected (allowing sequential
ups/downs)
- when deleting the next selected entry gets focus (allowing sequential
deletes)
- the info is now shown and updated
- find subsets the available entries as you type
- no additional find dialog (removed QCitationFind.ui)
- selecting with double-click
- removal of unused: Citation class, toVector() function
Index: src/frontends/qt4/Makefile.dialogs
===
--- src/frontends/qt4/Makefile.dialogs (revision 14247)
+++ src/frontends/qt4/Makefile.dialogs (working copy)
@@ -23,7 +23,6 @@
QChangesUi.ui \
QCharacterUi.ui \
QCitationUi.ui \
- QCitationFindUi.ui \
QDelimiterUi.ui \
QDocumentUi.ui \
QErrorListUi.ui \
Index: src/frontends/qt4/QCitation.C
===
--- src/frontends/qt4/QCitation.C (revision 14247)
+++ src/frontends/qt4/QCitation.C (working copy)
@@ -25,9 +25,6 @@
#include
#include
-#include
-using std::cout;
-using std::endl;
using std::vector;
using std::string;
@@ -46,15 +43,6 @@
}
-void toVector(vector & v, const QStringList & qlist)
-{
- v.clear();
-
- for (size_t i=0; i != qlist.size(); ++i)
- v.push_back(fromqstr(qlist[i]));
-}
-
-
namespace lyx {
namespace frontend {
@@ -68,7 +56,8 @@
void QCitation::apply(int const choice, bool const full, bool const force,
QString before, QString after)
{
-// InsetCommandParams & params = params();
+ if (!isValid())
+ return;
vector const & styles =
ControlCitation::getCiteStyles();
@@ -77,25 +66,11 @@
biblio::CitationStyle(styles[choice], full, force)
.asLatexStr();
+ params().setCmdName(command);
params().setContents(fromqstr(selected_keys_.stringList().join(",")));
params().setSecOptions(fromqstr(before));
params().setOptions(fromqstr(after));
dispatchParams();
-
-/*
- if (dialog().controller().isBufferDependent()) {
- if (!dialog().kernel().isBufferAvailable() ||
- dialog().kernel().isBufferReadonly())
- return;
- }
- dialog().controller().dispatchParams();
-
- if (dialog().controller().disconnectOnApply()) {
- dialog().kernel().disconnect(name());
- dialog().controller().initialiseParams(string());
- dialog().view().update();
- }
-*/
}
@@ -132,95 +107,43 @@
}
-QModelIndex QCitation::findKey(QString const & str, QModelIndex const & index)
const
+void QCitation::findKey(QString const & str)
{
- QStringList const avail = available_keys_.stringList();
- int const pos = avail.indexOf(str, index.row());
- if (pos == -1)
- return index;
- return available_keys_.index(pos);
+ QStringList sl = available_keys_.stringList().filter(str,
Qt::CaseInsensitive);
+ found_keys_.setStringList(sl);
}
-QModelIndex QCitation::findKey(QString const & str) const
+void QCitation::addKey(QModelIndex const & index)
{
- cout << "Find text " << fromqstr(str) << endl;
-
- QStringList const avail = available_keys_.stringList();
- QRegExp reg_exp(str);
-
- int const pos = avail.indexOf(reg_exp);
- if (pos == -1)
- return QModelIndex();
-
- cout << "found key " << fromqstr(avail[pos]) << " at pos " << pos <<
endl;
- return available_keys_.index(pos);
-}
-
-
-void QCitation::addKeys(QModelIndexList const & indexes)
-{
- QModelIndex index;
-
- if (indexes.empty())
- return;
-
QStringList keys = selected_keys_.stringList();
-
- foreach(index, indexes) {
- if (keys.indexOf(index.data().toString()) == -1)
- keys.append(index.data().toString());
- }
-
+ keys.append(index.data().toString());
selected_keys_.setStringList(keys);
}
-void QCitation::deleteKeys(QModelIndexList const & indexes)
+void QCitation::deleteKey(QModelIndex const & index)
{
- QModelIndex index;
-
- if (indexes.empty())
- return;
-
QStringList keys = selected_keys_.stringList();
-
- foreach(index, indexes) {
- int const pos = keys.indexOf(index.data().toString());
- if (pos != -1)
- keys.removeAt(pos);
- }
-
+ keys.removeAt(index.row());
selected_keys_.setStringList(keys);
}
-void QCitation::upKey(QModelIndexList const & indexes)
+void QCitation::upKey(QModelIndex const & index)
{
- if (indexes.e
Re: qt4 citation dialog
Edwin Leuven wrote: updated patch attached. i would suggest to put this in (unless i have overseen something important). things can always be taken further from there... Yep, go ahead. I see that you didn't need the initializeParam() overload after all. Does buffer switch work as expected now? Abdel.
Re: qt4 citation dialog
Abdelrazak Younes wrote: Yep, go ahead. done I see that you didn't need the initializeParam() overload after all. Does buffer switch work as expected now? it didn't and doesn't work next on the todo list...
Re: New citation dialog
On Fri, May 12, 2000 at 04:12:06PM +0100, Angus Leeming wrote: > The attached file, patch.tar.bz2, contains a directory, patch, which contains > four files > angus.patch cite.fd insetcite.C insetcite.h The file angus.patch is empty. Please submit a nonempty file.
Re: New citation dialog
Many thanks, Dekel, for working so hard at this and my apologies for the
confusion caused by my original submission with the empty file!
I like very much your inclusion of the info browser. Smashing idea.
I've made some tiny changes to get the thing to compile with DEC cxx (std::
stuff).
I've moved the info browser underneath the other two, and immediately above the
"Text After" box. If the bibliography database is empty, then this info is not
drawn at all and the dialog is resized accordingly.
As I see it, this info browser needs a little work only, to improve the parsing
of the bibliography data base. Ie, insetbib::getKeys() needs modifying. At the
moment a database containing:
@article{Butler:Tsuda97,
author = {J.P. Butler and A. Tsuda},
title = {Effect of convective stretching and folding on aerosol
mixing deep in the lung, assessed by approximate
entropy},
journal = JAP,
year = 1997,
volume = 83,
pages = {800-809}
}
@phdthesis{deFoy98,
author = {B. de Foy},
...
will produce a info browser containing:
author = {J.P. Butler and A. Tsuda},
title = {Effect of convective stretching and folding on aerosol
mixing deep in the lung, assessed by approximate
entropy},
journal = JAP,
year = 1997,
volume = 83,
pages = {800-809}
}
_
_
where _ indicates redundant extra lines. Note also the } at the end.
I'd suggest modifying the parser to strip off this rubbish from the tail. I
don't think we need make it intelligent and recognise the different fields, but
we might also get it to replace any strings with the expanded version. In this
case:
@String{JAP = {J. Appl. Physiol.}}
If you are busy implementing some of this, fine. If not, I'll have a go. Let's
not both do it though (so just drop me a line...)
Any other suggestions?
Angus
Re: New citation dialog
On Mon, May 15, 2000 at 04:33:31PM +0100, Angus Leeming wrote: > > I've moved the info browser underneath the other two, and immediately above the > "Text After" box. If the bibliography database is empty, then this info is not > drawn at all and the dialog is resized accordingly. I think that this makes the browser too tall (it will not fit in low resolution displays). > As I see it, this info browser needs a little work only, to improve the parsing > of the bibliography data base. Ie, insetbib::getKeys() needs modifying. At the > moment a database containing: > > I'd suggest modifying the parser to strip off this rubbish from the tail. I > don't think we need make it intelligent and recognise the different fields, but > we might also get it to replace any strings with the expanded version. In this > case: I'm not sure that @string expansion is a feature that worth the effort of coding it (I listed more important features (IMHO) below). Since InsetBibtex::getKeys() operates on the entire bibliography database, which can be quite large, it might be better to do there as little work as possible, and do the parsing in InsetCitation::Edit(). For example, instead of returning vector from insetbib::getKeys(), where the first element in a pair is a key, and the second is the concatenation of the lines in the entry strings, return vector>, where the second element of the pair is a vector of the lines. > If you are busy implementing some of this, fine. If not, I'll have a go. Let's > not both do it though (so just drop me a line...) No, I'm not working on this currently. > > Any other suggestions? - Below the browser line, add a text input form, and a button labeled search. When pressing the button, a key that its bibliography entry contains that string is searched for, and if such a key is found it will be selected in the bibliography keys browser (if there is already a selected key in this browser, the search will start from the next key). Use exsisting code for doing the search (e.g. contains() in support/lstrings.C) - Add a toggle button named "sort" below the bibliography keys browser, that allows you to watch the keys in sorted order/original order. - Move up/down buttons for reordering the keys in the inset-keys browser. - Discard "static vector bibkeys;" . This requires deleting the InsetCitation::Update() method, and also adding a functor for using with std::find.
Re: New citation dialog
Dekel Tsur wrote: > > No, I'm not working on this currently. How about edible labels? They are pretty essential for hollywood and broadway, and got lost when the menu TOC and REF went out. The baby went out with the bath water. Garst
Re: New citation dialog
On Mon, May 15, 2000 at 04:53:51PM -0300, Garst R. Reese wrote:
> Dekel Tsur wrote:
> >
> > No, I'm not working on this currently.
> How about edible labels? They are pretty essential for hollywood and
edible labels?
Yum.
Can I get ketchup with that?
--
Jules Bean |Any sufficiently advanced
jules@{debian.org,jellybean.co.uk} | technology is indistinguishable
[EMAIL PROTECTED] | from a perl script
Re: New citation dialog
Jules Bean wrote: > > On Mon, May 15, 2000 at 04:53:51PM -0300, Garst R. Reese wrote: > > Dekel Tsur wrote: > > > > > > No, I'm not working on this currently. > > How about edible labels? They are pretty essential for hollywood and > > edible labels? > > Yum. > > Can I get ketchup with that? Its poetic licentiousnous, only served with French wine, Norwegian beer or Aqua Vit. Garst
Re: New citation dialog
On 15-May-2000 Garst R. Reese wrote: > Dekel Tsur wrote: >> >> No, I'm not working on this currently. > How about edible labels? They are pretty essential for hollywood and > broadway, and got lost when the menu TOC and REF went out. The baby went > out with the bath water. This would be already in if we could have a single patch for this it's just that is was a bit mixed up with other stuff where we want also Lars opinion and he will return today :) Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-450296 ITALY Web:http://www.sad.it/~jug If our behavior is strict, we do not need fun! -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: New citation dialog
Dekel> I'm not sure that @string expansion is a feature that worth the effort
Dekel> of coding it (I listed more important features (IMHO) below).
Perhaps not for now. I have some ideas for adding entries to the BibTeX
database, in which case the parser will need to be a little more clever.
Dekel> Since InsetBibtex::getKeys() operates on the entire bibliography
Dekel> database, which can be quite large, it might be better to do there as
Dekel> little work as possible, and do the parsing in InsetCitation::Edit().
Indeed. At the moment, the database gets parsed every time a new citation dialog
is opened. Clearly this is stupid. I think something better would be to have a
class containing the database. Let's call it Biblio.
Biblio would contain a list of database files, getting this information from
the InsetBibtex dialog and a vector of database entries from these files.
The buffer would contain some data Biblio bib which could be used in
InsetCitation::Edit() something like:
if( current_view->buffer().bib.modified() ) {
current_view->buffer().bib.update();
bibkeys_info = current_view->buffer().bib.get();
bibkeys.clear();
for (unsigned int i = 0; i < bibkeys_info.size(); ++i)
bibkeys.push_back(bibkeys_info[i].first);
Update (citation_form->bibBrsr, citation_form->addBtn, bibkeys);
}
Biblio::modified() would check each file of the database to see whether they
had been changed since the last Biblio::update() or initialisation.
Biblio::update() would update that part of the database associated with a
particular (recently modified) file.
In addition to Biblio::get(), the class could (eventually) have a method
Biblio::set() that popped up some new dialog and allowed new entries to be
input into the database.
If people like the general idea, then I'll put some effort into thinking about
the specifics.
Dekel> For example, instead of returning vector from
Dekel> insetbib::getKeys(), where the first element in a pair is a key, and
Dekel> the second is the concatenation of the lines in the entry strings,
Dekel> return vector>, where the second element of the
Dekel> pair is a vector of the lines.
I think that the second entry should actually be a vector>
itself. That is, insetbib::getKeys() returns
vector>>>
I know this is a mouthful, but each database entry would then contain a key
(the first string) together with a vector> of BibTeX
fields. Things like "author", "Jo Bloggs and Uncle Sam".
Alternatively, using my concept of a Biblio class, this could be split up into
manageable get() functions. Perhaps Biblio::getKeys() returning just the keys
as a vector and Biblio::getKeyFields( int no ) returning the BiBTeX
fields to a particular key as a vector>.
Dekel> Below the browser line, add a text input form, and a button labeled
Dekel> search. When pressing the button, a key that its bibliography entry
Dekel> contains that string is searched for, and if such a key is found it will
Dekel> be selected in the bibliography keys browser (if there is already a
Dekel> selected key in this browser, the search will start from the next key).
OK. So the Citation dialog would call a function in the Biblio class that could
search its database.
Dekel> Add a toggle button named "sort" below the bibliography keys browser,
Dekel> that allows you to watch the keys in sorted order/original order.
Don't understand the value of this. Perhaps getKeys() should always return a
sorted vector. However, it would again be easy to do as you desire if we had a
Biblio storage class.
Dekel> Move up/down buttons for reordering the keys in the inset-keys browser.
No. This is LaTeX functionality. If you want sorted keys, then use the cite
package (or natbib, eventually).
Dekel> Discard "static vector bibkeys;" . This requires deleting the
Dekel> InsetCitation::Update() method, and also adding a functor for using with
Dekel> std::find.
Again, I don't see the value of this. Do you mean chuck out the bibliography
browser?
Finally, an additional word in favor of a database class Biblio. It would be
independant of the particular GUI and could be accessed by all three of today's
InsetCitation, InsetBibKey and InsetBibtex. I recognise that more thought is
needed here, but the more I think about it, the more I like my suggestion!
Someone bring me back down to Earth!
Angus
Re: New citation dialog
Juergen Vigna <[EMAIL PROTECTED]> writes: | This would be already in if we could have a single patch for this it's | just that is was a bit mixed up with other stuff where we want also Lars | opinion and he will return today :) What should I look at? Lgb
Re: New citation dialog
Lars> What should I look at? Lars, things have moved on since these patches were submitted. Only a little, but on, nevertheless. I've just remade things against todays CVS. Shall I resubmit? I'd like something in the tree sooner rather than later, because this thing could evolve quite rapidly and I'd like to have as much feedback as possible from interested users. At present the patch is quite small and the only real change in functionality is the ability to input multiple citations in one citation inset. The citation dialog is much improved and Dekel has introduced STL containers. I think that is enough for a first patch. Do you want the latest and greatest, and if so, should I send it to the list or to [EMAIL PROTECTED]? Angus
Re: New citation dialog
On Thu, May 18, 2000 at 12:17:44PM +0200, Lars Gullik Bj&resh;nnes wrote: > Juergen Vigna <[EMAIL PROTECTED]> writes: > > | This would be already in if we could have a single patch for this it's > | just that is was a bit mixed up with other stuff where we want also Lars > | opinion and he will return today :) > > What should I look at? At the attached patch. patch.gz
Re: New citation dialog
"Lars Gullik Bjønnes" wrote: > > Juergen Vigna <[EMAIL PROTECTED]> writes: > > | This would be already in if we could have a single patch for this it's > | just that is was a bit mixed up with other stuff where we want also Lars > | opinion and he will return today :) > > What should I look at? > > Lgb What I did here was to copy cvs 17 May, apply Dekel's patch with -b -V simple, copy lib/menus.bind.orig src/menus.C.orig src/menus.h.orig back to revert those patches. ChangeLog needs fixing. I tested with a file containing a TOC, list of figures, list of tables, lots of references, and a bib. Also with a long play and broadway, where labels are used in speaker. Garst
Re: New citation dialog
"Lars Gullik Bjønnes" wrote: > > Juergen Vigna <[EMAIL PROTECTED]> writes: > > | This would be already in if we could have a single patch for this it's > | just that is was a bit mixed up with other stuff where we want also Lars > | opinion and he will return today :) > > What should I look at? > > Lgb Oops, sorry, I thought this was referring to Dekel's patch for editable labels. Garst
Re: New citation dialog
Dekel Tsur <[EMAIL PROTECTED]> writes: | > What should I look at? | | At the attached patch. Ok, looking. Hmm, this patch does a bit more different things than I like to see... What is this? int const BIG_NUM = 1048576; looks _very_ hackish. Also you only implement parts of what varioref provides, same for pretty ref. Otoh support for varioref and prettyref are long overdue, but we should work to support them completely, also xr.sty should be worked into the same ref support. I have no real objections to the patch, so I think I will just include it. Lgb
Re: New citation dialog
On Wed, May 17, 2000 at 09:38:17AM +0100, Angus Leeming wrote: > > I think that the second entry should actually be a vector> > itself. That is, insetbib::getKeys() returns > vector>>> > I know this is a mouthful, but each database entry would then contain a key > (the first string) together with a vector> of BibTeX > fields. Things like "author", "Jo Bloggs and Uncle Sam". > > Alternatively, using my concept of a Biblio class, this could be split up into > manageable get() functions. Perhaps Biblio::getKeys() returning just the keys > as a vector and Biblio::getKeyFields( int no ) returning the BiBTeX > fields to a particular key as a vector>. The second alternative seems better. > Dekel> Add a toggle button named "sort" below the bibliography keys browser, > Dekel> that allows you to watch the keys in sorted order/original order. > > Don't understand the value of this. Perhaps getKeys() should always return a > sorted vector. However, it would again be easy to do as you desire if we had a > Biblio storage class. If the keys are not sorted in your bibliography file, then you might want to see them in the original order in some cases, and sorted in other cases. However, it is not very important feature. > Dekel> Move up/down buttons for reordering the keys in the inset-keys browser. > > No. This is LaTeX functionality. If you want sorted keys, then use the cite > package (or natbib, eventually). I do know that there are such packages. However, there may be cases when a manual sorting is needed (e.g. sorting according to importance). Again, this is not an important feature. > Dekel> Discard "static vector bibkeys;" . This requires deleting the > Dekel> InsetCitation::Update() method, and also adding a functor for using with > Dekel> std::find. > > Again, I don't see the value of this. Do you mean chuck out the bibliography > browser? In InsetCitation::Edit(), we get a vector from getBibkeyList() (and store it in the variable bibkeys_info), and then we generate a vector (variable bibkeys) containing only the keys in bibkeys_info. The conversion of the vector to a vector can be eliminated (note that if you change getBibkeyList() to return vector as you suggested this will fix the problem).
Re: New citation dialog
On 18-May-2000 Lars Gullik Bjønnes wrote: > > Also you only implement parts of what varioref provides, same for > pretty ref. > Otoh support for varioref and prettyref are long overdue, but we > should work to support them completely, also xr.sty should be worked > into the same ref support. > We always started with some support the rest can come in time :) > I have no real objections to the patch, so I think I will just include > it. Well I don't know if I missed it but I didn't see changes for LatexConfig, as we use new packages here this should also be reflected in the latex configuration and also in the package list with help to find it if it isn't available on the system, this should go in before we release final 1.1.5 if we include this patch! Greets Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-450296 ITALY Web:http://www.sad.it/~jug All phone calls are obscene. -- Karen Elizabeth Gordon -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: New citation dialog
Juergen Vigna <[EMAIL PROTECTED]> writes: | On 18-May-2000 Lars Gullik Bjønnes wrote: | > | > Also you only implement parts of what varioref provides, same for | > pretty ref. | > Otoh support for varioref and prettyref are long overdue, but we | > should work to support them completely, also xr.sty should be worked | > into the same ref support. | > | | We always started with some support the rest can come in time :) But should not be forgotten as we have a tendency to do... | > I have no real objections to the patch, so I think I will just include | > it. | | Well I don't know if I missed it but I didn't see changes for LatexConfig, | as we use new packages here this should also be reflected in the latex | configuration and also in the package list with help to find it if it | isn't available on the system, this should go in before we release final | 1.1.5 if we include this patch! Sure. I think I will get a patch RSN now... (hint, hint) Lgb
Re: New citation dialog
> >| > I have no real objections to the patch, so I think I will just include >| > it. >| >| Well I don't know if I missed it but I didn't see changes for LatexConfig, >| as we use new packages here this should also be reflected in the latex >| configuration and also in the package list with help to find it if it >| isn't available on the system, this should go in before we release final >| 1.1.5 if we include this patch! > > Sure. I think I will get a patch RSN now... (hint, hint) > BTW: Did you try to Preview the UserGuide? Please try, it gives 1 error! Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-450296 ITALY Web:http://www.sad.it/~jug You will reach the highest possible point in your business or profession. -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: New citation dialog
On 19-May-2000 Juergen Vigna wrote: > > BTW: Did you try to Preview the UserGuide? Please try, it gives 1 error! > And one more: I just read the whole UserGuide substituting LyXTable's with InsetTabular's and ..., it worked :)! -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-450296 ITALY Web:http://www.sad.it/~jug Life is like a tin of sardines. We're, all of us, looking for the key. -- Beyond the Fringe -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: New citation dialog
On 19-May-2000 Juergen Vigna wrote: > > On 19-May-2000 Juergen Vigna wrote: >> >> BTW: Did you try to Preview the UserGuide? Please try, it gives 1 error! >> > > And one more: I just read the whole UserGuide substituting LyXTable's with > InsetTabular's and ..., it worked :)! And while we are on it: Did you try to change the depth of a paragraph in a document like the UserGuide? It takes up 100% of cpu and takes quite a while, I guess this is the code of the vertical depth lines, if yes I really would like to be able to deactivate them as one cannot work in a large document with such large updates on a single action! Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-450296 ITALY Web:http://www.sad.it/~jug /earth is 98% full ... please delete anyone you can. -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: New citation dialog
On Fri, May 19, 2000 at 12:02:30PM +0200, Juergen Vigna wrote: > > > And one more: I just read the whole UserGuide substituting LyXTable's with > InsetTabular's and ..., it worked :)! You got so excited with this, that you haven't noticed that you enabled it on the CVS! (line 232 in buffer.C)
Re: New citation dialog
On 19-May-2000 Dekel Tsur wrote: > On Fri, May 19, 2000 at 12:02:30PM +0200, Juergen Vigna wrote: >> >> >> And one more: I just read the whole UserGuide substituting LyXTable's with >> InsetTabular's and ..., it worked :)! > > You got so excited with this, that you haven't noticed that you enabled it > on the CVS! (line 232 in buffer.C) #$%&*&* you're right I'll commit a fix immediately!!! Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-450296 ITALY Web:http://www.sad.it/~jug Philosophy will clip an angel's wings. -- John Keats -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: New citation dialog
> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: Juergen> And while we are on it: Did you try to change the depth of a Juergen> paragraph in a document like the UserGuide? It takes up 100% Juergen> of cpu and takes quite a while, I guess this is the code of Juergen> the vertical depth lines, if yes I really would like to be Juergen> able to deactivate them as one cannot work in a large Juergen> document with such large updates on a single action! If I see correctly, there is an error on the console when reading the file: fantomas: src/lyx LyX: \end_deeper: depth is already null [around line 7992 of file ~/src/lyx/lyxdoc/UserGuide.lyx] LyX: \end_deeper: depth is already null [around line 9054 of file ~/src/lyx/lyxdoc/UserGuide.lyx] Somehow, the reading of depth has been broken. Then, half of the document has depth 1, and of course, this is not a good test case for Dekel's code (even loading the UserGuide is horribly painful). First thing is to understand why there is a pb with UserGuide. JMarc
Re: New citation dialog
On Fri, May 19, 2000 at 05:10:22PM +0200, Jean-Marc Lasgouttes wrote: > > If I see correctly, there is an error on the console when reading the > file: > > fantomas: src/lyx > LyX: \end_deeper: depth is already null [around line 7992 of file >~/src/lyx/lyxdoc/UserGuide.lyx] > LyX: \end_deeper: depth is already null [around line 9054 of file >~/src/lyx/lyxdoc/UserGuide.lyx] > > Somehow, the reading of depth has been broken. Then, half of the > document has depth 1, and of course, this is not a good test case for > Dekel's code (even loading the UserGuide is horribly painful). First > thing is to understand why there is a pb with UserGuide. This is caused by a bug in InsetTabular (for a short period of time, the CVS code used InsetTabular instead of LyXTable when reading a file. Do a cvs update to fix this).
Re: New citation dialog
> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: Juergen> Well I don't know if I missed it but I didn't see changes for Juergen> LatexConfig, as we use new packages here this should also be Juergen> reflected in the latex configuration and also in the package Juergen> list with help to find it if it isn't available on the Juergen> system, this should go in before we release final 1.1.5 if we Juergen> include this patch! I agree of course. Dekel, would you have a short blurb about those packages? JMarc
Re: New citation dialog
--- Below this line is a copy of the message. Return-Path: <[EMAIL PROTECTED]> Received: (qmail 13165 invoked from network); 22 May 2000 08:35:31 - Received: from wsjug.sad.it (192.106.213.144) by wierdlmpc.msci.memphis.edu with SMTP; 22 May 2000 08:35:31 - Received: (from jug@localhost) by wsjug.sad.it (8.9.3/8.9.3) id KAA07545; Mon, 22 May 2000 10:34:34 +0200 Message-ID: <[EMAIL PROTECTED]> X-Mailer: XFMail 1.4.4 on Linux X-Priority: 3 (Normal) Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <[EMAIL PROTECTED]> Date: Mon, 22 May 2000 10:34:34 +0200 (CEST) Reply-To: Juergen Vigna <[EMAIL PROTECTED]> From: Juergen Vigna <[EMAIL PROTECTED]> To: Dekel Tsur <[EMAIL PROTECTED]> Subject: Re: New citation dialog Cc: LyX devel <[EMAIL PROTECTED]> On 19-May-2000 Dekel Tsur wrote: >> Somehow, the reading of depth has been broken. Then, half of the >> document has depth 1, and of course, this is not a good test case for >> Dekel's code (even loading the UserGuide is horribly painful). First >> thing is to understand why there is a pb with UserGuide. > > This is caused by a bug in InsetTabular (for a short period of time, the CVS > code used InsetTabular instead of LyXTable when reading a file. Do a cvs > update to fix this). You're right that this is caused by a wrong LyXTable read and you're also right that it isn't only your code which makes LyX so slow, but most probably the InsetTabular code. I'll have a look! Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-450296 ITALY Web:http://www.sad.it/~jug The goal of science is to build better mousetraps. The goal of nature is to build better mice. -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
The citation dialog & button?
Hi, What about adding an button in the Citation dialog? The Citation dialog can only be popped up once. For example, when I click on an existing citation inset, I get the list of that citation; when I then click on another citation inset, the citation dialog will change its contents. That way I was checking my citations (since for long citation lists, not all citations are visible). Occassionally I had to change a citation inset, but I only can make the change effective by *closing* the dialog. That interrupted unnecessarily my inset-hopping. Adding an button to the Citation dialog would help out here. I think the button would also extend the Citation dialogs functionality. Regards, Rob.
Bug in citation dialog
If I open the citation dialog, adds a new key to the inset keys list, and then press on one of the existing inset keys (or on the newly inserted key), then the OK button becomes disabled, even though the inset keys list has changed.
Problem with Citation dialog
Hello, in the citation dialog there is a problem with the OK button: 1. Select a citation 2. Select another citation 3. Remove one of the two citations 4. Click on the other citation --> the OK button is disabled Michael -- == Michael Schmittphone: +49 451 500 3725 Institute for Telematics secretary: +49 451 500 3721 Medical University of Luebeck fax: +49 451 500 3722 Ratzeburger Allee 160 eMail: [EMAIL PROTECTED] D-23538 Luebeck, Germany WWW: http://www.itm.mu-luebeck.de ==
Re: [BUG] citation dialog
On Wednesday 23 May 2001 07:03, Ben Stanley wrote: > Hi, > > I noticed this problem with lyx-1.1.6fix1, but didn't report it (bad, > bad boy...). Now I notice it's still there in lyx-1.1.6fix2. > > When you open a citation dialog on an existing citation with a "Text > after", and edit just the "Text after", you cannot press OK and you > cannot press apply. To enable these buttons, you have to change the > citation in some way - eg by adding a new one and deleting it. > > You should be able to press OK or apply after editing the "Text after". > > Ben. Sigh... I really, really should have done this before... Here's the patch fixing the problem (does not exist in HEAD). Jean-Marc, perhaps you'd like to commit it to the 1.1.6 branch, just in case there's ever a 1.1.6fix3? Angus patch.diff.gz
Re: [BUG] citation dialog
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Here's the patch fixing the problem (does not exist in HEAD). Angus> Jean-Marc, perhaps you'd like to commit it to the 1.1.6 branch, Angus> just in case there's ever a 1.1.6fix3? I'm currently doing that. This 1.1.6fix3 will probably only happen if we do a major fix, or if 1.2.0 is really late (which may happen, considering the neumber of things to sort out). JMarc
Re: [BUG] citation dialog
On Wednesday 23 May 2001 14:01, Jean-Marc Lasgouttes wrote: > > "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > > Angus> Here's the patch fixing the problem (does not exist in HEAD). > > A remark: now, when I have an empty document and open the popup, > OK/Apply are enabled. Is that intended? Interesting. No, it's not intended. The patch attached fixes that. I may have to port THIS particular patch to the HEAD too. H! Angus patch.diff.gz
Re: [BUG] citation dialog
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Interesting. No, it's not intended. The patch attached fixes Angus> that. I may have to port THIS particular patch to the HEAD too. Angus> H! Thanks. While we are at it, another wish: in the paragraph layout form, the align buttons should be disabled depending on the AlignPossible entry in the Layout. Could you do that? It would give a much better feedback to users. JMarc
Re: [BUG] citation dialog
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Interesting. No, it's not intended. The patch attached fixes Angus> that. I may have to port THIS particular patch to the HEAD too. Angus> H! Sorry but your previous patch has already been applied. Could you update it? (and you can also update your 1.1.6 cvs, you patch against the bare 1.1.6). JMarc
Re: [BUG] citation dialog
On Wednesday 23 May 2001 15:54, Jean-Marc Lasgouttes wrote: > > "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > > Angus> Interesting. No, it's not intended. The patch attached fixes > Angus> that. I may have to port THIS particular patch to the HEAD too. > Angus> H! > > Sorry but your previous patch has already been applied. Could you > update it? Here it is. > (and you can also update your 1.1.6 cvs, you patch against > the bare 1.1.6). So I've just discovered. I've now downloaded BRANCH_1_1_6. patch.diff.gz
Re: [BUG] citation dialog
On Wednesday 23 May 2001 15:52, Jean-Marc Lasgouttes wrote: > > "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > > Angus> Interesting. No, it's not intended. The patch attached fixes > Angus> that. I may have to port THIS particular patch to the HEAD too. > Angus> H! > > Thanks. While we are at it, another wish: in the paragraph layout > form, the align buttons should be disabled depending on the > AlignPossible entry in the Layout. Could you do that? It would give a > much better feedback to users. Is this HEAD or BRANCH_1_1_6? Angus
Re: [BUG] citation dialog
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Is this HEAD or BRANCH_1_1_6? Angus Head is obvously the most important, but &.1.6 would be nice too. JMarc, starring at the sea with his laptop on his lap, as it should...
Re: [BUG] citation dialog
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: >> Sorry but your previous patch has already been applied. Could you >> update it? Angus> Here it is. Thanks. Applied. JMarc
Re: [BUG] citation dialog
On Friday 25 May 2001 17:06, Jean-Marc Lasgouttes wrote: > Thanks. While we are at it, another wish: in the paragraph layout > form, the align buttons should be disabled depending on the > AlignPossible entry in the Layout. Could you do that? It would give a > much better feedback to users. > Angus> Is this HEAD or BRANCH_1_1_6? Angus > Head is obvously the most important, but &.1.6 would be nice too. > JMarc, starring at the sea with his laptop on his lap, as it should... ;-) Jean-Marc, does the attached patch do what you want? If so, can I leave this for you to apply to head and to 1.1.6? Cheers, Angus patch.diff.gz
Re: [BUG] citation dialog
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> does the attached patch do what you want? If so, can I leave Angus> this for you to apply to head and to 1.1.6? Close, but not perfect. If I am in a section (where Left and Block are allowed (for an unknown reason BTW)) and select 'left', then the center and right choices are available again. JMarc
BUGREPORT - lyx1.1.6fix2: citation dialog
If you try to add a bibtex reference, I think adding should work via double click on a bitex entry. but that's not the bug. The bug is comes up if you modify a bibtex citation, but don't add a new entry. E.g. if you change the page number in the "additional text", you can't close/okay the dialog. You can only Cancel it. Workaround: add and remove a bibtex entry, then it works. Keep going, I look forward to fix3 -- Moritz Moeller-Herrmann [EMAIL PROTECTED] ICQ# 3585990 Mosh: »Moritz ist ein weltbekannter Troll« PGP signature
Re: the citation dialog
Leuven, E. wrote: seems to have grown lately. perhaps someone can put it on a diet? It got a new line, because of the need to disable "Search as You Type", at least selectively. Then Jurgen re-organized it a bit. But of course you can re-organize it, too. ;-) as an aside: do we need something like the attached since the selection manager is created without a parent? If that doesn't cause a crash, we probably need it. But I'm no expert there. rh
Re: the citation dialog
rgheck wrote: Leuven, E. wrote: seems to have grown lately. perhaps someone can put it on a diet? It got a new line, because of the need to disable "Search as You Type", at least selectively. Then Jurgen re-organized it a bit. But of course you can re-organize it, too. ;-) wasn't referring to the new line, but rather that the listviews seem too big... as an aside: do we need something like the attached since the selection manager is created without a parent? If that doesn't cause a crash, we probably need it. But I'm no expert there. will put it in...
Re: the citation dialog
Leuven, E. wrote: seems to have grown lately. perhaps someone can put it on a diet? Here is some suggestion: - the preview dialog does not have to be so big by default. I know, there are some items with abstract etc, but a vertical scrollbar will be sufficient for those. - it would be nice if we could tile down with the mouse each of the 'Preview', 'Search' and 'Formatting' sections. The session info would remember the states of those subwindws. Don't know if this is easily achievable. as an aside: do we need something like the attached since the selection manager is created without a parent? Probably. Abdel.
Re: the citation dialog
On Tue, Apr 29, 2008 at 02:54:29PM +0200, Leuven, E. wrote: > seems to have grown lately. perhaps someone can put it on a diet? > > as an aside: do we need something like the attached since the > selection manager is created without a parent? Otherwise it would leak. But passing a QObject parent would be fine, too. Andre'
Re: the citation dialog
Edwin Leuven wrote: > wasn't referring to the new line, but rather that the listviews seem too > big... I forced the preview window to be smaller, which was a bit difficult (I needed some hardcoding). Feel free to jump in. Jürgen
