Re: Compile warnings with docbook
On Fri, 24 Sept 2021 at 10:07, Kornel Benko wrote: > Am Fri, 24 Sep 2021 09:34:36 +0200 > schrieb Thibaut Cuvelier : > > > On Fri, 24 Sept 2021 at 09:23, Kornel Benko wrote: > > > > > Am Fri, 24 Sep 2021 01:23:50 +0200 > > > schrieb Thibaut Cuvelier : > > > > > > > Hi Kornel, > > > > > > > > Thanks for pointing these out, they didn't show on my side. I could > quite > > > > easily fix the one about the unused argument in the constructor (it's > > > > already pushed: dca39815), but I don't know what to do for the > others. > > > > Maybe the attached patch solves the rest of the warnings? > > > > > > > > On Fri, 24 Sept 2021 at 00:55, Kornel Benko wrote: > > > > > > > > > > > > > > See attached. > > > > > > > > > > Kornel > > > > > -- > > > > > lyx-devel mailing list > > > > > lyx-devel@lists.lyx.org > > > > > http://lists.lyx.org/mailman/listinfo/lyx-devel > > > > > > > > > > > No, it does not help. Instead the number of similar warnings doubles. > > > > > > From: lyx::Floating::docbook_tag_type_’ will be initialized after > > > > > > to: lyx::Floating::docbook_tag_type_’ will be initialized after > > > lyx::Floating::docbook_float_type_’ will be initialized after > > > > > > But with the attached there are no warnings. > > > > > > > It shouldn't either with MSVC; do you want to push this patch? (I won't > be > > able to do it before tonight.) > > No problem, will do. > Thanks a lot for having a look at this :)! -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Compile warnings with docbook
Am Fri, 24 Sep 2021 09:34:36 +0200 schrieb Thibaut Cuvelier : > On Fri, 24 Sept 2021 at 09:23, Kornel Benko wrote: > > > Am Fri, 24 Sep 2021 01:23:50 +0200 > > schrieb Thibaut Cuvelier : > > > > > Hi Kornel, > > > > > > Thanks for pointing these out, they didn't show on my side. I could quite > > > easily fix the one about the unused argument in the constructor (it's > > > already pushed: dca39815), but I don't know what to do for the others. > > > Maybe the attached patch solves the rest of the warnings? > > > > > > On Fri, 24 Sept 2021 at 00:55, Kornel Benko wrote: > > > > > > > > > > > See attached. > > > > > > > > Kornel > > > > -- > > > > lyx-devel mailing list > > > > lyx-devel@lists.lyx.org > > > > http://lists.lyx.org/mailman/listinfo/lyx-devel > > > > > > > > No, it does not help. Instead the number of similar warnings doubles. > > > > From: lyx::Floating::docbook_tag_type_’ will be initialized after > > > > to: lyx::Floating::docbook_tag_type_’ will be initialized after > > lyx::Floating::docbook_float_type_’ will be initialized after > > > > But with the attached there are no warnings. > > > > It shouldn't either with MSVC; do you want to push this patch? (I won't be > able to do it before tonight.) No problem, will do. Kornel pgptbh71wIGjG.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Compile warnings with docbook
On Fri, 24 Sept 2021 at 09:23, Kornel Benko wrote: > Am Fri, 24 Sep 2021 01:23:50 +0200 > schrieb Thibaut Cuvelier : > > > Hi Kornel, > > > > Thanks for pointing these out, they didn't show on my side. I could quite > > easily fix the one about the unused argument in the constructor (it's > > already pushed: dca39815), but I don't know what to do for the others. > > Maybe the attached patch solves the rest of the warnings? > > > > On Fri, 24 Sept 2021 at 00:55, Kornel Benko wrote: > > > > > > > > See attached. > > > > > > Kornel > > > -- > > > lyx-devel mailing list > > > lyx-devel@lists.lyx.org > > > http://lists.lyx.org/mailman/listinfo/lyx-devel > > > > > No, it does not help. Instead the number of similar warnings doubles. > > From: lyx::Floating::docbook_tag_type_’ will be initialized after > > to: lyx::Floating::docbook_tag_type_’ will be initialized after > lyx::Floating::docbook_float_type_’ will be initialized after > > But with the attached there are no warnings. > It shouldn't either with MSVC; do you want to push this patch? (I won't be able to do it before tonight.) -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Compile warnings with docbook
Am Fri, 24 Sep 2021 01:23:50 +0200
schrieb Thibaut Cuvelier :
> Hi Kornel,
>
> Thanks for pointing these out, they didn't show on my side. I could quite
> easily fix the one about the unused argument in the constructor (it's
> already pushed: dca39815), but I don't know what to do for the others.
> Maybe the attached patch solves the rest of the warnings?
>
> On Fri, 24 Sept 2021 at 00:55, Kornel Benko wrote:
>
> >
> > See attached.
> >
> > Kornel
> > --
> > lyx-devel mailing list
> > lyx-devel@lists.lyx.org
> > http://lists.lyx.org/mailman/listinfo/lyx-devel
> >
No, it does not help. Instead the number of similar warnings doubles.
From: lyx::Floating::docbook_tag_type_’ will be initialized after
to: lyx::Floating::docbook_tag_type_’ will be initialized after
lyx::Floating::docbook_float_type_’ will be initialized after
But with the attached there are no warnings.
Kornel
diff --git a/src/Floating.cpp b/src/Floating.cpp
index d396e8a2c7..6a532aa7c9 100644
--- a/src/Floating.cpp
+++ b/src/Floating.cpp
@@ -40,12 +40,12 @@ Floating::Floating(string const & type, string const & placement,
style_(style), name_(name), listname_(listName), listcommand_(listCmd),
refprefix_(refPrefix), allowedplacement_(allowedplacement), required_(required),
usesfloatpkg_(usesfloat), ispredefined_(ispredefined),
allowswide_(allowswide), allowssideways_(allowssideways),
html_tag_(htmlTag), html_attrib_(htmlAttrib), html_style_(htmlStyle),
- docbook_tag_(docbookTag), docbook_tag_type_(docbookTagType),
- docbook_caption_(docbookCaption)
+ docbook_caption_(docbookCaption), docbook_tag_(docbookTag),
+ docbook_tag_type_(docbookTagType)
{
// Implement some edge cases for DocBook. Both docbook_float_type_ and docbook_attr_ must be computed
// based on the given value of docbookFloatType; docbook_tag_ can still be guessed without correlation.
// Determine the value of docbook_float_type_.
pgppuwwrxy622.pgp
Description: Digitale Signatur von OpenPGP
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Compile warnings with docbook
Hi Kornel, Thanks for pointing these out, they didn't show on my side. I could quite easily fix the one about the unused argument in the constructor (it's already pushed: dca39815), but I don't know what to do for the others. Maybe the attached patch solves the rest of the warnings? On Fri, 24 Sept 2021 at 00:55, Kornel Benko wrote: > > See attached. > > Kornel > -- > lyx-devel mailing list > lyx-devel@lists.lyx.org > http://lists.lyx.org/mailman/listinfo/lyx-devel > Fix_a_few_warnings_in_Floating_.patch Description: Binary data -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Compile warnings with docbook
See attached. Kornel Warnings Description: Binary data pgpvNNTRcQ84O.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
