Re: Find replace in 2.0

[Joost Verburg]

Jürgen Spitzmüller sp...@lyx.org wrote in message 
news:201102180855.11402.sp...@lyx.org...
-1. I think this simple and fast search method is still of much use 
besides

the big, blown advanced dialog.


Currently the dialogs are exactly the same except for the possibility to 
type non-plain text in the advanced one.
Perhaps it'd be good to make the Quick search a bit more simple then? 
Maybe just a search box?


Joost 

Re: Find replace in 2.0

[Jürgen Spitzmüller]

Joost Verburg wrote:
 Currently the dialogs are exactly the same except for the possibility to
 type non-plain text in the advanced one.

But the Advanced dialog takes up a lot of screen space. This is not always 
desirable.

 Perhaps it'd be good to make the Quick search a bit more simple then? 
 Maybe just a search box?

I like the idea to make it a Firefox-like bar (which could still also include 
replace, like in KDE's Kate editor). But I doubt this is LyX 2.0 stuff. 

Jürgen

Re: Find replace in 2.0

[Vincent van Ravesteijn]

 I like the idea to make it a Firefox-like bar (which could still also include
 replace, like in KDE's Kate editor). But I doubt this is LyX 2.0 stuff.

I have one and I will commit when 2.(0.)1 svn is open.

Unless people are urging to get it in 2.0.

Developing new features is just not very successful if you try to fix
a lot of bugs as well at the same time.

Vincent

Re: Find replace in 2.0

[Jürgen Spitzmüller]

Vincent van Ravesteijn wrote:
 Developing new features is just not very successful if you try to fix
 a lot of bugs as well at the same time.

bugfixing might be not as sexy, but you're the tacit hero, of course.

Jürgen

Re: Find replace in 2.0

[Pavel Sanda]

Vincent van Ravesteijn wrote:
  I like the idea to make it a Firefox-like bar (which could still also 
  include
  replace, like in KDE's Kate editor). But I doubt this is LyX 2.0 stuff.
 
 I have one and I will commit when 2.(0.)1 svn is open.
 
 Unless people are urging to get it in 2.0.

please not now. the urgency is to shrink 2.0 milestone bugs instead of
adding new ones...
pavel

Re: Find replace in 2.0

[Tommaso Cucinotta]

Il 18/02/2011 00:48, Pavel Sanda ha scritto:

Pavel Sanda wrote:

You're right, I was confused myself now by the UI. These texts on the tabs
(Basic and Advanced) don't make sense to me. Shouldn't that be renamed
to Search and Settings or something similar?

yes, looks more correct to me.

Tommaso, is this fine with you?

+1.

Just as a funny way to feed the discussion, let me highlight that you can
currently use the simple search to find text inside the Advanced Find's
search and replace WorkAreas :-).

I also fixed a few issues with the simple search, in trunk, so I'm of course
fine with keeping the original simple search at least for the first release
cycle in which the Advanced Find goes in.

Just as a reminder, the performance
problems in Advanced Find should come up only with long documents and
ignore-format option off (from the Advanced/Settings panel).
The potential problem of LyX apparently stuck while searching was addressed
by my patch to #7217, not committed yet because Vincent was preferring
a threaded implementation.
If other developers like me would prefer to have it in when LyX 2.0 is 
released

(leaving possible reworks in threaded mode for later) just let me know.

T.

Re: Find & replace in 2.0

[Joost Verburg]

"Jürgen Spitzmüller"  wrote in message 
news:201102180855.11402.sp...@lyx.org...
-1. I think this simple and fast search method is still of much use 
besides

the big, blown advanced dialog.


Currently the dialogs are exactly the same except for the possibility to 
type non-plain text in the advanced one.
Perhaps it'd be good to make the "Quick" search a bit more simple then? 
Maybe just a search box?


Joost 

Re: Find & replace in 2.0

[Jürgen Spitzmüller]

Joost Verburg wrote:
> Currently the dialogs are exactly the same except for the possibility to
> type non-plain text in the advanced one.

But the Advanced dialog takes up a lot of screen space. This is not always 
desirable.

> Perhaps it'd be good to make the "Quick" search a bit more simple then? 
> Maybe just a search box?

I like the idea to make it a Firefox-like bar (which could still also include 
replace, like in KDE's Kate editor). But I doubt this is LyX 2.0 stuff. 

Jürgen

Re: Find & replace in 2.0

[Vincent van Ravesteijn]

> I like the idea to make it a Firefox-like bar (which could still also include
> replace, like in KDE's Kate editor). But I doubt this is LyX 2.0 stuff.

I have one and I will commit when 2.(0.)1 svn is open.

Unless people are urging to get it in 2.0.

Developing new features is just not very successful if you try to fix
a lot of bugs as well at the same time.

Vincent

Re: Find & replace in 2.0

[Jürgen Spitzmüller]

Vincent van Ravesteijn wrote:
> Developing new features is just not very successful if you try to fix
> a lot of bugs as well at the same time.

bugfixing might be not as sexy, but you're the tacit hero, of course.

Jürgen

Re: Find & replace in 2.0

[Pavel Sanda]

Vincent van Ravesteijn wrote:
> > I like the idea to make it a Firefox-like bar (which could still also 
> > include
> > replace, like in KDE's Kate editor). But I doubt this is LyX 2.0 stuff.
> 
> I have one and I will commit when 2.(0.)1 svn is open.
> 
> Unless people are urging to get it in 2.0.

please not now. the urgency is to shrink 2.0 milestone bugs instead of
adding new ones...
pavel

Re: Find & replace in 2.0

[Tommaso Cucinotta]

Il 18/02/2011 00:48, Pavel Sanda ha scritto:

Pavel Sanda wrote:

You're right, I was confused myself now by the UI. These texts on the tabs
("Basic" and "Advanced") don't make sense to me. Shouldn't that be renamed
to "Search" and "Settings" or something similar?

yes, looks more correct to me.

Tommaso, is this fine with you?

+1.

Just as a funny way to feed the discussion, let me highlight that you can
currently use the simple search to find text inside the Advanced Find's
search and replace WorkAreas :-).

I also fixed a few issues with the simple search, in trunk, so I'm of course
fine with keeping the original simple search at least for the first release
cycle in which the Advanced Find goes in.

Just as a reminder, the performance
problems in Advanced Find should come up only with long documents and
ignore-format option off (from the Advanced/Settings panel).
The potential problem of LyX apparently stuck while searching was addressed
by my patch to #7217, not committed yet because Vincent was preferring
a threaded implementation.
If other developers like me would prefer to have it in when LyX 2.0 is 
released

(leaving possible reworks in threaded mode for later) just let me know.

T.

Find replace in 2.0

[Joost Verburg]

Hi,

I was just checking out some new 2.0 features and noticed we got three find 
 replace dialogs now:

* Find  replace - Quick
* Find  replace - Advanced - Basic
* Find  replace - Advanced - Advanced
This really seems like too much. Could we get rid of the old Quick dialog 
and rename Advanced Find and Replace to Find and Replace?


Regards,
Joost 

Re: Find replace in 2.0

[Pavel Sanda]

Joost Verburg wrote:
  replace dialogs now:
 * Find  replace - Quick
 * Find  replace - Advanced - Basic

which one is this one?

 * Find  replace - Advanced - Advanced

 Could we get rid of the old Quick dialog 

Vincent had plan to move it to firefox-style onliner, but it didn't happened.
unless you show me where is the third, i think these two are fine.
advanced speed is still not enough.

pavel

Re: Find replace in 2.0

[Joost Verburg]

Pavel Sanda sa...@lyx.org wrote in message 
news:20110217225227.gp26...@atrey.karlin.mff.cuni.cz...
Vincent had plan to move it to firefox-style onliner, but it didn't 
happened.

unless you show me where is the third, i think these two are fine.
advanced speed is still not enough.


The advanced mode has two windows - basic and advanced.
I didn't notice the performance issue of the advanced ones. UI wise it 
doesn't make sense to have both but I guess we have to wait for better 
performance then.


Joost 

Re: Find replace in 2.0

[Pavel Sanda]

Joost Verburg wrote:
 The advanced mode has two windows - basic and advanced.

i must miss something very basic. what two windows are you talking about? :)
i see one panel with two workareas and one tab for special settings.

 I didn't notice the performance issue of the advanced ones. UI wise it 
 doesn't make sense to have both but I guess we have to wait for better 
 performance then.

just tried some search and no, speed looks fine now. anyway we are still
in a debug mode for this new feature.

pavel

Re: Find replace in 2.0

[Joost Verburg]

Pavel Sanda sa...@lyx.org wrote in message 
news:20110217231834.gr26...@atrey.karlin.mff.cuni.cz...
i must miss something very basic. what two windows are you talking about? 
:)

i see one panel with two workareas and one tab for special settings.


You're right, I was confused myself now by the UI. These texts on the tabs 
(Basic and Advanced) don't make sense to me. Shouldn't that be renamed 
to Search and Settings or something similar?



just tried some search and no, speed looks fine now. anyway we are still
in a debug mode for this new feature.


I guess if it's stable enough to go in 2.0, it can also replace the old one?

Joost 

Re: Find replace in 2.0

[Pavel Sanda]

Joost Verburg wrote:
 Pavel Sanda sa...@lyx.org wrote in message 
 news:20110217231834.gr26...@atrey.karlin.mff.cuni.cz...
 i must miss something very basic. what two windows are you talking about? 
 :)
 i see one panel with two workareas and one tab for special settings.

 You're right, I was confused myself now by the UI. These texts on the tabs 
 (Basic and Advanced) don't make sense to me. Shouldn't that be renamed 
 to Search and Settings or something similar?

yes, looks more correct to me.

 just tried some search and no, speed looks fine now. anyway we are still
 in a debug mode for this new feature.

 I guess if it's stable enough to go in 2.0, it can also replace the old one?

its pretty clear from the patch activity around find adv code, that we havent
reach the stable point.

secondly, in my usage of lyx 2, i still prefer small dialog for only-text search
just because its size. thats why was talking about the replacement with small 
widget,
perhaps in 2.1. so no, i dont agree with killing it now.

pavel

Re: Find replace in 2.0

[Pavel Sanda]

Pavel Sanda wrote:
  You're right, I was confused myself now by the UI. These texts on the tabs 
  (Basic and Advanced) don't make sense to me. Shouldn't that be renamed 
  to Search and Settings or something similar?
 
 yes, looks more correct to me.

Tommaso, is this fine with you?
pavel
diff --git a/src/frontends/qt4/ui/FindAndReplaceUi.ui 
b/src/frontends/qt4/ui/FindAndReplaceUi.ui
index caa08e1..a57a17b 100644
--- a/src/frontends/qt4/ui/FindAndReplaceUi.ui
+++ b/src/frontends/qt4/ui/FindAndReplaceUi.ui
@@ -17,7 +17,7 @@
   /property
   widget class=QWidget name=basicTab 
attribute name=title 
-stringBasiamp;c/string
+stringSearamp;ch/string
/attribute
layout class=QGridLayout name=gridLayout 
 item row=0 column=0 
@@ -160,7 +160,7 @@
   /widget
   widget class=QWidget name=advancedTab 
attribute name=title 
-stringAdamp;vanced/string
+stringSamp;ettings/string
/attribute
layout class=QGridLayout name=gridLayout_2 
 item row=0 column=0 colspan=2 

Re: Find replace in 2.0

[Jürgen Spitzmüller]

Joost Verburg wrote:
 Could we get rid of the old Quick dialog 
 and rename Advanced Find and Replace to Find and Replace?

-1. I think this simple and fast search method is still of much use besides 
the big, blown advanced dialog.

Jürgen

Find & replace in 2.0

[Joost Verburg]

Hi,

I was just checking out some new 2.0 features and noticed we got three find 
& replace dialogs now:

* Find & replace - Quick
* Find & replace - Advanced - Basic
* Find & replace - Advanced - Advanced
This really seems like too much. Could we get rid of the old "Quick" dialog 
and rename "Advanced Find and Replace" to "Find and Replace"?


Regards,
Joost 

Re: Find & replace in 2.0

[Pavel Sanda]

Joost Verburg wrote:
> & replace dialogs now:
> * Find & replace - Quick
> * Find & replace - Advanced - Basic

which one is this one?

> * Find & replace - Advanced - Advanced

> Could we get rid of the old "Quick" dialog 

Vincent had plan to move it to firefox-style onliner, but it didn't happened.
unless you show me where is the third, i think these two are fine.
advanced speed is still not enough.

pavel

Re: Find & replace in 2.0

[Joost Verburg]

"Pavel Sanda"  wrote in message 
news:20110217225227.gp26...@atrey.karlin.mff.cuni.cz...
Vincent had plan to move it to firefox-style onliner, but it didn't 
happened.

unless you show me where is the third, i think these two are fine.
advanced speed is still not enough.


The advanced mode has two windows - basic and advanced.
I didn't notice the performance issue of the advanced ones. UI wise it 
doesn't make sense to have both but I guess we have to wait for better 
performance then.


Joost 

Re: Find & replace in 2.0

[Pavel Sanda]

Joost Verburg wrote:
> The advanced mode has two windows - basic and advanced.

i must miss something very basic. what two windows are you talking about? :)
i see one panel with two workareas and one tab for special settings.

> I didn't notice the performance issue of the advanced ones. UI wise it 
> doesn't make sense to have both but I guess we have to wait for better 
> performance then.

just tried some search and no, speed looks fine now. anyway we are still
in a debug mode for this new feature.

pavel

Re: Find & replace in 2.0

[Joost Verburg]

"Pavel Sanda"  wrote in message 
news:20110217231834.gr26...@atrey.karlin.mff.cuni.cz...
i must miss something very basic. what two windows are you talking about? 
:)

i see one panel with two workareas and one tab for special settings.


You're right, I was confused myself now by the UI. These texts on the tabs 
("Basic" and "Advanced") don't make sense to me. Shouldn't that be renamed 
to "Search" and "Settings" or something similar?



just tried some search and no, speed looks fine now. anyway we are still
in a debug mode for this new feature.


I guess if it's stable enough to go in 2.0, it can also replace the old one?

Joost 

Re: Find & replace in 2.0

[Pavel Sanda]

Joost Verburg wrote:
> "Pavel Sanda"  wrote in message 
> news:20110217231834.gr26...@atrey.karlin.mff.cuni.cz...
>> i must miss something very basic. what two windows are you talking about? 
>> :)
>> i see one panel with two workareas and one tab for special settings.
>
> You're right, I was confused myself now by the UI. These texts on the tabs 
> ("Basic" and "Advanced") don't make sense to me. Shouldn't that be renamed 
> to "Search" and "Settings" or something similar?

yes, looks more correct to me.

>> just tried some search and no, speed looks fine now. anyway we are still
>> in a debug mode for this new feature.
>
> I guess if it's stable enough to go in 2.0, it can also replace the old one?

its pretty clear from the patch activity around find adv code, that we havent
reach the stable point.

secondly, in my usage of lyx 2, i still prefer small dialog for only-text search
just because its size. thats why was talking about the replacement with small 
widget,
perhaps in 2.1. so no, i dont agree with killing it now.

pavel

Re: Find & replace in 2.0

[Pavel Sanda]

Pavel Sanda wrote:
> > You're right, I was confused myself now by the UI. These texts on the tabs 
> > ("Basic" and "Advanced") don't make sense to me. Shouldn't that be renamed 
> > to "Search" and "Settings" or something similar?
> 
> yes, looks more correct to me.

Tommaso, is this fine with you?
pavel
diff --git a/src/frontends/qt4/ui/FindAndReplaceUi.ui 
b/src/frontends/qt4/ui/FindAndReplaceUi.ui
index caa08e1..a57a17b 100644
--- a/src/frontends/qt4/ui/FindAndReplaceUi.ui
+++ b/src/frontends/qt4/ui/FindAndReplaceUi.ui
@@ -17,7 +17,7 @@
   
   

-Basic
+Search


 
@@ -160,7 +160,7 @@
   
   

-Advanced
+Settings


 

Re: Find & replace in 2.0

[Jürgen Spitzmüller]

Joost Verburg wrote:
> Could we get rid of the old "Quick" dialog 
> and rename "Advanced Find and Replace" to "Find and Replace"?

-1. I think this simple and fast search method is still of much use besides 
the big, blown advanced dialog.

Jürgen