Re: Hebrew/bidi bug 1975
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin A fresh patch for bug 1975, due to the boundary changes. Martin Bugzilla doesn't like me today, so attached. Martin Still no external testers found... please?!? Did this ever got applied? JMarc
Re: Hebrew/bidi bug 1975
On Mon, 2005-10-03 at 11:31 +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin A fresh patch for bug 1975, due to the boundary changes. Martin Bugzilla doesn't like me today, so attached. Martin Still no external testers found... please?!? Did this ever got applied? No... hanging in my tree. - Martin signature.asc Description: This is a digitally signed message part
Re: Hebrew/bidi bug 1975
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Did this ever got applied? Martin No... hanging in my tree. So, what has to be done? testing? How confident are you? JMarc
Re: Hebrew/bidi bug 1975
On Mon, 2005-10-03 at 12:08 +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Did this ever got applied? Martin No... hanging in my tree. So, what has to be done? testing? How confident are you? Pretty confident, as it appears that RtL is connected to language and completely decoupled from font. That makes it possible to test without having Hebrew fonts installed... still I would have appreciated a Hebrew tester. - Martin signature.asc Description: This is a digitally signed message part
Re: Hebrew/bidi bug 1975
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin On Mon, 2005-10-03 at 12:08 +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Did this ever got applied? Martin No... hanging in my tree. So, what has to be done? testing? How confident are you? Martin Pretty confident, as it appears that RtL is connected to Martin language and completely decoupled from font. That makes it Martin possible to test without having Hebrew fonts installed... Martin still I would have appreciated a Hebrew tester. Since it only affects RtL, I'd say that you should apply it. JMarc
Re: Hebrew/bidi bug 1975
On Mon, 2005-10-03 at 14:00 +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin On Mon, 2005-10-03 at 12:08 +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Did this ever got applied? Martin No... hanging in my tree. So, what has to be done? testing? How confident are you? Martin Pretty confident, as it appears that RtL is connected to Martin language and completely decoupled from font. That makes it Martin possible to test without having Hebrew fonts installed... Martin still I would have appreciated a Hebrew tester. Since it only affects RtL, I'd say that you should apply it. Done. Let's hope we get some testing ;-) - Martin signature.asc Description: This is a digitally signed message part
Re: Hebrew/bidi bug 1975
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> A fresh patch for bug 1975, due to the boundary changes. Martin> Bugzilla doesn't like me today, so attached. Martin> Still no external testers found... please?!? Did this ever got applied? JMarc
Re: Hebrew/bidi bug 1975
On Mon, 2005-10-03 at 11:31 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> A fresh patch for bug 1975, due to the boundary changes. > > Martin> Bugzilla doesn't like me today, so attached. > > Martin> Still no external testers found... please?!? > > Did this ever got applied? No... hanging in my tree. - Martin signature.asc Description: This is a digitally signed message part
Re: Hebrew/bidi bug 1975
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> Did this ever got applied? Martin> No... hanging in my tree. So, what has to be done? testing? How confident are you? JMarc
Re: Hebrew/bidi bug 1975
On Mon, 2005-10-03 at 12:08 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> Did this ever got applied? > > Martin> No... hanging in my tree. > > So, what has to be done? testing? How confident are you? Pretty confident, as it appears that RtL is connected to language and completely decoupled from font. That makes it possible to test without having Hebrew fonts installed... still I would have appreciated a Hebrew tester. - Martin signature.asc Description: This is a digitally signed message part
Re: Hebrew/bidi bug 1975
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> On Mon, 2005-10-03 at 12:08 +0200, Jean-Marc Lasgouttes wrote: >> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> >> >> Did this ever got applied? >> Martin> No... hanging in my tree. >> So, what has to be done? testing? How confident are you? Martin> Pretty confident, as it appears that RtL is connected to Martin> language and completely decoupled from font. That makes it Martin> possible to test without having Hebrew fonts installed... Martin> still I would have appreciated a Hebrew tester. Since it only affects RtL, I'd say that you should apply it. JMarc
Re: Hebrew/bidi bug 1975
On Mon, 2005-10-03 at 14:00 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> On Mon, 2005-10-03 at 12:08 +0200, Jean-Marc Lasgouttes wrote: > >> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > >> > >> >> Did this ever got applied? > >> > Martin> No... hanging in my tree. > >> So, what has to be done? testing? How confident are you? > > Martin> Pretty confident, as it appears that RtL is connected to > Martin> language and completely decoupled from font. That makes it > Martin> possible to test without having Hebrew fonts installed... > Martin> still I would have appreciated a Hebrew tester. > > Since it only affects RtL, I'd say that you should apply it. Done. Let's hope we get some testing ;-) - Martin signature.asc Description: This is a digitally signed message part
Re: Hebrew/bidi bug 1975
On Tue, 2005-08-16 at 09:05 +0200, Lars Gullik Bjønnes wrote:
Martin Vermeer [EMAIL PROTECTED] writes:
| On Mon, Aug 15, 2005 at 03:12:03PM +0200, Lars Gullik Bjønnes wrote:
My main reaons for being so unwilling is the changes to the .layout
format. It really looks like a cludge to me. (even the existing one)
--
Lgb
| OK, here is one more, the fix for 1975 (cursor positioning inside inset
| in RtL). This one handles inset-within-inset correctly. Straight UI
| regression fix.
Try to get someone else to test it as well, then ok.
A fresh patch for bug 1975, due to the boundary changes.
Bugzilla doesn't like me today, so attached.
Still no external testers found... please?!?
- Martin
Index: text.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/text.C,v
retrieving revision 1.627
diff -u -p -r1.627 text.C
--- text.C 10 Sep 2005 13:29:44 - 1.627
+++ text.C 16 Sep 2005 14:41:37 -
@@ -2124,12 +2124,21 @@ int LyXText::cursorX(CursorSlice const
}
// see correction above
- if (boundary_correction)
- if (getFont(par, ppos).isRightToLeft())
+ if (boundary_correction) {
+ if (getFont(par, ppos).isVisibleRightToLeft())
x -= singleWidth(par, ppos);
else
x += singleWidth(par, ppos);
+ }
+ // Make sure inside an inset we always count from the left
+ // edge (bidi!) -- MV
+ if (sl.pos() par.size()) {
+ font = getFont(par, sl.pos());
+ if (!boundary font.isVisibleRightToLeft()
+ par.isInset(sl.pos()))
+ x -= par.getInset(sl.pos())-width();
+ }
return int(x);
}
signature.asc
Description: This is a digitally signed message part
Re: Hebrew/bidi bug 1975
On Tue, 2005-08-16 at 09:05 +0200, Lars Gullik Bjønnes wrote:
> Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> | On Mon, Aug 15, 2005 at 03:12:03PM +0200, Lars Gullik Bjønnes wrote:
> >>
> >> My main reaons for being so unwilling is the changes to the .layout
> >> format. It really looks like a cludge to me. (even the existing one)
> >>
> >>
> >> --
> >>Lgb
> >
> | OK, here is one more, the fix for 1975 (cursor positioning inside inset
> | in RtL). This one handles inset-within-inset correctly. Straight UI
> | regression fix.
>
> Try to get someone else to test it as well, then ok.
A fresh patch for bug 1975, due to the boundary changes.
Bugzilla doesn't like me today, so attached.
Still no external testers found... please?!?
- Martin
Index: text.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/text.C,v
retrieving revision 1.627
diff -u -p -r1.627 text.C
--- text.C 10 Sep 2005 13:29:44 - 1.627
+++ text.C 16 Sep 2005 14:41:37 -
@@ -2124,12 +2124,21 @@ int LyXText::cursorX(CursorSlice const &
}
// see correction above
- if (boundary_correction)
- if (getFont(par, ppos).isRightToLeft())
+ if (boundary_correction) {
+ if (getFont(par, ppos).isVisibleRightToLeft())
x -= singleWidth(par, ppos);
else
x += singleWidth(par, ppos);
+ }
+ // Make sure inside an inset we always count from the left
+ // edge (bidi!) -- MV
+ if (sl.pos() < par.size()) {
+ font = getFont(par, sl.pos());
+ if (!boundary && font.isVisibleRightToLeft()
+ && par.isInset(sl.pos()))
+ x -= par.getInset(sl.pos())->width();
+ }
return int(x);
}
signature.asc
Description: This is a digitally signed message part
