Re: New win32 build
John == John Levon [EMAIL PROTECTED] writes: John On Thu, Jan 16, 2003 at 10:58:09PM +0100, Ruurd Reitsma wrote: All the patches are over there also. Is anyone still interested in adding some of it to CVS, or should I just stop asking? John Of course we are (though probably not right *now*). John It would help if you could send one mail with one patch that John makes one fix/change, and explain why it's necessary. And probably begin by the obvious ones, like changing class to struct (or was it the opposite?). JMarc
Re: New win32 build
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> On Thu, Jan 16, 2003 at 10:58:09PM +0100, Ruurd Reitsma wrote: >> All the patches are over there also. Is anyone still interested in >> adding some of it to CVS, or should I just stop asking? John> Of course we are (though probably not right *now*). John> It would help if you could send one mail with one patch that John> makes one fix/change, and explain why it's necessary. And probably begin by the obvious ones, like changing class to struct (or was it the opposite?). JMarc
New win32 build
Hi,
just made a fresh build for win32. This fixes the dialog crashes.
It's available at:
http://www.home.zonnet.nl/rareitsma/lyx/
All the patches are over there also. Is anyone still interested in adding
some of it to CVS, or should I just stop asking?
Cheers,
Ruurd
Btw, this was what caused it:
Index: frontends/qt2/qt_helpers.C
===
RCS file: /cvs/lyx/lyx-devel/src/frontends/qt2/qt_helpers.C,v
retrieving revision 1.4
diff -u -r1.4 qt_helpers.C
--- frontends/qt2/qt_helpers.C 2002/12/17 20:37:11 1.4
+++ frontends/qt2/qt_helpers.C 2003/01/16 21:49:30
@@ -117,6 +117,6 @@
{
QTextCodec * codec = QTextCodec::codecForLocale();
QCString tmpstr = codec-fromUnicode(str);
- char const * tmpcstr = tmpstr;
+ char const * tmpcstr = tmpstr ? tmpstr : ;
return tmpcstr;
}
Re: New win32 build
On Thu, Jan 16, 2003 at 10:58:09PM +0100, Ruurd Reitsma wrote:
All the patches are over there also. Is anyone still interested in adding
some of it to CVS, or should I just stop asking?
Of course we are (though probably not right *now*).
It would help if you could send one mail with one patch that makes one
fix/change, and explain why it's necessary.
@@ -117,6 +117,6 @@
{
QTextCodec * codec = QTextCodec::codecForLocale();
QCString tmpstr = codec-fromUnicode(str);
- char const * tmpcstr = tmpstr;
+ char const * tmpcstr = tmpstr ? tmpstr : ;
return tmpcstr;
}
Hmm. I would have expected it to return if we really have an empty
QString. What code triggers this ?
I have no objection to this change if it really is needed.
regards
john
--
We're standing there pounding a dead parrot on the counter, and the management
response is to frantically swap in new counters to see if that fixes the
problem.
- Peter Gutmann
New win32 build
Hi,
just made a fresh build for win32. This fixes the dialog crashes.
It's available at:
http://www.home.zonnet.nl/rareitsma/lyx/
All the patches are over there also. Is anyone still interested in adding
some of it to CVS, or should I just stop asking?
Cheers,
Ruurd
Btw, this was what caused it:
Index: frontends/qt2/qt_helpers.C
===
RCS file: /cvs/lyx/lyx-devel/src/frontends/qt2/qt_helpers.C,v
retrieving revision 1.4
diff -u -r1.4 qt_helpers.C
--- frontends/qt2/qt_helpers.C 2002/12/17 20:37:11 1.4
+++ frontends/qt2/qt_helpers.C 2003/01/16 21:49:30
@@ -117,6 +117,6 @@
{
QTextCodec * codec = QTextCodec::codecForLocale();
QCString tmpstr = codec->fromUnicode(str);
- char const * tmpcstr = tmpstr;
+ char const * tmpcstr = tmpstr ? tmpstr : "";
return tmpcstr;
}
Re: New win32 build
On Thu, Jan 16, 2003 at 10:58:09PM +0100, Ruurd Reitsma wrote:
> All the patches are over there also. Is anyone still interested in adding
> some of it to CVS, or should I just stop asking?
Of course we are (though probably not right *now*).
It would help if you could send one mail with one patch that makes one
fix/change, and explain why it's necessary.
> @@ -117,6 +117,6 @@
> {
> QTextCodec * codec = QTextCodec::codecForLocale();
> QCString tmpstr = codec->fromUnicode(str);
> - char const * tmpcstr = tmpstr;
> + char const * tmpcstr = tmpstr ? tmpstr : "";
> return tmpcstr;
> }
Hmm. I would have expected it to return "" if we really have an empty
QString. What code triggers this ?
I have no objection to this change if it really is needed.
regards
john
--
"We're standing there pounding a dead parrot on the counter, and the management
response is to frantically swap in new counters to see if that fixes the
problem."
- Peter Gutmann
