Re: Give insets a full Row
Juergen == Juergen Vigna [EMAIL PROTECTED] writes: Juergen You may be right but we overwirte it only if the depth 5, Juergen should I add code anyway to put it more to the right? OK, I think it is fine as it is. Let's wait for actual complaints before doing anything. JMarc
Re: Give insets a full Row
> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: Juergen> You may be right but we overwirte it only if the depth > 5, Juergen> should I add code anyway to put it more to the right? OK, I think it is fine as it is. Let's wait for actual complaints before doing anything. JMarc
RE: Give insets a full Row
On 11-Apr-2002 Juergen Vigna wrote: The attached small patch changes LyX's behaviour for NeedFullRow insets in that it does give them ALWAYS the full row for drawing and does not care if there is some indent or depth. IMO this is correct and should be done, also this fixes a few problems we have and makes things easier to handle. Comments!? Hmm, I did not get any complaints so I will commit this patch later this morning. Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Machines take me by surprise with great frequency. - Alan Turing
Re: Give insets a full Row
Juergen Vigna [EMAIL PROTECTED] writes: | The attached small patch changes LyX's behaviour for NeedFullRow insets in | that it does give them ALWAYS the full row for drawing and does not care if | there is some indent or depth. IMO this is correct and should be done, also | this fixes a few problems we have and makes things easier to handle. What problems? What things? | + Inset * ins; | + if ((row-par()-getChar(row-pos()) == Paragraph::META_INSET) | + (ins=row-par()-getInset(row-pos())) | + (ins-needFullRow() || ins-display())) | + return LYX_PAPER_MARGIN; | + Should probably be in a function of its own. -- Lgb
Re: Give insets a full Row
Juergen Vigna [EMAIL PROTECTED] writes: | On 11-Apr-2002 Juergen Vigna wrote: The attached small patch changes LyX's behaviour for NeedFullRow insets in that it does give them ALWAYS the full row for drawing and does not care if there is some indent or depth. IMO this is correct and should be done, also this fixes a few problems we have and makes things easier to handle. Comments!? | Hmm, I did not get any complaints so I will commit this patch later this | morning. What bugnumber does this fix? -- Lgb
Re: Give insets a full Row
On Fri, Apr 12, 2002 at 10:31:15AM +0200, Lars Gullik Bjønnes wrote: | + Inset * ins; | + if ((row-par()-getChar(row-pos()) == Paragraph::META_INSET) | + (ins=row-par()-getInset(row-pos())) | + (ins-needFullRow() || ins-display())) | + return LYX_PAPER_MARGIN; | + Should probably be in a function of its own. And since every term uses row-(...) it probably should be a function of the row... Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson)
Re: Give insets a full Row
Juergen == Juergen Vigna [EMAIL PROTECTED] writes: Juergen The attached small patch changes LyX's behaviour for Juergen NeedFullRow insets in that it does give them ALWAYS the full Juergen row for drawing and does not care if there is some indent or Juergen depth. IMO this is correct and should be done, also this Juergen fixes a few problems we have and makes things easier to Juergen handle. If you are giving the whole window width, it means that the depth markers in left margin will be overwritten. This is not nice. JMarc
Re: Give insets a full Row
Juergen == Juergen Vigna [EMAIL PROTECTED] writes: Juergen On 11-Apr-2002 Juergen Vigna wrote: The attached small patch changes LyX's behaviour for NeedFullRow insets in that it does give them ALWAYS the full row for drawing and does not care if there is some indent or depth. IMO this is correct and should be done, also this fixes a few problems we have and makes things easier to handle. Comments!? Juergen Hmm, I did not get any complaints so I will commit this patch Juergen later this morning. Huh? I just posted my own complaint one minute ago... JMarc
Re: Give insets a full Row
On 12-Apr-2002 Lars Gullik Bjønnes wrote: | + Inset * ins; | + if ((row-par()-getChar(row-pos()) == Paragraph::META_INSET) | + (ins=row-par()-getInset(row-pos())) | + (ins-needFullRow() || ins-display())) | + return LYX_PAPER_MARGIN; | + Should probably be in a function of its own. Yes I already thought about that. Should it be an inlined function? | Hmm, I did not get any complaints so I will commit this patch later this | morning. What bugnumber does this fix? Well in general we have problems with getting the right width of an inset when we have indent as paragraph spacing and also when we have paragraph which are in a deeper depth. Also this are insets which use more space as they also contain more paragraphs and so IMO when editing them we should give them more space. You surely saw in the commitlog official bug this fixes but IMO this fixes also bugs which are not on the list, but which bugged me since quite a time. Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ QOTD: I haven't come far enough, and don't call me baby.
Re: Give insets a full Row
On 12-Apr-2002 Jean-Marc Lasgouttes wrote: Juergen == Juergen Vigna [EMAIL PROTECTED] writes: Juergen The attached small patch changes LyX's behaviour for Juergen NeedFullRow insets in that it does give them ALWAYS the full Juergen row for drawing and does not care if there is some indent or Juergen depth. IMO this is correct and should be done, also this Juergen fixes a few problems we have and makes things easier to Juergen handle. If you are giving the whole window width, it means that the depth markers in left margin will be overwritten. This is not nice. You may be right but we overwirte it only if the depth 5, should I add code anyway to put it more to the right? Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ The man who sees, on New Year's day, Mount Fuji, a hawk, and an eggplant is forever blessed. -- Old Japanese proverb
Re: Give insets a full Row
On 12-Apr-2002 Jean-Marc Lasgouttes wrote: Juergen Hmm, I did not get any complaints so I will commit this patch Juergen later this morning. Huh? I just posted my own complaint one minute ago... Well I did not get it until now so! Anyway if you think this is wrong we can always revert it it's really small (just a few lines in the start of LeftMargin and RightMargin!). Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Never go to a doctor whose office plants have died. -- Erma Bombeck
Re: Give insets a full Row
Juergen == Juergen Vigna [EMAIL PROTECTED] writes: Juergen On 12-Apr-2002 Jean-Marc Lasgouttes wrote: Juergen Hmm, I did not get any complaints so I will commit this patch Juergen later this morning. Huh? I just posted my own complaint one minute ago... Juergen Well I did not get it until now so! Anyway if you think this Juergen is wrong we can always revert it it's really small (just a Juergen few lines in the start of LeftMargin and RightMargin!). It seems my mail is very slow today... JMarc
RE: Give insets a full Row
On 11-Apr-2002 Juergen Vigna wrote: > The attached small patch changes LyX's behaviour for NeedFullRow insets in > that it does give them ALWAYS the full row for drawing and does not care if > there is some indent or depth. IMO this is correct and should be done, also > this fixes a few problems we have and makes things easier to handle. > > Comments!? Hmm, I did not get any complaints so I will commit this patch later this morning. Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Machines take me by surprise with great frequency. - Alan Turing
Re: Give insets a full Row
Juergen Vigna <[EMAIL PROTECTED]> writes: | The attached small patch changes LyX's behaviour for NeedFullRow insets in | that it does give them ALWAYS the full row for drawing and does not care if | there is some indent or depth. IMO this is correct and should be done, also | this fixes a few problems we have and makes things easier to handle. What problems? What things? | + Inset * ins; | + if ((row->par()->getChar(row->pos()) == Paragraph::META_INSET) && | + (ins=row->par()->getInset(row->pos())) && | + (ins->needFullRow() || ins->display())) | + return LYX_PAPER_MARGIN; | + Should probably be in a function of its own. -- Lgb
Re: Give insets a full Row
Juergen Vigna <[EMAIL PROTECTED]> writes: | On 11-Apr-2002 Juergen Vigna wrote: >> The attached small patch changes LyX's behaviour for NeedFullRow insets in >> that it does give them ALWAYS the full row for drawing and does not care if >> there is some indent or depth. IMO this is correct and should be done, also >> this fixes a few problems we have and makes things easier to handle. >> >> Comments!? > | Hmm, I did not get any complaints so I will commit this patch later this | morning. What bugnumber does this fix? -- Lgb
Re: Give insets a full Row
On Fri, Apr 12, 2002 at 10:31:15AM +0200, Lars Gullik Bjønnes wrote: > | + Inset * ins; > | + if ((row->par()->getChar(row->pos()) == Paragraph::META_INSET) && > | + (ins=row->par()->getInset(row->pos())) && > | + (ins->needFullRow() || ins->display())) > | + return LYX_PAPER_MARGIN; > | + > > Should probably be in a function of its own. And since every term uses row->(...) it probably should be a function of the row... Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson)
Re: Give insets a full Row
> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: Juergen> The attached small patch changes LyX's behaviour for Juergen> NeedFullRow insets in that it does give them ALWAYS the full Juergen> row for drawing and does not care if there is some indent or Juergen> depth. IMO this is correct and should be done, also this Juergen> fixes a few problems we have and makes things easier to Juergen> handle. If you are giving the whole window width, it means that the depth markers in left margin will be overwritten. This is not nice. JMarc
Re: Give insets a full Row
> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: Juergen> On 11-Apr-2002 Juergen Vigna wrote: >> The attached small patch changes LyX's behaviour for NeedFullRow >> insets in that it does give them ALWAYS the full row for drawing >> and does not care if there is some indent or depth. IMO this is >> correct and should be done, also this fixes a few problems we have >> and makes things easier to handle. >> >> Comments!? Juergen> Hmm, I did not get any complaints so I will commit this patch Juergen> later this morning. Huh? I just posted my own complaint one minute ago... JMarc
Re: Give insets a full Row
On 12-Apr-2002 Lars Gullik Bjønnes wrote: > | + Inset * ins; > | + if ((row->par()->getChar(row->pos()) == Paragraph::META_INSET) && > | + (ins=row->par()->getInset(row->pos())) && > | + (ins->needFullRow() || ins->display())) > | + return LYX_PAPER_MARGIN; > | + > > Should probably be in a function of its own. Yes I already thought about that. Should it be an inlined function? >| Hmm, I did not get any complaints so I will commit this patch later this >| morning. > > What bugnumber does this fix? Well in general we have problems with getting the right width of an inset when we have indent as paragraph spacing and also when we have paragraph which are in a deeper depth. Also this are insets which use more space as they also contain more paragraphs and so IMO when editing them we should give them more space. You surely saw in the commitlog official bug this fixes but IMO this fixes also bugs which are not on the list, but which bugged me since quite a time. Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ QOTD: "I haven't come far enough, and don't call me baby."
Re: Give insets a full Row
On 12-Apr-2002 Jean-Marc Lasgouttes wrote: >> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: > > Juergen> The attached small patch changes LyX's behaviour for > Juergen> NeedFullRow insets in that it does give them ALWAYS the full > Juergen> row for drawing and does not care if there is some indent or > Juergen> depth. IMO this is correct and should be done, also this > Juergen> fixes a few problems we have and makes things easier to > Juergen> handle. > > If you are giving the whole window width, it means that the depth > markers in left margin will be overwritten. This is not nice. You may be right but we overwirte it only if the depth > 5, should I add code anyway to put it more to the right? Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ The man who sees, on New Year's day, Mount Fuji, a hawk, and an eggplant is forever blessed. -- Old Japanese proverb
Re: Give insets a full Row
On 12-Apr-2002 Jean-Marc Lasgouttes wrote: > Juergen> Hmm, I did not get any complaints so I will commit this patch > Juergen> later this morning. > > Huh? I just posted my own complaint one minute ago... Well I did not get it until now so! Anyway if you think this is wrong we can always revert it it's really small (just a few lines in the start of LeftMargin and RightMargin!). Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Never go to a doctor whose office plants have died. -- Erma Bombeck
Re: Give insets a full Row
> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: Juergen> On 12-Apr-2002 Jean-Marc Lasgouttes wrote: Juergen> Hmm, I did not get any complaints so I will commit this patch Juergen> later this morning. >> Huh? I just posted my own complaint one minute ago... Juergen> Well I did not get it until now so! Anyway if you think this Juergen> is wrong we can always revert it it's really small (just a Juergen> few lines in the start of LeftMargin and RightMargin!). It seems my mail is very slow today... JMarc
