Re: Some bugs
John == John Levon [EMAIL PROTECTED] writes: John 3. Button insets are still not centred. I think someone closed John this bug. It needs re-opening. What do you mean by not centered? I can see that the include inset can behave in a very weird way if one use enter just after it, though. John 8. (usability issue) - minipage is just way too hard to find. We John might consider a submenu for 'Box' that has Minipage, John Parbox, Framed Box etc. We used to have that, and I removed it... Is minipage such a useful beast to warrant menu bloat, apart from the fact that we are used to see it? John 11. Creating a new figure float, the 'Figure #:' of the caption John is only seen on pressing return I am not sure where this one comes from. John 12. Lars's on-screen translated things like 'Part' etc. are John broken. I get 'Teil' in the DVI and not on screen. As I commented in bugzilla, there are several solutions, but the core functionality works. John 14. The footnote in the User Guide (first one) is inheriting the John font from its containing paragraph. Not good ... Not good indeed. John 15. Right Address is (predictably enough) broken I think the current behaviour is what we decided to be 'good enough'. What I would suggest is some nice drawing (but what?) in the margin suggesting that the text is as much on the right as possible. This dubious feature did not deserve the complicated code to support it. JMarc
Re: Some bugs
On Mon, Feb 21, 2005 at 06:47:15PM +0100, Jean-Marc Lasgouttes wrote: John 3. Button insets are still not centred. I think someone closed John this bug. It needs re-opening. What do you mean by not centered? I can see that the include inset can behave in a very weird way if one use enter just after it, though. Physically on the screen: e.g. TOC button is not in the middle of the workarea. John 8. (usability issue) - minipage is just way too hard to find. We John might consider a submenu for 'Box' that has Minipage, John Parbox, Framed Box etc. We used to have that, and I removed it... Is minipage such a useful beast to warrant menu bloat, apart from the fact that we are used to see it? Well, personally I used minipage quite often, and from reports of users etc. it seems quite a lot of them do too. Maybe, it's not. John 15. Right Address is (predictably enough) broken I think the current behaviour is what we decided to be 'good enough'. What I would suggest is some nice drawing (but what?) in the margin suggesting that the text is as much on the right as possible. This dubious feature did not deserve the complicated code to support it. I don't know, but I agree that the old right address code was a nightmare john
Re: Some bugs
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> 3. Button insets are still not centred. I think someone closed John> this bug. It needs re-opening. What do you mean by not centered? I can see that the include inset can behave in a very weird way if one use just after it, though. John> 8. (usability issue) - minipage is just way too hard to find. We John> might consider a submenu for 'Box' that has "Minipage", John> "Parbox", "Framed Box" etc. We used to have that, and I removed it... Is minipage such a useful beast to warrant menu bloat, apart from the fact that we are used to see it? John> 11. Creating a new figure float, the 'Figure #:' of the caption John> is only seen on pressing return I am not sure where this one comes from. John> 12. Lars's on-screen translated things like 'Part' etc. are John> broken. I get 'Teil' in the DVI and not on screen. As I commented in bugzilla, there are several solutions, but the core functionality works. John> 14. The footnote in the User Guide (first one) is inheriting the John> font from its containing paragraph. Not good ... Not good indeed. John> 15. Right Address is (predictably enough) broken I think the current behaviour is what we decided to be 'good enough'. What I would suggest is some nice drawing (but what?) in the margin suggesting that the text is as much on the right as possible. This dubious feature did not deserve the complicated code to support it. JMarc
Re: Some bugs
On Mon, Feb 21, 2005 at 06:47:15PM +0100, Jean-Marc Lasgouttes wrote: > John> 3. Button insets are still not centred. I think someone closed > John> this bug. It needs re-opening. > > What do you mean by not centered? I can see that the include inset can > behave in a very weird way if one use just after it, though. Physically on the screen: e.g. TOC button is not in the middle of the workarea. > John> 8. (usability issue) - minipage is just way too hard to find. We > John> might consider a submenu for 'Box' that has "Minipage", > John> "Parbox", "Framed Box" etc. > > We used to have that, and I removed it... Is minipage such a useful > beast to warrant menu bloat, apart from the fact that we are used to > see it? Well, personally I used minipage quite often, and from reports of users etc. it seems quite a lot of them do too. Maybe, it's not. > John> 15. Right Address is (predictably enough) broken > > I think the current behaviour is what we decided to be 'good enough'. > What I would suggest is some nice drawing (but what?) in the margin > suggesting that the text is as much on the right as possible. This > dubious feature did not deserve the complicated code to support it. I don't know, but I agree that the old right address code was a nightmare john
Re: Some bugs
On Fri, 2005-02-11 at 03:11, John Levon wrote:
Since I can't access bugzilla. I only tried for about 10 minutes so please
don't think this is exhaustive. On the whole, the current CVS isn't too bad. A
couple of bad assertions, but after a few of these are fixed, I think we can
let Michael S loose. Massive improvement on last time... what have you lot
been
doing? :)
1. crash by new doc, insert comment, then repeatedly click on the
button to open and close the inset, until you get:
Assertion triggered in void LyXText::dispatch(LCursor, FuncRequest) by
failing check cur.text() == this in file text3.C:361
I get the same assertion in CVS of now, in the following way:
1) new document
2) insert math inset
3) inside math inset: insert text box (Control-M)
4) click inside this box.
The file created contains this:
\begin_inset Formula \[
\mbox{
\begin_layout Standard
\end_layout
}\]
\end_inset
Putting stuff inside the text box makes no difference. Clicking on it
crashes.
...
john
- Martin
signature.asc
Description: This is a digitally signed message part
Re: Some bugs
On Mon, Feb 14, 2005 at 04:47:12PM +0200, Martin Vermeer wrote: 1) new document 2) insert math inset 3) inside math inset: insert text box (Control-M) 4) click inside this box. mbox is broken in many ways right now. Andre'
Re: Some bugs
On Fri, 2005-02-11 at 03:11, John Levon wrote:
> Since I can't access bugzilla. I only tried for about 10 minutes so please
> don't think this is exhaustive. On the whole, the current CVS isn't too bad. A
> couple of bad assertions, but after a few of these are fixed, I think we can
> let Michael S loose. Massive improvement on last time... what have you lot
> been
> doing? :)
>
> 1. crash by new doc, insert comment, then repeatedly click on the
>button to open and close the inset, until you get:
>
> Assertion triggered in void LyXText::dispatch(LCursor&, FuncRequest&) by
> failing check "cur.text() == this" in file text3.C:361
I get the same assertion in CVS of now, in the following way:
1) new document
2) insert math inset
3) inside math inset: insert text box (Control-M)
4) click inside this box.
The file created contains this:
\begin_inset Formula \[
\mbox{
\begin_layout Standard
\end_layout
}\]
\end_inset
Putting stuff inside the text box makes no difference. Clicking on it
crashes.
...
> john
- Martin
signature.asc
Description: This is a digitally signed message part
Re: Some bugs
On Mon, Feb 14, 2005 at 04:47:12PM +0200, Martin Vermeer wrote: > 1) new document > 2) insert math inset > 3) inside math inset: insert text box (Control-M) > 4) click inside this box. mbox is broken in many ways right now. Andre'
Re: Some bugs
On Fri, Feb 11, 2005 at 01:11:24AM +, John Levon wrote: Since I can't access bugzilla. I only tried for about 10 minutes so please I filed all these now. john
Re: Some bugs
On Fri, Feb 11, 2005 at 01:11:24AM +, John Levon wrote: > Since I can't access bugzilla. I only tried for about 10 minutes so please I filed all these now. john
Re: Some bugs
On 17-Dec-2001 Lars Gullik Bjønnes wrote: | So, when and where is the next LyX developer's meeting going to be held? Hey!! We never decide that until after New Years. Well if you both wouldn't had drunken that much on the last meeting you probably should know that we already have a volunteer in the west of Europe near the Atlantic Ocean ;) | It seems Juergen needs some fun to lighten up. He could sure need to drink | some beer, introduce a bunch of bugs in the code, and sleep in forbidden | places. You know it's hard for me, my code doesn't have bugs! Yes... he is really only a copy cat. (and we should give him the opportunity to play it out.) ??? Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Winter is the season in which people try to keep the house as warm as it was in the summer, when they complained about the heat.
Re: Some bugs
John == John Levon [EMAIL PROTECTED] writes: John On Fri, Dec 14, 2001 at 08:42:32AM +0100, Michael Schmitt wrote: Place a paragraph that is aligned to the right and has a line above into a minipage - the line is not drawn correctly (in order to observe this, there must be some text in front/after the minipage and the size of the minipage should be set to 50% of page width) John fix attached (thanks for the good report) Applied (in my tree). JMarc
Re: Some bugs
On 17-Dec-2001 Lars Gullik Bjønnes wrote: >| So, when and where is the next LyX developer's meeting going to be held? > > Hey!! We never decide that until after New Years. Well if you both wouldn't had drunken that much on the last meeting you probably should know that we already have a volunteer in the west of Europe near the Atlantic Ocean ;) >| It seems Juergen needs some fun to lighten up. He could sure need to drink >| some beer, introduce a bunch of bugs in the code, and sleep in forbidden >| places. You know it's hard for me, my code doesn't have bugs! > Yes... he is really only a copy cat. (and we should give him the > opportunity to play it out.) ??? Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Winter is the season in which people try to keep the house as warm as it was in the summer, when they complained about the heat.
Re: Some bugs
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> On Fri, Dec 14, 2001 at 08:42:32AM +0100, Michael Schmitt wrote: >> Place a paragraph that is aligned to the right and has a line above >> into a minipage -> the line is not drawn correctly (in order to >> observe this, there must be some text in front/after the minipage >> and the size of the minipage should be set to 50% of page width) John> fix attached (thanks for the good report) Applied (in my tree). JMarc
Re: Some bugs
On Fri, 14 Dec 2001, Juergen Vigna wrote: [Blah, blah, blah, blah, blah] So, when and where is the next LyX developer's meeting going to be held? It seems Juergen needs some fun to lighten up. He could sure need to drink some beer, introduce a bunch of bugs in the code, and sleep in forbidden places. Greets, Asger
Re: Some bugs
On Fri, 14 Dec 2001, Juergen Vigna wrote: [Blah, blah, blah, blah, blah] So, when and where is the next LyX developer's meeting going to be held? It seems Juergen needs some fun to lighten up. He could sure need to drink some beer, introduce a bunch of bugs in the code, and sleep in forbidden places. Greets, Asger
Re: Some bugs
On Fri, Dec 14, 2001 at 08:42:32AM +0100, Michael Schmitt wrote: Place a paragraph that is aligned to the right and has a line above into a minipage - the line is not drawn correctly (in order to observe this, there must be some text in front/after the minipage and the size of the minipage should be set to 50% of page width) fix attached (thanks for the good report) regards john -- Of all manifestations of power, restraint impresses the most. - Thucydides Index: src/ChangeLog === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/ChangeLog,v retrieving revision 1.457 diff -u -r1.457 ChangeLog --- src/ChangeLog 2001/12/12 12:07:38 1.457 +++ src/ChangeLog 2001/12/14 09:05:24 @@ -1,3 +1,7 @@ +2001-12-14 John Levon [EMAIL PROTECTED] + + * text.C: fix line above/below drawing in insets + 2001-12-12 Lars Gullik Bjønnes [EMAIL PROTECTED] * lyxlength.[Ch] (operator!=): new function Index: src/text.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/text.C,v retrieving revision 1.213 diff -u -r1.213 text.C --- src/text.C 2001/12/12 09:56:00 1.213 +++ src/text.C 2001/12/14 09:05:33 @@ -,8 +,8 @@ y_top += asc; int const w = (inset_owner ? inset_owner-width(p.bv, font) : ww); - int const xp = static_castint(inset_owner ? p.x : 0); - p.pain-line(xp, p.yo + y_top, w, p.yo + y_top, + int const xp = static_castint(inset_owner ? p.xo : 0); + p.pain-line(xp, p.yo + y_top, xp + w, p.yo + y_top, LColor::topline, Painter::line_solid, Painter::line_thick); @@ -3493,9 +3493,9 @@ y_bottom -= asc; int const w = (inset_owner ? inset_owner-width(p.bv, font) : ww); - int const xp = static_castint(inset_owner ? p.x : 0); + int const xp = static_castint(inset_owner ? p.xo : 0); int const y = p.yo + y_bottom; - p.pain-line(xp, y, w, y, LColor::topline, Painter::line_solid, + p.pain-line(xp, y, xp + w, y, LColor::topline, Painter::line_solid, Painter::line_thick); y_bottom -= asc;
Re: Some bugs
On Fri, Dec 14, 2001 at 08:42:32AM +0100, Michael Schmitt wrote:
Adding a column after the last column of a table still causes a freed
memory access error! (Use njamd, a fast memory checker, to check this)
well, this patch doesn't make njamd complain, and things still work.
I'm not proposing this as a fix because I can't be bothered to decipher
the code and check everything is OK ...
regards
john
Index: tabular.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/tabular.C,v
retrieving revision 1.107
diff -u -r1.107 tabular.C
--- tabular.C 2001/12/11 17:26:51 1.107
+++ tabular.C 2001/12/14 09:20:31
@@ -307,12 +307,12 @@
c_info[i][j] = cell_info[i][j - 1];
}
// care about multicolumns
- if (cell_info[i][column + 1].multicolumn==CELL_BEGIN_OF_MULTICOLUMN) {
- cell_info[i][column + 1].multicolumn =
CELL_PART_OF_MULTICOLUMN;
+ if (c_info[i][column + 1].multicolumn==CELL_BEGIN_OF_MULTICOLUMN) {
+ c_info[i][column + 1].multicolumn = CELL_PART_OF_MULTICOLUMN;
}
if ((column + 1) == columns_ ||
- cell_info[i][column + 2].multicolumn !=
CELL_PART_OF_MULTICOLUMN) {
- cell_info[i][column + 1].multicolumn = LyXTabular::CELL_NORMAL;
+ c_info[i][column + 2].multicolumn != CELL_PART_OF_MULTICOLUMN)
+{
+ c_info[i][column + 1].multicolumn = LyXTabular::CELL_NORMAL;
}
}
cell_info = c_info;
--
Of all manifestations of power, restraint impresses the most.
- Thucydides
RE: Some bugs
On 14-Dec-2001 Michael Schmitt wrote: Insert one line of text into a note; delete the line and undo the deletion - freed memory access error! #0 Paragraph::id (this=0x446b8fdc) at paragraph.C:2073 #1 0x0818feb4 in InsetText::getParFromID (this=0x460feef8, id=1) This is a stupid error of myself in InsetText::paragraph(Paragraph *), as the code I put there to delete the paragraphs is WRONG! I fixed this already here a few days ago but wanted to finish the whole undo/redo fix stuff before commiting. But it seems it is better to commit often also half backed stuff as otherwise one will have to loose a lot of time solving conflicts, so most probably I will commit the whole stuff soon also if I didn't finish it and it still has some problems! Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Drop that pickle!
Re: Some bugs
On Fri, Dec 14, 2001 at 11:56:40AM +0100, Juergen Vigna wrote: fix stuff before commiting. But it seems it is better to commit often also half backed stuff as otherwise one will have to loose a lot of time solving conflicts, so most probably I will commit the whole stuff soon also if I didn't finish it and it still has some problems! that's 3 times today already ! I know it's friday, but I'm sure JMarc and Andre are very sorry now ... you could have just backed out their changes you know., regards john -- Of all manifestations of power, restraint impresses the most. - Thucydides
Re: Some bugs
On 14-Dec-2001 John Levon wrote: that's 3 times today already ! I know it's friday, but I'm sure JMarc and Andre are Only 3 times that far to few! And I don't think they need you as their advocate it seems they have attained full age some time ago! They were at least so intelligent to not answer my whines! very sorry now ... I really hope so! you could have just backed out their changes you know., Could I?! I'll comit soon anyway! Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ The rule on staying alive as a program manager is to give 'em a number or give 'em a date, but never give 'em both at once.
Re: Some bugs
On Fri, Dec 14, 2001 at 11:56:40AM +0100, Juergen Vigna wrote: But it seems it is better to commit often also half backed stuff as otherwise one will have to loose a lot of time solving conflicts, so most probably I will commit the whole stuff soon also if I didn't finish it and it still has some problems! I promise not to touch undo/redo until January. Does that sound ok? Andre' -- André Pönitz .. [EMAIL PROTECTED]
Re: Some bugs
On 14-Dec-2001 Juergen Vigna wrote: you could have just backed out their changes you know., Could I?! I'll comit soon anyway! And why should I back out a change which caused only one little conflict I fixed in about 5 secs! You all are responsilbe if I spend more time sending stupid mails then fixing real bugs! Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ How can you think and hit at the same time? -- Yogi Berra
Re: Some bugs
On 14-Dec-2001 Andre Poenitz wrote: On Fri, Dec 14, 2001 at 11:56:40AM +0100, Juergen Vigna wrote: But it seems it is better to commit often also half backed stuff as otherwise one will have to loose a lot of time solving conflicts, so most probably I will commit the whole stuff soon also if I didn't finish it and it still has some problems! I promise not to touch undo/redo until January. Does that sound ok? No that doesn't sound ok! Work on that code fix remaining bugs and send me the patches! Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ I/O, I/O, It's off to disk I go, A bit or byte to read or write, I/O, I/O, I/O...
Re: Some bugs
On Fri, Dec 14, 2001 at 12:14:50PM +0100, Juergen Vigna wrote: And why should I back out a change which caused only one little conflict I fixed in about 5 secs! You all are responsilbe if I spend more time sending stupid mails then fixing real bugs! first you hurt me , then you make me laugh ... is there no end ??? oh, and ben says you all suck for not applying his mmap deptable patch [1] john [1] not really - Of all manifestations of power, restraint impresses the most. - Thucydides
Re: Some bugs
On 14-Dec-2001 John Levon wrote: On Fri, Dec 14, 2001 at 12:14:50PM +0100, Juergen Vigna wrote: And why should I back out a change which caused only one little conflict I fixed in about 5 secs! You all are responsilbe if I spend more time sending stupid mails then fixing real bugs! first you hurt me , then you make me laugh ... is there no end ??? Well I guess there's always a Saturday after a Friday, but for myself you have to wait till Monday as on weekends I tend to not go too near a computer. oh, and ben says you all suck for not applying his mmap deptable patch [1] Well I have to agree and not only because of not applying a patch and most of all Asger who is only there to tell us some wise words without effectively doing anything. Also on meetings he drinks a lot of beer, hacks into the code a lot of bugs, lies drunken in places he's not supposed to and really thinks he will get away with it just not posting mails on Fridays, but today you got what you deserve! Jug P.S.: Did I tell you that I didn't sleep well tonight cause Kai had a bit of fever and held me awake most of the time. P.P.S.: In a second thought I added the Cc: to Asger so he'll not loose todays wisdoms! -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Is this foreplay? No, this is Nuke Strike. Foreplay has lousy graphics. Beat me again. -- Duckert, in Bad Rubber, Albedo #0 (comics)
Re: Some bugs
On Fri, Dec 14, 2001 at 08:42:32AM +0100, Michael Schmitt wrote: > Place a paragraph that is aligned to the right and has a line above into > a minipage -> the line is not drawn correctly > (in order to observe this, there must be some text in front/after the > minipage and the size of the minipage should be set to 50% of page width) fix attached (thanks for the good report) regards john -- "Of all manifestations of power, restraint impresses the most." - Thucydides Index: src/ChangeLog === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/ChangeLog,v retrieving revision 1.457 diff -u -r1.457 ChangeLog --- src/ChangeLog 2001/12/12 12:07:38 1.457 +++ src/ChangeLog 2001/12/14 09:05:24 @@ -1,3 +1,7 @@ +2001-12-14 John Levon <[EMAIL PROTECTED]> + + * text.C: fix line above/below drawing in insets + 2001-12-12 Lars Gullik Bjønnes <[EMAIL PROTECTED]> * lyxlength.[Ch] (operator!=): new function Index: src/text.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/text.C,v retrieving revision 1.213 diff -u -r1.213 text.C --- src/text.C 2001/12/12 09:56:00 1.213 +++ src/text.C 2001/12/14 09:05:33 @@ -,8 +,8 @@ y_top += asc; int const w = (inset_owner ? inset_owner->width(p.bv, font) : ww); - int const xp = static_cast(inset_owner ? p.x : 0); - p.pain->line(xp, p.yo + y_top, w, p.yo + y_top, + int const xp = static_cast(inset_owner ? p.xo : 0); + p.pain->line(xp, p.yo + y_top, xp + w, p.yo + y_top, LColor::topline, Painter::line_solid, Painter::line_thick); @@ -3493,9 +3493,9 @@ y_bottom -= asc; int const w = (inset_owner ? inset_owner->width(p.bv, font) : ww); - int const xp = static_cast(inset_owner ? p.x : 0); + int const xp = static_cast(inset_owner ? p.xo : 0); int const y = p.yo + y_bottom; - p.pain->line(xp, y, w, y, LColor::topline, Painter::line_solid, + p.pain->line(xp, y, xp + w, y, LColor::topline, Painter::line_solid, Painter::line_thick); y_bottom -= asc;
Re: Some bugs
On Fri, Dec 14, 2001 at 08:42:32AM +0100, Michael Schmitt wrote:
> Adding a column after the last column of a table still causes a freed
> memory access error! (Use "njamd", a fast memory checker, to check this)
well, this patch doesn't make njamd complain, and things still work.
I'm not proposing this as a fix because I can't be bothered to decipher
the code and check everything is OK ...
regards
john
Index: tabular.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/tabular.C,v
retrieving revision 1.107
diff -u -r1.107 tabular.C
--- tabular.C 2001/12/11 17:26:51 1.107
+++ tabular.C 2001/12/14 09:20:31
@@ -307,12 +307,12 @@
c_info[i][j] = cell_info[i][j - 1];
}
// care about multicolumns
- if (cell_info[i][column + 1].multicolumn==CELL_BEGIN_OF_MULTICOLUMN) {
- cell_info[i][column + 1].multicolumn =
CELL_PART_OF_MULTICOLUMN;
+ if (c_info[i][column + 1].multicolumn==CELL_BEGIN_OF_MULTICOLUMN) {
+ c_info[i][column + 1].multicolumn = CELL_PART_OF_MULTICOLUMN;
}
if ((column + 1) == columns_ ||
- cell_info[i][column + 2].multicolumn !=
CELL_PART_OF_MULTICOLUMN) {
- cell_info[i][column + 1].multicolumn = LyXTabular::CELL_NORMAL;
+ c_info[i][column + 2].multicolumn != CELL_PART_OF_MULTICOLUMN)
+{
+ c_info[i][column + 1].multicolumn = LyXTabular::CELL_NORMAL;
}
}
cell_info = c_info;
--
"Of all manifestations of power, restraint impresses the most."
- Thucydides
RE: Some bugs
On 14-Dec-2001 Michael Schmitt wrote: > Insert one line of text into a note; delete the line and undo the > deletion -> freed memory access error! > >#0 Paragraph::id (this=0x446b8fdc) at paragraph.C:2073 >#1 0x0818feb4 in InsetText::getParFromID (this=0x460feef8, id=1) This is a stupid error of myself in InsetText::paragraph(Paragraph *), as the code I put there to delete the paragraphs is WRONG! I fixed this already here a few days ago but wanted to finish the whole undo/redo fix stuff before commiting. But it seems it is better to commit often also half backed stuff as otherwise one will have to loose a lot of time solving conflicts, so most probably I will commit the whole stuff soon also if I didn't finish it and it still has some problems! Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Drop that pickle!
Re: Some bugs
On Fri, Dec 14, 2001 at 11:56:40AM +0100, Juergen Vigna wrote: > fix stuff before commiting. But it seems it is better to commit often > also half backed stuff as otherwise one will have to loose a lot of time > solving conflicts, so most probably I will commit the whole stuff soon > also if I didn't finish it and it still has some problems! that's 3 times today already ! I know it's friday, but I'm sure JMarc and Andre are very sorry now ... you could have just backed out their changes you know., regards john -- "Of all manifestations of power, restraint impresses the most." - Thucydides
Re: Some bugs
On 14-Dec-2001 John Levon wrote: > that's 3 times today already ! I know it's friday, but I'm sure JMarc and Andre are Only 3 times that far to few! And I don't think they need you as their advocate it seems they have attained full age some time ago! They were at least so intelligent to not answer my whines! > very sorry now ... I really hope so! > you could have just backed out their changes you know., Could I?! I'll comit soon anyway! Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ The rule on staying alive as a program manager is to give 'em a number or give 'em a date, but never give 'em both at once.
Re: Some bugs
On Fri, Dec 14, 2001 at 11:56:40AM +0100, Juergen Vigna wrote: > But it seems it is better to commit often also half backed stuff as > otherwise one will have to loose a lot of time solving conflicts, so most > probably I will commit the whole stuff soon also if I didn't finish it > and it still has some problems! I promise not to touch undo/redo until January. Does that sound ok? Andre' -- André Pönitz .. [EMAIL PROTECTED]
Re: Some bugs
On 14-Dec-2001 Juergen Vigna wrote: >> you could have just backed out their changes you know., > > Could I?! I'll comit soon anyway! And why should I back out a change which caused only one little conflict I fixed in about 5 secs! You all are responsilbe if I spend more time sending stupid mails then fixing real bugs! Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ How can you think and hit at the same time? -- Yogi Berra
Re: Some bugs
On 14-Dec-2001 Andre Poenitz wrote: > On Fri, Dec 14, 2001 at 11:56:40AM +0100, Juergen Vigna wrote: >> But it seems it is better to commit often also half backed stuff as >> otherwise one will have to loose a lot of time solving conflicts, so most >> probably I will commit the whole stuff soon also if I didn't finish it >> and it still has some problems! > > I promise not to touch undo/redo until January. > > Does that sound ok? No that doesn't sound ok! Work on that code fix remaining bugs and send me the patches! Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ I/O, I/O, It's off to disk I go, A bit or byte to read or write, I/O, I/O, I/O...
Re: Some bugs
On Fri, Dec 14, 2001 at 12:14:50PM +0100, Juergen Vigna wrote: > And why should I back out a change which caused only one little > conflict I fixed in about 5 secs! You all are responsilbe if I > spend more time sending stupid mails then fixing real bugs! first you hurt me , then you make me laugh ... is there no end ??? oh, and ben says you all suck for not applying his mmap deptable patch [1] john [1] not really - "Of all manifestations of power, restraint impresses the most." - Thucydides
Re: Some bugs
On 14-Dec-2001 John Levon wrote: > On Fri, Dec 14, 2001 at 12:14:50PM +0100, Juergen Vigna wrote: > >> And why should I back out a change which caused only one little >> conflict I fixed in about 5 secs! You all are responsilbe if I >> spend more time sending stupid mails then fixing real bugs! > > first you hurt me , then you make me laugh ... is there no end ??? Well I guess there's always a Saturday after a Friday, but for myself you have to wait till Monday as on weekends I tend to not go too near a computer. > oh, and ben says you all suck for not applying his mmap deptable patch [1] Well I have to agree and not only because of not applying a patch and most of all Asger who is only there to tell us some wise words without effectively doing anything. Also on meetings he drinks a lot of beer, hacks into the code a lot of bugs, lies drunken in places he's not supposed to and really thinks he will get away with it just not posting mails on Fridays, but today you got what you deserve! Jug P.S.: Did I tell you that I didn't sleep well tonight cause Kai had a bit of fever and held me awake most of the time. P.P.S.: In a second thought I added the Cc: to Asger so he'll not loose todays wisdoms! -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ "Is this foreplay?" "No, this is Nuke Strike. Foreplay has lousy graphics. Beat me again." -- Duckert, in "Bad Rubber," Albedo #0 (comics)
Re: some bugs
"Angus" == Angus Leeming [EMAIL PROTECTED] writes: Angus 2. I have two documents open with current cvs lyx. I'm not sure Angus how, but one has footnotes displayed in the NEW_INSET style, Angus whilst the other has them in old style. Isn't this Angus impossible Trust me, it's here in front of me. (I did have Angus NEW_INSETS enabled, but have turned that off and recompiled the Angus whole code base to track down bugs for the 1.1.6 release.) If you opened a document with new_insets defined and then saved it, then it uses new insets for floats, even if you re-open it without new_insets (am I wrong?). JMarc
Re: some bugs
Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: | "Angus" == Angus Leeming [EMAIL PROTECTED] writes: | | Angus 2. I have two documents open with current cvs lyx. I'm not sure | Angus how, but one has footnotes displayed in the NEW_INSET style, | Angus whilst the other has them in old style. Isn't this | Angus impossible Trust me, it's here in front of me. (I did have | Angus NEW_INSETS enabled, but have turned that off and recompiled the | Angus whole code base to track down bugs for the 1.1.6 release.) | | If you opened a document with new_insets defined and then saved it, | then it uses new insets for floats, even if you re-open it without | new_insets (am I wrong?). No, you are correct. Lgb
Re: some bugs
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> 2. I have two documents open with current cvs lyx. I'm not sure Angus> how, but one has footnotes displayed in the NEW_INSET style, Angus> whilst the other has them in old style. Isn't this Angus> impossible Trust me, it's here in front of me. (I did have Angus> NEW_INSETS enabled, but have turned that off and recompiled the Angus> whole code base to track down bugs for the 1.1.6 release.) If you opened a document with new_insets defined and then saved it, then it uses new insets for floats, even if you re-open it without new_insets (am I wrong?). JMarc
Re: some bugs
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: | | Angus> 2. I have two documents open with current cvs lyx. I'm not sure | Angus> how, but one has footnotes displayed in the NEW_INSET style, | Angus> whilst the other has them in old style. Isn't this | Angus> impossible Trust me, it's here in front of me. (I did have | Angus> NEW_INSETS enabled, but have turned that off and recompiled the | Angus> whole code base to track down bugs for the 1.1.6 release.) | | If you opened a document with new_insets defined and then saved it, | then it uses new insets for floats, even if you re-open it without | new_insets (am I wrong?). No, you are correct. Lgb
