Re: [LyX/master] Amend f01ca45: uk.po: translation update from Yuri Chornoivan

[Scott Kostyshak]

On Sat, Jul 15, 2017 at 10:43:37AM +0200, Kornel Benko wrote:

> I don't understand how it could happen
> Please readd it. Maybe something was/is wrong on my file system. Today I had 
> a crash on it,
> so it is possible.

Strange. I also don't know how that file became untracked. In any case,
the .gmo is in at 4d0c29d5. Everything should be fine now.

Scott


signature.asc
Description: PGP signature

Re: [LyX/master] Amend f01ca45: uk.po: translation update from Yuri Chornoivan

[Kornel Benko]

Am Samstag, 15. Juli 2017 um 04:18:17, schrieb Scott Kostyshak 

> On Wed, Jul 12, 2017 at 10:41:15AM +0200, Kornel Benko wrote:
> > Am Mittwoch, 12. Juli 2017 um 04:22:39, schrieb Scott Kostyshak 
> > 
> > > On Sun, Jul 09, 2017 at 08:58:52AM +0200, Kornel Benko wrote:
> > > > commit ca0ba098dafae01299a5eae567d541a6c7ba4cd8
> > > > Author: Kornel Benko 
> > > > Date:   Sun Jul 9 08:58:00 2017 +0200
> > > > 
> > > > Amend f01ca45: uk.po: translation update from Yuri Chornoivan
> > > > ---
> > > >  po/uk.gmo |  Bin 648018 -> 0 bytes
> > > >  1 files changed, 0 insertions(+), 0 deletions(-)
> > > > 
> > > > diff --git a/po/uk.gmo b/po/uk.gmo
> > > > deleted file mode 100644
> > > > index d1fe4c8..000
> > > > Binary files a/po/uk.gmo and /dev/null differ
> > > 
> > > Why should we remove the gmo? Because it is out-of-date, now that the po
> > > was changed? Why not update the gmo instead of removing it? In general,
> > > should I commit the gmo whenever I commit changes to the po?
> > > 
> > > Thanks,
> > > 
> > > Scott
> > 
> > ???
> > #ls -l po/uk.*
> > -rw-r--r-- 1 kornel kornel  663380 júl 11 12:04 po/uk.gmo
> > -rw-r--r-- 1 kornel kornel 1125162 júl  9 08:48 po/uk.po
> 
> Was your ls above done in the build dir or the repo dir?

Repo.

> If it is in the repo dir, what does "git status" say for you?
> 
> I get:
> 
> $ ls -l po/uk.*
> -rw-rw-r-- 1 scott scott 1125162 Jul  9 06:08 po/uk.po
> $
> 
> > uk.gmo was not updated, I don't know, why 'git commit' removes it first. 
> > Maybe because
> > the diff is binary?

Ouch!!
# git status uk.po uk.gmo
On branch master
Your branch is up-to-date with 'origin/master'.

Untracked files:
  (use "git add ..." to include in what will be committed)

uk.gmo

I don't understand how it could happen
Please readd it. Maybe something was/is wrong on my file system. Today I had a 
crash on it,
so it is possible.

> I'm not sure. I ran 'make update-gmo' and committed at 4d0c29d5. The
> size of the gmo matches your size (from your ls output above) so I think
> it is correct. Sorry for the confusion. I will try to remember to update the 
> .gmo files
> whenever I update the po files.
> 
> Scott

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: [LyX/master] Amend f01ca45: uk.po: translation update from Yuri Chornoivan

[Scott Kostyshak]

On Wed, Jul 12, 2017 at 10:41:15AM +0200, Kornel Benko wrote:
> Am Mittwoch, 12. Juli 2017 um 04:22:39, schrieb Scott Kostyshak 
> 
> > On Sun, Jul 09, 2017 at 08:58:52AM +0200, Kornel Benko wrote:
> > > commit ca0ba098dafae01299a5eae567d541a6c7ba4cd8
> > > Author: Kornel Benko 
> > > Date:   Sun Jul 9 08:58:00 2017 +0200
> > > 
> > > Amend f01ca45: uk.po: translation update from Yuri Chornoivan
> > > ---
> > >  po/uk.gmo |  Bin 648018 -> 0 bytes
> > >  1 files changed, 0 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/po/uk.gmo b/po/uk.gmo
> > > deleted file mode 100644
> > > index d1fe4c8..000
> > > Binary files a/po/uk.gmo and /dev/null differ
> > 
> > Why should we remove the gmo? Because it is out-of-date, now that the po
> > was changed? Why not update the gmo instead of removing it? In general,
> > should I commit the gmo whenever I commit changes to the po?
> > 
> > Thanks,
> > 
> > Scott
> 
> ???
> #ls -l po/uk.*
>   -rw-r--r-- 1 kornel kornel  663380 júl 11 12:04 po/uk.gmo
>   -rw-r--r-- 1 kornel kornel 1125162 júl  9 08:48 po/uk.po

Was your ls above done in the build dir or the repo dir?
If it is in the repo dir, what does "git status" say for you?

I get:

$ ls -l po/uk.*
-rw-rw-r-- 1 scott scott 1125162 Jul  9 06:08 po/uk.po
$

> uk.gmo was not updated, I don't know, why 'git commit' removes it first. 
> Maybe because
> the diff is binary?

I'm not sure. I ran 'make update-gmo' and committed at 4d0c29d5. The
size of the gmo matches your size (from your ls output above) so I think
it is correct.

Sorry for the confusion. I will try to remember to update the .gmo files
whenever I update the po files.

Scott


signature.asc
Description: PGP signature

Re: [LyX/master] Amend f01ca45: uk.po: translation update from Yuri Chornoivan

[Kornel Benko]

Am Mittwoch, 12. Juli 2017 um 04:22:39, schrieb Scott Kostyshak 

> On Sun, Jul 09, 2017 at 08:58:52AM +0200, Kornel Benko wrote:
> > commit ca0ba098dafae01299a5eae567d541a6c7ba4cd8
> > Author: Kornel Benko 
> > Date:   Sun Jul 9 08:58:00 2017 +0200
> > 
> > Amend f01ca45: uk.po: translation update from Yuri Chornoivan
> > ---
> >  po/uk.gmo |  Bin 648018 -> 0 bytes
> >  1 files changed, 0 insertions(+), 0 deletions(-)
> > 
> > diff --git a/po/uk.gmo b/po/uk.gmo
> > deleted file mode 100644
> > index d1fe4c8..000
> > Binary files a/po/uk.gmo and /dev/null differ
> 
> Why should we remove the gmo? Because it is out-of-date, now that the po
> was changed? Why not update the gmo instead of removing it? In general,
> should I commit the gmo whenever I commit changes to the po?
> 
> Thanks,
> 
> Scott

???
#ls -l po/uk.*
-rw-r--r-- 1 kornel kornel  663380 júl 11 12:04 po/uk.gmo
-rw-r--r-- 1 kornel kornel 1125162 júl  9 08:48 po/uk.po

uk.gmo was not updated, I don't know, why 'git commit' removes it first. Maybe 
because
the diff is binary?


Kornel


signature.asc
Description: This is a digitally signed message part.

Re: [LyX/master] Amend f01ca45: uk.po: translation update from Yuri Chornoivan

[Scott Kostyshak]

On Sun, Jul 09, 2017 at 08:58:52AM +0200, Kornel Benko wrote:
> commit ca0ba098dafae01299a5eae567d541a6c7ba4cd8
> Author: Kornel Benko 
> Date:   Sun Jul 9 08:58:00 2017 +0200
> 
> Amend f01ca45: uk.po: translation update from Yuri Chornoivan
> ---
>  po/uk.gmo |  Bin 648018 -> 0 bytes
>  1 files changed, 0 insertions(+), 0 deletions(-)
> 
> diff --git a/po/uk.gmo b/po/uk.gmo
> deleted file mode 100644
> index d1fe4c8..000
> Binary files a/po/uk.gmo and /dev/null differ

Why should we remove the gmo? Because it is out-of-date, now that the po
was changed? Why not update the gmo instead of removing it? In general,
should I commit the gmo whenever I commit changes to the po?

Thanks,

Scott


signature.asc
Description: PGP signature